669 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
tudor	993822d769	Merge pull request 'fix: don’t portray special schools as failing the mainstream benchmark' (#70) from fix/special-schools-not-failing into main ... Reviewed-on: #70	2026-07-20 21:14:57 +00:00
TudorandClaude Opus 4.8	0b36eace9d	fix(review): accurate PRU/AP copy, unbundle same-school trend, de-dupe note CSS ... Three review points on the special-schools change: 1. Copy accuracy — the context note said "Its pupils have special educational needs" for every isSpecialSchool() match, but the helper also matches pupil referral units and alternative provision, whose pupils are educated outside a mainstream setting (e.g. after exclusion) and are not necessarily SEND. Extracted a shared <SpecialSchoolNote> with type-aware copy: SEND wording only for genuine special schools; PRUs/AP get their own accurate wording. 2. Same-school trend was conflated with the England comparison — SchoolRow's year-over-year trend arrow (and the school's own figure) were gated on the same flag that drops the vs-England delta, hiding a still-meaningful trend for special schools with real data. Split the two: the school's OWN RWM figure + trend show whenever there's a real value (special schools included; only a placeholder all-zero row is hidden); only the vs-England delta is additionally dropped for special/PRU/AP. Mirrored in SecondarySchoolRow (own Attainment 8 shown; only the vs-LA delta dropped). 3. De-duplicated the .specialNote CSS (was copy-pasted between the two detail view module files) into SpecialSchoolNote.module.css, owned by the shared component so it can't drift. New SpecialSchoolNote unit tests assert SEND wording for special schools and NOT for PRUs/AP. tsc clean; 112/112 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 22:09:32 +01:00
TudorandClaude Opus 4.8	de943ded19	fix(review): don't suppress a genuine mainstream 0 in the rows ... Review feedback: the rankings/search rows treated any exactly-0 attainment as not comparable regardless of school type, so a genuine 0 at a mainstream school rendered as "—" (looks like missing data) and dropped its delta — stricter and inconsistent with SchoolDetailView's placeholder check. - SchoolRow: match SchoolDetailView's ks2Placeholder signature — suppress only when ALL of RWM + reading + writing + maths are 0 (special/suppressed signature), not on a bare rwm === 0. A genuine 0% combined (some pupils met individual subjects but not all three) is not all-zero, so it stays comparable and shows its real figure + trend. - SecondarySchoolRow: Attainment 8 is a single 0–80 score with no subject breakdown to form an all-zero signature, so key off establishment type only (drop the bare att8 === 0 guard). A genuine (if extreme) 0.0 shows its value + LA delta. - For consistency, apply the same to the detail views: drop the bare attainment_8_score === 0 guard (KS4 keys off isSpecial only); KS2 keeps the all-four-subjects-zero placeholder signature. Special schools / PRUs / AP are still handled via isSpecialSchool everywhere. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 21:58:13 +01:00
TudorandClaude Opus 4.8	ae6ef6860b	fix: don't portray special schools as failing the mainstream benchmark ... Special schools, PRUs and alternative provision teach pupils with SEND who sit the same KS2/KS4 assessments but very few reach the mainstream "expected standard". Their headline attainment is therefore ~0% (or a very low Attainment 8), and the site was comparing that to the England average and painting it red — e.g. Greenmead School (a community special school) rendered as "0.0% — −62 pts below England average" with three 0% red SATs bars. That portrays a special school as catastrophically failing against a benchmark that doesn't fit it. Add a shared `isSpecialSchool()` helper (detects every DfE special-school establishment type — all contain "special" — plus PRUs / alternative provision) and drop the mainstream England comparison + "below" framing for these schools across every surface: - Detail (primary + secondary): a plain-English context note explaining the school is special and why the comparison isn't shown; England-average delta chips, "England avg" hints, the SATs national markers, the Attainment-8 "vs national" bar and the trend chart's England overlay are all suppressed. An all-zero placeholder SATs row hides the (empty) subject bar chart and the "why is combined lower" bridge. - Rankings / search rows (primary + secondary): the mainstream RWM / Attainment 8 stat shows "—" with no "vs national" delta, instead of "0% · −62 vs national". - Compare: special schools' attainment values are dropped (no misleading dot at 0% / no "Below England average" chip); progress banding, which IS a fair measure for special schools, is kept. Belt-and-braces zero-guard: a whole-row zero attainment (special or a suppressed cohort) is also treated as not-comparable, while a legitimate single 0 (e.g. 0% exceeding at a mainstream school) stays comparable. Tests: new isSpecialSchool unit tests (every DfE special type matched, no mainstream false positives); an e2e journey asserts Greenmead shows the special-school note and no England-average comparison. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 20:39:16 +01:00
tudor	4e316b4e38	Merge pull request 'fix(detail): label the phase of all-through admissions figures (Batch F review fix)' (#69) from fix/detail-allthrough-admissions-phase into main ... Reviewed-on: #69	2026-07-20 16:18:44 +00:00
TudorandClaude Opus 4.8	733faefb98	fix(detail): label which phase all-through admissions figures cover (Batch F) ... Final Ofsted/education-expert review of the detail page (Batch F) found one clarity gap: on an all-through school the Admissions block shows a single entry point's figures (Hessle's are the Year 7 secondary intake — admissions.school_phase = "Secondary") but is titled just "Admissions", so a parent interested in the reception/primary intake could read the Year 7 numbers as the whole school. Add a phase subtitle for all-through schools ("These figures are for secondary entry (Year 7)." / "...primary entry (Reception)."). Pure-primary and pure-secondary pages are unambiguous and unchanged. Rest of the review verified correct against source payloads: all three Ofsted regimes (report card / ungraded post-Sept-2024 / carried-forward), England- average anchoring, gap-honest trend charts (KS2 + KS4), all-through dual-phase rendering, and the mobile layout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 17:13:37 +01:00
tudor	5e370d09f1	Merge pull request 'fix(detail): render both phases for all-through schools (Batch E)' (#68) from fix/detail-all-through into main ... Reviewed-on: #68	2026-07-20 12:02:08 +00:00
TudorandClaude Opus 4.8	f6bb037c47	fix(detail): render both phases for all-through schools (Batch E) ... Batch E of applying the compare-screen learnings to the school detail page — all-through handling (point 11). An all-through school carries both KS2 and KS4 figures in the same yearly rows, but SchoolDetailView flipped it to isSecondary and rendered GCSE-only, hiding the entire primary phase (SATs, phonics, KS2 trend). The Results snapshot already gated its KS2/KS4 blocks purely on data availability, so both already appeared there — but the section title, the trend chart, phonics, the nav label and the history table all still assumed a single phase. - Add an explicit `isAllThrough` flag (+ `showPrimaryContent = isPrimary || isAllThrough`); pure-secondary behaviour is unchanged. - Hero: an "All-through (primary & secondary)" meta chip for all-ages framing. - Results section: title "SATs & GCSE Results", a combined subtitle, and "Primary — KS2 SATs (Year 6)" / "Secondary — GCSEs (Year 11)" sub-headings separating the two blocks. - Results Over Time: render two stacked PerformanceCharts (KS2 SATs + GCSEs) rather than crowding both stages' series — on different scales with different gap stories — onto one axis. Each gets its correct England overlay. - Phonics section + nav item now show for all-through (primary-stage metric). - History table: an all-through column set covering both phases (RWM, Exceeding, Attainment 8, Progress 8, Eng & Maths 4+). - Nav "Results" label for all-through instead of "GCSEs". e2e: a new journey asserts an all-through school (Hessle, 137306) shows both the KS2 and KS4 results and the All-through label, with a data-driven precondition skip if staging data drifts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:53:07 +01:00
tudor	9c93c3d9c2	Merge pull request 'fix(detail): gap-honest year axis on the detail-page trend charts (Batch D)' (#67) from fix/detail-chart-truthfulness into main ... Reviewed-on: #67	2026-07-20 11:42:48 +00:00
TudorandClaude Opus 4.8	17bd4d5a5e	fix(detail): gap-honest year axis on the detail-page trend charts (Batch D) ... Applies the compare screen's chart-truthfulness rules (spec §8.1) to the school detail page's time-series charts. PerformanceChart (Results Over Time, both phases): - Fill every academic year between the first and last data point via the shared fillAcademicYears helper, so cancelled/unpublished years (2019/20, 2020/21, and — for KS2 — 2021/22) render as real gaps instead of compressed time. Each series and the England overlay map onto this filled axis with null for missing years; spanGaps:false so school lines never bridge a gap. - Replace the primary-only COVID note with a distinct, honest gap caption: KS2 names the cancelled tests plus the unpublished 2021/22 school-level year; KS4 names the unpublished 2019/20–2020/21 GCSE grading years. - Mobile x-axis switches to autoSkip so the longer (gap-honest) axis stays readable; the broken line still marks a missing year even when its tick label is skipped. AdmissionsTrendChart: - Same gap-honest axis + spanGaps:false so a missing admissions year is a real gap, not compressed time. Point 12 (definite canvas heights): desktop is already a definite 280px; fix the secondary detail's mobile .chartContainer, which fixed the outer box at 220px and double-constrained PerformanceChart's own 220px canvas + chip strip (clipping the chips onto the plot) — now height:auto to match the primary view. SatsChart is out of scope (single-year per-subject CSS bars — no year axis, no canvas height to constrain). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:19:37 +01:00
tudor	31ae13451a	Merge pull request 'fix(detail): banded admissions + plain-English Progress 8 (Batch C)' (#66) from fix/detail-inclusion-admissions into main ... Reviewed-on: #66	2026-07-20 11:11:39 +00:00
TudorandClaude Fable 5	4e6be0ce65	fix(detail): banded first-choice interpretation + plain-English P8 absence copy ... Batch C (points 7-10): - Point 7: the admissions section shows the first-choice offer rate but no sense of how severe a low rate is. Reuse the compare screen's banded summariseAdmissions ('More than half of first choices missed out' etc.) as an interpretive line under the tiles. (Selective/faith framing was already present via admissionsTag.) - Point 8: replace the jargon P8-suspended banner ('not used for accountability purposes ... treat with caution') with the compare screen's plain-English 'no KS2 baseline (COVID)' explanation. - Points 9 (disadvantaged cohort sizes) and 10 (FSM benchmark) don't apply to the detail page: it shows disadvantaged composition, not disadvantaged attainment, and no FSM-vs-benchmark comparison — so there's no small-cohort caveat or cross-definition fallback to fix here. - Also fixed a stray lowercase 'national avg' provenance string Batch B missed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:03:23 +01:00
tudor	452ec77449	Merge pull request 'fix(detail): 'England average' provenance labelling (Batch B)' (#65) from fix/detail-provenance-anchoring into main ... Reviewed-on: #65	2026-07-20 07:52:55 +00:00
tudor	aa87fa917d	Merge pull request 'fix(detail): Ofsted sentinel codes, sixth form, carried-forward labels (Batch A)' (#64) from fix/detail-ofsted-correctness into main ... Reviewed-on: #64	2026-07-20 06:21:06 +00:00
TudorandClaude Fable 5	e36125b24a	fix(detail): label official DfE figures as 'England average' (provenance) ... Batch B (points 5-6): the detail page called every national figure a 'National avg'. All of them come from the official-DfE national-averages marts (KS2/KS4 headlines), so they are England averages — relabel to match the compare screen's provenance convention ('England average' for official figures; the detail page has no computed benchmarks, so no 'state-school average (computed)' label is needed). Point 6 (anchoring every number) is already satisfied on the detail page via DeltaChip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 07:19:22 +01:00
TudorandClaude Fable 5	fdda52ff0a	fix(detail): filter Ofsted sentinel codes, show sixth-form judgement, label carried-forward grades ... Batch A of applying compare-screen learnings to the detail page (points 2-3): - Point 2: the legacy OEIF sub-judgement grid rendered any non-null value via OFSTED_LABELS[value], so Ofsted's sentinel code 9 ('not applicable') leaked as an undefined label, and the sixth-form judgement was dropped entirely. New shared ofstedLegacyAreas() helper returns only real grades (1-4) and includes Sixth Form provision. Both detail views + the all-same-grade check use it. - Point 3: the OEIF disclaimer always claimed 'Ofsted no longer makes an overall judgement' even when showing a carried-forward grade. It's now grade_source-aware and labels carried-forward grades as such, matching the compare screen. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 07:15:33 +01:00
tudor	a2c63b3cda	Merge pull request 'fix(list/map): report-card schools badged as Report Card, not their old grade' (#63) from fix/list-map-report-card-signal into main ... Reviewed-on: #63	2026-07-18 20:28:19 +00:00
TudorandClaude Fable 5	b2b2cad5ac	test/docs: harden report-card list e2e + correct badge docstring ... Review fixes on the list/map report-card PR: - e2e precondition now hard-asserts ofsted_rc_date instead of test.skip, so the backend dropping the field fails loudly (that's the regression under test), not silently skips. - Use page_size=5 (the real backend param); per_page was ignored and fell back to the default page size. - Update buildOfstedListBadge docstring to describe the ofsted_rc_date-based, report-card-wins-first detection instead of the removed framework check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 21:24:09 +01:00
TudorandClaude Fable 5	5ec4f3f7cd	fix(list/map): badge report-card schools as Report Card, not their carried-forward grade ... The search-result cards and map pins keyed report-card detection off ofsted_framework === 'ReportCard', but the API sets ofsted_framework to the raw event grouping ('Schools - S5'); worse, ofsted_grade (the carried-forward legacy grade) was checked first and won. So report-card schools were badged by their old grade — Barclay's pin/card read 'Outstanding · 2021' instead of 'Report Card · 2026'. Same root cause as the detail-page fix, different surface. Expose ofsted_rc_date on the list serialization (the report-card inspection date, non-null only for report cards) and make both badge builders treat a present rc-date as winning over any grade, using its year. Removes the dead framework === 'ReportCard' branches. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 21:14:57 +01:00
tudor	74bdbebd57	Merge pull request 'fix(detail): render & correctly date Ofsted report cards' (#62) from fix/detail-report-card-render-date into main ... Reviewed-on: #62	2026-07-18 18:13:25 +00:00
TudorandClaude Fable 5	b31e71ac88	fix(detail): render report cards and date them by the report-card inspection ... The detail views detected report cards via ofsted.framework === 'ReportCard', but the API sets framework to the raw event grouping ('Schools - S5') even for report-card schools — so the check never matched: report-card schools rendered as legacy 'Ofsted Rating' badges dated to a pre-Nov-2025 inspection (e.g. Barclay shown as 'Outstanding, Inspected 7 October 2021' instead of its Feb 2026 report card). Detect report cards by the presence of the report_card object (matching the compare screen), and date them with rc_inspection_date, never the legacy inspection_date. Applies to both primary and secondary detail views. New e2e assertion against a real report-card school gates it. Note: the list/map surface has the same latent issue via ofsted_framework (LeafletMapInner) — flagged as a separate follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 19:09:16 +01:00
tudor	b05f3bebc7	Merge pull request 'fix(ci): promotion E2E-gate check uses Actions token, not REGISTRY_TOKEN (403)' (#61) from fix/promote-status-token into main ... Reviewed-on: #61	2026-07-18 15:25:28 +00:00
TudorandClaude Fable 5	ce422e6436	fix(ci): use the Actions token, not REGISTRY_TOKEN, to read the E2E commit status ... Promotion's 'Verify the staging E2E gate' step called the Gitea commit-status API with REGISTRY_TOKEN, which has container-registry scope but no repository scope — so the API returned 403 and promotion failed. Switch to the built-in GITHUB_TOKEN (repo read scope), matching how pr-checks.yml already authenticates to the Gitea API. REGISTRY_TOKEN is still used for the docker registry login, which is its correct scope. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 16:20:03 +01:00
tudor	2ac26acf91	Merge pull request 'style(compare): shorten Ofsted link text to 'Ofsted page'' (#60) from fix/ofsted-link-text into main ... Reviewed-on: #60	2026-07-18 14:20:09 +00:00
TudorandClaude Fable 5	3e77057567	style(compare): shorten Ofsted link text to 'Ofsted page' ... The link repeated the full school name ('Watford Grammar School for Boys's Ofsted page') — long on mobile, and the colour-coded school name already leads the row. Show just 'Ofsted page →'; keep the full name in aria-label so screen readers can still tell the per-school links apart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 15:19:41 +01:00
tudor	e0d5a9969e	Merge pull request 'style(compare): enlarge per-school name label in mobile section cards' (#59) from fix/mobile-cell-name-size into main ... Reviewed-on: #59	2026-07-18 14:09:02 +00:00
TudorandClaude Fable 5	dc21e80a5e	style(compare): enlarge the per-school name label in mobile section cards ... The colour-coded school name that leads each row in a mobile measure card was 0.8rem — a touch small to scan which school a value belongs to. Bump to 0.9rem (with a matching 10px dot) so it's easier to read. Mobile only; desktop uses the column header and hides this label. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 15:06:18 +01:00
tudor	6d3a203699	Merge pull request 'fix(compare): anchor grade-5 & EBacc rows; restore secondary-button outline' (#58) from fix/secondary-anchors-button-affordance into main ... Reviewed-on: #58	2026-07-18 07:29:51 +00:00
TudorandClaude Fable 5	b0c5b6bb57	fix(compare): anchor grade-5 & EBacc rows; restore secondary-button outline ... SF1 (expert sign-off): the secondary academics 'Grade 5+ in English & maths' and 'EBacc entry' rows rendered as bare numbers — the one place the 'every number anchored against the England average' promise broke. Both now show the official England anchor (already in the payload) + an Above/Close/Below verdict chip, matching Attainment 8 (which also gains a chip for consistency). Button affordance: globals.css has a duplicate .btn block whose 'border: none' overrode the base '1px solid transparent', so .btn-secondary/.btn-active's 'border-color' had no width — every outline button (the modal's '+ Compare', search-result '+ Compare', 'Comparing') rendered as borderless teal text. Give the outline variants the full 'border' shorthand so the outline renders regardless of the clobbered base. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 08:26:59 +01:00
tudor	a1128bd801	Merge pull request 'fix(compare): keep add-school sheet above the mobile keyboard (VisualViewport)' (#57) from fix/modal-keyboard-viewport into main ... Reviewed-on: #57	2026-07-18 07:09:03 +00:00
TudorandClaude Fable 5	2fd997bfe6	fix(compare): keep the add-school sheet above the on-screen keyboard ... The bottom-sheet overlay was position:fixed inset:0, sized to the LAYOUT viewport, so when the mobile keyboard opened it kept full height: the sheet (anchored to the overlay's bottom) and the lower half of the dim backdrop sat behind the keyboard, hiding the search input and results. Track window.visualViewport (height + offsetTop) while the modal is open and pin the overlay to the visible region, so backdrop and sheet stay above the keyboard. Size the sheet against the overlay (max-height:100%, min-height:min(55vh,100%)) instead of vh, and drop the results list's own inner scroll on mobile so the sheet is a single scroll area. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 08:00:31 +01:00
tudor	bdd9bef349	Merge pull request 'fix(compare): repair mobile add-school modal + re-apply stranded chart-height fix' (#56) from fix/mobile-compare-polish into main ... Reviewed-on: #56	2026-07-17 22:11:45 +00:00
TudorandClaude Fable 5	e5f7f4c959	fix(compare): repair the mobile add-school modal ... The 'add school' modal passed no title to Modal, so its header held only the close button — shoved to the far left by justify-content:space-between in an otherwise-empty bar — while the real title was rendered separately inside the content. Pass the title to Modal so the header reads title (left) + close (right), and drop the duplicate in-content heading. Also: the mobile full-width result button targeted a dead .addButton selector (the button never had that class), so it rendered inconsistently — give the button a real module class and full width on mobile, tighten the stacked cards, and give the bottom sheet a stable min-height so its empty state isn't a tiny stub. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 23:02:12 +01:00
TudorandClaude Fable 5	60918da483	fix(compare): give the trend chart its own definite canvas height so the gap note can't squash it ... The chart note (and the 2-row mobile chip legend) lived inside the fixed 360px/420px chartBox and competed with the canvas for it, so a longer caption — e.g. the new KS4 gap note — shrank the mobile canvas to ~178px and tripped the e2e >220px guard. The canvas now owns a definite height (280px mobile / 380px desktop) with chips above and the note flowing below at natural size, so neither can eat the plot. Verified on staging: patched canvas renders 280px vs the squashed 178px. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 22:58:35 +01:00
tudor	284215fbce	Merge pull request 'fix(compare): expert should-fixes S1-S4, S6 (S5/S7 closed by verification)' (#55) from fix/expert-signoff-shouldfixes into main ... Reviewed-on: #55	2026-07-17 17:53:16 +00:00
TudorandClaude Fable 5	200a97d0b9	fix(compare): per-school P8 explanation; disadvantaged cohort from the same yearly row ... Review findings: (1) the 'no KS2 baseline (COVID)' explanation was derived from the basket-wide max year, so a school with an unrelated data gap borrowed it from a neighbour with 2024/25 data — now judged per school on its own latest year. (2) The '~N disadvantaged pupils' cohort multiplied eligible_pupils and disadvantaged_pct resolved independently across years — now both come from the same yearly row that supplies the displayed percentage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 17:53:10 +01:00
TudorandClaude Fable 5	f3fa12806b	fix(compare): expert should-fixes S1-S4, S6 — banded chips, P8 reason, KS4 gap caption, all-through framing, cohort sizes ... S1: first-choice chip banded (More than half / About 1 in 3 / Over 1 in 4 missed out) so a 44%-offered grammar isn't understated by half. S2: Progress 8 explains its absence for 2024/25+ cohorts (no KS2 baseline, COVID) instead of a bare 'No data'. S3: KS4 trend charts get their own honest gap caption (2019/20-2020/21 unpublished; later years not in our dataset yet); y-axis 'Value'→'Score'; buildCompareChart exposes englandOnlyYears. S4: all-through schools labelled in chips, rail caption says 'N schools · <phase> view' for mixed baskets, whole-school roll no longer judged against the single-phase median, community section carries an all-ages caveat. S6 (spec §8.5): disadvantaged attainment shows the cohort behind it ('of ~50 disadvantaged pupils'). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 17:41:12 +01:00
tudor	1004f08daf	Merge pull request 'fix(pipeline): annual DAG never builds the official KS4 national mart' (#54) from fix/annual-dag-ks4-national-selector into main ... Reviewed-on: #54	2026-07-17 13:28:08 +00:00
TudorandClaude Fable 5	79246edc22	fix(pipeline): build stg_ees_ks4_national in the annual EES DAG ... The DAG's dbt --select list predates the official-KS4-nationals stream, so the extract loaded raw.ees_ks4_national but the staging model and fact_ks4_national_averages were never rebuilt — staging kept serving the old computed means after the DAG run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 14:15:11 +01:00
tudor	64b63b96c8	Merge pull request 'fix(compare): expert sign-off must-fixes M1-M3' (#53) from fix/expert-signoff-mustfixes into main ... Reviewed-on: #53	2026-07-17 12:02:55 +00:00
TudorandClaude Fable 5	5944d88f0b	fix(compare): expert sign-off must-fixes — phase-matched admissions, Ofsted sentinel codes, selective-school copy ... M1: admissions rounds are now selected by the active phase tab (admissionsForPhase) — an all-through school's Year 7 round no longer masquerades as Reception odds beside pure primaries; honest per-cell and section fallbacks name the round (Reception / Year 7). M2: Ofsted sentinel codes (9 = not applicable) never render as judgement chips, and the sixth-form judgement — previously dropped — now renders for schools that have one. M3: 'What this means' is phase- and type-aware: selective schools get entrance-test framing, secondary faith schools a faith-criteria note, and the primaries' distance template never appears on the secondary tab (admissions_policy now exposed in compare school_info). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 12:40:42 +01:00
tudor	163b501be6	Merge pull request 'fix(compare): stale-basket fetch blanking comparisons; rail caption' (#52) from fix/compare-final-review-mustfix into main ... Reviewed-on: #52	2026-07-17 06:28:27 +00:00
TudorandClaude Fable 5	80176cac4d	fix(compare): drop the merge-on-fetch — cancellation alone fixes the race ... Review finding: merging left a re-added school's old entry in the map forever, so the covered check served stale data and the map grew unboundedly. The cancelled flag already discards superseded responses, which is the actual race fix; replacing keeps the map bounded to the current selection and guarantees fresh refetches. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 07:27:10 +01:00
TudorandClaude Fable 5	84baf95f68	fix(compare): stale basket fetch no longer blanks a freshly opened comparison ... Opening a compare link while localStorage held a different basket raced a fetch for the OLD school set against the URL's SSR data; the stale response replaced comparisonData, so no active school had data and every section (including the trends chart) vanished until a hard refresh. Responses from superseded effect runs are now dropped, successful ones merge instead of replace, and the URL-seed effect re-runs when a client-side navigation changes ?urns=. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 07:16:04 +01:00
TudorandClaude Fable 5	99b769ca9e	feat(compare): fill the sticky bar's label rail with a comparison caption ... 'COMPARING / 3 primary schools' — 0.72rem uppercase eyebrow over a 0.95rem semibold count, sized to sit alongside the 0.92rem chip names without dominating. Desktop only; mobile pills unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 21:27:25 +01:00
tudor	e8f78a1598	Merge pull request 'fix(compare): align sticky school chips with their data columns on desktop' (#51) from fix/compare-final-review-mustfix into main ... Reviewed-on: #51	2026-07-16 20:10:45 +00:00
TudorandClaude Fable 5	8e0b730629	fix(compare): align sticky school chips with their data columns on desktop ... The bar was a plain flex row while sections use a 200px-label + per-school grid, so chips drifted off the columns they label. The bar now shares the sections' grid template (via --school-count) at the same 761px breakpoint; verified pixel-exact against live section columns (236/615/994). Mobile pills unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 21:05:16 +01:00
tudor	20a27f3958	Merge pull request 'fix(compare): five must-fix findings from the final expert review' (#50) from fix/compare-final-review-mustfix into main ... Reviewed-on: #50	2026-07-16 19:16:54 +00:00
TudorandClaude Fable 5	852ed11e4d	chore: untrack dbt build artifacts (target/, logs/, .user.yml) and gitignore them ... Swept in accidentally by a broad 'git add pipeline'. They embed local absolute paths and a personal usage-tracking UUID, and a stale committed manifest causes partial-parse/version-mismatch noise for others. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 20:09:10 +01:00
TudorandClaude Fable 5	77d7052662	docs(spec): re-verify the 2021/22 KS2 gap — expert finding refuted, footnote copy stands ... The final review claimed DfE published school-level 2021/22 KS2 in Dec 2022. Re-verified: the GOV.UK announcement 'Primary school performance tables: 2022' is CANCELLED ('will not be published in key stage 2 performance tables in academic year 2021/22'), and the EES 2021/22 release carries the same statement. No code change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 19:12:07 +01:00