In "How students do academically", Grade 5+ in English & maths and EBacc entry rendered as bare percentages — the only place the "every number anchored against the England average" promise broke. Both now show the official England anchor (already in the payload: 45.4% and 40.5%) plus an Above / Close to / Below England average verdict chip. Attainment 8 gains the same chip for consistency. This surfaces the decision-relevant gaps the expert flagged — e.g. Bishop Stopford's 10% EBacc entry vs the 40.5% national rate now reads "Below England average" instead of a bare 10%.
Button affordance (UX/UI finding)
The modal's "+ Compare" (and the same button in search results, plus "✓ Comparing") rendered as borderless teal text, not a button. Root cause: globals.css has a duplicate .btn block whose border: none overrides the base 1px solid transparent, so .btn-secondary / .btn-active's border-color had no width to show (computed border: 0px none). Gave the outline variants the full border shorthand so the outline renders regardless of the clobbered base — a targeted fix that leaves all button sizing untouched.
Tests: new CompareAcademics.test.tsx asserts the anchors + chips render; 101 frontend tests green.
Not included (expert minors, your call): conditionalise the P8 "banding" sentence when P8 is null; a "non-selective despite the name" note for Watford Grammar; count-chip grammar for Bishop Stopford's "sub-judgements only".
The two fast-follows from the final combined review.
## SF1 — anchor the grade-5 & EBacc rows (education expert should-fix)
In "How students do academically", **Grade 5+ in English & maths** and **EBacc entry** rendered as bare percentages — the only place the "every number anchored against the England average" promise broke. Both now show the official England anchor (already in the payload: 45.4% and 40.5%) plus an **Above / Close to / Below England average** verdict chip. Attainment 8 gains the same chip for consistency. This surfaces the decision-relevant gaps the expert flagged — e.g. Bishop Stopford's 10% EBacc entry vs the 40.5% national rate now reads "Below England average" instead of a bare 10%.
## Button affordance (UX/UI finding)
The modal's "+ Compare" (and the same button in search results, plus "✓ Comparing") rendered as borderless teal **text**, not a button. Root cause: globals.css has a duplicate `.btn` block whose `border: none` overrides the base `1px solid transparent`, so `.btn-secondary` / `.btn-active`'s `border-color` had no width to show (computed `border: 0px none`). Gave the outline variants the full `border` shorthand so the outline renders regardless of the clobbered base — a targeted fix that leaves all button sizing untouched.
Tests: new `CompareAcademics.test.tsx` asserts the anchors + chips render; 101 frontend tests green.
Not included (expert minors, your call): conditionalise the P8 "banding" sentence when P8 is null; a "non-selective despite the name" note for Watford Grammar; count-chip grammar for Bishop Stopford's "sub-judgements only".
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
SF1 (expert sign-off): the secondary academics 'Grade 5+ in English &
maths' and 'EBacc entry' rows rendered as bare numbers — the one place
the 'every number anchored against the England average' promise broke.
Both now show the official England anchor (already in the payload) + an
Above/Close/Below verdict chip, matching Attainment 8 (which also gains a
chip for consistency).
Button affordance: globals.css has a duplicate .btn block whose
'border: none' overrode the base '1px solid transparent', so
.btn-secondary/.btn-active's 'border-color' had no width — every outline
button (the modal's '+ Compare', search-result '+ Compare', 'Comparing')
rendered as borderless teal text. Give the outline variants the full
'border' shorthand so the outline renders regardless of the clobbered base.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
tudor
merged commit 6d3a203699 into main2026-07-18 07:29:51 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The two fast-follows from the final combined review.
SF1 — anchor the grade-5 & EBacc rows (education expert should-fix)
In "How students do academically", Grade 5+ in English & maths and EBacc entry rendered as bare percentages — the only place the "every number anchored against the England average" promise broke. Both now show the official England anchor (already in the payload: 45.4% and 40.5%) plus an Above / Close to / Below England average verdict chip. Attainment 8 gains the same chip for consistency. This surfaces the decision-relevant gaps the expert flagged — e.g. Bishop Stopford's 10% EBacc entry vs the 40.5% national rate now reads "Below England average" instead of a bare 10%.
Button affordance (UX/UI finding)
The modal's "+ Compare" (and the same button in search results, plus "✓ Comparing") rendered as borderless teal text, not a button. Root cause: globals.css has a duplicate
.btnblock whoseborder: noneoverrides the base1px solid transparent, so.btn-secondary/.btn-active'sborder-colorhad no width to show (computedborder: 0px none). Gave the outline variants the fullbordershorthand so the outline renders regardless of the clobbered base — a targeted fix that leaves all button sizing untouched.Tests: new
CompareAcademics.test.tsxasserts the anchors + chips render; 101 frontend tests green.Not included (expert minors, your call): conditionalise the P8 "banding" sentence when P8 is null; a "non-selective despite the name" note for Watford Grammar; count-chip grammar for Bishop Stopford's "sub-judgements only".
🤖 Generated with Claude Code
https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB