Batch F — final Ofsted/education-expert review of the school detail page (primary, secondary, all-through; desktop + mobile), verified against source API payloads.
Verdict: fit for production. No must-fixes.
Verified correct: all three Ofsted regimes (report card / ungraded post-Sept-2024 / carried-forward), England-average anchoring on every delta, gap-honest KS2 and KS4 trend charts, all-through dual-phase rendering, plain-English Progress-8 absence, and the 390px mobile layout.
Two changes in this PR
All-through admissions labelling (review should-fix): an all-through school's Admissions block shows a single entry point — Hessle's is the Year 7 secondary intake (admissions.school_phase="Secondary") — but was titled just "Admissions". Added a phase subtitle for all-through schools. Pure-primary/secondary unchanged.
e2e fix: the Batch E all-through journey (already on main via #68) asserted #results getByText('Attainment 8'), which collides with hidden MetricTooltip labels and failed the staging gate. Now asserts the unique visible sub-headings ("Primary — KS2 SATs" / "Secondary — GCSEs"). Merging this greens up main's staging gate.
tsc --noEmit clean; npm test 105/105; e2e 17/17 against staging.
Batch F — final Ofsted/education-expert review of the school detail page (primary, secondary, all-through; desktop + mobile), verified against source API payloads.
### Verdict: fit for production. No must-fixes.
**Verified correct:** all three Ofsted regimes (report card / ungraded post-Sept-2024 / carried-forward), England-average anchoring on every delta, gap-honest KS2 **and** KS4 trend charts, all-through dual-phase rendering, plain-English Progress-8 absence, and the 390px mobile layout.
### Two changes in this PR
1. **All-through admissions labelling (review should-fix):** an all-through school's Admissions block shows a single entry point — Hessle's is the **Year 7 secondary** intake (`admissions.school_phase="Secondary"`) — but was titled just "Admissions". Added a phase subtitle for all-through schools. Pure-primary/secondary unchanged.
2. **e2e fix:** the Batch E all-through journey (already on `main` via #68) asserted `#results getByText('Attainment 8')`, which collides with hidden MetricTooltip labels and failed the staging gate. Now asserts the unique visible sub-headings ("Primary — KS2 SATs" / "Secondary — GCSEs"). **Merging this greens up `main`'s staging gate.**
`tsc --noEmit` clean; `npm test` 105/105; e2e 17/17 against staging.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Final Ofsted/education-expert review of the detail page (Batch F) found one
clarity gap: on an all-through school the Admissions block shows a single
entry point's figures (Hessle's are the Year 7 secondary intake —
admissions.school_phase = "Secondary") but is titled just "Admissions", so a
parent interested in the reception/primary intake could read the Year 7
numbers as the whole school.
Add a phase subtitle for all-through schools ("These figures are for secondary
entry (Year 7)." / "...primary entry (Reception)."). Pure-primary and
pure-secondary pages are unambiguous and unchanged.
Rest of the review verified correct against source payloads: all three Ofsted
regimes (report card / ungraded post-Sept-2024 / carried-forward), England-
average anchoring, gap-honest trend charts (KS2 + KS4), all-through dual-phase
rendering, and the mobile layout.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
Adds a one-line clarifying subtitle to the admissions section for all-through schools, stating which entry phase (Reception vs Year 7) the displayed admissions figures cover. The logic correctly uses the existing 'Primary'/'Secondary' school_phase values from SchoolAdmissions, renders as plain text (no injection risk), and reuses an existing CSS class already defined in the stylesheet.
✅ No issues found.
## 🤖 AI Code Review (Claude Code)
Adds a one-line clarifying subtitle to the admissions section for all-through schools, stating which entry phase (Reception vs Year 7) the displayed admissions figures cover. The logic correctly uses the existing 'Primary'/'Secondary' school_phase values from SchoolAdmissions, renders as plain text (no injection risk), and reuses an existing CSS class already defined in the stylesheet.
✅ No issues found.
tudor
merged commit 4e316b4e38 into main2026-07-20 16:18:44 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Batch F — final Ofsted/education-expert review of the school detail page (primary, secondary, all-through; desktop + mobile), verified against source API payloads.
Verdict: fit for production. No must-fixes.
Verified correct: all three Ofsted regimes (report card / ungraded post-Sept-2024 / carried-forward), England-average anchoring on every delta, gap-honest KS2 and KS4 trend charts, all-through dual-phase rendering, plain-English Progress-8 absence, and the 390px mobile layout.
Two changes in this PR
admissions.school_phase="Secondary") — but was titled just "Admissions". Added a phase subtitle for all-through schools. Pure-primary/secondary unchanged.mainvia #68) asserted#results getByText('Attainment 8'), which collides with hidden MetricTooltip labels and failed the staging gate. Now asserts the unique visible sub-headings ("Primary — KS2 SATs" / "Secondary — GCSEs"). Merging this greens upmain's staging gate.tsc --noEmitclean;npm test105/105; e2e 17/17 against staging.🤖 Generated with Claude Code
Final Ofsted/education-expert review of the detail page (Batch F) found one clarity gap: on an all-through school the Admissions block shows a single entry point's figures (Hessle's are the Year 7 secondary intake — admissions.school_phase = "Secondary") but is titled just "Admissions", so a parent interested in the reception/primary intake could read the Year 7 numbers as the whole school. Add a phase subtitle for all-through schools ("These figures are for secondary entry (Year 7)." / "...primary entry (Reception)."). Pure-primary and pure-secondary pages are unambiguous and unchanged. Rest of the review verified correct against source payloads: all three Ofsted regimes (report card / ungraded post-Sept-2024 / carried-forward), England- average anchoring, gap-honest trend charts (KS2 + KS4), all-through dual-phase rendering, and the mobile layout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB🤖 AI Code Review (Claude Code)
Adds a one-line clarifying subtitle to the admissions section for all-through schools, stating which entry phase (Reception vs Year 7) the displayed admissions figures cover. The logic correctly uses the existing 'Primary'/'Secondary' school_phase values from SchoolAdmissions, renders as plain text (no injection risk), and reuses an existing CSS class already defined in the stylesheet.
✅ No issues found.