fix(school): drop the nearby section's lede, which repeated its heading #180
Open
tudor
wants to merge 1 commits from
fix/nearby-drop-lede into main
pull from: fix/nearby-drop-lede
merge into: tudor:main
tudor:main
tudor:fix/scheduled-dbt-selectors
tudor:fix/school-page-selective-flag
tudor:feat/header-facts-and-flags
tudor:fix/la-average-cached-failure
tudor:fix/search-row-facts
tudor:fix/header-nursery-and-gender
tudor:feat/phase-order-child-path
tudor:fix/desktop-clear-keeps-search
tudor:fix/modal-close-tap-target
tudor:feat/single-state-school-group
tudor:feat/school-type-groups-faith
tudor:fix/filter-options-not-from-results
tudor:feat/mobile-filter-sheet
tudor:fix/e2e-after-half-mile-default
tudor:fix/map-popup-view-button
tudor:fix/default-radius-half-mile
tudor:fix/toolbar-one-line
tudor:fix/phase-filter-exact-match
tudor:fix/phase-filter-global
tudor:fix/map-pane-header
tudor:feat/map-list-rows
tudor:fix/phone-toolbar-width
tudor:feat/results-map-view
tudor:feat/results-toolbar
tudor:feat/compare-limit-per-phase
tudor:copy/remove-em-dashes
tudor:fix/jump-sheet-under-bottom-bar
tudor:fix/nearby-journey-waits-for-smooth-scroll
tudor:fix/nearby-scroll-journey-clicks-offscreen-card
tudor:fix/nearby-schools-order-by-distance
tudor:feat/similar-schools-nearby
tudor:fix/release-check-diagnostics
tudor:feat/release-identity-and-reliability-gate
tudor:docs/current-truth-and-legacy-inventory
tudor:fix/og-image-route-group
tudor:feat/school-page-place-links
tudor:feat/about-blog-flags
tudor:fix/payload-import-map
tudor:fix/payload-initial-migration
tudor:feat/about-and-blog
tudor:fix/destinations-national-grain
tudor:fix/airflow-fixed-admin-password
tudor:feat/ks4-destinations
tudor:fix/dark-mode-map-popup-contrast
tudor:fix/distance-flag-off-absence-copy
tudor:fix/navigation-source-soft-nav
tudor:feat/place-school-attributes
tudor:feat/place-analytics
tudor:fix/mobile-hero-search
tudor:fix/suggest-reopens-over-results
tudor:fix/dark-map-fade
tudor:fix/hero-dropdown-clipping
tudor:feat/school-autosuggest
tudor:fix/flags-runbook
tudor:feat/feature-flags
tudor:fix/place-phase-links
tudor:feat/place-alphabetical-sort
tudor:fix/e2e-canonical-and-robots
tudor:feat/place-multiple-authorities
tudor:fix/place-table-alignment
tudor:fix/place-presentation-to-main
tudor:fix/place-title-brand-doubling
tudor:fix/place-page-presentation
tudor:fix/place-phase-variants
tudor:fix/locality-collision-skip
tudor:feat/w2-location-layer
tudor:feat/seo-metadata-c1
tudor:fix/sitemap-any-year-data
tudor:fix/staging-noindex
tudor:feat/seo-crawl-hygiene-main
tudor:feat/hero-artwork
tudor:fix/homepage-truth-and-rhythm-main
tudor:feat/brand-logo-artwork
tudor:fix/homepage-truth-and-rhythm
tudor:feat/schoolcompare-brand
tudor:feat/detail-gias-fields-remove-unwired
tudor:fix/special-schools-not-failing
tudor:fix/detail-allthrough-admissions-phase
tudor:fix/expert-signoff-shouldfixes
tudor:fix/gias-blank-name-codes
tudor:feat/compare-api-enrichment
tudor:feat/gias-code-dictionaries
tudor:feat/compare-chart-mobile-readability
tudor:feat/pr-comment-agent
1
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
ccfa44389e |
fix(school): drop the nearby section's lede, which repeated its heading
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m19s
PR Checks / Backend Smoke (pull_request) Successful in 10s
PR Checks / Build Backend (no push) (pull_request) Successful in 19s
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m32s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 1m18s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 14s
"Other schools nearby" was followed by "Other primary schools near <school>.", which says the same thing again. The heading now stands alone. nearbyNoun() and the phase and schoolName props existed only to build that line, so they go with it. Its bottom margin was the only gap between the heading and the cards, so the header row carries that gap now, and centres the heading against the carousel arrows now that it is a single line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> |