tudor/school_compare
1
0 Fork 0
Code Issues 2 Pull Requests 2 Actions Packages Projects Releases Wiki Activity

fix(school): drop the nearby section's lede, which repeated its heading #180

Open
tudor wants to merge 1 commits from fix/nearby-drop-lede into main
pull from: fix/nearby-drop-lede
merge into: tudor:main
Conversation 1 Commits 1 Files Changed 6
+18 -98
tudor commented 2026-10-03 20:10:53 +00:00
Owner
Copy link
Copy source

What

School pages no longer print a sentence under the "Other schools nearby" heading. It read "Other primary schools near .", which repeated the heading.

Changes

  • NearbySchoolsSection: the heading is now the whole header. nearbyNoun() and the phase and schoolName props existed only to build the sentence, so they are removed, along with their tests and the props at both call sites.
  • NearbySchools.module.css: the sentence's 1.25rem bottom margin was the only gap between the heading and the cards, so it moves to .top. With only the heading left in that row, .top now centres it against the carousel arrows instead of aligning to their top.
  • Comments that described the sentence are updated, and an old one about intake claims that no longer referred to anything is removed.

Verification

  • npm test: 72 suites, 621 tests pass.
  • npm run typecheck: clean.
  • Staging preview, made by removing the sentence in the browser and applying the same CSS on Allfarthing Primary School, not a deploy. At 1280px the cards sit 18px below the heading (the same gap as before) and the heading is centred on the arrows. At 390px nothing spills past the right edge.

No e2e journey checks the sentence, so none change. There is no new test that it stays gone, because that would only check wording.

🤖 Generated with Claude Code

## What School pages no longer print a sentence under the "Other schools nearby" heading. It read "Other primary schools near <school>.", which repeated the heading. ## Changes - `NearbySchoolsSection`: the heading is now the whole header. `nearbyNoun()` and the `phase` and `schoolName` props existed only to build the sentence, so they are removed, along with their tests and the props at both call sites. - `NearbySchools.module.css`: the sentence's 1.25rem bottom margin was the only gap between the heading and the cards, so it moves to `.top`. With only the heading left in that row, `.top` now centres it against the carousel arrows instead of aligning to their top. - Comments that described the sentence are updated, and an old one about intake claims that no longer referred to anything is removed. ## Verification - `npm test`: 72 suites, 621 tests pass. - `npm run typecheck`: clean. - Staging preview, made by removing the sentence in the browser and applying the same CSS on Allfarthing Primary School, not a deploy. At 1280px the cards sit 18px below the heading (the same gap as before) and the heading is centred on the arrows. At 390px nothing spills past the right edge. No e2e journey checks the sentence, so none change. There is no new test that it stays gone, because that would only check wording. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
tudor added 1 commit 2026-10-03 20:10:54 +00:00
fix(school): drop the nearby section's lede, which repeated its heading
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m19s
Details
PR Checks / Backend Smoke (pull_request) Successful in 10s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 19s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m32s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 1m18s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 14s
Details
ccfa44389e 
"Other schools nearby" was followed by "Other primary schools near
<school>.", which says the same thing again. The heading now stands alone.

nearbyNoun() and the phase and schoolName props existed only to build that
line, so they go with it. Its bottom margin was the only gap between the
heading and the cards, so the header row carries that gap now, and centres
the heading against the carousel arrows now that it is a single line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gitea-actions Bot commented 2026-10-03 20:15:47 +00:00
Copy link
Copy source

🤖 AI Code Review (Claude Code)

Removes the lede paragraph and the nearbyNoun helper from the nearby-schools section, along with the now-unused schoolName and phase props, and updates callers, CSS and tests. This is a consistent UI-only cleanup with no data or backend impact, and it looks healthy.

✅ No issues found.

## 🤖 AI Code Review (Claude Code) Removes the lede paragraph and the nearbyNoun helper from the nearby-schools section, along with the now-unused schoolName and phase props, and updates callers, CSS and tests. This is a consistent UI-only cleanup with no data or backend impact, and it looks healthy. ✅ No issues found.
All checks were successful
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m19s
Details
PR Checks / Backend Smoke (pull_request) Successful in 10s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 19s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m32s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 1m18s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 14s
Details
You are not authorized to merge this pull request.
This pull request can be merged automatically.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/nearby-drop-lede:fix/nearby-drop-lede
git checkout fix/nearby-drop-lede
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
tudor
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tudor/school_compare#180