tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(e2e): scroll detail-page chart into view before asserting #5

Merged
tudor merged 2 commits from fix/e2e-detail-chart-scroll into main 2026-07-03 13:56:00 +00:00
Conversation 1 Commits 2 Files Changed 1
+5 -2
tudor commented 2026-07-03 13:34:33 +00:00
Owner
Copy Link
Copy Source

The chart canvas renders below the fold and reads as hidden until scrolled to. 5/6 journeys already pass against staging — this fixes the last one so the pipeline can promote to prod.

🤖 Generated with Claude Code

https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL

The chart canvas renders below the fold and reads as hidden until scrolled to. 5/6 journeys already pass against staging — this fixes the last one so the pipeline can promote to prod. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL
tudor added 1 commit 2026-07-03 13:34:33 +00:00
fix(e2e): scroll the detail-page chart into view before asserting visibility
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m41s
Details
PR Checks / Backend Smoke (pull_request) Successful in 5s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 55s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 34s
Details
4ece55b031 
The canvas renders below the fold and stays 'hidden' to Playwright until
scrolled to; wait for attachment, scroll, then assert.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL
tudor added 1 commit 2026-07-03 13:40:16 +00:00
fix(e2e): assert on a visible canvas — the first canvas is hidden by design
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m41s
Details
PR Checks / Backend Smoke (pull_request) Successful in 5s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 47s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 26s
Details
deeef23131 
The admissions card stacks year/trend views in one grid cell and keeps the
inactive view visibility:hidden; its canvas is first in the DOM. Use
canvas:visible instead of scrolling. Verified: full suite passes against prod.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL
gitea-actions bot commented 2026-07-03 13:46:14 +00:00
Copy Link
Copy Source

🤖 AI Code Review (Claude Code)

This diff modifies a single Playwright e2e test to explicitly wait for the chart canvas to attach, scroll it into view, then assert visibility, replacing a bare visibility assertion that could fail on below-the-fold elements. The change is scoped to test code only and looks correct and low-risk.

✅ No issues found.

## 🤖 AI Code Review (Claude Code) This diff modifies a single Playwright e2e test to explicitly wait for the chart canvas to attach, scroll it into view, then assert visibility, replacing a bare visibility assertion that could fail on below-the-fold elements. The change is scoped to test code only and looks correct and low-risk. ✅ No issues found.
tudor merged commit 23b4e1c453 into main 2026-07-03 13:56:00 +00:00
tudor deleted branch fix/e2e-detail-chart-scroll 2026-07-03 13:56:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
tudor
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tudor/school_compare#5