tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'fix(e2e): scroll detail-page chart into view before asserting' (#5) from fix/e2e-detail-chart-scroll into main
Deploy (staging -> E2E gate -> production) / Build Backend (FastAPI) (push) Successful in 13s
Details
Deploy (staging -> E2E gate -> production) / Build Frontend (Next.js) (push) Successful in 49s
Details
Deploy (staging -> E2E gate -> production) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 12s
Details
Deploy (staging -> E2E gate -> production) / Deploy to Staging (push) Successful in 1s
Details
Deploy (staging -> E2E gate -> production) / E2E Journeys against Staging (push) Successful in 33s
Details
Deploy (staging -> E2E gate -> production) / Promote to Production (push) Successful in 8s
Details

Browse Source
This commit was merged in pull request #5.
This commit is contained in:
tudor
2026-07-03 13:56:00 +00:00
parent 515494dbf0 deeef23131
commit 23b4e1c453
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/tests/journeys.spec.ts
+5 -2
View File
@@ -43,8 +43,11 @@ test('school detail page renders name and performance data', async ({ page }) =>
await firstSchool.click();
await page.waitForURL(/\/school\//);
await expect(page.locator('h1').first()).toBeVisible();
// The detail page renders at least one chart canvas (performance history)
await expect(page.locator('canvas').first()).toBeVisible({ timeout: 15_000 });
// The detail page renders at least one *visible* chart canvas. Plain
// .first() is wrong here: the admissions card stacks its year/trend views
// in one grid cell and keeps the inactive view's canvas visibility:hidden
// by design, and that canvas comes first in the DOM.
await expect(page.locator('canvas:visible').first()).toBeVisible({ timeout: 15_000 });
});
test('comparing two schools shows both side by side', async ({ page }) => {