tudor/school_compare

fix(e2e): scroll detail-page chart into view before asserting #5

Merged

tudor merged 2 commits from fix/e2e-detail-chart-scroll into main

2026-07-03 13:56:00 +00:00

Author	SHA1	Message	Date
TudorandClaude Fable 5	deeef23131	fix(e2e): assert on a visible canvas — the first canvas is hidden by design PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m41s Details PR Checks / Backend Smoke (pull_request) Successful in 5s Details PR Checks / Build Backend (no push) (pull_request) Successful in 10s Details PR Checks / Build Frontend (no push) (pull_request) Successful in 47s Details PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s Details PR Checks / AI Code Review (Claude) (pull_request) Successful in 26s Details The admissions card stacks year/trend views in one grid cell and keeps the inactive view visibility:hidden; its canvas is first in the DOM. Use canvas:visible instead of scrolling. Verified: full suite passes against prod. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL	2026-07-03 14:40:13 +01:00
TudorandClaude Fable 5	4ece55b031	fix(e2e): scroll the detail-page chart into view before asserting visibility PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m41s Details PR Checks / Backend Smoke (pull_request) Successful in 5s Details PR Checks / Build Backend (no push) (pull_request) Successful in 10s Details PR Checks / Build Frontend (no push) (pull_request) Successful in 55s Details PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s Details PR Checks / AI Code Review (Claude) (pull_request) Successful in 34s Details The canvas renders below the fold and stays 'hidden' to Playwright until scrolled to; wait for attachment, scroll, then assert. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL	2026-07-03 14:34:17 +01:00