Merge pull request 'fix(e2e): scroll detail-page chart into view before asserting' (#5 ) from fix/e2e-detail-chart-scroll into main

fix(e2e): assert on a visible canvas — the first canvas is hidden by design
The admissions card stacks year/trend views in one grid cell and keeps the inactive view visibility:hidden; its canvas is first in the DOM. Use canvas:visible instead of scrolling. Verified: full suite passes against prod. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL
2026-07-03 13:56:00 +00:00 · 2026-07-03 14:40:13 +01:00 · 2026-07-03 14:34:17 +01:00
1 changed files with 5 additions and 2 deletions
@@ -43,8 +43,11 @@ test('school detail page renders name and performance data', async ({ page }) =>
  await firstSchool.click();
  await page.waitForURL(/\/school\//);
  await expect(page.locator('h1').first()).toBeVisible();
-  // The detail page renders at least one chart canvas (performance history)
+  // The detail page renders at least one *visible* chart canvas. Plain
-  await expect(page.locator('canvas').first()).toBeVisible({ timeout: 15_000 });
+  // .first() is wrong here: the admissions card stacks its year/trend views
  // in one grid cell and keeps the inactive view's canvas visibility:hidden
  // by design, and that canvas comes first in the DOM.
  await expect(page.locator('canvas:visible').first()).toBeVisible({ timeout: 15_000 });
 });
 test('comparing two schools shows both side by side', async ({ page }) => {
Author	SHA1	Message	Date
tudor	23b4e1c453	Merge pull request 'fix(e2e): scroll detail-page chart into view before asserting' (#5 ) from fix/e2e-detail-chart-scroll into main Deploy (staging -> E2E gate -> production) / Build Backend (FastAPI) (push) Successful in 13s Details Deploy (staging -> E2E gate -> production) / Build Frontend (Next.js) (push) Successful in 49s Details Deploy (staging -> E2E gate -> production) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 12s Details Deploy (staging -> E2E gate -> production) / Deploy to Staging (push) Successful in 1s Details Deploy (staging -> E2E gate -> production) / E2E Journeys against Staging (push) Successful in 33s Details Deploy (staging -> E2E gate -> production) / Promote to Production (push) Successful in 8s Details	2026-07-03 13:56:00 +00:00
TudorandClaude Fable 5	deeef23131	fix(e2e): assert on a visible canvas — the first canvas is hidden by design PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m41s Details PR Checks / Backend Smoke (pull_request) Successful in 5s Details PR Checks / Build Backend (no push) (pull_request) Successful in 10s Details PR Checks / Build Frontend (no push) (pull_request) Successful in 47s Details PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s Details PR Checks / AI Code Review (Claude) (pull_request) Successful in 26s Details The admissions card stacks year/trend views in one grid cell and keeps the inactive view visibility:hidden; its canvas is first in the DOM. Use canvas:visible instead of scrolling. Verified: full suite passes against prod. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL	2026-07-03 14:40:13 +01:00
TudorandClaude Fable 5	4ece55b031	fix(e2e): scroll the detail-page chart into view before asserting visibility PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m41s Details PR Checks / Backend Smoke (pull_request) Successful in 5s Details PR Checks / Build Backend (no push) (pull_request) Successful in 10s Details PR Checks / Build Frontend (no push) (pull_request) Successful in 55s Details PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s Details PR Checks / AI Code Review (Claude) (pull_request) Successful in 34s Details The canvas renders below the fold and stays 'hidden' to Playwright until scrolled to; wait for attachment, scroll, then assert. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL	2026-07-03 14:34:17 +01:00