PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m8s
PR Checks / Backend Smoke (pull_request) Successful in 7s
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
PR Checks / Build Frontend (no push) (pull_request) Successful in 46s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 2m1s
Special schools, PRUs and alternative provision teach pupils with SEND who sit the same KS2/KS4 assessments but very few reach the mainstream "expected standard". Their headline attainment is therefore ~0% (or a very low Attainment 8), and the site was comparing that to the England average and painting it red — e.g. Greenmead School (a community special school) rendered as "0.0% — −62 pts below England average" with three 0% red SATs bars. That portrays a special school as catastrophically failing against a benchmark that doesn't fit it. Add a shared `isSpecialSchool()` helper (detects every DfE special-school establishment type — all contain "special" — plus PRUs / alternative provision) and drop the mainstream England comparison + "below" framing for these schools across every surface: - Detail (primary + secondary): a plain-English context note explaining the school is special and why the comparison isn't shown; England-average delta chips, "England avg" hints, the SATs national markers, the Attainment-8 "vs national" bar and the trend chart's England overlay are all suppressed. An all-zero placeholder SATs row hides the (empty) subject bar chart and the "why is combined lower" bridge. - Rankings / search rows (primary + secondary): the mainstream RWM / Attainment 8 stat shows "—" with no "vs national" delta, instead of "0% · −62 vs national". - Compare: special schools' attainment values are dropped (no misleading dot at 0% / no "Below England average" chip); progress banding, which IS a fair measure for special schools, is kept. Belt-and-braces zero-guard: a whole-row zero attainment (special or a suppressed cohort) is also treated as not-comparable, while a legitimate single 0 (e.g. 0% exceeding at a mainstream school) stays comparable. Tests: new isSpecialSchool unit tests (every DfE special type matched, no mainstream false positives); an e2e journey asserts Greenmead shows the special-school note and no England-average comparison. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
182 lines
6.7 KiB
TypeScript
182 lines
6.7 KiB
TypeScript
/**
|
||
* SchoolRow Component
|
||
* Four-line row for primary school search results
|
||
*
|
||
* Line 1: School name · Ofsted badge (framework-aware)
|
||
* Line 2: School type · Age range · Denomination · Gender
|
||
* Line 3: Reading, Writing & Maths % · trend arrow · vs-national delta · Pupils
|
||
* Line 4: Local authority · Distance
|
||
*/
|
||
|
||
import type { School } from '@/lib/types';
|
||
import { formatPercentage, calculateTrend, getPhaseStyle, schoolUrl, buildOfstedListBadge, formatAgeRange, isProposedToClose, isSpecialSchool } from '@/lib/utils';
|
||
import styles from './SchoolRow.module.css';
|
||
|
||
interface SchoolRowProps {
|
||
school: School;
|
||
isLocationSearch?: boolean;
|
||
isInCompare?: boolean;
|
||
onAddToCompare?: (school: School) => void;
|
||
onRemoveFromCompare?: (urn: number) => void;
|
||
nationalAvgRwm?: number | null;
|
||
}
|
||
|
||
export function SchoolRow({
|
||
school,
|
||
isLocationSearch,
|
||
isInCompare = false,
|
||
onAddToCompare,
|
||
onRemoveFromCompare,
|
||
nationalAvgRwm,
|
||
}: SchoolRowProps) {
|
||
const trend = calculateTrend(school.rwm_expected_pct, school.prev_rwm_expected_pct);
|
||
const phase = getPhaseStyle(school.phase);
|
||
const ofstedBadge = buildOfstedListBadge(school);
|
||
|
||
const showGender = school.gender && school.gender.toLowerCase() !== 'mixed';
|
||
const showDenomination =
|
||
school.religious_denomination &&
|
||
school.religious_denomination !== 'Does not apply';
|
||
|
||
// Special schools / PRUs / AP: the mainstream RWM measure and its England
|
||
// comparison aren't a fair judgement (their pupils have SEND), so a "0% ·
|
||
// −62 vs national" row misrepresents them. Treat the mainstream stat as not
|
||
// comparable — same for a placeholder all-zero value.
|
||
const rwmComparable =
|
||
school.rwm_expected_pct != null &&
|
||
school.rwm_expected_pct !== 0 &&
|
||
!isSpecialSchool(school);
|
||
|
||
// vs-national delta
|
||
const rwmDelta =
|
||
rwmComparable && nationalAvgRwm != null
|
||
? Math.round((school.rwm_expected_pct as number) - nationalAvgRwm)
|
||
: null;
|
||
|
||
const handleCompareClick = () => {
|
||
if (isInCompare) {
|
||
onRemoveFromCompare?.(school.urn);
|
||
} else {
|
||
onAddToCompare?.(school);
|
||
}
|
||
};
|
||
|
||
return (
|
||
<div className={`${styles.row} ${phase.key ? styles[`phase${phase.key}`] : ''} ${isInCompare ? styles.rowInCompare : ''}`}>
|
||
{/* Left: four content lines */}
|
||
<div className={styles.rowContent}>
|
||
|
||
{/* Line 1: School name + Ofsted badge */}
|
||
<div className={styles.line1}>
|
||
<a href={schoolUrl(school.urn, school.school_name)} className={styles.schoolName}>
|
||
{school.school_name}
|
||
</a>
|
||
<span className={`${styles.ofstedBadge} ${styles[ofstedBadge.cssClass]}`}>
|
||
{ofstedBadge.label}
|
||
</span>
|
||
</div>
|
||
|
||
{/* Line 2: Context tags */}
|
||
<div className={styles.line2}>
|
||
{phase.label && (
|
||
<span className={`${styles.phaseLabel} ${styles[`phaseLabel${phase.key}`]}`}>
|
||
{phase.label}
|
||
</span>
|
||
)}
|
||
{school.school_type && <span className={styles.attr}>{school.school_type}</span>}
|
||
{school.age_range && <span className={styles.attr}>{formatAgeRange(school.age_range)}</span>}
|
||
{showDenomination && <span className={styles.attr}>{school.religious_denomination}</span>}
|
||
{showGender && <span className={styles.attr}>{school.gender}</span>}
|
||
{isProposedToClose(school) && (
|
||
<span className={`${styles.attr} ${styles.attrClosing}`}>⚠ Proposed to close</span>
|
||
)}
|
||
</div>
|
||
|
||
{/* Line 3: Key stats */}
|
||
<div className={styles.line3}>
|
||
<span className={styles.stat}>
|
||
<strong className={styles.statValue}>
|
||
{rwmComparable ? formatPercentage(school.rwm_expected_pct, 0) : '—'}
|
||
</strong>
|
||
{rwmComparable && school.prev_rwm_expected_pct != null && (
|
||
<span
|
||
className={`${styles.trend} ${styles[`trend${trend.charAt(0).toUpperCase() + trend.slice(1)}`]}`}
|
||
title={`Previous year: ${formatPercentage(school.prev_rwm_expected_pct)}`}
|
||
>
|
||
{trend === 'up' && (
|
||
<svg viewBox="0 0 16 16" fill="none" width="9" height="9" aria-label="Trend up">
|
||
<path d="M8 3L14 10H2L8 3Z" fill="currentColor" />
|
||
</svg>
|
||
)}
|
||
{trend === 'down' && (
|
||
<svg viewBox="0 0 16 16" fill="none" width="9" height="9" aria-label="Trend down">
|
||
<path d="M8 13L2 6H14L8 13Z" fill="currentColor" />
|
||
</svg>
|
||
)}
|
||
{trend === 'stable' && (
|
||
<svg viewBox="0 0 16 16" fill="none" width="9" height="9" aria-label="Trend stable">
|
||
<rect x="2" y="7" width="12" height="2" rx="1" fill="currentColor" />
|
||
</svg>
|
||
)}
|
||
</span>
|
||
)}
|
||
<span className={styles.statLabel}>Reading, Writing & Maths</span>
|
||
{rwmDelta != null && (
|
||
<span
|
||
className={
|
||
rwmDelta >= 2
|
||
? styles.vsNational
|
||
: rwmDelta <= -2
|
||
? styles.vsNationalNeg
|
||
: styles.vsNationalFlat
|
||
}
|
||
>
|
||
{rwmDelta >= 2
|
||
? `+${rwmDelta} pts vs national`
|
||
: rwmDelta <= -2
|
||
? `${rwmDelta} pts vs national`
|
||
: '≈ national avg'}
|
||
</span>
|
||
)}
|
||
</span>
|
||
|
||
{school.total_pupils != null && (
|
||
<span className={styles.stat}>
|
||
<strong className={styles.statValue}>{school.total_pupils.toLocaleString()}</strong>
|
||
<span className={styles.statLabel}>pupils</span>
|
||
</span>
|
||
)}
|
||
</div>
|
||
|
||
{/* Line 4: Location + distance */}
|
||
<div className={styles.line4}>
|
||
{school.local_authority && (
|
||
<span>{school.local_authority}</span>
|
||
)}
|
||
{isLocationSearch && school.distance != null && (
|
||
<span className={styles.distanceBadge}>
|
||
{school.distance.toFixed(1)} mi
|
||
</span>
|
||
)}
|
||
</div>
|
||
|
||
</div>
|
||
|
||
{/* Right: actions, vertically centred */}
|
||
<div className={styles.rowActions}>
|
||
<a href={schoolUrl(school.urn, school.school_name)} className="btn btn-tertiary btn-sm">
|
||
View
|
||
</a>
|
||
{(onAddToCompare || onRemoveFromCompare) && (
|
||
<button
|
||
onClick={handleCompareClick}
|
||
className={isInCompare ? 'btn btn-active btn-sm' : 'btn btn-secondary btn-sm'}
|
||
>
|
||
{isInCompare ? '✓ Comparing' : '+ Compare'}
|
||
</button>
|
||
)}
|
||
</div>
|
||
</div>
|
||
);
|
||
}
|