PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m15s
PR Checks / Backend Smoke (pull_request) Successful in 9s
PR Checks / Build Backend (no push) (pull_request) Successful in 20s
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m21s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 12s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m39s
Both features ship dark. Neither is reachable in an environment where its flag is off, and every flag in this system starts off, so a deploy of this commit makes both disappear until someone turns them on deliberately. Two independent flags rather than one, which makes blog-on-about-off a reachable state. That state is the whole reason the change is larger than four notFound() calls: the blog leans on the About page for its author identity. The Person entity is anchored at /about#tudor, and that URL 404s while about_page is dark, so a post published in that state would claim an author resolving to nothing. Worse than having no named author. Both bylines fall back to unlinked text and the BlogPosting attributes to the publisher instead, so every combination of the two flags renders something correct. Gated: /about, /blog, /blog/[slug], the RSS feed, both footer links, and the matching content-sitemap entries. A sitemap must never advertise a URL that 404s. With both dark it emits a valid empty urlset rather than a 404, because robots.txt names it unconditionally. Not gated: /admin. Posts have to be writable before the blog is worth switching on, so flagging the panel would make the flag unflippable. getFlags takes a revalidate rather than always using the 300s constant. Reading a flag pins the calling route to the lowest revalidate among its fetches, and the footer links live in the root layout, so a naive gate there would have dropped every school and place page from a weekly cache to a 5-minute one. The layout passes 604800, the floor those routes already declare, and the build confirms all four SSG route families still prerender. The cost is one-way latency: pages follow a flip in minutes, footer links within a week. The e2e journeys follow the existing paired shape from the admission_distance flag: a lit journey and a dark one for each flag, reading state from whether /about and /blog respond rather than from /api/flags, which another journey asserts is not publicly reachable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXnXQKnPpZBBP61fBQiFkq
91 lines
2.7 KiB
TypeScript
91 lines
2.7 KiB
TypeScript
import { SITE_URL, absoluteUrl } from '@/lib/site';
|
|
|
|
/**
|
|
* The site's author entity.
|
|
*
|
|
* First name only, by choice — see /about. That makes this a weaker search
|
|
* signal than a fully identified author would be, which is why the About page
|
|
* carries a substantial methodology section: the credibility has to come from
|
|
* stated provenance rather than from a corroborable identity.
|
|
*
|
|
* Everything that needs an author — the About page, every post byline —
|
|
* references this one shape, so search engines resolve them all to one entity.
|
|
*/
|
|
export function personJsonLd() {
|
|
return {
|
|
'@type': 'Person',
|
|
'@id': `${SITE_URL}/about#tudor`,
|
|
name: 'Tudor',
|
|
url: absoluteUrl('/about'),
|
|
image: absoluteUrl('/brand/tudor.jpg'),
|
|
description:
|
|
'Parent in south-west London who built schoolcompare while looking for a primary school.',
|
|
} as const;
|
|
}
|
|
|
|
export function organizationJsonLd() {
|
|
return {
|
|
'@type': 'Organization',
|
|
'@id': `${SITE_URL}#organization`,
|
|
name: 'schoolcompare',
|
|
url: SITE_URL,
|
|
logo: absoluteUrl('/icon-512.png'),
|
|
} as const;
|
|
}
|
|
|
|
interface PostSummary {
|
|
title: string;
|
|
slug: string;
|
|
excerpt: string;
|
|
publishedAt: string;
|
|
}
|
|
|
|
/**
|
|
* References the Person and Organization by @id rather than repeating them, so
|
|
* search engines resolve every post and the About page to the one author
|
|
* entity. Repeating the shape would declare several people with one name.
|
|
*
|
|
* `namedAuthor` is the about_page flag. The Person entity is anchored at
|
|
* /about#tudor, and that URL 404s while the flag is dark, so a post published
|
|
* in that state must not claim it: an author @id resolving to nothing is a
|
|
* worse signal than no named author. It falls back to the publisher, which is
|
|
* always live. The parameter is required rather than defaulted because every
|
|
* call site has the flag to hand and the wrong default is silent.
|
|
*/
|
|
export function blogPostingJsonLd(
|
|
post: PostSummary,
|
|
{ namedAuthor }: { namedAuthor: boolean },
|
|
) {
|
|
return {
|
|
'@type': 'BlogPosting',
|
|
headline: post.title,
|
|
description: post.excerpt,
|
|
url: absoluteUrl(`/blog/${post.slug}`),
|
|
datePublished: post.publishedAt,
|
|
author: {
|
|
'@id': namedAuthor ? `${SITE_URL}/about#tudor` : `${SITE_URL}#organization`,
|
|
},
|
|
publisher: { '@id': `${SITE_URL}#organization` },
|
|
} as const;
|
|
}
|
|
|
|
export function breadcrumbJsonLd(post: PostSummary) {
|
|
return {
|
|
'@type': 'BreadcrumbList',
|
|
itemListElement: [
|
|
{
|
|
'@type': 'ListItem',
|
|
position: 1,
|
|
name: 'Blog',
|
|
item: absoluteUrl('/blog'),
|
|
},
|
|
{
|
|
'@type': 'ListItem',
|
|
position: 2,
|
|
name: post.title,
|
|
item: absoluteUrl(`/blog/${post.slug}`),
|
|
},
|
|
],
|
|
} as const;
|
|
}
|