TudorandClaude Fable 5
6c872ce726
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m36s
PR Checks / Backend Smoke (pull_request) Successful in 5s
PR Checks / Build Backend (no push) (pull_request) Successful in 20s
PR Checks / Build Frontend (no push) (pull_request) Successful in 52s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m44s
The rankings endpoint validated year with le=2100, but the database stores academic-year codes like 201819, so any explicit year selection returned a 422 and the rankings page rendered its empty state. Widen the bound to cover the codes and extend the e2e journey to pick a specific year and assert the table stays populated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
94 lines
4.0 KiB
TypeScript
94 lines
4.0 KiB
TypeScript
import { test, expect, Page } from '@playwright/test';
|
|
|
|
/**
|
|
* Journey tests for SchoolCompare, run against the staging environment as the
|
|
* gate before promotion to production. They assert stable data invariants
|
|
* (results exist, key UI renders) rather than exact numbers, so routine data
|
|
* refreshes don't break the pipeline.
|
|
*/
|
|
|
|
async function searchByName(page: Page, query: string) {
|
|
await page.goto('/');
|
|
const searchInput = page.getByPlaceholder('School name or postcode').first();
|
|
await searchInput.fill(query);
|
|
await searchInput.press('Enter');
|
|
await page.waitForURL(/search=|postcode=/);
|
|
}
|
|
|
|
function schoolLinks(page: Page) {
|
|
return page.locator('a[href^="/school/"]');
|
|
}
|
|
|
|
test('home page loads with hero search', async ({ page }) => {
|
|
await page.goto('/');
|
|
await expect(page.locator('h1').first()).toBeVisible();
|
|
await expect(page.getByPlaceholder('School name or postcode').first()).toBeVisible();
|
|
});
|
|
|
|
test('searching by name returns school results', async ({ page }) => {
|
|
await searchByName(page, 'primary');
|
|
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
|
expect(await schoolLinks(page).count()).toBeGreaterThan(1);
|
|
});
|
|
|
|
test('searching by postcode returns nearby schools', async ({ page }) => {
|
|
await searchByName(page, 'B1 1BB');
|
|
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
|
});
|
|
|
|
test('school detail page renders name and performance data', async ({ page }) => {
|
|
await searchByName(page, 'primary');
|
|
const firstSchool = schoolLinks(page).first();
|
|
await expect(firstSchool).toBeVisible({ timeout: 15_000 });
|
|
await firstSchool.click();
|
|
await page.waitForURL(/\/school\//);
|
|
await expect(page.locator('h1').first()).toBeVisible();
|
|
// The detail page renders at least one *visible* chart canvas. Plain
|
|
// .first() is wrong here: the admissions card stacks its year/trend views
|
|
// in one grid cell and keeps the inactive view's canvas visibility:hidden
|
|
// by design, and that canvas comes first in the DOM.
|
|
await expect(page.locator('canvas:visible').first()).toBeVisible({ timeout: 15_000 });
|
|
});
|
|
|
|
test('comparing two schools shows both side by side', async ({ page }) => {
|
|
// Collect two school URNs from search results, then load the share URL
|
|
await searchByName(page, 'primary');
|
|
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
|
const hrefs = await schoolLinks(page).evaluateAll((links) =>
|
|
links.map((l) => (l as HTMLAnchorElement).getAttribute('href') || '')
|
|
);
|
|
const urns = [...new Set(hrefs.map((h) => h.match(/\/school\/(\d+)/)?.[1]).filter(Boolean))];
|
|
expect(urns.length).toBeGreaterThanOrEqual(2);
|
|
|
|
await page.goto(`/compare?urns=${urns[0]},${urns[1]}`);
|
|
// Both schools' detail links should render in the comparison view
|
|
await expect(page.locator(`a[href*="${urns[0]}"]`).first()).toBeVisible({ timeout: 15_000 });
|
|
await expect(page.locator(`a[href*="${urns[1]}"]`).first()).toBeVisible();
|
|
});
|
|
|
|
test('rankings page loads a populated table', async ({ page }) => {
|
|
await page.goto('/rankings');
|
|
await expect(page.getByRole('heading', { name: /rankings/i }).first()).toBeVisible();
|
|
const rows = page.locator('table tbody tr');
|
|
await expect(rows.first()).toBeVisible({ timeout: 15_000 });
|
|
expect(await rows.count()).toBeGreaterThan(5);
|
|
});
|
|
|
|
test('rankings stay populated after picking a specific year', async ({ page }) => {
|
|
// Years are academic-year codes (e.g. 201819); the API must accept them
|
|
// as the `year` query param rather than rejecting with a 422.
|
|
await page.goto('/rankings');
|
|
const yearSelect = page.locator('#year-select');
|
|
await expect(yearSelect).toBeVisible({ timeout: 15_000 });
|
|
|
|
// Pick the first explicit year option (index 0 is the "Latest" default).
|
|
const yearValue = await yearSelect.locator('option').nth(1).getAttribute('value');
|
|
expect(yearValue).toBeTruthy();
|
|
await yearSelect.selectOption(yearValue!);
|
|
await page.waitForURL(/year=/);
|
|
|
|
const rows = page.locator('table tbody tr');
|
|
await expect(rows.first()).toBeVisible({ timeout: 15_000 });
|
|
expect(await rows.count()).toBeGreaterThan(5);
|
|
});
|