Follow-up to the GIAS detail-fields PR (already merged).
Changes
Religious character moved out of the identity chips into the labelled header details, next to County / Constituency: Religious character: <denomination> ("None" for the Does not apply / None values).
Mobile/tablet (≤768px): the header-details block — previously hidden outright on the primary view and merely stacked on the secondary view — is now collapsed behind a "Show all details ▾" toggle that reveals the full block (headteacher, website, pupils, trust, phone, religious character, county, constituency) and flips to "Hide details ▴". Desktop is unchanged (details always shown, toggle hidden).
Applied to both the primary and secondary detail views for parity.
Verification
Frontend tsc --noEmit: clean
Frontend jest: 112/112 pass
E2E: added a mobile-viewport test asserting the details start hidden, the toggle is visible, and clicking reveals them (flips to "Hide details"). Specs compile via playwright test --list; run against staging in CI.
Follow-up to the GIAS detail-fields PR (already merged).
### Changes
- **Religious character** moved out of the identity chips into the labelled header details, next to County / Constituency: `Religious character: <denomination>` ("None" for the *Does not apply* / *None* values).
- **Mobile/tablet (≤768px):** the header-details block — previously hidden outright on the primary view and merely stacked on the secondary view — is now collapsed behind a **"Show all details ▾"** toggle that reveals the full block (headteacher, website, pupils, trust, phone, religious character, county, constituency) and flips to **"Hide details ▴"**. Desktop is unchanged (details always shown, toggle hidden).
- Applied to **both** the primary and secondary detail views for parity.
### Verification
- Frontend `tsc --noEmit`: clean
- Frontend jest: 112/112 pass
- E2E: added a mobile-viewport test asserting the details start hidden, the toggle is visible, and clicking reveals them (flips to "Hide details"). Specs compile via `playwright test --list`; run against staging in CI.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Religious character now sits with the other labelled header details (near
County / Constituency) as "Religious character: <denomination>" ("None" for
Does not apply / None), instead of as an identity chip.
On mobile/tablet (≤768px) the header details block was hidden outright; it's
now collapsed behind a "Show all details" toggle that reveals the full block
(headteacher, website, pupils, trust, phone, religious character, county,
constituency). Applied to both the primary and secondary detail views for
parity. Extends the e2e journey with the mobile toggle behaviour.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This PR adds a mobile/tablet 'Show all details' toggle that collapses secondary header info (headteacher, contact, trust, area) behind a disclosure button, and relocates the religious character badge from the always-visible meta row into this collapsible details block for both SchoolDetailView and SecondarySchoolDetailView. The implementation is consistent across both components (matching CSS override order, correct aria-expanded/aria-controls wiring, no SSR/hydration issues), and the two view components are rendered mutually exclusively so the duplicated DOM id is not a practical conflict.
🟡 Minor
e2e/tests/journeys.spec.ts: The new e2e test only exercises the toggle on SchoolDetailView (primary schools); SecondarySchoolDetailView got the identical feature but has no corresponding test, leaving a coverage gap for that view.
## 🤖 AI Code Review (Claude Code)
This PR adds a mobile/tablet 'Show all details' toggle that collapses secondary header info (headteacher, contact, trust, area) behind a disclosure button, and relocates the religious character badge from the always-visible meta row into this collapsible details block for both SchoolDetailView and SecondarySchoolDetailView. The implementation is consistent across both components (matching CSS override order, correct aria-expanded/aria-controls wiring, no SSR/hydration issues), and the two view components are rendered mutually exclusively so the duplicated DOM id is not a practical conflict.
### 🟡 Minor
- **e2e/tests/journeys.spec.ts**: The new e2e test only exercises the toggle on SchoolDetailView (primary schools); SecondarySchoolDetailView got the identical feature but has no corresponding test, leaving a coverage gap for that view.
tudor
merged commit cab7b4fe91 into main2026-07-24 12:15:14 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Follow-up to the GIAS detail-fields PR (already merged).
Changes
Religious character: <denomination>("None" for the Does not apply / None values).Verification
tsc --noEmit: cleanplaywright test --list; run against staging in CI.🤖 Generated with Claude Code
Religious character now sits with the other labelled header details (near County / Constituency) as "Religious character: <denomination>" ("None" for Does not apply / None), instead of as an identity chip. On mobile/tablet (≤768px) the header details block was hidden outright; it's now collapsed behind a "Show all details" toggle that reveals the full block (headteacher, website, pupils, trust, phone, religious character, county, constituency). Applied to both the primary and secondary detail views for parity. Extends the e2e journey with the mobile toggle behaviour. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>🤖 AI Code Review (Claude Code)
This PR adds a mobile/tablet 'Show all details' toggle that collapses secondary header info (headteacher, contact, trust, area) behind a disclosure button, and relocates the religious character badge from the always-visible meta row into this collapsible details block for both SchoolDetailView and SecondarySchoolDetailView. The implementation is consistent across both components (matching CSS override order, correct aria-expanded/aria-controls wiring, no SSR/hydration issues), and the two view components are rendered mutually exclusively so the duplicated DOM id is not a practical conflict.
🟡 Minor