fix(e2e): pick the latest explicit year in the rankings year test #8

Merged
tudor merged 1 commits from fix/e2e-rankings-year-pick into main 2026-07-05 13:54:55 +00:00
Owner

The staging E2E gate failed because the new rankings-year journey picked the oldest year in the dropdown (201516), and staging does not carry the full data history — the empty table was legitimate, not the regression.

Select the last option (most recent explicit year) instead. The default view already proved that year has rows, so an empty table after selecting it can only mean the year query param was rejected — which is the 422 regression this test guards.

🤖 Generated with Claude Code

The staging E2E gate failed because the new rankings-year journey picked the oldest year in the dropdown (201516), and staging does not carry the full data history — the empty table was legitimate, not the regression. Select the last option (most recent explicit year) instead. The default view already proved that year has rows, so an empty table after selecting it can only mean the year query param was rejected — which is the 422 regression this test guards. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
tudor added 1 commit 2026-07-05 13:29:56 +00:00
fix(e2e): pick the latest explicit year in the rankings year test
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m39s
PR Checks / Backend Smoke (pull_request) Successful in 5s
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
PR Checks / Build Frontend (no push) (pull_request) Successful in 41s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 9s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m24s
acec8135e1
Staging doesn't always carry the full data history, so selecting the
oldest year legitimately returns no rows and fails the promotion gate.
Select the most recent explicit year instead: the default view already
proved it has rows, so an empty table after selecting it can only mean
the year query param was rejected — the regression this test guards.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

🤖 AI Code Review (Claude Code)

This diff fixes an e2e test that selects a year from the rankings year dropdown before asserting the table repopulates. It switches from picking option index 1 (the first explicit year) to the last option (the most recent explicit year), since the backend sorts filter years ascending and staging may not carry the full year history for the oldest year.

No issues found.

## 🤖 AI Code Review (Claude Code) This diff fixes an e2e test that selects a year from the rankings year dropdown before asserting the table repopulates. It switches from picking option index 1 (the first explicit year) to the last option (the most recent explicit year), since the backend sorts filter years ascending and staging may not carry the full year history for the oldest year. ✅ No issues found.
tudor merged commit ff606dad71 into main 2026-07-05 13:54:55 +00:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tudor/school_compare#8