tudor/school_compare

fix(api): school detail 500s for schools with no performance rows #20

Merged

tudor merged 2 commits from fix/school-detail-nan-500 into main

2026-07-07 08:56:23 +00:00

Author	SHA1	Message	Date
TudorandClaude Opus 4.8	536832a524	chore: drop committed .pyc files, ignore __pycache__ everywhere PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m37s Details PR Checks / Backend Smoke (pull_request) Successful in 6s Details PR Checks / Build Backend (no push) (pull_request) Successful in 29s Details PR Checks / Build Frontend (no push) (pull_request) Successful in 42s Details PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s Details PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m54s Details Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-07 09:37:17 +01:00
TudorandClaude Opus 4.8	87642b7b06	fix(api): serialize schools that have no performance rows PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m39s Details PR Checks / Backend Smoke (pull_request) Successful in 8s Details PR Checks / Build Backend (no push) (pull_request) Successful in 30s Details PR Checks / Build Frontend (no push) (pull_request) Successful in 42s Details PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s Details PR Checks / AI Code Review (Claude) (pull_request) Successful in 2m0s Details Schools without KS2/KS4 results (special post-16 institutions, sixth-form centres, PRUs, new schools) come back from the marts LEFT JOIN with NaN in every numeric column. school_info passed those raw pandas values straight into JSONResponse, which renders with allow_nan=False, so the detail endpoint 500d and the frontend turned that into a 404 on every such SEO landing page. Run school_info values through convert_to_native (the same treatment yearly_data already gets), add backend unit tests plus a pytest step in PR checks, and an e2e journey that finds a results-less school via the search API and asserts its page renders. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-07 09:22:54 +01:00