fix(search): tag only what the register records, and count the whole school #176

Merged

tudor merged 3 commits from fix/search-row-facts into main 2026-10-02 22:05:56 +00:00

Conversation 1 Commits 3 Files Changed 13

+295 -30

3 Commits

Author	SHA1	Message	Date
TudorandClaude Opus 5.5	8020191832	test(e2e): journeys for row tags and pupil counts, and ask for page_size ... Three journeys pin the fixes: a non-selective secondary's row has no Selective tag, a school recorded with no religious character has no faith tag, and the list and the school page agree on a secondary's pupil count. Run against staging before the fix, all three fail. The list API reads page_size. Nine journeys asked for per_page, which it ignores, so each got the default 25 rows whatever it asked for. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 22:51:31 +01:00
TudorandClaude Opus 5.5	5f9caad7f4	fix: count pupils as the whole school, not the GCSE year group ... fact_performance's total_pupils is the cohort a year's results were measured on. For a secondary that is Year 11 alone, and the list API sent it as the card's "pupils": Burntwood showed 245 in search and 1,462 on its page. The list and place payloads now carry the register's whole-school count, and nothing when the register has none. Map popups and the compare basket read the same field. The header and the wellbeing section fell back to the same results figure when the census had no record. They now fall back to the register count. The shell took yearlyData only for that fallback, so the prop is gone and the results array no longer ships to the client for the chrome. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 22:51:31 +01:00
TudorandClaude Opus 5.5	e65c93b68e	fix(search): tag only what the register records ... The secondary row tested the admissions policy with includes('selective'), which "Non-selective" passes, so every comprehensive (Burntwood, Graveney) was tagged Selective. It now needs an exact "Selective". Both rows excluded only "Does not apply" from the religious character, so a school recorded as "None" got "Faith priority" (Putney High) or a bare "None" chip (Abacus Belsize Primary). hasReligiousCharacter() treats both of the register's no-faith values as no faith. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 22:50:44 +01:00