tudor/school_compare
1
0 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(modal): give the close button a 44px touch target #172

Merged
tudor merged 1 commits from fix/modal-close-tap-target into main 2026-10-02 15:50:15 +00:00
Conversation 1 Commits 1 Files Changed 1
+4
1 Commits
Author SHA1 Message Date
TudorandClaude Opus 5.5 27d83f9bd0 fix(modal): give the close button a 44px touch target
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m13s
Details
PR Checks / Backend Smoke (pull_request) Successful in 10s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 18s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m19s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 12s
Details 
The close button was 40px square: a 24px icon in 8px of padding. MOBILE.md
sets 44px as the minimum, and the phone filter sheet journey, which
checks every target in the sheet, has failed on it in the staging E2E
gate since the sheet shipped. Measured on staging with the rule
injected: the button is 44x44, nothing in the sheet is under 44, and
the page does not overflow. Every Modal gets the same button, the
compare page's school search included.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-02 16:40:45 +01:00