tudor/school_compare
1
0 Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(search): offer every filter option, not only those in the results #169

Merged
tudor merged 2 commits from fix/filter-options-not-from-results into main 2026-10-02 09:34:02 +00:00
Conversation 2 Commits 2 Files Changed 4
+185 -16
2 Commits
Author SHA1 Message Date
TudorandClaude Opus 5.5 68452681f8 fix(search): match primary phases by their words, not exact labels
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m14s
Details
PR Checks / Backend Smoke (pull_request) Successful in 10s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 17s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m20s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 12s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 18s
Details 
The secondary-only filters were hidden for an exact set of lowercased
labels, so a change of case, hyphen or spacing in a GIAS phase label
would have left them showing. Phases are now matched on their words, as
compareGroups already reads "primary".

The E2E journey no longer counts school types: it asserts that choosing
one leaves the same list on offer, whatever the data holds. A test now
pins that a filter with no options is left out, not shown with only its
"any" option.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-02 10:28:34 +01:00
TudorandClaude Opus 5.5 0cc4f52816 fix(search): offer every filter option, not only those in the results
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m17s
Details
PR Checks / Backend Smoke (pull_request) Successful in 9s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 19s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m22s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 11s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 15s
Details 
School type, gender and admissions took their options from the result
set, which the filter had already narrowed: choose "Girls" and only
"Girls" was offered, so switching to "Boys" meant clearing first. They
now offer the full lists from /api/filters, as phase already did. Local
authority stays scoped to the results, so a postcode search offers the
councils nearby rather than all 153.

Whether gender, sixth form and admissions show was also decided by the
results (any secondary school in them). It is now decided by the phase
alone: hidden for Primary, Nursery and Middle deemed primary, shown
otherwise. Choosing one of those phases clears the three filters, which
would otherwise stay applied with no control showing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
 2026-10-02 10:22:39 +01:00