Choosing Nursery, 16 plus, Middle deemed primary or Middle deemed secondary in the search page's phase filter returned the whole unfiltered result set — mostly primary schools.
Why
/api/schools looked the phase up in PHASE_GROUPS, which only has primary, secondary and all-through. For any other value the lookup returned None and the filter was skipped entirely. The dropdown lists every GIAS phase (and since #162 always does), so four of its seven options did nothing.
Fix
primary / secondary / all-through keep their grouping (primary takes in middle deemed primary and all-through; secondary takes in middle deemed secondary, 16 plus and all-through).
Any other phase is an exact, case-insensitive match.
An unknown phase returns no schools instead of all of them.
Tests
New backend/tests/test_phase_filter.py: all seven phases plus an unknown value. 5 of 6 failed before the fix (reproducing the bug); all pass after. Full backend suite: 237 passed.
New E2E journey: a phase outside primary/secondary filters to that phase, not to everything (nursery, 16 plus via the API). Runs on the post-merge staging gate.
Not changed
The dropdown still shows the seven raw GIAS phase names. A shorter, parent-facing list is a separate product decision.
## What
Choosing **Nursery**, **16 plus**, **Middle deemed primary** or **Middle deemed secondary** in the search page's phase filter returned the whole unfiltered result set — mostly primary schools.
## Why
`/api/schools` looked the phase up in `PHASE_GROUPS`, which only has `primary`, `secondary` and `all-through`. For any other value the lookup returned `None` and the filter was skipped entirely. The dropdown lists every GIAS phase (and since #162 always does), so four of its seven options did nothing.
## Fix
- `primary` / `secondary` / `all-through` keep their grouping (primary takes in middle deemed primary and all-through; secondary takes in middle deemed secondary, 16 plus and all-through).
- Any other phase is an exact, case-insensitive match.
- An unknown phase returns no schools instead of all of them.
## Tests
- New `backend/tests/test_phase_filter.py`: all seven phases plus an unknown value. 5 of 6 failed before the fix (reproducing the bug); all pass after. Full backend suite: 237 passed.
- New E2E journey: *a phase outside primary/secondary filters to that phase, not to everything* (`nursery`, `16 plus` via the API). Runs on the post-merge staging gate.
## Not changed
The dropdown still shows the seven raw GIAS phase names. A shorter, parent-facing list is a separate product decision.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
/api/schools only recognised primary, secondary and all-through. Any
other phase the search page offers (nursery, 16 plus, middle deemed
primary/secondary) fell through to no filter, so "Nursery" returned the
whole result set, mostly primaries. Ungrouped phases now match exactly,
and an unknown phase returns nothing rather than everything.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The /api/schools phase filter now matches any GIAS phase name exactly when it isn't a grouped phase (primary/secondary). It previously fell through to no filter, so 'Nursery' returned the whole result set. It also handles null phases with fillna and adds backend unit tests and an e2e test. The change is small and correct, and I found no issues.
✅ No issues found.
## 🤖 AI Code Review (Claude Code)
The /api/schools phase filter now matches any GIAS phase name exactly when it isn't a grouped phase (primary/secondary). It previously fell through to no filter, so 'Nursery' returned the whole result set. It also handles null phases with fillna and adds backend unit tests and an e2e test. The change is small and correct, and I found no issues.
✅ No issues found.
tudor
merged commit 2002529137 into main2026-10-01 14:07:57 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What
Choosing Nursery, 16 plus, Middle deemed primary or Middle deemed secondary in the search page's phase filter returned the whole unfiltered result set — mostly primary schools.
Why
/api/schoolslooked the phase up inPHASE_GROUPS, which only hasprimary,secondaryandall-through. For any other value the lookup returnedNoneand the filter was skipped entirely. The dropdown lists every GIAS phase (and since #162 always does), so four of its seven options did nothing.Fix
primary/secondary/all-throughkeep their grouping (primary takes in middle deemed primary and all-through; secondary takes in middle deemed secondary, 16 plus and all-through).Tests
backend/tests/test_phase_filter.py: all seven phases plus an unknown value. 5 of 6 failed before the fix (reproducing the bug); all pass after. Full backend suite: 237 passed.nursery,16 plusvia the API). Runs on the post-merge staging gate.Not changed
The dropdown still shows the seven raw GIAS phase names. A shorter, parent-facing list is a separate product decision.
🤖 Generated with Claude Code
🤖 AI Code Review (Claude Code)
The /api/schools phase filter now matches any GIAS phase name exactly when it isn't a grouped phase (primary/secondary). It previously fell through to no filter, so 'Nursery' returned the whole result set. It also handles null phases with fillna and adds backend unit tests and an e2e test. The change is small and correct, and I found no issues.
✅ No issues found.