chore: drop the hero byline, and refresh a figure in the UX audit notes #100

Merged
tudor merged 1 commits from chore/byline-removal-and-audit-figure into main 2026-08-15 09:26:00 +00:00
Owner

The two changes that were sitting uncommitted in the working tree, as one commit. Neither is mine — both were made outside my edits, so I've committed them as found rather than adjusting them.

1. Hero byline removed

Drops Built for parents, by a parent. and its comment from the hero. It went in two commits ago (#97); taking it out is your call.

One thing left behind deliberately: the .heroByline rules in HomeView.module.css are now unreferenced. I have not deleted them, because the class was purpose-built for this one line and keeping it makes restoring the byline a one-line change. If the removal is permanent, that block and its 640px media query should go with it — say the word and I'll strip them.

2. UX audit notes: "24,000+" → "27,000+"

Two quoted figures updated in docs/superpowers/specs/2026-07-02-ux-audit-notes/journey-1-home-find-school.md.

Worth flagging, and I've left it as you edited it: that file records what the page said when it was audited, and at that time it genuinely did say "24,000+" — which was itself the bug we later fixed (the frontend read a total_schools field the API has never sent, so a hardcoded fallback rendered instead of the real 27,230).

So the edit makes the note consistent with the current site, at the cost of it no longer being a verbatim record of what was observed. If the intent is "keep the historical record accurate", the original figure was correct and the note could instead say the copy has since been fixed. If the intent is "stop the doc contradicting the live site", this is right as-is.

Verification

tsc clean, 159/159 unit tests, build green.

🤖 Generated with Claude Code

The two changes that were sitting uncommitted in the working tree, as one commit. Neither is mine — both were made outside my edits, so I've committed them as found rather than adjusting them. ## 1. Hero byline removed Drops `Built for parents, by a parent.` and its comment from the hero. It went in two commits ago (#97); taking it out is your call. **One thing left behind deliberately:** the `.heroByline` rules in `HomeView.module.css` are now unreferenced. I have *not* deleted them, because the class was purpose-built for this one line and keeping it makes restoring the byline a one-line change. If the removal is permanent, that block and its 640px media query should go with it — say the word and I'll strip them. ## 2. UX audit notes: "24,000+" → "27,000+" Two quoted figures updated in `docs/superpowers/specs/2026-07-02-ux-audit-notes/journey-1-home-find-school.md`. **Worth flagging, and I've left it as you edited it:** that file records what the page said *when it was audited*, and at that time it genuinely did say "24,000+" — which was itself the bug we later fixed (the frontend read a `total_schools` field the API has never sent, so a hardcoded fallback rendered instead of the real 27,230). So the edit makes the note consistent with the current site, at the cost of it no longer being a verbatim record of what was observed. If the intent is "keep the historical record accurate", the original figure was correct and the note could instead say the copy has since been fixed. If the intent is "stop the doc contradicting the live site", this is right as-is. ## Verification `tsc` clean, 159/159 unit tests, build green. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
tudor added 1 commit 2026-08-15 09:21:46 +00:00
chore: drop the hero byline, and refresh a figure in the UX audit notes
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m3s
PR Checks / Backend Smoke (pull_request) Successful in 6s
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
PR Checks / Build Frontend (no push) (pull_request) Successful in 47s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 14s
fa1abff642
Two unrelated working-tree changes, committed as one at the owner's request.

Removes "Built for parents, by a parent." and its comment from the hero. It
was added two commits ago; taking it out is the owner's call, and the reasons
it was placed under the search rather than in the footer no longer apply.

The .heroByline rules in HomeView.module.css are deliberately left in place.
They are now unreferenced, but the class was purpose-built for this one line
and keeping it makes restoring the byline a one-line change. If the removal is
permanent, that block (and its 640px media query) should go with it.

Also updates two quoted figures in the 2026-07-02 UX audit notes from
"24,000+" to "27,000+".

Worth noting for the record: that file documents what the page said when it was
audited, and at that time it genuinely did say "24,000+" — which was itself the
bug later fixed by reading unique_schools instead of a field the API never
sent. Editing the quoted evidence makes the note read consistently with the
current site, at the cost of no longer being a verbatim record of what was
observed. Left as the owner edited it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

🤖 AI Code Review (Claude Code)

This PR is a documentation/content-only change: two doc fixes to a UX audit spec (correcting a school count figure from 24,000+ to 27,000+) and removal of a hero byline paragraph (with its explanatory comment) from the homepage component. No logic, data, or deploy configuration is touched.

✅ No issues found.

## 🤖 AI Code Review (Claude Code) This PR is a documentation/content-only change: two doc fixes to a UX audit spec (correcting a school count figure from 24,000+ to 27,000+) and removal of a hero byline paragraph (with its explanatory comment) from the homepage component. No logic, data, or deploy configuration is touched. ✅ No issues found.
tudor merged commit 5156a85bd1 into main 2026-08-15 09:26:00 +00:00
Sign in to join this conversation.
No Reviewers
No labels
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: tudor/school_compare#100