Compare commits
101
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
a88139a539 | ||
|
|
9b765125ad | ||
|
|
ccf0892a0e | ||
|
|
0450f8ecd6 | ||
|
|
27d83f9bd0 | ||
|
|
19c574edb0 | ||
|
|
e78ec14e2e | ||
|
|
fb3ef7d2b9 | ||
|
|
49ac96b487 | ||
|
|
214c80663e | ||
|
|
84caee9f72 | ||
|
|
c992d7f3b9 | ||
|
|
17bfb4a3f7 | ||
|
|
15b8923e60 | ||
|
|
354244f755 | ||
|
|
3e2fa4a419 | ||
|
|
50546ecf22 | ||
|
|
99d62ef748 | ||
|
|
68452681f8 | ||
|
|
0cc4f52816 | ||
|
|
eb13ab0b5e | ||
|
|
fa49164143 | ||
|
|
cf3c773f86 | ||
|
|
4b54c25943 | ||
|
|
e7645d1ba5 | ||
|
|
29b5f85952 | ||
|
|
c077c27720 | ||
|
|
e2fc7a8f15 | ||
|
|
355a5a841c | ||
|
|
96deab7d58 | ||
|
|
e9886361d2 | ||
|
|
8ebe461435 | ||
|
|
2002529137 | ||
|
|
bd7c8593d9 | ||
|
|
0c414680fd | ||
|
|
e211e1376d | ||
|
|
74418ca6b9 | ||
|
|
5df8c93420 | ||
|
|
ebf9c12446 | ||
|
|
ca4ddd2b12 | ||
|
|
dff3e210ab | ||
|
|
37bbda1da1 | ||
|
|
a37da15008 | ||
|
|
cff3854e63 | ||
|
|
1bb3e0360f | ||
|
|
4e4b30e812 | ||
|
|
0e177ca2ec | ||
|
|
367a07c15d | ||
|
|
983a581555 | ||
|
|
b34feb8e98 | ||
|
|
cc99865bd4 | ||
|
|
587cfe3f0b | ||
|
|
0a4c051ee5 | ||
|
|
343b40c645 | ||
|
|
d1688ac150 | ||
|
|
271ffe92d4 | ||
|
|
0571d1c0ff | ||
|
|
180d6e9b3e | ||
|
|
80f405123e | ||
|
|
077aca6008 | ||
|
|
9dba5ff1ff | ||
|
|
f530a912bc | ||
|
|
029fe8d8a6 | ||
|
|
cd1c5d1e1a | ||
|
|
cd6a45bf7d | ||
|
|
5c0ccc693d | ||
|
|
151cf4bc80 | ||
|
|
83dc5ae5dc | ||
|
|
2175dccb7c | ||
|
|
bd2a6c385b | ||
|
|
4e0d8bcf87 | ||
|
|
91314a80b5 | ||
|
|
52b00ac752 | ||
|
|
b571d9c549 | ||
|
|
8a23e3657d | ||
|
|
e4e8f02599 | ||
|
|
b62dc17532 | ||
|
|
4d7762d796 | ||
|
|
3650f7d8b7 | ||
|
|
dfce308f1f | ||
|
|
64ae71d7ab | ||
|
|
7ab084dd3a | ||
|
|
5ad1cbfb53 | ||
|
|
0c901cd0d1 | ||
|
|
7b41218e6e | ||
|
|
9b75f54206 | ||
|
|
38bc17cab3 | ||
|
|
dc156058fe | ||
|
|
1d8858fbda | ||
|
|
eaf5e5d180 | ||
|
|
be780ebe13 | ||
|
|
b6c2cd5116 | ||
|
|
dc79d653e5 | ||
|
|
b0d5334e06 | ||
|
|
d65eb58883 | ||
|
|
7f5f0fb676 | ||
|
|
47f3591ed8 | ||
|
|
6fc7fce948 | ||
|
|
eb6d918650 | ||
|
|
d47ac71c47 | ||
|
|
17e5371e9c |
No files matched your search
+13
-5
@@ -20,7 +20,7 @@ PORT=80
|
|||||||
# =============================================================================
|
# =============================================================================
|
||||||
# CORS
|
# CORS
|
||||||
# =============================================================================
|
# =============================================================================
|
||||||
# Comma-separated list of allowed origins
|
# JSON array of allowed origins (pydantic-settings format)
|
||||||
# In production, only include your actual domain
|
# In production, only include your actual domain
|
||||||
ALLOWED_ORIGINS=["https://schoolcompare.co.uk"]
|
ALLOWED_ORIGINS=["https://schoolcompare.co.uk"]
|
||||||
|
|
||||||
@@ -33,13 +33,21 @@ ADMIN_API_KEY=CHANGE_THIS_TO_A_SECURE_RANDOM_KEY
|
|||||||
|
|
||||||
# Rate limiting (requests per minute per IP)
|
# Rate limiting (requests per minute per IP)
|
||||||
RATE_LIMIT_PER_MINUTE=60
|
RATE_LIMIT_PER_MINUTE=60
|
||||||
RATE_LIMIT_BURST=10
|
GLOBAL_RATE_LIMIT_PER_MINUTE=3000
|
||||||
|
|
||||||
# Maximum request body size in bytes (default 1MB)
|
# Maximum request body size in bytes (default 1MB)
|
||||||
MAX_REQUEST_SIZE=1048576
|
MAX_REQUEST_SIZE=1048576
|
||||||
|
|
||||||
# =============================================================================
|
# =============================================================================
|
||||||
# API
|
# SEARCH AND OPTIONAL FEATURE FLAGS
|
||||||
# =============================================================================
|
# =============================================================================
|
||||||
DEFAULT_PAGE_SIZE=50
|
TYPESENSE_URL=http://localhost:8108
|
||||||
MAX_PAGE_SIZE=100
|
TYPESENSE_API_KEY=CHANGE_THIS_TO_YOUR_TYPESENSE_KEY
|
||||||
|
|
||||||
|
# Empty URL disables Unleash-backed flags. Match the managed environment when used.
|
||||||
|
UNLEASH_URL=
|
||||||
|
UNLEASH_API_TOKEN=
|
||||||
|
|
||||||
|
# Page-size limits are currently declared by route Query parameters.
|
||||||
|
# DEFAULT_PAGE_SIZE, MAX_PAGE_SIZE and RATE_LIMIT_BURST are not reliable tuning
|
||||||
|
# controls in the current routes; see docs/LEGACY_CODE.md.
|
||||||
+73
-17
@@ -5,6 +5,11 @@ on:
|
|||||||
branches:
|
branches:
|
||||||
- main
|
- main
|
||||||
|
|
||||||
|
# Serialise the entire build/deploy/test cycle: no other run can move staging tags.
|
||||||
|
concurrency:
|
||||||
|
group: staging-release
|
||||||
|
cancel-in-progress: false
|
||||||
|
|
||||||
env:
|
env:
|
||||||
REGISTRY: privaterepo.sitaru.org
|
REGISTRY: privaterepo.sitaru.org
|
||||||
BACKEND_IMAGE_NAME: ${{ gitea.repository }}-backend
|
BACKEND_IMAGE_NAME: ${{ gitea.repository }}-backend
|
||||||
@@ -12,7 +17,18 @@ env:
|
|||||||
PIPELINE_IMAGE_NAME: ${{ gitea.repository }}-pipeline
|
PIPELINE_IMAGE_NAME: ${{ gitea.repository }}-pipeline
|
||||||
|
|
||||||
jobs:
|
jobs:
|
||||||
|
prepare:
|
||||||
|
runs-on: ubuntu-latest
|
||||||
|
outputs:
|
||||||
|
build_id: ${{ steps.identity.outputs.build_id }}
|
||||||
|
steps:
|
||||||
|
- id: identity
|
||||||
|
run: python3 -c 'import uuid; print("build_id=" + uuid.uuid4().hex)' >> "$GITHUB_OUTPUT"
|
||||||
|
|
||||||
build-backend:
|
build-backend:
|
||||||
|
needs: [prepare]
|
||||||
|
outputs:
|
||||||
|
digest: ${{ steps.build.outputs.digest }}
|
||||||
name: Build Backend (FastAPI)
|
name: Build Backend (FastAPI)
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
@@ -46,17 +62,24 @@ jobs:
|
|||||||
type=raw,value=staging
|
type=raw,value=staging
|
||||||
|
|
||||||
- name: Build and push Backend Docker image
|
- name: Build and push Backend Docker image
|
||||||
|
id: build
|
||||||
uses: docker/build-push-action@v5
|
uses: docker/build-push-action@v5
|
||||||
with:
|
with:
|
||||||
context: .
|
context: .
|
||||||
file: ./Dockerfile
|
file: ./Dockerfile
|
||||||
push: true
|
push: true
|
||||||
|
build-args: |
|
||||||
|
BUILD_SHA=${{ gitea.sha }}
|
||||||
|
BUILD_ID=${{ needs.prepare.outputs.build_id }}
|
||||||
tags: ${{ steps.meta-backend.outputs.tags }}
|
tags: ${{ steps.meta-backend.outputs.tags }}
|
||||||
labels: ${{ steps.meta-backend.outputs.labels }}
|
labels: ${{ steps.meta-backend.outputs.labels }}
|
||||||
cache-from: type=registry,ref=${{ env.REGISTRY }}/${{ env.BACKEND_IMAGE_NAME }}:buildcache
|
cache-from: type=registry,ref=${{ env.REGISTRY }}/${{ env.BACKEND_IMAGE_NAME }}:buildcache
|
||||||
cache-to: type=registry,ref=${{ env.REGISTRY }}/${{ env.BACKEND_IMAGE_NAME }}:buildcache,mode=max
|
cache-to: type=registry,ref=${{ env.REGISTRY }}/${{ env.BACKEND_IMAGE_NAME }}:buildcache,mode=max
|
||||||
|
|
||||||
build-frontend:
|
build-frontend:
|
||||||
|
needs: [prepare]
|
||||||
|
outputs:
|
||||||
|
digest: ${{ steps.build.outputs.digest }}
|
||||||
name: Build Frontend (Next.js)
|
name: Build Frontend (Next.js)
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
@@ -90,18 +113,23 @@ jobs:
|
|||||||
type=raw,value=staging
|
type=raw,value=staging
|
||||||
|
|
||||||
- name: Build and push Frontend Docker image
|
- name: Build and push Frontend Docker image
|
||||||
|
id: build
|
||||||
uses: docker/build-push-action@v5
|
uses: docker/build-push-action@v5
|
||||||
with:
|
with:
|
||||||
context: ./nextjs-app
|
context: ./nextjs-app
|
||||||
file: ./nextjs-app/Dockerfile
|
file: ./nextjs-app/Dockerfile
|
||||||
push: true
|
push: true
|
||||||
|
build-args: |
|
||||||
|
BUILD_SHA=${{ gitea.sha }}
|
||||||
|
BUILD_ID=${{ needs.prepare.outputs.build_id }}
|
||||||
tags: ${{ steps.meta-frontend.outputs.tags }}
|
tags: ${{ steps.meta-frontend.outputs.tags }}
|
||||||
labels: ${{ steps.meta-frontend.outputs.labels }}
|
labels: ${{ steps.meta-frontend.outputs.labels }}
|
||||||
build-args: |
|
|
||||||
FASTAPI_URL=http://backend:80/api
|
|
||||||
# Cache disabled due to registry size limits
|
# Cache disabled due to registry size limits
|
||||||
|
|
||||||
build-pipeline:
|
build-pipeline:
|
||||||
|
needs: [prepare]
|
||||||
|
outputs:
|
||||||
|
digest: ${{ steps.build.outputs.digest }}
|
||||||
name: Build Pipeline (Meltano + dbt + Airflow)
|
name: Build Pipeline (Meltano + dbt + Airflow)
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
steps:
|
steps:
|
||||||
@@ -135,11 +163,15 @@ jobs:
|
|||||||
type=raw,value=staging
|
type=raw,value=staging
|
||||||
|
|
||||||
- name: Build and push Pipeline Docker image
|
- name: Build and push Pipeline Docker image
|
||||||
|
id: build
|
||||||
uses: docker/build-push-action@v5
|
uses: docker/build-push-action@v5
|
||||||
with:
|
with:
|
||||||
context: ./pipeline
|
context: ./pipeline
|
||||||
file: ./pipeline/Dockerfile
|
file: ./pipeline/Dockerfile
|
||||||
push: true
|
push: true
|
||||||
|
build-args: |
|
||||||
|
BUILD_SHA=${{ gitea.sha }}
|
||||||
|
BUILD_ID=${{ needs.prepare.outputs.build_id }}
|
||||||
tags: ${{ steps.meta-pipeline.outputs.tags }}
|
tags: ${{ steps.meta-pipeline.outputs.tags }}
|
||||||
labels: ${{ steps.meta-pipeline.outputs.labels }}
|
labels: ${{ steps.meta-pipeline.outputs.labels }}
|
||||||
cache-from: type=registry,ref=${{ env.REGISTRY }}/${{ env.PIPELINE_IMAGE_NAME }}:buildcache
|
cache-from: type=registry,ref=${{ env.REGISTRY }}/${{ env.PIPELINE_IMAGE_NAME }}:buildcache
|
||||||
@@ -148,30 +180,23 @@ jobs:
|
|||||||
deploy-staging:
|
deploy-staging:
|
||||||
name: Deploy to Staging
|
name: Deploy to Staging
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
needs: [build-backend, build-frontend, build-pipeline]
|
needs: [prepare, build-backend, build-frontend, build-pipeline]
|
||||||
steps:
|
steps:
|
||||||
- name: Trigger staging stack update
|
- name: Trigger staging stack update
|
||||||
run: curl -fsSk -X POST "${{ secrets.PORTAINER_STAGING_WEBHOOK }}"
|
run: curl -fsSk -X POST "${{ secrets.PORTAINER_STAGING_WEBHOOK }}"
|
||||||
|
|
||||||
- name: Wait for staging to become healthy
|
- uses: actions/checkout@v4
|
||||||
run: |
|
- name: Verify deployed release identity
|
||||||
echo "Polling ${STAGING_BASE_URL} for up to 5 minutes..."
|
run: python3 scripts/ci/release.py wait
|
||||||
for i in $(seq 1 60); do
|
|
||||||
if curl -fsS -o /dev/null --max-time 10 "${STAGING_BASE_URL}/"; then
|
|
||||||
echo "Staging is up (attempt $i)"
|
|
||||||
exit 0
|
|
||||||
fi
|
|
||||||
sleep 5
|
|
||||||
done
|
|
||||||
echo "Staging did not become healthy in time" >&2
|
|
||||||
exit 1
|
|
||||||
env:
|
env:
|
||||||
STAGING_BASE_URL: ${{ secrets.STAGING_BASE_URL }}
|
BASE_URL: ${{ secrets.STAGING_BASE_URL }}
|
||||||
|
EXPECTED_SHA: ${{ gitea.sha }}
|
||||||
|
EXPECTED_BUILD_ID: ${{ needs.prepare.outputs.build_id }}
|
||||||
|
|
||||||
e2e-staging:
|
e2e-staging:
|
||||||
name: E2E Journeys against Staging
|
name: E2E Journeys against Staging
|
||||||
runs-on: ubuntu-latest
|
runs-on: ubuntu-latest
|
||||||
needs: [deploy-staging]
|
needs: [prepare, deploy-staging, build-backend, build-frontend, build-pipeline]
|
||||||
steps:
|
steps:
|
||||||
- name: Checkout repository
|
- name: Checkout repository
|
||||||
uses: actions/checkout@v4
|
uses: actions/checkout@v4
|
||||||
@@ -187,11 +212,42 @@ jobs:
|
|||||||
npm ci
|
npm ci
|
||||||
npx playwright install --with-deps chromium
|
npx playwright install --with-deps chromium
|
||||||
|
|
||||||
|
- name: Verify release before journeys
|
||||||
|
run: python3 scripts/ci/release.py wait --timeout 10
|
||||||
|
env:
|
||||||
|
BASE_URL: ${{ secrets.STAGING_BASE_URL }}
|
||||||
|
EXPECTED_SHA: ${{ gitea.sha }}
|
||||||
|
EXPECTED_BUILD_ID: ${{ needs.prepare.outputs.build_id }}
|
||||||
|
|
||||||
- name: Run E2E journeys
|
- name: Run E2E journeys
|
||||||
working-directory: e2e
|
working-directory: e2e
|
||||||
run: npx playwright test
|
run: npx playwright test
|
||||||
env:
|
env:
|
||||||
BASE_URL: ${{ secrets.STAGING_BASE_URL }}
|
BASE_URL: ${{ secrets.STAGING_BASE_URL }}
|
||||||
|
EXPECTED_SHA: ${{ gitea.sha }}
|
||||||
|
EXPECTED_BUILD_ID: ${{ needs.prepare.outputs.build_id }}
|
||||||
|
|
||||||
|
- name: Verify release after journeys
|
||||||
|
run: python3 scripts/ci/release.py wait --timeout 10
|
||||||
|
env:
|
||||||
|
BASE_URL: ${{ secrets.STAGING_BASE_URL }}
|
||||||
|
EXPECTED_SHA: ${{ gitea.sha }}
|
||||||
|
EXPECTED_BUILD_ID: ${{ needs.prepare.outputs.build_id }}
|
||||||
|
|
||||||
|
- uses: docker/setup-buildx-action@v3
|
||||||
|
- uses: docker/login-action@v3
|
||||||
|
with:
|
||||||
|
registry: ${{ env.REGISTRY }}
|
||||||
|
username: ${{ gitea.actor }}
|
||||||
|
password: ${{ secrets.REGISTRY_TOKEN }}
|
||||||
|
- name: Mark tested image digests as verified
|
||||||
|
run: python3 scripts/ci/release.py verify
|
||||||
|
env:
|
||||||
|
EXPECTED_SHA: ${{ gitea.sha }}
|
||||||
|
EXPECTED_BUILD_ID: ${{ needs.prepare.outputs.build_id }}
|
||||||
|
BACKEND_DIGEST: ${{ needs.build-backend.outputs.digest }}
|
||||||
|
FRONTEND_DIGEST: ${{ needs.build-frontend.outputs.digest }}
|
||||||
|
PIPELINE_DIGEST: ${{ needs.build-pipeline.outputs.digest }}
|
||||||
|
|
||||||
# Production deployment is a second, manual approval: see promote.yml
|
# Production deployment is a second, manual approval: see promote.yml
|
||||||
# ("Promote to Production (manual)") and docs/DEPLOY.md.
|
# ("Promote to Production (manual)") and docs/DEPLOY.md.
|
||||||
@@ -68,13 +68,13 @@ jobs:
|
|||||||
python-version: "3.12"
|
python-version: "3.12"
|
||||||
|
|
||||||
- name: Install dependencies
|
- name: Install dependencies
|
||||||
run: pip install -r requirements.txt pytest "httpx<0.28"
|
run: pip install -r requirements.txt pytest "httpx<0.28" pyyaml
|
||||||
|
|
||||||
- name: Import smoke test
|
- name: Import smoke test
|
||||||
run: python -c "from backend.app import app; print('backend imports OK')"
|
run: python -c "from backend.app import app; print('backend imports OK')"
|
||||||
|
|
||||||
- name: Backend unit tests
|
- name: Backend unit tests
|
||||||
run: python -m pytest backend/tests -q
|
run: python -m pytest backend/tests pipeline/tests scripts/ci/tests -q
|
||||||
|
|
||||||
build-backend:
|
build-backend:
|
||||||
name: Build Backend (no push)
|
name: Build Backend (no push)
|
||||||
|
|||||||
@@ -97,33 +97,15 @@ jobs:
|
|||||||
username: ${{ gitea.actor }}
|
username: ${{ gitea.actor }}
|
||||||
password: ${{ secrets.REGISTRY_TOKEN }}
|
password: ${{ secrets.REGISTRY_TOKEN }}
|
||||||
|
|
||||||
- name: Retag approved images as prod (keeping rollback pointer)
|
- name: Resolve verified digests and promote the complete image set
|
||||||
run: |
|
run: python3 scripts/ci/release.py promote --output release.json
|
||||||
SHORT_SHA="${{ steps.resolve.outputs.short }}"
|
env:
|
||||||
for IMAGE in \
|
EXPECTED_SHA: ${{ steps.resolve.outputs.full }}
|
||||||
"${REGISTRY}/${BACKEND_IMAGE_NAME}" \
|
|
||||||
"${REGISTRY}/${FRONTEND_IMAGE_NAME}" \
|
|
||||||
"${REGISTRY}/${PIPELINE_IMAGE_NAME}"; do
|
|
||||||
# Keep a rollback pointer before moving :prod
|
|
||||||
docker buildx imagetools create -t "${IMAGE}:prod-previous" "${IMAGE}:prod" || true
|
|
||||||
docker buildx imagetools create -t "${IMAGE}:prod" "${IMAGE}:${SHORT_SHA}"
|
|
||||||
echo "Promoted ${IMAGE}:${SHORT_SHA} -> :prod"
|
|
||||||
done
|
|
||||||
|
|
||||||
- name: Trigger production stack update
|
- name: Trigger production stack update
|
||||||
run: curl -fsSk -X POST "${{ secrets.PORTAINER_PROD_WEBHOOK }}"
|
run: curl -fsSk -X POST "${{ secrets.PORTAINER_PROD_WEBHOOK }}"
|
||||||
|
|
||||||
- name: Wait for production to become healthy
|
- name: Verify production release identity
|
||||||
run: |
|
run: python3 scripts/ci/release.py wait --release release.json
|
||||||
echo "Polling ${PROD_BASE_URL} for up to 5 minutes..."
|
|
||||||
for i in $(seq 1 60); do
|
|
||||||
if curl -fsS -o /dev/null --max-time 10 "${PROD_BASE_URL}/"; then
|
|
||||||
echo "Production is up (attempt $i)"
|
|
||||||
exit 0
|
|
||||||
fi
|
|
||||||
sleep 5
|
|
||||||
done
|
|
||||||
echo "Production did not become healthy in time" >&2
|
|
||||||
exit 1
|
|
||||||
env:
|
env:
|
||||||
PROD_BASE_URL: ${{ secrets.PROD_BASE_URL }}
|
BASE_URL: ${{ secrets.PROD_BASE_URL }}
|
||||||
+13
-187
@@ -1,191 +1,17 @@
|
|||||||
# Docker Deployment Guide
|
# Docker deployment
|
||||||
|
|
||||||
## Quick Start
|
The maintained deployment runbook is [docs/DEPLOY.md](docs/DEPLOY.md).
|
||||||
|
|
||||||
Deploy the complete SchoolCompare stack (PostgreSQL + FastAPI + Next.js) with one command:
|
- Production: `docker-compose.portainer.yml`, using `:prod` images.
|
||||||
|
- Staging: `docker-compose.portainer.staging.yml`, using `:staging` images.
|
||||||
|
- Builds and deployment: `.gitea/workflows/deploy.yml`.
|
||||||
|
- Human-approved production promotion: `.gitea/workflows/promote.yml`.
|
||||||
|
|
||||||
```bash
|
The generic `docker-compose.yml` is not a supported one-command onboarding path:
|
||||||
docker-compose up -d
|
it still uses `:latest` tags that the release workflow no longer publishes and
|
||||||
```
|
lacks the full current CMS setup. Review the [legacy inventory](docs/LEGACY_CODE.md)
|
||||||
|
before using old compose examples. Starting an empty database does not populate
|
||||||
|
school marts.
|
||||||
|
|
||||||
This will start:
|
For architecture, configuration and test commands, see
|
||||||
- **PostgreSQL** on port 5432 (database)
|
[ARCHITECTURE.md](docs/ARCHITECTURE.md) and [DEVELOPMENT.md](docs/DEVELOPMENT.md).
|
||||||
- **FastAPI** on port 8000 (backend API)
|
|
||||||
- **Next.js** on port 3000 (frontend)
|
|
||||||
|
|
||||||
## Service Details
|
|
||||||
|
|
||||||
### PostgreSQL Database
|
|
||||||
- **Port**: 5432
|
|
||||||
- **Container**: `schoolcompare_db`
|
|
||||||
- **Credentials**:
|
|
||||||
- User: `schoolcompare`
|
|
||||||
- Password: `schoolcompare`
|
|
||||||
- Database: `schoolcompare`
|
|
||||||
- **Volume**: `postgres_data` (persistent storage)
|
|
||||||
|
|
||||||
### FastAPI Backend
|
|
||||||
- **Port**: 8000 → 80 (container)
|
|
||||||
- **Container**: `schoolcompare_backend`
|
|
||||||
- **Built from**: Root `Dockerfile`
|
|
||||||
- **API Endpoint**: http://localhost:8000/api
|
|
||||||
- **Health Check**: http://localhost:8000/api/data-info
|
|
||||||
|
|
||||||
### Next.js Frontend
|
|
||||||
- **Port**: 3000
|
|
||||||
- **Container**: `schoolcompare_nextjs`
|
|
||||||
- **Built from**: `nextjs-app/Dockerfile`
|
|
||||||
- **URL**: http://localhost:3000
|
|
||||||
- **Connects to**: Backend via internal network
|
|
||||||
|
|
||||||
## Commands
|
|
||||||
|
|
||||||
### Start all services
|
|
||||||
```bash
|
|
||||||
docker-compose up -d
|
|
||||||
```
|
|
||||||
|
|
||||||
### View logs
|
|
||||||
```bash
|
|
||||||
# All services
|
|
||||||
docker-compose logs -f
|
|
||||||
|
|
||||||
# Specific service
|
|
||||||
docker-compose logs -f nextjs
|
|
||||||
docker-compose logs -f backend
|
|
||||||
docker-compose logs -f db
|
|
||||||
```
|
|
||||||
|
|
||||||
### Check status
|
|
||||||
```bash
|
|
||||||
docker-compose ps
|
|
||||||
```
|
|
||||||
|
|
||||||
### Stop all services
|
|
||||||
```bash
|
|
||||||
docker-compose down
|
|
||||||
```
|
|
||||||
|
|
||||||
### Rebuild after code changes
|
|
||||||
```bash
|
|
||||||
# Rebuild and restart specific service
|
|
||||||
docker-compose up -d --build nextjs
|
|
||||||
|
|
||||||
# Rebuild all services
|
|
||||||
docker-compose up -d --build
|
|
||||||
```
|
|
||||||
|
|
||||||
### Clean restart (remove volumes)
|
|
||||||
```bash
|
|
||||||
docker-compose down -v
|
|
||||||
docker-compose up -d
|
|
||||||
```
|
|
||||||
|
|
||||||
## Initial Database Setup
|
|
||||||
|
|
||||||
After first start, you may need to initialize the database:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Enter the backend container
|
|
||||||
docker exec -it schoolcompare_backend bash
|
|
||||||
|
|
||||||
# Run migrations or data loading
|
|
||||||
python -m backend.data_loader
|
|
||||||
```
|
|
||||||
|
|
||||||
## Accessing Services
|
|
||||||
|
|
||||||
Once running:
|
|
||||||
- **Frontend**: http://localhost:3000
|
|
||||||
- **Backend API**: http://localhost:8000/api
|
|
||||||
- **API Docs**: http://localhost:8000/docs (Swagger UI)
|
|
||||||
- **Database**: localhost:5432 (use any PostgreSQL client)
|
|
||||||
|
|
||||||
## Environment Variables
|
|
||||||
|
|
||||||
Create a `.env` file in the root directory to customize:
|
|
||||||
|
|
||||||
```env
|
|
||||||
# Database
|
|
||||||
POSTGRES_USER=schoolcompare
|
|
||||||
POSTGRES_PASSWORD=your_secure_password
|
|
||||||
POSTGRES_DB=schoolcompare
|
|
||||||
|
|
||||||
# Backend
|
|
||||||
DATABASE_URL=postgresql://schoolcompare:your_secure_password@db:5432/schoolcompare
|
|
||||||
|
|
||||||
# Frontend (for client-side access)
|
|
||||||
NEXT_PUBLIC_API_URL=http://localhost:8000/api
|
|
||||||
```
|
|
||||||
|
|
||||||
Then run:
|
|
||||||
```bash
|
|
||||||
docker-compose up -d
|
|
||||||
```
|
|
||||||
|
|
||||||
## Troubleshooting
|
|
||||||
|
|
||||||
### Backend not connecting to database
|
|
||||||
```bash
|
|
||||||
# Check database health
|
|
||||||
docker-compose ps
|
|
||||||
|
|
||||||
# View backend logs
|
|
||||||
docker-compose logs backend
|
|
||||||
|
|
||||||
# Restart backend
|
|
||||||
docker-compose restart backend
|
|
||||||
```
|
|
||||||
|
|
||||||
### Frontend not connecting to backend
|
|
||||||
```bash
|
|
||||||
# Check backend health
|
|
||||||
curl http://localhost:8000/api/data-info
|
|
||||||
|
|
||||||
# Check Next.js environment variables
|
|
||||||
docker exec schoolcompare_nextjs env | grep API
|
|
||||||
```
|
|
||||||
|
|
||||||
### Port already in use
|
|
||||||
```bash
|
|
||||||
# Change ports in docker-compose.yml
|
|
||||||
# For example, change "3000:3000" to "3001:3000"
|
|
||||||
```
|
|
||||||
|
|
||||||
### Rebuild from scratch
|
|
||||||
```bash
|
|
||||||
docker-compose down -v
|
|
||||||
docker system prune -a
|
|
||||||
docker-compose up -d --build
|
|
||||||
```
|
|
||||||
|
|
||||||
## Production Deployment
|
|
||||||
|
|
||||||
For production, update the following:
|
|
||||||
|
|
||||||
1. **Use secure passwords** in `.env` file
|
|
||||||
2. **Configure reverse proxy** (Nginx) in front of Next.js
|
|
||||||
3. **Enable HTTPS** with SSL certificates
|
|
||||||
4. **Set production environment variables**:
|
|
||||||
```env
|
|
||||||
NODE_ENV=production
|
|
||||||
POSTGRES_PASSWORD=<strong-password>
|
|
||||||
```
|
|
||||||
5. **Backup database** regularly:
|
|
||||||
```bash
|
|
||||||
docker exec schoolcompare_db pg_dump -U schoolcompare schoolcompare > backup.sql
|
|
||||||
```
|
|
||||||
|
|
||||||
## Network Architecture
|
|
||||||
|
|
||||||
```
|
|
||||||
Internet
|
|
||||||
↓
|
|
||||||
Next.js (port 3000) ← User browsers
|
|
||||||
↓ (internal network)
|
|
||||||
FastAPI (port 8000) ← API calls
|
|
||||||
↓ (internal network)
|
|
||||||
PostgreSQL (port 5432) ← Data queries
|
|
||||||
```
|
|
||||||
|
|
||||||
All services communicate via the `schoolcompare-network` Docker network.
|
|
||||||
@@ -24,6 +24,12 @@ RUN pip install --no-cache-dir -r requirements.txt
|
|||||||
COPY backend/ ./backend/
|
COPY backend/ ./backend/
|
||||||
COPY scripts/ ./scripts/
|
COPY scripts/ ./scripts/
|
||||||
|
|
||||||
|
ARG BUILD_SHA=development
|
||||||
|
ARG BUILD_ID=development
|
||||||
|
LABEL io.schoolcompare.build-id=$BUILD_ID
|
||||||
|
LABEL io.schoolcompare.commit=$BUILD_SHA
|
||||||
|
RUN python -c 'import json,sys; open("backend/build-info.json", "w").write(json.dumps({"sha":sys.argv[1],"build_id":sys.argv[2]}))' "$BUILD_SHA" "$BUILD_ID"
|
||||||
|
|
||||||
# Expose the application port
|
# Expose the application port
|
||||||
EXPOSE 80
|
EXPOSE 80
|
||||||
|
|
||||||
|
|||||||
@@ -1,3 +1,5 @@
|
|||||||
|
> Historical migration record, retained for context. Setup and architecture claims below may be obsolete. Use [README.md](README.md), [architecture](docs/ARCHITECTURE.md) and [deployment](docs/DEPLOY.md) for current guidance.
|
||||||
|
|
||||||
# SchoolCompare: Vanilla JS → Next.js Migration Summary
|
# SchoolCompare: Vanilla JS → Next.js Migration Summary
|
||||||
|
|
||||||
## Overview
|
## Overview
|
||||||
|
|||||||
@@ -1,214 +1,67 @@
|
|||||||
# Primary School Compass 🧒📚
|
# SchoolCompare
|
||||||
|
|
||||||
A modern web application for comparing **primary school (KS2)** performance data in **Wandsworth and Merton** over the last 5 years. Built with FastAPI and vanilla JavaScript with Chart.js visualizations.
|
SchoolCompare compares schools across England: primary (KS2), secondary (KS4),
|
||||||
|
all-through and post-16 provision, with coverage depending on the source dataset.
|
||||||
|
It provides school search, postcode maps, comparisons, rankings, place pages,
|
||||||
|
Ofsted information, admissions and destination measures. Editorial content lives
|
||||||
|
in a Payload CMS blog.
|
||||||
|
|
||||||

|
## Start here
|
||||||

|
|
||||||

|
|
||||||
|
|
||||||
## Features
|
- [Architecture and data flow](docs/ARCHITECTURE.md)
|
||||||
|
- [Development and validation](docs/DEVELOPMENT.md)
|
||||||
|
- [Deployment and promotion](docs/DEPLOY.md)
|
||||||
|
- [Legacy and unused-code inventory](docs/LEGACY_CODE.md)
|
||||||
|
- [Frontend conventions](nextjs-app/README.md)
|
||||||
|
- [CMS publishing](nextjs-app/docs/PUBLISHING.md)
|
||||||
|
|
||||||
- 📊 **Interactive Charts** - Visualize KS2 performance trends over time
|
## Repository map
|
||||||
- 🔍 **Smart Search** - Find primary schools by name in Wandsworth & Merton
|
|
||||||
- ⚖️ **Side-by-Side Comparison** - Compare up to 5 schools simultaneously
|
|
||||||
- 🏆 **Rankings** - View top-performing primary schools by various KS2 metrics
|
|
||||||
- 📱 **Responsive Design** - Works beautifully on desktop and mobile
|
|
||||||
|
|
||||||
## Key Metrics (KS2)
|
| Path | Responsibility |
|
||||||
|
|---|---|
|
||||||
|
| `backend/` | FastAPI routes, cached school data, read-only SQLAlchemy mappings, feature flags |
|
||||||
|
| `nextjs-app/` | Next.js App Router, React UI, Payload CMS, frontend tests |
|
||||||
|
| `pipeline/plugins/extractors/` | Custom Singer taps for GIAS, EES, Ofsted and other datasets |
|
||||||
|
| `pipeline/transform/` | dbt staging/intermediate models, marts, seeds and data tests |
|
||||||
|
| `pipeline/dags/` | Airflow extraction, transformation and publication workflows |
|
||||||
|
| `pipeline/scripts/` | Search indexing, code generation and operational diagnostics |
|
||||||
|
| `e2e/` | Playwright journeys against a running environment |
|
||||||
|
| `.gitea/workflows/` | PR checks, staging deployment and manual production promotion |
|
||||||
|
| `scripts/` | CI review tooling and historical data utilities; see the legacy inventory |
|
||||||
|
| `docs/superpowers/`, `mockups/` | Design history and prototypes, not application entry points |
|
||||||
|
|
||||||
The application tracks these Key Stage 2 performance indicators:
|
## Runtime
|
||||||
|
|
||||||
| Metric | Description |
|
The public site is **Next.js**, not the FastAPI root page. Browser `/api/*`
|
||||||
|--------|-------------|
|
requests pass through a Next.js route handler to FastAPI. Server-rendered pages
|
||||||
| **Reading Progress** | Progress in reading from KS1 to KS2 |
|
call FastAPI directly using `FASTAPI_URL`, including its `/api` suffix.
|
||||||
| **Writing Progress** | Progress in writing from KS1 to KS2 |
|
|
||||||
| **Maths Progress** | Progress in maths from KS1 to KS2 |
|
|
||||||
| **Reading Expected %** | Percentage meeting expected standard in reading |
|
|
||||||
| **Writing Expected %** | Percentage meeting expected standard in writing |
|
|
||||||
| **Maths Expected %** | Percentage meeting expected standard in maths |
|
|
||||||
| **Reading, Writing & Maths Combined %** | Percentage meeting expected standard in all three subjects |
|
|
||||||
|
|
||||||
## Quick Start
|
PostgreSQL/PostGIS stores school data. Meltano/Singer extracts source data;
|
||||||
|
dbt builds `marts.*`; FastAPI reads those tables. Typesense serves text search
|
||||||
|
and autocomplete. Payload runs inside Next.js and owns a separate `payload`
|
||||||
|
database schema and uploaded media.
|
||||||
|
|
||||||
### 1. Clone and Setup
|
There is **no automatic CSV import or sample dataset on startup**. A working
|
||||||
|
school-data environment needs populated marts from the pipeline or an approved
|
||||||
|
database snapshot. See [development](docs/DEVELOPMENT.md) before choosing a setup.
|
||||||
|
|
||||||
```bash
|
## Validation
|
||||||
cd school_results
|
|
||||||
|
|
||||||
# Create virtual environment
|
```sh
|
||||||
python -m venv venv
|
cd nextjs-app
|
||||||
source venv/bin/activate # On Windows: venv\Scripts\activate
|
npm ci
|
||||||
|
npm run typecheck
|
||||||
# Install dependencies
|
npm test -- --runInBand
|
||||||
pip install -r requirements.txt
|
|
||||||
```
|
```
|
||||||
|
|
||||||
### 2. Run the Application
|
Backend checks, pipeline validation, runtime versions and E2E requirements are
|
||||||
|
listed in [DEVELOPMENT.md](docs/DEVELOPMENT.md). No `npm run lint` script is
|
||||||
|
currently defined.
|
||||||
|
|
||||||
```bash
|
## Deployment
|
||||||
# Start the server
|
|
||||||
python -m uvicorn backend.app:app --reload --port 8000
|
|
||||||
```
|
|
||||||
|
|
||||||
Then open http://localhost:8000 in your browser.
|
|
||||||
|
|
||||||
The app will run with **sample data** by default, showing **110 primary schools** (66 in Wandsworth, 44 in Merton) with 5 years of KS2 performance data.
|
|
||||||
|
|
||||||
### 3. (Optional) Use Real Data
|
|
||||||
|
|
||||||
To use real UK school performance data:
|
|
||||||
|
|
||||||
1. Visit [Compare School Performance - Download Data](https://www.compare-school-performance.service.gov.uk/download-data)
|
|
||||||
|
|
||||||
2. Download **Key Stage 2** data for the years you want (2019-2024)
|
|
||||||
- Select "Key Stage 2" as the data type
|
|
||||||
|
|
||||||
3. Place the CSV files in the `data/` folder
|
|
||||||
|
|
||||||
4. Restart the server - it will automatically load and filter to Wandsworth & Merton schools
|
|
||||||
|
|
||||||
**Note:** The app only displays schools in Wandsworth and Merton. Data from other areas will be filtered out.
|
|
||||||
|
|
||||||
See the helper script for more details:
|
|
||||||
```bash
|
|
||||||
python scripts/download_data.py
|
|
||||||
```
|
|
||||||
|
|
||||||
## Project Structure
|
|
||||||
|
|
||||||
```
|
|
||||||
school_results/
|
|
||||||
├── backend/
|
|
||||||
│ └── app.py # FastAPI application with all API endpoints
|
|
||||||
├── frontend/
|
|
||||||
│ ├── index.html # Main HTML page
|
|
||||||
│ ├── styles.css # Styling (warm, editorial design)
|
|
||||||
│ └── app.js # Frontend JavaScript
|
|
||||||
├── data/
|
|
||||||
│ └── .gitkeep # Place CSV data files here
|
|
||||||
├── scripts/
|
|
||||||
│ └── download_data.py # Helper for downloading/processing data
|
|
||||||
├── requirements.txt # Python dependencies
|
|
||||||
└── README.md
|
|
||||||
```
|
|
||||||
|
|
||||||
## API Endpoints
|
|
||||||
|
|
||||||
| Endpoint | Description |
|
|
||||||
|----------|-------------|
|
|
||||||
| `GET /api/schools` | List schools with optional search/filter |
|
|
||||||
| `GET /api/schools/{urn}` | Get detailed data for a specific school |
|
|
||||||
| `GET /api/compare?urns=...` | Compare multiple schools |
|
|
||||||
| `GET /api/rankings` | Get school rankings by metric |
|
|
||||||
| `GET /api/filters` | Get available filter options |
|
|
||||||
| `GET /api/metrics` | Get available performance metrics |
|
|
||||||
|
|
||||||
### Example API Usage
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Search for schools
|
|
||||||
curl "http://localhost:8000/api/schools?search=academy"
|
|
||||||
|
|
||||||
# Get school details
|
|
||||||
curl "http://localhost:8000/api/schools/100001"
|
|
||||||
|
|
||||||
# Compare schools
|
|
||||||
curl "http://localhost:8000/api/compare?urns=100001,100002,100003"
|
|
||||||
|
|
||||||
# Get rankings
|
|
||||||
curl "http://localhost:8000/api/rankings?metric=rwm_expected_pct&year=2024"
|
|
||||||
```
|
|
||||||
|
|
||||||
## Data Format
|
|
||||||
|
|
||||||
If using your own CSV data, ensure it includes these columns (or similar):
|
|
||||||
|
|
||||||
| Column | Type | Description |
|
|
||||||
|--------|------|-------------|
|
|
||||||
| URN | Integer | Unique Reference Number |
|
|
||||||
| SCHNAME | String | School name |
|
|
||||||
| LA | String | Local Authority (must be Wandsworth or Merton) |
|
|
||||||
| READPROG | Float | Reading progress score |
|
|
||||||
| WRITPROG | Float | Writing progress score |
|
|
||||||
| MATPROG | Float | Maths progress score |
|
|
||||||
| PTRWM_EXP | Float | % meeting expected standard in reading, writing & maths |
|
|
||||||
| PTREAD_EXP | Float | % meeting expected standard in reading |
|
|
||||||
| PTWRIT_EXP | Float | % meeting expected standard in writing |
|
|
||||||
| PTMAT_EXP | Float | % meeting expected standard in maths |
|
|
||||||
|
|
||||||
The application normalizes column names automatically and filters to only show Wandsworth and Merton schools.
|
|
||||||
|
|
||||||
## Technology Stack
|
|
||||||
|
|
||||||
- **Backend**: FastAPI (Python) - High-performance async API framework
|
|
||||||
- **Frontend**: Vanilla JavaScript with Chart.js
|
|
||||||
- **Styling**: Custom CSS with CSS variables for theming
|
|
||||||
- **Data**: Pandas for CSV processing
|
|
||||||
|
|
||||||
## Design Philosophy
|
|
||||||
|
|
||||||
The UI features a warm, editorial design inspired by quality publications:
|
|
||||||
- **Typography**: DM Sans for body text, Playfair Display for headings
|
|
||||||
- **Color Palette**: Warm cream background with coral and teal accents
|
|
||||||
- **Interactions**: Smooth animations and hover effects
|
|
||||||
- **Charts**: Clean, readable data visualizations
|
|
||||||
|
|
||||||
## Development
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Run with auto-reload
|
|
||||||
python -m uvicorn backend.app:app --reload --port 8000
|
|
||||||
|
|
||||||
# Or run directly
|
|
||||||
python backend/app.py
|
|
||||||
```
|
|
||||||
|
|
||||||
## Coverage
|
|
||||||
|
|
||||||
This application is specifically designed for:
|
|
||||||
|
|
||||||
- **School Phase**: Primary schools only (Key Stage 2)
|
|
||||||
- **Geographic Area**: Wandsworth and Merton (London boroughs)
|
|
||||||
- **Time Period**: Last 5 years of data (2020-2024)
|
|
||||||
|
|
||||||
Note: 2021 data shows as unavailable because SATs were cancelled due to COVID-19.
|
|
||||||
|
|
||||||
## Data Source
|
|
||||||
|
|
||||||
Data is sourced from the UK Government's [Compare School Performance](https://www.compare-school-performance.service.gov.uk/) service, which provides official school performance data for England.
|
|
||||||
|
|
||||||
**Important**: When using real data, please comply with the [terms of use](https://www.compare-school-performance.service.gov.uk/download-data) and data protection regulations.
|
|
||||||
|
|
||||||
## Scheduled Jobs
|
|
||||||
|
|
||||||
### Geocoding Schools (Cron Job)
|
|
||||||
|
|
||||||
School postcodes are geocoded by a scheduled job, not on-demand. This improves performance and reduces API calls.
|
|
||||||
|
|
||||||
**Setup the cron job** (runs weekly on Sunday at 2am):
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Edit crontab
|
|
||||||
crontab -e
|
|
||||||
|
|
||||||
# Add this line (adjust paths as needed):
|
|
||||||
0 2 * * 0 cd /path/to/school_compare && /path/to/venv/bin/python scripts/geocode_schools.py >> /var/log/geocode_schools.log 2>&1
|
|
||||||
```
|
|
||||||
|
|
||||||
**Manual run:**
|
|
||||||
```bash
|
|
||||||
# Geocode only schools missing coordinates
|
|
||||||
python scripts/geocode_schools.py
|
|
||||||
|
|
||||||
# Force re-geocode all schools
|
|
||||||
python scripts/geocode_schools.py --force
|
|
||||||
```
|
|
||||||
|
|
||||||
## License
|
|
||||||
|
|
||||||
MIT License - feel free to use this project for educational purposes.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
Built with ❤️ for Wandsworth & Merton families
|
|
||||||
|
|
||||||
|
Work on a feature branch and open a PR. Merging to `main` builds images and
|
||||||
|
deploys staging. Production promotion is a separate, human-triggered Gitea
|
||||||
|
workflow. Use [DEPLOY.md](docs/DEPLOY.md) and the Portainer compose files as the
|
||||||
|
operational references. The generic compose examples still reference `:latest`,
|
||||||
|
which the current release workflow does not publish.
|
||||||
+251
-54
@@ -26,7 +26,8 @@ from starlette.middleware.base import BaseHTTPMiddleware
|
|||||||
import asyncio
|
import asyncio
|
||||||
from .config import settings
|
from .config import settings
|
||||||
from .data_loader import (
|
from .data_loader import (
|
||||||
clear_cache,
|
build_latest_school_data,
|
||||||
|
load_school_data_as_dataframe,
|
||||||
compute_benchmarks,
|
compute_benchmarks,
|
||||||
load_school_data,
|
load_school_data,
|
||||||
load_latest_school_data,
|
load_latest_school_data,
|
||||||
@@ -38,21 +39,22 @@ from .data_loader import (
|
|||||||
)
|
)
|
||||||
from .data_loader import get_data_info as get_db_info
|
from .data_loader import get_data_info as get_db_info
|
||||||
from . import flags
|
from . import flags
|
||||||
from .places import build_place_registry
|
from .places import build_place_index, build_place_registry, places_for_urn
|
||||||
from .schemas import METRIC_DEFINITIONS, RANKING_COLUMNS, SCHOOL_COLUMNS
|
from .schemas import METRIC_DEFINITIONS, PHASE_GROUPS, PHASE_ORDER, RANKING_COLUMNS, SCHOOL_COLUMNS
|
||||||
|
from .school_groups import (
|
||||||
|
FAITH_GROUPS,
|
||||||
|
FAITH_KEYS,
|
||||||
|
TYPE_GROUPS,
|
||||||
|
faith_groups_for,
|
||||||
|
type_group_for,
|
||||||
|
type_group_key,
|
||||||
|
)
|
||||||
|
from .nearby_schools import select_nearby
|
||||||
from .utils import clean_for_json, convert_to_native
|
from .utils import clean_for_json, convert_to_native
|
||||||
|
|
||||||
# Values to exclude from filter dropdowns (empty strings, non-applicable labels)
|
# Values to exclude from filter dropdowns (empty strings, non-applicable labels)
|
||||||
EXCLUDED_FILTER_VALUES = {"", "Not applicable", "Does not apply"}
|
EXCLUDED_FILTER_VALUES = {"", "Not applicable", "Does not apply"}
|
||||||
|
|
||||||
# Maps user-facing phase filter values to the GIAS PhaseOfEducation values they include.
|
|
||||||
# All-through schools appear in both primary and secondary results.
|
|
||||||
PHASE_GROUPS: dict[str, set[str]] = {
|
|
||||||
"primary": {"primary", "middle deemed primary", "all-through"},
|
|
||||||
"secondary": {"secondary", "middle deemed secondary", "all-through", "16 plus"},
|
|
||||||
"all-through": {"all-through"},
|
|
||||||
}
|
|
||||||
|
|
||||||
# Must match SITE_URL in nextjs-app/lib/site.ts. The apex 301s to www, and a
|
# Must match SITE_URL in nextjs-app/lib/site.ts. The apex 301s to www, and a
|
||||||
# sitemap <loc> that redirects wastes a crawl on every URL it lists.
|
# sitemap <loc> that redirects wastes a crawl on every URL it lists.
|
||||||
BASE_URL = "https://www.schoolcompare.co.uk"
|
BASE_URL = "https://www.schoolcompare.co.uk"
|
||||||
@@ -65,6 +67,10 @@ _sitemaps: dict[str, str] | None = None
|
|||||||
# Built from the same DataFrame the sitemap uses, so places and sitemap can
|
# Built from the same DataFrame the sitemap uses, so places and sitemap can
|
||||||
# never describe different corpora. Reset by the same admin endpoint.
|
# never describe different corpora. Reset by the same admin endpoint.
|
||||||
_place_registry: dict | None = None
|
_place_registry: dict | None = None
|
||||||
|
# Cached beside the registry, and invalidated by identity against it — see
|
||||||
|
# get_place_index. Never cleared independently.
|
||||||
|
_place_index: dict | None = None
|
||||||
|
_place_index_source: dict | None = None
|
||||||
|
|
||||||
VALID_PLACE_KINDS = ("town", "locality", "authority", "outcode")
|
VALID_PLACE_KINDS = ("town", "locality", "authority", "outcode")
|
||||||
|
|
||||||
@@ -111,7 +117,7 @@ def _has_publishable_data(row) -> bool:
|
|||||||
|
|
||||||
|
|
||||||
def _url_element(loc: str, lastmod: str | None = None) -> str:
|
def _url_element(loc: str, lastmod: str | None = None) -> str:
|
||||||
"""One <url> entry. No priority or changefreq — Google ignores both."""
|
"""One <url> entry. No priority or changefreq, Google ignores both."""
|
||||||
body = f"<loc>{loc}</loc>"
|
body = f"<loc>{loc}</loc>"
|
||||||
if lastmod:
|
if lastmod:
|
||||||
body += f"<lastmod>{lastmod}</lastmod>"
|
body += f"<lastmod>{lastmod}</lastmod>"
|
||||||
@@ -188,6 +194,24 @@ def get_place_registry() -> dict:
|
|||||||
return _place_registry
|
return _place_registry
|
||||||
|
|
||||||
|
|
||||||
|
def get_place_index() -> dict:
|
||||||
|
"""URN → its published places, cached against the registry it came from.
|
||||||
|
|
||||||
|
Invalidation is an identity check rather than a second flag to remember to
|
||||||
|
clear. Anything that drops `_place_registry` — the tests all do — gets a
|
||||||
|
fresh registry object here, which no longer matches the one the index was
|
||||||
|
built from, so the index rebuilds with it. A separate `_place_index = None`
|
||||||
|
would be one more thing to forget, and a stale reverse index is exactly the
|
||||||
|
bug that would put links to another dataset's places on a school page.
|
||||||
|
"""
|
||||||
|
global _place_index, _place_index_source
|
||||||
|
registry = get_place_registry()
|
||||||
|
if _place_index is None or _place_index_source is not registry:
|
||||||
|
_place_index = build_place_index(registry)
|
||||||
|
_place_index_source = registry
|
||||||
|
return _place_index
|
||||||
|
|
||||||
|
|
||||||
def _urlset(rows: list[str]) -> str:
|
def _urlset(rows: list[str]) -> str:
|
||||||
return "\n".join([
|
return "\n".join([
|
||||||
'<?xml version="1.0" encoding="UTF-8"?>',
|
'<?xml version="1.0" encoding="UTF-8"?>',
|
||||||
@@ -211,7 +235,67 @@ def _place_url(place) -> str:
|
|||||||
return f"/schools/{place.slug}"
|
return f"/schools/{place.slug}"
|
||||||
|
|
||||||
|
|
||||||
def _place_sitemap_rows(kinds: tuple[str, ...]) -> list[str]:
|
def _places_payload(urn: int) -> list[dict]:
|
||||||
|
"""The published places containing this school, as the school page needs
|
||||||
|
them: a name to write in the link, a count so the anchor can say what it
|
||||||
|
leads to, and the canonical path.
|
||||||
|
|
||||||
|
`phases` carries the phase variants this school actually appears on, which
|
||||||
|
is usually one and is two for an all-through school — it is listed on both
|
||||||
|
pages, so there is no tie to break.
|
||||||
|
|
||||||
|
Membership is read straight from the registry's own `phase_urns` rather
|
||||||
|
than re-derived from the school's phase string. The registry is the one
|
||||||
|
place that decides which phases a place publishes and who is on them;
|
||||||
|
computing it a second time here is how a page comes to link a school to a
|
||||||
|
phase page that does not list it, or to a route that does not exist. That
|
||||||
|
is also why outcodes need no special case: they carry empty `phase_urns`,
|
||||||
|
so they report no phase links on their own.
|
||||||
|
"""
|
||||||
|
payload = []
|
||||||
|
for place in places_for_urn(get_place_index(), int(urn)):
|
||||||
|
phases = [
|
||||||
|
{
|
||||||
|
"phase": phase,
|
||||||
|
"count": len(phase_urns),
|
||||||
|
"url": f"{_place_url(place)}/{phase}",
|
||||||
|
}
|
||||||
|
for phase, phase_urns in sorted(place.phase_urns.items())
|
||||||
|
if int(urn) in phase_urns
|
||||||
|
]
|
||||||
|
payload.append({
|
||||||
|
"kind": place.kind,
|
||||||
|
"slug": place.slug,
|
||||||
|
"name": place.name,
|
||||||
|
"count": len(place.urns),
|
||||||
|
"url": _place_url(place),
|
||||||
|
"phases": phases,
|
||||||
|
})
|
||||||
|
return payload
|
||||||
|
|
||||||
|
|
||||||
|
def _nearby_schools_payload(urn: int) -> list[dict]:
|
||||||
|
"""The nearest eligible schools this page may offer, closest first.
|
||||||
|
|
||||||
|
Phase and reach are read from the school's own row inside select_nearby,
|
||||||
|
so nothing here can hand it a phase that disagrees with the data.
|
||||||
|
|
||||||
|
Wrapped: a failure in selection must never 500 a page that is otherwise
|
||||||
|
complete, which is the posture get_supplementary_data already takes. The
|
||||||
|
section simply does not render.
|
||||||
|
"""
|
||||||
|
try:
|
||||||
|
return select_nearby(load_latest_school_data(), int(urn))
|
||||||
|
except Exception:
|
||||||
|
import logging
|
||||||
|
|
||||||
|
logging.getLogger(__name__).exception(
|
||||||
|
"Nearby schools selection failed for urn=%s", urn
|
||||||
|
)
|
||||||
|
return []
|
||||||
|
|
||||||
|
|
||||||
|
def _place_sitemap_rows(kinds: tuple[str, ...], registry=None) -> list[str]:
|
||||||
"""A <url> per place, plus a phase variant wherever that phase clears the
|
"""A <url> per place, plus a phase variant wherever that phase clears the
|
||||||
threshold on its own.
|
threshold on its own.
|
||||||
|
|
||||||
@@ -221,7 +305,9 @@ def _place_sitemap_rows(kinds: tuple[str, ...]) -> list[str]:
|
|||||||
linked from the place page either.
|
linked from the place page either.
|
||||||
"""
|
"""
|
||||||
rows: list[str] = []
|
rows: list[str] = []
|
||||||
for p in sorted(get_place_registry().values(), key=lambda p: (p.kind, p.slug)):
|
if registry is None:
|
||||||
|
registry = get_place_registry()
|
||||||
|
for p in sorted(registry.values(), key=lambda p: (p.kind, p.slug)):
|
||||||
if p.kind not in kinds:
|
if p.kind not in kinds:
|
||||||
continue
|
continue
|
||||||
rows.append(_url_element(BASE_URL + _place_url(p)))
|
rows.append(_url_element(BASE_URL + _place_url(p)))
|
||||||
@@ -235,9 +321,10 @@ def _place_sitemap_rows(kinds: tuple[str, ...]) -> list[str]:
|
|||||||
return rows
|
return rows
|
||||||
|
|
||||||
|
|
||||||
def build_sitemaps() -> dict[str, str]:
|
def build_sitemaps(df=None, registry=None) -> dict[str, str]:
|
||||||
"""Build the sitemap index and every child, keyed by name."""
|
"""Build the sitemap index and every child, keyed by name."""
|
||||||
df = load_school_data()
|
if df is None:
|
||||||
|
df = load_school_data()
|
||||||
|
|
||||||
children: dict[str, str] = {
|
children: dict[str, str] = {
|
||||||
"static.xml": _urlset(
|
"static.xml": _urlset(
|
||||||
@@ -257,7 +344,7 @@ def build_sitemaps() -> dict[str, str]:
|
|||||||
# measured apart from the school pages'.
|
# measured apart from the school pages'.
|
||||||
for label, kinds in (("places", ("town", "locality", "authority")),
|
for label, kinds in (("places", ("town", "locality", "authority")),
|
||||||
("outcodes", ("outcode",))):
|
("outcodes", ("outcode",))):
|
||||||
rows = _place_sitemap_rows(kinds)
|
rows = _place_sitemap_rows(kinds, registry)
|
||||||
chunks = [rows[i:i + SITEMAP_CHUNK_SIZE]
|
chunks = [rows[i:i + SITEMAP_CHUNK_SIZE]
|
||||||
for i in range(0, len(rows), SITEMAP_CHUNK_SIZE)] or [[]]
|
for i in range(0, len(rows), SITEMAP_CHUNK_SIZE)] or [[]]
|
||||||
for n, chunk in enumerate(chunks, start=1):
|
for n, chunk in enumerate(chunks, start=1):
|
||||||
@@ -294,6 +381,12 @@ def clean_filter_values(series: pd.Series) -> list[str]:
|
|||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def order_phases(phases: list[str]) -> list[str]:
|
||||||
|
"""Phases in the order a child meets them; any GIAS adds later follow, A-Z."""
|
||||||
|
rank = {p: i for i, p in enumerate(PHASE_ORDER)}
|
||||||
|
return sorted(phases, key=lambda p: (rank.get(p.lower(), len(rank)), p))
|
||||||
|
|
||||||
|
|
||||||
# =============================================================================
|
# =============================================================================
|
||||||
# SECURITY MIDDLEWARE & HELPERS
|
# SECURITY MIDDLEWARE & HELPERS
|
||||||
# =============================================================================
|
# =============================================================================
|
||||||
@@ -529,6 +622,15 @@ def verify_admin_api_key(x_api_key: str = Header(None)) -> bool:
|
|||||||
|
|
||||||
|
|
||||||
# Input validation helpers
|
# Input validation helpers
|
||||||
|
def _names_in_group(names: pd.Series, in_group) -> set:
|
||||||
|
"""The distinct names in a column that a group predicate accepts.
|
||||||
|
|
||||||
|
Evaluated once per distinct name rather than per row, so a filter over
|
||||||
|
every school costs a few dozen lookups.
|
||||||
|
"""
|
||||||
|
return {n for n in names.dropna().unique() if in_group(n)}
|
||||||
|
|
||||||
|
|
||||||
def sanitize_search_input(value: Optional[str], max_length: int = 100) -> Optional[str]:
|
def sanitize_search_input(value: Optional[str], max_length: int = 100) -> Optional[str]:
|
||||||
"""Sanitize search input to prevent injection attacks."""
|
"""Sanitize search input to prevent injection attacks."""
|
||||||
if value is None:
|
if value is None:
|
||||||
@@ -639,6 +741,15 @@ async def get_config():
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
@app.get("/api/release")
|
||||||
|
async def release_identity():
|
||||||
|
import json
|
||||||
|
from pathlib import Path
|
||||||
|
path = Path(__file__).with_name("build-info.json")
|
||||||
|
identity = json.loads(path.read_text()) if path.exists() else {"sha": "development", "build_id": "development"}
|
||||||
|
return JSONResponse(identity, headers={"Cache-Control": "no-store"})
|
||||||
|
|
||||||
|
|
||||||
@app.get("/api/schools")
|
@app.get("/api/schools")
|
||||||
@limiter.limit(f"{settings.rate_limit_per_minute}/minute")
|
@limiter.limit(f"{settings.rate_limit_per_minute}/minute")
|
||||||
async def get_schools(
|
async def get_schools(
|
||||||
@@ -648,7 +759,7 @@ async def get_schools(
|
|||||||
None, description="Filter by local authority", max_length=100
|
None, description="Filter by local authority", max_length=100
|
||||||
),
|
),
|
||||||
school_type: Optional[str] = Query(None, description="Filter by school type", max_length=100),
|
school_type: Optional[str] = Query(None, description="Filter by school type", max_length=100),
|
||||||
phase: Optional[str] = Query(None, description="Filter by phase: primary, secondary, all-through", max_length=50),
|
phase: Optional[str] = Query(None, description="Filter by phase: primary or secondary (grouped), or any GIAS phase name (exact)", max_length=50),
|
||||||
postcode: Optional[str] = Query(None, description="Search near postcode", max_length=10),
|
postcode: Optional[str] = Query(None, description="Search near postcode", max_length=10),
|
||||||
radius: float = Query(5.0, ge=0.1, le=5, description="Search radius in miles"),
|
radius: float = Query(5.0, ge=0.1, le=5, description="Search radius in miles"),
|
||||||
page: int = Query(1, ge=1, le=1000, description="Page number"),
|
page: int = Query(1, ge=1, le=1000, description="Page number"),
|
||||||
@@ -656,6 +767,7 @@ async def get_schools(
|
|||||||
gender: Optional[str] = Query(None, description="Filter by gender (Mixed/Boys/Girls)", max_length=50),
|
gender: Optional[str] = Query(None, description="Filter by gender (Mixed/Boys/Girls)", max_length=50),
|
||||||
admissions_policy: Optional[str] = Query(None, description="Filter by admissions policy", max_length=100),
|
admissions_policy: Optional[str] = Query(None, description="Filter by admissions policy", max_length=100),
|
||||||
has_sixth_form: Optional[str] = Query(None, description="Filter by sixth form presence: yes/no", max_length=3),
|
has_sixth_form: Optional[str] = Query(None, description="Filter by sixth form presence: yes/no", max_length=3),
|
||||||
|
faith: Optional[str] = Query(None, description="Filter by faith group key", max_length=40),
|
||||||
):
|
):
|
||||||
"""
|
"""
|
||||||
Get list of schools with pagination.
|
Get list of schools with pagination.
|
||||||
@@ -668,6 +780,7 @@ async def get_schools(
|
|||||||
local_authority = sanitize_search_input(local_authority)
|
local_authority = sanitize_search_input(local_authority)
|
||||||
school_type = sanitize_search_input(school_type)
|
school_type = sanitize_search_input(school_type)
|
||||||
phase = sanitize_search_input(phase)
|
phase = sanitize_search_input(phase)
|
||||||
|
faith = sanitize_search_input(faith)
|
||||||
postcode = validate_postcode(postcode)
|
postcode = validate_postcode(postcode)
|
||||||
|
|
||||||
# Load the pre-computed latest-year snapshot (cached after first request / startup).
|
# Load the pre-computed latest-year snapshot (cached after first request / startup).
|
||||||
@@ -675,7 +788,7 @@ async def get_schools(
|
|||||||
df_latest = load_latest_school_data()
|
df_latest = load_latest_school_data()
|
||||||
|
|
||||||
if df_latest.empty:
|
if df_latest.empty:
|
||||||
return {"schools": [], "total": 0, "page": page, "page_size": 0}
|
raise HTTPException(status_code=503, detail="School data temporarily unavailable")
|
||||||
|
|
||||||
# Use configured default if not specified
|
# Use configured default if not specified
|
||||||
if page_size is None:
|
if page_size is None:
|
||||||
@@ -683,11 +796,13 @@ async def get_schools(
|
|||||||
|
|
||||||
# Phase filter — uses PHASE_GROUPS so all-through/middle schools appear
|
# Phase filter — uses PHASE_GROUPS so all-through/middle schools appear
|
||||||
# in the correct phase(s) rather than being invisible to both filters.
|
# in the correct phase(s) rather than being invisible to both filters.
|
||||||
|
# Any other GIAS phase (nursery, 16 plus, middle deemed ...) is an exact
|
||||||
|
# match. It must never fall through to no filter: the search page offers
|
||||||
|
# every phase, and "Nursery" used to return the whole result set.
|
||||||
if phase:
|
if phase:
|
||||||
phase_lower = phase.lower().replace("_", "-")
|
phase_lower = phase.lower().replace("_", "-")
|
||||||
allowed = PHASE_GROUPS.get(phase_lower)
|
allowed = PHASE_GROUPS.get(phase_lower, {phase_lower})
|
||||||
if allowed:
|
df_latest = df_latest[df_latest["phase"].fillna("").str.lower().isin(allowed)]
|
||||||
df_latest = df_latest[df_latest["phase"].str.lower().isin(allowed)]
|
|
||||||
|
|
||||||
# Secondary-specific filters (after phase filter)
|
# Secondary-specific filters (after phase filter)
|
||||||
if gender:
|
if gender:
|
||||||
@@ -706,6 +821,22 @@ async def get_schools(
|
|||||||
flag = df_latest["age_range"].str.contains("18", na=False)
|
flag = df_latest["age_range"].str.contains("18", na=False)
|
||||||
df_latest = df_latest[flag if has_sixth_form == "yes" else ~flag]
|
df_latest = df_latest[flag if has_sixth_form == "yes" else ~flag]
|
||||||
|
|
||||||
|
# Faith group (backend/school_groups.py). A joint school is in every faith
|
||||||
|
# its label names; a missing religious character is "none". An unknown key
|
||||||
|
# matches nothing rather than being ignored, so a typo cannot show all.
|
||||||
|
if faith:
|
||||||
|
faith_key = faith.lower()
|
||||||
|
if faith_key in FAITH_KEYS and "religious_denomination" in df_latest.columns:
|
||||||
|
column = df_latest["religious_denomination"]
|
||||||
|
matches = column.isin(_names_in_group(column, lambda n: faith_key in faith_groups_for(n)))
|
||||||
|
# _names_in_group skips missing names; a missing religious
|
||||||
|
# character is "No religious character".
|
||||||
|
if faith_key == "none":
|
||||||
|
matches = matches | column.isna()
|
||||||
|
df_latest = df_latest[matches]
|
||||||
|
else:
|
||||||
|
df_latest = df_latest.iloc[0:0]
|
||||||
|
|
||||||
# Include key result metrics for display on cards
|
# Include key result metrics for display on cards
|
||||||
location_cols = ["latitude", "longitude"]
|
location_cols = ["latitude", "longitude"]
|
||||||
result_cols = [
|
result_cols = [
|
||||||
@@ -774,8 +905,8 @@ async def get_schools(
|
|||||||
|
|
||||||
# Apply filters
|
# Apply filters
|
||||||
if search:
|
if search:
|
||||||
ts_urns = search_schools_typesense(search)
|
ts_urns = await asyncio.to_thread(search_schools_typesense, search)
|
||||||
if ts_urns:
|
if ts_urns is not None:
|
||||||
urn_order = {urn: i for i, urn in enumerate(ts_urns)}
|
urn_order = {urn: i for i, urn in enumerate(ts_urns)}
|
||||||
schools_df = schools_df[schools_df["urn"].isin(set(ts_urns))].copy()
|
schools_df = schools_df[schools_df["urn"].isin(set(ts_urns))].copy()
|
||||||
schools_df["_ts_rank"] = schools_df["urn"].map(urn_order)
|
schools_df["_ts_rank"] = schools_df["urn"].map(urn_order)
|
||||||
@@ -783,9 +914,9 @@ async def get_schools(
|
|||||||
else:
|
else:
|
||||||
# Fallback: Typesense unavailable, use substring match
|
# Fallback: Typesense unavailable, use substring match
|
||||||
search_lower = search.lower()
|
search_lower = search.lower()
|
||||||
mask = schools_df["school_name"].str.lower().str.contains(search_lower, na=False)
|
mask = schools_df["school_name"].str.lower().str.contains(search_lower, na=False, regex=False)
|
||||||
if "address" in schools_df.columns:
|
if "address" in schools_df.columns:
|
||||||
mask = mask | schools_df["address"].str.lower().str.contains(search_lower, na=False)
|
mask = mask | schools_df["address"].str.lower().str.contains(search_lower, na=False, regex=False)
|
||||||
schools_df = schools_df[mask]
|
schools_df = schools_df[mask]
|
||||||
|
|
||||||
if local_authority:
|
if local_authority:
|
||||||
@@ -793,10 +924,17 @@ async def get_schools(
|
|||||||
schools_df["local_authority"].str.lower() == local_authority.lower()
|
schools_df["local_authority"].str.lower() == local_authority.lower()
|
||||||
]
|
]
|
||||||
|
|
||||||
|
# A type group key (backend/school_groups.py), old keys included, or for
|
||||||
|
# an old link a raw GIAS type label, matched exactly as before.
|
||||||
if school_type:
|
if school_type:
|
||||||
schools_df = schools_df[
|
type_key = type_group_key(school_type)
|
||||||
schools_df["school_type"].str.lower() == school_type.lower()
|
if type_key:
|
||||||
]
|
column = schools_df["school_type"]
|
||||||
|
schools_df = schools_df[
|
||||||
|
column.isin(_names_in_group(column, lambda n: type_group_for(n) == type_key))
|
||||||
|
]
|
||||||
|
else:
|
||||||
|
schools_df = schools_df[schools_df["school_type"].str.lower() == school_type.lower()]
|
||||||
|
|
||||||
# Compute result-scoped filter values (before pagination).
|
# Compute result-scoped filter values (before pagination).
|
||||||
# Gender and admissions are secondary-only filters — scope them to schools
|
# Gender and admissions are secondary-only filters — scope them to schools
|
||||||
@@ -805,7 +943,7 @@ async def get_schools(
|
|||||||
result_filters = {
|
result_filters = {
|
||||||
"local_authorities": clean_filter_values(schools_df["local_authority"]) if "local_authority" in schools_df.columns else [],
|
"local_authorities": clean_filter_values(schools_df["local_authority"]) if "local_authority" in schools_df.columns else [],
|
||||||
"school_types": clean_filter_values(schools_df["school_type"]) if "school_type" in schools_df.columns else [],
|
"school_types": clean_filter_values(schools_df["school_type"]) if "school_type" in schools_df.columns else [],
|
||||||
"phases": clean_filter_values(schools_df["phase"]) if "phase" in schools_df.columns else [],
|
"phases": order_phases(clean_filter_values(schools_df["phase"])) if "phase" in schools_df.columns else [],
|
||||||
"genders": clean_filter_values(schools_df.loc[_sec_mask, "gender"]) if "gender" in schools_df.columns and _sec_mask.any() else [],
|
"genders": clean_filter_values(schools_df.loc[_sec_mask, "gender"]) if "gender" in schools_df.columns and _sec_mask.any() else [],
|
||||||
"admissions_policies": clean_filter_values(schools_df.loc[_sec_mask, "admissions_policy"]) if "admissions_policy" in schools_df.columns and _sec_mask.any() else [],
|
"admissions_policies": clean_filter_values(schools_df.loc[_sec_mask, "admissions_policy"]) if "admissions_policy" in schools_df.columns and _sec_mask.any() else [],
|
||||||
}
|
}
|
||||||
@@ -844,7 +982,7 @@ async def get_school_details(request: Request, urn: int):
|
|||||||
df = load_school_data()
|
df = load_school_data()
|
||||||
|
|
||||||
if df.empty:
|
if df.empty:
|
||||||
raise HTTPException(status_code=404, detail="No data available")
|
raise HTTPException(status_code=503, detail="School data temporarily unavailable")
|
||||||
|
|
||||||
school_data = df[df["urn"] == urn]
|
school_data = df[df["urn"] == urn]
|
||||||
|
|
||||||
@@ -902,6 +1040,17 @@ async def get_school_details(request: Request, urn: int):
|
|||||||
|
|
||||||
return {
|
return {
|
||||||
"school_info": school_info,
|
"school_info": school_info,
|
||||||
|
# Where this school sits in the location layer, for the page's link
|
||||||
|
# module and breadcrumb. Derived from the same registry the place
|
||||||
|
# pages and the sitemap use, so a link is never offered for a page
|
||||||
|
# that does not exist. Empty is a valid answer: a school whose town
|
||||||
|
# and authority both fall below the publish threshold has nowhere to
|
||||||
|
# point, and the page renders without the module.
|
||||||
|
"places": _places_payload(urn),
|
||||||
|
# The nearest eligible schools, closest first. Always present on a
|
||||||
|
# build with this code; the frontend treats absent and empty
|
||||||
|
# identically, which is what lets the two images deploy independently.
|
||||||
|
"nearby_schools": _nearby_schools_payload(urn),
|
||||||
"yearly_data": clean_for_json(school_data),
|
"yearly_data": clean_for_json(school_data),
|
||||||
# Supplementary data (null if not yet populated by Kestra)
|
# Supplementary data (null if not yet populated by Kestra)
|
||||||
"ofsted": supplementary.get("ofsted"),
|
"ofsted": supplementary.get("ofsted"),
|
||||||
@@ -1060,15 +1209,29 @@ async def get_filter_options(request: Request):
|
|||||||
"local_authorities": [],
|
"local_authorities": [],
|
||||||
"school_types": [],
|
"school_types": [],
|
||||||
"years": [],
|
"years": [],
|
||||||
|
"school_type_groups": [],
|
||||||
|
"faiths": [],
|
||||||
}
|
}
|
||||||
|
|
||||||
# Phases: return values from data, ordered sensibly
|
# Phases: the values in the data, in the order a child meets them
|
||||||
phases = clean_filter_values(df["phase"]) if "phase" in df.columns else []
|
phases = order_phases(clean_filter_values(df["phase"])) if "phase" in df.columns else []
|
||||||
|
|
||||||
secondary_df = df[df["attainment_8_score"].notna()] if "attainment_8_score" in df.columns else df.iloc[0:0]
|
secondary_df = df[df["attainment_8_score"].notna()] if "attainment_8_score" in df.columns else df.iloc[0:0]
|
||||||
genders = clean_filter_values(secondary_df["gender"]) if "gender" in secondary_df.columns else []
|
genders = clean_filter_values(secondary_df["gender"]) if "gender" in secondary_df.columns else []
|
||||||
admissions_policies = clean_filter_values(secondary_df["admissions_policy"]) if "admissions_policy" in secondary_df.columns else []
|
admissions_policies = clean_filter_values(secondary_df["admissions_policy"]) if "admissions_policy" in secondary_df.columns else []
|
||||||
|
|
||||||
|
def offered(groups, present):
|
||||||
|
return [{"value": key, "label": label} for key, label, _ in groups if key in present]
|
||||||
|
|
||||||
|
type_groups_present = (
|
||||||
|
{type_group_for(n) for n in df["school_type"].dropna().unique()} - {None}
|
||||||
|
if "school_type" in df.columns else set()
|
||||||
|
)
|
||||||
|
faiths_present = (
|
||||||
|
{f for n in df["religious_denomination"].unique() for f in faith_groups_for(n)}
|
||||||
|
if "religious_denomination" in df.columns else set()
|
||||||
|
)
|
||||||
|
|
||||||
return {
|
return {
|
||||||
"local_authorities": clean_filter_values(df["local_authority"]) if "local_authority" in df.columns else [],
|
"local_authorities": clean_filter_values(df["local_authority"]) if "local_authority" in df.columns else [],
|
||||||
"school_types": clean_filter_values(df["school_type"]) if "school_type" in df.columns else [],
|
"school_types": clean_filter_values(df["school_type"]) if "school_type" in df.columns else [],
|
||||||
@@ -1076,6 +1239,8 @@ async def get_filter_options(request: Request):
|
|||||||
"phases": phases,
|
"phases": phases,
|
||||||
"genders": genders,
|
"genders": genders,
|
||||||
"admissions_policies": admissions_policies,
|
"admissions_policies": admissions_policies,
|
||||||
|
"school_type_groups": offered(TYPE_GROUPS, type_groups_present),
|
||||||
|
"faiths": offered(FAITH_GROUPS, faiths_present),
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
@@ -1474,20 +1639,51 @@ async def get_data_info(request: Request):
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
_publication_lock = asyncio.Lock()
|
||||||
|
|
||||||
|
|
||||||
|
def _prepare_publication(df):
|
||||||
|
if df.empty:
|
||||||
|
raise ValueError("Refusing to publish an empty school dataset")
|
||||||
|
if not {"urn", "year", "school_name"}.issubset(df.columns):
|
||||||
|
raise ValueError("School dataset is missing required columns")
|
||||||
|
if df["urn"].isna().any() or df.duplicated(["urn", "year"]).any():
|
||||||
|
raise ValueError("School dataset has missing URNs or duplicate school years")
|
||||||
|
latest = build_latest_school_data(df)
|
||||||
|
registry = build_place_registry(df)
|
||||||
|
index = build_place_index(registry)
|
||||||
|
sitemaps = build_sitemaps(df, registry)
|
||||||
|
return df, latest, registry, index, sitemaps
|
||||||
|
|
||||||
|
|
||||||
|
def _publish(prepared):
|
||||||
|
# Called on the event loop with no await: routes cannot observe half a swap.
|
||||||
|
# The application currently runs one worker; replicas require coordination.
|
||||||
|
from . import data_loader
|
||||||
|
global _place_registry, _place_index, _place_index_source, _sitemaps
|
||||||
|
df, latest, registry, index, sitemaps = prepared
|
||||||
|
data_loader._df_cache = df
|
||||||
|
data_loader._df_latest_cache = latest
|
||||||
|
_place_registry = registry
|
||||||
|
_place_index = index
|
||||||
|
_place_index_source = registry
|
||||||
|
_sitemaps = sitemaps
|
||||||
|
|
||||||
|
|
||||||
@app.post("/api/admin/reload")
|
@app.post("/api/admin/reload")
|
||||||
@limiter.limit("5/minute")
|
@limiter.limit("5/minute")
|
||||||
async def reload_data(
|
async def reload_data(request: Request, _: bool = Depends(verify_admin_api_key)):
|
||||||
request: Request,
|
"""Validate a complete replacement before publishing it; retain data on failure."""
|
||||||
_: bool = Depends(verify_admin_api_key)
|
async with _publication_lock:
|
||||||
):
|
try:
|
||||||
"""
|
df = await asyncio.to_thread(load_school_data_as_dataframe)
|
||||||
Admin endpoint to force data reload (useful after data updates).
|
prepared = await asyncio.to_thread(_prepare_publication, df)
|
||||||
Requires X-API-Key header with valid admin API key.
|
except Exception as exc:
|
||||||
"""
|
import logging
|
||||||
clear_cache()
|
logging.getLogger(__name__).exception("Dataset reload failed")
|
||||||
await asyncio.to_thread(load_school_data)
|
raise HTTPException(status_code=503, detail="Dataset reload failed; previous data retained") from exc
|
||||||
await asyncio.to_thread(load_latest_school_data)
|
_publish(prepared)
|
||||||
return {"status": "reloaded"}
|
return {"status": "reloaded", "schools": len(prepared[1])}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
@@ -1539,15 +1735,16 @@ async def regenerate_sitemap(
|
|||||||
request: Request,
|
request: Request,
|
||||||
_: bool = Depends(verify_admin_api_key),
|
_: bool = Depends(verify_admin_api_key),
|
||||||
):
|
):
|
||||||
"""Rebuild and cache the sitemap from current school data. Called by Airflow after data updates."""
|
"""Rebuild derived publication data without clearing the live registry."""
|
||||||
global _sitemaps, _place_registry
|
async with _publication_lock:
|
||||||
# Places and sitemap are rebuilt together — they read the same marts, and
|
try:
|
||||||
# letting them drift apart would submit URLs for places that no longer
|
prepared = await asyncio.to_thread(_prepare_publication, load_school_data())
|
||||||
# exist.
|
except Exception as exc:
|
||||||
_place_registry = None
|
raise HTTPException(status_code=503, detail="Sitemap rebuild failed; previous data retained") from exc
|
||||||
_sitemaps = build_sitemaps()
|
_publish(prepared)
|
||||||
n = sum(x.count("<url>") for x in _sitemaps.values())
|
n = sum(x.count("<url>") for x in prepared[4].values())
|
||||||
return {"status": "ok", "urls": n, "sitemaps": len(_sitemaps)}
|
return {"status": "ok", "urls": n, "sitemaps": len(prepared[4])}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
# Mount static files directly (must be after all routes to avoid catching API calls)
|
# Mount static files directly (must be after all routes to avoid catching API calls)
|
||||||
|
|||||||
+55
-24
@@ -84,21 +84,58 @@ def _get_typesense_client():
|
|||||||
return None
|
return None
|
||||||
|
|
||||||
|
|
||||||
def search_schools_typesense(query: str, limit: int = 250) -> List[int]:
|
SEARCH_PAGE_SIZE = 250
|
||||||
"""Search Typesense. Returns URNs in relevance order, or [] if unavailable."""
|
# Search results are filtered again by the API (authority, phase, postcode,
|
||||||
|
# etc.), so one page is too small for scoped searches. Keep the candidate set
|
||||||
|
# bounded, though: a broad query must not turn into an unbounded sequence of
|
||||||
|
# Typesense requests. Four pages is enough to preserve useful scoped matches
|
||||||
|
# while putting a hard ceiling on latency and upstream load.
|
||||||
|
SEARCH_MAX_CANDIDATES = 1_000
|
||||||
|
|
||||||
|
|
||||||
|
def search_schools_typesense(query: str) -> Optional[List[int]]:
|
||||||
|
"""Return a bounded set of matching URNs in relevance order.
|
||||||
|
|
||||||
|
``None`` means Typesense is unavailable; ``[]`` is a valid zero-match
|
||||||
|
result. The API applies its remaining filters after this search, so the
|
||||||
|
first few pages are fetched rather than only the first page. Once the
|
||||||
|
candidate ceiling is reached, the relevance-ordered prefix is returned on
|
||||||
|
purpose; fetching every match would make common or adversarial queries
|
||||||
|
unbounded.
|
||||||
|
"""
|
||||||
client = _get_typesense_client()
|
client = _get_typesense_client()
|
||||||
if client is None:
|
if client is None:
|
||||||
return []
|
return None
|
||||||
|
urns: list[int] = []
|
||||||
|
fetched = 0
|
||||||
try:
|
try:
|
||||||
result = client.collections["schools"].documents.search({
|
page = 1
|
||||||
"q": query,
|
while fetched < SEARCH_MAX_CANDIDATES:
|
||||||
"query_by": "school_name,local_authority,postcode",
|
page_size = min(SEARCH_PAGE_SIZE, SEARCH_MAX_CANDIDATES - fetched)
|
||||||
"per_page": min(limit, 250),
|
result = client.collections["schools"].documents.search({
|
||||||
"typo_tokens_threshold": 1,
|
"q": query,
|
||||||
})
|
"query_by": "school_name,local_authority,postcode",
|
||||||
return [int(h["document"]["urn"]) for h in result.get("hits", [])]
|
"per_page": page_size,
|
||||||
|
"page": page,
|
||||||
|
"typo_tokens_threshold": 1,
|
||||||
|
})
|
||||||
|
hits = result.get("hits", [])
|
||||||
|
urns.extend(int(h["document"]["urn"]) for h in hits)
|
||||||
|
fetched += len(hits)
|
||||||
|
if fetched >= result.get("found", fetched):
|
||||||
|
return list(dict.fromkeys(urns))
|
||||||
|
if not hits:
|
||||||
|
raise ValueError("Search pagination ended before all matches arrived")
|
||||||
|
page += 1
|
||||||
|
logging.getLogger(__name__).info(
|
||||||
|
"Typesense search capped at %d candidates for query %r",
|
||||||
|
SEARCH_MAX_CANDIDATES,
|
||||||
|
query,
|
||||||
|
)
|
||||||
|
return list(dict.fromkeys(urns))
|
||||||
except Exception:
|
except Exception:
|
||||||
return []
|
logging.getLogger(__name__).exception("School search unavailable")
|
||||||
|
return None
|
||||||
|
|
||||||
|
|
||||||
# The most a public endpoint will return in one response.
|
# The most a public endpoint will return in one response.
|
||||||
@@ -188,16 +225,6 @@ def geocode_single_postcode(postcode: str) -> Optional[Tuple[float, float]]:
|
|||||||
return None
|
return None
|
||||||
|
|
||||||
|
|
||||||
def haversine_distance(lat1: float, lon1: float, lat2: float, lon2: float) -> float:
|
|
||||||
"""Calculate great-circle distance between two points (miles)."""
|
|
||||||
from math import radians, cos, sin, asin, sqrt
|
|
||||||
lat1, lon1, lat2, lon2 = map(radians, [lat1, lon1, lat2, lon2])
|
|
||||||
dlat = lat2 - lat1
|
|
||||||
dlon = lon2 - lon1
|
|
||||||
a = sin(dlat / 2) ** 2 + cos(lat1) * cos(lat2) * sin(dlon / 2) ** 2
|
|
||||||
return 2 * asin(sqrt(a)) * 3956
|
|
||||||
|
|
||||||
|
|
||||||
# =============================================================================
|
# =============================================================================
|
||||||
# MAIN DATA LOAD — joins dim_school + dim_location + fact_performance
|
# MAIN DATA LOAD — joins dim_school + dim_location + fact_performance
|
||||||
# fact_performance is a merged KS2+KS4 table (one row per URN per year).
|
# fact_performance is a merged KS2+KS4 table (one row per URN per year).
|
||||||
@@ -512,7 +539,12 @@ def load_latest_school_data() -> pd.DataFrame:
|
|||||||
if _df_latest_cache is not None:
|
if _df_latest_cache is not None:
|
||||||
return _df_latest_cache
|
return _df_latest_cache
|
||||||
|
|
||||||
df = load_school_data()
|
_df_latest_cache = build_latest_school_data(load_school_data())
|
||||||
|
return _df_latest_cache
|
||||||
|
|
||||||
|
|
||||||
|
def build_latest_school_data(df: pd.DataFrame) -> pd.DataFrame:
|
||||||
|
"""Build a replacement snapshot without mutating the published caches."""
|
||||||
if df.empty:
|
if df.empty:
|
||||||
return df
|
return df
|
||||||
|
|
||||||
@@ -545,8 +577,7 @@ def load_latest_school_data() -> pd.DataFrame:
|
|||||||
df_latest = pd.concat([df_latest, df_no_perf], ignore_index=True)
|
df_latest = pd.concat([df_latest, df_no_perf], ignore_index=True)
|
||||||
|
|
||||||
print(f"Latest-snapshot cache built: {len(df_latest)} schools")
|
print(f"Latest-snapshot cache built: {len(df_latest)} schools")
|
||||||
_df_latest_cache = df_latest
|
return df_latest
|
||||||
return _df_latest_cache
|
|
||||||
|
|
||||||
|
|
||||||
def clear_cache():
|
def clear_cache():
|
||||||
|
|||||||
@@ -57,6 +57,23 @@ REGISTRY: dict[str, Flag] = {
|
|||||||
),
|
),
|
||||||
added=date(2026, 8, 26),
|
added=date(2026, 8, 26),
|
||||||
),
|
),
|
||||||
|
Flag(
|
||||||
|
name="about_page",
|
||||||
|
description=(
|
||||||
|
"The /about page, its footer link, its sitemap entry, and the "
|
||||||
|
"named-author byline on every blog post."
|
||||||
|
),
|
||||||
|
added=date(2026, 9, 8),
|
||||||
|
),
|
||||||
|
Flag(
|
||||||
|
name="blog",
|
||||||
|
description=(
|
||||||
|
"The /blog index, post pages, the RSS feed, their footer link "
|
||||||
|
"and their sitemap entries. Not /admin: posts must be "
|
||||||
|
"writable before the blog is readable."
|
||||||
|
),
|
||||||
|
added=date(2026, 9, 8),
|
||||||
|
),
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -1,512 +0,0 @@
|
|||||||
"""
|
|
||||||
Database migration logic for importing CSV data.
|
|
||||||
Used by both CLI script and automatic startup migration.
|
|
||||||
"""
|
|
||||||
|
|
||||||
import re
|
|
||||||
from pathlib import Path
|
|
||||||
from typing import Dict, Optional
|
|
||||||
|
|
||||||
import numpy as np
|
|
||||||
import pandas as pd
|
|
||||||
import requests
|
|
||||||
|
|
||||||
from .config import settings
|
|
||||||
from .database import Base, engine, get_db_session
|
|
||||||
from .models import School, SchoolResult
|
|
||||||
from .schemas import (
|
|
||||||
COLUMN_MAPPINGS,
|
|
||||||
LA_CODE_TO_NAME,
|
|
||||||
NULL_VALUES,
|
|
||||||
SCHOOL_TYPE_MAP,
|
|
||||||
)
|
|
||||||
|
|
||||||
|
|
||||||
def parse_numeric(value) -> Optional[float]:
|
|
||||||
"""Parse a numeric value, handling special cases."""
|
|
||||||
if pd.isna(value):
|
|
||||||
return None
|
|
||||||
if isinstance(value, (int, float)):
|
|
||||||
return float(value) if not np.isnan(value) else None
|
|
||||||
str_val = str(value).strip().upper()
|
|
||||||
if str_val in NULL_VALUES or str_val == "":
|
|
||||||
return None
|
|
||||||
# Remove percentage signs if present
|
|
||||||
str_val = str_val.replace("%", "")
|
|
||||||
try:
|
|
||||||
return float(str_val)
|
|
||||||
except ValueError:
|
|
||||||
return None
|
|
||||||
|
|
||||||
|
|
||||||
def extract_year_from_folder(folder_name: str) -> Optional[int]:
|
|
||||||
"""Extract year from folder name like '2023-2024'."""
|
|
||||||
match = re.search(r"(\d{4})-(\d{4})", folder_name)
|
|
||||||
if match:
|
|
||||||
return int(match.group(2))
|
|
||||||
match = re.search(r"(\d{4})", folder_name)
|
|
||||||
if match:
|
|
||||||
return int(match.group(1))
|
|
||||||
return None
|
|
||||||
|
|
||||||
|
|
||||||
def geocode_postcodes_bulk(postcodes: list) -> Dict[str, tuple]:
|
|
||||||
"""
|
|
||||||
Geocode postcodes in bulk using postcodes.io API.
|
|
||||||
Returns dict of postcode -> (latitude, longitude).
|
|
||||||
"""
|
|
||||||
results = {}
|
|
||||||
valid_postcodes = [
|
|
||||||
p.strip().upper()
|
|
||||||
for p in postcodes
|
|
||||||
if p and isinstance(p, str) and len(p.strip()) >= 5
|
|
||||||
]
|
|
||||||
valid_postcodes = list(set(valid_postcodes))
|
|
||||||
|
|
||||||
if not valid_postcodes:
|
|
||||||
return results
|
|
||||||
|
|
||||||
batch_size = 100
|
|
||||||
total_batches = (len(valid_postcodes) + batch_size - 1) // batch_size
|
|
||||||
|
|
||||||
for i, batch_start in enumerate(range(0, len(valid_postcodes), batch_size)):
|
|
||||||
batch = valid_postcodes[batch_start : batch_start + batch_size]
|
|
||||||
print(
|
|
||||||
f" Geocoding batch {i + 1}/{total_batches} ({len(batch)} postcodes)..."
|
|
||||||
)
|
|
||||||
|
|
||||||
try:
|
|
||||||
response = requests.post(
|
|
||||||
"https://api.postcodes.io/postcodes",
|
|
||||||
json={"postcodes": batch},
|
|
||||||
timeout=30,
|
|
||||||
)
|
|
||||||
if response.status_code == 200:
|
|
||||||
data = response.json()
|
|
||||||
for item in data.get("result", []):
|
|
||||||
if item and item.get("result"):
|
|
||||||
pc = item["query"].upper()
|
|
||||||
lat = item["result"].get("latitude")
|
|
||||||
lon = item["result"].get("longitude")
|
|
||||||
if lat and lon:
|
|
||||||
results[pc] = (lat, lon)
|
|
||||||
except Exception as e:
|
|
||||||
print(f" Warning: Geocoding batch failed: {e}")
|
|
||||||
|
|
||||||
return results
|
|
||||||
|
|
||||||
|
|
||||||
def load_csv_data(data_dir: Path) -> pd.DataFrame:
|
|
||||||
"""Load all CSV data from data directory."""
|
|
||||||
all_data = []
|
|
||||||
|
|
||||||
for folder in sorted(data_dir.iterdir()):
|
|
||||||
if not folder.is_dir():
|
|
||||||
continue
|
|
||||||
|
|
||||||
year = extract_year_from_folder(folder.name)
|
|
||||||
if not year:
|
|
||||||
continue
|
|
||||||
|
|
||||||
# Specifically look for the KS2 results file
|
|
||||||
ks2_file = folder / "england_ks2final.csv"
|
|
||||||
if not ks2_file.exists():
|
|
||||||
continue
|
|
||||||
|
|
||||||
csv_file = ks2_file
|
|
||||||
print(f" Loading {csv_file.name} (year {year})...")
|
|
||||||
|
|
||||||
try:
|
|
||||||
df = pd.read_csv(csv_file, encoding="latin-1", low_memory=False)
|
|
||||||
except Exception as e:
|
|
||||||
print(f" Error loading {csv_file}: {e}")
|
|
||||||
continue
|
|
||||||
|
|
||||||
# Rename columns
|
|
||||||
df.rename(columns=COLUMN_MAPPINGS, inplace=True)
|
|
||||||
df["year"] = year
|
|
||||||
|
|
||||||
# Handle local authority name
|
|
||||||
la_name_cols = ["LANAME", "LA (name)", "LA_NAME", "LA NAME"]
|
|
||||||
la_name_col = next((c for c in la_name_cols if c in df.columns), None)
|
|
||||||
|
|
||||||
if la_name_col and la_name_col != "local_authority":
|
|
||||||
df["local_authority"] = df[la_name_col]
|
|
||||||
elif "LEA" in df.columns:
|
|
||||||
df["local_authority_code"] = pd.to_numeric(df["LEA"], errors="coerce")
|
|
||||||
df["local_authority"] = (
|
|
||||||
df["local_authority_code"]
|
|
||||||
.map(LA_CODE_TO_NAME)
|
|
||||||
.fillna(df["LEA"].astype(str))
|
|
||||||
)
|
|
||||||
|
|
||||||
# Store LEA code
|
|
||||||
if "LEA" in df.columns:
|
|
||||||
df["local_authority_code"] = pd.to_numeric(df["LEA"], errors="coerce")
|
|
||||||
|
|
||||||
# Map school type
|
|
||||||
if "school_type_code" in df.columns:
|
|
||||||
df["school_type"] = (
|
|
||||||
df["school_type_code"]
|
|
||||||
.map(SCHOOL_TYPE_MAP)
|
|
||||||
.fillna(df["school_type_code"])
|
|
||||||
)
|
|
||||||
|
|
||||||
# Create combined address
|
|
||||||
addr_parts = ["address1", "address2", "town", "postcode"]
|
|
||||||
for col in addr_parts:
|
|
||||||
if col not in df.columns:
|
|
||||||
df[col] = None
|
|
||||||
|
|
||||||
df["address"] = df.apply(
|
|
||||||
lambda r: ", ".join(
|
|
||||||
str(v)
|
|
||||||
for v in [
|
|
||||||
r.get("address1"),
|
|
||||||
r.get("address2"),
|
|
||||||
r.get("town"),
|
|
||||||
r.get("postcode"),
|
|
||||||
]
|
|
||||||
if pd.notna(v) and str(v).strip()
|
|
||||||
),
|
|
||||||
axis=1,
|
|
||||||
)
|
|
||||||
|
|
||||||
all_data.append(df)
|
|
||||||
print(f" Loaded {len(df)} records")
|
|
||||||
|
|
||||||
if all_data:
|
|
||||||
result = pd.concat(all_data, ignore_index=True)
|
|
||||||
print(f"\nTotal records loaded: {len(result)}")
|
|
||||||
print(f"Unique schools: {result['urn'].nunique()}")
|
|
||||||
print(f"Years: {sorted(result['year'].unique())}")
|
|
||||||
return result
|
|
||||||
|
|
||||||
return pd.DataFrame()
|
|
||||||
|
|
||||||
|
|
||||||
def migrate_data(df: pd.DataFrame, geocode: bool = False, geocode_cache: dict = None):
|
|
||||||
"""Migrate DataFrame data to database."""
|
|
||||||
|
|
||||||
if geocode_cache is None:
|
|
||||||
geocode_cache = {}
|
|
||||||
|
|
||||||
# Clean URN column - convert to integer, drop invalid values
|
|
||||||
df = df.copy()
|
|
||||||
df["urn"] = pd.to_numeric(df["urn"], errors="coerce")
|
|
||||||
df = df.dropna(subset=["urn"])
|
|
||||||
df["urn"] = df["urn"].astype(int)
|
|
||||||
|
|
||||||
# Group by URN to get unique schools (use latest year's data)
|
|
||||||
school_data = (
|
|
||||||
df.sort_values("year", ascending=False).groupby("urn").first().reset_index()
|
|
||||||
)
|
|
||||||
print(f"\nMigrating {len(school_data)} unique schools...")
|
|
||||||
|
|
||||||
# Geocode postcodes that aren't already in the cache
|
|
||||||
geocoded = dict(geocode_cache) # start with preserved coordinates
|
|
||||||
if geocode and "postcode" in df.columns:
|
|
||||||
cached_postcodes = {
|
|
||||||
str(row.get("postcode", "")).strip().upper()
|
|
||||||
for _, row in school_data.iterrows()
|
|
||||||
if int(float(str(row.get("urn", 0) or 0))) in geocode_cache
|
|
||||||
}
|
|
||||||
postcodes_needed = [
|
|
||||||
p for p in df["postcode"].dropna().unique()
|
|
||||||
if str(p).strip().upper() not in cached_postcodes
|
|
||||||
]
|
|
||||||
if postcodes_needed:
|
|
||||||
print(f"\nGeocoding {len(postcodes_needed)} postcodes ({len(geocode_cache)} restored from cache)...")
|
|
||||||
fresh = geocode_postcodes_bulk(postcodes_needed)
|
|
||||||
geocoded.update(fresh)
|
|
||||||
print(f" Successfully geocoded {len(fresh)} new postcodes")
|
|
||||||
else:
|
|
||||||
print(f"\nAll {len(geocode_cache)} postcodes restored from cache, skipping geocoding.")
|
|
||||||
|
|
||||||
with get_db_session() as db:
|
|
||||||
# Create schools
|
|
||||||
urn_to_school_id = {}
|
|
||||||
schools_created = 0
|
|
||||||
|
|
||||||
for _, row in school_data.iterrows():
|
|
||||||
# Safely parse URN - handle None, NaN, whitespace, and invalid values
|
|
||||||
urn_val = row.get("urn")
|
|
||||||
urn = None
|
|
||||||
if pd.notna(urn_val):
|
|
||||||
try:
|
|
||||||
urn_str = str(urn_val).strip()
|
|
||||||
if urn_str:
|
|
||||||
urn = int(float(urn_str)) # Handle "12345.0" format
|
|
||||||
except (ValueError, TypeError):
|
|
||||||
pass
|
|
||||||
if not urn:
|
|
||||||
continue
|
|
||||||
|
|
||||||
# Skip if we've already added this URN (handles duplicates in source data)
|
|
||||||
if urn in urn_to_school_id:
|
|
||||||
continue
|
|
||||||
|
|
||||||
# Get geocoding data
|
|
||||||
postcode = row.get("postcode")
|
|
||||||
lat, lon = None, None
|
|
||||||
if postcode and pd.notna(postcode):
|
|
||||||
coords = geocoded.get(str(postcode).strip().upper())
|
|
||||||
if coords:
|
|
||||||
lat, lon = coords
|
|
||||||
|
|
||||||
# Safely parse local_authority_code
|
|
||||||
la_code = None
|
|
||||||
la_code_val = row.get("local_authority_code")
|
|
||||||
if pd.notna(la_code_val):
|
|
||||||
try:
|
|
||||||
la_code_str = str(la_code_val).strip()
|
|
||||||
if la_code_str:
|
|
||||||
la_code = int(float(la_code_str))
|
|
||||||
except (ValueError, TypeError):
|
|
||||||
pass
|
|
||||||
|
|
||||||
school = School(
|
|
||||||
urn=urn,
|
|
||||||
school_name=row.get("school_name")
|
|
||||||
if pd.notna(row.get("school_name"))
|
|
||||||
else "Unknown",
|
|
||||||
local_authority=row.get("local_authority")
|
|
||||||
if pd.notna(row.get("local_authority"))
|
|
||||||
else None,
|
|
||||||
local_authority_code=la_code,
|
|
||||||
school_type=row.get("school_type")
|
|
||||||
if pd.notna(row.get("school_type"))
|
|
||||||
else None,
|
|
||||||
school_type_code=row.get("school_type_code")
|
|
||||||
if pd.notna(row.get("school_type_code"))
|
|
||||||
else None,
|
|
||||||
religious_denomination=row.get("religious_denomination")
|
|
||||||
if pd.notna(row.get("religious_denomination"))
|
|
||||||
else None,
|
|
||||||
age_range=row.get("age_range")
|
|
||||||
if pd.notna(row.get("age_range"))
|
|
||||||
else None,
|
|
||||||
address1=row.get("address1") if pd.notna(row.get("address1")) else None,
|
|
||||||
address2=row.get("address2") if pd.notna(row.get("address2")) else None,
|
|
||||||
town=row.get("town") if pd.notna(row.get("town")) else None,
|
|
||||||
postcode=row.get("postcode") if pd.notna(row.get("postcode")) else None,
|
|
||||||
latitude=lat,
|
|
||||||
longitude=lon,
|
|
||||||
)
|
|
||||||
db.add(school)
|
|
||||||
db.flush() # Get the ID
|
|
||||||
urn_to_school_id[urn] = school.id
|
|
||||||
schools_created += 1
|
|
||||||
|
|
||||||
if schools_created % 1000 == 0:
|
|
||||||
print(f" Created {schools_created} schools...")
|
|
||||||
|
|
||||||
print(f" Created {schools_created} schools")
|
|
||||||
|
|
||||||
# Create results
|
|
||||||
print(f"\nMigrating {len(df)} yearly results...")
|
|
||||||
results_created = 0
|
|
||||||
|
|
||||||
for _, row in df.iterrows():
|
|
||||||
# Safely parse URN
|
|
||||||
urn_val = row.get("urn")
|
|
||||||
urn = None
|
|
||||||
if pd.notna(urn_val):
|
|
||||||
try:
|
|
||||||
urn_str = str(urn_val).strip()
|
|
||||||
if urn_str:
|
|
||||||
urn = int(float(urn_str))
|
|
||||||
except (ValueError, TypeError):
|
|
||||||
pass
|
|
||||||
if not urn or urn not in urn_to_school_id:
|
|
||||||
continue
|
|
||||||
|
|
||||||
school_id = urn_to_school_id[urn]
|
|
||||||
|
|
||||||
# Safely parse year
|
|
||||||
year_val = row.get("year")
|
|
||||||
year = None
|
|
||||||
if pd.notna(year_val):
|
|
||||||
try:
|
|
||||||
year = int(float(str(year_val).strip()))
|
|
||||||
except (ValueError, TypeError):
|
|
||||||
pass
|
|
||||||
if not year:
|
|
||||||
continue
|
|
||||||
|
|
||||||
result = SchoolResult(
|
|
||||||
school_id=school_id,
|
|
||||||
year=year,
|
|
||||||
total_pupils=parse_numeric(row.get("total_pupils")),
|
|
||||||
eligible_pupils=parse_numeric(row.get("eligible_pupils")),
|
|
||||||
# Expected Standard
|
|
||||||
rwm_expected_pct=parse_numeric(row.get("rwm_expected_pct")),
|
|
||||||
reading_expected_pct=parse_numeric(row.get("reading_expected_pct")),
|
|
||||||
writing_expected_pct=parse_numeric(row.get("writing_expected_pct")),
|
|
||||||
maths_expected_pct=parse_numeric(row.get("maths_expected_pct")),
|
|
||||||
gps_expected_pct=parse_numeric(row.get("gps_expected_pct")),
|
|
||||||
science_expected_pct=parse_numeric(row.get("science_expected_pct")),
|
|
||||||
# Higher Standard
|
|
||||||
rwm_high_pct=parse_numeric(row.get("rwm_high_pct")),
|
|
||||||
reading_high_pct=parse_numeric(row.get("reading_high_pct")),
|
|
||||||
writing_high_pct=parse_numeric(row.get("writing_high_pct")),
|
|
||||||
maths_high_pct=parse_numeric(row.get("maths_high_pct")),
|
|
||||||
gps_high_pct=parse_numeric(row.get("gps_high_pct")),
|
|
||||||
# Progress
|
|
||||||
reading_progress=parse_numeric(row.get("reading_progress")),
|
|
||||||
writing_progress=parse_numeric(row.get("writing_progress")),
|
|
||||||
maths_progress=parse_numeric(row.get("maths_progress")),
|
|
||||||
# Averages
|
|
||||||
reading_avg_score=parse_numeric(row.get("reading_avg_score")),
|
|
||||||
maths_avg_score=parse_numeric(row.get("maths_avg_score")),
|
|
||||||
gps_avg_score=parse_numeric(row.get("gps_avg_score")),
|
|
||||||
# Context
|
|
||||||
disadvantaged_pct=parse_numeric(row.get("disadvantaged_pct")),
|
|
||||||
eal_pct=parse_numeric(row.get("eal_pct")),
|
|
||||||
sen_support_pct=parse_numeric(row.get("sen_support_pct")),
|
|
||||||
sen_ehcp_pct=parse_numeric(row.get("sen_ehcp_pct")),
|
|
||||||
stability_pct=parse_numeric(row.get("stability_pct")),
|
|
||||||
# Absence
|
|
||||||
reading_absence_pct=parse_numeric(row.get("reading_absence_pct")),
|
|
||||||
gps_absence_pct=parse_numeric(row.get("gps_absence_pct")),
|
|
||||||
maths_absence_pct=parse_numeric(row.get("maths_absence_pct")),
|
|
||||||
writing_absence_pct=parse_numeric(row.get("writing_absence_pct")),
|
|
||||||
science_absence_pct=parse_numeric(row.get("science_absence_pct")),
|
|
||||||
# Gender
|
|
||||||
rwm_expected_boys_pct=parse_numeric(row.get("rwm_expected_boys_pct")),
|
|
||||||
rwm_expected_girls_pct=parse_numeric(row.get("rwm_expected_girls_pct")),
|
|
||||||
rwm_high_boys_pct=parse_numeric(row.get("rwm_high_boys_pct")),
|
|
||||||
rwm_high_girls_pct=parse_numeric(row.get("rwm_high_girls_pct")),
|
|
||||||
# Disadvantaged
|
|
||||||
rwm_expected_disadvantaged_pct=parse_numeric(
|
|
||||||
row.get("rwm_expected_disadvantaged_pct")
|
|
||||||
),
|
|
||||||
rwm_expected_non_disadvantaged_pct=parse_numeric(
|
|
||||||
row.get("rwm_expected_non_disadvantaged_pct")
|
|
||||||
),
|
|
||||||
disadvantaged_gap=parse_numeric(row.get("disadvantaged_gap")),
|
|
||||||
# 3-Year
|
|
||||||
rwm_expected_3yr_pct=parse_numeric(row.get("rwm_expected_3yr_pct")),
|
|
||||||
reading_avg_3yr=parse_numeric(row.get("reading_avg_3yr")),
|
|
||||||
maths_avg_3yr=parse_numeric(row.get("maths_avg_3yr")),
|
|
||||||
)
|
|
||||||
db.add(result)
|
|
||||||
results_created += 1
|
|
||||||
|
|
||||||
if results_created % 10000 == 0:
|
|
||||||
print(f" Created {results_created} results...")
|
|
||||||
db.flush()
|
|
||||||
|
|
||||||
print(f" Created {results_created} results")
|
|
||||||
|
|
||||||
# Commit all changes
|
|
||||||
db.commit()
|
|
||||||
print("\nMigration complete!")
|
|
||||||
|
|
||||||
|
|
||||||
def _apply_schema_alterations():
|
|
||||||
"""
|
|
||||||
Add new columns to existing tables using ALTER TABLE … ADD COLUMN IF NOT EXISTS.
|
|
||||||
Safe to run on every migration — no-ops if the column already exists.
|
|
||||||
Add entries here whenever models.py gains new columns on an existing table.
|
|
||||||
"""
|
|
||||||
alterations = [
|
|
||||||
# v4: Ofsted Report Card columns
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS framework VARCHAR(20)",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_safeguarding_met BOOLEAN",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_inclusion INTEGER",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_curriculum_teaching INTEGER",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_achievement INTEGER",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_attendance_behaviour INTEGER",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_personal_development INTEGER",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_leadership_governance INTEGER",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_early_years INTEGER",
|
|
||||||
"ALTER TABLE ofsted_inspections ADD COLUMN IF NOT EXISTS rc_sixth_form INTEGER",
|
|
||||||
]
|
|
||||||
from sqlalchemy import text as sa_text
|
|
||||||
with engine.connect() as conn:
|
|
||||||
for stmt in alterations:
|
|
||||||
try:
|
|
||||||
conn.execute(sa_text(stmt))
|
|
||||||
except Exception as e:
|
|
||||||
print(f" Warning: alteration skipped ({e})")
|
|
||||||
conn.commit()
|
|
||||||
|
|
||||||
|
|
||||||
def _apply_schema_drops():
|
|
||||||
"""
|
|
||||||
Drop tables retired from the schema. Idempotent (DROP … IF EXISTS), so it's
|
|
||||||
safe to run on every migration. Add entries here when a model is removed.
|
|
||||||
"""
|
|
||||||
drops = [
|
|
||||||
# v6: Ofsted Parent View feature removed
|
|
||||||
"DROP TABLE IF EXISTS marts.fact_parent_view CASCADE",
|
|
||||||
]
|
|
||||||
from sqlalchemy import text as sa_text
|
|
||||||
with engine.connect() as conn:
|
|
||||||
for stmt in drops:
|
|
||||||
try:
|
|
||||||
conn.execute(sa_text(stmt))
|
|
||||||
except Exception as e:
|
|
||||||
print(f" Warning: drop skipped ({e})")
|
|
||||||
conn.commit()
|
|
||||||
|
|
||||||
|
|
||||||
def run_full_migration(geocode: bool = False) -> bool:
|
|
||||||
"""
|
|
||||||
Run a complete migration: drop all tables and reimport from CSV.
|
|
||||||
|
|
||||||
Returns True if successful, False if no data found.
|
|
||||||
Raises exception on error.
|
|
||||||
"""
|
|
||||||
# Preserve existing geocoding so a reimport doesn't throw away coordinates
|
|
||||||
# that took a long time to compute.
|
|
||||||
geocode_cache: dict[int, tuple[float, float]] = {}
|
|
||||||
inspector = __import__("sqlalchemy").inspect(engine)
|
|
||||||
if "schools" in inspector.get_table_names():
|
|
||||||
try:
|
|
||||||
with get_db_session() as db:
|
|
||||||
rows = db.execute(
|
|
||||||
__import__("sqlalchemy").text(
|
|
||||||
"SELECT urn, latitude, longitude FROM schools "
|
|
||||||
"WHERE latitude IS NOT NULL AND longitude IS NOT NULL"
|
|
||||||
)
|
|
||||||
).fetchall()
|
|
||||||
geocode_cache = {r.urn: (r.latitude, r.longitude) for r in rows}
|
|
||||||
print(f" Saved {len(geocode_cache)} existing geocoded coordinates.")
|
|
||||||
except Exception as e:
|
|
||||||
print(f" Warning: could not save geocode cache: {e}")
|
|
||||||
|
|
||||||
# Only drop the core KS2 tables — leave supplementary tables (ofsted, census,
|
|
||||||
# finance, etc.) intact so a reimport doesn't wipe integrator-populated data.
|
|
||||||
# schema_version is NOT dropped: it persists so restarts don't re-trigger migration.
|
|
||||||
ks2_tables = ["school_results", "schools"]
|
|
||||||
print(f"Dropping core tables: {ks2_tables} ...")
|
|
||||||
inspector = __import__("sqlalchemy").inspect(engine)
|
|
||||||
existing = set(inspector.get_table_names())
|
|
||||||
for tname in ks2_tables:
|
|
||||||
if tname in existing:
|
|
||||||
Base.metadata.tables[tname].drop(bind=engine)
|
|
||||||
|
|
||||||
print("Creating all tables...")
|
|
||||||
Base.metadata.create_all(bind=engine)
|
|
||||||
|
|
||||||
# ALTER existing supplementary tables to add any new columns.
|
|
||||||
# create_all() only creates missing tables; it won't add columns to tables
|
|
||||||
# that already exist from an older schema version. These statements are
|
|
||||||
# idempotent (IF NOT EXISTS) so they're safe to run on every migration.
|
|
||||||
print("Applying column additions to supplementary tables...")
|
|
||||||
_apply_schema_alterations()
|
|
||||||
|
|
||||||
print("Dropping retired tables...")
|
|
||||||
_apply_schema_drops()
|
|
||||||
|
|
||||||
print("\nLoading CSV data...")
|
|
||||||
df = load_csv_data(settings.data_dir)
|
|
||||||
|
|
||||||
if df.empty:
|
|
||||||
print("Warning: No CSV data found to migrate!")
|
|
||||||
return False
|
|
||||||
|
|
||||||
migrate_data(df, geocode=geocode, geocode_cache=geocode_cache)
|
|
||||||
return True
|
|
||||||
@@ -0,0 +1,263 @@
|
|||||||
|
"""Which nearby schools a detail page may offer as alternatives.
|
||||||
|
|
||||||
|
HARD FILTERS decide eligibility, and encode claims the section is not allowed
|
||||||
|
to make. A selective school is not an alternative to a non-selective one, a
|
||||||
|
special school is not comparable to a mainstream one, and a Girls school is not
|
||||||
|
an option for a Boys school's reader. They never relax, at any distance, even
|
||||||
|
where that means the section does not render at all.
|
||||||
|
|
||||||
|
DISTANCE decides the order, and nothing else does.
|
||||||
|
|
||||||
|
An earlier version ranked by intake similarity first and used distance only as
|
||||||
|
a tiebreak. That put a Catholic school 2.9 miles away above the community
|
||||||
|
school 0.3 miles down the road, and — because the row filled from the best tier
|
||||||
|
before widening — filled all six slots with faith matches while omitting every
|
||||||
|
school a parent could actually walk to. For a primary, a school that far is not
|
||||||
|
a weaker option; it is not an option. Distance is a constraint and intake is a
|
||||||
|
preference, and the ranking now says so.
|
||||||
|
|
||||||
|
Similarity survives as `shared`: what a candidate genuinely has in common with
|
||||||
|
this school, reported on its card, so a reader applies their own weighting
|
||||||
|
instead of having ours applied for them.
|
||||||
|
|
||||||
|
Pure functions over a DataFrame: no I/O, no FastAPI, no database.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from __future__ import annotations
|
||||||
|
|
||||||
|
import re
|
||||||
|
|
||||||
|
import numpy as np
|
||||||
|
import pandas as pd
|
||||||
|
|
||||||
|
from .schemas import PHASE_GROUPS
|
||||||
|
|
||||||
|
# Three fit the row; the rest are behind the carousel arrows.
|
||||||
|
MAX_SCHOOLS = 6
|
||||||
|
MINIMUM = 2
|
||||||
|
|
||||||
|
# How far the section will reach, in miles, when nothing closer exists.
|
||||||
|
#
|
||||||
|
# A sanity bound rather than a target: ordering by distance already handles
|
||||||
|
# density, so a school in a dense area fills all six slots inside a mile and
|
||||||
|
# never sees this. It decides one thing — what happens where the area is
|
||||||
|
# sparse — and the answer differs by phase because catchments do. Primary
|
||||||
|
# catchments are routinely under a mile; beyond two, a primary is not a weaker
|
||||||
|
# option but not an option, and no section is the honest answer.
|
||||||
|
PRIMARY_RADIUS_MILES = 2.0
|
||||||
|
SECONDARY_RADIUS_MILES = 6.0
|
||||||
|
POST16_RADIUS_MILES = 10.0
|
||||||
|
|
||||||
|
EARTH_RADIUS_MILES = 3958.8
|
||||||
|
|
||||||
|
_SPECIAL = re.compile(r"\bspecial\b|pupil referral|alternative provision", re.I)
|
||||||
|
|
||||||
|
# Values that mean "this school has no religious character".
|
||||||
|
_NO_FAITH = {"", "none", "does not apply", "not applicable"}
|
||||||
|
|
||||||
|
|
||||||
|
def is_special_provision(school_type: str | None) -> bool:
|
||||||
|
"""Mirror of isSpecialSchool() in nextjs-app/lib/utils.ts.
|
||||||
|
|
||||||
|
Special schools carry a mainstream phase, so phase alone cannot identify
|
||||||
|
them. The two implementations must agree: a school the frontend treats as
|
||||||
|
special for benchmarking but this treats as mainstream would be dropped
|
||||||
|
from its own England comparison and then offered as a peer to a mainstream
|
||||||
|
school on the next page along.
|
||||||
|
"""
|
||||||
|
return bool(_SPECIAL.search(school_type or ""))
|
||||||
|
|
||||||
|
|
||||||
|
def is_selective(admissions_policy: str | None) -> bool:
|
||||||
|
"""Strictly selective. Unknown counts as non-selective, which is the safe
|
||||||
|
direction: it can only ever exclude a pairing, never invent one."""
|
||||||
|
return (admissions_policy or "").strip().lower() == "selective"
|
||||||
|
|
||||||
|
|
||||||
|
def faith_key(denomination: str | None) -> str:
|
||||||
|
value = (denomination or "").strip().lower()
|
||||||
|
return "" if value in _NO_FAITH else value
|
||||||
|
|
||||||
|
|
||||||
|
def faith_label(denomination: str | None) -> str:
|
||||||
|
return denomination.strip() if faith_key(denomination) else "No religious character"
|
||||||
|
|
||||||
|
|
||||||
|
def genders_compatible(a: str | None, b: str | None) -> bool:
|
||||||
|
single = {"boys", "girls"}
|
||||||
|
left, right = (a or "").strip().lower(), (b or "").strip().lower()
|
||||||
|
return not (left in single and right in single and left != right)
|
||||||
|
|
||||||
|
|
||||||
|
def is_secondary_phase(phase: str | None) -> bool:
|
||||||
|
"""Whether this phase takes the secondary side: secondary group membership,
|
||||||
|
minus all-through.
|
||||||
|
|
||||||
|
Membership is read from PHASE_GROUPS rather than tested with `"secondary" in
|
||||||
|
phase`, because that substring misses "16 plus" — GIAS phase 6, which
|
||||||
|
PHASE_GROUPS deliberately files as secondary. The substring version fails
|
||||||
|
silently rather than loudly: a sixth-form college is simply handed the
|
||||||
|
primary bucket and offered infant schools as peers.
|
||||||
|
|
||||||
|
All-through is the exception. PHASE_GROUPS lists it on both sides because it
|
||||||
|
belongs on both phases' place pages, but the detail page renders it with the
|
||||||
|
primary template, and the metric follows the template.
|
||||||
|
"""
|
||||||
|
text = (phase or "").strip().lower()
|
||||||
|
return text != "all-through" and text in PHASE_GROUPS["secondary"]
|
||||||
|
|
||||||
|
|
||||||
|
def radius_miles(phase: str | None) -> float:
|
||||||
|
"""How far this phase's section will reach when nothing closer exists."""
|
||||||
|
if (phase or "").strip().lower() == "16 plus":
|
||||||
|
return POST16_RADIUS_MILES
|
||||||
|
return SECONDARY_RADIUS_MILES if is_secondary_phase(phase) else PRIMARY_RADIUS_MILES
|
||||||
|
|
||||||
|
|
||||||
|
def _phase_group(is_secondary: bool) -> set[str]:
|
||||||
|
return PHASE_GROUPS["secondary" if is_secondary else "primary"]
|
||||||
|
|
||||||
|
|
||||||
|
def _haversine_miles(lat1: float, lon1: float, lat2, lon2):
|
||||||
|
"""Vectorised, matching the postcode search in app.py."""
|
||||||
|
lat1_r, lon1_r = np.radians(lat1), np.radians(lon1)
|
||||||
|
lat2_r, lon2_r = np.radians(lat2.astype(float)), np.radians(lon2.astype(float))
|
||||||
|
dlat, dlon = lat2_r - lat1_r, lon2_r - lon1_r
|
||||||
|
a = np.sin(dlat / 2) ** 2 + np.cos(lat1_r) * np.cos(lat2_r) * np.sin(dlon / 2) ** 2
|
||||||
|
return 2 * EARTH_RADIUS_MILES * np.arcsin(np.sqrt(a))
|
||||||
|
|
||||||
|
|
||||||
|
def _native(value):
|
||||||
|
"""NaN and numpy scalars both reach JSONResponse badly; normalise here so
|
||||||
|
the caller never has to remember to."""
|
||||||
|
if value is None:
|
||||||
|
return None
|
||||||
|
if isinstance(value, np.generic):
|
||||||
|
value = value.item()
|
||||||
|
if isinstance(value, float) and np.isnan(value):
|
||||||
|
return None
|
||||||
|
return value
|
||||||
|
|
||||||
|
|
||||||
|
def _mask(series: pd.Series, predicate) -> pd.Series:
|
||||||
|
"""A boolean mask that survives an empty frame.
|
||||||
|
|
||||||
|
`Series.apply` on an empty Series returns an empty *DataFrame*, and using
|
||||||
|
that as a mask silently drops every column — so the next column lookup
|
||||||
|
raises KeyError rather than yielding no rows. This is not hypothetical: a
|
||||||
|
special school with no special school near it empties the frame at the
|
||||||
|
provision filter, which is the ordinary case for most special schools.
|
||||||
|
"""
|
||||||
|
return pd.Series([predicate(value) for value in series], index=series.index, dtype=bool)
|
||||||
|
|
||||||
|
|
||||||
|
def _shared(subject: pd.Series, candidate: pd.Series, is_secondary: bool) -> list[str]:
|
||||||
|
"""What this candidate genuinely has in common with the subject.
|
||||||
|
|
||||||
|
Empty is a real answer, and renders no chips at all. A card claiming a
|
||||||
|
shared characteristic it does not have would be worse than a bare one —
|
||||||
|
and since these no longer affect the order, an empty list costs the school
|
||||||
|
nothing but its place in the row, which distance already decided.
|
||||||
|
"""
|
||||||
|
shared: list[str] = []
|
||||||
|
|
||||||
|
gender = str(subject.get("gender") or "").strip()
|
||||||
|
if gender and str(candidate.get("gender") or "").strip().lower() == gender.lower():
|
||||||
|
shared.append(gender)
|
||||||
|
|
||||||
|
if is_secondary:
|
||||||
|
policy = str(candidate.get("admissions_policy") or "").strip()
|
||||||
|
subject_policy = str(subject.get("admissions_policy") or "").strip()
|
||||||
|
if (
|
||||||
|
policy
|
||||||
|
and policy.lower() == subject_policy.lower()
|
||||||
|
and policy.lower() not in {"not applicable", "unknown"}
|
||||||
|
):
|
||||||
|
shared.append(policy)
|
||||||
|
|
||||||
|
if faith_key(candidate.get("religious_denomination")) == faith_key(
|
||||||
|
subject.get("religious_denomination")
|
||||||
|
):
|
||||||
|
shared.append(faith_label(candidate.get("religious_denomination")))
|
||||||
|
|
||||||
|
return shared
|
||||||
|
|
||||||
|
|
||||||
|
def select_nearby(frame: pd.DataFrame, urn: int) -> list[dict]:
|
||||||
|
"""The nearest eligible schools, closest first — at most MAX_SCHOOLS, and
|
||||||
|
none at all below MINIMUM.
|
||||||
|
|
||||||
|
The phase is read from the subject's own row rather than passed in, so a
|
||||||
|
caller cannot hand this a phase that disagrees with the data it selects
|
||||||
|
from.
|
||||||
|
"""
|
||||||
|
subject_rows = frame[frame["urn"] == urn]
|
||||||
|
if subject_rows.empty:
|
||||||
|
return []
|
||||||
|
subject = subject_rows.iloc[0]
|
||||||
|
|
||||||
|
lat, lon = _native(subject.get("latitude")), _native(subject.get("longitude"))
|
||||||
|
if lat is None or lon is None:
|
||||||
|
return []
|
||||||
|
|
||||||
|
phase = subject.get("phase")
|
||||||
|
is_secondary = is_secondary_phase(phase)
|
||||||
|
reach = radius_miles(phase)
|
||||||
|
metric_key = "attainment_8_score" if is_secondary else "rwm_expected_pct"
|
||||||
|
|
||||||
|
candidates = frame[frame["urn"] != urn].copy()
|
||||||
|
for column in ("latitude", "longitude"):
|
||||||
|
candidates = candidates[candidates[column].notna()]
|
||||||
|
if candidates.empty:
|
||||||
|
return []
|
||||||
|
|
||||||
|
# ── Hard filters ────────────────────────────────────────────────────
|
||||||
|
allowed_phases = _phase_group(is_secondary)
|
||||||
|
candidates = candidates[
|
||||||
|
candidates["phase"].fillna("").str.lower().isin(allowed_phases)
|
||||||
|
]
|
||||||
|
candidates = candidates[candidates["status"].fillna("").str.lower().str.startswith("open")]
|
||||||
|
|
||||||
|
subject_special = is_special_provision(subject.get("school_type"))
|
||||||
|
special = _mask(candidates["school_type"], is_special_provision)
|
||||||
|
candidates = candidates[special if subject_special else ~special]
|
||||||
|
|
||||||
|
subject_selective = is_selective(subject.get("admissions_policy"))
|
||||||
|
selective = _mask(candidates["admissions_policy"], is_selective)
|
||||||
|
candidates = candidates[selective if subject_selective else ~selective]
|
||||||
|
|
||||||
|
subject_gender = subject.get("gender")
|
||||||
|
candidates = candidates[
|
||||||
|
_mask(candidates["gender"], lambda g: genders_compatible(subject_gender, g))
|
||||||
|
]
|
||||||
|
if candidates.empty:
|
||||||
|
return []
|
||||||
|
|
||||||
|
candidates["distance_miles"] = _haversine_miles(
|
||||||
|
lat, lon, candidates["latitude"].values, candidates["longitude"].values
|
||||||
|
).round(1)
|
||||||
|
|
||||||
|
# ── Nearest first, and nothing else has a say ───────────────────────
|
||||||
|
within = candidates[candidates["distance_miles"] <= reach]
|
||||||
|
if len(within) < MINIMUM:
|
||||||
|
return []
|
||||||
|
|
||||||
|
selected = within.sort_values(["distance_miles", "urn"]).head(MAX_SCHOOLS)
|
||||||
|
return [
|
||||||
|
{
|
||||||
|
"urn": int(row["urn"]),
|
||||||
|
"school_name": str(row.get("school_name") or ""),
|
||||||
|
"distance_miles": float(row["distance_miles"]),
|
||||||
|
"school_type": _native(row.get("school_type")),
|
||||||
|
"age_range": _native(row.get("age_range")),
|
||||||
|
# Each peer's own phase, not the subject's: the pool is a phase
|
||||||
|
# group, so an all-through school can sit beside a primary. The
|
||||||
|
# compare basket counts it against both of its tabs.
|
||||||
|
"phase": _native(row.get("phase")),
|
||||||
|
"shared": _shared(subject, row, is_secondary),
|
||||||
|
"metric_value": _native(row.get(metric_key)),
|
||||||
|
"metric_key": metric_key,
|
||||||
|
"metric_year": _native(row.get("year")),
|
||||||
|
}
|
||||||
|
for _, row in selected.iterrows()
|
||||||
|
]
|
||||||
@@ -296,6 +296,48 @@ def _locality_places(df, publishable: set[int],
|
|||||||
return out
|
return out
|
||||||
|
|
||||||
|
|
||||||
|
# Ordered authority → town/locality → outcode, widest first, because that is
|
||||||
|
# the order a breadcrumb reads. The link module re-sorts for its own purposes.
|
||||||
|
_PLACE_ORDER = {"authority": 0, "town": 1, "locality": 2, "outcode": 3}
|
||||||
|
|
||||||
|
|
||||||
|
def build_place_index(registry: dict[str, Place]) -> dict[int, tuple[Place, ...]]:
|
||||||
|
"""URN → the published places containing it, built once per registry.
|
||||||
|
|
||||||
|
The reverse of the registry, and the thing school pages link out through.
|
||||||
|
Derived from the registry rather than maintained beside it, so the two
|
||||||
|
cannot disagree about which places exist: a place below the publish
|
||||||
|
threshold is absent from the registry, so it is absent from here too, and
|
||||||
|
a link is never offered for a page that does not exist.
|
||||||
|
|
||||||
|
Built as an index rather than scanned per call because /api/schools/{urn}
|
||||||
|
is the site's highest-traffic endpoint. Scanning meant walking every place
|
||||||
|
and doing a tuple membership test against each — on the order of 10^5
|
||||||
|
comparisons per request, repeated for every school page view. One pass at
|
||||||
|
registry-build time replaces all of it with a dict lookup.
|
||||||
|
"""
|
||||||
|
grouped: dict[int, list[Place]] = {}
|
||||||
|
for place in registry.values():
|
||||||
|
for urn in place.urns:
|
||||||
|
grouped.setdefault(int(urn), []).append(place)
|
||||||
|
|
||||||
|
return {
|
||||||
|
urn: tuple(sorted(places,
|
||||||
|
key=lambda p: (_PLACE_ORDER.get(p.kind, 9), p.slug)))
|
||||||
|
for urn, places in grouped.items()
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def places_for_urn(index: dict[int, tuple[Place, ...]], urn: int) -> tuple[Place, ...]:
|
||||||
|
"""The published places containing this school, widest first.
|
||||||
|
|
||||||
|
Empty is a real answer, not a failure: a school whose town and authority
|
||||||
|
both fall below the publish threshold has nowhere to link, and the page
|
||||||
|
renders without the module.
|
||||||
|
"""
|
||||||
|
return index.get(int(urn), ())
|
||||||
|
|
||||||
|
|
||||||
def build_place_registry(df) -> dict[str, Place]:
|
def build_place_registry(df) -> dict[str, Place]:
|
||||||
"""Every place the site publishes, keyed by "<kind>:<slug>"."""
|
"""Every place the site publishes, keyed by "<kind>:<slug>"."""
|
||||||
if df.empty or "urn" not in df.columns:
|
if df.empty or "urn" not in df.columns:
|
||||||
|
|||||||
@@ -532,6 +532,31 @@ RANKING_COLUMNS = [
|
|||||||
"gcse_grade_91_pct",
|
"gcse_grade_91_pct",
|
||||||
]
|
]
|
||||||
|
|
||||||
|
# Maps user-facing phase filter values to the GIAS PhaseOfEducation values they
|
||||||
|
# include. All-through schools appear in both primary and secondary results,
|
||||||
|
# which is why this is a set per phase rather than a single string comparison.
|
||||||
|
#
|
||||||
|
# Lives here rather than in app.py because nearby_schools.py needs it too, and
|
||||||
|
# importing app from there would be a cycle.
|
||||||
|
PHASE_GROUPS: dict[str, set[str]] = {
|
||||||
|
"primary": {"primary", "middle deemed primary", "all-through"},
|
||||||
|
"secondary": {"secondary", "middle deemed secondary", "all-through", "16 plus"},
|
||||||
|
"all-through": {"all-through"},
|
||||||
|
}
|
||||||
|
|
||||||
|
# GIAS phases in the order a child meets them, for the phase filter's options.
|
||||||
|
# All-through spans the whole path, so it follows the stages. Lowercased, as
|
||||||
|
# PHASE_GROUPS is, so a change of case in the GIAS label keeps its place.
|
||||||
|
PHASE_ORDER: list[str] = [
|
||||||
|
"nursery",
|
||||||
|
"primary",
|
||||||
|
"middle deemed primary",
|
||||||
|
"middle deemed secondary",
|
||||||
|
"secondary",
|
||||||
|
"16 plus",
|
||||||
|
"all-through",
|
||||||
|
]
|
||||||
|
|
||||||
# School listing columns
|
# School listing columns
|
||||||
SCHOOL_COLUMNS = [
|
SCHOOL_COLUMNS = [
|
||||||
"urn",
|
"urn",
|
||||||
|
|||||||
@@ -0,0 +1,120 @@
|
|||||||
|
"""Parent-facing groups over GIAS establishment types and religious characters.
|
||||||
|
|
||||||
|
The 34 GIAS establishment types describe governance and funding, which for a
|
||||||
|
mainstream state school barely changes what a parent experiences. The search
|
||||||
|
filter offers five groups a parent recognises instead, and a faith filter in
|
||||||
|
place of the faith signal that "Voluntary aided" and "Voluntary controlled"
|
||||||
|
only half carry. See
|
||||||
|
docs/superpowers/specs/2026-10-02-school-type-groups-and-faith-filter-design.md.
|
||||||
|
|
||||||
|
Groups are defined over GIAS codes and looked up by the translated name,
|
||||||
|
because the DataFrame the API filters carries names only: the codes are
|
||||||
|
replaced at load (data_loader.translate_gias_code_columns), the legacy-name
|
||||||
|
mart fallback never had them, and test fixtures are written in names.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from typing import Optional
|
||||||
|
|
||||||
|
import pandas as pd
|
||||||
|
|
||||||
|
from .gias_codes import RELIGIOUS_CHARACTER, SCHOOL_TYPE
|
||||||
|
|
||||||
|
# (key, label, GIAS TypeOfEstablishment codes), in the order shown.
|
||||||
|
TYPE_GROUPS: tuple[tuple[str, str, frozenset[int]], ...] = (
|
||||||
|
# Every mainstream state school, academy or council-run: Academy sponsor
|
||||||
|
# led, Academy converter, Free schools, University technical college,
|
||||||
|
# Studio schools, City technology college, Community, Voluntary aided,
|
||||||
|
# Voluntary controlled, Foundation, LA nursery. Academy against council-run
|
||||||
|
# was two near-halves of one pool, and did not follow the difference a
|
||||||
|
# parent feels most, admissions: voluntary aided and foundation schools
|
||||||
|
# set their own, as academies do. Faith, which voluntary aided mostly
|
||||||
|
# meant, has its own filter.
|
||||||
|
("state", "State school (free)",
|
||||||
|
frozenset({28, 34, 35, 40, 41, 6, 1, 2, 3, 5, 15})),
|
||||||
|
("independent", "Independent (fee-paying)", frozenset({11})),
|
||||||
|
# Every special type, independent ones included (usually funded by the
|
||||||
|
# council through an EHCP, so SEND provision to a parent, not private
|
||||||
|
# school), and Special post 16 institutions.
|
||||||
|
("special", "Special school (SEND)", frozenset({7, 8, 10, 12, 32, 33, 36, 44})),
|
||||||
|
# Further education, Sixth form centres, the 16-19 academies and free schools.
|
||||||
|
("post16", "Sixth form or college", frozenset({18, 31, 39, 45, 46})),
|
||||||
|
# Pupil referral units and AP academies and free schools. Last: parents do
|
||||||
|
# not apply to these; the local authority places children there.
|
||||||
|
("alternative", "Alternative provision", frozenset({14, 38, 42, 43})),
|
||||||
|
)
|
||||||
|
|
||||||
|
# In no group, so reachable only under "Any school type": Secure units,
|
||||||
|
# Miscellaneous, Higher education institutions, Online provider, Institution
|
||||||
|
# funded by other government department, Academy secure 16 to 19.
|
||||||
|
UNOFFERED_TYPE_CODES: frozenset[int] = frozenset({24, 27, 29, 49, 56, 57})
|
||||||
|
|
||||||
|
# (key, label, GIAS ReligiousCharacter codes), in the order shown. A joint
|
||||||
|
# school is in every faith its label names; a generic "Christian" beside a
|
||||||
|
# named church adds nothing.
|
||||||
|
FAITH_GROUPS: tuple[tuple[str, str, frozenset[int]], ...] = (
|
||||||
|
# Does not apply, None, and 99 (a blank label).
|
||||||
|
("none", "No religious character", frozenset({0, 6, 99})),
|
||||||
|
("church_of_england", "Church of England",
|
||||||
|
frozenset({2, 9, 10, 11, 12, 13, 19, 20, 30, 31, 32, 33, 34, 41, 48})),
|
||||||
|
("roman_catholic", "Roman Catholic", frozenset({3, 11, 13, 35, 48})),
|
||||||
|
# 28 "Inter- / non- denominational" is how GIAS files Christian schools
|
||||||
|
# tied to no one church.
|
||||||
|
("other_christian", "Other Christian",
|
||||||
|
frozenset({4, 8, 9, 10, 12, 14, 15, 16, 17, 18, 19, 22, 26, 28, 30, 33,
|
||||||
|
37, 38, 39, 40, 41, 44, 45, 46, 47})),
|
||||||
|
("jewish", "Jewish", frozenset({5, 36, 43})),
|
||||||
|
("muslim", "Muslim", frozenset({7, 42, 49})),
|
||||||
|
("other_faith", "Other faith", frozenset({21, 24, 25, 29})),
|
||||||
|
)
|
||||||
|
|
||||||
|
TYPE_GROUP_KEYS: frozenset[str] = frozenset(k for k, _, _ in TYPE_GROUPS)
|
||||||
|
|
||||||
|
# Keys a group was offered under before, so their links keep working: "state"
|
||||||
|
# was "academy" and "council" until 2026-10-02.
|
||||||
|
TYPE_GROUP_ALIASES: dict[str, str] = {"academy": "state", "council": "state"}
|
||||||
|
FAITH_KEYS: frozenset[str] = frozenset(k for k, _, _ in FAITH_GROUPS)
|
||||||
|
|
||||||
|
|
||||||
|
def _key(name: str) -> str:
|
||||||
|
return name.strip().lower()
|
||||||
|
|
||||||
|
|
||||||
|
_TYPE_GROUP_BY_NAME: dict[str, str] = {
|
||||||
|
_key(SCHOOL_TYPE[code]): key
|
||||||
|
for key, _, codes in TYPE_GROUPS
|
||||||
|
for code in codes
|
||||||
|
if code in SCHOOL_TYPE
|
||||||
|
}
|
||||||
|
|
||||||
|
_FAITHS_BY_NAME: dict[str, tuple[str, ...]] = {}
|
||||||
|
for _faith, _, _codes in FAITH_GROUPS:
|
||||||
|
for _code in sorted(_codes):
|
||||||
|
if _code in RELIGIOUS_CHARACTER:
|
||||||
|
_name = _key(RELIGIOUS_CHARACTER[_code])
|
||||||
|
_FAITHS_BY_NAME[_name] = _FAITHS_BY_NAME.get(_name, ()) + (_faith,)
|
||||||
|
|
||||||
|
|
||||||
|
def type_group_key(value: str) -> Optional[str]:
|
||||||
|
"""The type group a school_type URL value names, old keys included, or
|
||||||
|
None when it names no group (an old link's raw GIAS type)."""
|
||||||
|
v = value.strip().lower()
|
||||||
|
v = TYPE_GROUP_ALIASES.get(v, v)
|
||||||
|
return v if v in TYPE_GROUP_KEYS else None
|
||||||
|
|
||||||
|
|
||||||
|
def type_group_for(name: object) -> Optional[str]:
|
||||||
|
"""The type group of a GIAS establishment type name, or None."""
|
||||||
|
if not isinstance(name, str):
|
||||||
|
return None
|
||||||
|
return _TYPE_GROUP_BY_NAME.get(_key(name))
|
||||||
|
|
||||||
|
|
||||||
|
def faith_groups_for(name: object) -> tuple[str, ...]:
|
||||||
|
"""The faith groups of a GIAS religious character name.
|
||||||
|
|
||||||
|
A missing or blank name is "No religious character". A name the
|
||||||
|
dictionary does not know has no faith, so it matches no faith option.
|
||||||
|
"""
|
||||||
|
if not isinstance(name, str):
|
||||||
|
return ("none",) if name is None or pd.isna(name) else ()
|
||||||
|
return _FAITHS_BY_NAME.get(_key(name), ())
|
||||||
@@ -0,0 +1,395 @@
|
|||||||
|
"""Selection rules for the nearby-schools section.
|
||||||
|
|
||||||
|
Hard filters encode claims the section is not allowed to make — that a
|
||||||
|
selective school is an alternative to a non-selective one, that a special
|
||||||
|
school is comparable to a mainstream one, or that a Girls school is an option
|
||||||
|
for a Boys school's reader. They decide who is eligible.
|
||||||
|
|
||||||
|
Distance decides the order, and nothing else does. An earlier version ranked by
|
||||||
|
intake similarity first, which put a Catholic school 2.9 miles away above the
|
||||||
|
community school 0.3 miles down the road — for a primary, a school that far is
|
||||||
|
not a weaker option, it is not an option. Similarity is now reported on the
|
||||||
|
card and never reorders the row.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import numpy as np
|
||||||
|
import pandas as pd
|
||||||
|
|
||||||
|
from backend.nearby_schools import (
|
||||||
|
is_secondary_phase,
|
||||||
|
radius_miles,
|
||||||
|
select_nearby,
|
||||||
|
)
|
||||||
|
|
||||||
|
BASE_LAT, BASE_LON = 51.5000, -0.1000
|
||||||
|
|
||||||
|
|
||||||
|
def _row(urn, name, **overrides):
|
||||||
|
base = {
|
||||||
|
"urn": urn,
|
||||||
|
"school_name": name,
|
||||||
|
"local_authority": "Testshire",
|
||||||
|
"school_type": "Community school",
|
||||||
|
"phase": "Primary",
|
||||||
|
"age_range": "4-11",
|
||||||
|
"status": "Open",
|
||||||
|
"gender": "Mixed",
|
||||||
|
"religious_denomination": "None",
|
||||||
|
"admissions_policy": "Not applicable",
|
||||||
|
"latitude": BASE_LAT,
|
||||||
|
"longitude": BASE_LON,
|
||||||
|
"year": 202425,
|
||||||
|
"rwm_expected_pct": 70.0,
|
||||||
|
"attainment_8_score": np.nan,
|
||||||
|
}
|
||||||
|
base.update(overrides)
|
||||||
|
return base
|
||||||
|
|
||||||
|
|
||||||
|
def _frame(*rows):
|
||||||
|
return pd.DataFrame(list(rows))
|
||||||
|
|
||||||
|
|
||||||
|
def _at(miles):
|
||||||
|
"""A latitude `miles` north of BASE_LAT."""
|
||||||
|
return BASE_LAT + miles / 69.0
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Order: distance, and only distance
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
def test_returns_nearest_first():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "Mid", latitude=_at(1.0)),
|
||||||
|
_row(100003, "Near", latitude=_at(0.4)),
|
||||||
|
_row(100004, "Far", latitude=_at(1.8)),
|
||||||
|
)
|
||||||
|
result = select_nearby(frame, 100001)
|
||||||
|
assert [s["urn"] for s in result] == [100003, 100002, 100004]
|
||||||
|
assert result[0]["distance_miles"] == 0.4
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_faith_match_never_outranks_a_closer_school():
|
||||||
|
"""The reported defect. A Catholic primary surrounded by Catholic primaries
|
||||||
|
showed six of them and omitted the community school down the road."""
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "St Jude's RC Primary", religious_denomination="Roman Catholic"),
|
||||||
|
_row(100002, "Elm Grove Primary", religious_denomination="None", latitude=_at(0.3)),
|
||||||
|
_row(100003, "Holy Cross RC", religious_denomination="Roman Catholic", latitude=_at(0.8)),
|
||||||
|
_row(100004, "Sacred Heart RC", religious_denomination="Roman Catholic", latitude=_at(1.2)),
|
||||||
|
_row(100005, "St Peter's RC", religious_denomination="Roman Catholic", latitude=_at(1.6)),
|
||||||
|
)
|
||||||
|
result = select_nearby(frame, 100001)
|
||||||
|
assert result[0]["urn"] == 100002, "the nearest school leads, whatever its intake"
|
||||||
|
assert [s["distance_miles"] for s in result] == sorted(s["distance_miles"] for s in result)
|
||||||
|
|
||||||
|
|
||||||
|
def test_the_nearest_eligible_school_is_always_shown():
|
||||||
|
"""Whatever else changes, a section titled "nearby" cannot omit the nearest
|
||||||
|
school while listing one four times further away."""
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject", gender="Boys", religious_denomination="Roman Catholic"),
|
||||||
|
_row(100002, "Nearest", gender="Mixed", religious_denomination="None", latitude=_at(0.2)),
|
||||||
|
*[
|
||||||
|
_row(100010 + n, f"Match {n}", gender="Boys",
|
||||||
|
religious_denomination="Roman Catholic", latitude=_at(0.9 + n * 0.1))
|
||||||
|
for n in range(6)
|
||||||
|
],
|
||||||
|
)
|
||||||
|
assert select_nearby(frame, 100001)[0]["urn"] == 100002
|
||||||
|
|
||||||
|
|
||||||
|
def test_caps_at_six_taking_the_nearest():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
*[_row(100010 + n, f"Peer {n}", latitude=_at(0.1 * (n + 1))) for n in range(7)],
|
||||||
|
)
|
||||||
|
result = select_nearby(frame, 100001)
|
||||||
|
assert len(result) == 6
|
||||||
|
assert 100016 not in {s["urn"] for s in result}, "the seventh-nearest is the one dropped"
|
||||||
|
|
||||||
|
|
||||||
|
def test_fewer_than_two_matches_returns_empty():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "Only neighbour", latitude=_at(0.5)),
|
||||||
|
)
|
||||||
|
assert select_nearby(frame, 100001) == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_excludes_the_subject_school():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "A", latitude=_at(0.5)),
|
||||||
|
_row(100003, "B", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
assert 100001 not in {s["urn"] for s in select_nearby(frame, 100001)}
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_school_is_never_listed_twice():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "A", latitude=_at(0.5)),
|
||||||
|
_row(100003, "B", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
result = select_nearby(frame, 100001)
|
||||||
|
assert len(result) == len({s["urn"] for s in result})
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Reach: a sanity bound, not a target
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
def test_primary_does_not_reach_past_two_miles():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "Just inside", latitude=_at(1.9)),
|
||||||
|
_row(100003, "Just outside", latitude=_at(2.4)),
|
||||||
|
_row(100004, "Miles away", latitude=_at(4.0)),
|
||||||
|
)
|
||||||
|
# One inside the cap is below the minimum, so nothing renders at all —
|
||||||
|
# a primary with nothing within two miles has no nearby schools.
|
||||||
|
assert select_nearby(frame, 100001) == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_secondary_reaches_further_than_primary():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject", phase="Secondary"),
|
||||||
|
_row(100002, "A", phase="Secondary", latitude=_at(3.0)),
|
||||||
|
_row(100003, "B", phase="Secondary", latitude=_at(5.5)),
|
||||||
|
)
|
||||||
|
assert {s["urn"] for s in select_nearby(frame, 100001)} == {100002, 100003}
|
||||||
|
|
||||||
|
|
||||||
|
def test_each_card_carries_its_own_phase():
|
||||||
|
# The compare basket limits each phase separately, so an all-through peer
|
||||||
|
# must not inherit the subject's "Primary".
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "A", latitude=_at(0.5)),
|
||||||
|
_row(100003, "B", phase="All-through", age_range="4-18", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
phases = {s["urn"]: s["phase"] for s in select_nearby(frame, 100001)}
|
||||||
|
assert phases == {100002: "Primary", 100003: "All-through"}
|
||||||
|
|
||||||
|
|
||||||
|
def test_the_cap_follows_the_phase():
|
||||||
|
assert radius_miles("Primary") == 2.0
|
||||||
|
assert radius_miles("Middle deemed primary") == 2.0
|
||||||
|
assert radius_miles("All-through") == 2.0
|
||||||
|
assert radius_miles("Secondary") == 6.0
|
||||||
|
assert radius_miles("Middle deemed secondary") == 6.0
|
||||||
|
# Post-16 is the phase people travel furthest for.
|
||||||
|
assert radius_miles("16 plus") == 10.0
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# Hard filters: eligibility, never order
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
def test_selective_never_meets_non_selective():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Grammar", phase="Secondary", admissions_policy="Selective"),
|
||||||
|
_row(100002, "Comp A", phase="Secondary", admissions_policy="Non-selective", latitude=_at(0.5)),
|
||||||
|
_row(100003, "Comp B", phase="Secondary", admissions_policy="Non-selective", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
assert select_nearby(frame, 100001) == []
|
||||||
|
assert 100001 not in {s["urn"] for s in select_nearby(frame, 100002)}
|
||||||
|
|
||||||
|
|
||||||
|
def test_special_schools_match_only_each_other():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Special", school_type="Community special school"),
|
||||||
|
_row(100002, "Mainstream A", latitude=_at(0.5)),
|
||||||
|
_row(100003, "Mainstream B", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
assert select_nearby(frame, 100001) == []
|
||||||
|
assert select_nearby(frame, 100002) == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_boys_never_meets_girls():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Boys School", gender="Boys"),
|
||||||
|
_row(100002, "Girls School", gender="Girls", latitude=_at(0.5)),
|
||||||
|
_row(100003, "Mixed School", gender="Mixed", latitude=_at(0.6)),
|
||||||
|
_row(100004, "Another Mixed", gender="Mixed", latitude=_at(0.7)),
|
||||||
|
)
|
||||||
|
urns = {s["urn"] for s in select_nearby(frame, 100001)}
|
||||||
|
assert 100002 not in urns
|
||||||
|
assert urns == {100003, 100004}
|
||||||
|
|
||||||
|
|
||||||
|
def test_closed_schools_and_missing_coordinates_are_dropped():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "Closed", status="Closed", latitude=_at(0.5)),
|
||||||
|
_row(100003, "No coords", latitude=np.nan, longitude=np.nan),
|
||||||
|
_row(100004, "Good A", latitude=_at(0.6)),
|
||||||
|
_row(100005, "Good B", latitude=_at(0.7)),
|
||||||
|
)
|
||||||
|
assert {s["urn"] for s in select_nearby(frame, 100001)} == {100004, 100005}
|
||||||
|
|
||||||
|
|
||||||
|
def test_all_through_is_offered_on_both_phase_sides():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Primary subject", phase="Primary"),
|
||||||
|
_row(100002, "All through", phase="All-through", latitude=_at(0.5)),
|
||||||
|
_row(100003, "Primary peer", phase="Primary", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
assert 100002 in {s["urn"] for s in select_nearby(frame, 100001)}
|
||||||
|
|
||||||
|
secondary = _frame(
|
||||||
|
_row(100010, "Secondary subject", phase="Secondary"),
|
||||||
|
_row(100002, "All through", phase="All-through", latitude=_at(0.5)),
|
||||||
|
_row(100011, "Secondary peer", phase="Secondary", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
assert 100002 in {s["urn"] for s in select_nearby(secondary, 100010)}
|
||||||
|
|
||||||
|
|
||||||
|
def test_sixteen_plus_is_matched_against_secondary_not_primary():
|
||||||
|
"""GIAS phase 6 is "16 plus", and PHASE_GROUPS puts it in the secondary
|
||||||
|
group — a sixth-form college's peers are secondaries and other colleges,
|
||||||
|
never primary schools. A substring test for "secondary" misses it silently:
|
||||||
|
no crash, just a page offering infant schools to a sixth form."""
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Sixth Form College", phase="16 plus", age_range="16-19"),
|
||||||
|
_row(100002, "Nearby Secondary", phase="Secondary", latitude=_at(0.5),
|
||||||
|
attainment_8_score=52.0),
|
||||||
|
_row(100003, "Nearby College", phase="16 plus", latitude=_at(0.6)),
|
||||||
|
_row(100004, "Nearby Primary", phase="Primary", latitude=_at(0.1)),
|
||||||
|
)
|
||||||
|
result = select_nearby(frame, 100001)
|
||||||
|
urns = {s["urn"] for s in result}
|
||||||
|
assert 100004 not in urns, "a primary school is not a peer for a sixth form"
|
||||||
|
assert urns == {100002, 100003}
|
||||||
|
assert all(s["metric_key"] == "attainment_8_score" for s in result)
|
||||||
|
|
||||||
|
|
||||||
|
def test_is_secondary_phase_agrees_with_the_phase_groups_it_selects_from():
|
||||||
|
for phase in ("Secondary", "Middle deemed secondary", "16 plus"):
|
||||||
|
assert is_secondary_phase(phase) is True, phase
|
||||||
|
for phase in ("Primary", "Middle deemed primary", "Nursery", "", None):
|
||||||
|
assert is_secondary_phase(phase) is False, phase
|
||||||
|
# In PHASE_GROUPS an all-through school is on both sides, but it renders
|
||||||
|
# with the primary template, and the metric follows the phase side.
|
||||||
|
assert is_secondary_phase("All-through") is False
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# What the card reports
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
def test_shared_lists_only_what_is_actually_shared():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject", phase="Secondary", gender="Mixed",
|
||||||
|
religious_denomination="None", admissions_policy="Non-selective"),
|
||||||
|
_row(100002, "Full match", phase="Secondary", gender="Mixed",
|
||||||
|
religious_denomination="None", admissions_policy="Non-selective", latitude=_at(0.5)),
|
||||||
|
_row(100003, "Faith differs", phase="Secondary", gender="Mixed",
|
||||||
|
religious_denomination="Church of England", admissions_policy="Non-selective", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
by_urn = {s["urn"]: s for s in select_nearby(frame, 100001)}
|
||||||
|
assert by_urn[100002]["shared"] == ["Mixed", "Non-selective", "No religious character"]
|
||||||
|
assert by_urn[100003]["shared"] == ["Mixed", "Non-selective"]
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_shared_faith_is_named():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject", religious_denomination="Roman Catholic"),
|
||||||
|
_row(100002, "Also RC", religious_denomination="Roman Catholic", latitude=_at(0.4)),
|
||||||
|
_row(100003, "Secular", religious_denomination="None", latitude=_at(0.5)),
|
||||||
|
)
|
||||||
|
by_urn = {s["urn"]: s for s in select_nearby(frame, 100001)}
|
||||||
|
assert "Roman Catholic" in by_urn[100002]["shared"]
|
||||||
|
assert by_urn[100003]["shared"] == ["Mixed"]
|
||||||
|
|
||||||
|
|
||||||
|
def test_shared_is_empty_when_nothing_is_shared():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject", gender="Boys", religious_denomination="Roman Catholic"),
|
||||||
|
_row(100002, "A", gender="Mixed", religious_denomination="None", latitude=_at(0.4)),
|
||||||
|
_row(100003, "B", gender="Mixed", religious_denomination="Church of England", latitude=_at(0.5)),
|
||||||
|
)
|
||||||
|
assert all(s["shared"] == [] for s in select_nearby(frame, 100001))
|
||||||
|
|
||||||
|
|
||||||
|
def test_no_tier_is_reported_because_there_are_no_tiers():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "A", latitude=_at(0.4)),
|
||||||
|
_row(100003, "B", latitude=_at(0.5)),
|
||||||
|
)
|
||||||
|
assert all("tier" not in s for s in select_nearby(frame, 100001))
|
||||||
|
|
||||||
|
|
||||||
|
def test_metric_follows_the_phase_side_not_the_neighbour():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject", phase="Secondary", attainment_8_score=50.0),
|
||||||
|
_row(100002, "A", phase="Secondary", attainment_8_score=52.8, latitude=_at(0.5)),
|
||||||
|
_row(100003, "B", phase="Secondary", attainment_8_score=np.nan, latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
by_urn = {s["urn"]: s for s in select_nearby(frame, 100001)}
|
||||||
|
assert by_urn[100002]["metric_key"] == "attainment_8_score"
|
||||||
|
assert by_urn[100002]["metric_value"] == 52.8
|
||||||
|
assert by_urn[100002]["metric_year"] == 202425
|
||||||
|
assert by_urn[100003]["metric_value"] is None
|
||||||
|
|
||||||
|
|
||||||
|
def test_values_are_json_safe_native_types():
|
||||||
|
frame = _frame(
|
||||||
|
_row(100001, "Subject"),
|
||||||
|
_row(100002, "A", latitude=_at(0.5)),
|
||||||
|
_row(100003, "B", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
for school in select_nearby(frame, 100001):
|
||||||
|
assert isinstance(school["urn"], int)
|
||||||
|
assert isinstance(school["distance_miles"], float)
|
||||||
|
assert not isinstance(school["metric_value"], np.generic)
|
||||||
|
|
||||||
|
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
# The endpoint
|
||||||
|
# ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
import pytest
|
||||||
|
from fastapi.testclient import TestClient
|
||||||
|
|
||||||
|
|
||||||
|
def _endpoint_frame():
|
||||||
|
return _frame(
|
||||||
|
_row(100001, "Subject Primary"),
|
||||||
|
_row(100002, "Neighbour A", latitude=_at(0.5)),
|
||||||
|
_row(100003, "Neighbour B", latitude=_at(0.6)),
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture()
|
||||||
|
def client(monkeypatch):
|
||||||
|
from backend import app as app_module
|
||||||
|
|
||||||
|
monkeypatch.setattr(app_module, "load_latest_school_data", _endpoint_frame)
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data", _endpoint_frame)
|
||||||
|
monkeypatch.setattr(app_module, "get_supplementary_data", lambda db, urn: {})
|
||||||
|
return TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
|
|
||||||
|
|
||||||
|
def test_detail_payload_carries_nearby_schools(client):
|
||||||
|
resp = client.get("/api/schools/100001")
|
||||||
|
assert resp.status_code == 200, resp.text
|
||||||
|
similar = resp.json()["nearby_schools"]
|
||||||
|
assert [s["school_name"] for s in similar] == ["Neighbour A", "Neighbour B"]
|
||||||
|
assert similar[0]["metric_key"] == "rwm_expected_pct"
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_failure_in_selection_does_not_break_the_page(client, monkeypatch):
|
||||||
|
from backend import app as app_module
|
||||||
|
|
||||||
|
def _explode(*args, **kwargs):
|
||||||
|
raise ValueError("selection blew up")
|
||||||
|
|
||||||
|
monkeypatch.setattr(app_module, "select_nearby", _explode)
|
||||||
|
resp = client.get("/api/schools/100001")
|
||||||
|
assert resp.status_code == 200, resp.text
|
||||||
|
assert resp.json()["nearby_schools"] == []
|
||||||
@@ -0,0 +1,106 @@
|
|||||||
|
"""The /api/schools phase filter.
|
||||||
|
|
||||||
|
The search page offers every GIAS phase, but the filter only knew the three
|
||||||
|
grouped ones (primary, secondary, all-through). Anything else — nursery,
|
||||||
|
16 plus, the middle-deemed phases — fell through to no filter at all, so
|
||||||
|
"Nursery" returned the whole result set, mostly primaries.
|
||||||
|
"""
|
||||||
|
|
||||||
|
import numpy as np
|
||||||
|
import pandas as pd
|
||||||
|
import pytest
|
||||||
|
from fastapi.testclient import TestClient
|
||||||
|
|
||||||
|
PHASES = {
|
||||||
|
100001: "Nursery",
|
||||||
|
100002: "Primary",
|
||||||
|
100003: "Middle deemed primary",
|
||||||
|
100004: "Secondary",
|
||||||
|
100005: "Middle deemed secondary",
|
||||||
|
100006: "16 plus",
|
||||||
|
100007: "All-through",
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _schools_df() -> pd.DataFrame:
|
||||||
|
base = {
|
||||||
|
"local_authority": "Testshire",
|
||||||
|
"school_type": "Academy",
|
||||||
|
"address": "1 Test Street",
|
||||||
|
"town": "Testtown",
|
||||||
|
"postcode": "TS1 1AA",
|
||||||
|
"religious_denomination": None,
|
||||||
|
"age_range": "4-11",
|
||||||
|
"has_sixth_form": None,
|
||||||
|
"gender": "Mixed",
|
||||||
|
"admissions_policy": None,
|
||||||
|
"ofsted_grade": np.nan,
|
||||||
|
"ofsted_date": None,
|
||||||
|
"ofsted_framework": None,
|
||||||
|
"latitude": 51.5,
|
||||||
|
"longitude": -0.1,
|
||||||
|
"year": 202425,
|
||||||
|
"total_pupils": 300,
|
||||||
|
"rwm_expected_pct": np.nan,
|
||||||
|
"attainment_8_score": np.nan,
|
||||||
|
}
|
||||||
|
return pd.DataFrame([
|
||||||
|
{**base, "urn": urn, "school_name": f"{phase} School", "phase": phase}
|
||||||
|
for urn, phase in PHASES.items()
|
||||||
|
])
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture()
|
||||||
|
def client(monkeypatch):
|
||||||
|
from backend import app as app_module
|
||||||
|
|
||||||
|
monkeypatch.setattr(app_module, "load_latest_school_data", _schools_df)
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data", _schools_df)
|
||||||
|
return TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
|
|
||||||
|
|
||||||
|
def _urns(client, phase):
|
||||||
|
resp = client.get("/api/schools", params={"phase": phase})
|
||||||
|
assert resp.status_code == 200, resp.text
|
||||||
|
return sorted(s["urn"] for s in resp.json()["schools"])
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("phase, urn", [
|
||||||
|
("nursery", 100001),
|
||||||
|
("16 plus", 100006),
|
||||||
|
("middle deemed primary", 100003),
|
||||||
|
("middle deemed secondary", 100005),
|
||||||
|
])
|
||||||
|
def test_an_ungrouped_phase_matches_exactly(client, phase, urn):
|
||||||
|
assert _urns(client, phase) == [urn]
|
||||||
|
|
||||||
|
|
||||||
|
def test_grouped_phases_still_take_in_their_related_phases(client):
|
||||||
|
assert _urns(client, "primary") == [100002, 100003, 100007]
|
||||||
|
assert _urns(client, "secondary") == [100004, 100005, 100006, 100007]
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_unknown_phase_returns_nothing_rather_than_everything(client):
|
||||||
|
assert _urns(client, "kindergarten") == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_filters_lists_phases_in_the_order_a_child_meets_them(client):
|
||||||
|
# Alphabetical put "16 plus" and "All-through" first and Nursery fifth.
|
||||||
|
# All-through spans the whole path, so it comes after the stages.
|
||||||
|
assert client.get("/api/filters").json()["phases"] == [
|
||||||
|
"Nursery",
|
||||||
|
"Primary",
|
||||||
|
"Middle deemed primary",
|
||||||
|
"Middle deemed secondary",
|
||||||
|
"Secondary",
|
||||||
|
"16 plus",
|
||||||
|
"All-through",
|
||||||
|
]
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_unknown_phase_follows_the_known_ones():
|
||||||
|
from backend.app import order_phases
|
||||||
|
|
||||||
|
assert order_phases(["Secondary", "Zeta", "Alpha", "Nursery"]) == [
|
||||||
|
"Nursery", "Secondary", "Alpha", "Zeta",
|
||||||
|
]
|
||||||
@@ -8,7 +8,8 @@ import numpy as np
|
|||||||
import pandas as pd
|
import pandas as pd
|
||||||
import pytest
|
import pytest
|
||||||
|
|
||||||
from backend.places import MIN_SCHOOLS, build_place_registry
|
from backend.places import (MIN_SCHOOLS, build_place_index,
|
||||||
|
build_place_registry, places_for_urn)
|
||||||
|
|
||||||
|
|
||||||
def _df(rows: list[dict]) -> pd.DataFrame:
|
def _df(rows: list[dict]) -> pd.DataFrame:
|
||||||
@@ -418,3 +419,79 @@ def test_an_authority_still_publishes_phase_variants():
|
|||||||
and /schools/authority/[la]/[phase] is the route that serves it."""
|
and /schools/authority/[la]/[phase] is the route that serves it."""
|
||||||
reg = build_place_registry(_df(_town(MIN_SCHOOLS, "Maidstone", "Kent")))
|
reg = build_place_registry(_df(_town(MIN_SCHOOLS, "Maidstone", "Kent")))
|
||||||
assert reg["authority:kent"].publishes_phase("primary")
|
assert reg["authority:kent"].publishes_phase("primary")
|
||||||
|
|
||||||
|
|
||||||
|
# ── The reverse index: which published places contain a school ──────────────
|
||||||
|
#
|
||||||
|
# School pages link out to the location layer through this. It is the whole
|
||||||
|
# point of the index: before it, ~27k school pages linked to nothing on the
|
||||||
|
# site and stranded whatever authority they held.
|
||||||
|
|
||||||
|
def test_a_school_resolves_to_every_published_place_containing_it():
|
||||||
|
reg = build_place_registry(_df(_town(MIN_SCHOOLS, "Brentwood", "Essex")))
|
||||||
|
places = places_for_urn(build_place_index(reg), 100000)
|
||||||
|
|
||||||
|
kinds = {p.kind for p in places}
|
||||||
|
assert "town" in kinds
|
||||||
|
assert "authority" in kinds
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_school_in_an_unpublished_town_still_resolves_to_its_authority():
|
||||||
|
# A town below the threshold has no page, so there is no link to offer —
|
||||||
|
# but the authority above it clears the threshold on the same schools and
|
||||||
|
# is where that reader should be sent.
|
||||||
|
reg = build_place_registry(_df(
|
||||||
|
_town(MIN_SCHOOLS - 1, "Tinytown", "Essex")
|
||||||
|
+ _town(MIN_SCHOOLS, "Brentwood", "Essex", start=200000)
|
||||||
|
))
|
||||||
|
places = places_for_urn(build_place_index(reg), 100000)
|
||||||
|
|
||||||
|
# The town is below the threshold, so it has no page and must not be
|
||||||
|
# offered as a link. The authority above it does, and is the right target.
|
||||||
|
assert all(p.slug != "tinytown" for p in places)
|
||||||
|
assert "authority" in {p.kind for p in places}
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_unknown_urn_resolves_to_nothing_rather_than_raising():
|
||||||
|
# A school page renders for any URN the API knows; the link module is not
|
||||||
|
# entitled to take the page down when it has nothing to say.
|
||||||
|
reg = build_place_registry(_df(_town(MIN_SCHOOLS, "Brentwood", "Essex")))
|
||||||
|
assert places_for_urn(build_place_index(reg), 999999) == ()
|
||||||
|
|
||||||
|
|
||||||
|
def test_the_index_is_consistent_with_the_registry_it_was_built_from():
|
||||||
|
# The invariant that matters: a link module must never offer a place whose
|
||||||
|
# page does not exist, and never omit one that does.
|
||||||
|
reg = build_place_registry(_df(
|
||||||
|
_town(MIN_SCHOOLS, "Brentwood", "Essex")
|
||||||
|
+ _town(MIN_SCHOOLS, "Bedford", "Bedford", start=300000)
|
||||||
|
))
|
||||||
|
index = build_place_index(reg)
|
||||||
|
for key, place in reg.items():
|
||||||
|
for urn in place.urns:
|
||||||
|
assert place in places_for_urn(index, urn), (
|
||||||
|
f"{urn} is in {key} but the index does not say so")
|
||||||
|
|
||||||
|
|
||||||
|
def test_the_index_holds_no_school_the_registry_does_not():
|
||||||
|
# The reverse direction of the invariant above. An index entry for a URN
|
||||||
|
# no published place contains would put a link on a page for a place that
|
||||||
|
# does not list that school.
|
||||||
|
reg = build_place_registry(_df(
|
||||||
|
_town(MIN_SCHOOLS, "Brentwood", "Essex")
|
||||||
|
+ _town(MIN_SCHOOLS - 1, "Tinytown", "Essex", start=400000)
|
||||||
|
))
|
||||||
|
index = build_place_index(reg)
|
||||||
|
|
||||||
|
for urn, places in index.items():
|
||||||
|
for place in places:
|
||||||
|
assert urn in place.urns
|
||||||
|
assert place.key in reg
|
||||||
|
|
||||||
|
|
||||||
|
def test_the_index_preserves_the_widest_first_order():
|
||||||
|
# The breadcrumb reads authority then town, and takes this order as given.
|
||||||
|
reg = build_place_registry(_df(_town(MIN_SCHOOLS, "Brentwood", "Essex")))
|
||||||
|
kinds = [p.kind for p in places_for_urn(build_place_index(reg), 100000)]
|
||||||
|
|
||||||
|
assert kinds.index("authority") < kinds.index("town")
|
||||||
@@ -0,0 +1,68 @@
|
|||||||
|
"""Publication must preserve the current dataset until every replacement is ready."""
|
||||||
|
import asyncio
|
||||||
|
import pandas as pd
|
||||||
|
import pytest
|
||||||
|
from fastapi.testclient import TestClient
|
||||||
|
from backend import app as api, data_loader
|
||||||
|
from backend.tests.test_sixth_form_flag import _schools_df
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture
|
||||||
|
def client(monkeypatch):
|
||||||
|
old = _schools_df()
|
||||||
|
monkeypatch.setattr(data_loader, '_df_cache', old)
|
||||||
|
monkeypatch.setattr(data_loader, '_df_latest_cache', old)
|
||||||
|
monkeypatch.setattr(api, '_place_registry', {'old': 'registry'})
|
||||||
|
monkeypatch.setattr(api, '_place_index', {'old': 'index'})
|
||||||
|
monkeypatch.setattr(api, '_place_index_source', api._place_registry)
|
||||||
|
monkeypatch.setattr(api, '_sitemaps', {'old.xml': 'old sitemap'})
|
||||||
|
monkeypatch.setattr(api, '_publication_lock', asyncio.Lock())
|
||||||
|
monkeypatch.setattr(api.limiter, 'enabled', False)
|
||||||
|
api.app.dependency_overrides[api.verify_admin_api_key] = lambda: True
|
||||||
|
yield TestClient(api.app, raise_server_exceptions=False)
|
||||||
|
api.app.dependency_overrides.clear()
|
||||||
|
|
||||||
|
|
||||||
|
def state():
|
||||||
|
return (data_loader._df_cache, data_loader._df_latest_cache, api._place_registry,
|
||||||
|
api._place_index, api._place_index_source, api._sitemaps)
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize('failure', ['empty', 'database', 'sitemap', 'duplicate'])
|
||||||
|
def test_failed_reload_preserves_every_published_object(client, monkeypatch, failure):
|
||||||
|
before = state()
|
||||||
|
df = _schools_df()
|
||||||
|
if failure == 'empty':
|
||||||
|
df = pd.DataFrame()
|
||||||
|
if failure == 'duplicate':
|
||||||
|
df = pd.concat([df, df.iloc[:1]], ignore_index=True)
|
||||||
|
def load():
|
||||||
|
if failure == 'database':
|
||||||
|
raise RuntimeError('database unavailable')
|
||||||
|
return df
|
||||||
|
monkeypatch.setattr(api, 'load_school_data_as_dataframe', load)
|
||||||
|
if failure == 'sitemap':
|
||||||
|
monkeypatch.setattr(api, 'build_sitemaps', lambda *args: (_ for _ in ()).throw(RuntimeError('bad XML')))
|
||||||
|
response = client.post('/api/admin/reload')
|
||||||
|
assert response.status_code == 503
|
||||||
|
assert all(a is b for a, b in zip(before, state()))
|
||||||
|
|
||||||
|
|
||||||
|
def test_success_publishes_school_data_places_and_sitemaps(client, monkeypatch):
|
||||||
|
df = _schools_df()
|
||||||
|
df.loc[0, 'school_name'] = 'Replacement School'
|
||||||
|
monkeypatch.setattr(api, 'load_school_data_as_dataframe', lambda: df)
|
||||||
|
response = client.post('/api/admin/reload')
|
||||||
|
assert response.status_code == 200
|
||||||
|
assert data_loader.load_school_data() is df
|
||||||
|
assert data_loader.load_latest_school_data().iloc[0].school_name == 'Replacement School'
|
||||||
|
assert api._place_index_source is api._place_registry
|
||||||
|
assert 'old.xml' not in api._sitemaps
|
||||||
|
assert 'replacement-school' in api._sitemaps['schools-1.xml']
|
||||||
|
|
||||||
|
|
||||||
|
def test_failed_sitemap_regeneration_keeps_existing_publication(client, monkeypatch):
|
||||||
|
before = state()
|
||||||
|
monkeypatch.setattr(api, 'build_sitemaps', lambda *args: (_ for _ in ()).throw(RuntimeError('bad XML')))
|
||||||
|
assert client.post('/api/admin/regenerate-sitemap').status_code == 503
|
||||||
|
assert all(a is b for a, b in zip(before, state()))
|
||||||
@@ -56,6 +56,11 @@ def client(monkeypatch):
|
|||||||
monkeypatch.setattr(
|
monkeypatch.setattr(
|
||||||
app_module, "get_supplementary_data", lambda db, urn: {}
|
app_module, "get_supplementary_data", lambda db, urn: {}
|
||||||
)
|
)
|
||||||
|
# The place registry is a module-level cache, so without this the endpoint
|
||||||
|
# answers from whatever registry an earlier test happened to leave behind
|
||||||
|
# — and a `places == []` assertion is satisfied by a stale registry just
|
||||||
|
# as well as by this fixture's own data, which makes it prove nothing.
|
||||||
|
monkeypatch.setattr(app_module, "_place_registry", None)
|
||||||
return TestClient(app_module.app, raise_server_exceptions=False)
|
return TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
|
|
||||||
|
|
||||||
@@ -69,3 +74,174 @@ def test_nan_gias_fields_serialize_as_null(client):
|
|||||||
assert info["capacity"] is None
|
assert info["capacity"] is None
|
||||||
assert info["total_pupils"] is None
|
assert info["total_pupils"] is None
|
||||||
assert info["school_name"] == "West London Performing Arts Academy"
|
assert info["school_name"] == "West London Performing Arts Academy"
|
||||||
|
|
||||||
|
|
||||||
|
# ── Links out to the location layer ─────────────────────────────────────────
|
||||||
|
#
|
||||||
|
# School pages carried no link into the site at all: the only anchor on the
|
||||||
|
# template pointed at the school's own website, so ~27k pages received
|
||||||
|
# whatever authority the site had and sent it off-site. `places` is what the
|
||||||
|
# link module and the breadcrumb are built from.
|
||||||
|
|
||||||
|
def test_places_is_present_even_when_the_school_belongs_to_none(client):
|
||||||
|
# This fixture's single school cannot clear any publish threshold, so the
|
||||||
|
# honest answer is an empty list. The key must still be there: a missing
|
||||||
|
# key and "no places" are different things to the page rendering it.
|
||||||
|
body = client.get("/api/schools/150275").json()
|
||||||
|
assert body["places"] == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_places_names_only_pages_that_exist(monkeypatch):
|
||||||
|
from backend import app as app_module
|
||||||
|
from backend.places import MIN_SCHOOLS
|
||||||
|
|
||||||
|
def _df():
|
||||||
|
return pd.DataFrame([
|
||||||
|
{
|
||||||
|
"urn": 100000 + i,
|
||||||
|
"school_name": f"Brentwood School {i}",
|
||||||
|
"town": "Brentwood",
|
||||||
|
"local_authority": "Essex",
|
||||||
|
"postcode": "CM15 8AA",
|
||||||
|
"phase": "Primary",
|
||||||
|
"year": 202425,
|
||||||
|
"rwm_expected_pct": 60.0,
|
||||||
|
"attainment_8_score": np.nan,
|
||||||
|
"ofsted_grade": 2.0,
|
||||||
|
"ofsted_date": None,
|
||||||
|
}
|
||||||
|
for i in range(MIN_SCHOOLS)
|
||||||
|
])
|
||||||
|
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data", _df)
|
||||||
|
monkeypatch.setattr(app_module, "get_supplementary_data", lambda db, urn: {})
|
||||||
|
monkeypatch.setattr(app_module, "_place_registry", None)
|
||||||
|
client = TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
|
|
||||||
|
places = client.get("/api/schools/100000").json()["places"]
|
||||||
|
assert places, "a school in a published town must offer links"
|
||||||
|
|
||||||
|
by_kind = {p["kind"]: p for p in places}
|
||||||
|
assert by_kind["town"]["url"] == "/schools/brentwood"
|
||||||
|
assert by_kind["authority"]["url"] == "/schools/authority/essex"
|
||||||
|
|
||||||
|
# Every entry carries what the link text needs, and a count, so the anchor
|
||||||
|
# can say what it leads to rather than "click here".
|
||||||
|
for place in places:
|
||||||
|
assert place["name"]
|
||||||
|
assert place["count"] >= 1
|
||||||
|
assert place["url"].startswith("/schools/")
|
||||||
|
|
||||||
|
|
||||||
|
def _brentwood_df(phase: str = "Primary", n: int = None):
|
||||||
|
from backend.places import MIN_SCHOOLS
|
||||||
|
n = n if n is not None else MIN_SCHOOLS
|
||||||
|
return lambda: pd.DataFrame([
|
||||||
|
{
|
||||||
|
"urn": 100000 + i,
|
||||||
|
"school_name": f"Brentwood School {i}",
|
||||||
|
"town": "Brentwood", "local_authority": "Essex",
|
||||||
|
"postcode": "CM15 8AA", "phase": phase, "year": 202425,
|
||||||
|
"rwm_expected_pct": 60.0, "attainment_8_score": 50.0,
|
||||||
|
"ofsted_grade": 2.0, "ofsted_date": None,
|
||||||
|
}
|
||||||
|
for i in range(n)
|
||||||
|
])
|
||||||
|
|
||||||
|
|
||||||
|
def _places_for(monkeypatch, df_factory, urn: int):
|
||||||
|
from backend import app as app_module
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data", df_factory)
|
||||||
|
monkeypatch.setattr(app_module, "get_supplementary_data", lambda db, urn: {})
|
||||||
|
monkeypatch.setattr(app_module, "_place_registry", None)
|
||||||
|
client = TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
|
return client.get(f"/api/schools/{urn}").json()["places"]
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_place_offers_the_phase_page_this_school_appears_on(monkeypatch):
|
||||||
|
# "primary schools in brentwood" is the query the phase pages exist for,
|
||||||
|
# and ~950 of them were once reachable by nothing at all.
|
||||||
|
places = _places_for(monkeypatch, _brentwood_df("Primary"), 100000)
|
||||||
|
town = next(p for p in places if p["kind"] == "town")
|
||||||
|
|
||||||
|
assert town["phases"], "a primary school in a published primary town has a link"
|
||||||
|
assert town["phases"][0]["url"] == "/schools/brentwood/primary"
|
||||||
|
assert town["phases"][0]["count"] >= 1
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_all_through_school_offers_both_phase_pages(monkeypatch):
|
||||||
|
# It genuinely appears on both, so there is no tie to break.
|
||||||
|
places = _places_for(monkeypatch, _brentwood_df("All-through"), 100000)
|
||||||
|
town = next(p for p in places if p["kind"] == "town")
|
||||||
|
|
||||||
|
assert {p["phase"] for p in town["phases"]} == {"primary", "secondary"}
|
||||||
|
|
||||||
|
|
||||||
|
def test_outcodes_never_offer_a_phase_page(monkeypatch):
|
||||||
|
# The registry gives outcodes no phase route — nobody searches "primary
|
||||||
|
# schools in SW11" — and computing them anyway once put a link to a
|
||||||
|
# nonexistent route on all 1,720 outcode pages.
|
||||||
|
places = _places_for(monkeypatch, _brentwood_df("Primary"), 100000)
|
||||||
|
outcode = next((p for p in places if p["kind"] == "outcode"), None)
|
||||||
|
|
||||||
|
if outcode is not None:
|
||||||
|
assert outcode["phases"] == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_school_absent_from_the_phase_page_is_not_linked_to_it(monkeypatch):
|
||||||
|
# The check is URN membership in the registry's own phase list, not a
|
||||||
|
# re-derivation of the phase mapping. A secondary school must not be sent
|
||||||
|
# to a primary phase page that does not list it.
|
||||||
|
from backend.places import MIN_SCHOOLS
|
||||||
|
|
||||||
|
def df():
|
||||||
|
rows = [
|
||||||
|
{"urn": 100000 + i, "school_name": f"P{i}", "town": "Brentwood",
|
||||||
|
"local_authority": "Essex", "postcode": "CM15 8AA",
|
||||||
|
"phase": "Primary", "year": 202425, "rwm_expected_pct": 60.0,
|
||||||
|
"attainment_8_score": np.nan, "ofsted_grade": 2.0,
|
||||||
|
"ofsted_date": None}
|
||||||
|
for i in range(MIN_SCHOOLS)
|
||||||
|
]
|
||||||
|
rows.append({
|
||||||
|
"urn": 900000, "school_name": "Lone Secondary", "town": "Brentwood",
|
||||||
|
"local_authority": "Essex", "postcode": "CM15 8AA",
|
||||||
|
"phase": "Secondary", "year": 202425, "rwm_expected_pct": np.nan,
|
||||||
|
"attainment_8_score": 50.0, "ofsted_grade": 2.0, "ofsted_date": None,
|
||||||
|
})
|
||||||
|
return pd.DataFrame(rows)
|
||||||
|
|
||||||
|
places = _places_for(monkeypatch, df, 900000)
|
||||||
|
town = next(p for p in places if p["kind"] == "town")
|
||||||
|
|
||||||
|
# The town publishes a primary page, but this secondary school is not on
|
||||||
|
# it, and there are too few secondaries for a secondary page.
|
||||||
|
assert town["phases"] == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_the_place_index_rebuilds_when_the_registry_is_replaced(monkeypatch):
|
||||||
|
"""The reverse index is cached; a stale one would put another dataset's
|
||||||
|
places on a school page. Invalidation is an identity check against the
|
||||||
|
registry rather than a second flag, so this asserts the check works."""
|
||||||
|
from backend import app as app_module
|
||||||
|
|
||||||
|
monkeypatch.setattr(app_module, "_place_registry", None)
|
||||||
|
monkeypatch.setattr(app_module, "_place_index", None)
|
||||||
|
monkeypatch.setattr(app_module, "_place_index_source", None)
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data", _brentwood_df("Primary"))
|
||||||
|
|
||||||
|
first = app_module.get_place_index()
|
||||||
|
assert 100000 in first
|
||||||
|
|
||||||
|
# Same registry object, so the index is reused rather than rebuilt.
|
||||||
|
assert app_module.get_place_index() is first
|
||||||
|
|
||||||
|
# Drop the registry the way every test that touches place data does. The
|
||||||
|
# index must follow it, not survive it.
|
||||||
|
app_module._place_registry = None
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data",
|
||||||
|
_brentwood_df("Primary", n=0))
|
||||||
|
|
||||||
|
rebuilt = app_module.get_place_index()
|
||||||
|
assert rebuilt is not first
|
||||||
|
assert 100000 not in rebuilt, "the index outlived the registry it came from"
|
||||||
@@ -0,0 +1,112 @@
|
|||||||
|
"""Parent-facing groups over GIAS establishment types and religious characters.
|
||||||
|
|
||||||
|
Every GIAS code must be accounted for, so a new DfE code fails here instead of
|
||||||
|
silently vanishing from the filter.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import numpy as np
|
||||||
|
import pytest
|
||||||
|
import yaml
|
||||||
|
|
||||||
|
from backend.gias_codes import RELIGIOUS_CHARACTER, SCHOOL_TYPE
|
||||||
|
from backend.school_groups import (
|
||||||
|
FAITH_GROUPS,
|
||||||
|
TYPE_GROUPS,
|
||||||
|
UNOFFERED_TYPE_CODES,
|
||||||
|
faith_groups_for,
|
||||||
|
type_group_for,
|
||||||
|
type_group_key,
|
||||||
|
)
|
||||||
|
|
||||||
|
DBT_PROJECT = Path(__file__).resolve().parents[2] / "pipeline" / "transform" / "dbt_project.yml"
|
||||||
|
|
||||||
|
|
||||||
|
def _non_england_codes() -> set[int]:
|
||||||
|
return set(yaml.safe_load(DBT_PROJECT.read_text())["vars"]["non_england_school_type_codes"])
|
||||||
|
|
||||||
|
|
||||||
|
def test_every_type_code_is_in_exactly_one_place():
|
||||||
|
places = [codes for _, _, codes in TYPE_GROUPS] + [UNOFFERED_TYPE_CODES, _non_england_codes()]
|
||||||
|
for code in SCHOOL_TYPE:
|
||||||
|
homes = sum(code in p for p in places)
|
||||||
|
assert homes == 1, f"type code {code} ({SCHOOL_TYPE[code]}) is in {homes} places"
|
||||||
|
|
||||||
|
|
||||||
|
def test_every_religion_code_has_a_faith():
|
||||||
|
for code, name in RELIGIOUS_CHARACTER.items():
|
||||||
|
assert any(code in codes for _, _, codes in FAITH_GROUPS), f"{code} {name!r}"
|
||||||
|
|
||||||
|
|
||||||
|
def test_type_groups_in_display_order():
|
||||||
|
assert [k for k, _, _ in TYPE_GROUPS] == [
|
||||||
|
"state", "independent", "special", "post16", "alternative"]
|
||||||
|
|
||||||
|
|
||||||
|
def test_faiths_in_display_order():
|
||||||
|
assert [k for k, _, _ in FAITH_GROUPS] == [
|
||||||
|
"none", "church_of_england", "roman_catholic", "other_christian",
|
||||||
|
"jewish", "muslim", "other_faith"]
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("name, group", [
|
||||||
|
("Academy converter", "state"),
|
||||||
|
("University technical college", "state"),
|
||||||
|
("Voluntary aided school", "state"),
|
||||||
|
("Local authority nursery school", "state"),
|
||||||
|
("Other independent school", "independent"),
|
||||||
|
("Other independent special school", "special"),
|
||||||
|
("Special post 16 institution", "special"),
|
||||||
|
("Further education", "post16"),
|
||||||
|
("Pupil referral unit", "alternative"),
|
||||||
|
("academy CONVERTER", "state"),
|
||||||
|
])
|
||||||
|
def test_type_group_by_name(name, group):
|
||||||
|
assert type_group_for(name) == group
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("value, key", [
|
||||||
|
("state", "state"),
|
||||||
|
("Special", "special"),
|
||||||
|
# The two state groups that preceded "state", kept so their links still work.
|
||||||
|
("academy", "state"),
|
||||||
|
("Council", "state"),
|
||||||
|
("Community school", None),
|
||||||
|
("", None),
|
||||||
|
])
|
||||||
|
def test_type_group_key_resolves_keys_and_old_keys(value, key):
|
||||||
|
assert type_group_key(value) == key
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("name", [
|
||||||
|
"Higher education institutions", "Miscellaneous", "Unknown (9999)", "Academy", "", None, np.nan,
|
||||||
|
])
|
||||||
|
def test_unoffered_or_unknown_types_have_no_group(name):
|
||||||
|
assert type_group_for(name) is None
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("name, faiths", [
|
||||||
|
("Roman Catholic/Church of England", ("church_of_england", "roman_catholic")),
|
||||||
|
("Roman Catholic/Anglican", ("church_of_england", "roman_catholic")),
|
||||||
|
("Church of England/Methodist", ("church_of_england", "other_christian")),
|
||||||
|
("Church of England/Christian", ("church_of_england",)),
|
||||||
|
("Catholic", ("roman_catholic",)),
|
||||||
|
("Inter- / non- denominational", ("other_christian",)),
|
||||||
|
("Orthodox Jewish", ("jewish",)),
|
||||||
|
("Sunni Deobandi", ("muslim",)),
|
||||||
|
("Hindu", ("other_faith",)),
|
||||||
|
("Does not apply", ("none",)),
|
||||||
|
("None", ("none",)),
|
||||||
|
])
|
||||||
|
def test_faiths_by_name(name, faiths):
|
||||||
|
assert faith_groups_for(name) == faiths
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("missing", [None, np.nan, "", " "])
|
||||||
|
def test_a_missing_religion_is_no_religious_character(missing):
|
||||||
|
assert faith_groups_for(missing) == ("none",)
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_unknown_religion_has_no_faith():
|
||||||
|
assert faith_groups_for("Unknown (77)") == ()
|
||||||
@@ -0,0 +1,114 @@
|
|||||||
|
from types import SimpleNamespace
|
||||||
|
import pytest
|
||||||
|
from fastapi.testclient import TestClient
|
||||||
|
from backend import app as api, data_loader
|
||||||
|
from backend.tests.test_sixth_form_flag import _schools_df
|
||||||
|
|
||||||
|
|
||||||
|
def client_for(monkeypatch, search):
|
||||||
|
client = SimpleNamespace(collections={'schools': SimpleNamespace(documents=SimpleNamespace(search=search))})
|
||||||
|
monkeypatch.setattr(data_loader, '_get_typesense_client', lambda: client)
|
||||||
|
|
||||||
|
|
||||||
|
def test_search_returns_matches_beyond_first_page(monkeypatch):
|
||||||
|
pages = []
|
||||||
|
def search(params):
|
||||||
|
pages.append(params['page'])
|
||||||
|
urns = range(100000, 100250) if params['page'] == 1 else [100999]
|
||||||
|
return {'found': 251, 'hits': [{'document': {'urn': u}} for u in urns]}
|
||||||
|
client_for(monkeypatch, search)
|
||||||
|
result = data_loader.search_schools_typesense('academy')
|
||||||
|
assert len(result) == 251
|
||||||
|
assert result[-1] == 100999
|
||||||
|
assert pages == [1, 2]
|
||||||
|
|
||||||
|
|
||||||
|
def test_search_caps_broad_queries_at_a_bounded_number_of_pages(monkeypatch):
|
||||||
|
requests = []
|
||||||
|
|
||||||
|
def search(params):
|
||||||
|
requests.append(params)
|
||||||
|
return {
|
||||||
|
'found': 10_000,
|
||||||
|
'hits': [
|
||||||
|
{'document': {'urn': 100000 + params['page'] * 1000 + i}}
|
||||||
|
for i in range(params['per_page'])
|
||||||
|
],
|
||||||
|
}
|
||||||
|
|
||||||
|
client_for(monkeypatch, search)
|
||||||
|
result = data_loader.search_schools_typesense('school')
|
||||||
|
|
||||||
|
assert len(result) == data_loader.SEARCH_MAX_CANDIDATES
|
||||||
|
assert len(requests) == data_loader.SEARCH_MAX_CANDIDATES // data_loader.SEARCH_PAGE_SIZE
|
||||||
|
assert all(request['per_page'] == data_loader.SEARCH_PAGE_SIZE for request in requests)
|
||||||
|
assert requests[-1]['page'] == len(requests)
|
||||||
|
|
||||||
|
|
||||||
|
def test_search_uses_a_smaller_final_page_when_the_cap_is_not_a_page_multiple(monkeypatch):
|
||||||
|
monkeypatch.setattr(data_loader, 'SEARCH_MAX_CANDIDATES', 251)
|
||||||
|
requests = []
|
||||||
|
|
||||||
|
def search(params):
|
||||||
|
requests.append(params)
|
||||||
|
return {
|
||||||
|
'found': 10_000,
|
||||||
|
'hits': [{'document': {'urn': 100000 + len(requests) * 1000 + i}}
|
||||||
|
for i in range(params['per_page'])],
|
||||||
|
}
|
||||||
|
|
||||||
|
client_for(monkeypatch, search)
|
||||||
|
result = data_loader.search_schools_typesense('school')
|
||||||
|
|
||||||
|
assert len(result) == 251
|
||||||
|
assert [request['per_page'] for request in requests] == [250, 1]
|
||||||
|
|
||||||
|
|
||||||
|
def test_later_page_failure_does_not_return_partial_results(monkeypatch):
|
||||||
|
def search(params):
|
||||||
|
if params['page'] == 2:
|
||||||
|
raise RuntimeError('timeout')
|
||||||
|
return {'found': 251, 'hits': [{'document': {'urn': u}} for u in range(100000, 100250)]}
|
||||||
|
client_for(monkeypatch, search)
|
||||||
|
assert data_loader.search_schools_typesense('academy') is None
|
||||||
|
|
||||||
|
|
||||||
|
def test_zero_matches_are_distinct_from_unavailable(monkeypatch):
|
||||||
|
client_for(monkeypatch, lambda _: {'found': 0, 'hits': []})
|
||||||
|
assert data_loader.search_schools_typesense('academy') == []
|
||||||
|
monkeypatch.setattr(data_loader, '_get_typesense_client', lambda: None)
|
||||||
|
assert data_loader.search_schools_typesense('academy') is None
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize('matches, expected', [([], []), (None, [100001])])
|
||||||
|
def test_fallback_only_on_dependency_failure(monkeypatch, matches, expected):
|
||||||
|
monkeypatch.setattr(api.limiter, 'enabled', False)
|
||||||
|
monkeypatch.setattr(api, 'load_latest_school_data', _schools_df)
|
||||||
|
monkeypatch.setattr(api, 'search_schools_typesense', lambda _: matches)
|
||||||
|
response = TestClient(api.app).get('/api/schools?search=Alpha')
|
||||||
|
assert response.status_code == 200
|
||||||
|
assert [s['urn'] for s in response.json()['schools']] == expected
|
||||||
|
|
||||||
|
|
||||||
|
def test_filtered_api_keeps_match_from_second_search_page(monkeypatch):
|
||||||
|
monkeypatch.setattr(api.limiter, 'enabled', False)
|
||||||
|
df = _schools_df()
|
||||||
|
monkeypatch.setattr(api, 'load_latest_school_data', lambda: df)
|
||||||
|
def search(params):
|
||||||
|
urns = range(200000, 200250) if params['page'] == 1 else [100001]
|
||||||
|
return {'found': 251, 'hits': [{'document': {'urn': u}} for u in urns]}
|
||||||
|
client_for(monkeypatch, search)
|
||||||
|
response = TestClient(api.app).get('/api/schools?search=Alpha&local_authority=Testshire')
|
||||||
|
assert response.status_code == 200
|
||||||
|
assert response.json()['total'] == 1
|
||||||
|
assert response.json()['schools'][0]['urn'] == 100001
|
||||||
|
|
||||||
|
|
||||||
|
def test_unavailable_dataset_is_not_a_missing_school_or_empty_search(monkeypatch):
|
||||||
|
import pandas as pd
|
||||||
|
monkeypatch.setattr(api.limiter, 'enabled', False)
|
||||||
|
monkeypatch.setattr(api, 'load_school_data', lambda: pd.DataFrame())
|
||||||
|
monkeypatch.setattr(api, 'load_latest_school_data', lambda: pd.DataFrame())
|
||||||
|
client = TestClient(api.app)
|
||||||
|
assert client.get('/api/schools/100001').status_code == 503
|
||||||
|
assert client.get('/api/schools?search=school').status_code == 503
|
||||||
@@ -0,0 +1,100 @@
|
|||||||
|
"""/api/schools school-type groups and faith filter, and their /api/filters lists."""
|
||||||
|
|
||||||
|
import numpy as np
|
||||||
|
import pandas as pd
|
||||||
|
import pytest
|
||||||
|
from fastapi.testclient import TestClient
|
||||||
|
|
||||||
|
# urn -> (GIAS school type, GIAS religious character)
|
||||||
|
SCHOOLS = {
|
||||||
|
100001: ("Community school", "Does not apply"),
|
||||||
|
100002: ("Voluntary aided school", "Roman Catholic"),
|
||||||
|
100003: ("Academy converter", "Roman Catholic/Church of England"),
|
||||||
|
100004: ("Community special school", None),
|
||||||
|
100005: ("Academy special converter", "Church of England"),
|
||||||
|
100006: ("Other independent school", "Jewish"),
|
||||||
|
100007: ("Miscellaneous", ""),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _schools_df() -> pd.DataFrame:
|
||||||
|
base = {
|
||||||
|
"local_authority": "Testshire", "address": "1 Test Street", "town": "Testtown",
|
||||||
|
"postcode": "TS1 1AA", "age_range": "4-11", "has_sixth_form": None,
|
||||||
|
"gender": "Mixed", "admissions_policy": None, "ofsted_grade": np.nan,
|
||||||
|
"ofsted_date": None, "ofsted_framework": None, "latitude": 51.5,
|
||||||
|
"longitude": -0.1, "year": 202425, "total_pupils": 300,
|
||||||
|
"rwm_expected_pct": np.nan, "attainment_8_score": np.nan, "phase": "Primary",
|
||||||
|
}
|
||||||
|
return pd.DataFrame([
|
||||||
|
{**base, "urn": urn, "school_name": f"School {urn}",
|
||||||
|
"school_type": t, "religious_denomination": r}
|
||||||
|
for urn, (t, r) in SCHOOLS.items()
|
||||||
|
])
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture()
|
||||||
|
def client(monkeypatch):
|
||||||
|
from backend import app as app_module
|
||||||
|
|
||||||
|
monkeypatch.setattr(app_module, "load_latest_school_data", _schools_df)
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data", _schools_df)
|
||||||
|
return TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
|
|
||||||
|
|
||||||
|
def _urns(client, **params):
|
||||||
|
resp = client.get("/api/schools", params={"page_size": 50, **params})
|
||||||
|
assert resp.status_code == 200, resp.text
|
||||||
|
return sorted(s["urn"] for s in resp.json()["schools"])
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("key, urns", [
|
||||||
|
("state", [100001, 100002, 100003]),
|
||||||
|
("academy", [100001, 100002, 100003]),
|
||||||
|
("council", [100001, 100002, 100003]),
|
||||||
|
("special", [100004, 100005]),
|
||||||
|
("independent", [100006]),
|
||||||
|
("Special", [100004, 100005]),
|
||||||
|
])
|
||||||
|
def test_a_type_group_key_filters_to_its_group(client, key, urns):
|
||||||
|
assert _urns(client, school_type=key) == urns
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_raw_type_label_still_filters_exactly(client):
|
||||||
|
assert _urns(client, school_type="Community school") == [100001]
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("key, urns", [
|
||||||
|
("roman_catholic", [100002, 100003]),
|
||||||
|
("church_of_england", [100003, 100005]),
|
||||||
|
("none", [100001, 100004, 100007]),
|
||||||
|
("jewish", [100006]),
|
||||||
|
("Roman_Catholic", [100002, 100003]),
|
||||||
|
])
|
||||||
|
def test_faith_filters_to_its_group_joint_schools_included(client, key, urns):
|
||||||
|
assert _urns(client, faith=key) == urns
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_unknown_faith_returns_nothing(client):
|
||||||
|
assert _urns(client, faith="nonsense") == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_type_and_faith_combine(client):
|
||||||
|
assert _urns(client, school_type="special", faith="church_of_england") == [100005]
|
||||||
|
|
||||||
|
|
||||||
|
def test_filters_lists_only_groups_present_in_order(client):
|
||||||
|
body = client.get("/api/filters").json()
|
||||||
|
assert body["school_type_groups"] == [
|
||||||
|
{"value": "state", "label": "State school (free)"},
|
||||||
|
{"value": "independent", "label": "Independent (fee-paying)"},
|
||||||
|
{"value": "special", "label": "Special school (SEND)"},
|
||||||
|
]
|
||||||
|
assert body["faiths"] == [
|
||||||
|
{"value": "none", "label": "No religious character"},
|
||||||
|
{"value": "church_of_england", "label": "Church of England"},
|
||||||
|
{"value": "roman_catholic", "label": "Roman Catholic"},
|
||||||
|
{"value": "jewish", "label": "Jewish"},
|
||||||
|
]
|
||||||
|
# The raw list is still there for anything that reads it.
|
||||||
|
assert "Community school" in body["school_types"]
|
||||||
@@ -1,26 +0,0 @@
|
|||||||
"""
|
|
||||||
Schema versioning for database migrations.
|
|
||||||
|
|
||||||
HOW TO USE:
|
|
||||||
- Bump SCHEMA_VERSION when making changes to database models
|
|
||||||
- This triggers an automatic full data reimport on next app startup
|
|
||||||
|
|
||||||
WHEN TO BUMP:
|
|
||||||
- Adding/removing columns in models.py
|
|
||||||
- Changing column types or constraints
|
|
||||||
- Modifying CSV column mappings in schemas.py
|
|
||||||
- Any change that requires fresh data import
|
|
||||||
"""
|
|
||||||
|
|
||||||
# Current schema version - increment when models change
|
|
||||||
SCHEMA_VERSION = 6
|
|
||||||
|
|
||||||
# Changelog for documentation
|
|
||||||
SCHEMA_CHANGELOG = {
|
|
||||||
1: "Initial schema with School and SchoolResult tables",
|
|
||||||
2: "Added pupil absence fields (reading, maths, gps, writing, science)",
|
|
||||||
3: "Added supplementary data tables: ofsted, parent_view, census, admissions, sen_detail, phonics, deprivation, finance; GIAS columns on schools",
|
|
||||||
4: "Added Ofsted Report Card columns to ofsted_inspections (new framework from Nov 2025)",
|
|
||||||
5: "Apply ALTER TABLE additions for RC columns missed by create_all on existing tables",
|
|
||||||
6: "Removed the Ofsted Parent View feature: dropped fact_parent_view table and model",
|
|
||||||
}
|
|
||||||
@@ -1,180 +1,37 @@
|
|||||||
# SchoolCompare.co.uk - Project Context
|
# SchoolCompare project context
|
||||||
|
|
||||||
## Overview
|
## Maintained documentation
|
||||||
|
|
||||||
SchoolCompare is a web application for comparing UK primary school (KS2) performance data. It allows users to:
|
Read [README.md](README.md), [docs/ARCHITECTURE.md](docs/ARCHITECTURE.md) and
|
||||||
- Search and browse schools by name, location (postcode), or local authority
|
[docs/DEVELOPMENT.md](docs/DEVELOPMENT.md) for the current implementation.
|
||||||
- Compare multiple schools side-by-side with charts and tables
|
[docs/LEGACY_CODE.md](docs/LEGACY_CODE.md) records obsolete paths and deliberate
|
||||||
- View school rankings by various KS2 metrics
|
compatibility code. Historical design documents are not current setup instructions.
|
||||||
- See historical performance trends across years
|
|
||||||
|
|
||||||
## Architecture
|
## Architecture constraints
|
||||||
|
|
||||||
### Backend (Python/FastAPI)
|
- Next.js serves the public UI. FastAPI serves school data from dbt-built `marts.*`.
|
||||||
- **Framework**: FastAPI with uvicorn
|
The backend does not create school tables or import CSVs at startup.
|
||||||
- **Database**: PostgreSQL with SQLAlchemy ORM
|
- School coverage spans England and multiple phases, not only primary schools in
|
||||||
- **Data Source**: UK Government "Compare School Performance" CSV downloads
|
Wandsworth and Merton.
|
||||||
|
- `/api/*` belongs to the FastAPI proxy. Payload uses `/cms-api` and `/admin`.
|
||||||
Key files:
|
- Payload runs inside Next.js, with its own `payload` schema and persistent media.
|
||||||
- `backend/app.py` - Main FastAPI application, API routes
|
Keep CMS migrations independent of school-data transformations.
|
||||||
- `backend/config.py` - Configuration via pydantic-settings (env vars, .env file)
|
- Public and Payload route groups have separate root layouts. Do not introduce
|
||||||
- `backend/database.py` - SQLAlchemy engine, session management
|
`app/layout.tsx`. Keep site-wide metadata files at the `app/` root.
|
||||||
- `backend/models.py` - Database models (School, SchoolResult)
|
- Builds must succeed with `DATABASE_URL` unset. Do not call `getCachedPayload()`
|
||||||
- `backend/data_loader.py` - Data queries, geocoding, legacy DataFrame compatibility
|
at module scope or add DB-backed `generateStaticParams`.
|
||||||
- `backend/schemas.py` - Column mappings, metric definitions, LA code mappings
|
- After changing CMS fields/editors, run `npm run generate:importmap` and commit
|
||||||
|
the generated import map. See `nextjs-app/docs/PUBLISHING.md`.
|
||||||
### Content / CMS (Payload)
|
- The backend and pipeline GIAS dictionary copies are generated together; preserve
|
||||||
|
their parity. Tests enforce it.
|
||||||
Payload CMS runs **inside** the Next.js app — one image, one container, no
|
|
||||||
separate service. It powers `/blog`; `/about` is a plain coded page.
|
|
||||||
|
|
||||||
- **Admin panel:** `/admin`. The only authenticated surface on the site.
|
|
||||||
`noindex` via both `robots.txt` and `X-Robots-Tag`.
|
|
||||||
- **CMS API:** `/cms-api`, **not** `/api`. `/api/*` is a catch-all proxy to
|
|
||||||
FastAPI (`app/(frontend)/api/[...path]`) which would silently swallow every
|
|
||||||
admin call and forward it to the backend. Mount points are defined once in
|
|
||||||
`lib/payloadRoutes.ts`.
|
|
||||||
- **Database:** the existing Postgres, in its own `payload` schema, so no
|
|
||||||
pipeline operation on `public` — including
|
|
||||||
`scripts/migrate_csv_to_db.py --drop` — can reach blog content.
|
|
||||||
- **Uploads:** the `payload_media` Docker volume at `/app/media`. Not
|
|
||||||
reproducible from the pipeline; must be backed up.
|
|
||||||
- **New env vars:** `DATABASE_URL` and `PAYLOAD_SECRET` on the frontend service.
|
|
||||||
Staging must use a different `PAYLOAD_SECRET` from production.
|
|
||||||
- Publishing workflow and house style: `nextjs-app/docs/PUBLISHING.md`.
|
|
||||||
- **Admin field components resolve through a generated import map**
|
|
||||||
(`app/(payload)/admin/importMap.js`). Payload hands the client a *path* per
|
|
||||||
field and looks it up there; a missing entry renders no field and reports no
|
|
||||||
error, while `required` still blocks the save. After adding or changing any
|
|
||||||
field, editor or lexical feature, run `npm run generate:importmap` in
|
|
||||||
`nextjs-app/` and commit the result.
|
|
||||||
|
|
||||||
### Two route groups
|
|
||||||
|
|
||||||
`nextjs-app/app/` has no root `layout.tsx`. It cannot: Payload's admin panel
|
|
||||||
ships its own root layout rendering `<html>`/`<body>`, and Next permits
|
|
||||||
multiple root layouts only when no `app/layout.tsx` exists.
|
|
||||||
|
|
||||||
- `app/(frontend)/` — the site. Its `layout.tsx` is the site's root layout.
|
|
||||||
- `app/(payload)/` — the admin panel and `/cms-api`.
|
|
||||||
|
|
||||||
Route groups are invisible to routing, so every public URL is unchanged.
|
|
||||||
|
|
||||||
**The metadata file conventions stay at the `app/` root** — `robots.ts`,
|
|
||||||
`opengraph-image.tsx`, `icon.png`, `apple-icon.png`. Inside a route group Next
|
|
||||||
treats them as segment-scoped: it renames `/icon.png` to `/icon-<hash>.png` and
|
|
||||||
drops `/robots.txt` entirely. Route handlers are unaffected.
|
|
||||||
|
|
||||||
The build must succeed with `DATABASE_URL` unset, because CI builds it that
|
|
||||||
way. Never call `getCachedPayload()` at module scope, and never add
|
|
||||||
`generateStaticParams` to a DB-backed route.
|
|
||||||
|
|
||||||
### Frontend (Vanilla JS)
|
|
||||||
- Single-page application with hash-based routing
|
|
||||||
- Chart.js for data visualization
|
|
||||||
- No build step required
|
|
||||||
|
|
||||||
Key files:
|
|
||||||
- `frontend/index.html` - Main HTML structure
|
|
||||||
- `frontend/app.js` - All application logic, API calls, rendering
|
|
||||||
- `frontend/styles.css` - Styling (CSS variables, responsive design)
|
|
||||||
|
|
||||||
### Database Schema
|
|
||||||
|
|
||||||
```
|
|
||||||
schools school_results
|
|
||||||
├── id (PK) ├── id (PK)
|
|
||||||
├── urn (unique, indexed) ├── school_id (FK → schools.id)
|
|
||||||
├── school_name ├── year (indexed)
|
|
||||||
├── local_authority ├── rwm_expected_pct
|
|
||||||
├── school_type ├── reading_expected_pct
|
|
||||||
├── postcode ├── ... (all KS2 metrics)
|
|
||||||
├── latitude, longitude └── unique(school_id, year)
|
|
||||||
└── results → SchoolResult[]
|
|
||||||
```
|
|
||||||
|
|
||||||
## Configuration
|
|
||||||
|
|
||||||
Environment variables (or `.env` file):
|
|
||||||
- `DATABASE_URL` - PostgreSQL connection string (default: `postgresql://schoolcompare:schoolcompare@localhost:5432/schoolcompare`)
|
|
||||||
- `HOST`, `PORT` - Server binding (default: `0.0.0.0:80`)
|
|
||||||
- `ALLOWED_ORIGINS` - CORS origins
|
|
||||||
|
|
||||||
## Running Locally
|
|
||||||
|
|
||||||
1. Start PostgreSQL:
|
|
||||||
```bash
|
|
||||||
docker compose up -d db
|
|
||||||
```
|
|
||||||
|
|
||||||
2. Run migration to import CSV data:
|
|
||||||
```bash
|
|
||||||
python scripts/migrate_csv_to_db.py --drop
|
|
||||||
# Add --geocode to geocode postcodes (slower, adds lat/long)
|
|
||||||
```
|
|
||||||
|
|
||||||
3. Start the app:
|
|
||||||
```bash
|
|
||||||
uvicorn backend.app:app --host 0.0.0.0 --port 8000
|
|
||||||
```
|
|
||||||
|
|
||||||
## Docker Deployment
|
|
||||||
|
|
||||||
```bash
|
|
||||||
docker compose up -d
|
|
||||||
```
|
|
||||||
|
|
||||||
This starts:
|
|
||||||
- `db` - PostgreSQL 16 with persistent volume
|
|
||||||
- `app` - FastAPI application on port 80
|
|
||||||
|
|
||||||
## Data
|
|
||||||
|
|
||||||
- Source: UK Government Compare School Performance downloads
|
|
||||||
- Location: `data/` directory with year folders (e.g., `2023-2024/england_ks2final.csv`)
|
|
||||||
- The `scripts/download_data.py` can fetch data from the government website
|
|
||||||
|
|
||||||
## Key Features
|
|
||||||
|
|
||||||
- **Location Search**: Enter postcode to find nearby schools (uses postcodes.io API)
|
|
||||||
- **Multi-school Comparison**: Select multiple schools, view metrics across years
|
|
||||||
- **Rankings**: Top schools by any KS2 metric, filterable by local authority
|
|
||||||
- **Variability Analysis**: Shows standard deviation of scores across years
|
|
||||||
|
|
||||||
## API Endpoints
|
|
||||||
|
|
||||||
- `GET /api/schools` - List/search schools (supports pagination, location search)
|
|
||||||
- `GET /api/schools/{urn}` - School details with all yearly data
|
|
||||||
- `GET /api/compare?urns=123,456` - Compare multiple schools
|
|
||||||
- `GET /api/rankings` - School rankings by metric
|
|
||||||
- `GET /api/filters` - Available filter options (LAs, types, years)
|
|
||||||
- `GET /api/metrics` - Metric definitions (single source of truth)
|
|
||||||
- `GET /api/data-info` - Database stats
|
|
||||||
|
|
||||||
## SDLC
|
## SDLC
|
||||||
|
|
||||||
Full details in `docs/DEPLOY.md`. The short version:
|
Follow [docs/DEPLOY.md](docs/DEPLOY.md).
|
||||||
|
|
||||||
- **Never push to `main` directly.** Work on a feature branch and open a PR;
|
- Never push directly to `main`. Use a feature branch and a PR with passing checks.
|
||||||
branch protection requires the PR checks (typecheck, tests, builds, AI review)
|
- Merges deploy staging only. Production promotion is a separate human decision;
|
||||||
to pass before merge.
|
do not trigger the promotion workflow yourself.
|
||||||
- Merging to `main` deploys automatically **to staging only**: images are
|
- Update E2E journeys in the same PR when changing user-facing behaviour.
|
||||||
built once, deployed to the staging Portainer stack, and verified by the
|
- Do not attempt to start a local server to test the application; use unit checks
|
||||||
Playwright journeys in `e2e/`. Production is a second, manual approval:
|
and the configured integration environment.
|
||||||
the "Promote to Production (manual)" workflow in Gitea Actions, run after
|
|
||||||
testing the feature on staging. It refuses commits whose staging E2E gate
|
|
||||||
isn't green. Never trigger it yourself — promotion is the human's call.
|
|
||||||
- If you change user-facing behaviour, update or extend the `e2e/` journey
|
|
||||||
tests in the same PR — they gate whether staging is fit for human testing
|
|
||||||
and whether a commit is promotable.
|
|
||||||
|
|
||||||
## Recent Changes
|
|
||||||
|
|
||||||
- Added staging environment + automated staging→prod pipeline (Gitea Actions)
|
|
||||||
- Migrated from CSV file storage to PostgreSQL database
|
|
||||||
- Added location-based search using postcode geocoding
|
|
||||||
- Added local authority filter to rankings
|
|
||||||
- Improved frontend with featured schools, loading states, API caching
|
|
||||||
|
|
||||||
# Important
|
|
||||||
- Do not attempt to start a local server to test the application, it does not work
|
|
||||||
@@ -0,0 +1,125 @@
|
|||||||
|
# Architecture
|
||||||
|
|
||||||
|
This describes the implementation as reviewed on 2026-09-14. It distinguishes
|
||||||
|
current behaviour from improvements still to be implemented.
|
||||||
|
|
||||||
|
## Request flow
|
||||||
|
|
||||||
|
```text
|
||||||
|
Browser → Next.js public routes
|
||||||
|
├─ /api/* proxy → FastAPI → cached DataFrames / PostgreSQL marts
|
||||||
|
│ ├─ Typesense (search and suggestions)
|
||||||
|
│ └─ postcodes.io (postcode lookup)
|
||||||
|
└─ /admin, /cms-api, /blog → Payload → payload schema + media volume
|
||||||
|
|
||||||
|
Next.js server rendering → FastAPI directly through FASTAPI_URL
|
||||||
|
```
|
||||||
|
|
||||||
|
`nextjs-app/lib/api.ts` contains typed fetch wrappers and revalidation defaults.
|
||||||
|
The proxy is `nextjs-app/app/(frontend)/api/[...path]/route.ts`. Payload uses
|
||||||
|
`/cms-api` so its routes do not collide with the FastAPI proxy. The proxy denies
|
||||||
|
`/api/flags`; server-side rendering reads flags directly from FastAPI.
|
||||||
|
|
||||||
|
## Data ownership
|
||||||
|
|
||||||
|
| Layer | Owner and role |
|
||||||
|
|---|---|
|
||||||
|
| Source data | GIAS, DfE EES, Ofsted, finance, deprivation and council admission-distance sources |
|
||||||
|
| `raw` | Singer taps and the PostgreSQL target configured in `pipeline/meltano.yml` |
|
||||||
|
| Staging/intermediate/marts | dbt models in `pipeline/transform`; marts are materialized tables |
|
||||||
|
| `marts.dim_school`, `marts.dim_location` | School identity and location, filtered to supported England establishments |
|
||||||
|
| `marts.fact_*` | Performance and supplementary datasets; coverage and years vary |
|
||||||
|
| Typesense `schools` alias | Search documents built by `pipeline/scripts/sync_typesense.py` |
|
||||||
|
| `payload` | CMS collections and migrations in `nextjs-app/`; independent of dbt |
|
||||||
|
| Media volume | Uploaded blog media; requires backup and cannot be regenerated from school datasets |
|
||||||
|
|
||||||
|
`backend/models.py` maps existing marts for reading. It does not create the school
|
||||||
|
schema. There is no startup schema-version migration or CSV reimport. Payload's
|
||||||
|
`nextjs-app/migrations/` is active and must not be confused with the removed
|
||||||
|
legacy backend migration code.
|
||||||
|
|
||||||
|
Coordinates normally come from GIAS British National Grid coordinates transformed
|
||||||
|
by PostGIS in `dim_location.sql`. `pipeline/scripts/geocode_postcodes.py` is a
|
||||||
|
manual fallback utility, not a task wired into the current school-data DAG.
|
||||||
|
Backend postcode searches also use postcodes.io; that lookup does not populate
|
||||||
|
school coordinates in the database.
|
||||||
|
|
||||||
|
## Backend boundaries
|
||||||
|
|
||||||
|
- `app.py`: routes, middleware, search filtering, sitemap/place publication and response assembly.
|
||||||
|
- `data_loader.py`: SQL loading, process-local DataFrame caches, Typesense calls,
|
||||||
|
postcode lookups, supplementary queries and benchmark calculation.
|
||||||
|
- `database.py`: synchronous SQLAlchemy engine and sessions.
|
||||||
|
- `schemas.py`: metric definitions, column mappings and display metadata; despite
|
||||||
|
its name this is not a collection of Pydantic API response models.
|
||||||
|
- `places.py` and `localities.py`: place registry and curated locality information.
|
||||||
|
- `flags.py`: Unleash-backed feature flags, disabled when no server is configured.
|
||||||
|
- `gias_codes.py` / `ofsted_codes.py`: source-code translation and display rules.
|
||||||
|
|
||||||
|
Search starts from a cached latest-row-per-school snapshot. Detail pages read
|
||||||
|
history from the full DataFrame and supplementary data from marts. Comparisons
|
||||||
|
batch supplementary queries across selected URNs. Async routes still contain
|
||||||
|
synchronous dependency calls; a fully asynchronous database layer is not present.
|
||||||
|
|
||||||
|
## Frontend boundaries
|
||||||
|
|
||||||
|
`app/(frontend)` owns the public root layout and pages. `app/(payload)` owns the
|
||||||
|
CMS root layout. Do not add a shared `app/layout.tsx`: these groups deliberately
|
||||||
|
have separate root layouts. Root metadata files remain in `app/`.
|
||||||
|
|
||||||
|
Server pages fetch initial data and pass it to client views. Client state uses
|
||||||
|
React hooks, URL search parameters and the comparison context/localStorage.
|
||||||
|
There is no SWR dependency. Leaflet maps are loaded through dynamic wrappers;
|
||||||
|
Chart.js renders performance and comparison charts.
|
||||||
|
|
||||||
|
`components/school/` contains detail sections, with section decisions and data
|
||||||
|
preparation in `lib/schoolSections.ts`. The nearby-schools section is selected in
|
||||||
|
`backend/nearby_schools.py` — hard filters decide eligibility (phase, provision,
|
||||||
|
selectivity, gender) and distance alone decides the order, capped per phase —
|
||||||
|
and served on `/api/schools/{urn}`. Its rules are presentation logic,
|
||||||
|
deliberately kept out of `marts.*` so they can be tuned by deploy rather than by
|
||||||
|
pipeline run. `lib/types.ts` contains manually maintained
|
||||||
|
API types. `payload-types.ts` and the Payload import map are generated artifacts.
|
||||||
|
|
||||||
|
## Publication and caching today
|
||||||
|
|
||||||
|
1. Airflow DAGs extract and validate source data, then run selected dbt builds.
|
||||||
|
2. Relevant DAGs rebuild Typesense and swap the `schools` alias.
|
||||||
|
3. They call `POST /api/admin/reload` with `X-API-Key`. It builds and validates
|
||||||
|
replacement DataFrames, places, reverse membership and sitemaps off the request
|
||||||
|
loop, then publishes them together. Failure returns 503 and preserves live data.
|
||||||
|
4. A separate weekly sitemap DAG can regenerate the derived publication from the
|
||||||
|
current DataFrame without clearing the live registry first.
|
||||||
|
|
||||||
|
GIAS is scheduled daily, Ofsted monthly, and annual datasets are manually
|
||||||
|
triggered. The DAG definitions are authoritative for selectors and dependencies.
|
||||||
|
|
||||||
|
Caches exist in several independent layers: backend DataFrames and registries,
|
||||||
|
backend HTTP Cache-Control/ETags, Next.js fetch/page revalidation, and browser or
|
||||||
|
shared HTTP caches where configured. Place fetches request a one-week revalidation
|
||||||
|
interval. HTTP ETags are computed after route execution, not before database work.
|
||||||
|
|
||||||
|
Typesense publication validates every import response and the final document
|
||||||
|
count before switching aliases. A session-scoped PostgreSQL advisory lock
|
||||||
|
serialises index reads/publication across DAGs. The previous collection remains
|
||||||
|
available for rollback; old unaliased collections are pruned after success.
|
||||||
|
Failed drafts are retained until a later successful cleanup, because an uncertain
|
||||||
|
alias-update response must never cause deletion of a potentially live index.
|
||||||
|
|
||||||
|
The backend snapshot swap is process-local and assumes the current single-worker
|
||||||
|
deployment. It is not an atomic transaction spanning PostgreSQL marts, Typesense
|
||||||
|
and Next.js caches. Next.js caches are not explicitly purged by the pipeline.
|
||||||
|
School search retrieves a relevance-ordered candidate prefix (currently capped at
|
||||||
|
1,000 URNs) before applying API filters. This keeps scoped searches useful while
|
||||||
|
putting a hard ceiling on Typesense round trips; only a dependency failure invokes
|
||||||
|
substring fallback, not a valid empty match set.
|
||||||
|
|
||||||
|
## Deployment references
|
||||||
|
|
||||||
|
See [DEPLOY.md](DEPLOY.md). PR checks include frontend typechecking/tests, backend
|
||||||
|
unit tests, image builds and AI review. Staging journeys run after merging.
|
||||||
|
Staging runs are serialised across builds, deployment and E2E. Build-stamped
|
||||||
|
frontend/backend identities are checked before and after journeys. Only then are
|
||||||
|
the captured image digests marked verified. Promotion resolves and validates the
|
||||||
|
complete verified image set before retagging production. See the runbook for
|
||||||
|
first-rollout requirements and remaining integration checks.
|
||||||
+53
-4
@@ -19,8 +19,9 @@ PR checks (.gitea/workflows/pr-checks.yml)
|
|||||||
▼
|
▼
|
||||||
Stage pipeline (.gitea/workflows/deploy.yml) — automatic
|
Stage pipeline (.gitea/workflows/deploy.yml) — automatic
|
||||||
1. build & push images → tags sha-<sha>, staging
|
1. build & push images → tags sha-<sha>, staging
|
||||||
2. staging Portainer webhook → wait for staging health
|
2. staging Portainer webhook → verify frontend/backend SHA + build ID
|
||||||
3. Playwright E2E journeys against staging ← gate before human testing
|
3. Playwright E2E journeys against staging ← gate before human testing
|
||||||
|
4. verify identity again; tag tested digests verified-<full-sha>
|
||||||
▼
|
▼
|
||||||
Manual testing on staging (stx.schoolcompare.co.uk)
|
Manual testing on staging (stx.schoolcompare.co.uk)
|
||||||
│ Actions → "Promote to Production (manual)" ← approval #2
|
│ Actions → "Promote to Production (manual)" ← approval #2
|
||||||
@@ -28,14 +29,15 @@ Manual testing on staging (stx.schoolcompare.co.uk)
|
|||||||
Promote pipeline (.gitea/workflows/promote.yml) — manual dispatch
|
Promote pipeline (.gitea/workflows/promote.yml) — manual dispatch
|
||||||
1. resolve target sha (input, or latest main if empty)
|
1. resolve target sha (input, or latest main if empty)
|
||||||
2. REFUSE unless that commit's "E2E Journeys against Staging" status is green
|
2. REFUSE unless that commit's "E2E Journeys against Staging" status is green
|
||||||
3. retag sha-<sha> → :prod (same bytes — build once, promote the image)
|
3. resolve verified-<full-sha> digests, validate labels, retag digests → :prod
|
||||||
previous :prod saved as :prod-previous
|
previous :prod saved as :prod-previous
|
||||||
4. prod Portainer webhook → wait for prod health
|
4. prod Portainer webhook → verify expected SHA + build ID
|
||||||
```
|
```
|
||||||
|
|
||||||
Key principle: **build once, promote the exact image**. Production pins `:prod`,
|
Key principle: **build once, promote the exact image**. Production pins `:prod`,
|
||||||
which only moves when a human runs the promote workflow — and the workflow
|
which only moves when a human runs the promote workflow — and the workflow
|
||||||
only accepts commits that passed the staging E2E gate. Nothing tags `:latest`
|
only accepts commits that passed the staging E2E gate and have a complete verified
|
||||||
|
image set. Nothing tags `:latest`
|
||||||
anymore.
|
anymore.
|
||||||
|
|
||||||
## Branch & PR workflow
|
## Branch & PR workflow
|
||||||
@@ -256,3 +258,50 @@ how long any feature is exposed to this.
|
|||||||
If `UNLEASH_URL` is unset, every flag is `False` and no connection is
|
If `UNLEASH_URL` is unset, every flag is `False` and no connection is
|
||||||
attempted. That is the correct behaviour for local development and CI, and it
|
attempted. That is the correct behaviour for local development and CI, and it
|
||||||
means the test suites need no flag server.
|
means the test suites need no flag server.
|
||||||
|
|
||||||
|
## Release identity and the P1 reliability gate
|
||||||
|
|
||||||
|
Every staging run creates a random build ID before building its three images.
|
||||||
|
Each image carries the commit and build ID as labels. Frontend/backend images
|
||||||
|
also contain a build-time JSON file; environment overrides cannot rewrite it.
|
||||||
|
`/release.json` returns both identities with `Cache-Control: no-store`. It fails
|
||||||
|
with 503 when either identity cannot be read. FastAPI's internal endpoint is
|
||||||
|
`/api/release`.
|
||||||
|
|
||||||
|
The entire staging workflow shares one concurrency group, with cancellation
|
||||||
|
disabled. This needs Gitea 1.26 or newer, where workflow concurrency is supported
|
||||||
|
([release notes](https://blog.gitea.com/release-of-1.26.0/)); the configured server
|
||||||
|
reported 1.27.3 during this change. Do not run the workflow on an older server
|
||||||
|
that ignores the concurrency key. Manual deployments outside this workflow must
|
||||||
|
also avoid changing staging during journeys.
|
||||||
|
|
||||||
|
The gate checks both identities before and after Playwright. It then validates
|
||||||
|
labels on the captured build output digests and tags them `verified-<full-sha>`.
|
||||||
|
The manual promotion script resolves all three verified tags to immutable digests
|
||||||
|
and confirms one matching commit/build ID before moving any `:prod` tag. It polls
|
||||||
|
production for that same identity using a locally saved release manifest.
|
||||||
|
A registry error can still interrupt the three tag writes; the Portainer webhook
|
||||||
|
only runs after successful promotion, and rerunning promotion resolves the full
|
||||||
|
verified set again. There is no cross-registry atomic tag transaction.
|
||||||
|
|
||||||
|
**First rollout:** old green commits without verified tags/build identities are
|
||||||
|
not promotable through this gate. Build and test a commit containing the new
|
||||||
|
workflow first. The release route must be reachable through the configured
|
||||||
|
`STAGING_BASE_URL`/`PROD_BASE_URL`; it deliberately avoids the public staging
|
||||||
|
`/api` proxy limitation. No new deployment secret is required.
|
||||||
|
|
||||||
|
`scripts/ci/release.py` implements identity polling and digest verification.
|
||||||
|
The poller identifies itself as `SchoolCompare-Release-Check/1.0`: the public
|
||||||
|
staging proxy has returned HTTP 403 to Python's default urllib user agent even
|
||||||
|
while the release endpoint was healthy. It logs changes in HTTP/connection
|
||||||
|
failures or observed release identities, and includes the last observation in
|
||||||
|
the timeout error. If verification fails, use that observation to distinguish
|
||||||
|
proxy rejection (403), an unavailable release endpoint (503), and containers
|
||||||
|
still reporting an older SHA/build ID. Check the configured base URL from the
|
||||||
|
CI runner; a successful request from another machine does not establish runner
|
||||||
|
connectivity. Do not bypass identity verification to unblock a deployment.
|
||||||
|
Its mocked tests run in PR checks alongside backend and index-publication tests.
|
||||||
|
The new Playwright journeys also check deployed identity and stale pagination.
|
||||||
|
Local unit checks do not validate registry credentials, Portainer behaviour,
|
||||||
|
proxy routing or a deployed image; those require the staging run. Production
|
||||||
|
promotion remains a separate human action.
|
||||||
@@ -0,0 +1,94 @@
|
|||||||
|
# Development and validation
|
||||||
|
|
||||||
|
## Prerequisites and environment boundaries
|
||||||
|
|
||||||
|
Use a feature branch. The deployed stack is the integration environment; do not
|
||||||
|
assume a local server can run from a fresh checkout. This cleanup did not start
|
||||||
|
local servers or provision databases. Unit tests use fixtures and mocks.
|
||||||
|
|
||||||
|
The current versions are not yet aligned:
|
||||||
|
|
||||||
|
| Component | Container | PR checks |
|
||||||
|
|---|---|---|
|
||||||
|
| Backend | Python 3.11 | Python 3.12 |
|
||||||
|
| Frontend | Node 24 | Node 22 |
|
||||||
|
| Pipeline | Python 3.13 | Pipeline image build |
|
||||||
|
|
||||||
|
Use the component's container version when reproducing deployment behaviour.
|
||||||
|
The backend dependency pins predate Python 3.14; do not assume the system Python
|
||||||
|
can install or run them. Version alignment is a separate maintenance task.
|
||||||
|
|
||||||
|
## Frontend checks
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd nextjs-app
|
||||||
|
npm ci
|
||||||
|
npm run typecheck
|
||||||
|
npm test -- --runInBand
|
||||||
|
```
|
||||||
|
|
||||||
|
`npm run build` is the production build check. There is no `lint` script.
|
||||||
|
Tests live in `__tests__/` and use Jest/React Testing Library. These checks do not
|
||||||
|
prove that live PostgreSQL queries, Typesense or a deployed proxy work.
|
||||||
|
|
||||||
|
The frontend `.env.example` documents runtime variables. Browser traffic normally
|
||||||
|
uses `/api`; `FASTAPI_URL` is an absolute server-side URL ending in `/api`.
|
||||||
|
Payload additionally needs `DATABASE_URL` and `PAYLOAD_SECRET` when used at runtime.
|
||||||
|
Never commit credentials or real `.env` files.
|
||||||
|
|
||||||
|
## Backend checks
|
||||||
|
|
||||||
|
From the repository root, using an available Python 3.11 or 3.12 interpreter:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
python3.11 -m venv /tmp/schoolcompare-backend-venv
|
||||||
|
/tmp/schoolcompare-backend-venv/bin/python -m pip install -r requirements.txt pytest 'httpx<0.28' pyyaml
|
||||||
|
/tmp/schoolcompare-backend-venv/bin/python -m pytest backend/tests pipeline/tests scripts/ci/tests -q
|
||||||
|
```
|
||||||
|
|
||||||
|
Substitute `python3.12` if matching PR CI. The test dependencies above match the
|
||||||
|
current workflow; they are not yet captured in a dedicated development lockfile.
|
||||||
|
Backend configuration is defined in `backend/config.py`; `.env.example` documents
|
||||||
|
commonly used values. `ALLOWED_ORIGINS` uses a JSON array, not a comma-separated string.
|
||||||
|
|
||||||
|
## Data and pipeline work
|
||||||
|
|
||||||
|
The app needs populated `marts.*` tables. A new Postgres instance alone is not a
|
||||||
|
working school-data environment. Use the existing managed pipeline or an approved
|
||||||
|
snapshot; the removed CSV importer cannot build the current schema.
|
||||||
|
|
||||||
|
The pipeline container includes Meltano, dbt/Postgres, Airflow and the custom taps.
|
||||||
|
Airflow commands/selectors live in `pipeline/dags/`. Schema tests live in
|
||||||
|
`pipeline/transform/tests/` and model YAML files. Run the relevant `dbt build`
|
||||||
|
selector in an isolated data environment for model changes; it writes tables and
|
||||||
|
is not a read-only smoke test. Prefer `python -m dbt.cli.main` as the DAGs do.
|
||||||
|
|
||||||
|
GIAS dictionaries are generated together by
|
||||||
|
`pipeline/scripts/generate_gias_codes.py`. The backend and pipeline copies are
|
||||||
|
intentional; `backend/tests/test_gias_codes.py` checks that they stay identical.
|
||||||
|
|
||||||
|
For Payload collection/editor changes, run `npm run generate:importmap` in
|
||||||
|
`nextjs-app/` and include the generated map. Preserve CMS migrations and the
|
||||||
|
separate `payload` schema. See [publishing](../nextjs-app/docs/PUBLISHING.md).
|
||||||
|
|
||||||
|
## End-to-end checks
|
||||||
|
|
||||||
|
Against an existing, authorised test environment:
|
||||||
|
|
||||||
|
```sh
|
||||||
|
cd e2e
|
||||||
|
npm ci
|
||||||
|
npx playwright install chromium
|
||||||
|
BASE_URL=https://your-test-environment.example npx playwright test
|
||||||
|
```
|
||||||
|
|
||||||
|
The suite does not start a web server. CI installs Chromium with system dependencies
|
||||||
|
and runs against staging. Use the configured staging target: `docs/DEPLOY.md`
|
||||||
|
records the public staging proxy limitation. User-visible behaviour changes should
|
||||||
|
update the corresponding journeys.
|
||||||
|
|
||||||
|
## Before requesting review
|
||||||
|
|
||||||
|
Run checks relevant to the change, inspect `git diff --check`, and report checks
|
||||||
|
that could not run. Do not publish or promote as part of local validation.
|
||||||
|
[DEPLOY.md](DEPLOY.md) documents the PR and human promotion gates.
|
||||||
@@ -0,0 +1,90 @@
|
|||||||
|
# Legacy and unused-code inventory
|
||||||
|
|
||||||
|
Reviewed 2026-09-14. This inventory records source evidence, not production usage
|
||||||
|
telemetry. A command with no repository caller may still be run manually or from
|
||||||
|
an external scheduler. Historical specs and prototypes are not runtime imports.
|
||||||
|
|
||||||
|
## Method and scope
|
||||||
|
|
||||||
|
Searched backend imports, tests, CLI scripts, Airflow DAGs, Meltano configuration,
|
||||||
|
Gitea workflows, Dockerfiles and documentation. For frontend candidates, inspected
|
||||||
|
TypeScript imports, re-exports, literal dynamic imports and `require` calls,
|
||||||
|
resolving relative and `@/` paths while excluding tests, dependencies and build
|
||||||
|
output. Checked candidates again with text searches including tests.
|
||||||
|
|
||||||
|
Next.js route files, generated Payload import-map entries and plugin discovery
|
||||||
|
are entry points even without ordinary imports. This is why a zero-import count
|
||||||
|
alone is not sufficient grounds for deletion. Computed imports and external
|
||||||
|
operators are outside this static audit.
|
||||||
|
|
||||||
|
## Removed in this cleanup
|
||||||
|
|
||||||
|
These names are recorded for Git-history lookup; they are no longer file links.
|
||||||
|
|
||||||
|
| Removed path or symbol | Evidence and replacement |
|
||||||
|
|---|---|
|
||||||
|
| `backend/migration.py` | Imported `School` and `SchoolResult`, which no longer exist in `backend/models.py`. Only the legacy CSV CLI imported it. Current tables are built by dbt. |
|
||||||
|
| `backend/version.py` | Only the legacy importer consumed `SCHEMA_VERSION`. FastAPI lifespan does not perform version-triggered imports. This is unrelated to active Payload migrations. |
|
||||||
|
| `scripts/migrate_csv_to_db.py` | Imported removed `init_db`/`set_db_schema_version` helpers and the obsolete models indirectly. No runtime, DAG or workflow calls it. Use the managed pipeline for current marts. |
|
||||||
|
| `scripts/geocode_schools.py` | Imported the removed `School` ORM model. No pipeline/workflow calls it. Coordinates now come from GIAS/PostGIS; a separate mart-aware manual utility remains under `pipeline/scripts/`. |
|
||||||
|
| `backend.data_loader.haversine_distance` | No callers. Search uses its inline vectorised NumPy calculation. |
|
||||||
|
| `nextjs-app/lib/api.ts: fetcher` | No callers; SWR is not installed. Application fetches use the named API wrappers. |
|
||||||
|
| `nextjs-app/lib/api.ts: kmToMiles` | No callers. `calculateDistance` remains because `CutoffMapPanel` uses it. |
|
||||||
|
|
||||||
|
The removed command files could not import successfully against the current
|
||||||
|
backend. This cleanup does not run replacements, migrate data or modify databases.
|
||||||
|
Their previous implementations remain recoverable from Git history.
|
||||||
|
|
||||||
|
## Unused candidates retained for a separate cleanup
|
||||||
|
|
||||||
|
| Candidate | Evidence | Recommended next step |
|
||||||
|
|---|---|---|
|
||||||
|
| `nextjs-app/components/LoadingSkeleton.tsx` and its CSS | No application or test imports found. | Remove together after confirming no planned use. |
|
||||||
|
| `nextjs-app/components/Pagination.tsx` and its CSS | No application or test imports found; HomeView implements load-more behaviour. | Remove as a pair if numbered pagination will not return. |
|
||||||
|
| `nextjs-app/components/SchoolCard.tsx` and its CSS | Imported by its own tests, not application code. HomeView uses SchoolRow/SecondarySchoolRow. | Decide whether to retire the card design; if removed, remove its dedicated tests as well. Passing tests do not establish runtime use. |
|
||||||
|
| `backend/database.py: get_db`, `get_db_session` | No remaining callers after removing the importer. Current code creates SessionLocal directly. | Either adopt these helpers during session-lifecycle cleanup or remove them; do not rewrite active sessions in a documentation change. |
|
||||||
|
| `backend/schemas.py: COLUMN_MAPPINGS`, `NULL_VALUES`, `LA_CODE_TO_NAME` | No remaining Python consumers found after importer removal. Other constants in this module are active. | Remove individual constants after checking external data utilities; retain the module. |
|
||||||
|
| `backend/app.py: result_filters` keys `school_types`, `phases`, `genders`, `admissions_policies` | Since 2026-10-02 FilterBar offers these from `/api/filters`, because options scoped to the results left only the chosen value on offer. Only `local_authorities` is still read. | Stop computing the four keys in a focused API change; keep `local_authorities`. |
|
||||||
|
| `backend/config.py: data_dir`, `max_page_size`, `rate_limit_burst` | No active consumers found. `default_page_size` appears only in a branch that expects None, although the route supplies a concrete default. | Reconcile settings with route validation in a focused API change. |
|
||||||
|
|
||||||
|
## Legacy/manual paths requiring operational verification
|
||||||
|
|
||||||
|
| Path | Status and reason to retain for now |
|
||||||
|
|---|---|
|
||||||
|
| FastAPI `/`, `/compare`, `/rankings`, `/favicon.svg`, `/robots.txt`, and conditional `/static` | Old frontend-serving routes reference a `frontend/` directory absent from the checkout and backend image. Next.js owns these public surfaces. Removal changes externally callable routes, so first check proxy/operator usage and define replacement responses. |
|
||||||
|
| `scripts/fetch_real_data.py`, `scripts/download_data.py` | Historical standalone CSV utilities. The fetch script targets Wandsworth/Merton; neither is wired into the managed pipeline. Marked historical, retained pending confirmation of manual use. |
|
||||||
|
| `pipeline/scripts/geocode_postcodes.py` | Mart-aware postcode fallback, not called by the current DAGs. Do not confuse it with the removed legacy ORM geocoder. Verify the target schema before manual use. |
|
||||||
|
| `docker-compose.yml` | Uses unpublished `:latest` release tags and lacks frontend Payload DB/secret/media configuration. Retained as an old development topology, not recommended onboarding. |
|
||||||
|
| `nextjs-app/docker-compose.yml` | Standalone legacy recipe with old backend port assumptions and no CMS persistence setup. Retained until its consumers are checked. |
|
||||||
|
| `MIGRATION_SUMMARY.md`, `docs/superpowers/`, `mockups/` | Historical designs and prototypes. Retain as history; do not follow as current deployment instructions. |
|
||||||
|
| `scripts/sql/drop_fact_parent_view.sql` | One-off maintenance SQL. Not an application entry point; repository call-site searches cannot establish whether it is still needed operationally. |
|
||||||
|
|
||||||
|
## Active code that can look obsolete
|
||||||
|
|
||||||
|
- `backend/data_loader.py` older-mart query fallbacks are covered by backend tests
|
||||||
|
and support databases at different migration stages. Remove only after verifying
|
||||||
|
the deployed schemas in every supported environment.
|
||||||
|
- `backend/gias_codes.py` and `pipeline/scripts/gias_codes.py` are intentionally
|
||||||
|
generated copies for separate runtime images. Their parity is tested.
|
||||||
|
- `nextjs-app/migrations/`, `payload-types.ts` and the Payload import map are active
|
||||||
|
CMS artifacts, not remnants of the removed school importer.
|
||||||
|
- `get_available_years`, `get_available_local_authorities` and `get_schools_count`
|
||||||
|
in `data_loader.py` are called through `get_data_info`, which serves the backend
|
||||||
|
data-info endpoint. They are not dead functions.
|
||||||
|
- `get_supplementary_data` is an intentional single-school wrapper around the
|
||||||
|
batch implementation.
|
||||||
|
- `pipeline/transform` models named `legacy` can be active data sources: annual
|
||||||
|
DAG selectors explicitly include legacy KS2/KS4 lineage. Names alone do not
|
||||||
|
establish obsolescence.
|
||||||
|
|
||||||
|
## Suggested next passes
|
||||||
|
|
||||||
|
1. Decide the fate of the three unused UI components and remove paired assets/tests.
|
||||||
|
2. Consolidate backend session usage and remove abandoned settings/constants.
|
||||||
|
3. Verify external consumers, then retire static-serving API routes and old compose recipes.
|
||||||
|
4. Audit manual data utilities with pipeline operators before deleting them.
|
||||||
|
5. Revisit compatibility fallbacks only after documenting supported schema versions.
|
||||||
|
|
||||||
|
Validation for this cleanup should include frontend typechecking/tests, Python
|
||||||
|
syntax checks, reference searches and documentation link checks. Live database,
|
||||||
|
external scheduler and deployed route usage require separate integration evidence.
|
||||||
File diff suppressed because it is too large.
Load diff
@@ -0,0 +1,911 @@
|
|||||||
|
# School Type Groups and a Faith Filter Implementation Plan
|
||||||
|
|
||||||
|
> **For agentic workers:** REQUIRED SUB-SKILL: Use superpowers:subagent-driven-development (recommended) or superpowers:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
|
||||||
|
|
||||||
|
**Goal:** Replace the School type filter's 34 GIAS types with six parent-facing groups, and add a Faith filter with eight options.
|
||||||
|
|
||||||
|
**Architecture:** A new backend module `backend/school_groups.py` holds both groupings as GIAS code sets and exposes lookups by the translated *name* (the DataFrame the API filters only carries names). `/api/schools` accepts a group key for `school_type` and a new `faith` key; `/api/filters` gains `school_type_groups` and `faiths` as `{value, label}` lists. The frontend's FilterBar reads those lists for its School type select and a new Faith select.
|
||||||
|
|
||||||
|
**Tech Stack:** FastAPI + pandas (backend, pytest via uv), Next.js 15 / React (frontend, Jest + Testing Library), Playwright (E2E against staging).
|
||||||
|
|
||||||
|
**Spec:** `docs/superpowers/specs/2026-10-02-school-type-groups-and-faith-filter-design.md`
|
||||||
|
|
||||||
|
## Global Constraints
|
||||||
|
|
||||||
|
- Type group keys, labels and order, verbatim: `academy` "State school: academy or free school", `council` "State school: council-run", `independent` "Independent (fee-paying)", `special` "Special school (SEND)", `post16` "Sixth form or college", `alternative` "Alternative provision".
|
||||||
|
- Faith keys, labels and order, verbatim: `none` "No religious character", `church_of_england` "Church of England", `roman_catholic` "Roman Catholic", `other_christian` "Other Christian", `jewish` "Jewish", `muslim` "Muslim", `other_faith` "Other faith".
|
||||||
|
- Select defaults, verbatim: "Any school type", "Any faith or none". Faith select `aria-label="Faith"`.
|
||||||
|
- `/api/filters` keeps `school_types` (raw list) unchanged; the new keys are additions.
|
||||||
|
- An old raw-label `school_type` value (e.g. `Community school`) still filters by that label exactly.
|
||||||
|
- An unknown `faith` key returns no schools.
|
||||||
|
- Do not change `backend/gias_codes.py` or `pipeline/scripts/gias_codes.py` (their parity is tested).
|
||||||
|
- No copy may use an em dash (`__tests__/components/noEmDashCopy.test.ts`).
|
||||||
|
- Backend tests run from the repo root with: `uv run --with-requirements requirements.txt --with pytest --with "httpx==0.27.0" python -m pytest backend/tests -q`
|
||||||
|
- Frontend checks run from `nextjs-app/`: `npx jest` and `npx tsc --noEmit`.
|
||||||
|
- Do not start a local server. E2E journeys are verified against staging after merge.
|
||||||
|
|
||||||
|
## Review Focus
|
||||||
|
|
||||||
|
- A school whose `religious_denomination` is `None`/NaN or `""` (GIAS code 99) must count as "No religious character", not drop out of every faith option. Pinned in Task 1.
|
||||||
|
- A type or religion label the dictionaries do not know (e.g. `"Unknown (9999)"`, or a test fixture's `"Academy"`) must map to no group without raising. Pinned in Task 1.
|
||||||
|
- `/api/filters` returning no `school_type_groups`/`faiths` (API failed, or an older backend) must leave the selects out rather than render "Any…" alone. Pinned in Task 3.
|
||||||
|
- An old bookmarked URL with `school_type=Community+school` must still return community schools and show a chip with its raw label. Pinned in Tasks 2 and 3.
|
||||||
|
- Mixed case in a key (`?faith=Roman_Catholic`, `?school_type=Special`) must still match. Pinned in Task 2.
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
## File Structure
|
||||||
|
|
||||||
|
| File | Responsibility |
|
||||||
|
|---|---|
|
||||||
|
| `backend/school_groups.py` (new) | The two groupings as code sets, and name-based lookups. Nothing else. |
|
||||||
|
| `backend/tests/test_school_groups.py` (new) | Coverage of every GIAS code, joint faiths, unknown/blank names. |
|
||||||
|
| `backend/app.py` (modify) | `faith` param; group-key branch for `school_type`; two new `/api/filters` keys. |
|
||||||
|
| `backend/tests/test_type_and_faith_filters.py` (new) | API behaviour of both filters and the new `/api/filters` keys. |
|
||||||
|
| `nextjs-app/lib/types.ts` (modify) | `FilterOption`; optional `school_type_groups`/`faiths` on `Filters`; `faith` on `SchoolSearchParams`. |
|
||||||
|
| `nextjs-app/app/(frontend)/page.tsx` (modify) | Read and forward `faith`. |
|
||||||
|
| `nextjs-app/components/FilterBar.tsx` (modify) | Grouped School type options; Faith select; chips, counts, analytics. |
|
||||||
|
| `nextjs-app/__tests__/components/FilterBarTypeFaith.test.tsx` (new) | Frontend behaviour of both selects. |
|
||||||
|
| Existing FilterBar tests (modify) | Fixtures move from raw types to groups. |
|
||||||
|
| `e2e/tests/journeys.spec.ts` (modify) | A journey for both filters. |
|
||||||
|
| Spec (modify) | Architecture section: grouping is by name at filter time. |
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 1: The groupings module
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Create: `backend/school_groups.py`
|
||||||
|
- Test: `backend/tests/test_school_groups.py`
|
||||||
|
- Modify: `docs/superpowers/specs/2026-10-02-school-type-groups-and-faith-filter-design.md` (Architecture)
|
||||||
|
|
||||||
|
**Interfaces:**
|
||||||
|
- Consumes: `backend.gias_codes.SCHOOL_TYPE: dict[int, str]`, `backend.gias_codes.RELIGIOUS_CHARACTER: dict[int, str]` (code 99 maps to `""`).
|
||||||
|
- Produces:
|
||||||
|
- `TYPE_GROUPS: tuple[tuple[str, str, frozenset[int]], ...]` (key, label, codes), in display order
|
||||||
|
- `UNOFFERED_TYPE_CODES: frozenset[int]`
|
||||||
|
- `FAITH_GROUPS: tuple[tuple[str, str, frozenset[int]], ...]`, in display order
|
||||||
|
- `TYPE_GROUP_KEYS: frozenset[str]`, `FAITH_KEYS: frozenset[str]`
|
||||||
|
- `type_group_for(name: object) -> str | None`
|
||||||
|
- `faith_groups_for(name: object) -> tuple[str, ...]`
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Create `backend/tests/test_school_groups.py`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
"""Parent-facing groups over GIAS establishment types and religious characters.
|
||||||
|
|
||||||
|
Every GIAS code must be accounted for, so a new DfE code fails here instead of
|
||||||
|
silently vanishing from the filter.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from pathlib import Path
|
||||||
|
|
||||||
|
import numpy as np
|
||||||
|
import pytest
|
||||||
|
import yaml
|
||||||
|
|
||||||
|
from backend.gias_codes import RELIGIOUS_CHARACTER, SCHOOL_TYPE
|
||||||
|
from backend.school_groups import (
|
||||||
|
FAITH_GROUPS,
|
||||||
|
TYPE_GROUPS,
|
||||||
|
UNOFFERED_TYPE_CODES,
|
||||||
|
faith_groups_for,
|
||||||
|
type_group_for,
|
||||||
|
)
|
||||||
|
|
||||||
|
DBT_PROJECT = Path(__file__).resolve().parents[2] / "pipeline" / "transform" / "dbt_project.yml"
|
||||||
|
|
||||||
|
|
||||||
|
def _non_england_codes() -> set[int]:
|
||||||
|
return set(yaml.safe_load(DBT_PROJECT.read_text())["vars"]["non_england_school_type_codes"])
|
||||||
|
|
||||||
|
|
||||||
|
def test_every_type_code_is_in_exactly_one_place():
|
||||||
|
places = [codes for _, _, codes in TYPE_GROUPS] + [UNOFFERED_TYPE_CODES, _non_england_codes()]
|
||||||
|
for code in SCHOOL_TYPE:
|
||||||
|
homes = sum(code in p for p in places)
|
||||||
|
assert homes == 1, f"type code {code} ({SCHOOL_TYPE[code]}) is in {homes} places"
|
||||||
|
|
||||||
|
|
||||||
|
def test_every_religion_code_has_a_faith():
|
||||||
|
for code, name in RELIGIOUS_CHARACTER.items():
|
||||||
|
assert any(code in codes for _, _, codes in FAITH_GROUPS), f"{code} {name!r}"
|
||||||
|
|
||||||
|
|
||||||
|
def test_type_groups_in_display_order():
|
||||||
|
assert [k for k, _, _ in TYPE_GROUPS] == [
|
||||||
|
"academy", "council", "independent", "special", "post16", "alternative"]
|
||||||
|
|
||||||
|
|
||||||
|
def test_faiths_in_display_order():
|
||||||
|
assert [k for k, _, _ in FAITH_GROUPS] == [
|
||||||
|
"none", "church_of_england", "roman_catholic", "other_christian",
|
||||||
|
"jewish", "muslim", "other_faith"]
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("name, group", [
|
||||||
|
("Academy converter", "academy"),
|
||||||
|
("University technical college", "academy"),
|
||||||
|
("Voluntary aided school", "council"),
|
||||||
|
("Local authority nursery school", "council"),
|
||||||
|
("Other independent school", "independent"),
|
||||||
|
("Other independent special school", "special"),
|
||||||
|
("Special post 16 institution", "special"),
|
||||||
|
("Further education", "post16"),
|
||||||
|
("Pupil referral unit", "alternative"),
|
||||||
|
("academy CONVERTER", "academy"),
|
||||||
|
])
|
||||||
|
def test_type_group_by_name(name, group):
|
||||||
|
assert type_group_for(name) == group
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("name", [
|
||||||
|
"Higher education institutions", "Miscellaneous", "Unknown (9999)", "Academy", "", None, np.nan,
|
||||||
|
])
|
||||||
|
def test_unoffered_or_unknown_types_have_no_group(name):
|
||||||
|
assert type_group_for(name) is None
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("name, faiths", [
|
||||||
|
("Roman Catholic/Church of England", ("church_of_england", "roman_catholic")),
|
||||||
|
("Roman Catholic/Anglican", ("church_of_england", "roman_catholic")),
|
||||||
|
("Church of England/Methodist", ("church_of_england", "other_christian")),
|
||||||
|
("Church of England/Christian", ("church_of_england",)),
|
||||||
|
("Catholic", ("roman_catholic",)),
|
||||||
|
("Inter- / non- denominational", ("other_christian",)),
|
||||||
|
("Orthodox Jewish", ("jewish",)),
|
||||||
|
("Sunni Deobandi", ("muslim",)),
|
||||||
|
("Hindu", ("other_faith",)),
|
||||||
|
("Does not apply", ("none",)),
|
||||||
|
("None", ("none",)),
|
||||||
|
])
|
||||||
|
def test_faiths_by_name(name, faiths):
|
||||||
|
assert faith_groups_for(name) == faiths
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("missing", [None, np.nan, "", " "])
|
||||||
|
def test_a_missing_religion_is_no_religious_character(missing):
|
||||||
|
assert faith_groups_for(missing) == ("none",)
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_unknown_religion_has_no_faith():
|
||||||
|
assert faith_groups_for("Unknown (77)") == ()
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run them to see them fail**
|
||||||
|
|
||||||
|
Run: `uv run --with-requirements requirements.txt --with pytest --with "httpx==0.27.0" python -m pytest backend/tests/test_school_groups.py -q`
|
||||||
|
Expected: collection error, `ModuleNotFoundError: No module named 'backend.school_groups'`.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Write the module**
|
||||||
|
|
||||||
|
Create `backend/school_groups.py`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
"""Parent-facing groups over GIAS establishment types and religious characters.
|
||||||
|
|
||||||
|
The 34 GIAS establishment types describe governance and funding, which for a
|
||||||
|
mainstream state school barely changes what a parent experiences. The search
|
||||||
|
filter offers six groups a parent recognises instead, and a faith filter in
|
||||||
|
place of the faith signal that "Voluntary aided" and "Voluntary controlled"
|
||||||
|
only half carry. See
|
||||||
|
docs/superpowers/specs/2026-10-02-school-type-groups-and-faith-filter-design.md.
|
||||||
|
|
||||||
|
Groups are defined over GIAS codes and looked up by the translated name,
|
||||||
|
because the DataFrame the API filters carries names only: the codes are
|
||||||
|
replaced at load (data_loader.translate_gias_code_columns), the legacy-name
|
||||||
|
mart fallback never had them, and test fixtures are written in names.
|
||||||
|
"""
|
||||||
|
|
||||||
|
from typing import Optional
|
||||||
|
|
||||||
|
import pandas as pd
|
||||||
|
|
||||||
|
from .gias_codes import RELIGIOUS_CHARACTER, SCHOOL_TYPE
|
||||||
|
|
||||||
|
# (key, label, GIAS TypeOfEstablishment codes), in the order shown.
|
||||||
|
TYPE_GROUPS: tuple[tuple[str, str, frozenset[int]], ...] = (
|
||||||
|
# Academy sponsor led, Academy converter, Free schools, University technical
|
||||||
|
# college, Studio schools, City technology college. UTCs and studio schools
|
||||||
|
# are legally academies, and a family considering one searches by name.
|
||||||
|
("academy", "State school: academy or free school", frozenset({28, 34, 35, 40, 41, 6})),
|
||||||
|
# Community, Voluntary aided, Voluntary controlled, Foundation, LA nursery.
|
||||||
|
("council", "State school: council-run", frozenset({1, 2, 3, 5, 15})),
|
||||||
|
("independent", "Independent (fee-paying)", frozenset({11})),
|
||||||
|
# Every special type, independent ones included (usually funded by the
|
||||||
|
# council through an EHCP, so SEND provision to a parent, not private
|
||||||
|
# school), and Special post 16 institutions.
|
||||||
|
("special", "Special school (SEND)", frozenset({7, 8, 10, 12, 32, 33, 36, 44})),
|
||||||
|
# Further education, Sixth form centres, the 16-19 academies and free schools.
|
||||||
|
("post16", "Sixth form or college", frozenset({18, 31, 39, 45, 46})),
|
||||||
|
# Pupil referral units and AP academies and free schools. Last: parents do
|
||||||
|
# not apply to these; the local authority places children there.
|
||||||
|
("alternative", "Alternative provision", frozenset({14, 38, 42, 43})),
|
||||||
|
)
|
||||||
|
|
||||||
|
# In no group, so reachable only under "Any school type": Secure units,
|
||||||
|
# Miscellaneous, Higher education institutions, Online provider, Institution
|
||||||
|
# funded by other government department, Academy secure 16 to 19.
|
||||||
|
UNOFFERED_TYPE_CODES: frozenset[int] = frozenset({24, 27, 29, 49, 56, 57})
|
||||||
|
|
||||||
|
# (key, label, GIAS ReligiousCharacter codes), in the order shown. A joint
|
||||||
|
# school is in every faith its label names; a generic "Christian" beside a
|
||||||
|
# named church adds nothing.
|
||||||
|
FAITH_GROUPS: tuple[tuple[str, str, frozenset[int]], ...] = (
|
||||||
|
# Does not apply, None, and 99 (a blank label).
|
||||||
|
("none", "No religious character", frozenset({0, 6, 99})),
|
||||||
|
("church_of_england", "Church of England",
|
||||||
|
frozenset({2, 9, 10, 11, 12, 13, 19, 20, 30, 31, 32, 33, 34, 41, 48})),
|
||||||
|
("roman_catholic", "Roman Catholic", frozenset({3, 11, 13, 35, 48})),
|
||||||
|
# 28 "Inter- / non- denominational" is how GIAS files Christian schools
|
||||||
|
# tied to no one church.
|
||||||
|
("other_christian", "Other Christian",
|
||||||
|
frozenset({4, 8, 9, 10, 12, 14, 15, 16, 17, 18, 19, 22, 26, 28, 30, 33,
|
||||||
|
37, 38, 39, 40, 41, 44, 45, 46, 47})),
|
||||||
|
("jewish", "Jewish", frozenset({5, 36, 43})),
|
||||||
|
("muslim", "Muslim", frozenset({7, 42, 49})),
|
||||||
|
("other_faith", "Other faith", frozenset({21, 24, 25, 29})),
|
||||||
|
)
|
||||||
|
|
||||||
|
TYPE_GROUP_KEYS: frozenset[str] = frozenset(k for k, _, _ in TYPE_GROUPS)
|
||||||
|
FAITH_KEYS: frozenset[str] = frozenset(k for k, _, _ in FAITH_GROUPS)
|
||||||
|
|
||||||
|
|
||||||
|
def _key(name: str) -> str:
|
||||||
|
return name.strip().lower()
|
||||||
|
|
||||||
|
|
||||||
|
_TYPE_GROUP_BY_NAME: dict[str, str] = {
|
||||||
|
_key(SCHOOL_TYPE[code]): key
|
||||||
|
for key, _, codes in TYPE_GROUPS
|
||||||
|
for code in codes
|
||||||
|
if code in SCHOOL_TYPE
|
||||||
|
}
|
||||||
|
|
||||||
|
_FAITHS_BY_NAME: dict[str, tuple[str, ...]] = {}
|
||||||
|
for _faith, _, _codes in FAITH_GROUPS:
|
||||||
|
for _code in sorted(_codes):
|
||||||
|
if _code in RELIGIOUS_CHARACTER:
|
||||||
|
_name = _key(RELIGIOUS_CHARACTER[_code])
|
||||||
|
_FAITHS_BY_NAME[_name] = _FAITHS_BY_NAME.get(_name, ()) + (_faith,)
|
||||||
|
|
||||||
|
|
||||||
|
def type_group_for(name: object) -> Optional[str]:
|
||||||
|
"""The type group of a GIAS establishment type name, or None."""
|
||||||
|
if not isinstance(name, str):
|
||||||
|
return None
|
||||||
|
return _TYPE_GROUP_BY_NAME.get(_key(name))
|
||||||
|
|
||||||
|
|
||||||
|
def faith_groups_for(name: object) -> tuple[str, ...]:
|
||||||
|
"""The faith groups of a GIAS religious character name.
|
||||||
|
|
||||||
|
A missing or blank name is "No religious character". A name the
|
||||||
|
dictionary does not know has no faith, so it matches no faith option.
|
||||||
|
"""
|
||||||
|
if not isinstance(name, str):
|
||||||
|
return ("none",) if name is None or pd.isna(name) else ()
|
||||||
|
return _FAITHS_BY_NAME.get(_key(name), ())
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run the tests to see them pass**
|
||||||
|
|
||||||
|
Run: `uv run --with-requirements requirements.txt --with pytest --with "httpx==0.27.0" python -m pytest backend/tests/test_school_groups.py -q`
|
||||||
|
Expected: all pass.
|
||||||
|
|
||||||
|
- [ ] **Step 5: Correct the spec's architecture**
|
||||||
|
|
||||||
|
In the spec, replace the `### backend/data_loader.py` subsection with:
|
||||||
|
|
||||||
|
```markdown
|
||||||
|
### Grouping by name, at filter time
|
||||||
|
|
||||||
|
The groups are defined over codes but looked up by the translated name
|
||||||
|
(`type_group_for(name)`, `faith_groups_for(name)`), when `/api/schools` and
|
||||||
|
`/api/filters` filter. The DataFrame those endpoints read carries names only:
|
||||||
|
`translate_gias_code_columns` replaces the codes at load, the legacy-name
|
||||||
|
mart fallback never had codes, and the API test fixtures are written in
|
||||||
|
names. The names come from the same dictionaries, so the lookup is exact.
|
||||||
|
`data_loader.py` is unchanged.
|
||||||
|
```
|
||||||
|
|
||||||
|
and in `### backend/school_groups.py (new)` replace the `type_group_for(code)` / `faith_groups_for(code)` bullet with `type_group_for(name) -> str | None` and `faith_groups_for(name) -> tuple[str, ...]` (a missing or blank name gives `("none",)`).
|
||||||
|
|
||||||
|
- [ ] **Step 6: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add backend/school_groups.py backend/tests/test_school_groups.py docs/superpowers/specs/2026-10-02-school-type-groups-and-faith-filter-design.md
|
||||||
|
git commit -m "feat(api): group GIAS school types and religions for parents"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 2: The API filters
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `backend/app.py` (imports near line 43; `get_schools` params ~738-747, sanitising ~755-759, secondary filters ~782-786, `school_type` filter ~886-889; `get_filter_options` ~1155-1180)
|
||||||
|
- Test: `backend/tests/test_type_and_faith_filters.py`
|
||||||
|
|
||||||
|
**Interfaces:**
|
||||||
|
- Consumes: from Task 1, `TYPE_GROUPS`, `FAITH_GROUPS`, `TYPE_GROUP_KEYS`, `FAITH_KEYS`, `type_group_for`, `faith_groups_for`.
|
||||||
|
- Produces:
|
||||||
|
- `GET /api/schools?school_type=<group key | raw label>&faith=<faith key>`
|
||||||
|
- `GET /api/filters` adds `"school_type_groups": [{"value": str, "label": str}]` and `"faiths": [{"value": str, "label": str}]`, in group order, groups with no school left out.
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Create `backend/tests/test_type_and_faith_filters.py`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
"""/api/schools school-type groups and faith filter, and their /api/filters lists."""
|
||||||
|
|
||||||
|
import numpy as np
|
||||||
|
import pandas as pd
|
||||||
|
import pytest
|
||||||
|
from fastapi.testclient import TestClient
|
||||||
|
|
||||||
|
# urn -> (GIAS school type, GIAS religious character)
|
||||||
|
SCHOOLS = {
|
||||||
|
100001: ("Community school", "Does not apply"),
|
||||||
|
100002: ("Voluntary aided school", "Roman Catholic"),
|
||||||
|
100003: ("Academy converter", "Roman Catholic/Church of England"),
|
||||||
|
100004: ("Community special school", None),
|
||||||
|
100005: ("Academy special converter", "Church of England"),
|
||||||
|
100006: ("Other independent school", "Jewish"),
|
||||||
|
100007: ("Miscellaneous", ""),
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def _schools_df() -> pd.DataFrame:
|
||||||
|
base = {
|
||||||
|
"local_authority": "Testshire", "address": "1 Test Street", "town": "Testtown",
|
||||||
|
"postcode": "TS1 1AA", "age_range": "4-11", "has_sixth_form": None,
|
||||||
|
"gender": "Mixed", "admissions_policy": None, "ofsted_grade": np.nan,
|
||||||
|
"ofsted_date": None, "ofsted_framework": None, "latitude": 51.5,
|
||||||
|
"longitude": -0.1, "year": 202425, "total_pupils": 300,
|
||||||
|
"rwm_expected_pct": np.nan, "attainment_8_score": np.nan, "phase": "Primary",
|
||||||
|
}
|
||||||
|
return pd.DataFrame([
|
||||||
|
{**base, "urn": urn, "school_name": f"School {urn}",
|
||||||
|
"school_type": t, "religious_denomination": r}
|
||||||
|
for urn, (t, r) in SCHOOLS.items()
|
||||||
|
])
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.fixture()
|
||||||
|
def client(monkeypatch):
|
||||||
|
from backend import app as app_module
|
||||||
|
|
||||||
|
monkeypatch.setattr(app_module, "load_latest_school_data", _schools_df)
|
||||||
|
monkeypatch.setattr(app_module, "load_school_data", _schools_df)
|
||||||
|
return TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
|
|
||||||
|
|
||||||
|
def _urns(client, **params):
|
||||||
|
resp = client.get("/api/schools", params={"page_size": 50, **params})
|
||||||
|
assert resp.status_code == 200, resp.text
|
||||||
|
return sorted(s["urn"] for s in resp.json()["schools"])
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("key, urns", [
|
||||||
|
("council", [100001, 100002]),
|
||||||
|
("academy", [100003]),
|
||||||
|
("special", [100004, 100005]),
|
||||||
|
("independent", [100006]),
|
||||||
|
("Special", [100004, 100005]),
|
||||||
|
])
|
||||||
|
def test_a_type_group_key_filters_to_its_group(client, key, urns):
|
||||||
|
assert _urns(client, school_type=key) == urns
|
||||||
|
|
||||||
|
|
||||||
|
def test_a_raw_type_label_still_filters_exactly(client):
|
||||||
|
assert _urns(client, school_type="Community school") == [100001]
|
||||||
|
|
||||||
|
|
||||||
|
@pytest.mark.parametrize("key, urns", [
|
||||||
|
("roman_catholic", [100002, 100003]),
|
||||||
|
("church_of_england", [100003, 100005]),
|
||||||
|
("none", [100001, 100004, 100007]),
|
||||||
|
("jewish", [100006]),
|
||||||
|
("Roman_Catholic", [100002, 100003]),
|
||||||
|
])
|
||||||
|
def test_faith_filters_to_its_group_joint_schools_included(client, key, urns):
|
||||||
|
assert _urns(client, faith=key) == urns
|
||||||
|
|
||||||
|
|
||||||
|
def test_an_unknown_faith_returns_nothing(client):
|
||||||
|
assert _urns(client, faith="nonsense") == []
|
||||||
|
|
||||||
|
|
||||||
|
def test_type_and_faith_combine(client):
|
||||||
|
assert _urns(client, school_type="special", faith="church_of_england") == [100005]
|
||||||
|
|
||||||
|
|
||||||
|
def test_filters_lists_only_groups_present_in_order(client):
|
||||||
|
body = client.get("/api/filters").json()
|
||||||
|
assert body["school_type_groups"] == [
|
||||||
|
{"value": "academy", "label": "State school: academy or free school"},
|
||||||
|
{"value": "council", "label": "State school: council-run"},
|
||||||
|
{"value": "independent", "label": "Independent (fee-paying)"},
|
||||||
|
{"value": "special", "label": "Special school (SEND)"},
|
||||||
|
]
|
||||||
|
assert body["faiths"] == [
|
||||||
|
{"value": "none", "label": "No religious character"},
|
||||||
|
{"value": "church_of_england", "label": "Church of England"},
|
||||||
|
{"value": "roman_catholic", "label": "Roman Catholic"},
|
||||||
|
{"value": "jewish", "label": "Jewish"},
|
||||||
|
]
|
||||||
|
# The raw list is still there for anything that reads it.
|
||||||
|
assert "Community school" in body["school_types"]
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run them to see them fail**
|
||||||
|
|
||||||
|
Run: `uv run --with-requirements requirements.txt --with pytest --with "httpx==0.27.0" python -m pytest backend/tests/test_type_and_faith_filters.py -q`
|
||||||
|
Expected: the group-key, faith and `/api/filters` tests fail (`KeyError: 'school_type_groups'`, empty URN lists); `test_a_raw_type_label_still_filters_exactly` passes.
|
||||||
|
|
||||||
|
- [ ] **Step 3: Implement**
|
||||||
|
|
||||||
|
In `backend/app.py`, add beside the other local imports (after the `from .schemas import ...` line):
|
||||||
|
|
||||||
|
```python
|
||||||
|
from .school_groups import (
|
||||||
|
FAITH_GROUPS,
|
||||||
|
FAITH_KEYS,
|
||||||
|
TYPE_GROUP_KEYS,
|
||||||
|
TYPE_GROUPS,
|
||||||
|
faith_groups_for,
|
||||||
|
type_group_for,
|
||||||
|
)
|
||||||
|
```
|
||||||
|
|
||||||
|
Add a helper just above `def sanitize_search_input`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
def _names_in_group(names: pd.Series, in_group) -> set:
|
||||||
|
"""The distinct names in a column that a group predicate accepts.
|
||||||
|
|
||||||
|
Evaluated once per distinct name rather than per row, so a filter over
|
||||||
|
every school costs a few dozen lookups.
|
||||||
|
"""
|
||||||
|
return {n for n in names.dropna().unique() if in_group(n)}
|
||||||
|
```
|
||||||
|
|
||||||
|
In `get_schools`, add the parameter after `has_sixth_form`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
faith: Optional[str] = Query(None, description="Filter by faith group key", max_length=40),
|
||||||
|
```
|
||||||
|
|
||||||
|
and after `phase = sanitize_search_input(phase)`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
faith = sanitize_search_input(faith)
|
||||||
|
```
|
||||||
|
|
||||||
|
After the `has_sixth_form` filter block (the one ending `df_latest = df_latest[flag if has_sixth_form == "yes" else ~flag]`), add:
|
||||||
|
|
||||||
|
```python
|
||||||
|
# Faith group (backend/school_groups.py). A joint school is in every faith
|
||||||
|
# its label names; a missing religious character is "none". An unknown key
|
||||||
|
# matches nothing rather than being ignored, so a typo cannot show all.
|
||||||
|
if faith:
|
||||||
|
faith_key = faith.lower()
|
||||||
|
if faith_key in FAITH_KEYS and "religious_denomination" in df_latest.columns:
|
||||||
|
column = df_latest["religious_denomination"]
|
||||||
|
matches = column.isin(_names_in_group(column, lambda n: faith_key in faith_groups_for(n)))
|
||||||
|
# _names_in_group skips missing names; a missing religious
|
||||||
|
# character is "No religious character".
|
||||||
|
if faith_key == "none":
|
||||||
|
matches = matches | column.isna()
|
||||||
|
df_latest = df_latest[matches]
|
||||||
|
else:
|
||||||
|
df_latest = df_latest.iloc[0:0]
|
||||||
|
```
|
||||||
|
|
||||||
|
Replace the existing `school_type` filter:
|
||||||
|
|
||||||
|
```python
|
||||||
|
if school_type:
|
||||||
|
schools_df = schools_df[
|
||||||
|
schools_df["school_type"].str.lower() == school_type.lower()
|
||||||
|
]
|
||||||
|
```
|
||||||
|
|
||||||
|
with:
|
||||||
|
|
||||||
|
```python
|
||||||
|
# A type group key (backend/school_groups.py), or for an old link a raw
|
||||||
|
# GIAS type label, matched exactly as before.
|
||||||
|
if school_type:
|
||||||
|
type_key = school_type.lower()
|
||||||
|
if type_key in TYPE_GROUP_KEYS:
|
||||||
|
column = schools_df["school_type"]
|
||||||
|
schools_df = schools_df[
|
||||||
|
column.isin(_names_in_group(column, lambda n: type_group_for(n) == type_key))
|
||||||
|
]
|
||||||
|
else:
|
||||||
|
schools_df = schools_df[schools_df["school_type"].str.lower() == type_key]
|
||||||
|
```
|
||||||
|
|
||||||
|
In `get_filter_options`, add to the early `if df.empty:` return dict:
|
||||||
|
|
||||||
|
```python
|
||||||
|
"school_type_groups": [],
|
||||||
|
"faiths": [],
|
||||||
|
```
|
||||||
|
|
||||||
|
and before the final `return {`:
|
||||||
|
|
||||||
|
```python
|
||||||
|
def offered(groups, present):
|
||||||
|
return [{"value": key, "label": label} for key, label, _ in groups if key in present]
|
||||||
|
|
||||||
|
type_groups_present = (
|
||||||
|
{type_group_for(n) for n in df["school_type"].dropna().unique()} - {None}
|
||||||
|
if "school_type" in df.columns else set()
|
||||||
|
)
|
||||||
|
faiths_present = (
|
||||||
|
{f for n in df["religious_denomination"].unique() for f in faith_groups_for(n)}
|
||||||
|
if "religious_denomination" in df.columns else set()
|
||||||
|
)
|
||||||
|
```
|
||||||
|
|
||||||
|
and add to the returned dict:
|
||||||
|
|
||||||
|
```python
|
||||||
|
"school_type_groups": offered(TYPE_GROUPS, type_groups_present),
|
||||||
|
"faiths": offered(FAITH_GROUPS, faiths_present),
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 4: Run the new tests, then the whole backend suite**
|
||||||
|
|
||||||
|
Run: `uv run --with-requirements requirements.txt --with pytest --with "httpx==0.27.0" python -m pytest backend/tests/test_type_and_faith_filters.py -q`
|
||||||
|
Expected: all pass.
|
||||||
|
|
||||||
|
Run: `uv run --with-requirements requirements.txt --with pytest --with "httpx==0.27.0" python -m pytest backend/tests pipeline/tests scripts/ci/tests -q`
|
||||||
|
Expected: all pass (the CI command; `pyyaml` comes from requirements or add `--with pyyaml` if collection fails on `import yaml`).
|
||||||
|
|
||||||
|
- [ ] **Step 5: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add backend/app.py backend/tests/test_type_and_faith_filters.py
|
||||||
|
git commit -m "feat(api): filter schools by type group and by faith"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 3: The frontend filters
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `nextjs-app/lib/types.ts` (`Filters` ~487-494, `SchoolSearchParams` ~558-570)
|
||||||
|
- Modify: `nextjs-app/app/(frontend)/page.tsx` (props type ~15-29, `hasSearchParams` ~79-88, `fetchSchools` call ~96-109)
|
||||||
|
- Modify: `nextjs-app/components/FilterBar.tsx`
|
||||||
|
- Test: `nextjs-app/__tests__/components/FilterBarTypeFaith.test.tsx` (new)
|
||||||
|
- Modify tests: `__tests__/components/ResultsToolbar.test.tsx`, `FilterSheet.test.tsx`, `FilterSheetPending.test.tsx`, `FilterBarOptions.test.tsx`
|
||||||
|
|
||||||
|
**Interfaces:**
|
||||||
|
- Consumes: `/api/filters` keys `school_type_groups`, `faiths` (Task 2); URL params `school_type` (group key) and `faith`.
|
||||||
|
- Produces: `export interface FilterOption { value: string; label: string }`; `Filters.school_type_groups?: FilterOption[]`; `Filters.faiths?: FilterOption[]`; `SchoolSearchParams.faith?: string`. FilterBar selects named "School type" and "Faith".
|
||||||
|
|
||||||
|
- [ ] **Step 1: Write the failing tests**
|
||||||
|
|
||||||
|
Create `nextjs-app/__tests__/components/FilterBarTypeFaith.test.tsx`:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
import { fireEvent, render, screen, within } from '@testing-library/react';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
import { track } from '@/lib/analytics';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* School type offers six groups a parent recognises, not GIAS's 34 types, and
|
||||||
|
* a Faith filter sits beside it (spec 2026-10-02-school-type-groups-and-faith-
|
||||||
|
* filter-design.md). Both lists come from /api/filters.
|
||||||
|
*/
|
||||||
|
|
||||||
|
let params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
const push = jest.fn();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push, replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/analytics', () => ({ track: jest.fn() }));
|
||||||
|
|
||||||
|
const filters = {
|
||||||
|
local_authorities: ['Wandsworth'], school_types: ['Community school'], years: [],
|
||||||
|
phases: ['Primary', 'Secondary'], genders: [], admissions_policies: [],
|
||||||
|
school_type_groups: [
|
||||||
|
{ value: 'academy', label: 'State school: academy or free school' },
|
||||||
|
{ value: 'council', label: 'State school: council-run' },
|
||||||
|
{ value: 'special', label: 'Special school (SEND)' },
|
||||||
|
],
|
||||||
|
faiths: [
|
||||||
|
{ value: 'none', label: 'No religious character' },
|
||||||
|
{ value: 'roman_catholic', label: 'Roman Catholic' },
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
const pushedParams = () => new URLSearchParams(push.mock.calls.at(-1)![0].split('?')[1]);
|
||||||
|
const openSheet = () => {
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /^Filters/ }));
|
||||||
|
return screen.getByRole('dialog', { name: 'Filters' });
|
||||||
|
};
|
||||||
|
const optionsOf = (scope: HTMLElement, name: string) =>
|
||||||
|
within(within(scope).getByRole('combobox', { name })).getAllByRole('option').map((o) => o.textContent);
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
push.mockClear();
|
||||||
|
jest.mocked(track).mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('School type', () => {
|
||||||
|
it('offers the groups, not the GIAS types, on desktop and in the sheet', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const groups = ['Any school type', 'State school: academy or free school',
|
||||||
|
'State school: council-run', 'Special school (SEND)'];
|
||||||
|
expect(optionsOf(screen.getByRole('group', { name: 'Filters' }), 'School type')).toEqual(groups);
|
||||||
|
expect(optionsOf(openSheet(), 'School type')).toEqual(groups);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('puts the group key in the URL and names the chip by its label', () => {
|
||||||
|
const view = render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.change(within(openSheet()).getByRole('combobox', { name: 'School type' }),
|
||||||
|
{ target: { value: 'special' } });
|
||||||
|
expect(pushedParams().get('school_type')).toBe('special');
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&school_type=special');
|
||||||
|
view.rerender(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Special school (SEND)' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('names an old raw-label link\'s chip by that label', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&school_type=Community+school');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Community school' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is left out when the API sends no groups', () => {
|
||||||
|
render(<FilterBar filters={{ ...filters, school_type_groups: undefined }} />);
|
||||||
|
expect(screen.queryByRole('combobox', { name: 'School type' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Faith', () => {
|
||||||
|
it('offers its options in the More filters panel and in the sheet', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /More filters/ }));
|
||||||
|
const faiths = ['Any faith or none', 'No religious character', 'Roman Catholic'];
|
||||||
|
expect(optionsOf(document.body, 'Faith')).toEqual(faiths);
|
||||||
|
expect(optionsOf(openSheet(), 'Faith')).toEqual(faiths);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows as a chip, counts on both buttons, and clears with Clear all', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&faith=roman_catholic');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Roman Catholic' })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: 'Filters, 1 applied' })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: /More filters \(1\)/ })).toBeInTheDocument();
|
||||||
|
fireEvent.click(within(screen.getByRole('group', { name: 'Applied filters' }))
|
||||||
|
.getByRole('button', { name: 'Clear all' }));
|
||||||
|
expect(pushedParams().get('faith')).toBeNull();
|
||||||
|
expect(pushedParams().get('postcode')).toBe('SW196AR');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('goes into the search analytics event', () => {
|
||||||
|
params = new URLSearchParams('faith=roman_catholic');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const input = screen.getByRole('searchbox', { name: 'School name or postcode' });
|
||||||
|
fireEvent.change(input, { target: { value: 'st marys' } });
|
||||||
|
fireEvent.submit(input.closest('form')!);
|
||||||
|
expect(track).toHaveBeenCalledWith('search_submitted',
|
||||||
|
expect.objectContaining({ filters_active: 'faith=roman_catholic', filters_count: 1 }));
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is left out when the API sends no faiths', () => {
|
||||||
|
render(<FilterBar filters={{ ...filters, faiths: [] }} />);
|
||||||
|
expect(within(openSheet()).queryByRole('combobox', { name: 'Faith' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Run them to see them fail**
|
||||||
|
|
||||||
|
Run (from `nextjs-app/`): `npx jest __tests__/components/FilterBarTypeFaith.test.tsx`
|
||||||
|
Expected: failures; School type still lists `Community school`, no `Faith` combobox. (`tsc` also flags `school_type_groups` on `Filters`, which Step 3 fixes.)
|
||||||
|
|
||||||
|
- [ ] **Step 3: Types and page plumbing**
|
||||||
|
|
||||||
|
In `nextjs-app/lib/types.ts`, above `export interface Filters`:
|
||||||
|
|
||||||
|
```ts
|
||||||
|
/** A filter option whose URL value differs from what a parent reads. */
|
||||||
|
export interface FilterOption {
|
||||||
|
value: string;
|
||||||
|
label: string;
|
||||||
|
}
|
||||||
|
```
|
||||||
|
|
||||||
|
and add to `Filters` (after `admissions_policies`):
|
||||||
|
|
||||||
|
```ts
|
||||||
|
/** Parent-facing school type groups; the URL's school_type takes their value. */
|
||||||
|
school_type_groups?: FilterOption[];
|
||||||
|
faiths?: FilterOption[];
|
||||||
|
```
|
||||||
|
|
||||||
|
and to `SchoolSearchParams` (after `has_sixth_form`):
|
||||||
|
|
||||||
|
```ts
|
||||||
|
faith?: string;
|
||||||
|
```
|
||||||
|
|
||||||
|
In `nextjs-app/app/(frontend)/page.tsx`: add `faith?: string;` to the `searchParams` type after `has_sixth_form?: string;`; add `params.faith ||` to `hasSearchParams` after `params.has_sixth_form`; add `faith: params.faith,` to the `fetchSchools({...})` call after `has_sixth_form: params.has_sixth_form,`.
|
||||||
|
|
||||||
|
- [ ] **Step 4: FilterBar**
|
||||||
|
|
||||||
|
In `nextjs-app/components/FilterBar.tsx`:
|
||||||
|
|
||||||
|
1. Add `"faith"` to `FILTER_KEYS` directly after `"school_type"`.
|
||||||
|
2. After `const currentHasSixthForm = ...` add:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
const currentFaith = searchParams.get("faith") || "";
|
||||||
|
```
|
||||||
|
|
||||||
|
3. Add `currentFaith,` to the `activeDropdownFilters` array (after `currentLA,`). Faith lives behind More filters, so it counts there.
|
||||||
|
4. In `handleSearchSubmit`'s `filters_active` list, after the `type=` line add:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
currentFaith && `faith=${currentFaith}`,
|
||||||
|
```
|
||||||
|
|
||||||
|
5. Add `currentFaith ||` to `hasActiveFilters` after `currentType ||`.
|
||||||
|
6. Replace `const typeOptions = filters.school_types;` with:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
// Six groups a parent recognises, not GIAS's 34 establishment types.
|
||||||
|
const typeOptions = filters.school_type_groups ?? [];
|
||||||
|
const faithOptions = filters.faiths ?? [];
|
||||||
|
```
|
||||||
|
|
||||||
|
7. Add `faith: currentFaith,` to the `values` record after `school_type: currentType,`.
|
||||||
|
8. In `labelFor`, before the `// Phase, gender and admissions values…` comment, add:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
// An old link may carry a raw GIAS type, which reads as itself.
|
||||||
|
const labelled = { school_type: typeOptions, faith: faithOptions }[
|
||||||
|
key as "school_type" | "faith"
|
||||||
|
];
|
||||||
|
if (labelled) return labelled.find((o) => o.value === value)?.label ?? value;
|
||||||
|
```
|
||||||
|
|
||||||
|
9. In `typeSelect`, replace the options map with:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
{typeOptions.map((o) => (
|
||||||
|
<option key={o.value} value={o.value}>
|
||||||
|
{o.label}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
```
|
||||||
|
|
||||||
|
10. After `laSelect`, add:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
const faithSelect = (look: Look) => (
|
||||||
|
<SelectShell wide>
|
||||||
|
<select
|
||||||
|
value={currentFaith}
|
||||||
|
onChange={(e) => handleFilterChange("faith", e.target.value)}
|
||||||
|
className={selectClass(look, currentFaith)}
|
||||||
|
aria-label="Faith"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">Any faith or none</option>
|
||||||
|
{faithOptions.map((o) => (
|
||||||
|
<option key={o.value} value={o.value}>
|
||||||
|
{o.label}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
```
|
||||||
|
|
||||||
|
11. In the desktop row, change `{typeSelect("pill")}` to `{typeOptions.length > 0 && typeSelect("pill")}`.
|
||||||
|
12. In the More filters panel, after `{laSelect("panel")}` add `{faithOptions.length > 0 && faithSelect("panel")}`.
|
||||||
|
13. In the sheet, replace `<SheetField label="School type">{typeSelect("sheet")}</SheetField>` with:
|
||||||
|
|
||||||
|
```tsx
|
||||||
|
{typeOptions.length > 0 && (
|
||||||
|
<SheetField label="School type">{typeSelect("sheet")}</SheetField>
|
||||||
|
)}
|
||||||
|
{faithOptions.length > 0 && (
|
||||||
|
<SheetField label="Faith">{faithSelect("sheet")}</SheetField>
|
||||||
|
)}
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 5: Move the existing tests' fixtures to groups**
|
||||||
|
|
||||||
|
These tests used raw types as values; give each fixture the groups and use keys:
|
||||||
|
|
||||||
|
- `ResultsToolbar.test.tsx`: add to `filters` `school_type_groups: [{ value: 'council', label: 'State school: council-run' }],`; in 'counts only what More filters hides' change `school_type=Community+school` to `school_type=council`.
|
||||||
|
- `FilterSheet.test.tsx`: add the same `school_type_groups` to `filters`; change both `school_type=Community+school` to `school_type=council`.
|
||||||
|
- `FilterSheetPending.test.tsx`: add the same `school_type_groups`; change the `{ target: { value: 'Community school' } }` to `{ target: { value: 'council' } }` and `toBe('Community school')` to `toBe('council')`.
|
||||||
|
- `FilterBarOptions.test.tsx`: add to `filters` `school_type_groups: [{ value: 'academy', label: 'State school: academy or free school' }, { value: 'council', label: 'State school: council-run' }],`; change `school_type=Community+school` (two places) to `school_type=council`; change the expected School type options to `['Any school type', 'State school: academy or free school', 'State school: council-run']`; change `toBe('Community school')` to `toBe('council')`; rename the first test to 'offer every school type group, gender and admissions policy, whatever the results hold'; and in the header comment replace "School type, gender and admissions offer the full lists" with "School type groups, gender and admissions offer the full lists".
|
||||||
|
|
||||||
|
- [ ] **Step 6: Run the frontend checks**
|
||||||
|
|
||||||
|
Run (from `nextjs-app/`): `npx jest` then `npx tsc --noEmit`
|
||||||
|
Expected: all suites pass; no type errors.
|
||||||
|
|
||||||
|
- [ ] **Step 7: Commit**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add nextjs-app/lib/types.ts "nextjs-app/app/(frontend)/page.tsx" nextjs-app/components/FilterBar.tsx nextjs-app/__tests__/components/FilterBarTypeFaith.test.tsx nextjs-app/__tests__/components/ResultsToolbar.test.tsx nextjs-app/__tests__/components/FilterSheet.test.tsx nextjs-app/__tests__/components/FilterSheetPending.test.tsx nextjs-app/__tests__/components/FilterBarOptions.test.tsx
|
||||||
|
git commit -m "feat(search): school type groups and a faith filter"
|
||||||
|
```
|
||||||
|
|
||||||
|
---
|
||||||
|
|
||||||
|
### Task 4: E2E journey, build, PR
|
||||||
|
|
||||||
|
**Files:**
|
||||||
|
- Modify: `e2e/tests/journeys.spec.ts` (insert before `test('a phase outside primary/secondary filters to that phase, not to everything'`)
|
||||||
|
|
||||||
|
**Interfaces:**
|
||||||
|
- Consumes: the "School type" and "Faith" selects (Task 3); `/api/schools?school_type=&faith=` (Task 2).
|
||||||
|
|
||||||
|
- [ ] **Step 1: Add the journey**
|
||||||
|
|
||||||
|
```ts
|
||||||
|
/*
|
||||||
|
* School type offers six groups a parent recognises, and Faith sits beside it.
|
||||||
|
* Data-invariant: asserts what every returned school is, never how many.
|
||||||
|
*/
|
||||||
|
test('school type groups and the faith filter narrow to what they name', async ({ page }) => {
|
||||||
|
await page.goto('/?search=school');
|
||||||
|
const type = page.getByRole('combobox', { name: 'School type', exact: true });
|
||||||
|
await expect(type).toBeVisible({ timeout: 15_000 });
|
||||||
|
await type.selectOption({ label: 'Special school (SEND)' });
|
||||||
|
await expect(page).toHaveURL(/[?&]school_type=special(&|$)/);
|
||||||
|
|
||||||
|
await page.getByRole('button', { name: /^More filters/ }).click();
|
||||||
|
await page.getByRole('combobox', { name: 'Faith', exact: true }).selectOption({ label: 'Roman Catholic' });
|
||||||
|
await expect(page).toHaveURL(/[?&]faith=roman_catholic(&|$)/);
|
||||||
|
|
||||||
|
const res = await page.request.get(
|
||||||
|
'/api/schools?search=school&school_type=special&faith=roman_catholic&page_size=100');
|
||||||
|
expect(res.ok()).toBeTruthy();
|
||||||
|
for (const s of (await res.json()).schools as { school_type: string; religious_denomination: string }[]) {
|
||||||
|
expect(s.school_type).toMatch(/special/i);
|
||||||
|
expect(s.religious_denomination).toMatch(/catholic/i);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
```
|
||||||
|
|
||||||
|
- [ ] **Step 2: Confirm it parses, and fails on today's staging**
|
||||||
|
|
||||||
|
Run (from `e2e/`): `npx playwright test --list | grep "school type groups"`
|
||||||
|
Expected: the test is listed.
|
||||||
|
|
||||||
|
Run: `BASE_URL=https://stx.schoolcompare.co.uk npx playwright test -g "school type groups" --retries=0 --reporter=line`
|
||||||
|
Expected: FAIL at `selectOption({ label: 'Special school (SEND)' })`, because staging still offers the raw types. It can only pass after merge (the staging E2E gate runs post-merge).
|
||||||
|
|
||||||
|
- [ ] **Step 3: Build without a database**
|
||||||
|
|
||||||
|
Run (from `nextjs-app/`): `env -u DATABASE_URL npm run build`
|
||||||
|
Expected: build completes.
|
||||||
|
|
||||||
|
- [ ] **Step 4: Commit, push, open the PR**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
git add e2e/tests/journeys.spec.ts
|
||||||
|
git commit -m "test(e2e): school type groups and the faith filter"
|
||||||
|
git push -u origin feat/school-type-groups-faith
|
||||||
|
```
|
||||||
|
|
||||||
|
Open the PR on Gitea against `main` (credential-helper basic auth, as for PRs #168/#169), listing: the six groups and seven faiths, the old-link compatibility, the backend-by-name decision, test counts, and that the new journey can only pass post-merge.
|
||||||
@@ -0,0 +1,432 @@
|
|||||||
|
# Other Schools Nearby — Design
|
||||||
|
|
||||||
|
**Date:** 2026-09-21, revised 2026-09-22
|
||||||
|
**Status:** revised after staging review
|
||||||
|
**Scope:** school detail pages, both phase templates
|
||||||
|
|
||||||
|
> **Revision, 2026-09-22.** The first build ranked by intake similarity and used
|
||||||
|
> distance as a tiebreak. On staging a Catholic primary showed six Catholic
|
||||||
|
> primaries, none of them close enough to be a real option, and omitted the
|
||||||
|
> community school down the road. Distance now decides the order and nothing
|
||||||
|
> else does; the tier system is gone. The reasoning is kept below rather than
|
||||||
|
> quietly overwritten, because the mistake is the instructive part.
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Give a school detail page an answer to the question every reader arrives with
|
||||||
|
after the results tables: *and what else is around here?*
|
||||||
|
|
||||||
|
Today a school page links outward to its place pages through
|
||||||
|
`components/school/NearbyPlaces.tsx` and nowhere else. It never links to another
|
||||||
|
school. This section adds that edge — up to six nearby schools of the same phase
|
||||||
|
and a comparable intake, three at a time in a carousel, each a crawlable link and
|
||||||
|
each addable to the comparison basket in one click.
|
||||||
|
|
||||||
|
Mockup, in both themes (drawn against the original tiered design, so its ledes
|
||||||
|
and chip fallbacks are one revision behind the copy specified below):
|
||||||
|
<https://claude.ai/artifact/168KdUMcfkUeGWW2FGjuec>
|
||||||
|
|
||||||
|
Source of the same page in the repo: `mockups/similar-schools-nearby.html`.
|
||||||
|
|
||||||
|
## The constraint that shapes everything
|
||||||
|
|
||||||
|
**A nearby school is not automatically a comparable school.**
|
||||||
|
|
||||||
|
The section's whole value is that a reader treats what it shows as a shortlist.
|
||||||
|
That makes every card an implicit claim that the school is a realistic
|
||||||
|
alternative, and there are three ways that claim goes wrong:
|
||||||
|
|
||||||
|
1. A **selective** school beside a non-selective one. Their intakes are
|
||||||
|
different by construction, so putting their Attainment 8 figures side by side
|
||||||
|
invites a conclusion the data cannot support.
|
||||||
|
2. A **special school, PRU or AP** beside a mainstream school. This is the same
|
||||||
|
error PR #70 fixed for the England benchmark, where Greenmead (URN 101099)
|
||||||
|
rendered "0% — 62 below England".
|
||||||
|
3. A **single-sex** school of the opposite sex. Not a weak match — not an option
|
||||||
|
at all.
|
||||||
|
|
||||||
|
So the design separates two kinds of fact, and never confuses them:
|
||||||
|
|
||||||
|
- **Hard filters** encode the claims above. They decide eligibility, and are
|
||||||
|
never relaxed at any distance, even if that means the section does not render.
|
||||||
|
- **Shared characteristics** — gender, religious character, selectivity —
|
||||||
|
describe how closely an intake resembles this school's. They are *reported on
|
||||||
|
the card and never ranked on*, so the reader weighs them rather than having
|
||||||
|
them weighed for them.
|
||||||
|
|
||||||
|
Everything below follows from that split. The revision at the top of this
|
||||||
|
document is what happens when the second kind is treated as the first.
|
||||||
|
|
||||||
|
## Selection algorithm
|
||||||
|
|
||||||
|
A backend helper, `_nearby_schools_payload(urn)` in `backend/app.py`, modelled
|
||||||
|
on the existing `_places_payload(urn)` and delegating to
|
||||||
|
`backend/nearby_schools.select_nearby(frame, urn)`, which operates on the cached
|
||||||
|
`load_latest_school_data()` frame — one row per URN, already carrying
|
||||||
|
`latitude`, `longitude`, `phase`, `gender`, `religious_denomination`,
|
||||||
|
`admissions_policy`, `school_type` and `status`.
|
||||||
|
|
||||||
|
### Hard filters
|
||||||
|
|
||||||
|
| Filter | Rule |
|
||||||
|
|---|---|
|
||||||
|
| Self | `urn` is excluded |
|
||||||
|
| Status | GIAS status must be open |
|
||||||
|
| Coordinates | both `latitude` and `longitude` present on both schools |
|
||||||
|
| Phase | same phase group via the existing `PHASE_GROUPS` map |
|
||||||
|
| Provision | special/PRU/AP match only each other |
|
||||||
|
| Selectivity | selective matches selective; non-selective matches non-selective |
|
||||||
|
| Gender | Boys never matches Girls; Mixed is compatible with both |
|
||||||
|
|
||||||
|
`PHASE_GROUPS` is reused rather than re-derived so an all-through school is
|
||||||
|
offered correctly on both the primary and secondary sides, exactly as it already
|
||||||
|
behaves in search.
|
||||||
|
|
||||||
|
The provision filter needs a backend counterpart to the frontend's
|
||||||
|
`isSpecialSchool()` in `nextjs-app/lib/utils.ts:897`, reading the same GIAS
|
||||||
|
establishment types through `backend/gias_codes.py`. The two must agree: a
|
||||||
|
school the frontend treats as special for benchmarking but the backend treats as
|
||||||
|
mainstream for matching would be dropped from its own England comparison and
|
||||||
|
then offered as a peer to a mainstream school on the next page along.
|
||||||
|
|
||||||
|
**Up to six cards, three visible.** Three fit the row; the rest are reached with
|
||||||
|
the carousel arrows. Two is the minimum that renders at all.
|
||||||
|
|
||||||
|
### Order: distance, and nothing else
|
||||||
|
|
||||||
|
The nearest eligible schools, closest first. Similarity does not enter the
|
||||||
|
ranking at any point.
|
||||||
|
|
||||||
|
**Why not, having built it the other way first.** The original design ranked by
|
||||||
|
tiers — same gender and faith within 3 miles, then same gender within 5, then
|
||||||
|
anything within 10 — and used distance only to order the result. Two things
|
||||||
|
followed, and both showed up on the first Catholic primary anyone looked at:
|
||||||
|
|
||||||
|
- A faith match at 2.9 miles outranked a community school at 0.3 miles. For a
|
||||||
|
primary, whose catchment is routinely under a mile, the far school is not a
|
||||||
|
weaker option; it is not an option.
|
||||||
|
- Because the row filled from the best tier before widening, three Catholic
|
||||||
|
schools within 3 miles were enough to fill all six slots with Catholic
|
||||||
|
schools. The stopping rule that produced this had been added to prevent the
|
||||||
|
*opposite* failure — padding a row with weak distant matches — and made this
|
||||||
|
one certain.
|
||||||
|
|
||||||
|
The premise was backwards. **Distance is a constraint and intake is a
|
||||||
|
preference.** A parent cannot act on a school outside their reach however well
|
||||||
|
it matches, and they are perfectly capable of noticing a shared denomination
|
||||||
|
for themselves if we show it to them. So similarity moved from the ranking to
|
||||||
|
the card: `shared` reports what a school genuinely has in common, and the reader
|
||||||
|
applies their own weighting.
|
||||||
|
|
||||||
|
The hard filters above were always where the defensibility lived. They are
|
||||||
|
untouched.
|
||||||
|
|
||||||
|
### Reach: a sanity bound, not a target
|
||||||
|
|
||||||
|
| Phase | Reach |
|
||||||
|
|---|---|
|
||||||
|
| Primary, middle deemed primary, all-through | 2 miles |
|
||||||
|
| Secondary, middle deemed secondary | 6 miles |
|
||||||
|
| 16 plus | 10 miles |
|
||||||
|
|
||||||
|
Ordering by distance already handles density — a school in inner London fills
|
||||||
|
all six slots inside a mile and never approaches the cap. The cap decides one
|
||||||
|
thing: what happens where the area is sparse. It differs by phase because
|
||||||
|
catchments do, and because people travel furthest for post-16.
|
||||||
|
|
||||||
|
**A primary with nothing inside two miles renders no section**, and that is the
|
||||||
|
intended answer rather than a gap. The alternative is a section headed "nearby"
|
||||||
|
listing a school four miles from a five-year-old.
|
||||||
|
|
||||||
|
**Past the sixth school, the rest are dropped without a count.** The section
|
||||||
|
does not try to be the list: `NearbyPlaces` sits directly beneath and already
|
||||||
|
leads to the place pages, which are built for browsing a full set and which the
|
||||||
|
school page exists to feed.
|
||||||
|
|
||||||
|
**Fewer than two results renders nothing.** Not an empty state, not a single
|
||||||
|
lonely card. The section is absent, the nav item is absent, and the page is
|
||||||
|
unchanged from before it existed.
|
||||||
|
|
||||||
|
### Distance
|
||||||
|
|
||||||
|
Straight-line, from the vectorised haversine already used for postcode search at
|
||||||
|
`backend/app.py:831`, computed over the ~27k-row frame in numpy. Reported to one
|
||||||
|
decimal place in miles, consistent with the rest of the site.
|
||||||
|
|
||||||
|
Straight-line distance is not road distance and is not measured from the
|
||||||
|
reader's home. The section says so in its disclosure rather than leaving the
|
||||||
|
reader to assume otherwise.
|
||||||
|
|
||||||
|
## API
|
||||||
|
|
||||||
|
`/api/schools/{urn}` gains a `similar_schools` array. Each row:
|
||||||
|
|
||||||
|
| Field | Notes |
|
||||||
|
|---|---|
|
||||||
|
| `urn` | for the link and the compare basket |
|
||||||
|
| `school_name` | link text |
|
||||||
|
| `distance_miles` | one decimal place |
|
||||||
|
| `school_type` | GIAS type, translated, for the card's meta line |
|
||||||
|
| `age_range` | for the meta line |
|
||||||
|
| `shared` | what this school genuinely shares with the subject; may be empty |
|
||||||
|
| `metric_value` | the phase-appropriate headline figure, or null |
|
||||||
|
| `metric_key` | `rwm_expected_pct` or `attainment_8_score` — see below |
|
||||||
|
| `metric_year` | the year the figure is from |
|
||||||
|
|
||||||
|
The metric follows the subject school's phase side, not the neighbour's own
|
||||||
|
phase, so a row of cards never mixes two scales. The secondary
|
||||||
|
side uses `attainment_8_score`; the primary side uses `rwm_expected_pct`. Where
|
||||||
|
the neighbour has no value for that key, the card reads "Not published" rather
|
||||||
|
than falling back to the other key.
|
||||||
|
|
||||||
|
Which side a school takes is decided once, in
|
||||||
|
`similar_schools.is_secondary_phase`, by membership of `PHASE_GROUPS["secondary"]`
|
||||||
|
minus all-through — never by testing for the substring "secondary", which misses
|
||||||
|
`16 plus` (GIAS phase 6) and hands a sixth-form college the primary bucket.
|
||||||
|
All-through is the exception in the other direction: `PHASE_GROUPS` lists it on
|
||||||
|
both sides, but it takes the primary metric.
|
||||||
|
|
||||||
|
This is usually the same thing as "the template the page renders", but not
|
||||||
|
always. `computeSchoolFlags` decides the template with that same substring test,
|
||||||
|
so a `16 plus` school renders `PrimarySchoolSections` while being matched —
|
||||||
|
correctly — against secondaries. The section therefore takes its lede noun from
|
||||||
|
the school's own phase rather than from its template, or it would print "Other
|
||||||
|
primary schools near <sixth form college>" above a row of secondaries.
|
||||||
|
|
||||||
|
Up to six rows of roughly 130 bytes each. It rides in the existing detail payload
|
||||||
|
rather than a new endpoint because the page already makes exactly one server
|
||||||
|
fetch for its data, and `/school/[slug]` regenerates at most weekly
|
||||||
|
(`revalidate = 604800`), so the per-request cost is paid once per school per
|
||||||
|
week.
|
||||||
|
|
||||||
|
**The key is absent, not null, on a backend that does not have this code.** The
|
||||||
|
frontend treats absent and empty identically, which is what allowed
|
||||||
|
`NearbyPlaces` to ship without a lockstep deploy of the two images.
|
||||||
|
|
||||||
|
`shared` is computed on the backend, beside the data it is derived from, not
|
||||||
|
re-derived on the frontend. Deriving it twice is how a card comes to claim
|
||||||
|
something the selection never established. An empty list is a real answer and
|
||||||
|
renders no chips: a bare card costs a school nothing but the likeness it does
|
||||||
|
not have, since the order was already settled by distance.
|
||||||
|
|
||||||
|
## Frontend
|
||||||
|
|
||||||
|
### Components
|
||||||
|
|
||||||
|
`components/school/SimilarSchoolsSection.tsx` — a server component wrapped in
|
||||||
|
the shared `Section` shell from `sectionShared.tsx`. It renders the heading,
|
||||||
|
the lede, the card grid, the footer CTA and one caption line. Every
|
||||||
|
card's title is an `<a>` to the school's canonical slug URL via `schoolUrl()`.
|
||||||
|
|
||||||
|
`components/school/AddToCompareButton.tsx` — calls `addSchool` from
|
||||||
|
`ComparisonProvider` and reports the selection with a `from: 'similar_schools'`
|
||||||
|
attribution, mirroring `addSchoolFromSearch` in `HomeView.tsx:442`.
|
||||||
|
|
||||||
|
`components/school/SimilarSchoolsCarousel.tsx` — the scroller and its arrows. It
|
||||||
|
takes the server-rendered cards as `children` and the server-rendered heading and
|
||||||
|
lede as a `header` prop, so those stay server components while the client
|
||||||
|
component owns only the ref, the scroll handler and the arrows' disabled state.
|
||||||
|
|
||||||
|
The split matters: the links — the part with SEO value and the part that must
|
||||||
|
work without JavaScript — are server-rendered into the initial HTML, and only
|
||||||
|
the basket interaction and the arrows are hydrated.
|
||||||
|
|
||||||
|
### The carousel
|
||||||
|
|
||||||
|
**Every card is in the initial HTML.** The arrows scroll a list; they never swap
|
||||||
|
a view. Six `<a>` elements are in the markup whether or not anything is
|
||||||
|
hydrated, which is the whole reason the section exists — a paginated widget that
|
||||||
|
mounts cards on click would put four of the six links beyond a crawler and
|
||||||
|
beyond a reader with no JavaScript.
|
||||||
|
|
||||||
|
So the scroller is a plain overflowing `<ul>` with `scroll-snap-type: x
|
||||||
|
mandatory`, and the arrows call `scrollBy` on it. With no JavaScript it
|
||||||
|
degrades to a horizontally scrollable row that still works by touch and by
|
||||||
|
trackpad. Three cards are visible at desktop width and two below 820px.
|
||||||
|
|
||||||
|
**Arrows appear only when there is somewhere to go** — that is, only when more
|
||||||
|
than three schools were found. Each disables itself at its own end of the
|
||||||
|
travel.
|
||||||
|
|
||||||
|
#### Below 640px the arrows go away
|
||||||
|
|
||||||
|
This follows [MOBILE.md](../../../MOBILE.md), which makes 360px the design
|
||||||
|
floor and mobile the primary target at ≥55% of traffic.
|
||||||
|
|
||||||
|
Kept in the heading's flex row at 360px, the two arrow buttons take 96px from a
|
||||||
|
328px card and crush the lede into a four-line column — measured, not guessed.
|
||||||
|
And swiping already does what they do. So below 640px the header becomes a
|
||||||
|
single column, the arrows are not rendered, one card shows at 86% width so the
|
||||||
|
next one peeks, and the affordance is carried by the right-edge scroll-fade that
|
||||||
|
MOBILE.md documents for exactly this case:
|
||||||
|
|
||||||
|
```css
|
||||||
|
mask-image: linear-gradient(to right, #000 calc(100% - 28px), transparent);
|
||||||
|
```
|
||||||
|
|
||||||
|
The fade lifts at the end of the travel, where there is nothing left to hint
|
||||||
|
at. That means the at-end state must be computed whether or not an arrow exists
|
||||||
|
to consume it — on mobile it drives the mask alone.
|
||||||
|
|
||||||
|
**Every interactive element clears 44×44px**, per MOBILE.md's iOS HIG check: the
|
||||||
|
arrow buttons and the add-to-compare button are both 44px, up from the 40px they
|
||||||
|
were first drawn at. A card title's own box is shorter than that, but its hit
|
||||||
|
area is the whole card through the `::after` overlay, so it passes on the target
|
||||||
|
that actually receives the tap.
|
||||||
|
|
||||||
|
**The edge test needs a tolerance, and this is not fussiness.** The scroller
|
||||||
|
carries 2px of padding so focus rings are not clipped, and scroll-snap treats
|
||||||
|
that padding as the first card's snap position: a scroller sitting at its start
|
||||||
|
reports `scrollLeft` of 2, not 0. Sub-pixel rounding moves it again at other
|
||||||
|
zoom levels. Testing `scrollLeft === 0` therefore leaves the back arrow live and
|
||||||
|
pointing nowhere on first paint — confirmed in the mockup before it was fixed.
|
||||||
|
Both ends compare against an 8px tolerance.
|
||||||
|
|
||||||
|
**Selecting a school must not move the row.** Adding to the basket re-renders
|
||||||
|
the footer; the scroll offset lives in the DOM rather than in React state, so
|
||||||
|
the carousel must not remount or reset on that render. A reader who ticks the
|
||||||
|
fifth school and is thrown back to the first has been punished for using the
|
||||||
|
feature.
|
||||||
|
|
||||||
|
### Placement and navigation
|
||||||
|
|
||||||
|
Rendered as the last section **inside** `SchoolDetailShell`, from both
|
||||||
|
`PrimarySchoolSections` and `SecondarySchoolSections`. Inside, not after, because
|
||||||
|
the sticky nav's scroll-spy locates sections with `document.getElementById` and
|
||||||
|
can only reach a section that lives in the shell.
|
||||||
|
|
||||||
|
`NearbyPlaces` stays where it is, outside the shell, immediately below. The
|
||||||
|
resulting order — this school, then similar schools, then the places containing
|
||||||
|
them — narrows before it widens, which is the order a reader leaves a page in.
|
||||||
|
|
||||||
|
`buildNavItems` and `buildSecondaryNavItems` both gain
|
||||||
|
`{ id: 'similar', label: 'Similar schools' }`, gated on the section rendering.
|
||||||
|
The id must match the `Section` id or the scroll-spy silently breaks.
|
||||||
|
|
||||||
|
### The comparison CTA
|
||||||
|
|
||||||
|
A plain `<a href="/compare?urns=…">`, built from this school's URN plus the
|
||||||
|
selected ones. `/compare` already parses `urns` from the query string
|
||||||
|
(`app/(frontend)/compare/page.tsx:55`), so this needs no new compare plumbing.
|
||||||
|
With nothing selected the CTA is disabled; the button also adds to the shared
|
||||||
|
basket so the site-wide comparison state stays consistent with what the page
|
||||||
|
shows.
|
||||||
|
|
||||||
|
## Copy, and what the section is allowed to claim
|
||||||
|
|
||||||
|
**The lede never claims an intake.** It reads "Other primary schools near X." —
|
||||||
|
one sentence, no variants. The earlier version varied the wording by tier, which
|
||||||
|
only existed to soften a claim the section should not have been making.
|
||||||
|
|
||||||
|
**The heading is "Other schools nearby", not "Similar schools nearby".** The
|
||||||
|
hard filters do guarantee a comparable set — same phase, same selectivity,
|
||||||
|
mainstream never beside special — but nothing ranks on likeness, so the heading
|
||||||
|
does not say it does. The nav item reads "Nearby schools" and the section id is
|
||||||
|
`nearby`.
|
||||||
|
|
||||||
|
**Chips state only what is shared, and may be absent entirely.** A card with
|
||||||
|
nothing in common renders no chip row rather than falling back to a filler.
|
||||||
|
Since chips no longer affect the order, an empty one costs that school nothing
|
||||||
|
except a claim it cannot support — and a Catholic parent scanning the row still
|
||||||
|
spots "Roman Catholic" on the card that carries it, and weighs it themselves.
|
||||||
|
|
||||||
|
**The neighbour's metric carries no valence colour.** Green and terracotta are
|
||||||
|
reserved site-wide for comparison against the England average. Colouring a
|
||||||
|
neighbour's figure against this school's would read as ranking the neighbours
|
||||||
|
against each other, which is precisely the endorsement this section must not
|
||||||
|
make. The figure sits in neutral ink above a plain "72% at this school"
|
||||||
|
reference line, and the reader draws their own conclusion.
|
||||||
|
|
||||||
|
**A missing figure reads "Not published".** Never 0, never blank, never an
|
||||||
|
em dash. This follows the same rule the rest of the detail page uses: a school
|
||||||
|
with no published result has not scored zero.
|
||||||
|
|
||||||
|
**There is no "how these are chosen" disclosure.** The method is visible in what
|
||||||
|
the section already shows — the phase in the lede, the shared characteristics on
|
||||||
|
each card, the distance above each name — and a collapsed panel restating it
|
||||||
|
earns less than the space it costs.
|
||||||
|
|
||||||
|
**One caption line survives, and only one:** that distances are straight-line
|
||||||
|
from the school and not road distance. This is not a method note. A reader who
|
||||||
|
sees "0.6 miles away" and takes it for the walk has been misled by us, and no
|
||||||
|
other element on the card corrects that. The remaining notes — that listing is
|
||||||
|
not a recommendation, that special schools only meet special schools — are
|
||||||
|
statements the selection rules already keep true without being narrated.
|
||||||
|
|
||||||
|
## Degradation
|
||||||
|
|
||||||
|
| Condition | Behaviour |
|
||||||
|
|---|---|
|
||||||
|
| `similar_schools` absent (older backend image) | no section, no nav item |
|
||||||
|
| fewer than 2 qualifying schools | no section, no nav item |
|
||||||
|
| this school has no coordinates | no section |
|
||||||
|
| the helper raises | returns `[]`; the page renders without the section |
|
||||||
|
|
||||||
|
The helper is wrapped so a failure inside it never 500s a page that is otherwise
|
||||||
|
complete — the posture `get_supplementary_data` already takes for its own
|
||||||
|
queries.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
**Backend**, in a new `backend/tests/test_similar_schools.py`, against a
|
||||||
|
synthetic frame rather than live marts:
|
||||||
|
|
||||||
|
- a selective school never returns a non-selective one, and vice versa
|
||||||
|
- a special school returns only special schools; a mainstream school returns none
|
||||||
|
- a Boys school never returns a Girls school; Mixed matches both
|
||||||
|
- closed schools and schools without coordinates are never returned
|
||||||
|
- results are ordered by distance ascending, always
|
||||||
|
- a faith match never outranks a closer school (the staging defect, pinned)
|
||||||
|
- the nearest eligible school is always present
|
||||||
|
- more than six qualifying schools returns the six nearest
|
||||||
|
- reach is capped per phase, and a primary beyond two miles returns `[]`
|
||||||
|
- an all-through school is offered on both phase sides
|
||||||
|
- a `16 plus` school is matched against secondaries and colleges, never primaries
|
||||||
|
- `is_secondary_phase` and `PHASE_GROUPS` agree on every GIAS phase value
|
||||||
|
- fewer than two qualifying schools returns `[]`
|
||||||
|
- distances match a hand-computed haversine for a known pair
|
||||||
|
|
||||||
|
**Frontend**, in `nextjs-app/__tests__`:
|
||||||
|
|
||||||
|
- the section renders nothing for absent, empty and single-row inputs
|
||||||
|
- the lede never claims a similar intake
|
||||||
|
- an empty `shared` renders no chips rather than a filler
|
||||||
|
- a null metric renders "Not published"
|
||||||
|
- the nav item appears only alongside the section
|
||||||
|
- every card is in the DOM, including the ones scrolled out of view
|
||||||
|
- arrows render only when more than three schools were found
|
||||||
|
|
||||||
|
jsdom has no layout, so `scrollWidth` and `clientWidth` are both 0 there and the
|
||||||
|
arrows' disabled state cannot be meaningfully asserted in Jest. That behaviour is
|
||||||
|
covered in the journey instead, against a real engine, rather than by a unit test
|
||||||
|
that would pass on a measurement that does not exist.
|
||||||
|
|
||||||
|
**E2E**, added to the existing journeys in `e2e/tests` in the same PR, per the
|
||||||
|
repository's rule on user-facing behaviour:
|
||||||
|
|
||||||
|
- the section renders on a known staging URN, with resolving links
|
||||||
|
- where arrows are present, the back arrow starts disabled and the forward arrow
|
||||||
|
moves the row
|
||||||
|
- selecting a school does not reset the scroll position
|
||||||
|
- add-to-compare reaches `/compare` with the expected `urns`
|
||||||
|
- at 360, 390 and 430px: no horizontal overflow, every interactive element in the
|
||||||
|
section clears 44×44px, and no arrows are rendered
|
||||||
|
|
||||||
|
The E2E gate runs after merge on this project, so these journeys are not
|
||||||
|
provable in the PR checks; the PR is verified on the unit tests, and the
|
||||||
|
journeys are confirmed on the post-merge staging run.
|
||||||
|
|
||||||
|
## Out of scope
|
||||||
|
|
||||||
|
- A map of the nearby schools. The section is a list; the page already has a map.
|
||||||
|
- Autoplay, dots, or an infinite loop on the carousel. It is a short list a
|
||||||
|
reader scans deliberately, not a banner competing for attention, and a row
|
||||||
|
that moves on its own is a row that moves while someone is reading it.
|
||||||
|
- Statistical neighbours on deprivation, size or cohort profile. If plain
|
||||||
|
distance proves too blunt, that is the trigger to move this computation into a
|
||||||
|
dbt mart — `select_nearby` is a deliberate seam for exactly that swap.
|
||||||
|
- Precomputing neighbours in `marts.*`. Rejected for now: a new mart is inert
|
||||||
|
until Airflow runs, so the feature would ship dark, and every tuning change to
|
||||||
|
the rules would become a pipeline round-trip instead of a deploy. The revision
|
||||||
|
at the top of this document is the argument for keeping that loop short.
|
||||||
|
- Any change to `/api/compare`, the compare page, or the comparison basket.
|
||||||
@@ -0,0 +1,233 @@
|
|||||||
|
# School Type Groups and a Faith Filter — Design
|
||||||
|
|
||||||
|
**Date:** 2026-10-02
|
||||||
|
**Status:** shipped in PR #170; revised 2026-10-02 (one state group)
|
||||||
|
**Scope:** search filters (`/` results toolbar and phone filter sheet), `/api/schools`, `/api/filters`
|
||||||
|
|
||||||
|
## Goal
|
||||||
|
|
||||||
|
Replace the School type filter's 34 GIAS establishment types with five groups a
|
||||||
|
parent recognises, and add a Faith filter.
|
||||||
|
|
||||||
|
> **Revision, 2026-10-02.** PR #170 shipped six groups, with state schools
|
||||||
|
> split into "academy or free school" and "council-run". They are now one,
|
||||||
|
> "State school (free)". The split was two near-halves of the same pool, so it
|
||||||
|
> rarely narrowed anything, and it did not follow the difference a parent feels
|
||||||
|
> most, admissions: voluntary aided and foundation schools set their own
|
||||||
|
> admissions, as academies do, while community and voluntary controlled
|
||||||
|
> schools have theirs set by the council. Faith, which voluntary aided mostly
|
||||||
|
> meant, has its own filter. The old keys `academy` and `council` resolve to
|
||||||
|
> `state`, so their links keep working.
|
||||||
|
|
||||||
|
Since PR #169 the School type select offers the full GIAS list rather than the
|
||||||
|
types in the results. That fixed the trap where choosing a type left only that
|
||||||
|
type on offer, but it exposed the list itself: "Academy converter", "Academy
|
||||||
|
sponsor led", "Free schools", "Foundation school", "Voluntary controlled
|
||||||
|
school" and 29 more. These describe governance and funding. For a mainstream
|
||||||
|
state school they change almost nothing a parent experiences, and parents
|
||||||
|
cannot be expected to know the differences.
|
||||||
|
|
||||||
|
What parents actually ask is: is it free, is it mainstream, is it for children
|
||||||
|
with special needs, is it a sixth form or college, and is it a faith school.
|
||||||
|
The first four are the type groups below. The fifth is the real meaning behind
|
||||||
|
"Voluntary aided" and "Voluntary controlled", but many academies are faith
|
||||||
|
schools too, so it gets its own filter rather than hiding inside type.
|
||||||
|
|
||||||
|
## Non-goals
|
||||||
|
|
||||||
|
- Changing what a school page or result row shows. They keep the precise GIAS
|
||||||
|
type ("Academy sponsor led"), where it is information, not a choice.
|
||||||
|
- Removing the "not offered" types from search results. They stay reachable
|
||||||
|
under "Any school type"; whether parents should see them at all is a
|
||||||
|
separate decision.
|
||||||
|
- Reordering the type options by phase (for example "Sixth form or college"
|
||||||
|
first for 16 plus). Fixed order is simpler.
|
||||||
|
- The rankings page, which has no type filter.
|
||||||
|
- Changing `result_filters`. Its `school_types` key is already unread
|
||||||
|
(docs/LEGACY_CODE.md).
|
||||||
|
|
||||||
|
## Type groups
|
||||||
|
|
||||||
|
Order is the order shown. Codes are GIAS `TypeOfEstablishment` codes
|
||||||
|
(`backend/gias_codes.py: SCHOOL_TYPE`). Counts are staging schools on
|
||||||
|
2026-10-02.
|
||||||
|
|
||||||
|
| Key | Label | GIAS codes | Schools |
|
||||||
|
|---|---|---|---|
|
||||||
|
| `state` | State school (free) | 28 Academy sponsor led, 34 Academy converter, 35 Free schools, 40 University technical college, 41 Studio schools, 6 City technology college, 1 Community school, 2 Voluntary aided school, 3 Voluntary controlled school, 5 Foundation school, 15 Local authority nursery school | 20,502 |
|
||||||
|
| `independent` | Independent (fee-paying) | 11 Other independent school | 1,585 |
|
||||||
|
| `special` | Special school (SEND) | 7 Community special, 12 Foundation special, 44 Academy special converter, 33 Academy special sponsor led, 36 Free schools special, 8 Non-maintained special, 10 Other independent special, 32 Special post 16 institution | 2,227 |
|
||||||
|
| `post16` | Sixth form or college | 18 Further education, 31 Sixth form centres, 45 Academy 16-19 converter, 46 Academy 16 to 19 sponsor led, 39 Free schools 16 to 19 | 302 |
|
||||||
|
| `alternative` | Alternative provision | 14 Pupil referral unit, 42 Academy AP converter, 43 Academy AP sponsor led, 38 Free schools AP | 331 |
|
||||||
|
|
||||||
|
**Not offered** (no group, reachable only under "Any school type"): 29 Higher
|
||||||
|
education institutions, 27 Miscellaneous, 24 Secure units, 49 Online provider,
|
||||||
|
57 Academy secure 16 to 19, 56 Institution funded by other government
|
||||||
|
department. 238 schools.
|
||||||
|
|
||||||
|
**Excluded upstream** (never in the marts): 25, 26, 30, 37, per
|
||||||
|
`non_england_school_type_codes` in `pipeline/transform/dbt_project.yml`.
|
||||||
|
|
||||||
|
### Judgement calls
|
||||||
|
|
||||||
|
- **Independent special schools are Special, not Independent.** They are
|
||||||
|
usually funded by the local authority through a child's EHCP; to a parent
|
||||||
|
they are SEND provision, not private school.
|
||||||
|
- **UTCs, studio schools and city technology colleges are state schools.** They
|
||||||
|
are legally academies, they are few (66 together), and a family considering
|
||||||
|
one searches for it by name.
|
||||||
|
- **Academies and council-run schools are one group.** See the revision note
|
||||||
|
under Goal.
|
||||||
|
- **Special post 16 institutions are Special, not Sixth form or college.** The
|
||||||
|
defining fact for a parent is the SEND provision.
|
||||||
|
- **Alternative provision is last.** Parents do not apply to it; the local
|
||||||
|
authority places children there.
|
||||||
|
|
||||||
|
## Faith groups
|
||||||
|
|
||||||
|
Codes are GIAS `ReligiousCharacter` codes
|
||||||
|
(`backend/gias_codes.py: RELIGIOUS_CHARACTER`). A joint school belongs to every
|
||||||
|
faith its label names, so "Roman Catholic/Church of England" matches both
|
||||||
|
Church of England and Roman Catholic. A generic "Christian" alongside a named
|
||||||
|
denomination adds nothing ("Church of England/Christian" is Church of England
|
||||||
|
only).
|
||||||
|
|
||||||
|
| Key | Label | GIAS codes |
|
||||||
|
|---|---|---|
|
||||||
|
| `none` | No religious character | 0 Does not apply, 6 None, 99 (blank), and a missing code |
|
||||||
|
| `church_of_england` | Church of England | 2, 31 Anglican, 34 Anglican/Church of England, 20 CofE/Christian, 32 Anglican/Christian, and the joint codes 9, 10, 11, 12, 13, 19, 30, 33, 41, 48 |
|
||||||
|
| `roman_catholic` | Roman Catholic | 3, 35 Catholic, and the joint codes 11, 13, 48 |
|
||||||
|
| `other_christian` | Other Christian | 4 Methodist, 8 Seventh Day Adventist, 14 Quaker, 15 Christian, 16 United Reformed Church, 17 Congregational Church, 18 Free Church, 22 Greek Orthodox, 26 Moravian, 28 Inter- / non- denominational, 37 Christian/Evangelical, 38 Christian Science, 39 Christian/Methodist, 40 Christian/non-denominational, 44 Plymouth Brethren Christian Church, 45 Protestant, 46 Protestant/Evangelical, 47 Reformed Baptist, and the joint codes 9, 10, 12, 19, 30, 33, 41 |
|
||||||
|
| `jewish` | Jewish | 5 Jewish, 36 Charadi Jewish, 43 Orthodox Jewish |
|
||||||
|
| `muslim` | Muslim | 7 Muslim, 42 Islam, 49 Sunni Deobandi |
|
||||||
|
| `other_faith` | Other faith | 21 Sikh, 24 Buddhist, 25 Hindu, 29 Multi-faith |
|
||||||
|
|
||||||
|
The joint codes: 9 CofE/Methodist, 10 Methodist/CofE, 11 CofE/RC, 12 CofE/URC,
|
||||||
|
13 RC/CofE, 19 CofE/Free Church, 30 CofE/Methodist/URC/Baptist,
|
||||||
|
33 Anglican/Evangelical, 41 CofE/Evangelical, 48 RC/Anglican.
|
||||||
|
|
||||||
|
28 "Inter- / non- denominational" is filed as Other Christian: GIAS uses it for
|
||||||
|
Christian schools that are not tied to one church.
|
||||||
|
|
||||||
|
## Architecture
|
||||||
|
|
||||||
|
Grouping lives in the backend, not dbt. The API already translates GIAS codes
|
||||||
|
to names when it loads the marts (`backend/data_loader.py:
|
||||||
|
translate_gias_code_columns`), and every filter is applied to that DataFrame.
|
||||||
|
Grouping there needs no mart change, so there is no Airflow run between merge
|
||||||
|
and staging showing it.
|
||||||
|
|
||||||
|
### `backend/school_groups.py` (new)
|
||||||
|
|
||||||
|
- `TYPE_GROUPS`: ordered `(key, label, frozenset[int])` per type group.
|
||||||
|
- `UNOFFERED_TYPE_CODES`: the not-offered codes, so that "every code is
|
||||||
|
accounted for" is testable.
|
||||||
|
- `FAITH_GROUPS`: ordered `(key, label, frozenset[int])` per faith group.
|
||||||
|
- `type_group_for(name) -> str | None` and
|
||||||
|
`faith_groups_for(name) -> tuple[str, ...]` (a missing or blank name gives
|
||||||
|
`("none",)`).
|
||||||
|
|
||||||
|
No dependence on the generated GIAS dictionaries beyond their codes, so the
|
||||||
|
backend/pipeline dictionary parity test is untouched.
|
||||||
|
|
||||||
|
### Grouping by name, at filter time
|
||||||
|
|
||||||
|
The groups are defined over codes but looked up by the translated name
|
||||||
|
(`type_group_for(name)`, `faith_groups_for(name)`), when `/api/schools` and
|
||||||
|
`/api/filters` filter. The DataFrame those endpoints read carries names only:
|
||||||
|
`translate_gias_code_columns` replaces the codes at load, the legacy-name
|
||||||
|
mart fallback never had codes, and the API test fixtures are written in
|
||||||
|
names. The names come from the same dictionaries, so the lookup is exact.
|
||||||
|
`data_loader.py` is unchanged.
|
||||||
|
|
||||||
|
### `/api/schools`
|
||||||
|
|
||||||
|
Both filters work on the name columns at request time. `_names_in_group`
|
||||||
|
collects the distinct `school_type` or `religious_denomination` names the
|
||||||
|
group accepts, once per distinct name rather than per row, and the rows are
|
||||||
|
kept with `isin`. No group column is stored.
|
||||||
|
|
||||||
|
- `school_type`: if the value is a type group key (any case), keep the rows
|
||||||
|
whose `school_type` name `type_group_for` puts in that group. Otherwise
|
||||||
|
filter on the raw label exactly as today, so an old
|
||||||
|
`?school_type=Community+school` link keeps working.
|
||||||
|
- `faith` (new, optional, `max_length=40`, sanitised like the others): keep the
|
||||||
|
rows whose `religious_denomination` name `faith_groups_for` puts in that
|
||||||
|
faith (any case); for `none`, rows with a missing name too. An unknown key
|
||||||
|
returns no schools rather than being ignored, so a typo does not silently
|
||||||
|
show everything.
|
||||||
|
|
||||||
|
### `/api/filters`
|
||||||
|
|
||||||
|
Two new keys:
|
||||||
|
|
||||||
|
- `school_type_groups`: `[{value, label}]` in `TYPE_GROUPS` order, only groups
|
||||||
|
with at least one school.
|
||||||
|
- `faiths`: `[{value, label}]` in `FAITH_GROUPS` order, same rule.
|
||||||
|
|
||||||
|
`school_types` stays as it is (the raw list), so nothing that reads it breaks.
|
||||||
|
|
||||||
|
### Frontend
|
||||||
|
|
||||||
|
- `lib/types.ts`: `Filters` gains optional `school_type_groups` and `faiths`
|
||||||
|
(`{ value: string; label: string }[]`). Optional, so the empty fallbacks in
|
||||||
|
`app/(frontend)/page.tsx` and `rankings/page.tsx` stay valid.
|
||||||
|
- `app/(frontend)/page.tsx`: reads `faith` from the search params, counts it
|
||||||
|
in `hasSearchParams`, and passes it to `fetchSchools`. `SchoolSearchParams`
|
||||||
|
in `lib/types.ts` gains `faith`. HomeView's load-more already forwards every
|
||||||
|
URL param. HomeView's `isSearchActive` is left as it is: like phase and
|
||||||
|
gender, faith narrows a search rather than starting one.
|
||||||
|
- `components/FilterBar.tsx`:
|
||||||
|
- The School type select's options become `filters.school_type_groups`;
|
||||||
|
"Any school type" stays first. With no groups (the API failed), the select
|
||||||
|
is left out, as Gender and Admissions already are.
|
||||||
|
- A new **Faith** select (`aria-label="Faith"`, "Any faith or none" first)
|
||||||
|
from `filters.faiths`. On desktop it goes in the More filters panel, after
|
||||||
|
Local authority. In the phone sheet it comes after School type.
|
||||||
|
- `faith` joins `FILTER_KEYS` (chip and Filters count) and the More filters
|
||||||
|
count, and `faith=` joins `filters_active` in the `search_submitted`
|
||||||
|
analytics event.
|
||||||
|
- Chip labels come from the option lists: "Special school (SEND)",
|
||||||
|
"Roman Catholic". An old raw-label `school_type` shows its raw label.
|
||||||
|
- `lib/utils.ts: isSpecialSchool` is unchanged. It reads a school's raw
|
||||||
|
`school_type`, which still arrives.
|
||||||
|
|
||||||
|
## Testing
|
||||||
|
|
||||||
|
**Backend (pytest):**
|
||||||
|
|
||||||
|
- Every `SCHOOL_TYPE` code is in exactly one type group, in
|
||||||
|
`UNOFFERED_TYPE_CODES`, or in `non_england_school_type_codes`. A new DfE
|
||||||
|
code fails this test instead of silently vanishing from the filter.
|
||||||
|
- Every `RELIGIOUS_CHARACTER` code maps to at least one faith group.
|
||||||
|
- The joint codes map to each faith they name (11 and 48 → CofE and RC;
|
||||||
|
9 → CofE and Other Christian) and 20 → CofE only.
|
||||||
|
- `/api/schools?school_type=special` returns only special-group schools;
|
||||||
|
`?school_type=Community+school` still filters by label.
|
||||||
|
- `/api/schools?faith=roman_catholic` returns only matching schools, a joint
|
||||||
|
school included; `?faith=nonsense` returns none.
|
||||||
|
- `/api/filters` lists the groups in order and leaves out an empty one.
|
||||||
|
- Run via uv, as the backend tests always are.
|
||||||
|
|
||||||
|
**Frontend (Jest):**
|
||||||
|
|
||||||
|
- School type offers the six group labels, not raw types.
|
||||||
|
- Faith offers its options, in the panel and in the sheet.
|
||||||
|
- A faith filter shows as a chip, counts on Filters and More filters, and
|
||||||
|
clears with Clear all.
|
||||||
|
- No groups or faiths in `filters` → the select is left out.
|
||||||
|
|
||||||
|
**E2E (`e2e/tests/journeys.spec.ts`):**
|
||||||
|
|
||||||
|
- A journey that picks "Special school (SEND)" and "Roman Catholic" from the
|
||||||
|
selects, then checks through `/api/schools` with the same params that every
|
||||||
|
returned school's `school_type` is a special type and its
|
||||||
|
`religious_denomination` names Catholic. Data-invariant: it asserts the
|
||||||
|
property, not a count.
|
||||||
|
- It can only pass after merge; the staging E2E gate runs post-merge.
|
||||||
|
|
||||||
|
## Rollout
|
||||||
|
|
||||||
|
One PR; backend and frontend deploy together on merge. The frontend tolerates
|
||||||
|
an API without the new keys (the selects are left out), so the order the
|
||||||
|
containers update in does not matter.
|
||||||
+673
-9
@@ -1,4 +1,4 @@
|
|||||||
import { test, expect, Page } from '@playwright/test';
|
import { test, expect, Locator, Page } from '@playwright/test';
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Journey tests for SchoolCompare, run against the staging environment as the
|
* Journey tests for SchoolCompare, run against the staging environment as the
|
||||||
@@ -19,6 +19,31 @@ function schoolLinks(page: Page) {
|
|||||||
return page.locator('a[href^="/school/"]');
|
return page.locator('a[href^="/school/"]');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A scroll offset that has stopped moving.
|
||||||
|
*
|
||||||
|
* The carousel arrows scroll with `behavior: 'smooth'`, so a reading taken
|
||||||
|
* straight after a click lands mid-animation. Measured against staging: the
|
||||||
|
* animation runs ~700ms, and a poll for "has it moved at all" is satisfied
|
||||||
|
* 50ms in, at 13px of a 1300px journey. A test that then records an offset,
|
||||||
|
* does something, and records again is measuring the tail of the arrow's
|
||||||
|
* animation rather than the effect of whatever it did in between.
|
||||||
|
*
|
||||||
|
* Two identical readings in a row is the cheapest sound definition of settled.
|
||||||
|
*/
|
||||||
|
async function settledScrollLeft(scroller: Locator): Promise<number> {
|
||||||
|
let previous = -1;
|
||||||
|
await expect
|
||||||
|
.poll(async () => {
|
||||||
|
const current = await scroller.evaluate((node: HTMLElement) => Math.round(node.scrollLeft));
|
||||||
|
const settled = current === previous;
|
||||||
|
previous = current;
|
||||||
|
return settled;
|
||||||
|
}, { timeout: 10_000 })
|
||||||
|
.toBe(true);
|
||||||
|
return previous;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Two URNs guaranteed to be pure-primary (same phase). The compare page's
|
* Two URNs guaranteed to be pure-primary (same phase). The compare page's
|
||||||
* phase tabs split all-through schools (which carry KS4 data) onto the
|
* phase tabs split all-through schools (which carry KS4 data) onto the
|
||||||
@@ -97,9 +122,9 @@ test('the coverage figure is live, not the hardcoded fallback', async ({ page })
|
|||||||
test('the landing page states the real comparison limit', async ({ page }) => {
|
test('the landing page states the real comparison limit', async ({ page }) => {
|
||||||
await page.goto('/');
|
await page.goto('/');
|
||||||
const body = await page.locator('body').innerText();
|
const body = await page.locator('body').innerText();
|
||||||
// MAX_SCHOOLS in context/ComparisonProvider.tsx is 5. The hero used to
|
// MAX_PER_GROUP in lib/compareLogic.ts is 5 per phase. The hero once
|
||||||
// promise three while a card lower on the same page promised five.
|
// promised three while a card lower on the same page promised five.
|
||||||
expect(body).toMatch(/five schools/i);
|
expect(body).toMatch(/five primary and five secondary schools/i);
|
||||||
expect(body).not.toMatch(/three schools/i);
|
expect(body).not.toMatch(/three schools/i);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -245,6 +270,103 @@ test('searching by name returns school results', async ({ page }) => {
|
|||||||
test('searching by postcode returns nearby schools', async ({ page }) => {
|
test('searching by postcode returns nearby schools', async ({ page }) => {
|
||||||
await searchByName(page, 'B1 1BB');
|
await searchByName(page, 'B1 1BB');
|
||||||
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
||||||
|
// A new postcode search starts at half a mile.
|
||||||
|
await expect(page).toHaveURL(/[?&]radius=0\.5(&|$)/);
|
||||||
|
await expect(page.getByRole('combobox', { name: 'Distance' })).toHaveValue('0.5');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the phase filter switches straight from secondary to primary', async ({ page }) => {
|
||||||
|
// The phase options once came from the result set, which the phase filter
|
||||||
|
// had already narrowed — so with secondary chosen, primary was not offered.
|
||||||
|
await page.goto('/?search=school&phase=secondary');
|
||||||
|
const phase = page.getByRole('combobox', { name: 'Phase' });
|
||||||
|
await expect(phase).toHaveValue('secondary', { timeout: 15_000 });
|
||||||
|
await phase.selectOption('primary');
|
||||||
|
await expect(page).toHaveURL(/[?&]phase=primary(&|$)/);
|
||||||
|
await expect(phase).toHaveValue('primary');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the phase filter lists phases in the order a child meets them', async ({ page }) => {
|
||||||
|
// They were alphabetical, so "16 plus" and "All-through" came before Nursery.
|
||||||
|
const childPath = ['Nursery', 'Primary', 'Middle deemed primary',
|
||||||
|
'Middle deemed secondary', 'Secondary', '16 plus', 'All-through'];
|
||||||
|
await page.goto('/?search=school');
|
||||||
|
const phase = page.getByRole('combobox', { name: 'Phase' });
|
||||||
|
await expect(phase).toBeVisible({ timeout: 15_000 });
|
||||||
|
const offered = (await phase.locator('option').allTextContents())
|
||||||
|
.filter((o) => childPath.includes(o));
|
||||||
|
expect(offered, 'no phase on offer').toContain('Primary');
|
||||||
|
expect(offered).toEqual(childPath.filter((p) => offered.includes(p)));
|
||||||
|
});
|
||||||
|
|
||||||
|
test('school type and gender switch straight to another value', async ({ page }) => {
|
||||||
|
// Their options came from the result set, which the filter had already
|
||||||
|
// narrowed, so with one value chosen it was the only one on offer.
|
||||||
|
await page.goto('/?search=school&gender=girls');
|
||||||
|
// An applied gender filter opens More filters by itself.
|
||||||
|
const gender = page.getByRole('combobox', { name: 'Gender', exact: true });
|
||||||
|
await expect(gender).toHaveValue('girls', { timeout: 15_000 });
|
||||||
|
await gender.selectOption('boys');
|
||||||
|
await expect(page).toHaveURL(/[?&]gender=boys(&|$)/);
|
||||||
|
|
||||||
|
// Whatever types the data holds, choosing one leaves the same list on offer.
|
||||||
|
const type = page.getByRole('combobox', { name: 'School type', exact: true });
|
||||||
|
const offered = await type.locator('option').allTextContents();
|
||||||
|
expect(offered.length, 'no school type to choose').toBeGreaterThan(1);
|
||||||
|
await type.selectOption(offered[1]);
|
||||||
|
await expect(page).toHaveURL(/[?&]school_type=/);
|
||||||
|
await expect.poll(() => type.locator('option').allTextContents()).toEqual(offered);
|
||||||
|
});
|
||||||
|
|
||||||
|
/*
|
||||||
|
* School type offers six groups a parent recognises, and Faith sits beside it.
|
||||||
|
* Data-invariant: asserts what every returned school is, never how many.
|
||||||
|
*/
|
||||||
|
// Clear all once dropped the search with the filters, which sent desktop back
|
||||||
|
// to the home page instead of to the unfiltered results.
|
||||||
|
test('Clear all removes the filters and keeps the search', async ({ page }) => {
|
||||||
|
await page.goto('/?search=school&phase=primary');
|
||||||
|
const row = page.getByRole('group', { name: 'Filters', exact: true });
|
||||||
|
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
||||||
|
await row.getByRole('button', { name: 'Clear all', exact: true }).click();
|
||||||
|
await expect(page).not.toHaveURL(/[?&]phase=/);
|
||||||
|
await expect(page).toHaveURL(/[?&]search=school(&|$)/);
|
||||||
|
await expect(schoolLinks(page).first()).toBeVisible();
|
||||||
|
await expect(row.getByRole('button', { name: 'Clear all', exact: true })).toHaveCount(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('school type groups and the faith filter narrow to what they name', async ({ page }) => {
|
||||||
|
await page.goto('/?search=school');
|
||||||
|
const type = page.getByRole('combobox', { name: 'School type', exact: true });
|
||||||
|
await expect(type).toBeVisible({ timeout: 15_000 });
|
||||||
|
await type.selectOption({ label: 'Special school (SEND)' });
|
||||||
|
await expect(page).toHaveURL(/[?&]school_type=special(&|$)/);
|
||||||
|
|
||||||
|
await page.getByRole('button', { name: /^More filters/ }).click();
|
||||||
|
await page.getByRole('combobox', { name: 'Faith', exact: true }).selectOption({ label: 'Roman Catholic' });
|
||||||
|
await expect(page).toHaveURL(/[?&]faith=roman_catholic(&|$)/);
|
||||||
|
|
||||||
|
const res = await page.request.get(
|
||||||
|
'/api/schools?search=school&school_type=special&faith=roman_catholic&page_size=100');
|
||||||
|
expect(res.ok()).toBeTruthy();
|
||||||
|
for (const s of (await res.json()).schools as { school_type: string; religious_denomination: string }[]) {
|
||||||
|
expect(s.school_type).toMatch(/special/i);
|
||||||
|
expect(s.religious_denomination).toMatch(/catholic/i);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a phase outside primary/secondary filters to that phase, not to everything', async ({ page }) => {
|
||||||
|
// The search page offers every GIAS phase, but the API only knew the grouped
|
||||||
|
// ones and silently dropped the rest — so "Nursery" returned primaries.
|
||||||
|
for (const phase of ['Nursery', '16 plus']) {
|
||||||
|
const res = await page.request.get(
|
||||||
|
`/api/schools?phase=${encodeURIComponent(phase.toLowerCase())}&page_size=50`);
|
||||||
|
expect(res.ok()).toBeTruthy();
|
||||||
|
const phases = new Set(
|
||||||
|
((await res.json()).schools ?? []).map((s: { phase?: string }) => s.phase));
|
||||||
|
expect([...phases], `phase=${phase} returned other phases`)
|
||||||
|
.toEqual(phases.size ? [phase] : []);
|
||||||
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
test('a report-card school shows a Report Card badge in search results, not its old grade', async ({ page }) => {
|
test('a report-card school shows a Report Card badge in search results, not its old grade', async ({ page }) => {
|
||||||
@@ -475,11 +597,8 @@ test('results map fullscreen falls back to an overlay on iOS', async ({ page })
|
|||||||
delete Element.prototype.requestFullscreen;
|
delete Element.prototype.requestFullscreen;
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// A postcode search opens on the map, phones included; open it fullscreen.
|
||||||
await searchByName(page, 'B1 1BB');
|
await searchByName(page, 'B1 1BB');
|
||||||
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
|
||||||
|
|
||||||
// Switch to the map view, then open the map fullscreen.
|
|
||||||
await page.getByRole('button', { name: 'Map', exact: true }).click();
|
|
||||||
const openFs = page.getByRole('button', { name: 'View map fullscreen' });
|
const openFs = page.getByRole('button', { name: 'View map fullscreen' });
|
||||||
await expect(openFs).toBeVisible({ timeout: 15_000 });
|
await expect(openFs).toBeVisible({ timeout: 15_000 });
|
||||||
await openFs.click();
|
await openFs.click();
|
||||||
@@ -491,6 +610,276 @@ test('results map fullscreen falls back to an overlay on iOS', async ({ page })
|
|||||||
await expect(openFs).toBeVisible();
|
await expect(openFs).toBeVisible();
|
||||||
});
|
});
|
||||||
|
|
||||||
|
/*
|
||||||
|
* A postcode search with a list long enough to scroll. The default half mile
|
||||||
|
* finds two schools around B1 1BB, so the page ends before the toolbar has
|
||||||
|
* anything to stay pinned over; the scroll tests ask for a mile.
|
||||||
|
*/
|
||||||
|
const LONG_LIST = '/?postcode=B1%201BB&radius=1';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* The results toolbar: search, filters and the List/Map switch pinned under
|
||||||
|
* the header, so none of them scroll away with the results.
|
||||||
|
*
|
||||||
|
* Positions are read after window.scrollTo, never after a click: Playwright
|
||||||
|
* scrolls a click target into view first, which would make "still on screen
|
||||||
|
* after scrolling" true of anything.
|
||||||
|
*/
|
||||||
|
test('the results toolbar stays pinned with its List/Map switch', async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width: 1280, height: 800 });
|
||||||
|
await page.goto(LONG_LIST);
|
||||||
|
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
||||||
|
|
||||||
|
const view = page.getByRole('group', { name: 'Results view' });
|
||||||
|
await expect(view).toBeVisible();
|
||||||
|
// Desktop opens on the map; the list is the long page that scrolls.
|
||||||
|
await page.getByRole('button', { name: 'List', exact: true }).click();
|
||||||
|
await expect(page.getByRole('button', { name: 'List', exact: true }))
|
||||||
|
.toHaveAttribute('aria-pressed', 'true');
|
||||||
|
|
||||||
|
await page.evaluate(() => window.scrollTo(0, 1500));
|
||||||
|
await expect.poll(() => page.evaluate(() => window.scrollY)).toBeGreaterThan(1000);
|
||||||
|
const box = await view.boundingBox();
|
||||||
|
expect(box, 'the switch left the viewport').not.toBeNull();
|
||||||
|
// Just under the 64px header, not scrolled off the top.
|
||||||
|
expect(box!.y).toBeGreaterThanOrEqual(64);
|
||||||
|
expect(box!.y).toBeLessThan(160);
|
||||||
|
await expect(page.getByRole('combobox', { name: 'Distance' })).toBeInViewport();
|
||||||
|
|
||||||
|
await page.getByRole('button', { name: 'Map', exact: true }).click();
|
||||||
|
await expect(page.getByRole('button', { name: 'Map', exact: true }))
|
||||||
|
.toHaveAttribute('aria-pressed', 'true');
|
||||||
|
});
|
||||||
|
|
||||||
|
/*
|
||||||
|
* The toolbar's line count is set by the screen width, never by the results.
|
||||||
|
* It once wrapped wherever it ran out of room, and the List/Map switch only
|
||||||
|
* appears when there are results — so the same search took two lines with
|
||||||
|
* results and one without.
|
||||||
|
*/
|
||||||
|
test('the results toolbar keeps its line count whether or not there are results', async ({ page }) => {
|
||||||
|
const withResults = LONG_LIST;
|
||||||
|
// No school type matches this, so the same search returns nothing.
|
||||||
|
const without = `${withResults}&school_type=no-such-type`;
|
||||||
|
|
||||||
|
const lines = async (url: string) => {
|
||||||
|
await page.goto(url);
|
||||||
|
// By label: the input is a combobox when autosuggest is on.
|
||||||
|
const input = page.getByLabel('School name or postcode', { exact: true });
|
||||||
|
const filters = page.getByRole('group', { name: 'Filters' });
|
||||||
|
await expect(filters).toBeVisible({ timeout: 15_000 });
|
||||||
|
const a = (await input.boundingBox())!;
|
||||||
|
const b = (await filters.boundingBox())!;
|
||||||
|
return b.y >= a.y + a.height ? 2 : 1;
|
||||||
|
};
|
||||||
|
const view = page.getByRole('group', { name: 'Results view' });
|
||||||
|
|
||||||
|
for (const [width, expected] of [[1400, 1], [1100, 2]] as const) {
|
||||||
|
await page.setViewportSize({ width, height: 800 });
|
||||||
|
expect(await lines(withResults), `${width}px with results`).toBe(expected);
|
||||||
|
await expect(view).toBeVisible();
|
||||||
|
expect(await lines(without), `${width}px without results`).toBe(expected);
|
||||||
|
await expect(view).toHaveCount(0);
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Desktop opens a postcode search on the map (mockup B): the list in a pane on
|
||||||
|
* the left, the map filling the rest of the screen, and a card on the map for
|
||||||
|
* the school picked in either.
|
||||||
|
*/
|
||||||
|
test('a desktop postcode search opens on the map with the list beside it', async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width: 1280, height: 800 });
|
||||||
|
await searchByName(page, 'B1 1BB');
|
||||||
|
|
||||||
|
await expect(page.getByRole('button', { name: 'Map', exact: true }))
|
||||||
|
.toHaveAttribute('aria-pressed', 'true', { timeout: 15_000 });
|
||||||
|
const pane = page.locator('[class*="mapListPane"]');
|
||||||
|
const card = pane.locator('[data-urn]').first();
|
||||||
|
await expect(card).toBeVisible({ timeout: 15_000 });
|
||||||
|
// The list view's own row, not a cut-down card: it carries the same View
|
||||||
|
// link and Compare button.
|
||||||
|
await expect(card.getByRole('link', { name: 'View', exact: true })).toBeVisible();
|
||||||
|
await expect(card.getByRole('button', { name: /Compar/ })).toBeVisible();
|
||||||
|
await expect(page.locator('.sc-pin').first()).toBeVisible({ timeout: 15_000 });
|
||||||
|
|
||||||
|
// The count and the sort share one line at the top of the list.
|
||||||
|
const heading = await pane.getByRole('heading', { level: 2 }).boundingBox();
|
||||||
|
const sort = await pane.getByRole('combobox').boundingBox();
|
||||||
|
expect(Math.abs((heading!.y + heading!.height / 2) - (sort!.y + sort!.height / 2)))
|
||||||
|
.toBeLessThan(8);
|
||||||
|
|
||||||
|
// The split runs to the bottom of the screen rather than stopping short.
|
||||||
|
const split = await page.locator('[class*="mapViewContainer"]').boundingBox();
|
||||||
|
expect(split!.y + split!.height).toBeGreaterThan(800 - 40);
|
||||||
|
expect(split!.y + split!.height).toBeLessThanOrEqual(800);
|
||||||
|
|
||||||
|
// A card picks its pin and opens its card on the map. Clicked in its padding,
|
||||||
|
// clear of the name link and the Compare button.
|
||||||
|
const name = (await card.locator('a').first().innerText()).trim();
|
||||||
|
await card.click({ position: { x: 6, y: 6 } });
|
||||||
|
await expect(page.locator('.sc-pin--selected')).toHaveCount(1);
|
||||||
|
// Leaflet crossfades popups for 200ms, so two exist until the old one goes.
|
||||||
|
await expect(page.locator('.sc-popup')).toHaveCount(1);
|
||||||
|
await expect(page.locator('.sc-popup')).toContainText(name);
|
||||||
|
// The card's View link is drawn like the list's, not in Leaflet's link blue.
|
||||||
|
// Polled, because .btn transitions its colour.
|
||||||
|
const colour = (l: Locator) => l.evaluate(el => getComputedStyle(el).color);
|
||||||
|
const listViewColour = await colour(card.getByRole('link', { name: 'View', exact: true }));
|
||||||
|
await expect.poll(() => colour(page.locator('.sc-popup').getByRole('link', { name: 'View', exact: true })))
|
||||||
|
.toBe(listViewColour);
|
||||||
|
|
||||||
|
// And from the keyboard: each row has a "Show … on the map" button that
|
||||||
|
// appears on focus.
|
||||||
|
const second = pane.locator('[data-urn]').nth(1);
|
||||||
|
const secondName = (await second.locator('a').first().innerText()).trim();
|
||||||
|
const show = second.getByRole('button', { name: `Show ${secondName} on the map` });
|
||||||
|
await show.focus();
|
||||||
|
await expect(show).toBeVisible();
|
||||||
|
await page.keyboard.press('Enter');
|
||||||
|
await expect(show).toHaveAttribute('aria-pressed', 'true');
|
||||||
|
await expect(page.locator('.sc-popup')).toHaveCount(1);
|
||||||
|
await expect(page.locator('.sc-popup')).toContainText(secondName);
|
||||||
|
});
|
||||||
|
|
||||||
|
// 402 is the iPhone 17, where the toolbar overflowed (see below).
|
||||||
|
for (const width of [360, 390, 402, 430]) {
|
||||||
|
test(`a phone opens on the map, with the list a tap away, at ${width}px`, async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width, height: 800 });
|
||||||
|
await page.goto(LONG_LIST);
|
||||||
|
|
||||||
|
// On the map, with the floating button offering the list, clear of the
|
||||||
|
// bottom tab bar.
|
||||||
|
const toList = page.getByRole('button', { name: 'Show list' });
|
||||||
|
await expect(toList).toBeInViewport({ timeout: 15_000 });
|
||||||
|
await expect(page.locator('.sc-pin').first()).toBeAttached({ timeout: 15_000 });
|
||||||
|
const barTop = await page.locator('nav[class*="bottomBar"]')
|
||||||
|
.evaluate((el) => el.getBoundingClientRect().top);
|
||||||
|
const fabBox = (await toList.boundingBox())!;
|
||||||
|
expect(fabBox.y + fabBox.height).toBeLessThanOrEqual(barTop);
|
||||||
|
|
||||||
|
// A pin opens the bottom sheet, stacked under the button, above the bar.
|
||||||
|
// dispatchEvent, not click: a pin may sit under the button or the toolbar,
|
||||||
|
// and Leaflet listens on the pin itself.
|
||||||
|
await page.locator('.sc-pin').first().dispatchEvent('click');
|
||||||
|
const sheet = page.locator('[class*="bottomSheet"]');
|
||||||
|
await expect(sheet).toBeVisible();
|
||||||
|
// The sheet slides up over 0.3s; measure where it comes to rest, not a
|
||||||
|
// frame of the animation (which reads as below the tab bar).
|
||||||
|
await expect.poll(async () => {
|
||||||
|
const box = (await sheet.boundingBox())!;
|
||||||
|
return Math.round(box.y + box.height);
|
||||||
|
}).toBeLessThanOrEqual(barTop);
|
||||||
|
// The dock is anchored at the bottom, so the sheet pushes the button up:
|
||||||
|
// measure the button again now that the sheet is in.
|
||||||
|
const fabNow = (await toList.boundingBox())!;
|
||||||
|
expect((await sheet.boundingBox())!.y).toBeGreaterThanOrEqual(fabNow.y + fabNow.height);
|
||||||
|
|
||||||
|
// MOBILE.md: no horizontal overflow, and 44px targets in the new chrome.
|
||||||
|
expect(await page.evaluate(() => document.documentElement.scrollWidth - window.innerWidth))
|
||||||
|
.toBe(0);
|
||||||
|
// scrollWidth alone cannot see this page's overflow: .main clips on x, so
|
||||||
|
// the search summary ran 40px off an iPhone 17 screen with scrollWidth
|
||||||
|
// still equal to the viewport. Measure the toolbar's own edges instead;
|
||||||
|
// the applied-filter chips scroll by design, so only their line's box is
|
||||||
|
// held to the edge.
|
||||||
|
const offscreen = await page.evaluate(() => {
|
||||||
|
const toolbar = document.querySelector('[class*="resultsToolbar"]');
|
||||||
|
return [...(toolbar?.querySelectorAll('*') ?? [])]
|
||||||
|
.filter((el) => (el as HTMLElement).offsetParent
|
||||||
|
&& !el.parentElement?.closest('[class*="chipsLine"]'))
|
||||||
|
.map((el) => ({ el: (el.className?.toString() || el.tagName).slice(0, 40),
|
||||||
|
right: Math.round(el.getBoundingClientRect().right) }))
|
||||||
|
.filter((o) => o.right > window.innerWidth);
|
||||||
|
});
|
||||||
|
expect(offscreen).toEqual([]);
|
||||||
|
const small = await page.evaluate(() => {
|
||||||
|
const toolbar = document.querySelector('[class*="resultsToolbar"]');
|
||||||
|
const fabEl = document.querySelector('[class*="viewFab"]');
|
||||||
|
const closeEl = document.querySelector('[class*="closeSheetBtn"]');
|
||||||
|
return [...(toolbar?.querySelectorAll('a, button, input, select') ?? []), fabEl, closeEl]
|
||||||
|
.filter((el): el is HTMLElement => !!el && !!(el as HTMLElement).offsetParent)
|
||||||
|
.map((el) => ({ t: el.innerText?.trim().slice(0, 24) || el.getAttribute('aria-label'),
|
||||||
|
w: el.getBoundingClientRect().width, h: el.getBoundingClientRect().height }))
|
||||||
|
.filter((o) => o.w < 44 || o.h < 44);
|
||||||
|
});
|
||||||
|
expect(small).toEqual([]);
|
||||||
|
|
||||||
|
// The list: the search folds to a summary, and the pinned toolbar and
|
||||||
|
// the button survive a scroll.
|
||||||
|
await toList.click();
|
||||||
|
const toMap = page.getByRole('button', { name: 'Show map' });
|
||||||
|
await expect(toMap).toBeInViewport();
|
||||||
|
await expect(schoolLinks(page).first()).toBeVisible();
|
||||||
|
const summary = page.getByRole('button', { name: /^Edit search: B1 1BB/ });
|
||||||
|
await page.evaluate(() => window.scrollTo(0, 1200));
|
||||||
|
await expect.poll(() => page.evaluate(() => window.scrollY)).toBeGreaterThan(600);
|
||||||
|
await expect(summary).toBeInViewport();
|
||||||
|
await expect(toMap).toBeInViewport();
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Phones filter through one Filters button and a sheet with every filter in
|
||||||
|
* it. The row it replaced scrolled sideways with "More filters" first, so
|
||||||
|
* phase showed only in part, school type not at all, and the panel "More
|
||||||
|
* filters" opened held neither.
|
||||||
|
*/
|
||||||
|
test('a phone filters through one sheet, and sees what it applied as chips', async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width: 390, height: 844 });
|
||||||
|
await page.goto(LONG_LIST);
|
||||||
|
const trigger = page.getByRole('button', { name: 'Filters', exact: true });
|
||||||
|
await expect(trigger).toBeInViewport({ timeout: 15_000 });
|
||||||
|
// The desktop row is gone at this width: no phase select until the sheet.
|
||||||
|
await expect(page.getByRole('combobox', { name: 'Phase', exact: true })).toHaveCount(0);
|
||||||
|
|
||||||
|
await trigger.click();
|
||||||
|
const sheet = page.getByRole('dialog', { name: 'Filters' });
|
||||||
|
await expect(sheet).toBeVisible();
|
||||||
|
await expect(sheet.getByRole('radio', { name: 'Within 1 mile' })).toBeChecked();
|
||||||
|
for (const name of ['Phase', 'School type', 'Local authority']) {
|
||||||
|
await expect(sheet.getByRole('combobox', { name, exact: true })).toBeVisible();
|
||||||
|
}
|
||||||
|
|
||||||
|
// A change applies at once, and the sheet stays open for the next one.
|
||||||
|
await sheet.getByRole('combobox', { name: 'Phase', exact: true }).selectOption('primary');
|
||||||
|
await page.waitForURL(/[?&]phase=primary(&|$)/);
|
||||||
|
await expect(sheet).toBeVisible();
|
||||||
|
const show = sheet.getByRole('button', { name: /^(Show [\d,]+ schools?|No schools match)$/ });
|
||||||
|
await expect(show).toBeVisible();
|
||||||
|
|
||||||
|
// MOBILE.md: the sheet clears the bottom tab bar, and its targets are 44px.
|
||||||
|
// It slides up over 0.3s, so poll for where it comes to rest.
|
||||||
|
await expect.poll(async () => {
|
||||||
|
const box = (await show.boundingBox())!;
|
||||||
|
return Math.round(box.y + box.height);
|
||||||
|
}).toBeLessThanOrEqual(844);
|
||||||
|
const small = await sheet.evaluate((el) =>
|
||||||
|
[...el.querySelectorAll('button, select, label:has(input)')]
|
||||||
|
.filter((n): n is HTMLElement => !!(n as HTMLElement).offsetParent)
|
||||||
|
.map((n) => ({ t: n.innerText?.trim().slice(0, 24) || n.getAttribute('aria-label'),
|
||||||
|
w: n.getBoundingClientRect().width, h: n.getBoundingClientRect().height }))
|
||||||
|
.filter((o) => o.w < 44 || o.h < 44));
|
||||||
|
expect(small).toEqual([]);
|
||||||
|
|
||||||
|
await show.click();
|
||||||
|
await expect(sheet).toBeHidden();
|
||||||
|
|
||||||
|
// What was applied shows under the search, counted on the button, and comes
|
||||||
|
// off with a tap, keeping the search.
|
||||||
|
await expect(page.getByRole('button', { name: 'Filters, 1 applied' })).toBeInViewport();
|
||||||
|
const chip = page.getByRole('group', { name: 'Applied filters' })
|
||||||
|
.getByRole('button', { name: 'Remove filter: Primary' });
|
||||||
|
await expect(chip).toBeInViewport();
|
||||||
|
expect(await page.evaluate(() => document.documentElement.scrollWidth - window.innerWidth))
|
||||||
|
.toBe(0);
|
||||||
|
await chip.click();
|
||||||
|
await expect(page).not.toHaveURL(/[?&]phase=/);
|
||||||
|
await expect(page).toHaveURL(/[?&]postcode=B1(%20|\+)1BB/);
|
||||||
|
await expect(page.getByRole('group', { name: 'Applied filters' })).toHaveCount(0);
|
||||||
|
await expect(trigger).toBeInViewport();
|
||||||
|
});
|
||||||
|
|
||||||
test('comparing two schools shows the parent-first sections side by side', async ({ page }) => {
|
test('comparing two schools shows the parent-first sections side by side', async ({ page }) => {
|
||||||
// Two same-phase (pure primary) schools so both stay on one tab.
|
// Two same-phase (pure primary) schools so both stay on one tab.
|
||||||
const [urn0, urn1] = await twoPrimaryUrns(page);
|
const [urn0, urn1] = await twoPrimaryUrns(page);
|
||||||
@@ -1935,6 +2324,63 @@ async function firstPlaceOfKind(page: Page, kind: string) {
|
|||||||
return hit as { kind: string; slug: string; name: string; count: number };
|
return hit as { kind: string; slug: string; name: string; count: number };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The round trip. Place pages always linked down to school pages; school
|
||||||
|
* pages linked nowhere on the site, so the ~27k of them that carry most of
|
||||||
|
* the inbound authority stranded it — their only anchor pointed at the
|
||||||
|
* school's own website.
|
||||||
|
*
|
||||||
|
* Asserting both directions is the point. A one-way link is what already
|
||||||
|
* existed and is not what this journey is for.
|
||||||
|
*/
|
||||||
|
test('a school page links back into the location layer, and the place page links down', async ({ page }) => {
|
||||||
|
const town = await firstPlaceOfKind(page, 'town');
|
||||||
|
|
||||||
|
// Start from the place page and take its first school, so the pair is
|
||||||
|
// guaranteed to be genuinely related rather than a hardcoded guess.
|
||||||
|
await page.goto(`/schools/${town.slug}`);
|
||||||
|
const schoolHref = await page.locator('a[href^="/school/"]').first()
|
||||||
|
.getAttribute('href');
|
||||||
|
expect(schoolHref, 'the town page listed no school to follow').toBeTruthy();
|
||||||
|
|
||||||
|
await page.goto(schoolHref!);
|
||||||
|
|
||||||
|
// Down: the school page must offer a link back to the town it sits in.
|
||||||
|
const backToTown = page.locator(`a[href="/schools/${town.slug}"]`);
|
||||||
|
await expect(backToTown).toHaveCount(1);
|
||||||
|
await expect(backToTown).toBeVisible();
|
||||||
|
|
||||||
|
// The anchor says what it leads to, which is worth more than "see more".
|
||||||
|
await expect(backToTown).toContainText(town.name, { ignoreCase: true });
|
||||||
|
await expect(backToTown).toContainText(/\d+ schools?/);
|
||||||
|
|
||||||
|
// And the breadcrumb resolves the school into a real hierarchy.
|
||||||
|
const blocks = await page.locator('script[type="application/ld+json"]')
|
||||||
|
.allTextContents();
|
||||||
|
const graph = blocks.join(' ');
|
||||||
|
expect(graph).toContain('"BreadcrumbList"');
|
||||||
|
// The narrower type, not the EducationalOrganization parent it used to be.
|
||||||
|
expect(graph).toContain('"School"');
|
||||||
|
|
||||||
|
/*
|
||||||
|
* The phase variants are the pages this most needs to reach: ~950 of them
|
||||||
|
* were once reachable by nothing at all, absent from every sitemap and
|
||||||
|
* unlinked from the place page. Conditional because not every school sits
|
||||||
|
* in a town that publishes one.
|
||||||
|
*/
|
||||||
|
const phaseLink = page.locator(`a[href^="/schools/${town.slug}/"]`).first();
|
||||||
|
if (await phaseLink.count()) {
|
||||||
|
const phaseHref = await phaseLink.getAttribute('href');
|
||||||
|
expect((await page.request.get(phaseHref!)).status()).toBe(200);
|
||||||
|
await expect(phaseLink).toContainText(/primary|secondary/);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Following it lands on a real page, not a 404.
|
||||||
|
await backToTown.click();
|
||||||
|
await page.waitForURL(new RegExp(`/schools/${town.slug}$`));
|
||||||
|
await expect(page.locator('h1')).toContainText(town.name, { ignoreCase: true });
|
||||||
|
});
|
||||||
|
|
||||||
for (const [kind, prefix, article] of [
|
for (const [kind, prefix, article] of [
|
||||||
['town', '/schools/', 'a'],
|
['town', '/schools/', 'a'],
|
||||||
['authority', '/schools/authority/', 'an'],
|
['authority', '/schools/authority/', 'an'],
|
||||||
@@ -2560,8 +3006,56 @@ test('the destinations section never claims a pupil stayed at this school', asyn
|
|||||||
* These journeys assert the load-bearing parts of that — a name, a face, the
|
* These journeys assert the load-bearing parts of that — a name, a face, the
|
||||||
* honesty claim, and a resolvable Person entity — rather than exact copy,
|
* honesty claim, and a resolvable Person entity — rather than exact copy,
|
||||||
* which will be edited.
|
* which will be edited.
|
||||||
|
*
|
||||||
|
* Both are behind flags (about_page, blog), so each has a lit journey and a
|
||||||
|
* dark one. Flag state is read from the observable effect rather than from
|
||||||
|
* /api/flags, which the public proxy denies on purpose — the same approach
|
||||||
|
* distanceFeatureIsOn() takes above.
|
||||||
*/
|
*/
|
||||||
|
async function aboutPageIsOn(page: Page): Promise<boolean> {
|
||||||
|
return (await page.request.get('/about')).ok();
|
||||||
|
}
|
||||||
|
|
||||||
|
async function blogIsOn(page: Page): Promise<boolean> {
|
||||||
|
return (await page.request.get('/blog')).ok();
|
||||||
|
}
|
||||||
|
|
||||||
|
test('with the about page off, it is absent rather than empty', async ({ page }) => {
|
||||||
|
test.skip(await aboutPageIsOn(page), 'the about_page flag is on in this environment');
|
||||||
|
|
||||||
|
// Dark means the URL does not exist, not that it renders empty: a 404 is
|
||||||
|
// what stops a crawler keeping the page in its index.
|
||||||
|
expect((await page.request.get('/about')).status()).toBe(404);
|
||||||
|
|
||||||
|
// A footer link into a 404 is the failure this flag has to avoid.
|
||||||
|
await page.goto('/');
|
||||||
|
await expect(page.locator('footer a[href="/about"]')).toHaveCount(0);
|
||||||
|
|
||||||
|
// And a sitemap must never advertise a URL that 404s.
|
||||||
|
const sitemap = await page.request.get('/content-sitemap.xml');
|
||||||
|
expect(await sitemap.text()).not.toContain('/about');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('with the blog off, it is absent rather than empty', async ({ page }) => {
|
||||||
|
test.skip(await blogIsOn(page), 'the blog flag is on in this environment');
|
||||||
|
|
||||||
|
expect((await page.request.get('/blog')).status()).toBe(404);
|
||||||
|
expect((await page.request.get('/blog/rss.xml')).status()).toBe(404);
|
||||||
|
|
||||||
|
await page.goto('/');
|
||||||
|
await expect(page.locator('footer a[href="/blog"]')).toHaveCount(0);
|
||||||
|
|
||||||
|
const sitemap = await page.request.get('/content-sitemap.xml');
|
||||||
|
expect(await sitemap.text()).not.toContain('/blog');
|
||||||
|
|
||||||
|
// The admin panel is deliberately NOT flagged: posts have to be writable
|
||||||
|
// before the blog is readable, or there is nothing to turn on.
|
||||||
|
expect((await page.request.get('/admin')).status()).not.toBe(404);
|
||||||
|
});
|
||||||
|
|
||||||
test('the about page names a human author and is reachable from the footer', async ({ page }) => {
|
test('the about page names a human author and is reachable from the footer', async ({ page }) => {
|
||||||
|
test.skip(!(await aboutPageIsOn(page)), 'the about_page flag is off in this environment');
|
||||||
|
|
||||||
await page.goto('/');
|
await page.goto('/');
|
||||||
const aboutLink = page.locator('footer a[href="/about"]');
|
const aboutLink = page.locator('footer a[href="/about"]');
|
||||||
await expect(aboutLink).toBeVisible();
|
await expect(aboutLink).toBeVisible();
|
||||||
@@ -2585,6 +3079,8 @@ test('the about page names a human author and is reachable from the footer', asy
|
|||||||
});
|
});
|
||||||
|
|
||||||
test('the blog lists posts and each one renders with a byline', async ({ page }) => {
|
test('the blog lists posts and each one renders with a byline', async ({ page }) => {
|
||||||
|
test.skip(!(await blogIsOn(page)), 'the blog flag is off in this environment');
|
||||||
|
|
||||||
await page.goto('/blog');
|
await page.goto('/blog');
|
||||||
await expect(page.getByRole('heading', { level: 1 })).toBeVisible();
|
await expect(page.getByRole('heading', { level: 1 })).toBeVisible();
|
||||||
|
|
||||||
@@ -2612,8 +3108,13 @@ test('the admin panel is not indexable', async ({ page }) => {
|
|||||||
|
|
||||||
test('the content sitemap lists the about page and is advertised in robots', async ({ page }) => {
|
test('the content sitemap lists the about page and is advertised in robots', async ({ page }) => {
|
||||||
const sitemap = await page.request.get('/content-sitemap.xml');
|
const sitemap = await page.request.get('/content-sitemap.xml');
|
||||||
|
// Served whatever the flags say: robots.txt names it unconditionally, and
|
||||||
|
// with both dark it is a valid empty urlset rather than a 404.
|
||||||
expect(sitemap.ok()).toBeTruthy();
|
expect(sitemap.ok()).toBeTruthy();
|
||||||
expect(await sitemap.text()).toContain('/about');
|
|
||||||
|
if (await aboutPageIsOn(page)) {
|
||||||
|
expect(await sitemap.text()).toContain('/about');
|
||||||
|
}
|
||||||
|
|
||||||
// The school corpus sitemap is proxied from FastAPI; this one is Next's.
|
// The school corpus sitemap is proxied from FastAPI; this one is Next's.
|
||||||
// robots.txt must advertise both or the blog never gets discovered.
|
// robots.txt must advertise both or the blog never gets discovered.
|
||||||
@@ -2622,3 +3123,166 @@ test('the content sitemap lists the about page and is advertised in robots', asy
|
|||||||
expect(body).toContain('/sitemap.xml');
|
expect(body).toContain('/sitemap.xml');
|
||||||
expect(body).toContain('/content-sitemap.xml');
|
expect(body).toContain('/content-sitemap.xml');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Other schools nearby.
|
||||||
|
*
|
||||||
|
* The section is absent by design where fewer than two schools qualify, and the
|
||||||
|
* arrows are absent where three cards fit, so this asserts each part of the
|
||||||
|
* contract only where it applies.
|
||||||
|
*
|
||||||
|
* Two things here cannot be tested anywhere else: the arrows' disabled state,
|
||||||
|
* which jsdom cannot measure because it has no layout, and the scroll position
|
||||||
|
* surviving a selection, which is DOM state rather than React state.
|
||||||
|
*/
|
||||||
|
test('nearby schools link on to other schools and into compare', async ({ page }) => {
|
||||||
|
await searchByName(page, 'Primary');
|
||||||
|
await schoolLinks(page).first().click();
|
||||||
|
await page.waitForURL(/\/school\//);
|
||||||
|
|
||||||
|
const section = page.locator('#nearby');
|
||||||
|
if ((await section.count()) === 0) {
|
||||||
|
test.skip(true, 'No qualifying similar schools for this school');
|
||||||
|
}
|
||||||
|
|
||||||
|
// Every card is a real link to another school page — including the ones
|
||||||
|
// behind the arrows, which is the whole reason this is a scroller and not a
|
||||||
|
// paginated widget.
|
||||||
|
const links = section.locator('a[href^="/school/"]');
|
||||||
|
const linkCount = await links.count();
|
||||||
|
expect(linkCount).toBeGreaterThanOrEqual(2);
|
||||||
|
expect(linkCount).toBeLessThanOrEqual(6);
|
||||||
|
expect(await links.first().getAttribute('href')).toMatch(/^\/school\/\d{6}-/);
|
||||||
|
|
||||||
|
await expect(section.getByText(/miles away/).first()).toBeVisible();
|
||||||
|
|
||||||
|
const scroller = section.locator('ul').first();
|
||||||
|
|
||||||
|
// The carousel, where this school had more than three matches.
|
||||||
|
const forward = section.getByRole('button', { name: 'More schools' });
|
||||||
|
if (await forward.count()) {
|
||||||
|
const back = section.getByRole('button', { name: 'Previous schools' });
|
||||||
|
await expect(back).toBeDisabled();
|
||||||
|
|
||||||
|
await forward.click();
|
||||||
|
expect(await settledScrollLeft(scroller)).toBeGreaterThan(8);
|
||||||
|
await expect(back).toBeEnabled();
|
||||||
|
}
|
||||||
|
|
||||||
|
// The compare hand-off, and the row must not jump back to the start when the
|
||||||
|
// footer re-renders underneath it.
|
||||||
|
//
|
||||||
|
// Click the LAST card's button, not the first. Playwright scrolls a target
|
||||||
|
// into view before clicking it, so clicking card one while the row is paged
|
||||||
|
// to the end scrolls the container back to the start — and the assertion
|
||||||
|
// below then measures Playwright's own scrolling rather than the app's.
|
||||||
|
// That is what this test did on its first staging run: 537 → 2, reproduced
|
||||||
|
// afterwards on a static page with no React on it at all.
|
||||||
|
//
|
||||||
|
// A few pixels of snap or sub-pixel adjustment are fine; a reset to the
|
||||||
|
// start is not, which is the whole point of the check.
|
||||||
|
const offsetBefore = await settledScrollLeft(scroller);
|
||||||
|
await section.getByRole('button', { name: /Add to compare/ }).last().click();
|
||||||
|
await expect(
|
||||||
|
section.getByRole('button', { name: /Added to compare/ }).first(),
|
||||||
|
).toBeVisible();
|
||||||
|
const offsetAfter = await settledScrollLeft(scroller);
|
||||||
|
expect(Math.abs(offsetAfter - offsetBefore)).toBeLessThanOrEqual(8);
|
||||||
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Every section in the mobile jump sheet can actually be reached.
|
||||||
|
*
|
||||||
|
* The sheet is a fixed bottom sheet, and the app has a fixed bottom tab bar.
|
||||||
|
* `position: sticky` with a z-index on the sticky nav makes it a stacking
|
||||||
|
* context, so the sheet's own z-index orders it only within that context —
|
||||||
|
* against the tab bar, the nav's value is what counts. The last item in the
|
||||||
|
* sheet was therefore painted over and untappable as soon as the list grew
|
||||||
|
* long enough to reach the bar, which adding "Nearby schools" is what did.
|
||||||
|
*
|
||||||
|
* Bounding boxes are not enough to catch this: the item is in the viewport and
|
||||||
|
* the right size, it is simply underneath something. So this asks the question
|
||||||
|
* a thumb asks — what is on top at this point.
|
||||||
|
*/
|
||||||
|
test('every section in the mobile jump sheet is tappable, not under the tab bar', async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width: 390, height: 844 });
|
||||||
|
await searchByName(page, 'Primary');
|
||||||
|
await schoolLinks(page).first().click();
|
||||||
|
await page.waitForURL(/\/school\//);
|
||||||
|
|
||||||
|
// Scroll down so the sticky nav is docked and the sheet has somewhere to open.
|
||||||
|
await page.evaluate(() => window.scrollTo({ top: 1200 }));
|
||||||
|
// Two controls carry aria-haspopup: the mobile "Section" button and the
|
||||||
|
// desktop "All" one, which is display:none here but still in the DOM.
|
||||||
|
await page.locator('[aria-haspopup="menu"]:visible').click();
|
||||||
|
|
||||||
|
const sheet = page.locator('[role="menu"]');
|
||||||
|
await expect(sheet).toBeVisible();
|
||||||
|
|
||||||
|
const covered = await sheet.evaluate((panel: HTMLElement) =>
|
||||||
|
Array.from(panel.querySelectorAll('[role="menuitem"]'))
|
||||||
|
.map((el) => {
|
||||||
|
const box = el.getBoundingClientRect();
|
||||||
|
const hit = document.elementFromPoint(
|
||||||
|
Math.round(box.left + box.width / 2),
|
||||||
|
Math.round(box.top + box.height / 2),
|
||||||
|
);
|
||||||
|
return { label: (el as HTMLElement).innerText.trim().replace(/\s+/g, ' '), reachable: !!(hit && hit.closest('[role="menuitem"]')) };
|
||||||
|
})
|
||||||
|
.filter((item) => !item.reachable)
|
||||||
|
.map((item) => item.label),
|
||||||
|
);
|
||||||
|
|
||||||
|
expect(covered).toEqual([]);
|
||||||
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The nearby-schools section at MOBILE.md's three reference widths.
|
||||||
|
*
|
||||||
|
* MOBILE.md asks for exactly this check and records that it was not written
|
||||||
|
* because "Playwright isn't currently in the project dependency set". That is
|
||||||
|
* no longer true — this suite is Playwright — so the check exists now, scoped
|
||||||
|
* to the page this feature touches.
|
||||||
|
*/
|
||||||
|
for (const width of [360, 390, 430]) {
|
||||||
|
test(`nearby schools survives a ${width}px viewport`, async ({ page }) => {
|
||||||
|
await page.setViewportSize({ width, height: 800 });
|
||||||
|
await searchByName(page, 'Primary');
|
||||||
|
await schoolLinks(page).first().click();
|
||||||
|
await page.waitForURL(/\/school\//);
|
||||||
|
|
||||||
|
const section = page.locator('#nearby');
|
||||||
|
if ((await section.count()) === 0) {
|
||||||
|
test.skip(true, 'No qualifying similar schools for this school');
|
||||||
|
}
|
||||||
|
|
||||||
|
// 1. Nothing bleeds past the right edge.
|
||||||
|
expect(
|
||||||
|
await page.evaluate(() => document.documentElement.scrollWidth - window.innerWidth),
|
||||||
|
).toBe(0);
|
||||||
|
|
||||||
|
// 2. No arrows on touch widths — swiping does the job, and they would take
|
||||||
|
// 96px from a 328px card.
|
||||||
|
await expect(section.getByRole('button', { name: 'More schools' })).toHaveCount(0);
|
||||||
|
|
||||||
|
// 3. Every tap target in the section clears 44px. A card title's own box is
|
||||||
|
// shorter, but its hit area is the whole card via ::after.
|
||||||
|
const failing = await section.evaluate((root: HTMLElement) =>
|
||||||
|
Array.from(root.querySelectorAll('a, button'))
|
||||||
|
.filter((el) => (el as HTMLElement).offsetParent)
|
||||||
|
.map((el) => {
|
||||||
|
const card = el.closest('li');
|
||||||
|
const box = el.matches('h3 a') && card
|
||||||
|
? card.getBoundingClientRect()
|
||||||
|
: el.getBoundingClientRect();
|
||||||
|
return {
|
||||||
|
text: (el as HTMLElement).innerText.trim().slice(0, 24),
|
||||||
|
w: box.width,
|
||||||
|
h: box.height,
|
||||||
|
};
|
||||||
|
})
|
||||||
|
.filter((o) => o.w < 44 || o.h < 44),
|
||||||
|
);
|
||||||
|
expect(failing).toEqual([]);
|
||||||
|
});
|
||||||
|
}
|
||||||
@@ -0,0 +1,41 @@
|
|||||||
|
import { test, expect, Route } from '@playwright/test';
|
||||||
|
|
||||||
|
test('the deployed frontend and backend report the tested build', async ({ request }) => {
|
||||||
|
const response = await request.get('/release.json');
|
||||||
|
expect(response.ok()).toBeTruthy();
|
||||||
|
expect(response.headers()['cache-control']).toContain('no-store');
|
||||||
|
const identity = await response.json();
|
||||||
|
expect(identity.frontend).toEqual(identity.backend);
|
||||||
|
expect(identity.frontend.sha).toMatch(/^[a-f0-9]{40}$/);
|
||||||
|
expect(identity.frontend.build_id).toMatch(/^[a-f0-9]{32}$/);
|
||||||
|
if (process.env.EXPECTED_SHA) expect(identity.frontend.sha).toBe(process.env.EXPECTED_SHA);
|
||||||
|
if (process.env.EXPECTED_BUILD_ID) expect(identity.frontend.build_id).toBe(process.env.EXPECTED_BUILD_ID);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('changing search while loading another page does not append old results', async ({ page }) => {
|
||||||
|
await page.goto('/?phase=primary');
|
||||||
|
await expect(page.getByRole('button', { name: 'Load more schools' })).toBeVisible();
|
||||||
|
let received!: (route: Route) => void;
|
||||||
|
const pending = new Promise<Route>(resolve => { received = resolve; });
|
||||||
|
await page.route('**/api/schools?**', async route => {
|
||||||
|
if (new URL(route.request().url()).searchParams.get('page') === '2') {
|
||||||
|
received(route);
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
await route.continue();
|
||||||
|
});
|
||||||
|
await page.getByRole('button', { name: 'Load more schools' }).click();
|
||||||
|
const oldRequest = await pending;
|
||||||
|
const search = page.getByPlaceholder('School name or postcode').first();
|
||||||
|
await search.fill('secondary');
|
||||||
|
await search.press('Enter');
|
||||||
|
await page.waitForURL(/search=secondary/);
|
||||||
|
// A cancelled fetch may prevent route fulfilment altogether; either way,
|
||||||
|
// this deliberately late response must not become part of the new results.
|
||||||
|
await oldRequest.fulfill({ json: {
|
||||||
|
schools: [{ urn: 999998, school_name: 'P1 stale result sentinel', phase: 'Primary' }],
|
||||||
|
total: 2, page: 2, page_size: 1, total_pages: 2,
|
||||||
|
} }).catch(() => {});
|
||||||
|
await expect(page.getByText('P1 stale result sentinel')).toHaveCount(0);
|
||||||
|
await expect(page.getByRole('button', { name: 'Loading...' })).toHaveCount(0);
|
||||||
|
});
|
||||||
@@ -0,0 +1,373 @@
|
|||||||
|
<!DOCTYPE html>
|
||||||
|
<html lang="en">
|
||||||
|
<head>
|
||||||
|
<meta charset="utf-8">
|
||||||
|
<meta name="viewport" content="width=device-width, initial-scale=1">
|
||||||
|
<title>Similar Schools Nearby</title>
|
||||||
|
<link rel="preconnect" href="https://fonts.googleapis.com">
|
||||||
|
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
|
||||||
|
<link href="https://fonts.googleapis.com/css2?family=Inter:wght@400;500;600&family=Manrope:wght@500;600;700&display=swap" rel="stylesheet">
|
||||||
|
<style>
|
||||||
|
/* Tokens copied verbatim from nextjs-app/app/(frontend)/globals.css so this
|
||||||
|
mockup cannot drift from the shipped palette. Light values first, dark
|
||||||
|
under prefers-color-scheme, both overridable by the theme switch. */
|
||||||
|
:root {
|
||||||
|
color-scheme: light;
|
||||||
|
--bg-primary:#FAFAF8; --bg-secondary:#F5EFE6; --bg-card:#FFFFFF;
|
||||||
|
--text-primary:#1C2731; --text-secondary:#4A5560; --text-muted:#5F6A75;
|
||||||
|
--border:#E5E7EB; --border-strong:#D3D7DD;
|
||||||
|
--brand:#0F766E; --brand-strong:#0C5F58; --brand-bg:rgba(15,118,110,.10); --brand-on:#FFFFFF;
|
||||||
|
--action:#BE3C27; --action-strong:#A33320; --action-on:#FFFFFF;
|
||||||
|
--sand:#F5EFE6;
|
||||||
|
--font-display:Manrope,-apple-system,BlinkMacSystemFont,sans-serif;
|
||||||
|
--font-ui:Inter,-apple-system,BlinkMacSystemFont,sans-serif;
|
||||||
|
--radius-md:8px; --radius-lg:16px;
|
||||||
|
--shadow:0 1px 2px rgba(28,39,49,.06),0 1px 3px rgba(28,39,49,.05);
|
||||||
|
}
|
||||||
|
@media (prefers-color-scheme: dark) {
|
||||||
|
:root:not([data-theme="light"]) {
|
||||||
|
color-scheme: dark;
|
||||||
|
--bg-primary:#111A20; --bg-secondary:#16222A; --bg-card:#18242C;
|
||||||
|
--text-primary:#E9EEF0; --text-secondary:#B4C2C7; --text-muted:#8B9AA1;
|
||||||
|
--border:#26343D; --border-strong:#35454F;
|
||||||
|
--brand:#5FC7BB; --brand-strong:#7BD6CC; --brand-bg:rgba(95,199,187,.14); --brand-on:#0A1418;
|
||||||
|
--action:#F08A72; --action-strong:#F5A492; --action-on:#241009;
|
||||||
|
--sand:#1B2730;
|
||||||
|
--shadow:0 1px 2px rgba(0,0,0,.3),0 1px 3px rgba(0,0,0,.25);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
:root[data-theme="dark"] {
|
||||||
|
color-scheme: dark;
|
||||||
|
--bg-primary:#111A20; --bg-secondary:#16222A; --bg-card:#18242C;
|
||||||
|
--text-primary:#E9EEF0; --text-secondary:#B4C2C7; --text-muted:#8B9AA1;
|
||||||
|
--border:#26343D; --border-strong:#35454F;
|
||||||
|
--brand:#5FC7BB; --brand-strong:#7BD6CC; --brand-bg:rgba(95,199,187,.14); --brand-on:#0A1418;
|
||||||
|
--action:#F08A72; --action-strong:#F5A492; --action-on:#241009;
|
||||||
|
--sand:#1B2730;
|
||||||
|
--shadow:0 1px 2px rgba(0,0,0,.3),0 1px 3px rgba(0,0,0,.25);
|
||||||
|
}
|
||||||
|
* { box-sizing:border-box; }
|
||||||
|
body {
|
||||||
|
margin:0; padding:32px 16px 80px; background:var(--bg-primary);
|
||||||
|
color:var(--text-primary); font:15px/1.55 var(--font-ui);
|
||||||
|
-webkit-font-smoothing:antialiased;
|
||||||
|
}
|
||||||
|
.page { max-width:960px; margin:0 auto; }
|
||||||
|
.page > header { margin-bottom:28px; display:flex; flex-wrap:wrap; gap:16px; align-items:flex-start; justify-content:space-between; }
|
||||||
|
.page > header h1 { font:700 25px/1.25 var(--font-display); letter-spacing:-.6px; margin:0 0 6px; }
|
||||||
|
.page > header p { margin:0; color:var(--text-muted); font-size:14px; max-width:60ch; }
|
||||||
|
.theme-switch { border:1px solid var(--border-strong); background:var(--bg-card); color:var(--text-secondary); border-radius:999px; padding:8px 14px; font:500 13px var(--font-ui); cursor:pointer; min-height:44px; }
|
||||||
|
.theme-switch:hover { border-color:var(--brand); color:var(--brand); }
|
||||||
|
|
||||||
|
/* ── The page context each variant is shown inside ─────────────────── */
|
||||||
|
.variant { margin-bottom:40px; }
|
||||||
|
.variant > .context { padding:0 4px 12px; }
|
||||||
|
.variant .eyebrow { margin:0 0 4px; font-size:12px; letter-spacing:.04em; text-transform:uppercase; color:var(--text-muted); }
|
||||||
|
.variant .context h2 { font:600 18px/1.35 var(--font-display); margin:0; color:var(--text-secondary); }
|
||||||
|
.variant .note { margin:10px 4px 0; font-size:12.5px; color:var(--text-muted); }
|
||||||
|
.variant .note b { color:var(--text-secondary); font-weight:600; }
|
||||||
|
|
||||||
|
/* ── The section itself — mirrors components/school/Section ────────── */
|
||||||
|
.card {
|
||||||
|
background:var(--bg-card); border:1px solid var(--border);
|
||||||
|
border-radius:var(--radius-lg); padding:28px; box-shadow:var(--shadow);
|
||||||
|
}
|
||||||
|
.top { display:flex; align-items:flex-start; justify-content:space-between; gap:16px; }
|
||||||
|
.top h2 { font:700 22px/1.25 var(--font-display); letter-spacing:-.4px; margin:0; }
|
||||||
|
.lede { margin:8px 0 20px; color:var(--text-secondary); font-size:14.5px; max-width:64ch; }
|
||||||
|
|
||||||
|
/* ── Carousel ───────────────────────────────────────────────────────
|
||||||
|
Every card is in the DOM and in the initial HTML — the arrows scroll a
|
||||||
|
list, they do not swap a view. That keeps all six links crawlable and
|
||||||
|
keeps the section usable with no JavaScript, where it degrades to a
|
||||||
|
plain horizontally scrollable row. */
|
||||||
|
.arrows { display:flex; gap:8px; flex:none; }
|
||||||
|
.arrow {
|
||||||
|
width:44px; height:44px; display:grid; place-items:center; cursor:pointer;
|
||||||
|
border:1px solid var(--border-strong); border-radius:999px;
|
||||||
|
background:var(--bg-card); color:var(--brand);
|
||||||
|
}
|
||||||
|
.arrow:hover:not(:disabled) { border-color:var(--brand); background:var(--brand-bg); }
|
||||||
|
.arrow:disabled { opacity:.35; cursor:default; }
|
||||||
|
.arrow:focus-visible { outline:2px solid var(--brand); outline-offset:2px; }
|
||||||
|
.arrow svg { width:17px; height:17px; }
|
||||||
|
|
||||||
|
.scroller {
|
||||||
|
display:grid; grid-auto-flow:column;
|
||||||
|
grid-auto-columns:calc((100% - 28px) / 3);
|
||||||
|
gap:14px; overflow-x:auto; scroll-snap-type:x mandatory;
|
||||||
|
padding:2px; margin:-2px; /* room for focus rings */
|
||||||
|
scrollbar-width:none; -ms-overflow-style:none;
|
||||||
|
list-style:none;
|
||||||
|
}
|
||||||
|
.scroller::-webkit-scrollbar { display:none; }
|
||||||
|
.scroller:focus-visible { outline:2px solid var(--brand); outline-offset:4px; border-radius:var(--radius-md); }
|
||||||
|
@media (max-width:820px) { .scroller { grid-auto-columns:calc((100% - 14px) / 2); } }
|
||||||
|
/* Touch widths: the arrows would squeeze the lede into a four-line column for a
|
||||||
|
control that swiping already provides, so they go and the documented
|
||||||
|
right-edge fade carries the affordance instead (MOBILE.md). The fade lifts at
|
||||||
|
the end of the travel, where there is nothing more to hint at. */
|
||||||
|
@media (max-width:640px) {
|
||||||
|
.top { display:block; }
|
||||||
|
.arrows { display:none; }
|
||||||
|
.scroller { grid-auto-columns:86%; mask-image:linear-gradient(to right, #000 calc(100% - 28px), transparent); }
|
||||||
|
.scroller[data-at-end=true] { mask-image:none; }
|
||||||
|
.card { padding:20px; }
|
||||||
|
}
|
||||||
|
|
||||||
|
.school {
|
||||||
|
position:relative; display:flex; flex-direction:column; scroll-snap-align:start;
|
||||||
|
border:1px solid var(--border); border-radius:var(--radius-md);
|
||||||
|
padding:16px; background:var(--bg-card);
|
||||||
|
}
|
||||||
|
.school:has(.add[aria-pressed=true]) { border-color:var(--brand); background:var(--brand-bg); }
|
||||||
|
.distance { display:flex; align-items:center; gap:5px; font-size:12px; color:var(--text-muted); margin:0 0 10px; }
|
||||||
|
.distance svg { width:13px; height:13px; flex:none; }
|
||||||
|
.school h3 { font:600 16px/1.35 var(--font-display); margin:0 0 6px; }
|
||||||
|
/* The whole card is the link target; the button sits above it on z-index so
|
||||||
|
it stays independently clickable. */
|
||||||
|
.school h3 a { color:var(--text-primary); text-decoration:none; }
|
||||||
|
.school h3 a::after { content:""; position:absolute; inset:0; border-radius:var(--radius-md); }
|
||||||
|
.school:hover { border-color:var(--border-strong); }
|
||||||
|
.school h3 a:hover { color:var(--brand); text-decoration:underline; }
|
||||||
|
.school h3 a:focus-visible { outline:none; }
|
||||||
|
.school:has(h3 a:focus-visible) { outline:2px solid var(--brand); outline-offset:2px; }
|
||||||
|
.meta { margin:0 0 12px; font-size:12.5px; color:var(--text-muted); }
|
||||||
|
.shared { display:flex; flex-wrap:wrap; gap:6px; margin:0 0 14px; padding:0; list-style:none; }
|
||||||
|
.shared li { font-size:11.5px; line-height:1.4; padding:4px 8px; border-radius:999px; background:var(--brand-bg); color:var(--brand); border:1px solid transparent; }
|
||||||
|
.shared li.loose { background:transparent; color:var(--text-muted); border-color:var(--border); }
|
||||||
|
.metric { margin-top:auto; padding-top:13px; border-top:1px solid var(--border); }
|
||||||
|
.value { font:700 26px/1.1 var(--font-display); letter-spacing:-.6px; margin:0; }
|
||||||
|
.value.absent { font-size:15px; font-weight:600; color:var(--text-muted); letter-spacing:0; }
|
||||||
|
.metric .label { margin:4px 0 0; font-size:12px; color:var(--text-secondary); }
|
||||||
|
.metric .ref { margin:2px 0 0; font-size:12px; color:var(--text-muted); }
|
||||||
|
.add {
|
||||||
|
position:relative; z-index:1; margin-top:14px; width:100%; min-height:44px;
|
||||||
|
font:500 13px var(--font-ui); cursor:pointer; border-radius:var(--radius-md);
|
||||||
|
border:1px solid var(--border-strong); background:var(--bg-card); color:var(--brand);
|
||||||
|
}
|
||||||
|
.add:hover { border-color:var(--brand); background:var(--brand-bg); }
|
||||||
|
.add[aria-pressed=true] { border-color:var(--brand); background:var(--brand-bg); font-weight:600; }
|
||||||
|
.add:focus-visible { outline:2px solid var(--brand); outline-offset:2px; }
|
||||||
|
|
||||||
|
.footer {
|
||||||
|
display:flex; flex-wrap:wrap; align-items:center; justify-content:space-between;
|
||||||
|
gap:14px; margin-top:20px; padding-top:18px; border-top:1px solid var(--border);
|
||||||
|
}
|
||||||
|
.footer p { margin:0; font-size:12.5px; color:var(--text-muted); }
|
||||||
|
.footer strong { display:block; font:600 14px var(--font-ui); color:var(--text-primary); }
|
||||||
|
/* Coral: the one decisive action in this section, and there is only one. */
|
||||||
|
.compare {
|
||||||
|
min-height:44px; padding:0 20px; border-radius:var(--radius-md); cursor:pointer;
|
||||||
|
font:600 14px var(--font-ui); background:var(--action); color:var(--action-on);
|
||||||
|
border:1px solid var(--action); text-decoration:none; display:inline-flex; align-items:center; gap:8px;
|
||||||
|
}
|
||||||
|
.compare:hover { background:var(--action-strong); border-color:var(--action-strong); }
|
||||||
|
.compare[aria-disabled=true] { opacity:.45; pointer-events:none; }
|
||||||
|
.caption { margin:16px 0 0; font-size:11.5px; color:var(--text-muted); }
|
||||||
|
.sr { position:absolute; width:1px; height:1px; padding:0; margin:-1px; overflow:hidden; clip:rect(0 0 0 0); white-space:nowrap; border:0; }
|
||||||
|
</style>
|
||||||
|
</head>
|
||||||
|
<body>
|
||||||
|
<div class="page">
|
||||||
|
<header>
|
||||||
|
<div>
|
||||||
|
<h1>Similar schools nearby</h1>
|
||||||
|
<p>A new section on the school detail page. Fictional schools and figures; shipped
|
||||||
|
colour, type and section shell taken from <code>globals.css</code>.</p>
|
||||||
|
</div>
|
||||||
|
<button class="theme-switch" type="button" id="theme">Dark theme</button>
|
||||||
|
</header>
|
||||||
|
<div id="variants"></div>
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<script>
|
||||||
|
const PIN = '<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true"><path d="M20 10c0 6-8 12-8 12s-8-6-8-12a8 8 0 0 1 16 0Z"/><circle cx="12" cy="10" r="3"/></svg>';
|
||||||
|
const CHEV = (dir) => `<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round" aria-hidden="true"><path d="${dir === 'prev' ? 'M15 18l-6-6 6-6' : 'M9 18l6-6-6-6'}"/></svg>`;
|
||||||
|
|
||||||
|
const variants = [
|
||||||
|
{
|
||||||
|
id: 'dense',
|
||||||
|
eyebrow: 'Variant 1 · Dense urban primary — six matches, carousel active',
|
||||||
|
context: 'Meadowbrook Primary School — Ages 4–11 · Mixed · No religious character · Community school',
|
||||||
|
lede: 'Other primary schools near Meadowbrook Primary School, with a similar intake.',
|
||||||
|
metric: 'Reading, writing & maths',
|
||||||
|
caption: 'Meeting the expected standard at key stage 2, 2025.',
|
||||||
|
thisValue: '72%',
|
||||||
|
note: 'Fourteen schools cleared <b>tier 1</b> within three miles, so the section takes the six nearest and stops there. The arrows scroll a list that is entirely in the HTML — all six links are crawlable, and with JavaScript off the row still scrolls.',
|
||||||
|
schools: [
|
||||||
|
{ name:'Willow Lane Primary School', distance:'0.4', meta:'Community school · Ages 4–11', shared:['Mixed','No religious character'], value:'74%' },
|
||||||
|
{ name:'Oakfield Primary School', distance:'0.6', meta:'Academy converter · Ages 3–11', shared:['Mixed','No religious character'], value:'69%' },
|
||||||
|
{ name:'Brookside Primary School', distance:'0.9', meta:'Community school · Ages 4–11', shared:['Mixed','No religious character'], value:'Not published' },
|
||||||
|
{ name:'Hollytree Primary School', distance:'1.3', meta:'Academy converter · Ages 4–11', shared:['Mixed','No religious character'], value:'81%' },
|
||||||
|
{ name:'Marsh Green Primary School', distance:'1.8', meta:'Community school · Ages 3–11', shared:['Mixed','No religious character'], value:'64%' },
|
||||||
|
{ name:'Kingsway Primary School', distance:'2.2', meta:'Foundation school · Ages 4–11', shared:['Mixed','No religious character'], value:'77%' },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: 'secondary',
|
||||||
|
eyebrow: 'Variant 2 · Secondary — four matches, mixed tiers',
|
||||||
|
context: 'Meadowbrook High School — Ages 11–18 · Mixed · Non-selective · Academy',
|
||||||
|
lede: 'Other secondary schools near Meadowbrook High School, with a similar intake.',
|
||||||
|
metric: 'Attainment 8',
|
||||||
|
caption: 'Average GCSE attainment score across eight qualifications, 2025.',
|
||||||
|
thisValue: '51.2',
|
||||||
|
note: 'Only two schools cleared tier 1, so the search widened to <b>tier 2</b> and found two more. It stops there rather than widening again to reach six — tiers relax to reach a usable set, never to fill the last slots. Selectivity never relaxes, so no grammar school can appear here.',
|
||||||
|
schools: [
|
||||||
|
{ name:'Rivermead High School', distance:'0.9', meta:'Academy converter · Ages 11–18', shared:['Mixed','Non-selective','No religious character'], value:'52.8' },
|
||||||
|
{ name:'Oakfield Academy', distance:'1.7', meta:'Academy sponsor led · Ages 11–16', shared:['Mixed','Non-selective','No religious character'], value:'49.6' },
|
||||||
|
{ name:'St Aidan’s Catholic High School', distance:'2.4', meta:'Voluntary aided · Ages 11–18', shared:['Mixed','Non-selective'], value:'53.4' },
|
||||||
|
{ name:'Parkside Community School', distance:'3.8', meta:'Community school · Ages 11–16', shared:['Mixed','Non-selective'], value:'50.9' },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
{
|
||||||
|
id: 'sparse',
|
||||||
|
eyebrow: 'Variant 3 · Rural — two matches, no arrows',
|
||||||
|
context: 'Little Ashby Church of England Primary School — Ages 4–11 · Mixed · Church of England · Voluntary controlled',
|
||||||
|
lede: 'Other primary schools near Little Ashby Church of England Primary School.',
|
||||||
|
metric: 'Reading, writing & maths',
|
||||||
|
caption: 'Meeting the expected standard at key stage 2, 2025.',
|
||||||
|
thisValue: '66%',
|
||||||
|
note: 'Nothing matched on religious character within range. At <b>tier 3</b> the lede drops the phrase “with a similar intake” and the chips fall back to the plain phase. Two cards fit the row, so the arrows are not rendered at all. One school fewer and the section would not render either.',
|
||||||
|
schools: [
|
||||||
|
{ name:'Great Marden Primary School', distance:'4.2', meta:'Community school · Ages 4–11', shared:['Primary school'], loose:true, value:'71%' },
|
||||||
|
{ name:'Ashby Vale Academy', distance:'7.8', meta:'Academy converter · Ages 4–11', shared:['Primary school'], loose:true, value:'58%' },
|
||||||
|
],
|
||||||
|
},
|
||||||
|
];
|
||||||
|
|
||||||
|
const selected = Object.fromEntries(variants.map((v) => [v.id, new Set()]));
|
||||||
|
|
||||||
|
function card(v, s, i) {
|
||||||
|
const on = selected[v.id].has(i);
|
||||||
|
const absent = s.value === 'Not published';
|
||||||
|
return `
|
||||||
|
<li class="school">
|
||||||
|
<p class="distance">${PIN}${s.distance} miles away</p>
|
||||||
|
<h3><a href="#">${s.name}</a></h3>
|
||||||
|
<p class="meta">${s.meta}</p>
|
||||||
|
<ul class="shared">${s.shared.map((c) => `<li class="${s.loose ? 'loose' : ''}">${c}</li>`).join('')}</ul>
|
||||||
|
<div class="metric">
|
||||||
|
<p class="value ${absent ? 'absent' : ''}">${s.value}</p>
|
||||||
|
<p class="label">${v.metric}</p>
|
||||||
|
<p class="ref">${v.thisValue} at this school</p>
|
||||||
|
</div>
|
||||||
|
<button class="add" type="button" data-variant="${v.id}" data-index="${i}" aria-pressed="${on}">
|
||||||
|
${on ? '✓ Added to compare' : '+ Add to compare'}<span class="sr"> — ${s.name}</span>
|
||||||
|
</button>
|
||||||
|
</li>`;
|
||||||
|
}
|
||||||
|
|
||||||
|
function render() {
|
||||||
|
document.getElementById('variants').innerHTML = variants.map((v) => {
|
||||||
|
const count = selected[v.id].size;
|
||||||
|
// Three fit the row, so anything more is what the arrows are for.
|
||||||
|
const scrollable = v.schools.length > 3;
|
||||||
|
return `
|
||||||
|
<section class="variant">
|
||||||
|
<div class="context">
|
||||||
|
<p class="eyebrow">${v.eyebrow}</p>
|
||||||
|
<h2>${v.context}</h2>
|
||||||
|
</div>
|
||||||
|
<div class="card">
|
||||||
|
<div class="top">
|
||||||
|
<div>
|
||||||
|
<h2 id="h-${v.id}">Similar schools nearby</h2>
|
||||||
|
<p class="lede">${v.lede}</p>
|
||||||
|
</div>
|
||||||
|
${scrollable ? `<div class="arrows">
|
||||||
|
<button class="arrow" type="button" data-scroll="prev" data-variant="${v.id}" aria-label="Previous schools" aria-controls="sc-${v.id}">${CHEV('prev')}</button>
|
||||||
|
<button class="arrow" type="button" data-scroll="next" data-variant="${v.id}" aria-label="More schools" aria-controls="sc-${v.id}">${CHEV('next')}</button>
|
||||||
|
</div>` : ''}
|
||||||
|
</div>
|
||||||
|
|
||||||
|
<ul class="scroller" id="sc-${v.id}" ${scrollable ? `tabindex="0" role="group" aria-labelledby="h-${v.id}"` : ''}>
|
||||||
|
${v.schools.map((s, i) => card(v, s, i)).join('')}
|
||||||
|
</ul>
|
||||||
|
|
||||||
|
<div class="footer">
|
||||||
|
<p aria-live="polite">
|
||||||
|
<strong>${count ? `${count} school${count === 1 ? '' : 's'} selected` : 'Compare side by side'}</strong>
|
||||||
|
${count ? 'This school is included automatically.' : 'Add a school to compare it with this one.'}
|
||||||
|
</p>
|
||||||
|
<a class="compare" href="#" aria-disabled="${count ? 'false' : 'true'}">
|
||||||
|
${count ? `Compare ${count + 1} schools` : 'Compare'} →
|
||||||
|
</a>
|
||||||
|
</div>
|
||||||
|
<p class="caption">Distances are straight-line from this school, not road distance.
|
||||||
|
${v.caption} Fictional schools and figures for this mockup.</p>
|
||||||
|
</div>
|
||||||
|
<p class="note">${v.note}</p>
|
||||||
|
</section>`;
|
||||||
|
}).join('');
|
||||||
|
|
||||||
|
variants.forEach((v) => {
|
||||||
|
const scroller = document.getElementById(`sc-${v.id}`);
|
||||||
|
if (scroller) syncArrows(v.id, scroller);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
/** An arrow that scrolls nowhere is a dead control, so each end disables its own.
|
||||||
|
*
|
||||||
|
* EDGE is not paranoia. The scroller carries 2px of padding so focus rings are
|
||||||
|
* not clipped, and scroll-snap treats that padding as the first card's snap
|
||||||
|
* position — so a scroller sitting at its start reports scrollLeft 2, not 0.
|
||||||
|
* Sub-pixel rounding at other zoom levels moves it again. Testing against an
|
||||||
|
* exact 0 leaves the back arrow live at the start, pointing nowhere. */
|
||||||
|
const EDGE = 8;
|
||||||
|
|
||||||
|
function syncArrows(id, scroller) {
|
||||||
|
const max = scroller.scrollWidth - scroller.clientWidth;
|
||||||
|
const atStart = scroller.scrollLeft <= EDGE;
|
||||||
|
const atEnd = scroller.scrollLeft >= max - EDGE;
|
||||||
|
|
||||||
|
// Drives the mobile scroll-fade, so it is computed even where no arrow is
|
||||||
|
// rendered to consume it.
|
||||||
|
scroller.dataset.atEnd = String(atEnd);
|
||||||
|
|
||||||
|
const prev = document.querySelector(`.arrow[data-scroll="prev"][data-variant="${id}"]`);
|
||||||
|
const next = document.querySelector(`.arrow[data-scroll="next"][data-variant="${id}"]`);
|
||||||
|
if (!prev || !next) return;
|
||||||
|
prev.disabled = atStart;
|
||||||
|
next.disabled = atEnd;
|
||||||
|
}
|
||||||
|
|
||||||
|
document.getElementById('variants').addEventListener('click', (event) => {
|
||||||
|
const arrow = event.target.closest('.arrow');
|
||||||
|
if (arrow) {
|
||||||
|
const scroller = document.getElementById(`sc-${arrow.dataset.variant}`);
|
||||||
|
// A page is what the reader can see, so the viewport is the step.
|
||||||
|
scroller.scrollBy({ left: (arrow.dataset.scroll === 'next' ? 1 : -1) * scroller.clientWidth, behavior: 'smooth' });
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
const button = event.target.closest('.add');
|
||||||
|
if (!button) return;
|
||||||
|
const { variant, index } = button.dataset;
|
||||||
|
const set = selected[variant];
|
||||||
|
const i = Number(index);
|
||||||
|
// Scroll position is DOM state, not React state; keep it across the re-render.
|
||||||
|
const offset = document.getElementById(`sc-${variant}`).scrollLeft;
|
||||||
|
set.has(i) ? set.delete(i) : set.add(i);
|
||||||
|
render();
|
||||||
|
const scroller = document.getElementById(`sc-${variant}`);
|
||||||
|
scroller.scrollLeft = offset;
|
||||||
|
syncArrows(variant, scroller);
|
||||||
|
document.querySelector(`.add[data-variant="${variant}"][data-index="${index}"]`).focus();
|
||||||
|
}, true);
|
||||||
|
|
||||||
|
document.getElementById('variants').addEventListener('scroll', (event) => {
|
||||||
|
const scroller = event.target.closest('.scroller');
|
||||||
|
if (scroller) syncArrows(scroller.id.replace('sc-', ''), scroller);
|
||||||
|
}, true);
|
||||||
|
|
||||||
|
const themeButton = document.getElementById('theme');
|
||||||
|
themeButton.addEventListener('click', () => {
|
||||||
|
const dark = document.documentElement.dataset.theme === 'dark';
|
||||||
|
document.documentElement.dataset.theme = dark ? 'light' : 'dark';
|
||||||
|
themeButton.textContent = dark ? 'Dark theme' : 'Light theme';
|
||||||
|
});
|
||||||
|
|
||||||
|
render();
|
||||||
|
</script>
|
||||||
|
</body>
|
||||||
|
</html>
|
||||||
+12
-4
@@ -1,8 +1,16 @@
|
|||||||
# API Configuration
|
# Browser requests use the same-origin Next.js proxy.
|
||||||
NEXT_PUBLIC_API_URL=http://localhost:8000/api
|
NEXT_PUBLIC_API_URL=/api
|
||||||
|
|
||||||
# Production API URL (for deployment)
|
# Absolute URL for server-side fetching and the proxy; include /api.
|
||||||
# NEXT_PUBLIC_API_URL=https://api.schoolcompare.co.uk/api
|
# In the managed container network this is http://backend:80/api (staging differs).
|
||||||
|
FASTAPI_URL=http://localhost:8000/api
|
||||||
|
|
||||||
|
# Payload CMS runtime configuration. Use the managed environment's database;
|
||||||
|
# Payload owns the payload schema, independently of the school marts.
|
||||||
|
DATABASE_URL=postgresql://schoolcompare:CHANGE_THIS_PASSWORD@localhost:5432/schoolcompare
|
||||||
|
# Generate a secret: python -c "import secrets; print(secrets.token_urlsafe(32))"
|
||||||
|
# Use distinct secrets for staging and production.
|
||||||
|
PAYLOAD_SECRET=CHANGE_THIS_TO_A_SECURE_RANDOM_SECRET
|
||||||
|
|
||||||
# Node Environment
|
# Node Environment
|
||||||
NODE_ENV=development
|
NODE_ENV=development
|
||||||
+12
-288
@@ -1,291 +1,15 @@
|
|||||||
# Deployment Guide
|
# Frontend deployment
|
||||||
|
|
||||||
This guide covers deployment options for the SchoolCompare Next.js application.
|
Next.js and Payload run in the same frontend container. The maintained deployment
|
||||||
|
procedure is [docs/DEPLOY.md](../docs/DEPLOY.md), with the production and staging
|
||||||
|
Portainer compose files at the repository root.
|
||||||
|
|
||||||
## Deployment Options
|
The frontend Dockerfile builds a standalone Next.js image. Runtime configuration
|
||||||
|
supplies `FASTAPI_URL`, `DATABASE_URL` and `PAYLOAD_SECRET`; uploaded CMS media is
|
||||||
|
persisted in a volume. Promote the built image through the repository's Gitea
|
||||||
|
workflow after human staging approval.
|
||||||
|
|
||||||
### Option 1: Vercel (Recommended for Next.js)
|
Earlier Vercel and standalone deployment recipes have been retired from this file
|
||||||
|
because they do not describe the current CMS, persistence and promotion setup.
|
||||||
Vercel is the easiest and most optimized platform for Next.js applications.
|
See [development](../docs/DEVELOPMENT.md) for checks and
|
||||||
|
[publishing](docs/PUBLISHING.md) for CMS operations.
|
||||||
#### Steps:
|
|
||||||
|
|
||||||
1. **Install Vercel CLI**:
|
|
||||||
```bash
|
|
||||||
npm install -g vercel
|
|
||||||
```
|
|
||||||
|
|
||||||
2. **Login to Vercel**:
|
|
||||||
```bash
|
|
||||||
vercel login
|
|
||||||
```
|
|
||||||
|
|
||||||
3. **Deploy**:
|
|
||||||
```bash
|
|
||||||
vercel --prod
|
|
||||||
```
|
|
||||||
|
|
||||||
4. **Configure Environment Variables** in Vercel dashboard:
|
|
||||||
- `NEXT_PUBLIC_API_URL`: Your FastAPI endpoint (e.g., `https://api.schoolcompare.co.uk/api`)
|
|
||||||
- `FASTAPI_URL`: Same as above for server-side requests
|
|
||||||
|
|
||||||
#### Benefits:
|
|
||||||
- Automatic HTTPS
|
|
||||||
- Global CDN
|
|
||||||
- Zero-config deployment
|
|
||||||
- Automatic preview deployments
|
|
||||||
- Built-in analytics
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
### Option 2: Docker (Self-hosted)
|
|
||||||
|
|
||||||
Deploy using Docker containers for full control.
|
|
||||||
|
|
||||||
#### Prerequisites:
|
|
||||||
- Docker 20+
|
|
||||||
- Docker Compose 2+
|
|
||||||
|
|
||||||
#### Steps:
|
|
||||||
|
|
||||||
1. **Build Docker Image**:
|
|
||||||
```bash
|
|
||||||
docker build -t schoolcompare-nextjs:latest .
|
|
||||||
```
|
|
||||||
|
|
||||||
2. **Run with Docker Compose**:
|
|
||||||
```bash
|
|
||||||
# Create .env file with production variables
|
|
||||||
echo "NEXT_PUBLIC_API_URL=https://api.schoolcompare.co.uk/api" > .env
|
|
||||||
echo "FASTAPI_URL=http://backend:8000/api" >> .env
|
|
||||||
|
|
||||||
# Start services
|
|
||||||
docker-compose up -d
|
|
||||||
```
|
|
||||||
|
|
||||||
3. **Verify Deployment**:
|
|
||||||
```bash
|
|
||||||
curl http://localhost:3000
|
|
||||||
```
|
|
||||||
|
|
||||||
#### Environment Variables:
|
|
||||||
- `NEXT_PUBLIC_API_URL`: Public API endpoint (client-side)
|
|
||||||
- `FASTAPI_URL`: Internal API endpoint (server-side)
|
|
||||||
- `NODE_ENV`: `production`
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
### Option 3: PM2 (Node.js Process Manager)
|
|
||||||
|
|
||||||
Deploy directly on a Node.js server using PM2.
|
|
||||||
|
|
||||||
#### Prerequisites:
|
|
||||||
- Node.js 24+
|
|
||||||
- PM2 (`npm install -g pm2`)
|
|
||||||
|
|
||||||
#### Steps:
|
|
||||||
|
|
||||||
1. **Build Application**:
|
|
||||||
```bash
|
|
||||||
npm run build
|
|
||||||
```
|
|
||||||
|
|
||||||
2. **Create PM2 Ecosystem File** (`ecosystem.config.js`):
|
|
||||||
```javascript
|
|
||||||
module.exports = {
|
|
||||||
apps: [{
|
|
||||||
name: 'schoolcompare-nextjs',
|
|
||||||
script: 'npm',
|
|
||||||
args: 'start',
|
|
||||||
cwd: '/path/to/nextjs-app',
|
|
||||||
instances: 'max',
|
|
||||||
exec_mode: 'cluster',
|
|
||||||
env: {
|
|
||||||
NODE_ENV: 'production',
|
|
||||||
PORT: 3000,
|
|
||||||
NEXT_PUBLIC_API_URL: 'https://api.schoolcompare.co.uk/api',
|
|
||||||
FASTAPI_URL: 'http://localhost:8000/api',
|
|
||||||
},
|
|
||||||
}],
|
|
||||||
};
|
|
||||||
```
|
|
||||||
|
|
||||||
3. **Start with PM2**:
|
|
||||||
```bash
|
|
||||||
pm2 start ecosystem.config.js
|
|
||||||
pm2 save
|
|
||||||
pm2 startup
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
### Option 4: Nginx Reverse Proxy
|
|
||||||
|
|
||||||
Use Nginx as a reverse proxy in front of Next.js.
|
|
||||||
|
|
||||||
#### Nginx Configuration:
|
|
||||||
|
|
||||||
```nginx
|
|
||||||
server {
|
|
||||||
listen 80;
|
|
||||||
server_name schoolcompare.co.uk;
|
|
||||||
|
|
||||||
# Redirect to HTTPS
|
|
||||||
return 301 https://$server_name$request_uri;
|
|
||||||
}
|
|
||||||
|
|
||||||
server {
|
|
||||||
listen 443 ssl http2;
|
|
||||||
server_name schoolcompare.co.uk;
|
|
||||||
|
|
||||||
# SSL Configuration
|
|
||||||
ssl_certificate /etc/ssl/certs/schoolcompare.crt;
|
|
||||||
ssl_certificate_key /etc/ssl/private/schoolcompare.key;
|
|
||||||
|
|
||||||
# Security Headers
|
|
||||||
# frame-ancestors replaces X-Frame-Options so the analytics subdomain
|
|
||||||
# (Umami heatmap/recorder) can embed the site in an iframe.
|
|
||||||
add_header Content-Security-Policy "frame-ancestors 'self' https://analytics.schoolcompare.co.uk" always;
|
|
||||||
add_header X-Content-Type-Options "nosniff" always;
|
|
||||||
add_header X-XSS-Protection "1; mode=block" always;
|
|
||||||
|
|
||||||
# Proxy to Next.js
|
|
||||||
location / {
|
|
||||||
proxy_pass http://localhost:3000;
|
|
||||||
proxy_http_version 1.1;
|
|
||||||
proxy_set_header Upgrade $http_upgrade;
|
|
||||||
proxy_set_header Connection 'upgrade';
|
|
||||||
proxy_set_header Host $host;
|
|
||||||
proxy_cache_bypass $http_upgrade;
|
|
||||||
proxy_set_header X-Real-IP $remote_addr;
|
|
||||||
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
|
|
||||||
proxy_set_header X-Forwarded-Proto $scheme;
|
|
||||||
}
|
|
||||||
|
|
||||||
# Proxy to FastAPI
|
|
||||||
location /api/ {
|
|
||||||
proxy_pass http://localhost:8000;
|
|
||||||
proxy_http_version 1.1;
|
|
||||||
proxy_set_header Host $host;
|
|
||||||
proxy_set_header X-Real-IP $remote_addr;
|
|
||||||
proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
|
|
||||||
proxy_set_header X-Forwarded-Proto $scheme;
|
|
||||||
}
|
|
||||||
|
|
||||||
# Cache static files
|
|
||||||
location /_next/static/ {
|
|
||||||
proxy_pass http://localhost:3000;
|
|
||||||
add_header Cache-Control "public, max-age=31536000, immutable";
|
|
||||||
}
|
|
||||||
}
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Pre-Deployment Checklist
|
|
||||||
|
|
||||||
- [ ] Run `npm run build` successfully
|
|
||||||
- [ ] Run `npm test` - all tests pass
|
|
||||||
- [ ] Environment variables configured
|
|
||||||
- [ ] FastAPI backend accessible
|
|
||||||
- [ ] Database migrations applied
|
|
||||||
- [ ] SSL certificates configured (production)
|
|
||||||
- [ ] Domain DNS configured
|
|
||||||
- [ ] Monitoring/logging set up
|
|
||||||
- [ ] Backup strategy in place
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Post-Deployment Verification
|
|
||||||
|
|
||||||
1. **Health Check**:
|
|
||||||
```bash
|
|
||||||
curl https://schoolcompare.co.uk
|
|
||||||
```
|
|
||||||
|
|
||||||
2. **Test Routes**:
|
|
||||||
- Home: `https://schoolcompare.co.uk/`
|
|
||||||
- School Page: `https://schoolcompare.co.uk/school/100001`
|
|
||||||
- Compare: `https://schoolcompare.co.uk/compare`
|
|
||||||
- Rankings: `https://schoolcompare.co.uk/rankings`
|
|
||||||
|
|
||||||
3. **Check SEO**:
|
|
||||||
- Sitemap: `https://schoolcompare.co.uk/sitemap.xml`
|
|
||||||
- Robots: `https://schoolcompare.co.uk/robots.txt`
|
|
||||||
|
|
||||||
4. **Performance Audit**:
|
|
||||||
- Run Lighthouse in Chrome DevTools
|
|
||||||
- Target scores: 90+ for Performance, Accessibility, Best Practices, SEO
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Monitoring
|
|
||||||
|
|
||||||
### Recommended Tools:
|
|
||||||
- **Vercel Analytics** (if using Vercel)
|
|
||||||
- **Sentry** for error tracking
|
|
||||||
- **Google Analytics** for user analytics
|
|
||||||
- **Uptime Robot** for uptime monitoring
|
|
||||||
|
|
||||||
### Health Check Endpoint:
|
|
||||||
The application automatically serves health data at the root route.
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Rollback Procedure
|
|
||||||
|
|
||||||
### Vercel:
|
|
||||||
```bash
|
|
||||||
vercel rollback
|
|
||||||
```
|
|
||||||
|
|
||||||
### Docker:
|
|
||||||
```bash
|
|
||||||
docker-compose down
|
|
||||||
docker-compose up -d --force-recreate
|
|
||||||
```
|
|
||||||
|
|
||||||
### PM2:
|
|
||||||
```bash
|
|
||||||
pm2 stop schoolcompare-nextjs
|
|
||||||
# Restore previous build
|
|
||||||
pm2 start schoolcompare-nextjs
|
|
||||||
```
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Troubleshooting
|
|
||||||
|
|
||||||
### Issue: API requests failing
|
|
||||||
- **Solution**: Check `NEXT_PUBLIC_API_URL` and `FASTAPI_URL` environment variables
|
|
||||||
- **Verify**: FastAPI backend is accessible from Next.js container/server
|
|
||||||
|
|
||||||
### Issue: Build fails
|
|
||||||
- **Solution**: Check Node.js version (requires 24+)
|
|
||||||
- **Clear cache**: `rm -rf .next node_modules && npm install && npm run build`
|
|
||||||
|
|
||||||
### Issue: Slow page loads
|
|
||||||
- **Solution**: Enable caching in API calls
|
|
||||||
- **Check**: Network latency to FastAPI backend
|
|
||||||
- **Verify**: CDN is serving static assets
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Security Considerations
|
|
||||||
|
|
||||||
- ✅ HTTPS enabled
|
|
||||||
- ✅ Security headers configured (X-Frame-Options, CSP, etc.)
|
|
||||||
- ✅ API keys in environment variables (never in code)
|
|
||||||
- ✅ CORS properly configured
|
|
||||||
- ✅ Rate limiting on API endpoints
|
|
||||||
- ✅ Regular security updates
|
|
||||||
- ✅ Dependency vulnerability scanning
|
|
||||||
|
|
||||||
---
|
|
||||||
|
|
||||||
## Support
|
|
||||||
|
|
||||||
For deployment issues, contact the DevOps team or refer to:
|
|
||||||
- [Next.js Deployment Docs](https://nextjs.org/docs/deployment)
|
|
||||||
- [Vercel Documentation](https://vercel.com/docs)
|
|
||||||
- [Docker Documentation](https://docs.docker.com/)
|
|
||||||
@@ -28,6 +28,10 @@ ENV NODE_ENV=production
|
|||||||
ARG FASTAPI_URL=http://backend:80/api
|
ARG FASTAPI_URL=http://backend:80/api
|
||||||
ENV FASTAPI_URL=${FASTAPI_URL}
|
ENV FASTAPI_URL=${FASTAPI_URL}
|
||||||
|
|
||||||
|
ARG BUILD_SHA=development
|
||||||
|
ARG BUILD_ID=development
|
||||||
|
RUN node -e 'require("fs").writeFileSync("build-info.json", JSON.stringify({sha:process.argv[1],build_id:process.argv[2]}))' "$BUILD_SHA" "$BUILD_ID"
|
||||||
|
|
||||||
# Build application
|
# Build application
|
||||||
RUN npm run build
|
RUN npm run build
|
||||||
|
|
||||||
@@ -70,6 +74,12 @@ USER nextjs
|
|||||||
EXPOSE 3000
|
EXPOSE 3000
|
||||||
|
|
||||||
# Set environment variables
|
# Set environment variables
|
||||||
|
ARG BUILD_SHA=development
|
||||||
|
ARG BUILD_ID=development
|
||||||
|
LABEL io.schoolcompare.build-id=$BUILD_ID
|
||||||
|
LABEL io.schoolcompare.commit=$BUILD_SHA
|
||||||
|
COPY --from=builder /app/build-info.json ./build-info.json
|
||||||
|
|
||||||
ENV PORT=3000
|
ENV PORT=3000
|
||||||
ENV HOSTNAME="0.0.0.0"
|
ENV HOSTNAME="0.0.0.0"
|
||||||
|
|
||||||
|
|||||||
+43
-141
@@ -1,156 +1,58 @@
|
|||||||
# SchoolCompare Next.js Application
|
# SchoolCompare frontend and CMS
|
||||||
|
|
||||||
Modern Next.js application for comparing primary school KS2 performance across England.
|
Next.js App Router with React, TypeScript, CSS Modules, Chart.js, Leaflet and
|
||||||
|
Payload CMS. It serves school search, comparisons, rankings, school/place detail
|
||||||
|
pages and editorial content across England.
|
||||||
|
|
||||||
## Features
|
Start with the [repository overview](../README.md),
|
||||||
|
[architecture](../docs/ARCHITECTURE.md) and [development checks](../docs/DEVELOPMENT.md).
|
||||||
|
|
||||||
- **Server-Side Rendering (SSR)**: Fast initial page loads with pre-rendered content
|
## Source map
|
||||||
- **Individual School Pages**: Dedicated pages for each school with full SEO optimization
|
|
||||||
- **Side-by-Side Comparison**: Compare up to 5 schools simultaneously
|
|
||||||
- **School Rankings**: Top-performing schools by various metrics
|
|
||||||
- **Interactive Maps**: Leaflet integration for geographic visualization
|
|
||||||
- **Performance Charts**: Chart.js visualizations for historical data
|
|
||||||
- **Responsive Design**: Mobile-first approach with full responsive support
|
|
||||||
- **SEO Optimized**: Dynamic sitemaps, meta tags, and structured data
|
|
||||||
|
|
||||||
## Tech Stack
|
| Path | Purpose |
|
||||||
|
|---|---|
|
||||||
|
| `app/(frontend)/` | Public root layout, server pages and FastAPI proxy |
|
||||||
|
| `app/(payload)/` | Payload root layout, `/admin` and `/cms-api` |
|
||||||
|
| `app/robots.ts`, `app/opengraph-image.tsx`, root icons | Site-wide metadata endpoints |
|
||||||
|
| `components/` | Client views and reusable display components |
|
||||||
|
| `components/school/` | School detail sections |
|
||||||
|
| `lib/api.ts`, `lib/types.ts` | Fetch wrappers and manual school API types |
|
||||||
|
| `lib/schoolSections.ts`, `lib/compareLogic.ts` | Presentation decisions and data preparation |
|
||||||
|
| `context/`, `hooks/` | Comparison state, suggestion state and responsive behaviour |
|
||||||
|
| `collections/`, `blocks/`, `migrations/` | CMS schema and production migrations |
|
||||||
|
| `__tests__/` | Jest and React Testing Library tests |
|
||||||
|
|
||||||
- **Framework**: Next.js 16 (App Router)
|
Do not introduce a shared `app/layout.tsx`: public pages and Payload have separate
|
||||||
- **Language**: TypeScript 5
|
root layouts. Keep root metadata files outside the route groups.
|
||||||
- **Styling**: CSS Modules + CSS Variables
|
|
||||||
- **State Management**: React Context API + URL state
|
|
||||||
- **Data Fetching**: SWR (client-side) + Next.js fetch (server-side)
|
|
||||||
- **Charts**: Chart.js + react-chartjs-2
|
|
||||||
- **Maps**: Leaflet + react-leaflet
|
|
||||||
- **Testing**: Jest + React Testing Library
|
|
||||||
- **Validation**: Zod
|
|
||||||
|
|
||||||
## Getting Started
|
## Data and state
|
||||||
|
|
||||||
### Prerequisites
|
Server pages fetch initial data directly from `FASTAPI_URL`. Browser fetches use
|
||||||
|
`/api` by default, forwarded by `app/(frontend)/api/[...path]/route.ts`.
|
||||||
|
`FASTAPI_URL` must include `/api`. See `.env.example` for CMS and API settings.
|
||||||
|
|
||||||
- Node.js 24+ (using nvm recommended)
|
State uses React hooks/context, URL search parameters and localStorage for the
|
||||||
- FastAPI backend running on port 8000
|
comparison basket. SWR is not installed. Maps use dynamic Leaflet wrappers.
|
||||||
|
Revalidation intervals are configured in fetch wrappers and pages; they vary by
|
||||||
|
resource. Backend reloads do not automatically invalidate every Next.js cache.
|
||||||
|
|
||||||
### Installation
|
## Commands
|
||||||
|
|
||||||
```bash
|
```sh
|
||||||
# Install dependencies
|
npm ci
|
||||||
npm install
|
npm run typecheck
|
||||||
|
npm test -- --runInBand
|
||||||
# Copy environment variables
|
|
||||||
cp .env.example .env.local
|
|
||||||
|
|
||||||
# Update .env.local with your configuration
|
|
||||||
```
|
|
||||||
|
|
||||||
### Development
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Start development server
|
|
||||||
npm run dev
|
|
||||||
|
|
||||||
# Open http://localhost:3000
|
|
||||||
```
|
|
||||||
|
|
||||||
### Building
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Build for production
|
|
||||||
npm run build
|
npm run build
|
||||||
|
|
||||||
# Start production server
|
|
||||||
npm start
|
|
||||||
```
|
```
|
||||||
|
|
||||||
### Testing
|
`test:watch` and `test:coverage` are also available. There is no `lint` script.
|
||||||
|
A running application needs the backend/data environment described in the
|
||||||
|
[development guide](../docs/DEVELOPMENT.md).
|
||||||
|
|
||||||
```bash
|
After CMS field or editor changes, run `npm run generate:importmap`. Keep
|
||||||
# Run tests
|
`payload-types.ts` generated from the CMS schema rather than editing it by hand.
|
||||||
npm test
|
The build must work without a database connection; avoid module-scope CMS queries
|
||||||
|
and DB-backed `generateStaticParams` functions.
|
||||||
|
|
||||||
# Run tests in watch mode
|
See [publishing](docs/PUBLISHING.md) for CMS operations and
|
||||||
npm run test:watch
|
[deployment](../docs/DEPLOY.md) for staging and production promotion.
|
||||||
|
|
||||||
# Run tests with coverage
|
|
||||||
npm run test:coverage
|
|
||||||
```
|
|
||||||
|
|
||||||
### Linting
|
|
||||||
|
|
||||||
```bash
|
|
||||||
# Run ESLint
|
|
||||||
npm run lint
|
|
||||||
```
|
|
||||||
|
|
||||||
## Project Structure
|
|
||||||
|
|
||||||
```
|
|
||||||
nextjs-app/
|
|
||||||
├── app/ # App Router pages
|
|
||||||
│ ├── layout.tsx # Root layout
|
|
||||||
│ ├── page.tsx # Home page
|
|
||||||
│ ├── compare/ # Compare page
|
|
||||||
│ ├── rankings/ # Rankings page
|
|
||||||
│ ├── school/[urn]/ # Individual school pages
|
|
||||||
│ ├── sitemap.ts # Dynamic sitemap
|
|
||||||
│ └── robots.ts # Robots.txt
|
|
||||||
├── components/ # React components
|
|
||||||
│ ├── SchoolCard.tsx # School card component
|
|
||||||
│ ├── FilterBar.tsx # Search/filter controls
|
|
||||||
│ ├── ComparisonView.tsx # Comparison interface
|
|
||||||
│ ├── RankingsView.tsx # Rankings table
|
|
||||||
│ └── ...
|
|
||||||
├── lib/ # Utility libraries
|
|
||||||
│ ├── api.ts # API client
|
|
||||||
│ ├── types.ts # TypeScript types
|
|
||||||
│ └── utils.ts # Helper functions
|
|
||||||
├── hooks/ # Custom React hooks
|
|
||||||
├── context/ # React Context providers
|
|
||||||
├── styles/ # Global styles
|
|
||||||
├── public/ # Static assets
|
|
||||||
└── __tests__/ # Test files
|
|
||||||
```
|
|
||||||
|
|
||||||
## Environment Variables
|
|
||||||
|
|
||||||
| Variable | Description | Default |
|
|
||||||
|----------|-------------|---------|
|
|
||||||
| `NEXT_PUBLIC_API_URL` | Public API endpoint (client-side) | `http://localhost:8000/api` |
|
|
||||||
| `FASTAPI_URL` | Server-side API endpoint | `http://localhost:8000/api` |
|
|
||||||
| `NODE_ENV` | Environment mode | `development` |
|
|
||||||
|
|
||||||
## Performance Optimizations
|
|
||||||
|
|
||||||
- **Server-Side Rendering**: Initial HTML rendered on server
|
|
||||||
- **Static Generation**: Where possible, pages are pre-generated
|
|
||||||
- **Image Optimization**: Next.js Image component with AVIF/WebP support
|
|
||||||
- **Code Splitting**: Automatic route-based code splitting
|
|
||||||
- **Dynamic Imports**: Heavy components loaded on demand
|
|
||||||
- **API Caching**: Configurable revalidation for data fetching
|
|
||||||
- **Bundle Optimization**: Tree shaking and minification
|
|
||||||
- **Compression**: Gzip compression enabled
|
|
||||||
|
|
||||||
## SEO Features
|
|
||||||
|
|
||||||
- **Dynamic Meta Tags**: Generated per page with Next.js Metadata API
|
|
||||||
- **Open Graph**: Social media optimization
|
|
||||||
- **JSON-LD**: Structured data for search engines
|
|
||||||
- **Sitemap**: Auto-generated from database
|
|
||||||
- **Robots.txt**: Search engine crawling rules
|
|
||||||
- **Canonical URLs**: Duplicate content prevention
|
|
||||||
|
|
||||||
## Browser Support
|
|
||||||
|
|
||||||
- Chrome (latest)
|
|
||||||
- Firefox (latest)
|
|
||||||
- Safari (latest)
|
|
||||||
- Edge (latest)
|
|
||||||
|
|
||||||
## License
|
|
||||||
|
|
||||||
Proprietary - SchoolCompare
|
|
||||||
|
|
||||||
## Support
|
|
||||||
|
|
||||||
For issues and questions, please contact the development team.
|
|
||||||
@@ -27,14 +27,27 @@ describe('BlogPosting structured data', () => {
|
|||||||
it('names the same Person entity the about page declares', () => {
|
it('names the same Person entity the about page declares', () => {
|
||||||
// By @id, not by repeating the person: search engines must resolve every
|
// By @id, not by repeating the person: search engines must resolve every
|
||||||
// post and the about page to one author entity, or the site has several.
|
// post and the about page to one author entity, or the site has several.
|
||||||
const ld = blogPostingJsonLd(post);
|
const ld = blogPostingJsonLd(post, { namedAuthor: true });
|
||||||
expect(ld['@type']).toBe('BlogPosting');
|
expect(ld['@type']).toBe('BlogPosting');
|
||||||
expect(ld.author['@id']).toBe('https://www.schoolcompare.co.uk/about#tudor');
|
expect(ld.author['@id']).toBe('https://www.schoolcompare.co.uk/about#tudor');
|
||||||
expect(ld.publisher['@id']).toBe('https://www.schoolcompare.co.uk#organization');
|
expect(ld.publisher['@id']).toBe('https://www.schoolcompare.co.uk#organization');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('attributes to the organization when the about page is dark', () => {
|
||||||
|
/*
|
||||||
|
* The two flags are independent, so blog-on-about-off is a reachable
|
||||||
|
* state. The Person entity lives at /about#tudor and that URL 404s while
|
||||||
|
* the flag is dark, so claiming it would declare an author that resolves
|
||||||
|
* to nothing — worse for the blog's credibility than having no named
|
||||||
|
* author at all. Attribute to the publisher instead.
|
||||||
|
*/
|
||||||
|
const ld = blogPostingJsonLd(post, { namedAuthor: false });
|
||||||
|
expect(ld.author['@id']).toBe('https://www.schoolcompare.co.uk#organization');
|
||||||
|
expect(JSON.stringify(ld)).not.toContain('/about');
|
||||||
|
});
|
||||||
|
|
||||||
it('carries a self-referencing canonical url and the publish date', () => {
|
it('carries a self-referencing canonical url and the publish date', () => {
|
||||||
const ld = blogPostingJsonLd(post);
|
const ld = blogPostingJsonLd(post, { namedAuthor: true });
|
||||||
expect(ld.url).toBe(
|
expect(ld.url).toBe(
|
||||||
'https://www.schoolcompare.co.uk/blog/what-the-data-cannot-tell-you',
|
'https://www.schoolcompare.co.uk/blog/what-the-data-cannot-tell-you',
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -0,0 +1,51 @@
|
|||||||
|
import { fireEvent, render, screen } from '@testing-library/react';
|
||||||
|
import HomePage from '@/app/(frontend)/page';
|
||||||
|
import SchoolPage from '@/app/(frontend)/school/[slug]/page';
|
||||||
|
import ErrorPage from '@/app/(frontend)/error';
|
||||||
|
import { APIFetchError, fetchSchools, fetchFilters, fetchSchoolDetails } from '@/lib/api';
|
||||||
|
import { fetchPlace, fetchPlaces } from '@/lib/places';
|
||||||
|
|
||||||
|
jest.mock('@/lib/api', () => ({
|
||||||
|
...jest.requireActual('@/lib/api'),
|
||||||
|
fetchSchools: jest.fn(),
|
||||||
|
fetchSchoolDetails: jest.fn(),
|
||||||
|
fetchFilters: jest.fn(async () => ({})),
|
||||||
|
fetchDataInfo: jest.fn(async () => null),
|
||||||
|
fetchNationalAverages: jest.fn(async () => null),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/flags', () => ({ getFlags: jest.fn(async () => ({})) }));
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
notFound: () => { throw new Error('NEXT_NOT_FOUND'); },
|
||||||
|
redirect: jest.fn(),
|
||||||
|
}));
|
||||||
|
const realFetch = global.fetch;
|
||||||
|
afterEach(() => { global.fetch = realFetch; jest.clearAllMocks(); });
|
||||||
|
|
||||||
|
test('school outages propagate; only a real 404 becomes not found', async () => {
|
||||||
|
const request = { params: Promise.resolve({ slug: '100001-school' }) };
|
||||||
|
const outage = new APIFetchError('unavailable', 503);
|
||||||
|
jest.mocked(fetchSchoolDetails).mockRejectedValueOnce(outage);
|
||||||
|
await expect(SchoolPage(request)).rejects.toBe(outage);
|
||||||
|
jest.mocked(fetchSchoolDetails).mockRejectedValueOnce(new APIFetchError('missing', 404));
|
||||||
|
await expect(SchoolPage(request)).rejects.toThrow('NEXT_NOT_FOUND');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('homepage search failure is not returned as an empty successful page', async () => {
|
||||||
|
jest.mocked(fetchSchools).mockRejectedValueOnce(new APIFetchError('unavailable', 503));
|
||||||
|
await expect(HomePage({ searchParams: Promise.resolve({ search: 'school' }) })).rejects.toThrow('unavailable');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('a place is absent only on 404; other failures propagate', async () => {
|
||||||
|
global.fetch = jest.fn().mockResolvedValue({ ok: false, status: 404 });
|
||||||
|
await expect(fetchPlace('town', 'example')).resolves.toBeNull();
|
||||||
|
jest.mocked(global.fetch).mockResolvedValue({ ok: false, status: 503 } as Response);
|
||||||
|
await expect(fetchPlace('town', 'example')).rejects.toMatchObject({ status: 503 });
|
||||||
|
await expect(fetchPlaces()).rejects.toMatchObject({ status: 503 });
|
||||||
|
});
|
||||||
|
|
||||||
|
test('the error boundary offers a retry without showing an empty search', () => {
|
||||||
|
const reset = jest.fn();
|
||||||
|
render(<ErrorPage error={new Error('offline')} reset={reset} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'Try again' }));
|
||||||
|
expect(reset).toHaveBeenCalledTimes(1);
|
||||||
|
});
|
||||||
@@ -2,6 +2,7 @@ import { metadata as homeMetadata } from '@/app/(frontend)/page';
|
|||||||
import { metadata as rankingsMetadata } from '@/app/(frontend)/rankings/page';
|
import { metadata as rankingsMetadata } from '@/app/(frontend)/rankings/page';
|
||||||
import { metadata as admissionsMetadata } from '@/app/(frontend)/admissions/page';
|
import { metadata as admissionsMetadata } from '@/app/(frontend)/admissions/page';
|
||||||
import { generateMetadata as compareMetadata } from '@/app/(frontend)/compare/page';
|
import { generateMetadata as compareMetadata } from '@/app/(frontend)/compare/page';
|
||||||
|
import { metadata as rootMetadata } from '@/app/(frontend)/layout';
|
||||||
|
|
||||||
describe('canonical URLs', () => {
|
describe('canonical URLs', () => {
|
||||||
it('the homepage canonicalises to the bare root', () => {
|
it('the homepage canonicalises to the bare root', () => {
|
||||||
@@ -122,9 +123,47 @@ describe('C1 snippet copy', () => {
|
|||||||
|
|
||||||
it('no C1 page claims a school count that will drift', () => {
|
it('no C1 page claims a school count that will drift', () => {
|
||||||
// The corpus moves with every data refresh; this repo has already shipped
|
// The corpus moves with every data refresh; this repo has already shipped
|
||||||
// one copy bug of that kind ("three schools" against MAX_SCHOOLS = 5).
|
// one copy bug of that kind ("three schools" against a limit of five).
|
||||||
for (const [, meta] of pages) {
|
for (const [, meta] of pages) {
|
||||||
expect(meta.description as string).not.toMatch(/\b\d{2},\d{3}\b|\b\d{2},000\b/);
|
expect(meta.description as string).not.toMatch(/\b\d{2},\d{3}\b|\b\d{2},000\b/);
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The share card must be declared, not inherited.
|
||||||
|
*
|
||||||
|
* `app/opengraph-image.tsx` is a metadata file convention, and it does attach
|
||||||
|
* to routes in the app root segment — `_not-found` gets an og:image from it.
|
||||||
|
* It does NOT attach to the site's pages, which live in the `(frontend)`
|
||||||
|
* route group whose own layout is a root layout. Staging served og:title,
|
||||||
|
* og:description, og:url, og:site_name and og:type and no og:image at all,
|
||||||
|
* so every link pasted into a chat rendered bare.
|
||||||
|
*
|
||||||
|
* The file stays at the app root, because /robots.txt and /icon.png depend on
|
||||||
|
* it being there. The site's root layout points at the route it generates.
|
||||||
|
*/
|
||||||
|
describe('the share card', () => {
|
||||||
|
it('declares an opengraph image on the site root layout', () => {
|
||||||
|
// No og:image means every link pasted into a chat renders bare.
|
||||||
|
const images = rootMetadata.openGraph?.images;
|
||||||
|
expect(images).toBeTruthy();
|
||||||
|
expect(JSON.stringify(images)).toContain('/opengraph-image');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('declares a twitter image too', () => {
|
||||||
|
// twitter.card is summary_large_image. Claiming a large-image card and
|
||||||
|
// supplying no image is worse than claiming a summary card.
|
||||||
|
// Metadata['twitter'] is a union and `card` is not on every member, so
|
||||||
|
// this reads the serialised shape rather than narrowing the type.
|
||||||
|
const twitter = JSON.stringify(rootMetadata.twitter);
|
||||||
|
expect(twitter).toContain('summary_large_image');
|
||||||
|
expect(twitter).toContain('/opengraph-image');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('resolves the card to an absolute url via metadataBase', () => {
|
||||||
|
// The e2e journey does `new URL(ogUrl)`, which throws on a relative path.
|
||||||
|
expect(rootMetadata.metadataBase?.toString())
|
||||||
|
.toBe('https://www.schoolcompare.co.uk/');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,30 @@
|
|||||||
|
/** @jest-environment node */
|
||||||
|
import { GET } from '@/app/(frontend)/release.json/route';
|
||||||
|
import { readFile } from 'node:fs/promises';
|
||||||
|
|
||||||
|
jest.mock('node:fs/promises', () => ({ readFile: jest.fn() }));
|
||||||
|
const realFetch = global.fetch;
|
||||||
|
const identity = { sha: 'a'.repeat(40), build_id: 'b'.repeat(32) };
|
||||||
|
beforeEach(() => {
|
||||||
|
jest.mocked(readFile).mockResolvedValue(JSON.stringify(identity));
|
||||||
|
global.fetch = jest.fn(async () => Response.json(identity));
|
||||||
|
});
|
||||||
|
afterEach(() => { global.fetch = realFetch; jest.resetAllMocks(); });
|
||||||
|
|
||||||
|
test('reports immutable file identity and backend identity without caching', async () => {
|
||||||
|
const response = await GET();
|
||||||
|
expect(response.status).toBe(200);
|
||||||
|
expect(response.headers.get('Cache-Control')).toBe('no-store');
|
||||||
|
expect(await response.json()).toEqual({ frontend: identity, backend: identity });
|
||||||
|
expect(fetch).toHaveBeenCalledWith(expect.stringMatching(/\/api\/release$/), expect.objectContaining({ cache: 'no-store', signal: expect.anything() }));
|
||||||
|
});
|
||||||
|
|
||||||
|
test('missing build metadata cannot pass the release gate', async () => {
|
||||||
|
jest.mocked(readFile).mockRejectedValueOnce(new Error('missing file'));
|
||||||
|
expect((await GET()).status).toBe(503);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('backend failure cannot pass the release gate', async () => {
|
||||||
|
jest.mocked(fetch).mockResolvedValueOnce(new Response('', { status: 503 }));
|
||||||
|
expect((await GET()).status).toBe(503);
|
||||||
|
});
|
||||||
@@ -104,7 +104,7 @@ describe('CompareAdmissions', () => {
|
|||||||
render(<CompareAdmissions schools={[grammar]} data={data} isSecondary={true} />);
|
render(<CompareAdmissions schools={[grammar]} data={data} isSecondary={true} />);
|
||||||
|
|
||||||
expect(
|
expect(
|
||||||
screen.getByText(/Entry is by entrance test — the school is selective/),
|
screen.getByText(/Entry is by entrance test\. The school is selective/),
|
||||||
).toBeInTheDocument();
|
).toBeInTheDocument();
|
||||||
expect(screen.queryByText(/non-faith primaries/)).toBeNull();
|
expect(screen.queryByText(/non-faith primaries/)).toBeNull();
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -102,7 +102,7 @@ describe('CutoffMapPanel', () => {
|
|||||||
// Explanation is supporting text, not part of the bold verdict line.
|
// Explanation is supporting text, not part of the bold verdict line.
|
||||||
expect(result.querySelector('[class*="cutoffCheckHeadline"]')!.textContent)
|
expect(result.querySelector('[class*="cutoffCheckHeadline"]')!.textContent)
|
||||||
.not.toMatch(/measurement error/);
|
.not.toMatch(/measurement error/);
|
||||||
expect(result).not.toHaveTextContent(/^\S+ away — inside/);
|
expect(result).not.toHaveTextContent(/^\S+ away, inside/);
|
||||||
});
|
});
|
||||||
|
|
||||||
it('surfaces a postcode the geocoder cannot find', async () => {
|
it('surfaces a postcode the geocoder cannot find', async () => {
|
||||||
|
|||||||
@@ -0,0 +1,129 @@
|
|||||||
|
import { fireEvent, render, screen, within } from '@testing-library/react';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
import type { ResultFilters } from '@/lib/types';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* A filter's options must not come from the results it is filtering, or
|
||||||
|
* choosing one leaves only that one on offer: pick "Girls" and "Boys" is gone
|
||||||
|
* until the filter is cleared. School type groups, gender and admissions offer the
|
||||||
|
* full lists, as phase already did. Local authority stays scoped to the
|
||||||
|
* results, so a postcode search offers the councils nearby rather than 153.
|
||||||
|
*
|
||||||
|
* Gender, sixth form and admissions show unless the phase chosen is a primary
|
||||||
|
* one, so what the results happen to contain never decides which filters
|
||||||
|
* there are.
|
||||||
|
*/
|
||||||
|
|
||||||
|
let params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
const push = jest.fn();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push, replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/analytics', () => ({ track: jest.fn() }));
|
||||||
|
|
||||||
|
const filters = {
|
||||||
|
local_authorities: ['Merton', 'Wandsworth'],
|
||||||
|
school_types: ['Academy converter', 'Community school'], years: [],
|
||||||
|
phases: ['Middle deemed primary', 'Nursery', 'Primary', 'Secondary', 'All-through'],
|
||||||
|
genders: ['Boys', 'Girls', 'Mixed'],
|
||||||
|
admissions_policies: ['Non-selective', 'Selective'],
|
||||||
|
school_type_groups: [
|
||||||
|
{ value: 'academy', label: 'State school: academy or free school' },
|
||||||
|
{ value: 'council', label: 'State school: council-run' },
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
// What the results came back with once narrowed by the chosen filters.
|
||||||
|
const narrowed: ResultFilters = {
|
||||||
|
local_authorities: ['Wandsworth'], school_types: ['Community school'],
|
||||||
|
phases: ['Secondary'], genders: ['Girls'], admissions_policies: ['Non-selective'],
|
||||||
|
};
|
||||||
|
|
||||||
|
const pushedParams = () => new URLSearchParams(push.mock.calls.at(-1)![0].split('?')[1]);
|
||||||
|
|
||||||
|
const openSheet = () => {
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /^Filters/ }));
|
||||||
|
return screen.getByRole('dialog', { name: 'Filters' });
|
||||||
|
};
|
||||||
|
|
||||||
|
const optionsOf = (sheet: HTMLElement, name: string) =>
|
||||||
|
within(within(sheet).getByRole('combobox', { name }))
|
||||||
|
.getAllByRole('option').map((o) => o.textContent);
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
push.mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('filter options', () => {
|
||||||
|
it('offer every school type group, gender and admissions policy, whatever the results hold', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&school_type=council&gender=girls');
|
||||||
|
render(<FilterBar filters={filters} resultFilters={narrowed} />);
|
||||||
|
const sheet = openSheet();
|
||||||
|
expect(optionsOf(sheet, 'School type')).toEqual(['Any school type', 'State school: academy or free school', 'State school: council-run']);
|
||||||
|
expect(optionsOf(sheet, 'Gender')).toEqual(['Boys, Girls & Mixed', 'Boys', 'Girls', 'Mixed']);
|
||||||
|
expect(optionsOf(sheet, 'Admissions')).toEqual(['All admissions types', 'Non-selective', 'Selective']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keep local authority to the councils in the results', () => {
|
||||||
|
render(<FilterBar filters={filters} resultFilters={narrowed} />);
|
||||||
|
expect(optionsOf(openSheet(), 'Local authority')).toEqual(['All Local Authorities', 'Wandsworth']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('offer the full school types in the desktop row too', () => {
|
||||||
|
render(<FilterBar filters={filters} resultFilters={narrowed} />);
|
||||||
|
const row = screen.getByRole('group', { name: 'Filters' });
|
||||||
|
expect(within(within(row).getByRole('combobox', { name: 'School type' }))
|
||||||
|
.getAllByRole('option')).toHaveLength(3);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the secondary-only filters', () => {
|
||||||
|
const secondaryOnly = ['Gender', 'Sixth form', 'Admissions'];
|
||||||
|
const shown = (sheet: HTMLElement) =>
|
||||||
|
secondaryOnly.filter((name) => within(sheet).queryByRole('combobox', { name }));
|
||||||
|
|
||||||
|
it('show with any phase, even when no secondary school is in the results', () => {
|
||||||
|
const primariesOnly = { ...narrowed, phases: ['Primary'], genders: [], admissions_policies: [] };
|
||||||
|
render(<FilterBar filters={filters} resultFilters={primariesOnly} />);
|
||||||
|
expect(shown(openSheet())).toEqual(secondaryOnly);
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each(['primary', 'nursery', 'middle deemed primary', 'Middle-deemed Primary'])(
|
||||||
|
'hide for the %s phase', (phase) => {
|
||||||
|
params = new URLSearchParams(`postcode=SW196AR&radius=1&phase=${encodeURIComponent(phase)}`);
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(shown(openSheet())).toEqual([]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('leave out a filter with no options, rather than show only its "any"', () => {
|
||||||
|
render(<FilterBar filters={{ ...filters, genders: [], admissions_policies: [] }} />);
|
||||||
|
expect(shown(openSheet())).toEqual(['Sixth form']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it.each(['secondary', 'all-through', 'middle deemed secondary', '16 plus'])('show for the %s phase', (phase) => {
|
||||||
|
params = new URLSearchParams(`postcode=SW196AR&radius=1&phase=${phase}`);
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(shown(openSheet())).toEqual(secondaryOnly);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('are cleared by choosing a primary phase, rather than left applied and hidden', () => {
|
||||||
|
params = new URLSearchParams(
|
||||||
|
'postcode=SW196AR&radius=1&phase=secondary&gender=girls&has_sixth_form=yes&admissions_policy=selective&school_type=council');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.change(within(openSheet()).getByRole('combobox', { name: 'Phase' }), { target: { value: 'primary' } });
|
||||||
|
const next = pushedParams();
|
||||||
|
expect(next.get('phase')).toBe('primary');
|
||||||
|
for (const key of ['gender', 'has_sixth_form', 'admissions_policy']) expect(next.get(key)).toBeNull();
|
||||||
|
expect(next.get('school_type')).toBe('council');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('are kept when the new phase still has them', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&phase=secondary&gender=girls');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.change(within(openSheet()).getByRole('combobox', { name: 'Phase' }), { target: { value: 'all-through' } });
|
||||||
|
expect(pushedParams().get('gender')).toBe('girls');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,40 @@
|
|||||||
|
import { render, screen, within } from '@testing-library/react';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
|
||||||
|
let searchParams = new URLSearchParams();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useRouter: () => ({ push: jest.fn(), replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
usePathname: () => '/',
|
||||||
|
useSearchParams: () => searchParams,
|
||||||
|
}));
|
||||||
|
|
||||||
|
const FILTERS = {
|
||||||
|
local_authorities: [], school_types: [], years: [],
|
||||||
|
phases: ['Primary', 'Secondary', 'All-through'],
|
||||||
|
genders: [], admissions_policies: [],
|
||||||
|
};
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The phase options must not come from the result set. The backend scopes its
|
||||||
|
* result filters to the schools it returns, and it applies the phase filter
|
||||||
|
* first — so with "secondary" chosen the scoped list holds only secondary-ish
|
||||||
|
* phases, and switching to primary meant going back to "Any phase" first.
|
||||||
|
*/
|
||||||
|
describe('FilterBar phase options', () => {
|
||||||
|
it('offers every phase while a phase filter narrows the results', () => {
|
||||||
|
searchParams = new URLSearchParams('search=hampton&phase=secondary');
|
||||||
|
render(
|
||||||
|
<FilterBar
|
||||||
|
filters={FILTERS}
|
||||||
|
resultFilters={{
|
||||||
|
local_authorities: [], school_types: [],
|
||||||
|
phases: ['Secondary', 'All-through'],
|
||||||
|
genders: [], admissions_policies: [],
|
||||||
|
}}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
const phase = screen.getByRole('combobox', { name: 'Phase' });
|
||||||
|
expect(within(phase).getByRole('option', { name: 'Primary' })).toBeInTheDocument();
|
||||||
|
expect(phase).toHaveValue('secondary');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,51 @@
|
|||||||
|
import { render, screen, waitFor } from '@testing-library/react';
|
||||||
|
import userEvent from '@testing-library/user-event';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
|
||||||
|
const push = jest.fn();
|
||||||
|
let searchParams = new URLSearchParams();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useRouter: () => ({ push, replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
usePathname: () => '/',
|
||||||
|
useSearchParams: () => searchParams,
|
||||||
|
}));
|
||||||
|
|
||||||
|
const FILTERS = {
|
||||||
|
local_authorities: [], school_types: [], years: [], phases: [],
|
||||||
|
genders: [], admissions_policies: [],
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
push.mockClear();
|
||||||
|
searchParams = new URLSearchParams();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('FilterBar default distance', () => {
|
||||||
|
it('searches a new postcode within half a mile', async () => {
|
||||||
|
render(<FilterBar filters={FILTERS} />);
|
||||||
|
await userEvent.type(screen.getByPlaceholderText(/School name or postcode/i), 'SW19 6AR{Enter}');
|
||||||
|
await waitFor(() => expect(push).toHaveBeenCalledWith(expect.stringContaining('radius=0.5')));
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows half a mile when the URL carries a postcode but no radius', () => {
|
||||||
|
searchParams = new URLSearchParams('postcode=SW196AR');
|
||||||
|
render(<FilterBar filters={FILTERS} />);
|
||||||
|
expect(screen.getByRole('combobox', { name: 'Distance' })).toHaveValue('0.5');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps a distance the user already chose', async () => {
|
||||||
|
searchParams = new URLSearchParams('postcode=SW196AR&radius=3');
|
||||||
|
render(<FilterBar filters={FILTERS} />);
|
||||||
|
expect(screen.getByRole('combobox', { name: 'Distance' })).toHaveValue('3');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('FilterBar distance options', () => {
|
||||||
|
it('offers a quarter mile without making it the default', () => {
|
||||||
|
searchParams = new URLSearchParams('postcode=SW196AR');
|
||||||
|
render(<FilterBar filters={FILTERS} />);
|
||||||
|
const distance = screen.getByRole('combobox', { name: 'Distance' });
|
||||||
|
expect([...(distance as HTMLSelectElement).options].map(o => o.value)).toEqual(['0.25', '0.5', '1', '3', '5']);
|
||||||
|
expect(distance).toHaveValue('0.5');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -32,9 +32,9 @@ afterEach(() => { global.fetch = realFetch; });
|
|||||||
describe('FilterBar autosuggest', () => {
|
describe('FilterBar autosuggest', () => {
|
||||||
it('is a combobox only when the flag is on', () => {
|
it('is a combobox only when the flag is on', () => {
|
||||||
const { rerender } = render(<FilterBar filters={FILTERS} autosuggest={false} />);
|
const { rerender } = render(<FilterBar filters={FILTERS} autosuggest={false} />);
|
||||||
expect(screen.queryByRole('combobox')).not.toBeInTheDocument();
|
expect(screen.queryByRole('combobox', { name: 'School name or postcode' })).not.toBeInTheDocument();
|
||||||
rerender(<FilterBar filters={FILTERS} autosuggest />);
|
rerender(<FilterBar filters={FILTERS} autosuggest />);
|
||||||
expect(screen.getByRole('combobox')).toBeInTheDocument();
|
expect(screen.getByRole('combobox', { name: 'School name or postcode' })).toBeInTheDocument();
|
||||||
});
|
});
|
||||||
|
|
||||||
it('makes no request while the flag is off', async () => {
|
it('makes no request while the flag is off', async () => {
|
||||||
@@ -47,7 +47,7 @@ describe('FilterBar autosuggest', () => {
|
|||||||
|
|
||||||
it('shows suggestions and navigates when one is chosen', async () => {
|
it('shows suggestions and navigates when one is chosen', async () => {
|
||||||
render(<FilterBar filters={FILTERS} autosuggest />);
|
render(<FilterBar filters={FILTERS} autosuggest />);
|
||||||
await userEvent.type(screen.getByRole('combobox'), 'brecknock');
|
await userEvent.type(screen.getByRole('combobox', { name: 'School name or postcode' }), 'brecknock');
|
||||||
const option = await screen.findByRole('option', { name: /Brecknock/ });
|
const option = await screen.findByRole('option', { name: /Brecknock/ });
|
||||||
await userEvent.click(option);
|
await userEvent.click(option);
|
||||||
expect(push).toHaveBeenCalledWith(
|
expect(push).toHaveBeenCalledWith(
|
||||||
@@ -61,7 +61,7 @@ describe('FilterBar autosuggest', () => {
|
|||||||
// "NW1" is not a postcode, so a request for it is correct behaviour. Only
|
// "NW1" is not a postcode, so a request for it is correct behaviour. Only
|
||||||
// the settled value is the assertion, so set it in one go.
|
// the settled value is the assertion, so set it in one go.
|
||||||
render(<FilterBar filters={FILTERS} autosuggest />);
|
render(<FilterBar filters={FILTERS} autosuggest />);
|
||||||
fireEvent.change(screen.getByRole('combobox'), { target: { value: 'NW1 1AA' } });
|
fireEvent.change(screen.getByRole('combobox', { name: 'School name or postcode' }), { target: { value: 'NW1 1AA' } });
|
||||||
await new Promise((r) => setTimeout(r, 300)); // past the 200ms debounce
|
await new Promise((r) => setTimeout(r, 300)); // past the 200ms debounce
|
||||||
expect(global.fetch).not.toHaveBeenCalled();
|
expect(global.fetch).not.toHaveBeenCalled();
|
||||||
});
|
});
|
||||||
@@ -69,7 +69,7 @@ describe('FilterBar autosuggest', () => {
|
|||||||
it('Enter with no active option still submits the free-text search', async () => {
|
it('Enter with no active option still submits the free-text search', async () => {
|
||||||
// The existing behaviour is preserved, not replaced.
|
// The existing behaviour is preserved, not replaced.
|
||||||
render(<FilterBar filters={FILTERS} autosuggest />);
|
render(<FilterBar filters={FILTERS} autosuggest />);
|
||||||
const input = screen.getByRole('combobox');
|
const input = screen.getByRole('combobox', { name: 'School name or postcode' });
|
||||||
await userEvent.type(input, 'brecknock{Enter}');
|
await userEvent.type(input, 'brecknock{Enter}');
|
||||||
// updateURL pushes inside startTransition, so the call is not synchronous.
|
// updateURL pushes inside startTransition, so the call is not synchronous.
|
||||||
await waitFor(() => expect(push).toHaveBeenCalledWith(
|
await waitFor(() => expect(push).toHaveBeenCalledWith(
|
||||||
@@ -90,7 +90,7 @@ describe('FilterBar autosuggest does not reopen over results', () => {
|
|||||||
searchParams = new URLSearchParams('search=brecknock');
|
searchParams = new URLSearchParams('search=brecknock');
|
||||||
render(<FilterBar filters={FILTERS} autosuggest />);
|
render(<FilterBar filters={FILTERS} autosuggest />);
|
||||||
|
|
||||||
expect(screen.getByRole('combobox')).toHaveValue('brecknock');
|
expect(screen.getByRole('combobox', { name: 'School name or postcode' })).toHaveValue('brecknock');
|
||||||
await new Promise((r) => setTimeout(r, 300)); // past the 200ms debounce
|
await new Promise((r) => setTimeout(r, 300)); // past the 200ms debounce
|
||||||
expect(global.fetch).not.toHaveBeenCalled();
|
expect(global.fetch).not.toHaveBeenCalled();
|
||||||
expect(screen.queryByRole('listbox')).not.toBeInTheDocument();
|
expect(screen.queryByRole('listbox')).not.toBeInTheDocument();
|
||||||
@@ -98,7 +98,7 @@ describe('FilterBar autosuggest does not reopen over results', () => {
|
|||||||
|
|
||||||
it('closes the dropdown when the search is submitted', async () => {
|
it('closes the dropdown when the search is submitted', async () => {
|
||||||
render(<FilterBar filters={FILTERS} autosuggest />);
|
render(<FilterBar filters={FILTERS} autosuggest />);
|
||||||
const input = screen.getByRole('combobox');
|
const input = screen.getByRole('combobox', { name: 'School name or postcode' });
|
||||||
|
|
||||||
await userEvent.type(input, 'brecknock');
|
await userEvent.type(input, 'brecknock');
|
||||||
expect(await screen.findByRole('listbox')).toBeInTheDocument();
|
expect(await screen.findByRole('listbox')).toBeInTheDocument();
|
||||||
|
|||||||
@@ -0,0 +1,137 @@
|
|||||||
|
import { fireEvent, render, screen, within } from '@testing-library/react';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
import { track } from '@/lib/analytics';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* School type offers six groups a parent recognises, not GIAS's 34 types, and
|
||||||
|
* a Faith filter sits beside it (spec 2026-10-02-school-type-groups-and-faith-
|
||||||
|
* filter-design.md). Both lists come from /api/filters.
|
||||||
|
*/
|
||||||
|
|
||||||
|
let params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
const push = jest.fn();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push, replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/analytics', () => ({ track: jest.fn() }));
|
||||||
|
|
||||||
|
const filters = {
|
||||||
|
local_authorities: ['Wandsworth'], school_types: ['Community school'], years: [],
|
||||||
|
phases: ['Primary', 'Secondary'], genders: [], admissions_policies: [],
|
||||||
|
school_type_groups: [
|
||||||
|
{ value: 'academy', label: 'State school: academy or free school' },
|
||||||
|
{ value: 'council', label: 'State school: council-run' },
|
||||||
|
{ value: 'special', label: 'Special school (SEND)' },
|
||||||
|
],
|
||||||
|
faiths: [
|
||||||
|
{ value: 'none', label: 'No religious character' },
|
||||||
|
{ value: 'roman_catholic', label: 'Roman Catholic' },
|
||||||
|
],
|
||||||
|
};
|
||||||
|
|
||||||
|
const pushedParams = () => new URLSearchParams(push.mock.calls.at(-1)![0].split('?')[1]);
|
||||||
|
const openSheet = () => {
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /^Filters/ }));
|
||||||
|
return screen.getByRole('dialog', { name: 'Filters' });
|
||||||
|
};
|
||||||
|
const optionsOf = (scope: HTMLElement, name: string) =>
|
||||||
|
within(within(scope).getByRole('combobox', { name })).getAllByRole('option').map((o) => o.textContent);
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
push.mockClear();
|
||||||
|
jest.mocked(track).mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('School type', () => {
|
||||||
|
it('offers the groups, not the GIAS types, on desktop and in the sheet', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const groups = ['Any school type', 'State school: academy or free school',
|
||||||
|
'State school: council-run', 'Special school (SEND)'];
|
||||||
|
expect(optionsOf(screen.getByRole('group', { name: 'Filters' }), 'School type')).toEqual(groups);
|
||||||
|
expect(optionsOf(openSheet(), 'School type')).toEqual(groups);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('puts the group key in the URL and names the chip by its label', () => {
|
||||||
|
const view = render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.change(within(openSheet()).getByRole('combobox', { name: 'School type' }),
|
||||||
|
{ target: { value: 'special' } });
|
||||||
|
expect(pushedParams().get('school_type')).toBe('special');
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&school_type=special');
|
||||||
|
view.rerender(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Special school (SEND)' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('names an old raw-label link\'s chip by that label', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&school_type=Community+school');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Community school' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is left out when the API sends no groups', () => {
|
||||||
|
render(<FilterBar filters={{ ...filters, school_type_groups: undefined }} />);
|
||||||
|
expect(screen.queryByRole('combobox', { name: 'School type' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('Faith', () => {
|
||||||
|
it('offers its options in the More filters panel and in the sheet', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /More filters/ }));
|
||||||
|
const faiths = ['Any faith or none', 'No religious character', 'Roman Catholic'];
|
||||||
|
expect(optionsOf(document.body, 'Faith')).toEqual(faiths);
|
||||||
|
expect(optionsOf(openSheet(), 'Faith')).toEqual(faiths);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows as a chip, counts on both buttons, and clears with Clear all', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&faith=roman_catholic');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Roman Catholic' })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: 'Filters, 1 applied' })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: /More filters \(1\)/ })).toBeInTheDocument();
|
||||||
|
fireEvent.click(within(screen.getByRole('group', { name: 'Applied filters' }))
|
||||||
|
.getByRole('button', { name: 'Clear all' }));
|
||||||
|
expect(pushedParams().get('faith')).toBeNull();
|
||||||
|
expect(pushedParams().get('postcode')).toBe('SW196AR');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('goes into the search analytics event', () => {
|
||||||
|
params = new URLSearchParams('faith=roman_catholic');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const input = screen.getByRole('searchbox', { name: 'School name or postcode' });
|
||||||
|
fireEvent.change(input, { target: { value: 'st marys' } });
|
||||||
|
fireEvent.submit(input.closest('form')!);
|
||||||
|
expect(track).toHaveBeenCalledWith('search_submitted',
|
||||||
|
expect.objectContaining({ filters_active: 'faith=roman_catholic', filters_count: 1 }));
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is left out when the API sends no faiths', () => {
|
||||||
|
render(<FilterBar filters={{ ...filters, faiths: [] }} />);
|
||||||
|
expect(within(openSheet()).queryByRole('combobox', { name: 'Faith' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('a URL value the options do not spell the same way', () => {
|
||||||
|
const row = () => screen.getByRole('group', { name: 'Filters' });
|
||||||
|
|
||||||
|
it('shows an old raw-label type in the select, and lets "Any" clear it', () => {
|
||||||
|
params = new URLSearchParams('search=school&school_type=Community+school');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const type = within(row()).getByRole('combobox', { name: 'School type' });
|
||||||
|
expect(type).toHaveValue('Community school');
|
||||||
|
expect(within(type).getByRole('option', { name: 'Community school' })).toBeInTheDocument();
|
||||||
|
fireEvent.change(type, { target: { value: '' } });
|
||||||
|
expect(pushedParams().get('school_type')).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('matches a key in another case, in the select and the chip', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&school_type=Special&faith=Roman_Catholic');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(within(row()).getByRole('combobox', { name: 'School type' })).toHaveValue('special');
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Special school (SEND)' })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: 'Remove filter: Roman Catholic' })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('combobox', { name: 'Faith' })).toHaveValue('roman_catholic');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,157 @@
|
|||||||
|
import { fireEvent, render, screen, within } from '@testing-library/react';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Phones filter through one "Filters" button and a bottom sheet holding every
|
||||||
|
* filter, rather than a sideways-scrolling row whose later chips (phase, type)
|
||||||
|
* sat off-screen beside a "More filters" panel that did not contain them.
|
||||||
|
* Which markup shows at which width is CSS and invisible to jsdom; these pin
|
||||||
|
* the behaviour and the accessible names.
|
||||||
|
*/
|
||||||
|
|
||||||
|
let params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
const push = jest.fn();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push, replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/analytics', () => ({ track: jest.fn() }));
|
||||||
|
|
||||||
|
const filters = {
|
||||||
|
local_authorities: ['Wandsworth', 'Merton'], school_types: ['Community school'], years: [],
|
||||||
|
phases: ['Primary', 'Secondary'], genders: ['Girls', 'Mixed'], admissions_policies: [],
|
||||||
|
school_type_groups: [{ value: 'council', label: 'State school: council-run' }],
|
||||||
|
};
|
||||||
|
|
||||||
|
const pushedParams = () => new URLSearchParams(push.mock.calls.at(-1)![0].split('?')[1]);
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
push.mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the phone Filters button', () => {
|
||||||
|
it('sits beside the folded search summary', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const summary = screen.getByRole('button', { name: /Edit search/ });
|
||||||
|
expect(summary.parentElement).toContainElement(screen.getByRole('button', { name: 'Filters' }));
|
||||||
|
});
|
||||||
|
|
||||||
|
it('counts every applied filter, phase and type included', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&phase=primary&school_type=council');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Filters, 2 applied' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is still offered before anything has been searched', () => {
|
||||||
|
params = new URLSearchParams('local_authority=Wandsworth');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: 'Filters, 1 applied' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('stays out of the hero', () => {
|
||||||
|
render(<FilterBar filters={filters} isHero />);
|
||||||
|
expect(screen.queryByRole('button', { name: /^Filters/ })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the filter sheet', () => {
|
||||||
|
const openSheet = () => {
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /^Filters/ }));
|
||||||
|
return screen.getByRole('dialog', { name: 'Filters' });
|
||||||
|
};
|
||||||
|
|
||||||
|
it('holds every filter in one place', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const sheet = openSheet();
|
||||||
|
expect(within(sheet).getByRole('radiogroup', { name: 'Distance' })).toBeInTheDocument();
|
||||||
|
for (const name of ['Phase', 'School type', 'Local authority']) {
|
||||||
|
expect(within(sheet).getByRole('combobox', { name })).toBeInTheDocument();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows the secondary-only filters once they apply', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&phase=secondary');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const sheet = openSheet();
|
||||||
|
for (const name of ['Gender', 'Sixth form']) {
|
||||||
|
expect(within(sheet).getByRole('combobox', { name })).toBeInTheDocument();
|
||||||
|
}
|
||||||
|
});
|
||||||
|
|
||||||
|
it('offers distance only for a postcode search', () => {
|
||||||
|
params = new URLSearchParams('search=southmead');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(within(openSheet()).queryByRole('radiogroup', { name: 'Distance' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('changes the distance', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const distance = within(openSheet()).getByRole('radiogroup', { name: 'Distance' });
|
||||||
|
expect(within(distance).getByRole('radio', { name: 'Within 1 mile' })).toBeChecked();
|
||||||
|
fireEvent.click(within(distance).getByRole('radio', { name: 'Within 3 miles' }));
|
||||||
|
expect(pushedParams().get('radius')).toBe('3');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('applies a change straight away and stays open for the next one', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const sheet = openSheet();
|
||||||
|
fireEvent.change(within(sheet).getByRole('combobox', { name: 'Phase' }), { target: { value: 'primary' } });
|
||||||
|
expect(pushedParams().get('phase')).toBe('primary');
|
||||||
|
expect(screen.getByRole('dialog', { name: 'Filters' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('closes on the results button, which gives the count', () => {
|
||||||
|
render(<FilterBar filters={filters} resultCount={12} />);
|
||||||
|
fireEvent.click(within(openSheet()).getByRole('button', { name: 'Show 12 schools' }));
|
||||||
|
expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('says so when nothing matches', () => {
|
||||||
|
render(<FilterBar filters={filters} resultCount={0} />);
|
||||||
|
expect(within(openSheet()).getByRole('button', { name: 'No schools match' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('clears the filters but keeps the search', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&phase=primary&local_authority=Wandsworth');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.click(within(openSheet()).getByRole('button', { name: 'Clear all' }));
|
||||||
|
const next = pushedParams();
|
||||||
|
expect(next.get('phase')).toBeNull();
|
||||||
|
expect(next.get('local_authority')).toBeNull();
|
||||||
|
expect(next.get('postcode')).toBe('SW196AR');
|
||||||
|
expect(next.get('radius')).toBe('1');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the applied-filter chips', () => {
|
||||||
|
it('appear only when something is applied', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.queryByRole('group', { name: 'Applied filters' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('name each filter by its label and remove it on tap', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&phase=primary&gender=girls&has_sixth_form=no');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const chips = screen.getByRole('group', { name: 'Applied filters' });
|
||||||
|
for (const label of ['Primary', 'Girls', 'Without sixth form']) {
|
||||||
|
expect(within(chips).getByRole('button', { name: `Remove filter: ${label}` })).toBeInTheDocument();
|
||||||
|
}
|
||||||
|
fireEvent.click(within(chips).getByRole('button', { name: 'Remove filter: Primary' }));
|
||||||
|
const next = pushedParams();
|
||||||
|
expect(next.get('phase')).toBeNull();
|
||||||
|
expect(next.get('gender')).toBe('girls');
|
||||||
|
expect(next.get('postcode')).toBe('SW196AR');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('carry a Clear all that keeps the search', () => {
|
||||||
|
params = new URLSearchParams('search=southmead&school_type=council');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.click(within(screen.getByRole('group', { name: 'Applied filters' }))
|
||||||
|
.getByRole('button', { name: 'Clear all' }));
|
||||||
|
const next = pushedParams();
|
||||||
|
expect(next.get('school_type')).toBeNull();
|
||||||
|
expect(next.get('search')).toBe('southmead');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,81 @@
|
|||||||
|
import { act, fireEvent, render, screen, within } from '@testing-library/react';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* While a filter change is navigating, the sheet's controls stay enabled: a
|
||||||
|
* control disabled under the user's focus drops it to <body>, and a keyboard or
|
||||||
|
* screen-reader user is thrown out of the sheet after every change. A second
|
||||||
|
* change made before the first lands must build on the first, not on the URL
|
||||||
|
* useSearchParams still reports.
|
||||||
|
*/
|
||||||
|
|
||||||
|
// Every transition stays pending, as a slow server render would.
|
||||||
|
jest.mock('react', () => ({
|
||||||
|
...jest.requireActual('react'),
|
||||||
|
useTransition: () => [true, (fn: () => void) => fn()],
|
||||||
|
}));
|
||||||
|
|
||||||
|
const params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
const push = jest.fn();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push, replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/analytics', () => ({ track: jest.fn() }));
|
||||||
|
|
||||||
|
const filters = {
|
||||||
|
local_authorities: ['Wandsworth'], school_types: ['Community school'], years: [],
|
||||||
|
phases: ['Primary', 'Secondary'], genders: [], admissions_policies: [],
|
||||||
|
school_type_groups: [{ value: 'council', label: 'State school: council-run' }],
|
||||||
|
};
|
||||||
|
|
||||||
|
const pushedParams = () => new URLSearchParams(push.mock.calls.at(-1)![0].split('?')[1]);
|
||||||
|
|
||||||
|
const openSheet = () => {
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /^Filters/ }));
|
||||||
|
return screen.getByRole('dialog', { name: 'Filters' });
|
||||||
|
};
|
||||||
|
|
||||||
|
beforeEach(() => push.mockClear());
|
||||||
|
|
||||||
|
it('keeps the sheet usable, and says it is busy, while a change lands', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const sheet = openSheet();
|
||||||
|
for (const name of ['Phase', 'School type', 'Local authority']) {
|
||||||
|
expect(within(sheet).getByRole('combobox', { name })).toBeEnabled();
|
||||||
|
}
|
||||||
|
expect(within(sheet).getByRole('radio', { name: 'Within 3 miles' })).toBeEnabled();
|
||||||
|
expect(sheet.querySelector('[aria-busy="true"]')).not.toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('builds a second change on the first, not on the URL it has not reached', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const sheet = openSheet();
|
||||||
|
fireEvent.change(within(sheet).getByRole('combobox', { name: 'Phase' }), { target: { value: 'primary' } });
|
||||||
|
fireEvent.change(within(sheet).getByRole('combobox', { name: 'School type' }),
|
||||||
|
{ target: { value: 'council' } });
|
||||||
|
const next = pushedParams();
|
||||||
|
expect(next.get('phase')).toBe('primary');
|
||||||
|
expect(next.get('school_type')).toBe('council');
|
||||||
|
expect(next.get('postcode')).toBe('SW196AR');
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('a screen that widens past phone width', () => {
|
||||||
|
let listeners: ((e: { matches: boolean }) => void)[] = [];
|
||||||
|
beforeEach(() => {
|
||||||
|
listeners = [];
|
||||||
|
window.matchMedia = jest.fn().mockImplementation((query: string) => ({
|
||||||
|
matches: true, media: query,
|
||||||
|
addEventListener: (_: string, l: (e: { matches: boolean }) => void) => listeners.push(l),
|
||||||
|
removeEventListener: jest.fn(),
|
||||||
|
}));
|
||||||
|
});
|
||||||
|
|
||||||
|
it('closes the sheet, leaving the desktop row as the only filters', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
openSheet();
|
||||||
|
act(() => listeners.forEach((l) => l({ matches: false })));
|
||||||
|
expect(screen.queryByRole('dialog')).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,47 @@
|
|||||||
|
/**
|
||||||
|
* The footer is the only navigational route to /about and /blog, so it is
|
||||||
|
* where a dark flag would otherwise leave a link into a 404.
|
||||||
|
*
|
||||||
|
* Both props default to false. A caller that forgets to pass them hides the
|
||||||
|
* links, which is the direction that cannot break a page — the same reasoning
|
||||||
|
* as backend/flags.py's "every flag defaults to False".
|
||||||
|
*/
|
||||||
|
import { render, screen } from '@testing-library/react';
|
||||||
|
import { Footer } from '@/components/Footer';
|
||||||
|
|
||||||
|
describe('footer feature links', () => {
|
||||||
|
it('links to both when both flags are on', () => {
|
||||||
|
render(<Footer aboutEnabled blogEnabled />);
|
||||||
|
expect(screen.getByRole('link', { name: /who's behind this/i }))
|
||||||
|
.toHaveAttribute('href', '/about');
|
||||||
|
expect(screen.getByRole('link', { name: /^blog$/i }))
|
||||||
|
.toHaveAttribute('href', '/blog');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('omits the about link when that flag is dark', () => {
|
||||||
|
render(<Footer blogEnabled />);
|
||||||
|
expect(screen.queryByRole('link', { name: /who's behind this/i })).toBeNull();
|
||||||
|
expect(screen.getByRole('link', { name: /^blog$/i })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('omits the blog link when that flag is dark', () => {
|
||||||
|
render(<Footer aboutEnabled />);
|
||||||
|
expect(screen.queryByRole('link', { name: /^blog$/i })).toBeNull();
|
||||||
|
expect(screen.getByRole('link', { name: /who's behind this/i }))
|
||||||
|
.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('drops the whole section when both are dark, not an empty heading', () => {
|
||||||
|
// Shipping dark means the footer renders as it did before the feature
|
||||||
|
// existed, not as a section with its contents removed.
|
||||||
|
render(<Footer />);
|
||||||
|
expect(screen.queryByRole('heading', { name: /^about$/i })).toBeNull();
|
||||||
|
expect(screen.queryByRole('link', { name: /who's behind this/i })).toBeNull();
|
||||||
|
expect(screen.queryByRole('link', { name: /^blog$/i })).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('defaults to dark when a caller passes nothing', () => {
|
||||||
|
render(<Footer />);
|
||||||
|
expect(screen.queryByRole('link', { name: /who's behind this/i })).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,86 @@
|
|||||||
|
import { act, fireEvent, render, screen } from '@testing-library/react';
|
||||||
|
import { HomeView } from '@/components/HomeView';
|
||||||
|
import { fetchSchools } from '@/lib/api';
|
||||||
|
import { primaryFixture } from '../support/schoolFixtures';
|
||||||
|
import type { SchoolsResponse, School } from '@/lib/types';
|
||||||
|
|
||||||
|
let params = new URLSearchParams('postcode=SW1A+1AA');
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push: jest.fn(), replace: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/context/ComparisonContext', () => ({
|
||||||
|
useComparisonContext: () => ({ addSchool: jest.fn(), removeSchool: jest.fn(), selectedSchools: [] }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/api', () => ({
|
||||||
|
fetchSchools: jest.fn(),
|
||||||
|
fetchNationalAverages: jest.fn(async () => ({})),
|
||||||
|
fetchLAaverages: jest.fn(async () => ({ secondary: { attainment_8_by_la: {} } })),
|
||||||
|
}));
|
||||||
|
// Renders only the List/Map switch HomeView hands it, which lives in its row.
|
||||||
|
jest.mock('@/components/FilterBar', () => ({
|
||||||
|
FilterBar: ({ viewSwitch }: { viewSwitch?: unknown }) => viewSwitch || null,
|
||||||
|
}));
|
||||||
|
jest.mock('@/components/SchoolRow', () => ({ SchoolRow: ({ school }: {school: School}) => <div>{school.school_name}</div> }));
|
||||||
|
jest.mock('@/components/SchoolMap', () => ({ SchoolMap: ({ schools }: {schools: School[]}) => <div data-testid="map">{schools.map(s => s.school_name).join(',')}</div> }));
|
||||||
|
|
||||||
|
const filters = { local_authorities: [], school_types: [], years: [], phases: [], genders: [], admissions_policies: [] };
|
||||||
|
function response(name: string): SchoolsResponse {
|
||||||
|
return { schools: [{ ...primaryFixture.schoolInfo, school_name: name }],
|
||||||
|
total: 2, page: 1, page_size: 1, total_pages: 2 };
|
||||||
|
}
|
||||||
|
function deferred() {
|
||||||
|
let resolve!: (value: SchoolsResponse) => void;
|
||||||
|
let reject!: (error: Error) => void;
|
||||||
|
const promise = new Promise<SchoolsResponse>((yes, no) => { resolve = yes; reject = no; });
|
||||||
|
return { promise, resolve, reject };
|
||||||
|
}
|
||||||
|
beforeEach(() => {
|
||||||
|
params = new URLSearchParams('postcode=SW1A+1AA');
|
||||||
|
jest.mocked(fetchSchools).mockReset();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('load-more results from an old search are discarded, even after returning to it', async () => {
|
||||||
|
// Name searches: a postcode search opens on the map, which has no Load more.
|
||||||
|
params = new URLSearchParams('search=abbey');
|
||||||
|
const pending = deferred();
|
||||||
|
jest.mocked(fetchSchools).mockReturnValueOnce(pending.promise);
|
||||||
|
const view = render(<HomeView initialSchools={response('Initial A')} filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'Load more schools' }));
|
||||||
|
const signal = jest.mocked(fetchSchools).mock.calls[0][1]?.signal;
|
||||||
|
params = new URLSearchParams('search=brecknock');
|
||||||
|
view.rerender(<HomeView initialSchools={response('Initial B')} filters={filters} />);
|
||||||
|
expect(signal?.aborted).toBe(true);
|
||||||
|
params = new URLSearchParams('search=abbey');
|
||||||
|
view.rerender(<HomeView initialSchools={response('Fresh A')} filters={filters} />);
|
||||||
|
await act(async () => pending.resolve(response('Stale append')));
|
||||||
|
expect(screen.queryByText('Stale append')).not.toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: 'Load more schools' })).toBeEnabled();
|
||||||
|
});
|
||||||
|
|
||||||
|
test('an older map response cannot overwrite the current search', async () => {
|
||||||
|
const first = deferred(), second = deferred();
|
||||||
|
jest.mocked(fetchSchools).mockReturnValueOnce(first.promise).mockReturnValueOnce(second.promise);
|
||||||
|
const initial = response('Initial A');
|
||||||
|
const view = render(<HomeView initialSchools={initial} filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'Map' }));
|
||||||
|
params = new URLSearchParams('postcode=SW2+1AA');
|
||||||
|
view.rerender(<HomeView initialSchools={response('Initial B')} filters={filters} />);
|
||||||
|
await act(async () => second.resolve(response('Current map')));
|
||||||
|
await act(async () => first.resolve(response('Stale map')));
|
||||||
|
expect(screen.getByTestId('map')).toHaveTextContent('Current map');
|
||||||
|
expect(screen.getByTestId('map')).not.toHaveTextContent('Stale map');
|
||||||
|
});
|
||||||
|
|
||||||
|
test('failed map requests can be retried by reopening the map', async () => {
|
||||||
|
const pending = deferred();
|
||||||
|
jest.mocked(fetchSchools).mockReturnValueOnce(pending.promise).mockResolvedValue(response('Retry result'));
|
||||||
|
render(<HomeView initialSchools={response('Initial')} filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'Map' }));
|
||||||
|
await act(async () => pending.reject(new Error('offline')));
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'List' }));
|
||||||
|
await act(async () => fireEvent.click(screen.getByRole('button', { name: 'Map' })));
|
||||||
|
expect(fetchSchools).toHaveBeenCalledTimes(2);
|
||||||
|
expect(screen.getByTestId('map')).toHaveTextContent('Retry result');
|
||||||
|
});
|
||||||
@@ -0,0 +1,107 @@
|
|||||||
|
import { act, fireEvent, render } from '@testing-library/react';
|
||||||
|
import LeafletMapInner from '@/components/LeafletMapInner';
|
||||||
|
import { primaryFixture } from '../support/schoolFixtures';
|
||||||
|
import type { School } from '@/lib/types';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* The results map's own logic, against real Leaflet in jsdom: which pin is
|
||||||
|
* selected, whether the card opens, and what the card offers. jsdom lays out
|
||||||
|
* nothing, so this pins behaviour, never positions.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const base = primaryFixture.schoolInfo;
|
||||||
|
const a: School = { ...base, urn: 1, school_name: 'Southmead Primary School', latitude: 51.43, longitude: -0.21, distance: 0.2, rwm_expected_pct: 52 };
|
||||||
|
const b: School = { ...base, urn: 2, school_name: 'Greenmead School', latitude: 51.431, longitude: -0.205, distance: 0.2,
|
||||||
|
school_type: 'Community special school', rwm_expected_pct: 0, reading_expected_pct: 0, writing_expected_pct: 0, maths_expected_pct: 0 };
|
||||||
|
const schools = [a, b];
|
||||||
|
const centre: [number, number] = [51.43, -0.21];
|
||||||
|
|
||||||
|
function setWide(wide: boolean) {
|
||||||
|
window.matchMedia = ((q: string) => ({
|
||||||
|
matches: wide, media: q, addEventListener() {}, removeEventListener() {},
|
||||||
|
})) as unknown as typeof window.matchMedia;
|
||||||
|
}
|
||||||
|
|
||||||
|
function renderMap(props: Partial<React.ComponentProps<typeof LeafletMapInner>> = {}) {
|
||||||
|
const all = {
|
||||||
|
schools, center: centre, zoom: 13, referencePoint: centre, radiusMiles: 1,
|
||||||
|
nationalAvgRwm: 62, ...props,
|
||||||
|
};
|
||||||
|
const view = render(<LeafletMapInner {...all} />);
|
||||||
|
return { ...view, rerender: (next: Partial<typeof all>) => view.rerender(<LeafletMapInner {...all} {...next} />) };
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => setWide(true));
|
||||||
|
|
||||||
|
it('draws a pin per school, the search location and the radius', () => {
|
||||||
|
const { container } = renderMap();
|
||||||
|
expect(container.querySelectorAll('.sc-pin')).toHaveLength(2);
|
||||||
|
expect(container.querySelector('.sc-home')).not.toBeNull();
|
||||||
|
expect(container.querySelector('.sc-radius-label')).toHaveTextContent('1 mile');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('reports a pin click, and marks and opens the selected school', () => {
|
||||||
|
const onMarkerClick = jest.fn();
|
||||||
|
const { container, rerender } = renderMap({ onMarkerClick });
|
||||||
|
fireEvent.click(container.querySelectorAll('.sc-pin')[0]);
|
||||||
|
expect(onMarkerClick).toHaveBeenCalledWith(a);
|
||||||
|
|
||||||
|
rerender({ onMarkerClick, selectedUrn: 1 });
|
||||||
|
expect(container.querySelectorAll('.sc-pin--selected')).toHaveLength(1);
|
||||||
|
expect(container.querySelector('.sc-popup')).toHaveTextContent('Southmead Primary School');
|
||||||
|
expect(container.querySelector('.sc-popup')).toHaveTextContent('52% RWM -10 pts');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps the special-school card free of a benchmark and a placeholder 0%', () => {
|
||||||
|
const { container } = renderMap({ selectedUrn: 2 });
|
||||||
|
const card = container.querySelector('.sc-popup')!;
|
||||||
|
expect(card).toHaveTextContent('Greenmead School');
|
||||||
|
expect(card).not.toHaveTextContent(/%|pts/);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('adds to compare from the card, and the card follows the basket', () => {
|
||||||
|
const onAddToCompare = jest.fn();
|
||||||
|
const { container, rerender } = renderMap({ onAddToCompare, selectedUrn: 1, compareUrns: [] });
|
||||||
|
fireEvent.click(container.querySelector('[data-compare]')!);
|
||||||
|
expect(onAddToCompare).toHaveBeenCalledWith(a);
|
||||||
|
|
||||||
|
rerender({ onAddToCompare, selectedUrn: 1, compareUrns: [1] });
|
||||||
|
expect(container.querySelector('[data-compare]')).toHaveTextContent('✓ Comparing');
|
||||||
|
fireEvent.click(container.querySelector('[data-compare]')!);
|
||||||
|
expect(onAddToCompare).toHaveBeenCalledTimes(2);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('tells the page when the card is closed from the map, but not when replaced', () => {
|
||||||
|
const onDeselect = jest.fn();
|
||||||
|
const { container, rerender } = renderMap({ onDeselect, selectedUrn: 1 });
|
||||||
|
rerender({ onDeselect, selectedUrn: 2 });
|
||||||
|
expect(onDeselect).not.toHaveBeenCalled();
|
||||||
|
|
||||||
|
fireEvent.click(container.querySelector('.leaflet-popup-close-button')!);
|
||||||
|
expect(onDeselect).toHaveBeenCalledTimes(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps the selection when the results reload under it', () => {
|
||||||
|
const onDeselect = jest.fn();
|
||||||
|
const { container, rerender } = renderMap({ onDeselect, selectedUrn: 1 });
|
||||||
|
act(() => rerender({ onDeselect, selectedUrn: 1, schools: [...schools] }));
|
||||||
|
expect(onDeselect).not.toHaveBeenCalled();
|
||||||
|
expect(container.querySelector('.sc-popup')).toHaveTextContent('Southmead Primary School');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('opens no card on a narrow screen, where the page shows a bottom sheet', () => {
|
||||||
|
setWide(false);
|
||||||
|
const { container } = renderMap({ selectedUrn: 1 });
|
||||||
|
expect(container.querySelectorAll('.sc-pin--selected')).toHaveLength(1);
|
||||||
|
expect(container.querySelector('.sc-popup')).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('puts the card back when the pins are rebuilt for a reason other than the schools', () => {
|
||||||
|
const onDeselect = jest.fn();
|
||||||
|
const { container, rerender } = renderMap({ onDeselect, selectedUrn: 1 });
|
||||||
|
act(() => rerender({ onDeselect, selectedUrn: 1, radiusMiles: 3, referencePoint: [51.43, -0.21] }));
|
||||||
|
expect(onDeselect).not.toHaveBeenCalled();
|
||||||
|
expect(container.querySelector('.sc-radius-label')).toHaveTextContent('3 miles');
|
||||||
|
expect(container.querySelector('.sc-popup')).toHaveTextContent('Southmead Primary School');
|
||||||
|
expect(container.querySelectorAll('.sc-pin--selected')).toHaveLength(1);
|
||||||
|
});
|
||||||
@@ -0,0 +1,92 @@
|
|||||||
|
/**
|
||||||
|
* The module that ends the stranding: before it, a school page's only anchor
|
||||||
|
* pointed at the school's own website, so ~27k pages sent authority off-site
|
||||||
|
* and none of it reached the location layer.
|
||||||
|
*/
|
||||||
|
import { render, screen } from '@testing-library/react';
|
||||||
|
import { NearbyPlaces } from '@/components/school/NearbyPlaces';
|
||||||
|
|
||||||
|
const essex = { kind: 'authority', slug: 'essex', name: 'Essex', count: 480, url: '/schools/authority/essex', phases: [] };
|
||||||
|
const brentwood = { kind: 'town', slug: 'brentwood', name: 'Brentwood', count: 37, url: '/schools/brentwood', phases: [] };
|
||||||
|
const cm15 = { kind: 'outcode', slug: 'cm15', name: 'CM15', count: 12, url: '/schools/near/cm15', phases: [] };
|
||||||
|
|
||||||
|
describe('NearbyPlaces', () => {
|
||||||
|
it('links to every place the school belongs to', () => {
|
||||||
|
render(<NearbyPlaces places={[essex, brentwood, cm15]} />);
|
||||||
|
|
||||||
|
expect(screen.getByRole('link', { name: /Brentwood/ }))
|
||||||
|
.toHaveAttribute('href', '/schools/brentwood');
|
||||||
|
expect(screen.getByRole('link', { name: /Essex/ }))
|
||||||
|
.toHaveAttribute('href', '/schools/authority/essex');
|
||||||
|
expect(screen.getByRole('link', { name: /CM15/ }))
|
||||||
|
.toHaveAttribute('href', '/schools/near/cm15');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('says how many schools each link leads to', () => {
|
||||||
|
// An anchor that states its destination's size is worth more to a reader
|
||||||
|
// and to a crawler than "see more".
|
||||||
|
render(<NearbyPlaces places={[brentwood]} />);
|
||||||
|
expect(screen.getByRole('link', { name: /37 schools in Brentwood/ }))
|
||||||
|
.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders nothing at all when the school has no published places', () => {
|
||||||
|
// Not an empty heading. A school whose town and authority both fall below
|
||||||
|
// the threshold has nowhere to point, and the page should look as it did
|
||||||
|
// before the module existed.
|
||||||
|
const { container } = render(<NearbyPlaces places={[]} />);
|
||||||
|
expect(container).toBeEmptyDOMElement();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('puts the narrowest place first, which is the most useful link', () => {
|
||||||
|
// The API orders widest-first for the breadcrumb; a reader on a school
|
||||||
|
// page wants its town before its county.
|
||||||
|
render(<NearbyPlaces places={[essex, brentwood, cm15]} />);
|
||||||
|
const hrefs = screen.getAllByRole('link').map((a) => a.getAttribute('href'));
|
||||||
|
expect(hrefs.indexOf('/schools/brentwood'))
|
||||||
|
.toBeLessThan(hrefs.indexOf('/schools/authority/essex'));
|
||||||
|
});
|
||||||
|
|
||||||
|
it('handles a singular count without saying "1 schools"', () => {
|
||||||
|
render(<NearbyPlaces places={[{ ...brentwood, count: 1 }]} />);
|
||||||
|
expect(screen.getByRole('link', { name: /1 school in Brentwood/ }))
|
||||||
|
.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('links the phase page the school appears on', () => {
|
||||||
|
// "primary schools in brentwood" is the query these pages exist for.
|
||||||
|
render(<NearbyPlaces places={[{
|
||||||
|
...brentwood,
|
||||||
|
phases: [{ phase: 'primary', count: 22, url: '/schools/brentwood/primary' }],
|
||||||
|
}]} />);
|
||||||
|
|
||||||
|
expect(screen.getByRole('link', { name: /22 primary schools in Brentwood/ }))
|
||||||
|
.toHaveAttribute('href', '/schools/brentwood/primary');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('links both phase pages for an all-through school', () => {
|
||||||
|
render(<NearbyPlaces places={[{
|
||||||
|
...brentwood,
|
||||||
|
phases: [
|
||||||
|
{ phase: 'primary', count: 22, url: '/schools/brentwood/primary' },
|
||||||
|
{ phase: 'secondary', count: 9, url: '/schools/brentwood/secondary' },
|
||||||
|
],
|
||||||
|
}]} />);
|
||||||
|
|
||||||
|
expect(screen.getByRole('link', { name: /22 primary schools/ })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('link', { name: /9 secondary schools/ })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps a phase link next to the place it belongs to', () => {
|
||||||
|
// Grouping matters: "22 primary schools in Brentwood" directly after
|
||||||
|
// "37 schools in Brentwood" reads as one place, not two unrelated links.
|
||||||
|
render(<NearbyPlaces places={[essex, {
|
||||||
|
...brentwood,
|
||||||
|
phases: [{ phase: 'primary', count: 22, url: '/schools/brentwood/primary' }],
|
||||||
|
}]} />);
|
||||||
|
|
||||||
|
const hrefs = screen.getAllByRole('link').map((a) => a.getAttribute('href'));
|
||||||
|
expect(hrefs.indexOf('/schools/brentwood/primary'))
|
||||||
|
.toBe(hrefs.indexOf('/schools/brentwood') + 1);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,192 @@
|
|||||||
|
/**
|
||||||
|
* The section's job is to be honest about what it is showing. These tests pin
|
||||||
|
* the ways it could mislead: rendering below the minimum, claiming a likeness
|
||||||
|
* it does not rank on, showing a missing figure as a number, or hiding a card
|
||||||
|
* behind an arrow where a crawler cannot reach it.
|
||||||
|
*/
|
||||||
|
|
||||||
|
import { render, screen } from '@testing-library/react';
|
||||||
|
|
||||||
|
import {
|
||||||
|
nearbyNoun,
|
||||||
|
NearbySchoolsSection,
|
||||||
|
shouldRenderNearby,
|
||||||
|
} from '@/components/school/NearbySchoolsSection';
|
||||||
|
import type { NearbySchool } from '@/lib/types';
|
||||||
|
|
||||||
|
jest.mock('@/components/school/AddToCompareButton', () => ({
|
||||||
|
AddToCompareButton: ({ school }: { school: NearbySchool }) => (
|
||||||
|
<button type="button">Add {school.school_name} to compare</button>
|
||||||
|
),
|
||||||
|
}));
|
||||||
|
|
||||||
|
jest.mock('@/components/school/NearbySchoolsCompareBar', () => ({
|
||||||
|
NearbySchoolsCompareBar: ({ thisUrn }: { thisUrn: number }) => (
|
||||||
|
<div data-testid="compare-bar">bar for {thisUrn}</div>
|
||||||
|
),
|
||||||
|
}));
|
||||||
|
|
||||||
|
function school(overrides: Partial<NearbySchool> = {}): NearbySchool {
|
||||||
|
return {
|
||||||
|
urn: 100002,
|
||||||
|
school_name: 'Willow Lane Primary School',
|
||||||
|
distance_miles: 0.6,
|
||||||
|
school_type: 'Community school',
|
||||||
|
age_range: '4-11',
|
||||||
|
shared: ['Mixed', 'No religious character'],
|
||||||
|
metric_value: 74,
|
||||||
|
metric_key: 'rwm_expected_pct',
|
||||||
|
metric_year: 202425,
|
||||||
|
...overrides,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function renderSection(nearby: NearbySchool[]) {
|
||||||
|
return render(
|
||||||
|
<NearbySchoolsSection
|
||||||
|
urn={100001}
|
||||||
|
schoolName="Meadowbrook Primary School"
|
||||||
|
phase="Primary"
|
||||||
|
thisMetricValue={72}
|
||||||
|
nearby={nearby}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('render gates', () => {
|
||||||
|
it.each([
|
||||||
|
['undefined', undefined],
|
||||||
|
['null', null],
|
||||||
|
['empty', []],
|
||||||
|
['a single school', [school()]],
|
||||||
|
])('renders nothing for %s', (_label, value) => {
|
||||||
|
expect(shouldRenderNearby(value as NearbySchool[] | null | undefined)).toBe(false);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders for two or more schools', () => {
|
||||||
|
expect(shouldRenderNearby([school(), school({ urn: 100003 })])).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('returns null rather than an empty shell below the minimum', () => {
|
||||||
|
const { container } = renderSection([school()]);
|
||||||
|
expect(container).toBeEmptyDOMElement();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('what the section claims', () => {
|
||||||
|
it('never claims a similar intake, because it does not rank on one', () => {
|
||||||
|
renderSection([school(), school({ urn: 100003, shared: [] })]);
|
||||||
|
expect(screen.queryByText(/similar intake/i)).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is headed "Other schools nearby", not "similar"', () => {
|
||||||
|
renderSection([school(), school({ urn: 100003 })]);
|
||||||
|
expect(screen.getByRole('heading', { name: 'Other schools nearby' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows chips for what is shared', () => {
|
||||||
|
renderSection([school({ shared: ['Mixed', 'Roman Catholic'] }), school({ urn: 100003 })]);
|
||||||
|
expect(screen.getAllByText('Roman Catholic').length).toBe(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows no chips at all when nothing is shared, rather than inventing one', () => {
|
||||||
|
const { container } = render(
|
||||||
|
<NearbySchoolsSection
|
||||||
|
urn={100001}
|
||||||
|
schoolName="Meadowbrook Primary School"
|
||||||
|
phase="Primary"
|
||||||
|
thisMetricValue={72}
|
||||||
|
nearby={[school({ shared: [] }), school({ urn: 100003, shared: [] })]}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
// The card still carries its distance, name, type and figure — just no
|
||||||
|
// claim of likeness.
|
||||||
|
expect(container.querySelectorAll('li ul').length).toBe(0);
|
||||||
|
expect(screen.getAllByText(/miles away/).length).toBe(2);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('what the lede calls the set', () => {
|
||||||
|
it.each([
|
||||||
|
['Primary', 'primary schools'],
|
||||||
|
['Middle deemed primary', 'primary schools'],
|
||||||
|
['Secondary', 'secondary schools'],
|
||||||
|
['Middle deemed secondary', 'secondary schools'],
|
||||||
|
['All-through', 'all-through schools'],
|
||||||
|
// GIAS phase 6. Its candidates span the whole secondary group, so no
|
||||||
|
// single noun fits and it takes the honest general one.
|
||||||
|
['16 plus', 'schools and colleges'],
|
||||||
|
['', 'schools'],
|
||||||
|
[null, 'schools'],
|
||||||
|
])('calls a %s school\'s neighbours "%s"', (phase, expected) => {
|
||||||
|
expect(nearbyNoun(phase)).toBe(expected);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('never calls a sixth form college\'s neighbours primary schools', () => {
|
||||||
|
render(
|
||||||
|
<NearbySchoolsSection
|
||||||
|
urn={100001}
|
||||||
|
schoolName="Barnet Sixth Form College"
|
||||||
|
phase="16 plus"
|
||||||
|
thisMetricValue={null}
|
||||||
|
nearby={[school(), school({ urn: 100003 })]}
|
||||||
|
/>,
|
||||||
|
);
|
||||||
|
expect(screen.getByText(/Other schools and colleges near Barnet Sixth Form College/)).toBeInTheDocument();
|
||||||
|
expect(screen.queryByText(/primary schools/)).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('cards', () => {
|
||||||
|
it('links each school to its canonical slug', () => {
|
||||||
|
renderSection([school(), school({ urn: 100003, school_name: 'Oakfield Primary School' })]);
|
||||||
|
const link = screen.getByRole('link', { name: /Willow Lane Primary School/ });
|
||||||
|
expect(link).toHaveAttribute('href', '/school/100002-willow-lane-primary-school');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows the distance and the shared characteristics', () => {
|
||||||
|
renderSection([school(), school({ urn: 100003 })]);
|
||||||
|
expect(screen.getAllByText('0.6 miles away').length).toBeGreaterThan(0);
|
||||||
|
expect(screen.getAllByText('Mixed').length).toBeGreaterThan(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('renders a missing figure as "Not published", never as a number', () => {
|
||||||
|
renderSection([school({ metric_value: null }), school({ urn: 100003 })]);
|
||||||
|
expect(screen.getByText('Not published')).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('anchors each figure against this school', () => {
|
||||||
|
renderSection([school(), school({ urn: 100003 })]);
|
||||||
|
expect(screen.getAllByText('72% at this school').length).toBe(2);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('offers the compare bar once, for this school', () => {
|
||||||
|
renderSection([school(), school({ urn: 100003 })]);
|
||||||
|
expect(screen.getByTestId('compare-bar')).toHaveTextContent('bar for 100001');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps every card in the DOM, including the ones scrolled out of view', () => {
|
||||||
|
const six = Array.from({ length: 6 }, (_, n) =>
|
||||||
|
school({ urn: 100002 + n, school_name: `Peer ${n} School` }),
|
||||||
|
);
|
||||||
|
renderSection(six);
|
||||||
|
expect(screen.getAllByRole('link', { name: /Peer \d School/ })).toHaveLength(6);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('offers no arrows when three cards fit the row', () => {
|
||||||
|
renderSection([school(), school({ urn: 100003 }), school({ urn: 100004 })]);
|
||||||
|
expect(screen.queryByRole('button', { name: /More schools/ })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('offers arrows once there is a fourth school', () => {
|
||||||
|
renderSection(Array.from({ length: 4 }, (_, n) => school({ urn: 100002 + n })));
|
||||||
|
expect(screen.getByRole('button', { name: /More schools/ })).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: /Previous schools/ })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('says distances are straight-line, and offers no method panel', () => {
|
||||||
|
const { container } = renderSection([school(), school({ urn: 100003 })]);
|
||||||
|
expect(screen.getByText(/straight-line from this school/i)).toBeInTheDocument();
|
||||||
|
expect(container.querySelector('details')).toBeNull();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,195 @@
|
|||||||
|
import { act, fireEvent, render, screen, within } from '@testing-library/react';
|
||||||
|
import { HomeView } from '@/components/HomeView';
|
||||||
|
import { fetchSchools, fetchNationalAverages } from '@/lib/api';
|
||||||
|
import { primaryFixture } from '../support/schoolFixtures';
|
||||||
|
import type { School, SchoolsResponse } from '@/lib/types';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* The map view: the list beside the map (mockup B), where every postcode
|
||||||
|
* search opens. The map itself is Leaflet and mocked here; what is pinned is what
|
||||||
|
* HomeView hands it and the list it draws beside it.
|
||||||
|
*/
|
||||||
|
|
||||||
|
let params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push: jest.fn(), replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/context/ComparisonContext', () => ({
|
||||||
|
useComparisonContext: () => ({ addSchool: jest.fn(), removeSchool: jest.fn(), selectedSchools: [] }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/api', () => ({
|
||||||
|
fetchSchools: jest.fn(),
|
||||||
|
fetchNationalAverages: jest.fn(),
|
||||||
|
fetchLAaverages: jest.fn(async () => ({ secondary: { attainment_8_by_la: {} } })),
|
||||||
|
}));
|
||||||
|
// Renders only the List/Map switch HomeView hands it, which lives in its row.
|
||||||
|
jest.mock('@/components/FilterBar', () => ({
|
||||||
|
FilterBar: ({ viewSwitch }: { viewSwitch?: unknown }) => viewSwitch || null,
|
||||||
|
}));
|
||||||
|
jest.mock('@/components/SchoolMap', () => ({
|
||||||
|
SchoolMap: ({ selectedUrn, radiusMiles, onMarkerClick, schools }: {
|
||||||
|
selectedUrn: number | null; radiusMiles?: number;
|
||||||
|
onMarkerClick: (s: School) => void; schools: School[];
|
||||||
|
}) => (
|
||||||
|
<div data-testid="map" data-selected={selectedUrn ?? ''} data-radius={radiusMiles}>
|
||||||
|
<button type="button" onClick={() => onMarkerClick(schools[1])}>pin</button>
|
||||||
|
</div>
|
||||||
|
),
|
||||||
|
}));
|
||||||
|
|
||||||
|
const base = primaryFixture.schoolInfo;
|
||||||
|
const southmead: School = {
|
||||||
|
...base, urn: 2, school_name: 'Southmead Primary School', distance: 0.2,
|
||||||
|
school_type: 'Community school', rwm_expected_pct: 52, total_pupils: 269,
|
||||||
|
};
|
||||||
|
const greenmead: School = {
|
||||||
|
...base, urn: 3, school_name: 'Greenmead School', distance: 0.2,
|
||||||
|
school_type: 'Community special school', rwm_expected_pct: 0,
|
||||||
|
reading_expected_pct: 0, writing_expected_pct: 0, maths_expected_pct: 0, total_pupils: 62,
|
||||||
|
};
|
||||||
|
const ourLady: School = {
|
||||||
|
...base, urn: 1, school_name: 'Our Lady Queen of Heaven RC School', distance: 0,
|
||||||
|
school_type: 'Voluntary aided school', rwm_expected_pct: 70, total_pupils: 224,
|
||||||
|
};
|
||||||
|
|
||||||
|
function results(): SchoolsResponse {
|
||||||
|
return {
|
||||||
|
schools: [ourLady, southmead, greenmead], total: 3, page: 1, page_size: 25, total_pages: 1,
|
||||||
|
location_info: { postcode: 'SW196AR', radius: 1.60934, coordinates: [51.42, -0.21] },
|
||||||
|
} as SchoolsResponse;
|
||||||
|
}
|
||||||
|
const filters = { local_authorities: [], school_types: [], years: [], phases: [], genders: [], admissions_policies: [] };
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
jest.mocked(fetchSchools).mockReset().mockResolvedValue(results());
|
||||||
|
jest.mocked(fetchNationalAverages).mockResolvedValue({ primary: { rwm_expected_pct: 62 } } as never);
|
||||||
|
setWide(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
/** Desktop unless a test says otherwise: the list pane is shown from 769px. */
|
||||||
|
function setWide(wide: boolean) {
|
||||||
|
window.matchMedia = ((q: string) => ({
|
||||||
|
matches: wide, media: q, addEventListener() {}, removeEventListener() {},
|
||||||
|
})) as unknown as typeof window.matchMedia;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function renderMap() {
|
||||||
|
const view = render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
await act(async () => {});
|
||||||
|
return view;
|
||||||
|
}
|
||||||
|
|
||||||
|
it('opens a postcode search on the map', async () => {
|
||||||
|
await renderMap();
|
||||||
|
expect(screen.getByTestId('map')).toHaveAttribute('data-radius', '1');
|
||||||
|
expect(screen.getByRole('button', { name: 'Map' })).toHaveAttribute('aria-pressed', 'true');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('lists a name search, which has no map', async () => {
|
||||||
|
params = new URLSearchParams('search=southmead');
|
||||||
|
render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
await act(async () => {});
|
||||||
|
expect(screen.queryByTestId('map')).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('puts the count and the sort in the list beside the map, once', async () => {
|
||||||
|
await renderMap();
|
||||||
|
// Short beside the map, so it shares one line with the sort.
|
||||||
|
expect(screen.getAllByRole('heading', { name: '3 schools within 1 mile' })).toHaveLength(1);
|
||||||
|
expect(screen.getAllByRole('combobox')).toHaveLength(1);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('selects the pin from the card, and the card from the pin', async () => {
|
||||||
|
const { container } = await renderMap();
|
||||||
|
const card = (urn: number) => container.querySelector(`[data-urn="${urn}"]`) as HTMLElement;
|
||||||
|
|
||||||
|
fireEvent.click(within(card(1)).getByText(/pupils/));
|
||||||
|
expect(screen.getByTestId('map')).toHaveAttribute('data-selected', '1');
|
||||||
|
expect(card(1).className).toMatch(/mapRowSelected/);
|
||||||
|
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'pin' }));
|
||||||
|
expect(card(2).className).toMatch(/mapRowSelected/);
|
||||||
|
expect(card(1).className).not.toMatch(/mapRowSelected/);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('clicking a card\'s link or button does not also select it', async () => {
|
||||||
|
const { container } = await renderMap();
|
||||||
|
const card = container.querySelector('[data-urn="1"]') as HTMLElement;
|
||||||
|
fireEvent.click(within(card).getByRole('button', { name: '+ Compare' }));
|
||||||
|
expect(screen.getByTestId('map')).toHaveAttribute('data-selected', '');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('shows the England comparison for mainstream schools only, and never a placeholder 0%', async () => {
|
||||||
|
const { container } = await renderMap();
|
||||||
|
const card = (urn: number) => container.querySelector(`[data-urn="${urn}"]`) as HTMLElement;
|
||||||
|
expect(card(2)).toHaveTextContent('52%Reading, Writing & Maths-10 pts vs national');
|
||||||
|
expect(card(2)).toHaveTextContent('269pupils');
|
||||||
|
expect(card(3)).toHaveTextContent('62pupils');
|
||||||
|
expect(card(3)).not.toHaveTextContent(/%|pts/);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('opens the map after a hero search, and keeps the reader\'s choice after that', async () => {
|
||||||
|
// Landing page, then a hero search: the same instance gets new props.
|
||||||
|
params = new URLSearchParams('');
|
||||||
|
const empty = { schools: [], total: 0, page: 1, page_size: 25, total_pages: 0 } as SchoolsResponse;
|
||||||
|
const view = render(<HomeView initialSchools={empty} filters={filters} />);
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
view.rerender(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
await act(async () => {});
|
||||||
|
expect(screen.getByTestId('map')).toBeInTheDocument();
|
||||||
|
|
||||||
|
// Chosen: a later search keeps the list.
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'List' }));
|
||||||
|
params = new URLSearchParams('postcode=SW170AA&radius=1');
|
||||||
|
view.rerender(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
await act(async () => {});
|
||||||
|
expect(screen.queryByTestId('map')).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('builds no list cards on a phone, where the pane is hidden', async () => {
|
||||||
|
setWide(false);
|
||||||
|
const { container } = await renderMap();
|
||||||
|
expect(screen.getByTestId('map')).toBeInTheDocument();
|
||||||
|
expect(container.querySelectorAll('[data-urn]')).toHaveLength(0);
|
||||||
|
// The count stays: it is the pane's heading, shown above the map.
|
||||||
|
expect(screen.getByRole('heading', { name: /3 schools within/ })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('draws the list view\'s own row beside the map, with the same content', async () => {
|
||||||
|
const { container } = await renderMap();
|
||||||
|
const beside = container.querySelector('[data-urn="2"] > [class~="row"]')!.textContent;
|
||||||
|
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'List' }));
|
||||||
|
const row = screen.getByRole('link', { name: 'Southmead Primary School' }).closest('[class~="row"]')!;
|
||||||
|
expect(row.parentElement?.className).toMatch(/schoolList/);
|
||||||
|
expect(row.textContent).toBe(beside);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('lets a keyboard pick a pin from the list, with a real button', async () => {
|
||||||
|
await renderMap();
|
||||||
|
const show = screen.getByRole('button', { name: 'Show Southmead Primary School on the map' });
|
||||||
|
expect(show).toHaveAttribute('aria-pressed', 'false');
|
||||||
|
fireEvent.click(show);
|
||||||
|
expect(screen.getByTestId('map')).toHaveAttribute('data-selected', '2');
|
||||||
|
expect(show).toHaveAttribute('aria-pressed', 'true');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps the postcode in the heading in list view, where there is room', async () => {
|
||||||
|
await renderMap();
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'List' }));
|
||||||
|
expect(screen.getByRole('heading', { name: '3 schools within 1 mile of SW196AR' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('draws and names a quarter-mile search as 0.25, not rounded to 0.3', async () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=0.25');
|
||||||
|
const quarter = { ...results(), location_info: { postcode: 'SW196AR', radius: 0.25 * 1.60934, coordinates: [51.42, -0.21] } } as SchoolsResponse;
|
||||||
|
render(<HomeView initialSchools={quarter} filters={filters} />);
|
||||||
|
await act(async () => {});
|
||||||
|
expect(screen.getByTestId('map')).toHaveAttribute('data-radius', '0.25');
|
||||||
|
expect(screen.getByRole('heading', { name: '3 schools within 0.25 miles' })).toBeInTheDocument();
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'List' }));
|
||||||
|
expect(screen.getByRole('heading', { name: '3 schools within 0.25 miles of SW196AR' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
@@ -0,0 +1,198 @@
|
|||||||
|
import { act, fireEvent, render, screen, within } from '@testing-library/react';
|
||||||
|
import { HomeView } from '@/components/HomeView';
|
||||||
|
import { FilterBar } from '@/components/FilterBar';
|
||||||
|
import { fetchSchools } from '@/lib/api';
|
||||||
|
import { track } from '@/lib/analytics';
|
||||||
|
import { primaryFixture } from '../support/schoolFixtures';
|
||||||
|
import type { SchoolsResponse } from '@/lib/types';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* The results toolbar (option B of the 2026-09-30 results-controls mockups):
|
||||||
|
* search, filters and the List/Map switch pinned under the header, with a
|
||||||
|
* floating List/Map button standing in for the switch on phones. Layout is CSS
|
||||||
|
* and not visible to jsdom; these pin the behaviour and the accessible names
|
||||||
|
* the E2E journeys rely on.
|
||||||
|
*/
|
||||||
|
|
||||||
|
let params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
const push = jest.fn();
|
||||||
|
jest.mock('next/navigation', () => ({
|
||||||
|
useSearchParams: () => params,
|
||||||
|
usePathname: () => '/',
|
||||||
|
useRouter: () => ({ push, replace: jest.fn(), prefetch: jest.fn() }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/context/ComparisonContext', () => ({
|
||||||
|
useComparisonContext: () => ({ addSchool: jest.fn(), removeSchool: jest.fn(), selectedSchools: [] }),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/api', () => ({
|
||||||
|
fetchSchools: jest.fn(),
|
||||||
|
fetchNationalAverages: jest.fn(async () => ({})),
|
||||||
|
fetchLAaverages: jest.fn(async () => ({ secondary: { attainment_8_by_la: {} } })),
|
||||||
|
}));
|
||||||
|
jest.mock('@/lib/analytics', () => ({ track: jest.fn() }));
|
||||||
|
jest.mock('@/components/SchoolMap', () => ({ SchoolMap: () => <div data-testid="map" /> }));
|
||||||
|
|
||||||
|
const filters = {
|
||||||
|
local_authorities: ['Wandsworth'], school_types: ['Community school'], years: [],
|
||||||
|
phases: ['Primary', 'Secondary'], genders: [], admissions_policies: [],
|
||||||
|
school_type_groups: [{ value: 'council', label: 'State school: council-run' }],
|
||||||
|
};
|
||||||
|
|
||||||
|
function results(): SchoolsResponse {
|
||||||
|
return { schools: [{ ...primaryFixture.schoolInfo, school_name: 'Southmead Primary School' }],
|
||||||
|
total: 1, page: 1, page_size: 25, total_pages: 1 };
|
||||||
|
}
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1');
|
||||||
|
push.mockClear();
|
||||||
|
jest.mocked(track).mockClear();
|
||||||
|
jest.mocked(fetchSchools).mockReset().mockResolvedValue(results());
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the List/Map switch', () => {
|
||||||
|
it('lives in the toolbar with the filters and says which view is on', () => {
|
||||||
|
render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
const view = screen.getByRole('group', { name: 'Results view' });
|
||||||
|
expect(view.closest('div[class*="resultsToolbar"]')).not.toBeNull();
|
||||||
|
// A postcode search opens on the map.
|
||||||
|
expect(screen.getByRole('button', { name: 'Map' })).toHaveAttribute('aria-pressed', 'true');
|
||||||
|
expect(screen.getByRole('button', { name: 'List' })).toHaveAttribute('aria-pressed', 'false');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('has a floating twin that flips between map and list', async () => {
|
||||||
|
render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
await act(async () => {});
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'Show list' }));
|
||||||
|
expect(screen.queryByTestId('map')).not.toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: 'List' })).toHaveAttribute('aria-pressed', 'true');
|
||||||
|
expect(track).toHaveBeenCalledWith('results_view_changed', { view: 'list', via: 'floating' });
|
||||||
|
|
||||||
|
await act(async () => fireEvent.click(screen.getByRole('button', { name: 'Show map' })));
|
||||||
|
expect(screen.getByTestId('map')).toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('button', { name: 'Show list' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('does not track a click on the view already showing', async () => {
|
||||||
|
render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
await act(async () => {});
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'Map' }));
|
||||||
|
expect(track).not.toHaveBeenCalledWith('results_view_changed', expect.anything());
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is absent from a name search, which has no map', () => {
|
||||||
|
params = new URLSearchParams('search=southmead');
|
||||||
|
render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
expect(screen.queryByRole('group', { name: 'Results view' })).not.toBeInTheDocument();
|
||||||
|
expect(screen.queryByRole('button', { name: 'Show map' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the toolbar filters', () => {
|
||||||
|
it('keeps distance, phase and school type in the row, not behind More filters', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const row = screen.getByRole('group', { name: 'Filters' });
|
||||||
|
for (const name of ['Distance', 'Phase', 'School type']) {
|
||||||
|
expect(row).toContainElement(screen.getByRole('combobox', { name }));
|
||||||
|
}
|
||||||
|
expect(screen.getByRole('combobox', { name: 'Distance' })).toHaveDisplayValue('Within 1 mile');
|
||||||
|
expect(screen.queryByRole('combobox', { name: 'Local authority' })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('counts only what More filters hides', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&school_type=council&local_authority=Wandsworth');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.getByRole('button', { name: /More filters \(1\)/ })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the phone chips line', () => {
|
||||||
|
it('drops its "more this way" fade when nothing is left to scroll', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=1&phase=primary');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
// jsdom lays nothing out, so the line reads as not overflowing at all.
|
||||||
|
const line = screen.getByRole('group', { name: 'Applied filters' }).parentElement!;
|
||||||
|
expect(line.className).toMatch(/controlsAtEnd/);
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the phone filter sheet', () => {
|
||||||
|
it('offers the results total', () => {
|
||||||
|
render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: 'Filters' }));
|
||||||
|
expect(screen.getByRole('button', { name: 'Show 1 school' })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the folded search', () => {
|
||||||
|
it('summarises the search and unfolds on tap', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
const summary = screen.getByRole('button', { name: 'Edit search: SW196AR, within 1 mile' });
|
||||||
|
fireEvent.click(summary);
|
||||||
|
expect(screen.queryByRole('button', { name: /Edit search/ })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('folds again once the edited search is submitted', () => {
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /Edit search/ }));
|
||||||
|
const input = screen.getByRole('searchbox', { name: 'School name or postcode' });
|
||||||
|
fireEvent.change(input, { target: { value: 'SW19 1AA' } });
|
||||||
|
fireEvent.submit(input.closest('form')!);
|
||||||
|
expect(screen.getByRole('button', { name: /Edit search/ })).toBeInTheDocument();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('refolds and shows the new text when the search changes some other way', () => {
|
||||||
|
const view = render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /Edit search/ }));
|
||||||
|
fireEvent.change(screen.getByRole('searchbox', { name: 'School name or postcode' }),
|
||||||
|
{ target: { value: 'half-typed' } });
|
||||||
|
|
||||||
|
// Back button: the URL changes under the component, nothing is submitted.
|
||||||
|
params = new URLSearchParams('postcode=SW170AA&radius=3');
|
||||||
|
view.rerender(<FilterBar filters={filters} />);
|
||||||
|
|
||||||
|
expect(screen.getByRole('button', { name: 'Edit search: SW170AA, within 3 miles' }))
|
||||||
|
.toBeInTheDocument();
|
||||||
|
expect(screen.getByRole('searchbox', { name: 'School name or postcode' }))
|
||||||
|
.toHaveValue('SW170AA');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('never appears in the hero, or before anything has been searched', () => {
|
||||||
|
const { unmount } = render(<FilterBar filters={filters} isHero />);
|
||||||
|
expect(screen.queryByRole('button', { name: /Edit search/ })).not.toBeInTheDocument();
|
||||||
|
unmount();
|
||||||
|
params = new URLSearchParams('local_authority=Wandsworth');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(screen.queryByRole('button', { name: /Edit search/ })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the results list', () => {
|
||||||
|
it('repeats no applied filters above the results; the filter bar shows them', () => {
|
||||||
|
params = new URLSearchParams('search=southmead&school_type=council&local_authority=Wandsworth');
|
||||||
|
const { container } = render(<HomeView initialSchools={results()} filters={filters} />);
|
||||||
|
expect(container.querySelector('[class*="activeFilters"]')).toBeNull();
|
||||||
|
expect(screen.queryByText('Search: southmead')).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
describe('the desktop Clear all', () => {
|
||||||
|
const row = () => screen.getByRole('group', { name: 'Filters' });
|
||||||
|
|
||||||
|
it('removes the filters and keeps the search, rather than going home', () => {
|
||||||
|
params = new URLSearchParams('postcode=SW196AR&radius=3&phase=primary&school_type=council&local_authority=Wandsworth');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
fireEvent.click(within(row()).getByRole('button', { name: 'Clear all' }));
|
||||||
|
const pushed = push.mock.calls.at(-1)![0] as string;
|
||||||
|
const next = new URLSearchParams(pushed.split('?')[1]);
|
||||||
|
expect(next.get('postcode')).toBe('SW196AR');
|
||||||
|
expect(next.get('radius')).toBe('3');
|
||||||
|
for (const key of ['phase', 'school_type', 'local_authority']) expect(next.get(key)).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is not offered when only a search is applied', () => {
|
||||||
|
params = new URLSearchParams('search=southmead');
|
||||||
|
render(<FilterBar filters={filters} />);
|
||||||
|
expect(within(row()).queryByRole('button', { name: /^Clear/ })).not.toBeInTheDocument();
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -119,10 +119,13 @@ describe('third-party surfaces under themed text', () => {
|
|||||||
|
|
||||||
it('still finds a component painting themed text into a Leaflet popup', () => {
|
it('still finds a component painting themed text into a Leaflet popup', () => {
|
||||||
// Guards the rule below against passing vacuously if the popups are ever
|
// Guards the rule below against passing vacuously if the popups are ever
|
||||||
// rewritten as React components rather than HTML strings.
|
// rewritten as React components rather than HTML strings. The results
|
||||||
|
// map's card themes its text through classes in SchoolMap.module.css
|
||||||
|
// rather than inline, so a class-built popup counts as well.
|
||||||
const themed = sources(COMPONENTS).filter((file) => {
|
const themed = sources(COMPONENTS).filter((file) => {
|
||||||
const src = fs.readFileSync(file, 'utf8');
|
const src = fs.readFileSync(file, 'utf8');
|
||||||
return /bindPopup\(/.test(src) && /color:var\(--|color: var\(--/.test(src);
|
return /bindPopup\(|L\.popup\(/.test(src)
|
||||||
|
&& (/color:var\(--|color: var\(--/.test(src) || /class="sc-card/.test(src));
|
||||||
});
|
});
|
||||||
|
|
||||||
expect(themed.length).toBeGreaterThan(0);
|
expect(themed.length).toBeGreaterThan(0);
|
||||||
|
|||||||
@@ -0,0 +1,72 @@
|
|||||||
|
import fs from 'fs';
|
||||||
|
import path from 'path';
|
||||||
|
import ts from 'typescript';
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Keeps the em dash out of public copy.
|
||||||
|
*
|
||||||
|
* Every visitor-facing sentence was rewritten to use a colon, comma, full stop
|
||||||
|
* or parentheses instead. A new one slips back in unnoticed, because it reads
|
||||||
|
* fine to whoever wrote it, so this walks the source with the TypeScript parser
|
||||||
|
* and checks every string literal, template chunk and JSX text node. Comments
|
||||||
|
* are not nodes the walk visits, so they stay free to use it.
|
||||||
|
*
|
||||||
|
* Two uses are allowed:
|
||||||
|
* - a lone dash standing in for a missing value in a table cell or stat slot,
|
||||||
|
* which is a data convention rather than prose;
|
||||||
|
* - the message of a thrown Error, which only a developer reads.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const ROOT = path.join(__dirname, '..', '..');
|
||||||
|
const SCANNED = ['app', 'components', 'lib'];
|
||||||
|
const SKIPPED = [path.join(ROOT, 'app', '(payload)')];
|
||||||
|
|
||||||
|
function sources(dir: string): string[] {
|
||||||
|
if (SKIPPED.includes(dir)) return [];
|
||||||
|
return fs.readdirSync(dir, { withFileTypes: true }).flatMap((entry) => {
|
||||||
|
const full = path.join(dir, entry.name);
|
||||||
|
if (entry.isDirectory()) return sources(full);
|
||||||
|
return /\.tsx?$/.test(entry.name) ? [full] : [];
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
function isErrorMessage(node: ts.Node): boolean {
|
||||||
|
for (let p = node.parent; p; p = p.parent) {
|
||||||
|
if (ts.isNewExpression(p) && /Error$/.test(p.expression.getText())) return true;
|
||||||
|
if (ts.isStatement(p)) return false;
|
||||||
|
}
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
const EMPTY_VALUE = /^(—|—)$/;
|
||||||
|
|
||||||
|
function dashedCopy(file: string): string[] {
|
||||||
|
const text = fs.readFileSync(file, 'utf8');
|
||||||
|
const kind = file.endsWith('.tsx') ? ts.ScriptKind.TSX : ts.ScriptKind.TS;
|
||||||
|
const sf = ts.createSourceFile(file, text, ts.ScriptTarget.Latest, true, kind);
|
||||||
|
const found: string[] = [];
|
||||||
|
const visit = (node: ts.Node) => {
|
||||||
|
if (
|
||||||
|
ts.isStringLiteral(node) || ts.isNoSubstitutionTemplateLiteral(node) || ts.isJsxText(node)
|
||||||
|
|| ts.isTemplateHead(node) || ts.isTemplateMiddle(node) || ts.isTemplateTail(node)
|
||||||
|
) {
|
||||||
|
const copy = node.getText().replace(/\s+/g, ' ').trim();
|
||||||
|
const bare = node.text.trim();
|
||||||
|
if (/—|—/.test(copy) && !EMPTY_VALUE.test(bare) && !isErrorMessage(node)) {
|
||||||
|
const { line } = sf.getLineAndCharacterOfPosition(node.getStart());
|
||||||
|
found.push(`${path.relative(ROOT, file)}:${line + 1} ${copy}`);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ts.forEachChild(node, visit);
|
||||||
|
};
|
||||||
|
visit(sf);
|
||||||
|
return found;
|
||||||
|
}
|
||||||
|
|
||||||
|
describe('public copy', () => {
|
||||||
|
it('uses no em dashes', () => {
|
||||||
|
const files = SCANNED.flatMap((dir) => sources(path.join(ROOT, dir)));
|
||||||
|
expect(files.length).toBeGreaterThan(50);
|
||||||
|
expect(files.flatMap(dashedCopy)).toEqual([]);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,41 @@
|
|||||||
|
import fs from 'fs';
|
||||||
|
import path from 'path';
|
||||||
|
|
||||||
|
/*
|
||||||
|
* SchoolRow and SecondarySchoolRow switch to their narrow layout with a
|
||||||
|
* container query on a `results` container, not a media query, because the
|
||||||
|
* same row fills the phone list and the narrow list beside the desktop map.
|
||||||
|
* Outside a `results` container the query never matches and the row keeps its
|
||||||
|
* wide layout on a phone, a silent regression rather than an error.
|
||||||
|
*
|
||||||
|
* HomeView provides the container on every list it renders the rows into.
|
||||||
|
* Anything else that starts rendering them must do the same; this fails so
|
||||||
|
* that the person adding it reads this first.
|
||||||
|
*/
|
||||||
|
|
||||||
|
const ROOT = path.join(__dirname, '..', '..');
|
||||||
|
const DIRS = ['app', 'components', 'lib'];
|
||||||
|
const ROW_IMPORT = /from\s+['"][^'"]*\/(SchoolRow|SecondarySchoolRow)['"]/;
|
||||||
|
|
||||||
|
function sources(dir: string): string[] {
|
||||||
|
return fs.readdirSync(dir, { withFileTypes: true }).flatMap((entry) => {
|
||||||
|
const full = path.join(dir, entry.name);
|
||||||
|
if (entry.isDirectory()) return entry.name === 'node_modules' ? [] : sources(full);
|
||||||
|
return /\.tsx?$/.test(entry.name) ? [full] : [];
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
it('renders the results rows only where a `results` container is provided', () => {
|
||||||
|
const importers = DIRS.flatMap((d) => sources(path.join(ROOT, d)))
|
||||||
|
.filter((file) => ROW_IMPORT.test(fs.readFileSync(file, 'utf8')))
|
||||||
|
.map((file) => path.relative(ROOT, file));
|
||||||
|
expect(importers).toEqual(['components/HomeView.tsx']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('gives each of HomeView\'s row lists the `results` container', () => {
|
||||||
|
const css = fs.readFileSync(path.join(ROOT, 'components', 'HomeView.module.css'), 'utf8');
|
||||||
|
for (const list of ['.schoolList', '.compactList', '.bottomSheet']) {
|
||||||
|
const rule = new RegExp(`\\${list}\\s*\\{[^}]*container:\\s*results\\s*/\\s*inline-size`);
|
||||||
|
expect({ list, provided: rule.test(css) }).toEqual({ list, provided: true });
|
||||||
|
}
|
||||||
|
});
|
||||||
@@ -108,7 +108,7 @@ describe('all-through schools', () => {
|
|||||||
|
|
||||||
it('labels the KS2 block explicitly', () => {
|
it('labels the KS2 block explicitly', () => {
|
||||||
renderSchoolDetail(allThroughFixture);
|
renderSchoolDetail(allThroughFixture);
|
||||||
expect(screen.getAllByText(/Primary — KS2 SATs/).length).toBeGreaterThan(0);
|
expect(screen.getAllByText(/Primary: KS2 SATs/).length).toBeGreaterThan(0);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,114 @@
|
|||||||
|
/**
|
||||||
|
* The basket limit is five per phase group, not five overall, and the
|
||||||
|
* provider is where it is enforced for every add path.
|
||||||
|
*
|
||||||
|
* Entries without a phase count against both groups. Baskets saved before
|
||||||
|
* phases were recorded hold such entries, so the compare page backfills them
|
||||||
|
* once it has fetched each school.
|
||||||
|
*/
|
||||||
|
|
||||||
|
import { act, render, screen, fireEvent } from '@testing-library/react';
|
||||||
|
|
||||||
|
import { AddToCompareButton } from '@/components/school/AddToCompareButton';
|
||||||
|
import { ComparisonProvider } from '@/context/ComparisonProvider';
|
||||||
|
import { useComparisonContext } from '@/context/ComparisonContext';
|
||||||
|
import type { NearbySchool, School } from '@/lib/types';
|
||||||
|
|
||||||
|
type Ctx = ReturnType<typeof useComparisonContext>;
|
||||||
|
|
||||||
|
function renderBasket(stored: Partial<School>[] = []) {
|
||||||
|
window.localStorage.setItem('selectedSchools', JSON.stringify(stored));
|
||||||
|
const ref: { current: Ctx | null } = { current: null };
|
||||||
|
function Probe() {
|
||||||
|
ref.current = useComparisonContext();
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
render(
|
||||||
|
<ComparisonProvider>
|
||||||
|
<Probe />
|
||||||
|
</ComparisonProvider>,
|
||||||
|
);
|
||||||
|
return ref as { current: Ctx };
|
||||||
|
}
|
||||||
|
|
||||||
|
const school = (urn: number, phase: string | null) =>
|
||||||
|
({ urn, school_name: `School ${urn}`, phase }) as School;
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
window.localStorage.clear();
|
||||||
|
jest.spyOn(window, 'alert').mockImplementation(() => {});
|
||||||
|
});
|
||||||
|
|
||||||
|
afterEach(() => jest.restoreAllMocks());
|
||||||
|
|
||||||
|
it('holds five primary and five secondary schools, and no more of either', () => {
|
||||||
|
const ctx = renderBasket();
|
||||||
|
act(() => {
|
||||||
|
for (let i = 0; i < 6; i++) ctx.current.addSchool(school(100000 + i, 'Primary'));
|
||||||
|
for (let i = 0; i < 6; i++) ctx.current.addSchool(school(200000 + i, 'Secondary'));
|
||||||
|
});
|
||||||
|
expect(ctx.current.selectedSchools).toHaveLength(10);
|
||||||
|
expect(window.alert).toHaveBeenCalledWith(expect.stringMatching(/5 primary schools/));
|
||||||
|
expect(window.alert).toHaveBeenCalledWith(expect.stringMatching(/5 secondary schools/));
|
||||||
|
});
|
||||||
|
|
||||||
|
it('frees the second group once a stored entry learns its phase', () => {
|
||||||
|
// Three phase-less entries from an older basket plus two primaries: the
|
||||||
|
// primary group reads as full although only two are really primary.
|
||||||
|
const ctx = renderBasket([
|
||||||
|
school(100001, null),
|
||||||
|
school(100002, null),
|
||||||
|
school(100003, null),
|
||||||
|
school(100004, 'Primary'),
|
||||||
|
school(100005, 'Primary'),
|
||||||
|
]);
|
||||||
|
expect(ctx.current.fullGroupFor({ phase: 'Primary' })).toBe('primary');
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
ctx.current.backfillPhases({ 100001: 'Secondary', 100002: 'Secondary', 100003: 'Secondary' });
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(ctx.current.fullGroupFor({ phase: 'Primary' })).toBeNull();
|
||||||
|
expect(ctx.current.selectedSchools.map((s) => s.phase)).toEqual([
|
||||||
|
'Secondary',
|
||||||
|
'Secondary',
|
||||||
|
'Secondary',
|
||||||
|
'Primary',
|
||||||
|
'Primary',
|
||||||
|
]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('never overwrites a phase the basket already has', () => {
|
||||||
|
const ctx = renderBasket([school(100001, 'Primary')]);
|
||||||
|
act(() => ctx.current.backfillPhases({ 100001: 'All-through' }));
|
||||||
|
expect(ctx.current.selectedSchools[0].phase).toBe('Primary');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a nearby card adds its own phase, not an unknown one', () => {
|
||||||
|
const nearby = {
|
||||||
|
urn: 100009,
|
||||||
|
school_name: 'Nearby',
|
||||||
|
distance_miles: 0.4,
|
||||||
|
school_type: 'Academy',
|
||||||
|
age_range: '4-18',
|
||||||
|
phase: 'All-through',
|
||||||
|
shared: [],
|
||||||
|
metric_value: null,
|
||||||
|
metric_key: 'rwm_expected_pct',
|
||||||
|
metric_year: null,
|
||||||
|
} as NearbySchool;
|
||||||
|
|
||||||
|
const ref: { current: Ctx | null } = { current: null };
|
||||||
|
function Probe() {
|
||||||
|
ref.current = useComparisonContext();
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
render(
|
||||||
|
<ComparisonProvider>
|
||||||
|
<Probe />
|
||||||
|
<AddToCompareButton school={nearby} />
|
||||||
|
</ComparisonProvider>,
|
||||||
|
);
|
||||||
|
fireEvent.click(screen.getByRole('button', { name: /Add to compare/ }));
|
||||||
|
expect(ref.current?.selectedSchools[0].phase).toBe('All-through');
|
||||||
|
});
|
||||||
@@ -6,8 +6,12 @@
|
|||||||
*/
|
*/
|
||||||
|
|
||||||
import {
|
import {
|
||||||
|
MAX_PER_GROUP,
|
||||||
OFSTED_LEGACY_GRADES,
|
OFSTED_LEGACY_GRADES,
|
||||||
admissionsForPhase,
|
admissionsForPhase,
|
||||||
|
compareGroups,
|
||||||
|
fitToGroupLimits,
|
||||||
|
fullGroupFor,
|
||||||
ofstedDisplay,
|
ofstedDisplay,
|
||||||
progressBand,
|
progressBand,
|
||||||
rcAreaLabel,
|
rcAreaLabel,
|
||||||
@@ -313,3 +317,48 @@ describe('latestValues', () => {
|
|||||||
expect(latestValues(data, [1], 'nope')).toEqual([null]);
|
expect(latestValues(data, [1], 'nope')).toEqual([null]);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('basket limits per comparison group', () => {
|
||||||
|
const school = (phase: string | null, urn = 0) => ({ urn, phase });
|
||||||
|
const many = (phase: string | null, n: number, from = 0) =>
|
||||||
|
Array.from({ length: n }, (_, i) => school(phase, from + i));
|
||||||
|
|
||||||
|
it('files each phase under its compare tab', () => {
|
||||||
|
expect(compareGroups('Primary')).toEqual(['primary']);
|
||||||
|
expect(compareGroups('Middle deemed primary')).toEqual(['primary']);
|
||||||
|
expect(compareGroups('Secondary')).toEqual(['secondary']);
|
||||||
|
expect(compareGroups('Middle deemed secondary')).toEqual(['secondary']);
|
||||||
|
expect(compareGroups('16 plus')).toEqual(['secondary']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('counts schools that could land in either tab against both', () => {
|
||||||
|
expect(compareGroups('All-through')).toEqual(['primary', 'secondary']);
|
||||||
|
expect(compareGroups('Not applicable')).toEqual(['primary', 'secondary']);
|
||||||
|
expect(compareGroups(null)).toEqual(['primary', 'secondary']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('a full primary group still admits secondary schools', () => {
|
||||||
|
const basket = many('Primary', MAX_PER_GROUP);
|
||||||
|
expect(fullGroupFor(basket, school('Primary'))).toBe('primary');
|
||||||
|
expect(fullGroupFor(basket, school('Secondary'))).toBeNull();
|
||||||
|
expect(fullGroupFor(basket, school('All-through'))).toBe('primary');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('allows ten schools in total, five per group', () => {
|
||||||
|
const basket = [...many('Primary', 5), ...many('Secondary', 5, 5)];
|
||||||
|
expect(fullGroupFor(basket, school('Primary'))).toBe('primary');
|
||||||
|
expect(fullGroupFor(basket, school('Secondary'))).toBe('secondary');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('an all-through school uses a slot in both groups', () => {
|
||||||
|
const basket = [school('All-through'), ...many('Primary', 4, 1)];
|
||||||
|
expect(fullGroupFor(basket, school('Primary'))).toBe('primary');
|
||||||
|
expect(fullGroupFor(basket, school('Secondary'))).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it('trims an oversized shared link per group, keeping order', () => {
|
||||||
|
const urls = [...many('Primary', 7), ...many('Secondary', 3, 7)];
|
||||||
|
const kept = fitToGroupLimits(urls).map((s) => s.urn);
|
||||||
|
expect(kept).toEqual([0, 1, 2, 3, 4, 7, 8, 9]);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,4 +1,4 @@
|
|||||||
import { getFlags } from '@/lib/flags';
|
import { getFlags, FLAGS_REVALIDATE } from '@/lib/flags';
|
||||||
|
|
||||||
// jsdom provides no global fetch, so there is nothing for jest.spyOn to attach
|
// jsdom provides no global fetch, so there is nothing for jest.spyOn to attach
|
||||||
// to — assign it and restore the original afterwards. This is the first test
|
// to — assign it and restore the original afterwards. This is the first test
|
||||||
@@ -31,4 +31,28 @@ describe('getFlags', () => {
|
|||||||
mockFetch(async () => ({ ok: false, status: 503 }));
|
mockFetch(async () => ({ ok: false, status: 503 }));
|
||||||
await expect(getFlags()).resolves.toEqual({});
|
await expect(getFlags()).resolves.toEqual({});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Reading a flag pins the calling route's ISR floor: Next uses the LOWEST
|
||||||
|
* revalidate among a route's fetches for the whole route. That is why the
|
||||||
|
* revalidate is an argument rather than the constant.
|
||||||
|
*
|
||||||
|
* Every SEO route here declares `revalidate = 604800`. A gate that read
|
||||||
|
* flags at the 300s default would drop the whole school and place corpus
|
||||||
|
* from a weekly cache to a 5-minute one, which is a large origin-load
|
||||||
|
* regression to pay for a feature flag.
|
||||||
|
*/
|
||||||
|
it('reads at the 300s floor by default', async () => {
|
||||||
|
mockFetch(async () => ({ ok: true, json: async () => ({}) }));
|
||||||
|
await getFlags();
|
||||||
|
expect((global.fetch as jest.Mock).mock.calls[0][1])
|
||||||
|
.toEqual({ next: { revalidate: FLAGS_REVALIDATE } });
|
||||||
|
});
|
||||||
|
|
||||||
|
it('lets a caller pass its own route floor instead', async () => {
|
||||||
|
mockFetch(async () => ({ ok: true, json: async () => ({}) }));
|
||||||
|
await getFlags(604800);
|
||||||
|
expect((global.fetch as jest.Mock).mock.calls[0][1])
|
||||||
|
.toEqual({ next: { revalidate: 604800 } });
|
||||||
|
});
|
||||||
});
|
});
|
||||||
@@ -122,7 +122,7 @@ describe('compareToCutoff', () => {
|
|||||||
|
|
||||||
it('reads back the reported case in one unit', () => {
|
it('reads back the reported case in one unit', () => {
|
||||||
expect(compareToCutoff(69, 270, 2026).headline)
|
expect(compareToCutoff(69, 270, 2026).headline)
|
||||||
.toBe('0.04 miles away — inside the September 2026 cut-off of 0.17 miles.');
|
.toBe('0.04 miles away, inside the September 2026 cut-off of 0.17 miles.');
|
||||||
});
|
});
|
||||||
|
|
||||||
it('calls a clearly nearer home inside, and names the year', () => {
|
it('calls a clearly nearer home inside, and names the year', () => {
|
||||||
|
|||||||
@@ -0,0 +1,68 @@
|
|||||||
|
/**
|
||||||
|
* School pages had no BreadcrumbList and no links into the location layer.
|
||||||
|
* Both are fixed by the same data — the `places` array the API now returns —
|
||||||
|
* so they are tested together.
|
||||||
|
*/
|
||||||
|
import { schoolBreadcrumbJsonLd } from '@/lib/jsonld';
|
||||||
|
|
||||||
|
const essex = { kind: 'authority', slug: 'essex', name: 'Essex', count: 480, url: '/schools/authority/essex', phases: [] };
|
||||||
|
const brentwood = { kind: 'town', slug: 'brentwood', name: 'Brentwood', count: 37, url: '/schools/brentwood', phases: [] };
|
||||||
|
const outcode = { kind: 'outcode', slug: 'cm15', name: 'CM15', count: 12, url: '/schools/near/cm15', phases: [] };
|
||||||
|
|
||||||
|
describe('school breadcrumbs', () => {
|
||||||
|
it('reads home to authority to town to school', () => {
|
||||||
|
const ld = schoolBreadcrumbJsonLd({
|
||||||
|
name: 'Brentwood School', url: '/school/100000-brentwood-school',
|
||||||
|
places: [essex, brentwood],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(ld['@type']).toBe('BreadcrumbList');
|
||||||
|
expect(ld.itemListElement.map((i) => i.name))
|
||||||
|
.toEqual(['schoolcompare', 'Essex', 'Brentwood', 'Brentwood School']);
|
||||||
|
expect(ld.itemListElement.map((i) => i.position)).toEqual([1, 2, 3, 4]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('skips a level the school has no published place for', () => {
|
||||||
|
// A school whose town falls below the publish threshold has no town page.
|
||||||
|
// The trail closes over the gap rather than linking to a 404.
|
||||||
|
const ld = schoolBreadcrumbJsonLd({
|
||||||
|
name: 'Lone School', url: '/school/1-lone-school', places: [essex],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(ld.itemListElement.map((i) => i.name))
|
||||||
|
.toEqual(['schoolcompare', 'Essex', 'Lone School']);
|
||||||
|
expect(ld.itemListElement.map((i) => i.position)).toEqual([1, 2, 3]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('omits outcodes, which are not a place a breadcrumb reads through', () => {
|
||||||
|
// CM15 is a useful link in the module but nonsense in a trail: nobody
|
||||||
|
// navigates Essex → CM15 → school.
|
||||||
|
const ld = schoolBreadcrumbJsonLd({
|
||||||
|
name: 'Brentwood School', url: '/school/100000-brentwood-school',
|
||||||
|
places: [essex, brentwood, outcode],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(JSON.stringify(ld)).not.toContain('cm15');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('still produces a valid trail when the school has no places at all', () => {
|
||||||
|
const ld = schoolBreadcrumbJsonLd({
|
||||||
|
name: 'Orphan School', url: '/school/2-orphan-school', places: [],
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(ld.itemListElement.map((i) => i.name)).toEqual(['schoolcompare', 'Orphan School']);
|
||||||
|
});
|
||||||
|
|
||||||
|
it('uses absolute urls, as every other entity on the site does', () => {
|
||||||
|
const ld = schoolBreadcrumbJsonLd({
|
||||||
|
name: 'Brentwood School', url: '/school/100000-brentwood-school',
|
||||||
|
places: [essex, brentwood],
|
||||||
|
});
|
||||||
|
|
||||||
|
for (const item of ld.itemListElement) {
|
||||||
|
expect(item.item).toMatch(/^https:\/\/www\.schoolcompare\.co\.uk\//);
|
||||||
|
}
|
||||||
|
// The root is the homepage: there is no /schools index page to link to.
|
||||||
|
expect(ld.itemListElement[0].item).toBe('https://www.schoolcompare.co.uk/');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -172,3 +172,39 @@ describe('buildSecondaryNavItems', () => {
|
|||||||
expect(ids).not.toContain('history');
|
expect(ids).not.toContain('history');
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('the nearby-schools nav item', () => {
|
||||||
|
const navInput = {
|
||||||
|
ofsted: null, admissions: null, admissionDistance: null,
|
||||||
|
hasLocation: true, yearlyDataLength: 1,
|
||||||
|
};
|
||||||
|
|
||||||
|
it('appears on both templates when the section renders', () => {
|
||||||
|
const primary = computeSchoolFlags(primaryFixture);
|
||||||
|
const secondary = computeSecondaryFlags(secondaryFixture);
|
||||||
|
const input = { ...navInput, hasNearbySchools: true };
|
||||||
|
|
||||||
|
expect(buildNavItems(primary, input).map((i) => i.id)).toContain('nearby');
|
||||||
|
expect(buildSecondaryNavItems(secondary, input).map((i) => i.id)).toContain('nearby');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is absent when the section does not render', () => {
|
||||||
|
const primary = computeSchoolFlags(primaryFixture);
|
||||||
|
const secondary = computeSecondaryFlags(secondaryFixture);
|
||||||
|
const input = { ...navInput, hasNearbySchools: false };
|
||||||
|
|
||||||
|
expect(buildNavItems(primary, input).map((i) => i.id)).not.toContain('nearby');
|
||||||
|
expect(buildSecondaryNavItems(secondary, input).map((i) => i.id)).not.toContain('nearby');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('is absent when nothing says either way', () => {
|
||||||
|
const primary = computeSchoolFlags(primaryFixture);
|
||||||
|
expect(buildNavItems(primary, navInput).map((i) => i.id)).not.toContain('nearby');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('comes last, because the section renders last', () => {
|
||||||
|
const primary = computeSchoolFlags(primaryFixture);
|
||||||
|
const ids = buildNavItems(primary, { ...navInput, hasNearbySchools: true }).map((i) => i.id);
|
||||||
|
expect(ids[ids.length - 1]).toBe('nearby');
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -38,8 +38,7 @@ describe('payload mount points', () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
it('isolates CMS tables in their own postgres schema', () => {
|
it('isolates CMS tables in their own postgres schema', () => {
|
||||||
// Blog content must sit outside `public`, where the app tables, Airflow's
|
// Blog content must stay separate from school marts and Airflow metadata.
|
||||||
// metadata and scripts/migrate_csv_to_db.py --drop all live.
|
|
||||||
expect(CONFIG).toMatch(/schemaName:\s*['"]payload['"]/);
|
expect(CONFIG).toMatch(/schemaName:\s*['"]payload['"]/);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
@@ -1,6 +1,8 @@
|
|||||||
import type { Metadata } from 'next';
|
import type { Metadata } from 'next';
|
||||||
import Image from 'next/image';
|
import Image from 'next/image';
|
||||||
|
import { notFound } from 'next/navigation';
|
||||||
import { absoluteUrl } from '@/lib/site';
|
import { absoluteUrl } from '@/lib/site';
|
||||||
|
import { getFlags } from '@/lib/flags';
|
||||||
import { personJsonLd, organizationJsonLd } from '@/lib/jsonld';
|
import { personJsonLd, organizationJsonLd } from '@/lib/jsonld';
|
||||||
import styles from './About.module.css';
|
import styles from './About.module.css';
|
||||||
|
|
||||||
@@ -11,7 +13,18 @@ export const metadata: Metadata = {
|
|||||||
alternates: { canonical: absoluteUrl('/about') },
|
alternates: { canonical: absoluteUrl('/about') },
|
||||||
};
|
};
|
||||||
|
|
||||||
export default function AboutPage() {
|
/*
|
||||||
|
* Gated on about_page. The default 300s read is the right floor here: this
|
||||||
|
* page declares no revalidate of its own, so nothing is lost by it, and a flip
|
||||||
|
* lands within five minutes.
|
||||||
|
*
|
||||||
|
* notFound(), not a redirect: while the flag is dark this URL does not exist,
|
||||||
|
* and a 404 is what tells a crawler not to keep it.
|
||||||
|
*/
|
||||||
|
export default async function AboutPage() {
|
||||||
|
const flags = await getFlags();
|
||||||
|
if (flags.about_page !== true) notFound();
|
||||||
|
|
||||||
const jsonLd = {
|
const jsonLd = {
|
||||||
'@context': 'https://schema.org',
|
'@context': 'https://schema.org',
|
||||||
'@graph': [personJsonLd(), organizationJsonLd()],
|
'@graph': [personJsonLd(), organizationJsonLd()],
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import type { JSXConvertersFunction } from '@payloadcms/richtext-lexical/react';
|
|||||||
import { getCachedPayload } from '@/lib/payload';
|
import { getCachedPayload } from '@/lib/payload';
|
||||||
import type { Post, Media } from '@/payload-types';
|
import type { Post, Media } from '@/payload-types';
|
||||||
import { absoluteUrl } from '@/lib/site';
|
import { absoluteUrl } from '@/lib/site';
|
||||||
|
import { getFlags } from '@/lib/flags';
|
||||||
import {
|
import {
|
||||||
blogPostingJsonLd,
|
blogPostingJsonLd,
|
||||||
breadcrumbJsonLd,
|
breadcrumbJsonLd,
|
||||||
@@ -112,6 +113,15 @@ export default async function PostPage(
|
|||||||
{ params }: { params: Promise<{ slug: string }> },
|
{ params }: { params: Promise<{ slug: string }> },
|
||||||
) {
|
) {
|
||||||
const { slug } = await params;
|
const { slug } = await params;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Flags read at this route's own declared floor, so gating costs it nothing.
|
||||||
|
* Checked before the post is fetched: a dark blog should not query Payload.
|
||||||
|
*/
|
||||||
|
const flags = await getFlags(3600);
|
||||||
|
if (flags.blog !== true) notFound();
|
||||||
|
const namedAuthor = flags.about_page === true;
|
||||||
|
|
||||||
const post = await findPost(slug);
|
const post = await findPost(slug);
|
||||||
if (!post) notFound();
|
if (!post) notFound();
|
||||||
|
|
||||||
@@ -120,10 +130,15 @@ export default async function PostPage(
|
|||||||
|
|
||||||
const jsonLd = {
|
const jsonLd = {
|
||||||
'@context': 'https://schema.org',
|
'@context': 'https://schema.org',
|
||||||
|
/*
|
||||||
|
* The Person entity is anchored at /about#tudor, so it is declared only
|
||||||
|
* when that page exists. Claiming an author whose URL 404s is a worse
|
||||||
|
* signal than attributing the post to the publisher.
|
||||||
|
*/
|
||||||
'@graph': [
|
'@graph': [
|
||||||
blogPostingJsonLd(summary),
|
blogPostingJsonLd(summary, { namedAuthor }),
|
||||||
breadcrumbJsonLd(summary),
|
breadcrumbJsonLd(summary),
|
||||||
personJsonLd(),
|
...(namedAuthor ? [personJsonLd()] : []),
|
||||||
organizationJsonLd(),
|
organizationJsonLd(),
|
||||||
],
|
],
|
||||||
};
|
};
|
||||||
@@ -142,7 +157,10 @@ export default async function PostPage(
|
|||||||
<h1 className={styles.heading}>{summary.title}</h1>
|
<h1 className={styles.heading}>{summary.title}</h1>
|
||||||
|
|
||||||
<p className={styles.byline}>
|
<p className={styles.byline}>
|
||||||
By <Link href="/about" className={styles.link}>Tudor</Link>
|
{/* Unlinked while about_page is dark; the flags are independent. */}
|
||||||
|
By {namedAuthor
|
||||||
|
? <Link href="/about" className={styles.link}>Tudor</Link>
|
||||||
|
: 'Tudor'}
|
||||||
{' · '}
|
{' · '}
|
||||||
<time dateTime={summary.publishedAt}>
|
<time dateTime={summary.publishedAt}>
|
||||||
{new Date(summary.publishedAt).toLocaleDateString('en-GB', {
|
{new Date(summary.publishedAt).toLocaleDateString('en-GB', {
|
||||||
|
|||||||
@@ -1,7 +1,9 @@
|
|||||||
import type { Metadata } from 'next';
|
import type { Metadata } from 'next';
|
||||||
import Link from 'next/link';
|
import Link from 'next/link';
|
||||||
|
import { notFound } from 'next/navigation';
|
||||||
import { getCachedPayload } from '@/lib/payload';
|
import { getCachedPayload } from '@/lib/payload';
|
||||||
import { absoluteUrl } from '@/lib/site';
|
import { absoluteUrl } from '@/lib/site';
|
||||||
|
import { getFlags } from '@/lib/flags';
|
||||||
import styles from './Blog.module.css';
|
import styles from './Blog.module.css';
|
||||||
|
|
||||||
/*
|
/*
|
||||||
@@ -31,6 +33,9 @@ function formatDate(value: string) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export default async function BlogIndexPage() {
|
export default async function BlogIndexPage() {
|
||||||
|
const flags = await getFlags();
|
||||||
|
if (flags.blog !== true) notFound();
|
||||||
|
|
||||||
const payload = await getCachedPayload();
|
const payload = await getCachedPayload();
|
||||||
const { docs } = await payload.find({
|
const { docs } = await payload.find({
|
||||||
collection: 'posts',
|
collection: 'posts',
|
||||||
@@ -48,7 +53,11 @@ export default async function BlogIndexPage() {
|
|||||||
<p className={styles.standfirst}>
|
<p className={styles.standfirst}>
|
||||||
What school performance data shows, what it doesn't, and how to
|
What school performance data shows, what it doesn't, and how to
|
||||||
read it without being misled. Written by{' '}
|
read it without being misled. Written by{' '}
|
||||||
<Link href="/about" className={styles.link}>Tudor</Link>.
|
{/* Plain text when about_page is dark: the two flags are
|
||||||
|
independent, so this link would otherwise point at a 404. */}
|
||||||
|
{flags.about_page === true
|
||||||
|
? <Link href="/about" className={styles.link}>Tudor</Link>
|
||||||
|
: 'Tudor'}.
|
||||||
</p>
|
</p>
|
||||||
</header>
|
</header>
|
||||||
|
|
||||||
|
|||||||
@@ -1,5 +1,6 @@
|
|||||||
import { getCachedPayload } from '@/lib/payload';
|
import { getCachedPayload } from '@/lib/payload';
|
||||||
import { absoluteUrl } from '@/lib/site';
|
import { absoluteUrl } from '@/lib/site';
|
||||||
|
import { getFlags } from '@/lib/flags';
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Dynamic, not ISR.
|
* Dynamic, not ISR.
|
||||||
@@ -18,6 +19,11 @@ function escapeXml(value: string): string {
|
|||||||
}
|
}
|
||||||
|
|
||||||
export async function GET() {
|
export async function GET() {
|
||||||
|
// A dark blog has no feed. 404 rather than an empty channel: an empty feed
|
||||||
|
// is a live feed with nothing in it, which a reader would keep polling.
|
||||||
|
const flags = await getFlags();
|
||||||
|
if (flags.blog !== true) return new Response('Not found', { status: 404 });
|
||||||
|
|
||||||
const payload = await getCachedPayload();
|
const payload = await getCachedPayload();
|
||||||
const { docs } = await payload.find({
|
const { docs } = await payload.find({
|
||||||
collection: 'posts',
|
collection: 'posts',
|
||||||
|
|||||||
@@ -33,9 +33,9 @@ export async function generateMetadata(
|
|||||||
// Deliberately not the homepage's phrase. Two pages chasing "compare
|
// Deliberately not the homepage's phrase. Two pages chasing "compare
|
||||||
// schools" is how a site competes with itself; this one takes the tool
|
// schools" is how a site competes with itself; this one takes the tool
|
||||||
// phrasing instead.
|
// phrasing instead.
|
||||||
title: 'School Comparison Tool — Up to Five at Once | schoolcompare',
|
title: 'School Comparison Tool: Primary and Secondary Schools | schoolcompare',
|
||||||
description:
|
description:
|
||||||
'Put up to five English schools in one table: SATs and GCSE results against the England average, Ofsted grades, and the distance places were offered.',
|
'Put up to five primary and five secondary schools in England in one table: SATs and GCSE results against the England average, Ofsted grades, and the distance places were offered.',
|
||||||
keywords:
|
keywords:
|
||||||
'school comparison, compare schools, Ofsted comparison, school admissions, KS2 comparison, primary school performance',
|
'school comparison, compare schools, Ofsted comparison, school admissions, KS2 comparison, primary school performance',
|
||||||
alternates: { canonical: absoluteUrl('/compare') },
|
alternates: { canonical: absoluteUrl('/compare') },
|
||||||
|
|||||||
@@ -8,6 +8,7 @@
|
|||||||
*/
|
*/
|
||||||
import { getCachedPayload } from '@/lib/payload';
|
import { getCachedPayload } from '@/lib/payload';
|
||||||
import { absoluteUrl } from '@/lib/site';
|
import { absoluteUrl } from '@/lib/site';
|
||||||
|
import { getFlags } from '@/lib/flags';
|
||||||
|
|
||||||
/*
|
/*
|
||||||
* Dynamic, not ISR.
|
* Dynamic, not ISR.
|
||||||
@@ -21,18 +22,33 @@ import { absoluteUrl } from '@/lib/site';
|
|||||||
export const dynamic = 'force-dynamic';
|
export const dynamic = 'force-dynamic';
|
||||||
|
|
||||||
export async function GET() {
|
export async function GET() {
|
||||||
const payload = await getCachedPayload();
|
/*
|
||||||
const { docs } = await payload.find({
|
* A dark page must not be advertised. Submitting a URL that 404s is the one
|
||||||
collection: 'posts',
|
* thing a sitemap is not allowed to do, so each entry is gated on the same
|
||||||
where: { _status: { equals: 'published' } },
|
* flag that gates the page itself.
|
||||||
sort: '-publishedAt',
|
*
|
||||||
limit: 500,
|
* With both flags dark this emits a valid, empty <urlset> rather than a 404:
|
||||||
depth: 0,
|
* robots.txt names this sitemap unconditionally, and an empty sitemap is a
|
||||||
});
|
* well-formed statement that there is nothing here yet.
|
||||||
|
*/
|
||||||
|
const flags = await getFlags();
|
||||||
|
const aboutEnabled = flags.about_page === true;
|
||||||
|
const blogEnabled = flags.blog === true;
|
||||||
|
|
||||||
|
// Only query Payload when the blog is actually being advertised.
|
||||||
|
const docs = blogEnabled
|
||||||
|
? (await (await getCachedPayload()).find({
|
||||||
|
collection: 'posts',
|
||||||
|
where: { _status: { equals: 'published' } },
|
||||||
|
sort: '-publishedAt',
|
||||||
|
limit: 500,
|
||||||
|
depth: 0,
|
||||||
|
})).docs
|
||||||
|
: [];
|
||||||
|
|
||||||
const urls: Array<{ loc: string; lastmod: string | null }> = [
|
const urls: Array<{ loc: string; lastmod: string | null }> = [
|
||||||
{ loc: absoluteUrl('/about'), lastmod: null },
|
...(aboutEnabled ? [{ loc: absoluteUrl('/about'), lastmod: null }] : []),
|
||||||
{ loc: absoluteUrl('/blog'), lastmod: null },
|
...(blogEnabled ? [{ loc: absoluteUrl('/blog'), lastmod: null }] : []),
|
||||||
...docs.map((post) => ({
|
...docs.map((post) => ({
|
||||||
loc: absoluteUrl(`/blog/${post.slug}`),
|
loc: absoluteUrl(`/blog/${post.slug}`),
|
||||||
lastmod: new Date(String(post.updatedAt ?? post.publishedAt)).toISOString(),
|
lastmod: new Date(String(post.updatedAt ?? post.publishedAt)).toISOString(),
|
||||||
|
|||||||
@@ -0,0 +1,12 @@
|
|||||||
|
'use client';
|
||||||
|
|
||||||
|
export default function ErrorPage({ reset }: { error: Error & { digest?: string }; reset: () => void }) {
|
||||||
|
return (
|
||||||
|
<main style={{ maxWidth: '48rem', margin: '4rem auto', padding: '1.5rem' }}>
|
||||||
|
<h1>We couldn’t load this page</h1>
|
||||||
|
<p>School information is temporarily unavailable. Please try again.</p>
|
||||||
|
<button type="button" onClick={reset}>Try again</button>
|
||||||
|
<p><a href="/">Return to school search</a></p>
|
||||||
|
</main>
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -645,6 +645,13 @@ html .leaflet-container a.leaflet-popup-close-button:focus {
|
|||||||
color: var(--text-primary);
|
color: var(--text-primary);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* The popup card's View link is a .btn-tertiary, which leaflet.css's
|
||||||
|
`.leaflet-container a` (0,1,1) paints #0078A8 over its 0,1,0. Its hover
|
||||||
|
rule, at 0,3,0, still wins over this. */
|
||||||
|
html .leaflet-container a.btn-tertiary {
|
||||||
|
color: var(--text-secondary);
|
||||||
|
}
|
||||||
|
|
||||||
/* Main content column */
|
/* Main content column */
|
||||||
.main {
|
.main {
|
||||||
max-width: 1400px;
|
max-width: 1400px;
|
||||||
|
|||||||
@@ -7,6 +7,7 @@ import { ComparisonToast } from '@/components/ComparisonToast';
|
|||||||
import { RouteTrail } from '@/components/RouteTrail';
|
import { RouteTrail } from '@/components/RouteTrail';
|
||||||
import { ComparisonProvider } from '@/context/ComparisonProvider';
|
import { ComparisonProvider } from '@/context/ComparisonProvider';
|
||||||
import { SITE_URL } from '@/lib/site';
|
import { SITE_URL } from '@/lib/site';
|
||||||
|
import { getFlags } from '@/lib/flags';
|
||||||
import './globals.css';
|
import './globals.css';
|
||||||
|
|
||||||
// Manrope carries headings and key messaging — the guideline's "friendly,
|
// Manrope carries headings and key messaging — the guideline's "friendly,
|
||||||
@@ -53,19 +54,37 @@ export const metadata: Metadata = {
|
|||||||
template: '%s | schoolcompare',
|
template: '%s | schoolcompare',
|
||||||
},
|
},
|
||||||
description:
|
description:
|
||||||
'Put five English schools on one screen — SATs, GCSE results, Ofsted grades, and how close you had to live to get a place. Free, no sign-up.',
|
'Put five English schools on one screen: SATs, GCSE results, Ofsted grades, and how close you had to live to get a place. Free, no sign-up.',
|
||||||
keywords: 'school comparison, KS2 results, KS4 results, primary school, secondary school, England schools, SATs results, GCSE results',
|
keywords: 'school comparison, KS2 results, KS4 results, primary school, secondary school, England schools, SATs results, GCSE results',
|
||||||
authors: [{ name: 'schoolcompare' }],
|
authors: [{ name: 'schoolcompare' }],
|
||||||
manifest: '/manifest.json',
|
manifest: '/manifest.json',
|
||||||
// No `icons` key on purpose: setting it here would override the file
|
// No `icons` key on purpose: setting it here would override the file
|
||||||
// conventions. app/icon.svg and app/apple-icon.tsx are the source, and
|
// conventions. app/icon.png and app/apple-icon.png are the source.
|
||||||
// app/opengraph-image.tsx supplies og:image and twitter:image.
|
//
|
||||||
|
// og:image and twitter:image are NOT inherited from
|
||||||
|
// app/opengraph-image.tsx — see the note on openGraph.images below. The
|
||||||
|
// icon conventions do reach these pages; the opengraph-image one does not.
|
||||||
metadataBase: new URL(SITE_URL),
|
metadataBase: new URL(SITE_URL),
|
||||||
openGraph: {
|
openGraph: {
|
||||||
type: 'website',
|
type: 'website',
|
||||||
title: 'Compare Schools Side by Side | schoolcompare',
|
title: 'Compare Schools Side by Side | schoolcompare',
|
||||||
description:
|
description:
|
||||||
'Put five English schools on one screen — SATs, GCSE results, Ofsted grades, and how close you had to live to get a place.',
|
'Put five English schools on one screen: SATs, GCSE results, Ofsted grades, and how close you had to live to get a place.',
|
||||||
|
/*
|
||||||
|
* Declared, not inherited.
|
||||||
|
*
|
||||||
|
* app/opengraph-image.tsx is a metadata file convention, and it does
|
||||||
|
* attach to routes in the app root segment — _not-found gets an og:image
|
||||||
|
* from it. It does not reach the site's pages, which live in the
|
||||||
|
* (frontend) route group whose own layout.tsx is a root layout. Staging
|
||||||
|
* served og:title, og:description, og:url, og:site_name and og:type with
|
||||||
|
* no og:image at all, so every link pasted into a chat rendered bare.
|
||||||
|
*
|
||||||
|
* The file stays at the app root: /robots.txt and /icon.png depend on it
|
||||||
|
* being there, and moving it is what broke those before. This points at
|
||||||
|
* the route it generates instead. metadataBase makes it absolute.
|
||||||
|
*/
|
||||||
|
images: ['/opengraph-image'],
|
||||||
url: SITE_URL,
|
url: SITE_URL,
|
||||||
siteName: 'schoolcompare',
|
siteName: 'schoolcompare',
|
||||||
},
|
},
|
||||||
@@ -74,15 +93,35 @@ export const metadata: Metadata = {
|
|||||||
card: 'summary_large_image',
|
card: 'summary_large_image',
|
||||||
title: 'Compare Schools Side by Side | schoolcompare',
|
title: 'Compare Schools Side by Side | schoolcompare',
|
||||||
description:
|
description:
|
||||||
'Put five English schools on one screen — SATs, GCSE results, Ofsted grades, and how close you had to live to get a place.',
|
'Put five English schools on one screen: SATs, GCSE results, Ofsted grades, and how close you had to live to get a place.',
|
||||||
|
// The card is summary_large_image; claiming that and supplying no image
|
||||||
|
// is worse than claiming a summary card.
|
||||||
|
images: ['/opengraph-image'],
|
||||||
},
|
},
|
||||||
};
|
};
|
||||||
|
|
||||||
export default function RootLayout({
|
/*
|
||||||
|
* The footer's About and Blog links are flagged, which makes this the one
|
||||||
|
* place on the site that reads a flag on every route.
|
||||||
|
*
|
||||||
|
* 604800 is deliberate and load-bearing: it is the revalidate every SEO route
|
||||||
|
* here already declares. Next pins a route to the LOWEST revalidate among its
|
||||||
|
* fetches, so reading flags at the 300s default would drop the whole school
|
||||||
|
* and place corpus from a weekly cache to a 5-minute one — a large origin-load
|
||||||
|
* regression to hide two footer links.
|
||||||
|
*
|
||||||
|
* The cost is latency in one direction only. The pages themselves read the
|
||||||
|
* same flags at their own floors and flip within minutes; the footer links
|
||||||
|
* follow within a week. Turning a feature on early therefore shows the page
|
||||||
|
* before its footer link, which is harmless. Turning one off leaves a link to
|
||||||
|
* a 404 until the cache turns over, so a rollback that matters wants a purge.
|
||||||
|
*/
|
||||||
|
export default async function RootLayout({
|
||||||
children,
|
children,
|
||||||
}: Readonly<{
|
}: Readonly<{
|
||||||
children: React.ReactNode;
|
children: React.ReactNode;
|
||||||
}>) {
|
}>) {
|
||||||
|
const flags = await getFlags(604800);
|
||||||
return (
|
return (
|
||||||
// The font variable classes must sit on <html>, not <body>. globals.css
|
// The font variable classes must sit on <html>, not <body>. globals.css
|
||||||
// declares --font-display on :root as var(--font-manrope) and --font-ui as
|
// declares --font-display on :root as var(--font-manrope) and --font-ui as
|
||||||
@@ -126,7 +165,10 @@ export default function RootLayout({
|
|||||||
{children}
|
{children}
|
||||||
</main>
|
</main>
|
||||||
<ComparisonToast />
|
<ComparisonToast />
|
||||||
<Footer />
|
<Footer
|
||||||
|
aboutEnabled={flags.about_page === true}
|
||||||
|
blogEnabled={flags.blog === true}
|
||||||
|
/>
|
||||||
</ComparisonProvider>
|
</ComparisonProvider>
|
||||||
</body>
|
</body>
|
||||||
</html>
|
</html>
|
||||||
|
|||||||
@@ -6,7 +6,7 @@
|
|||||||
import { absoluteUrl } from '@/lib/site';
|
import { absoluteUrl } from '@/lib/site';
|
||||||
import type { Metadata } from 'next';
|
import type { Metadata } from 'next';
|
||||||
import { fetchSchools, fetchFilters, fetchDataInfo } from '@/lib/api';
|
import { fetchSchools, fetchFilters, fetchDataInfo } from '@/lib/api';
|
||||||
import { formatAcademicYear } from '@/lib/utils';
|
import { DEFAULT_RADIUS_MILES, formatAcademicYear } from '@/lib/utils';
|
||||||
import { HomeView } from '@/components/HomeView';
|
import { HomeView } from '@/components/HomeView';
|
||||||
import { getFlags } from '@/lib/flags';
|
import { getFlags } from '@/lib/flags';
|
||||||
import { HowItWorksSection } from '@/components/HowItWorksSection';
|
import { HowItWorksSection } from '@/components/HowItWorksSection';
|
||||||
@@ -25,6 +25,7 @@ interface HomePageProps {
|
|||||||
gender?: string;
|
gender?: string;
|
||||||
admissions_policy?: string;
|
admissions_policy?: string;
|
||||||
has_sixth_form?: string;
|
has_sixth_form?: string;
|
||||||
|
faith?: string;
|
||||||
}>;
|
}>;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -49,7 +50,7 @@ export const metadata: Metadata = {
|
|||||||
*/
|
*/
|
||||||
title: { absolute: 'Compare Schools Side by Side | schoolcompare' },
|
title: { absolute: 'Compare Schools Side by Side | schoolcompare' },
|
||||||
description:
|
description:
|
||||||
'Put five English schools on one screen — SATs, GCSE results, Ofsted grades, and how close you had to live to get a place. Free, no sign-up.',
|
'Put five English schools on one screen: SATs, GCSE results, Ofsted grades, and how close you had to live to get a place. Free, no sign-up.',
|
||||||
// This page reads eleven search params. They filter a result set; they do
|
// This page reads eleven search params. They filter a result set; they do
|
||||||
// not make a new document. Collapsing every combination onto "/" stops the
|
// not make a new document. Collapsing every combination onto "/" stops the
|
||||||
// homepage competing with itself for its own head terms.
|
// homepage competing with itself for its own head terms.
|
||||||
@@ -71,7 +72,9 @@ export default async function HomePage({ searchParams }: HomePageProps) {
|
|||||||
|
|
||||||
// Parse search params
|
// Parse search params
|
||||||
const page = parseInt(params.page || '1');
|
const page = parseInt(params.page || '1');
|
||||||
const radius = params.radius ? parseFloat(params.radius) : undefined;
|
// Without this the API applies its own 5-mile default while the Distance
|
||||||
|
// control shows DEFAULT_RADIUS_MILES.
|
||||||
|
const radius = params.radius ? parseFloat(params.radius) : DEFAULT_RADIUS_MILES;
|
||||||
|
|
||||||
// Check if user has performed a search
|
// Check if user has performed a search
|
||||||
const hasSearchParams = !!(
|
const hasSearchParams = !!(
|
||||||
@@ -82,76 +85,55 @@ export default async function HomePage({ searchParams }: HomePageProps) {
|
|||||||
params.postcode ||
|
params.postcode ||
|
||||||
params.gender ||
|
params.gender ||
|
||||||
params.admissions_policy ||
|
params.admissions_policy ||
|
||||||
params.has_sixth_form
|
params.has_sixth_form ||
|
||||||
|
params.faith
|
||||||
);
|
);
|
||||||
|
|
||||||
// Fetch data on server with error handling
|
// Failures propagate to the retryable error boundary.
|
||||||
try {
|
const [filtersData, dataInfo] = await Promise.all([fetchFilters(), fetchDataInfo().catch(() => null)]);
|
||||||
const [filtersData, dataInfo] = await Promise.all([fetchFilters(), fetchDataInfo().catch(() => null)]);
|
|
||||||
|
|
||||||
// Only fetch schools if there are search parameters
|
// Only fetch schools if there are search parameters
|
||||||
let schoolsData;
|
let schoolsData;
|
||||||
if (hasSearchParams) {
|
if (hasSearchParams) {
|
||||||
schoolsData = await fetchSchools({
|
schoolsData = await fetchSchools({
|
||||||
search: params.search,
|
search: params.search,
|
||||||
local_authority: params.local_authority,
|
local_authority: params.local_authority,
|
||||||
school_type: params.school_type,
|
school_type: params.school_type,
|
||||||
phase: params.phase,
|
phase: params.phase,
|
||||||
postcode: params.postcode,
|
postcode: params.postcode,
|
||||||
radius,
|
radius,
|
||||||
page,
|
page,
|
||||||
page_size: 50,
|
page_size: 50,
|
||||||
gender: params.gender,
|
gender: params.gender,
|
||||||
admissions_policy: params.admissions_policy,
|
admissions_policy: params.admissions_policy,
|
||||||
has_sixth_form: params.has_sixth_form,
|
has_sixth_form: params.has_sixth_form,
|
||||||
});
|
faith: params.faith,
|
||||||
} else {
|
});
|
||||||
// Empty state by default
|
} else {
|
||||||
schoolsData = { schools: [], page: 1, page_size: 50, total: 0, total_pages: 0 };
|
// Empty state by default
|
||||||
}
|
schoolsData = { schools: [], page: 1, page_size: 50, total: 0, total_pages: 0 };
|
||||||
|
|
||||||
const resolvedFilters = filtersData || { local_authorities: [], school_types: [], years: [], phases: [], genders: [], admissions_policies: [] };
|
|
||||||
// `unique_schools`, not `total_schools` — the latter is not a field this
|
|
||||||
// endpoint returns, and reading it silently yielded null on every request.
|
|
||||||
const total = dataInfo?.unique_schools ?? null;
|
|
||||||
const years = dataInfo?.years_available ?? [];
|
|
||||||
return (
|
|
||||||
<HomeView
|
|
||||||
autosuggest={autosuggest}
|
|
||||||
initialSchools={schoolsData}
|
|
||||||
filters={resolvedFilters}
|
|
||||||
totalSchools={total}
|
|
||||||
howItWorks={hasSearchParams ? null : <HowItWorksSection />}
|
|
||||||
editorial={hasSearchParams ? null : (
|
|
||||||
<EditorialSection
|
|
||||||
totalSchools={total}
|
|
||||||
localAuthorityCount={resolvedFilters.local_authorities.length}
|
|
||||||
earliestYearLabel={years.length ? formatAcademicYear(years[0]) : null}
|
|
||||||
latestYearLabel={years.length ? formatAcademicYear(years[years.length - 1]) : null}
|
|
||||||
/>
|
|
||||||
)}
|
|
||||||
/>
|
|
||||||
);
|
|
||||||
} catch (error) {
|
|
||||||
console.error('Error fetching data for home page:', error);
|
|
||||||
|
|
||||||
const emptyFilters = { local_authorities: [], school_types: [], years: [], phases: [], genders: [], admissions_policies: [] };
|
|
||||||
return (
|
|
||||||
<HomeView
|
|
||||||
autosuggest={autosuggest}
|
|
||||||
initialSchools={{ schools: [], page: 1, page_size: 50, total: 0, total_pages: 0 }}
|
|
||||||
filters={emptyFilters}
|
|
||||||
totalSchools={null}
|
|
||||||
howItWorks={hasSearchParams ? null : <HowItWorksSection />}
|
|
||||||
editorial={hasSearchParams ? null : (
|
|
||||||
<EditorialSection
|
|
||||||
totalSchools={null}
|
|
||||||
localAuthorityCount={0}
|
|
||||||
earliestYearLabel={null}
|
|
||||||
latestYearLabel={null}
|
|
||||||
/>
|
|
||||||
)}
|
|
||||||
/>
|
|
||||||
);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const resolvedFilters = filtersData || { local_authorities: [], school_types: [], years: [], phases: [], genders: [], admissions_policies: [] };
|
||||||
|
// `unique_schools`, not `total_schools` — the latter is not a field this
|
||||||
|
// endpoint returns, and reading it silently yielded null on every request.
|
||||||
|
const total = dataInfo?.unique_schools ?? null;
|
||||||
|
const years = dataInfo?.years_available ?? [];
|
||||||
|
return (
|
||||||
|
<HomeView
|
||||||
|
autosuggest={autosuggest}
|
||||||
|
initialSchools={schoolsData}
|
||||||
|
filters={resolvedFilters}
|
||||||
|
totalSchools={total}
|
||||||
|
howItWorks={hasSearchParams ? null : <HowItWorksSection />}
|
||||||
|
editorial={hasSearchParams ? null : (
|
||||||
|
<EditorialSection
|
||||||
|
totalSchools={total}
|
||||||
|
localAuthorityCount={resolvedFilters.local_authorities.length}
|
||||||
|
earliestYearLabel={years.length ? formatAcademicYear(years[0]) : null}
|
||||||
|
latestYearLabel={years.length ? formatAcademicYear(years[years.length - 1]) : null}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
|
/>
|
||||||
|
);
|
||||||
}
|
}
|
||||||
@@ -0,0 +1,17 @@
|
|||||||
|
import { readFile } from 'node:fs/promises';
|
||||||
|
import path from 'node:path';
|
||||||
|
|
||||||
|
export const dynamic = 'force-dynamic';
|
||||||
|
export const runtime = 'nodejs';
|
||||||
|
|
||||||
|
export async function GET() {
|
||||||
|
try {
|
||||||
|
const frontend = JSON.parse(await readFile(path.join(process.cwd(), 'build-info.json'), 'utf8'));
|
||||||
|
const base = process.env.FASTAPI_URL || 'http://localhost:8000/api';
|
||||||
|
const res = await fetch(`${base}/release`, { cache: 'no-store', signal: AbortSignal.timeout(5000) });
|
||||||
|
if (!res.ok) throw new Error('Backend identity unavailable');
|
||||||
|
return Response.json({ frontend, backend: await res.json() }, { headers: { 'Cache-Control': 'no-store', 'X-Robots-Tag': 'noindex' } });
|
||||||
|
} catch {
|
||||||
|
return Response.json({ detail: 'Release identity unavailable' }, { status: 503, headers: { 'Cache-Control': 'no-store', 'X-Robots-Tag': 'noindex' } });
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -4,9 +4,12 @@
|
|||||||
* URL format: /school/138267-school-name-here
|
* URL format: /school/138267-school-name-here
|
||||||
*/
|
*/
|
||||||
|
|
||||||
import { fetchSchoolDetails, fetchSchools, fetchNationalAverages } from '@/lib/api';
|
import { APIFetchError, fetchSchoolDetails, fetchSchools, fetchNationalAverages } from '@/lib/api';
|
||||||
import { notFound, redirect } from 'next/navigation';
|
import { notFound, redirect } from 'next/navigation';
|
||||||
import { SchoolDetailShell } from '@/components/school/SchoolDetailShell';
|
import { SchoolDetailShell } from '@/components/school/SchoolDetailShell';
|
||||||
|
import { NearbyPlaces } from '@/components/school/NearbyPlaces';
|
||||||
|
import { shouldRenderNearby } from '@/components/school/NearbySchoolsSection';
|
||||||
|
import { schoolBreadcrumbJsonLd, type SchoolPlace } from '@/lib/jsonld';
|
||||||
import { PrimarySchoolSections } from '@/components/school/PrimarySchoolSections';
|
import { PrimarySchoolSections } from '@/components/school/PrimarySchoolSections';
|
||||||
import { SecondarySchoolSections } from '@/components/school/SecondarySchoolSections';
|
import { SecondarySchoolSections } from '@/components/school/SecondarySchoolSections';
|
||||||
import {
|
import {
|
||||||
@@ -144,11 +147,17 @@ export default async function SchoolPage({ params }: SchoolPageProps) {
|
|||||||
fetchNationalAverages().catch(() => null),
|
fetchNationalAverages().catch(() => null),
|
||||||
]);
|
]);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error(`Failed to fetch school ${urn}:`, error);
|
if (error instanceof APIFetchError && error.status === 404) notFound();
|
||||||
notFound();
|
throw error;
|
||||||
}
|
}
|
||||||
|
|
||||||
const { school_info, yearly_data, absence_data, ofsted, census, admissions, admissions_history, admission_distance, deprivation, finance, destinations } = data;
|
const { school_info, yearly_data, absence_data, ofsted, census, admissions, admissions_history, admission_distance, deprivation, finance, destinations } = data;
|
||||||
|
// Absent on an older API build; the module and the trail both degrade to
|
||||||
|
// nothing rather than throwing, which is how this shipped without a
|
||||||
|
// lockstep deploy of the two images.
|
||||||
|
const places: SchoolPlace[] = data.places ?? [];
|
||||||
|
// Absent on an older API build, exactly like `places` above.
|
||||||
|
const nearbySchools = data.nearby_schools ?? [];
|
||||||
|
|
||||||
// Redirect bare URN to canonical slug URL
|
// Redirect bare URN to canonical slug URL
|
||||||
const canonicalSlug = schoolUrl(urn, school_info.school_name).replace('/school/', '');
|
const canonicalSlug = schoolUrl(urn, school_info.school_name).replace('/school/', '');
|
||||||
@@ -180,15 +189,25 @@ export default async function SchoolPage({ params }: SchoolPageProps) {
|
|||||||
admissions: admissions ?? null,
|
admissions: admissions ?? null,
|
||||||
admissionDistance: admission_distance ?? null,
|
admissionDistance: admission_distance ?? null,
|
||||||
hasLocation: school_info.latitude != null && school_info.longitude != null,
|
hasLocation: school_info.latitude != null && school_info.longitude != null,
|
||||||
|
hasNearbySchools: shouldRenderNearby(nearbySchools),
|
||||||
yearlyDataLength: yearly_data.length,
|
yearlyDataLength: yearly_data.length,
|
||||||
};
|
};
|
||||||
const primaryNavItems = buildNavItems(primaryFlags, navInput);
|
const primaryNavItems = buildNavItems(primaryFlags, navInput);
|
||||||
const secondaryNavItems = buildSecondaryNavItems(secondaryFlags, navInput);
|
const secondaryNavItems = buildSecondaryNavItems(secondaryFlags, navInput);
|
||||||
|
|
||||||
// Generate JSON-LD structured data for SEO
|
/*
|
||||||
|
* `School`, not `EducationalOrganization`.
|
||||||
|
*
|
||||||
|
* Both are valid, but EducationalOrganization is the parent type covering
|
||||||
|
* universities, training providers and nurseries alike. School is the
|
||||||
|
* specific one, and a type that says what the page is about is the whole
|
||||||
|
* point of declaring it. Google's own guidance treats the narrower type as
|
||||||
|
* the correct choice where it applies.
|
||||||
|
*/
|
||||||
const structuredData = {
|
const structuredData = {
|
||||||
'@context': 'https://schema.org',
|
'@context': 'https://schema.org',
|
||||||
'@type': 'EducationalOrganization',
|
'@graph': [{
|
||||||
|
'@type': 'School',
|
||||||
name: school_info.school_name,
|
name: school_info.school_name,
|
||||||
identifier: school_info.urn.toString(),
|
identifier: school_info.urn.toString(),
|
||||||
...(school_info.address && {
|
...(school_info.address && {
|
||||||
@@ -210,6 +229,15 @@ export default async function SchoolPage({ params }: SchoolPageProps) {
|
|||||||
...(school_info.school_type && {
|
...(school_info.school_type && {
|
||||||
additionalType: school_info.school_type,
|
additionalType: school_info.school_type,
|
||||||
}),
|
}),
|
||||||
|
},
|
||||||
|
// The trail the page sits at the end of. School pages carried no
|
||||||
|
// breadcrumb at all, while every place page already emitted one.
|
||||||
|
schoolBreadcrumbJsonLd({
|
||||||
|
name: school_info.school_name,
|
||||||
|
url: `/school/${slug}`,
|
||||||
|
places,
|
||||||
|
}),
|
||||||
|
],
|
||||||
};
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
@@ -238,6 +266,7 @@ export default async function SchoolPage({ params }: SchoolPageProps) {
|
|||||||
finance={finance ?? null}
|
finance={finance ?? null}
|
||||||
nationalAvg={nationalAvg}
|
nationalAvg={nationalAvg}
|
||||||
destinations={destinations ?? null}
|
destinations={destinations ?? null}
|
||||||
|
nearbySchools={nearbySchools}
|
||||||
flags={secondaryFlags}
|
flags={secondaryFlags}
|
||||||
/>
|
/>
|
||||||
</SchoolDetailShell>
|
</SchoolDetailShell>
|
||||||
@@ -260,10 +289,12 @@ export default async function SchoolPage({ params }: SchoolPageProps) {
|
|||||||
deprivation={deprivation ?? null}
|
deprivation={deprivation ?? null}
|
||||||
finance={finance ?? null}
|
finance={finance ?? null}
|
||||||
nationalAvg={nationalAvg}
|
nationalAvg={nationalAvg}
|
||||||
|
nearbySchools={nearbySchools}
|
||||||
flags={primaryFlags}
|
flags={primaryFlags}
|
||||||
/>
|
/>
|
||||||
</SchoolDetailShell>
|
</SchoolDetailShell>
|
||||||
)}
|
)}
|
||||||
|
<NearbyPlaces places={places} />
|
||||||
</>
|
</>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -56,7 +56,7 @@ export async function generateMetadata({ params }: Props): Promise<Metadata> {
|
|||||||
// absolute: the root layout's template appends '| schoolcompare' to a
|
// absolute: the root layout's template appends '| schoolcompare' to a
|
||||||
// plain string, and this title already carries it. Without this every
|
// plain string, and this title already carries it. Without this every
|
||||||
// place title read '... | schoolcompare | schoolcompare'.
|
// place title read '... | schoolcompare | schoolcompare'.
|
||||||
title: { absolute: `Schools in ${name} — Compare ${count} Schools | schoolcompare` },
|
title: { absolute: `Schools in ${name}: Compare ${count} Schools | schoolcompare` },
|
||||||
description:
|
description:
|
||||||
`Every school in ${name}, with SATs and GCSE results, Ofsted grades, the local `
|
`Every school in ${name}, with SATs and GCSE results, Ofsted grades, the local `
|
||||||
+ `average against England, and how close you had to live to get a place.`,
|
+ `average against England, and how close you had to live to get a place.`,
|
||||||
|
|||||||
@@ -41,7 +41,7 @@ export async function generateMetadata({ params }: Props): Promise<Metadata> {
|
|||||||
// "Local Authority" stays in the title for the same reason it is on the
|
// "Local Authority" stays in the title for the same reason it is on the
|
||||||
// bare authority page: 67 town names collide with an authority name, and
|
// bare authority page: 67 town names collide with an authority name, and
|
||||||
// a reader landing on both needs to know which set each covers.
|
// a reader landing on both needs to know which set each covers.
|
||||||
title: { absolute: `${word} Schools in ${name} — Local Authority | schoolcompare` },
|
title: { absolute: `${word} Schools in ${name} (Local Authority) | schoolcompare` },
|
||||||
description:
|
description:
|
||||||
`Every ${phase} school in the ${name} local authority, with results, Ofsted `
|
`Every ${phase} school in the ${name} local authority, with results, Ofsted `
|
||||||
+ `grades and the authority average against England.`,
|
+ `grades and the authority average against England.`,
|
||||||
|
|||||||
@@ -43,7 +43,7 @@ export async function generateMetadata({ params }: Props): Promise<Metadata> {
|
|||||||
|
|
||||||
const { name, count } = detail.place;
|
const { name, count } = detail.place;
|
||||||
return {
|
return {
|
||||||
title: { absolute: `Schools in ${name} — Local Authority | schoolcompare` },
|
title: { absolute: `Schools in ${name} (Local Authority) | schoolcompare` },
|
||||||
description:
|
description:
|
||||||
`All ${count} schools in the ${name} local authority, with SATs and GCSE results, `
|
`All ${count} schools in the ${name} local authority, with SATs and GCSE results, `
|
||||||
+ `Ofsted grades and the authority average against England.`,
|
+ `Ofsted grades and the authority average against England.`,
|
||||||
|
|||||||
@@ -11,7 +11,7 @@ import { ImageResponse } from 'next/og';
|
|||||||
* and a suggestion of the illustration's rolling landscape along the bottom.
|
* and a suggestion of the illustration's rolling landscape along the bottom.
|
||||||
* It states the promise rather than decorating it.
|
* It states the promise rather than decorating it.
|
||||||
*/
|
*/
|
||||||
export const alt = 'schoolcompare — find the school where your child will flourish';
|
export const alt = 'schoolcompare: find the school where your child will flourish';
|
||||||
export const size = { width: 1200, height: 630 };
|
export const size = { width: 1200, height: 630 };
|
||||||
export const contentType = 'image/png';
|
export const contentType = 'image/png';
|
||||||
|
|
||||||
|
|||||||
@@ -64,11 +64,11 @@ interface Step {
|
|||||||
const SECONDARY_STEPS: Step[] = [
|
const SECONDARY_STEPS: Step[] = [
|
||||||
{
|
{
|
||||||
title: 'Check entry criteria',
|
title: 'Check entry criteria',
|
||||||
body: 'Look at each school\'s admissions policy — catchment areas, faith criteria, sibling priority, and aptitude tests vary widely.',
|
body: 'Look at each school\'s admissions policy. Catchment areas, faith criteria, sibling priority and aptitude tests vary widely.',
|
||||||
callouts: [
|
callouts: [
|
||||||
{
|
{
|
||||||
title: 'Selective schools register earlier',
|
title: 'Selective schools register earlier',
|
||||||
body: 'Grammar and other selective schools need separate entrance-test registration months earlier — often by September, well before the 31 October deadline.',
|
body: 'Grammar and other selective schools need separate entrance-test registration months earlier, often by September and well before the 31 October deadline.',
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
title: 'Faith schools may need an extra form',
|
title: 'Faith schools may need an extra form',
|
||||||
@@ -86,26 +86,26 @@ const SECONDARY_STEPS: Step[] = [
|
|||||||
{
|
{
|
||||||
date: '31 October',
|
date: '31 October',
|
||||||
title: 'Application deadline',
|
title: 'Application deadline',
|
||||||
body: 'Submit your ranked list of schools — most councils allow three to six preferences (London boroughs typically six). Councils treat all preferences equally, so list schools in the genuine order you want them, not strategically.',
|
body: 'Submit your ranked list of schools. Most councils allow three to six preferences (London boroughs typically six). Councils treat all preferences equally, so list schools in the genuine order you want them, not strategically.',
|
||||||
highlight: 'deadline',
|
highlight: 'deadline',
|
||||||
tool: { label: 'Compare performance to order your preferences', href: '/rankings' },
|
tool: { label: 'Compare performance to order your preferences', href: '/rankings' },
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
date: '1 March',
|
date: '1 March',
|
||||||
title: 'National Offer Day',
|
title: 'National Offer Day',
|
||||||
body: 'Your allocated school appears on the council\'s online admissions portal and is sent by email. Release times are set by each council — often from late afternoon, though some publish overnight — so check your council\'s page rather than refreshing at midnight.',
|
body: 'Your allocated school appears on the council\'s online admissions portal and is sent by email. Release times are set by each council (often from late afternoon, though some publish overnight), so check your council\'s page rather than refreshing at midnight.',
|
||||||
highlight: 'offer',
|
highlight: 'offer',
|
||||||
tool: { label: 'Look up your allocated school', href: '/' },
|
tool: { label: 'Look up your allocated school', href: '/' },
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
date: '~15 March',
|
date: '~15 March',
|
||||||
title: 'Accept or decline',
|
title: 'Accept or decline',
|
||||||
body: 'Respond by the deadline your council gives — typically around 15 March. Accepting does not prevent you from keeping a place on a waiting list for a preferred school.',
|
body: 'Respond by the deadline your council gives, typically around 15 March. Accepting does not prevent you from keeping a place on a waiting list for a preferred school.',
|
||||||
tool: { label: 'Weigh your offer against your other choices', href: '/compare' },
|
tool: { label: 'Weigh your offer against your other choices', href: '/compare' },
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
title: 'Appeals',
|
title: 'Appeals',
|
||||||
body: 'If unsuccessful, you can appeal within 20 school days of the refusal letter. Secondary appeals consider whether prejudice to the school outweighs your case — success rates vary.',
|
body: 'If unsuccessful, you can appeal within 20 school days of the refusal letter. Secondary appeals consider whether prejudice to the school outweighs your case, and success rates vary.',
|
||||||
tool: { label: 'Gather performance evidence for your case', href: '/rankings' },
|
tool: { label: 'Gather performance evidence for your case', href: '/rankings' },
|
||||||
},
|
},
|
||||||
];
|
];
|
||||||
@@ -163,7 +163,7 @@ interface Tip {
|
|||||||
const TIPS: Tip[] = [
|
const TIPS: Tip[] = [
|
||||||
{
|
{
|
||||||
heading: 'Equal preference rule',
|
heading: 'Equal preference rule',
|
||||||
body: 'Councils consider every school you list before making any offer, then give you the highest-ranked one you qualify for. Your order only decides which qualifying school you get — you can\'t game it, so list schools in the order you genuinely want them.',
|
body: 'Councils consider every school you list before making any offer, then give you the highest-ranked one you qualify for. Your order only decides which qualifying school you get. You can\'t game it, so list schools in the order you genuinely want them.',
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
heading: 'Late applications go to the back',
|
heading: 'Late applications go to the back',
|
||||||
@@ -259,7 +259,7 @@ export function AdmissionsView() {
|
|||||||
</span>
|
</span>
|
||||||
<h1 className={styles.heroTitle}>School Admissions Guide</h1>
|
<h1 className={styles.heroTitle}>School Admissions Guide</h1>
|
||||||
<p className={styles.heroSub}>
|
<p className={styles.heroSub}>
|
||||||
Everything parents need to know about applying for a school place in England — from opening dates to National Offer Day, with live countdowns to every key milestone.
|
Everything parents need to know about applying for a school place in England, from opening dates to National Offer Day, with live countdowns to every key milestone.
|
||||||
</p>
|
</p>
|
||||||
</section>
|
</section>
|
||||||
|
|
||||||
|
|||||||
@@ -43,7 +43,7 @@ interface ComparisonChartProps {
|
|||||||
isSecondary?: boolean;
|
isSecondary?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
// One shape per basket slot (MAX_SCHOOLS = 5) — secondary encoding so
|
// One shape per slot in a phase tab (MAX_PER_GROUP = 5) — secondary encoding so
|
||||||
// converging lines stay tellable apart without relying on hue alone.
|
// converging lines stay tellable apart without relying on hue alone.
|
||||||
const POINT_STYLES: PointStyle[] = ['circle', 'triangle', 'rect', 'rectRot', 'star'];
|
const POINT_STYLES: PointStyle[] = ['circle', 'triangle', 'rect', 'rectRot', 'star'];
|
||||||
|
|
||||||
@@ -258,15 +258,15 @@ export function ComparisonChart({ comparisonData, schools, metric, metricLabel,
|
|||||||
// published by DfE but aren't in our dataset yet.
|
// published by DfE but aren't in our dataset yet.
|
||||||
<p className={styles.chartNote}>
|
<p className={styles.chartNote}>
|
||||||
School-level GCSE figures for 2019/20 and 2020/21 weren't published (COVID
|
School-level GCSE figures for 2019/20 and 2020/21 weren't published (COVID
|
||||||
grading), and more recent years aren't in our dataset yet where lines break — the
|
grading), and more recent years aren't in our dataset yet. Where lines break, the
|
||||||
England average is shown where available.
|
England average is shown if available.
|
||||||
</p>
|
</p>
|
||||||
) : (
|
) : (
|
||||||
!isSecondary &&
|
!isSecondary &&
|
||||||
built.showUnpublished202122Note && (
|
built.showUnpublished202122Note && (
|
||||||
<p className={styles.chartNote}>
|
<p className={styles.chartNote}>
|
||||||
No national tests were held in 2019/20 and 2020/21 (COVID), and DfE didn't publish
|
No national tests were held in 2019/20 and 2020/21 (COVID), and DfE didn't publish
|
||||||
school-level figures for 2021/22 — the England average is shown for that year.
|
school-level figures for 2021/22. The England average is shown for that year.
|
||||||
</p>
|
</p>
|
||||||
)
|
)
|
||||||
)}
|
)}
|
||||||
|
|||||||
@@ -53,7 +53,8 @@ export function ComparisonView({
|
|||||||
const router = useRouter();
|
const router = useRouter();
|
||||||
const pathname = usePathname();
|
const pathname = usePathname();
|
||||||
const searchParams = useSearchParams();
|
const searchParams = useSearchParams();
|
||||||
const { selectedSchools, removeSchool, replaceSchools, isInitialized } = useComparison();
|
const { selectedSchools, removeSchool, replaceSchools, backfillPhases, isInitialized } =
|
||||||
|
useComparison();
|
||||||
|
|
||||||
const [selectedMetric, setSelectedMetric] = useState(initialMetric);
|
const [selectedMetric, setSelectedMetric] = useState(initialMetric);
|
||||||
const [isModalOpen, setIsModalOpen] = useState(false);
|
const [isModalOpen, setIsModalOpen] = useState(false);
|
||||||
@@ -157,6 +158,17 @@ export function ComparisonView({
|
|||||||
};
|
};
|
||||||
}, [urnKey, isInitialized]);
|
}, [urnKey, isInitialized]);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!comparisonData) return;
|
||||||
|
backfillPhases(
|
||||||
|
Object.fromEntries(
|
||||||
|
Object.values(comparisonData)
|
||||||
|
.filter((d) => d?.school_info)
|
||||||
|
.map((d) => [d.school_info.urn, d.school_info.phase]),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
}, [comparisonData, backfillPhases]);
|
||||||
|
|
||||||
const primarySchools = selectedSchools.filter((school) => {
|
const primarySchools = selectedSchools.filter((school) => {
|
||||||
const info = comparisonData?.[school.urn]?.school_info;
|
const info = comparisonData?.[school.urn]?.school_info;
|
||||||
const hasPrimaryData =
|
const hasPrimaryData =
|
||||||
@@ -263,7 +275,7 @@ export function ComparisonView({
|
|||||||
<header className={styles.header}>
|
<header className={styles.header}>
|
||||||
<h1>Compare Schools</h1>
|
<h1>Compare Schools</h1>
|
||||||
<p className={styles.subtitle}>
|
<p className={styles.subtitle}>
|
||||||
Add schools to your comparison basket to see them side by side — inspection results,
|
Add schools to your comparison basket to see them side by side: inspection results,
|
||||||
academics, admissions and community.
|
academics, admissions and community.
|
||||||
</p>
|
</p>
|
||||||
</header>
|
</header>
|
||||||
@@ -300,8 +312,8 @@ export function ComparisonView({
|
|||||||
<div>
|
<div>
|
||||||
<h1>Compare Schools</h1>
|
<h1>Compare Schools</h1>
|
||||||
<p className={styles.subtitle}>
|
<p className={styles.subtitle}>
|
||||||
{selectedSchools.length} school{selectedSchools.length !== 1 ? 's' : ''} side by side
|
{selectedSchools.length} school{selectedSchools.length !== 1 ? 's' : ''} side by side,
|
||||||
— each number anchored against the England average so you can tell at a glance
|
each number anchored against the England average so you can tell at a glance
|
||||||
what's typical and what stands out.
|
what's typical and what stands out.
|
||||||
</p>
|
</p>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -47,7 +47,7 @@ export function EditorialSection({
|
|||||||
<p>
|
<p>
|
||||||
School performance data in England is rich but fragmented. The Department for Education and Ofsted
|
School performance data in England is rich but fragmented. The Department for Education and Ofsted
|
||||||
publish Key Stage 2 SATs, GCSE attainment, inspection outcomes, progress scores, admissions figures
|
publish Key Stage 2 SATs, GCSE attainment, inspection outcomes, progress scores, admissions figures
|
||||||
and demographics — each in its own table, each with its own jargon.
|
and demographics, each in its own table with its own jargon.
|
||||||
</p>
|
</p>
|
||||||
<p>
|
<p>
|
||||||
schoolcompare brings it all into one place. Every school page shows performance against the national
|
schoolcompare brings it all into one place. Every school page shows performance against the national
|
||||||
|
|||||||
@@ -4,8 +4,10 @@
|
|||||||
* hero a single white pill on the Sand hero panel, carrying the one
|
* hero a single white pill on the Sand hero panel, carrying the one
|
||||||
* coral action the page exists for. No card of its own: the panel
|
* coral action the page exists for. No card of its own: the panel
|
||||||
* behind it belongs to the page, so the pill reads as the object.
|
* behind it belongs to the page, so the pill reads as the object.
|
||||||
* compact the filter rail above the results — a white card of quiet
|
* compact the results toolbar — search, then a row of pill controls. The
|
||||||
* controls, brand for what is active, sage for what is selected.
|
* card around it belongs to HomeView, which pins it under the
|
||||||
|
* header and puts the List/Map switch beside it, so the compact
|
||||||
|
* bar draws no card of its own.
|
||||||
*
|
*
|
||||||
* Colour comes from the token layer only; the disclosure arrows are drawn
|
* Colour comes from the token layer only; the disclosure arrows are drawn
|
||||||
* from currentColor rather than a background image so they follow the theme.
|
* from currentColor rather than a background image so they follow the theme.
|
||||||
@@ -38,6 +40,68 @@
|
|||||||
margin: 0 auto 1.5rem;
|
margin: 0 auto 1.5rem;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* One row on wide screens, two below 1340px — decided by the width alone,
|
||||||
|
* never by what the search returned.
|
||||||
|
*
|
||||||
|
* The row once wrapped wherever it ran out of room, and its contents change
|
||||||
|
* with the results: the List/Map switch beside it, the distance chip and Clear
|
||||||
|
* all come and go. So the same search folded onto two lines when it had
|
||||||
|
* results and sat on one when it had none. Now the controls never wrap away
|
||||||
|
* from the search on a wide screen; the search box takes what they leave, and
|
||||||
|
* 1340px is where the fullest toolbar (distance, phase, type, More filters,
|
||||||
|
* Clear and the switch) still leaves it 12rem. The "More filters" panel breaks
|
||||||
|
* onto its own line below both.
|
||||||
|
*/
|
||||||
|
.filterBar:not(.heroMode) {
|
||||||
|
display: flex;
|
||||||
|
flex-wrap: wrap;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.5rem;
|
||||||
|
background: none;
|
||||||
|
border: 0;
|
||||||
|
border-radius: 0;
|
||||||
|
box-shadow: none;
|
||||||
|
padding: 0;
|
||||||
|
margin: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.filterBar:not(.heroMode) .searchSection {
|
||||||
|
flex: 1 1 0;
|
||||||
|
min-width: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.filterBar:not(.heroMode) .controlsRow {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
flex-wrap: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* The List/Map switch closes the line; the "More filters" panel follows it. */
|
||||||
|
.viewSwitchSlot {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
order: 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Below that, the switch stays up beside the search and the controls always
|
||||||
|
take a full-width line of their own, results or not. */
|
||||||
|
@media (min-width: 641px) and (max-width: 1339px) {
|
||||||
|
.viewSwitchSlot {
|
||||||
|
order: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.filterBar:not(.heroMode) .controlsRow {
|
||||||
|
flex-basis: 100%;
|
||||||
|
flex-wrap: wrap;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Only phones fold the form away and filter through the sheet; see the
|
||||||
|
640px block. */
|
||||||
|
.summaryRow,
|
||||||
|
.chipsLine {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
/* ── Search ───────────────────────────────────────────────────────── */
|
/* ── Search ───────────────────────────────────────────────────────── */
|
||||||
|
|
||||||
.searchSection {
|
.searchSection {
|
||||||
@@ -115,8 +179,13 @@
|
|||||||
box-shadow: none;
|
box-shadow: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.filterBar:not(.heroMode) .omniInput {
|
||||||
|
min-height: 2.75rem;
|
||||||
|
}
|
||||||
|
|
||||||
.searchButton {
|
.searchButton {
|
||||||
flex: 0 0 auto;
|
flex: 0 0 auto;
|
||||||
|
min-height: 2.75rem;
|
||||||
padding: 0.6875rem 1.25rem;
|
padding: 0.6875rem 1.25rem;
|
||||||
font-size: var(--step--1);
|
font-size: var(--step--1);
|
||||||
border-radius: var(--radius-sm);
|
border-radius: var(--radius-sm);
|
||||||
@@ -217,34 +286,13 @@
|
|||||||
text-align: center;
|
text-align: center;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* ── Controls row (radius + phase + advanced toggle) ──────────────── */
|
/* ── Controls row (distance, phase, type, more filters) ───────────── */
|
||||||
|
|
||||||
.controlsRow {
|
.controlsRow {
|
||||||
display: flex;
|
display: flex;
|
||||||
align-items: center;
|
align-items: center;
|
||||||
gap: 0.5rem;
|
gap: 0.5rem;
|
||||||
flex-wrap: wrap;
|
flex-wrap: wrap;
|
||||||
margin-top: 0.875rem;
|
|
||||||
padding-top: 0.875rem;
|
|
||||||
border-top: 1px solid var(--border);
|
|
||||||
}
|
|
||||||
|
|
||||||
.controlsRow .advancedToggle {
|
|
||||||
margin-left: auto;
|
|
||||||
}
|
|
||||||
|
|
||||||
.radiusControl {
|
|
||||||
display: flex;
|
|
||||||
align-items: center;
|
|
||||||
gap: 0.375rem;
|
|
||||||
flex-shrink: 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
.radiusLabel {
|
|
||||||
font-size: var(--step--2);
|
|
||||||
font-weight: 600;
|
|
||||||
color: var(--text-secondary);
|
|
||||||
white-space: nowrap;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
/* ── Selects ──────────────────────────────────────────────────────── */
|
/* ── Selects ──────────────────────────────────────────────────────── */
|
||||||
@@ -302,11 +350,30 @@
|
|||||||
font-weight: 500;
|
font-weight: 500;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* In the phone sheet a select is a full-width field and a whole touch target. */
|
||||||
|
.sheetSelect {
|
||||||
|
min-height: 2.75rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* A pill, 44px tall: these are the page's main controls now, not fine print,
|
||||||
|
and a phone needs the full touch target. */
|
||||||
.controlSelect {
|
.controlSelect {
|
||||||
padding: 0.4375rem 1.875rem 0.4375rem 0.75rem;
|
min-height: 2.75rem;
|
||||||
|
padding: 0 2.25rem 0 1rem;
|
||||||
|
border-color: var(--border-strong);
|
||||||
|
border-radius: 999px;
|
||||||
font-size: var(--step--1);
|
font-size: var(--step--1);
|
||||||
font-weight: 500;
|
font-weight: 500;
|
||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
|
/* A select is as wide as its longest option, and a school type can run to
|
||||||
|
"Academy special sponsor led". Cap it; the chosen value truncates. The cap
|
||||||
|
is part of the one-line budget above. */
|
||||||
|
max-width: 11rem;
|
||||||
|
text-overflow: ellipsis;
|
||||||
|
}
|
||||||
|
|
||||||
|
.selectShell:has(.controlSelect) .selectChevron {
|
||||||
|
right: 1rem;
|
||||||
}
|
}
|
||||||
|
|
||||||
.filterSelect:hover:not(:disabled),
|
.filterSelect:hover:not(:disabled),
|
||||||
@@ -335,12 +402,19 @@
|
|||||||
border-color: var(--brand);
|
border-color: var(--brand);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Capped so an open panel scrolls inside the pinned toolbar instead of
|
||||||
|
pushing the results off a short screen. The 3px gutter keeps the selects'
|
||||||
|
focus rings clear of the scroll clip. */
|
||||||
.filters {
|
.filters {
|
||||||
|
order: 2;
|
||||||
|
flex-basis: 100%;
|
||||||
display: flex;
|
display: flex;
|
||||||
gap: 0.625rem;
|
gap: 0.625rem;
|
||||||
flex-wrap: wrap;
|
flex-wrap: wrap;
|
||||||
margin-top: 0.75rem;
|
max-height: 50dvh;
|
||||||
padding-top: 0.75rem;
|
overflow-y: auto;
|
||||||
|
margin: 0.25rem -3px 0;
|
||||||
|
padding: 0.75rem 3px 3px;
|
||||||
border-top: 1px solid var(--border);
|
border-top: 1px solid var(--border);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -350,15 +424,16 @@
|
|||||||
display: inline-flex;
|
display: inline-flex;
|
||||||
align-items: center;
|
align-items: center;
|
||||||
gap: 0.375rem;
|
gap: 0.375rem;
|
||||||
padding: 0.4375rem 0.75rem;
|
min-height: 2.75rem;
|
||||||
background: none;
|
padding: 0 1rem;
|
||||||
border: 1px solid var(--border);
|
background: var(--bg-card);
|
||||||
border-radius: var(--radius-sm);
|
border: 1px solid var(--text-secondary);
|
||||||
|
border-radius: 999px;
|
||||||
font-family: var(--font-ui);
|
font-family: var(--font-ui);
|
||||||
font-size: var(--step--1);
|
font-size: var(--step--1);
|
||||||
font-weight: 500;
|
font-weight: 600;
|
||||||
line-height: 1;
|
line-height: 1;
|
||||||
color: var(--text-secondary);
|
color: var(--text-primary);
|
||||||
cursor: pointer;
|
cursor: pointer;
|
||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
transition: border-color var(--transition), background-color var(--transition),
|
transition: border-color var(--transition), background-color var(--transition),
|
||||||
@@ -387,7 +462,8 @@
|
|||||||
}
|
}
|
||||||
|
|
||||||
.clearButton {
|
.clearButton {
|
||||||
padding: 0.4375rem 0.875rem;
|
min-height: 2.75rem;
|
||||||
|
padding: 0 1rem;
|
||||||
font-size: var(--step--1);
|
font-size: var(--step--1);
|
||||||
font-weight: 500;
|
font-weight: 500;
|
||||||
border-radius: var(--radius-sm);
|
border-radius: var(--radius-sm);
|
||||||
@@ -413,31 +489,6 @@
|
|||||||
/* ── Narrow ───────────────────────────────────────────────────────── */
|
/* ── Narrow ───────────────────────────────────────────────────────── */
|
||||||
|
|
||||||
@media (max-width: 768px) {
|
@media (max-width: 768px) {
|
||||||
/*
|
|
||||||
* Scoped, like the two rules below it.
|
|
||||||
*
|
|
||||||
* The results filter bar is a card — background, border, shadow — and needs
|
|
||||||
* inner padding. The hero's search is not a card: .heroMode zeroes the
|
|
||||||
* padding, border and background so the search sits directly on the panel.
|
|
||||||
* Unscoped, this rule put 14px back, which indented the search box, the hint
|
|
||||||
* and the location link 14px past the headline they sit under, and cost the
|
|
||||||
* search field 28px of width on a 390px screen.
|
|
||||||
*/
|
|
||||||
.filterBar:not(.heroMode) {
|
|
||||||
padding: 0.875rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* The hero pill stays a pill at every width — stacking it would lose the
|
|
||||||
one shape the page is built around. Only the results bar stacks. */
|
|
||||||
.filterBar:not(.heroMode) .omniBoxContainer {
|
|
||||||
flex-direction: column;
|
|
||||||
align-items: stretch;
|
|
||||||
}
|
|
||||||
|
|
||||||
.filterBar:not(.heroMode) .searchButton {
|
|
||||||
width: 100%;
|
|
||||||
}
|
|
||||||
|
|
||||||
.filters {
|
.filters {
|
||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
}
|
}
|
||||||
@@ -446,19 +497,6 @@
|
|||||||
min-width: 100%;
|
min-width: 100%;
|
||||||
}
|
}
|
||||||
|
|
||||||
.controlsRow {
|
|
||||||
gap: 0.5rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.controlsRow .advancedToggle {
|
|
||||||
margin-left: 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
.controlSelect {
|
|
||||||
flex: 1;
|
|
||||||
min-width: 140px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.searchHint {
|
.searchHint {
|
||||||
text-align: left;
|
text-align: left;
|
||||||
}
|
}
|
||||||
@@ -518,3 +556,201 @@
|
|||||||
padding: 0.75rem 0.875rem;
|
padding: 0.75rem 0.875rem;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Phones: the results toolbar is pinned, so it is held to two short lines.
|
||||||
|
*
|
||||||
|
* After a search the form folds into a one-line summary ("SW196AR · 1 mi
|
||||||
|
* Edit") with the Filters button beside it, and every filter lives in
|
||||||
|
* the sheet that button opens. A second line, of the applied filters as
|
||||||
|
* chips, appears only once something is applied.
|
||||||
|
*/
|
||||||
|
@media (max-width: 640px) {
|
||||||
|
/*
|
||||||
|
* nowrap matters as much as column. The desktop rule wraps, and in a
|
||||||
|
* wrapping flex container each line is as wide as its widest item's content,
|
||||||
|
* not the container: the search summary (then "SW196AR · within 1 mile Edit",
|
||||||
|
* about 410px) stretched the line, and the controls row with it, 40px past a
|
||||||
|
* 402px iPhone 17 screen. Single-line, stretch means the container's width.
|
||||||
|
*/
|
||||||
|
.filterBar:not(.heroMode) {
|
||||||
|
flex-direction: column;
|
||||||
|
flex-wrap: nowrap;
|
||||||
|
align-items: stretch;
|
||||||
|
gap: 0.625rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.filterBar:not(.heroMode) .searchSection {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
}
|
||||||
|
|
||||||
|
.searchSummary {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.5rem;
|
||||||
|
min-height: 2.75rem;
|
||||||
|
padding: 0 0.875rem;
|
||||||
|
background: var(--bg-card);
|
||||||
|
border: 1px solid var(--border-strong);
|
||||||
|
border-radius: var(--radius-md);
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
color: var(--text-muted);
|
||||||
|
text-align: left;
|
||||||
|
cursor: pointer;
|
||||||
|
}
|
||||||
|
|
||||||
|
.summaryText {
|
||||||
|
flex: 1;
|
||||||
|
min-width: 0;
|
||||||
|
overflow: hidden;
|
||||||
|
white-space: nowrap;
|
||||||
|
text-overflow: ellipsis;
|
||||||
|
}
|
||||||
|
|
||||||
|
.summaryText strong {
|
||||||
|
color: var(--text-primary);
|
||||||
|
font-weight: 700;
|
||||||
|
}
|
||||||
|
|
||||||
|
.summaryEdit {
|
||||||
|
flex-shrink: 0;
|
||||||
|
font-weight: 600;
|
||||||
|
color: var(--brand);
|
||||||
|
}
|
||||||
|
|
||||||
|
.searchFolded {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Phones switch views with the floating button (HomeView, .mobileDock). An
|
||||||
|
empty slot would still take a gap in this column. */
|
||||||
|
.viewSwitchSlot {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* The desktop row and its panel give way to the Filters button, the
|
||||||
|
applied-filter chips and the sheet. */
|
||||||
|
.filterBar:not(.heroMode) .controlsRow,
|
||||||
|
.filterBar:not(.heroMode) .filters {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.summaryRow {
|
||||||
|
display: flex;
|
||||||
|
align-items: stretch;
|
||||||
|
gap: 0.5rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.summaryRow .searchSummary {
|
||||||
|
flex: 1 1 auto;
|
||||||
|
min-width: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.sheetTrigger {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.375rem;
|
||||||
|
min-height: 2.75rem;
|
||||||
|
padding: 0 0.875rem;
|
||||||
|
background: var(--bg-card);
|
||||||
|
border: 1px solid var(--text-secondary);
|
||||||
|
border-radius: var(--radius-md);
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 600;
|
||||||
|
line-height: 1;
|
||||||
|
color: var(--text-primary);
|
||||||
|
cursor: pointer;
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* The same brand chip as "More filters" on desktop: the list is narrowed. */
|
||||||
|
.sheetTriggerActive {
|
||||||
|
border-color: var(--brand);
|
||||||
|
background: var(--brand-bg);
|
||||||
|
color: var(--brand);
|
||||||
|
}
|
||||||
|
|
||||||
|
.sheetTriggerCount {
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
min-width: 1.25rem;
|
||||||
|
height: 1.25rem;
|
||||||
|
padding: 0 0.3rem;
|
||||||
|
border-radius: 999px;
|
||||||
|
background: var(--brand);
|
||||||
|
color: var(--bg-card);
|
||||||
|
font-size: 0.75rem;
|
||||||
|
font-weight: 700;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Bleeds to the screen edge so a chip scrolls out from under it, rather than
|
||||||
|
being cut off at the toolbar's padding. The toolbar's inline padding is
|
||||||
|
1rem at this width (HomeView.module.css, .resultsToolbar). The 4px of
|
||||||
|
block padding is room for focus rings, which the scroll clip would
|
||||||
|
otherwise cut off above and below the chips. */
|
||||||
|
.chipsLine {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.5rem;
|
||||||
|
overflow-x: auto;
|
||||||
|
margin: -4px -1rem;
|
||||||
|
padding: 4px 1rem;
|
||||||
|
scrollbar-width: none;
|
||||||
|
mask-image: linear-gradient(to right, #000 calc(100% - 28px), transparent);
|
||||||
|
}
|
||||||
|
|
||||||
|
.controlsAtEnd {
|
||||||
|
mask-image: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipsLine::-webkit-scrollbar {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipsLine > *,
|
||||||
|
.chips > * {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chips {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.5rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chip {
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.375rem;
|
||||||
|
min-height: 2.75rem;
|
||||||
|
padding: 0 0.75rem 0 1rem;
|
||||||
|
background: rgba(var(--sage-rgb), 0.38);
|
||||||
|
border: 1px solid var(--brand);
|
||||||
|
border-radius: 999px;
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 600;
|
||||||
|
line-height: 1;
|
||||||
|
color: var(--brand-strong);
|
||||||
|
cursor: pointer;
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* A school type can run to "Academy special sponsor led". */
|
||||||
|
.chipLabel {
|
||||||
|
max-width: 11rem;
|
||||||
|
overflow: hidden;
|
||||||
|
text-overflow: ellipsis;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipsClear {
|
||||||
|
min-height: 2.75rem;
|
||||||
|
padding: 0 0.75rem;
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 500;
|
||||||
|
}
|
||||||
|
}
|
||||||
+553
-153
@@ -3,12 +3,13 @@
|
|||||||
import { useState, useCallback, useTransition, useRef, useEffect } from "react";
|
import { useState, useCallback, useTransition, useRef, useEffect } from "react";
|
||||||
import type { ReactNode } from "react";
|
import type { ReactNode } from "react";
|
||||||
import { useRouter, useSearchParams, usePathname } from "next/navigation";
|
import { useRouter, useSearchParams, usePathname } from "next/navigation";
|
||||||
import { isValidPostcode, schoolUrl } from "@/lib/utils";
|
import { DEFAULT_RADIUS_MILES, isValidPostcode, schoolUrl } from "@/lib/utils";
|
||||||
import { track } from "@/lib/analytics";
|
import { track } from "@/lib/analytics";
|
||||||
import { useSchoolSuggest } from "@/hooks/useSchoolSuggest";
|
import { useSchoolSuggest } from "@/hooks/useSchoolSuggest";
|
||||||
import { SuggestList, suggestOptionId } from "./SuggestList";
|
import { SuggestList, suggestOptionId } from "./SuggestList";
|
||||||
|
import { FilterSheet, SheetField, RADIUS_OPTIONS, radiusLabel as milesLabel } from "./FilterSheet";
|
||||||
import type { Suggestion } from "@/lib/suggest";
|
import type { Suggestion } from "@/lib/suggest";
|
||||||
import type { Filters, ResultFilters } from "@/lib/types";
|
import type { FilterOption, Filters, ResultFilters } from "@/lib/types";
|
||||||
import styles from "./FilterBar.module.css";
|
import styles from "./FilterBar.module.css";
|
||||||
|
|
||||||
interface FilterBarProps {
|
interface FilterBarProps {
|
||||||
@@ -22,6 +23,14 @@ interface FilterBarProps {
|
|||||||
geoError?: string | null;
|
geoError?: string | null;
|
||||||
/** Server-read feature flag. Off means no listener, no fetch, no markup. */
|
/** Server-read feature flag. Off means no listener, no fetch, no markup. */
|
||||||
autosuggest?: boolean;
|
autosuggest?: boolean;
|
||||||
|
/**
|
||||||
|
* The results page's List/Map switch. It sits in this bar's own row rather
|
||||||
|
* than beside it, so that when the bar takes two lines the filters' line
|
||||||
|
* runs the full width instead of stopping short of the switch.
|
||||||
|
*/
|
||||||
|
viewSwitch?: ReactNode;
|
||||||
|
/** The results' total, for the phone filter sheet's "Show N schools". */
|
||||||
|
resultCount?: number;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
@@ -46,6 +55,76 @@ function SelectShell({
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/** The filters a phone sees as chips and counts on its Filters button. */
|
||||||
|
const FILTER_KEYS = [
|
||||||
|
"phase",
|
||||||
|
"school_type",
|
||||||
|
"faith",
|
||||||
|
"local_authority",
|
||||||
|
"gender",
|
||||||
|
"has_sixth_form",
|
||||||
|
"admissions_policy",
|
||||||
|
] as const;
|
||||||
|
type FilterKey = (typeof FILTER_KEYS)[number];
|
||||||
|
|
||||||
|
/** Filters that only mean something for schools teaching beyond primary. */
|
||||||
|
const SECONDARY_ONLY_KEYS = ["gender", "has_sixth_form", "admissions_policy"] as const;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* False for a phase with no secondary-age pupils, for which those filters are
|
||||||
|
* hidden: Primary, Nursery and Middle deemed primary. Matched on the words,
|
||||||
|
* not exact labels, so a change of case, hyphen or spacing in the GIAS label
|
||||||
|
* cannot leave them showing. The same reading of "primary" as
|
||||||
|
* compareGroups in lib/compareLogic.ts. The API's PHASE_GROUPS answers a
|
||||||
|
* different question (which phases a phase filter returns: primary includes
|
||||||
|
* all-through), so it is not this list.
|
||||||
|
*/
|
||||||
|
function hasSecondaryFilters(phase: string): boolean {
|
||||||
|
const p = phase.toLowerCase().replace(/[^a-z]+/g, " ").trim();
|
||||||
|
return !(p === "nursery" || (p.includes("primary") && !p.includes("secondary")));
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* The option a URL value names, ignoring case as the API does. An old link's
|
||||||
|
* raw GIAS type names none, and is shown as itself.
|
||||||
|
*/
|
||||||
|
function optionFor(options: FilterOption[], value: string) {
|
||||||
|
const v = value.toLowerCase();
|
||||||
|
return options.find((o) => o.value.toLowerCase() === v);
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A select's value and, when the URL holds something no option spells, an
|
||||||
|
* extra option for it, so the select shows what is applied and "Any" can be
|
||||||
|
* chosen to clear it. Without one, React shows the first option, "Any",
|
||||||
|
* while the list is still filtered, and choosing it changes nothing.
|
||||||
|
*/
|
||||||
|
function selectedOf(options: FilterOption[], value: string) {
|
||||||
|
if (!value) return { value, unlisted: null };
|
||||||
|
const match = optionFor(options, value);
|
||||||
|
return match ? { value: match.value, unlisted: null } : { value, unlisted: value };
|
||||||
|
}
|
||||||
|
|
||||||
|
function SlidersIcon() {
|
||||||
|
return (
|
||||||
|
<svg
|
||||||
|
width="16"
|
||||||
|
height="16"
|
||||||
|
viewBox="0 0 24 24"
|
||||||
|
fill="none"
|
||||||
|
stroke="currentColor"
|
||||||
|
strokeWidth="2"
|
||||||
|
strokeLinecap="round"
|
||||||
|
aria-hidden="true"
|
||||||
|
>
|
||||||
|
<path d="M4 6h10M18 6h2M4 12h4M12 12h8M4 18h12" />
|
||||||
|
<circle cx="16" cy="6" r="2" />
|
||||||
|
<circle cx="10" cy="12" r="2" />
|
||||||
|
<circle cx="18" cy="18" r="2" />
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
export function FilterBar({
|
export function FilterBar({
|
||||||
filters,
|
filters,
|
||||||
isHero,
|
isHero,
|
||||||
@@ -54,6 +133,8 @@ export function FilterBar({
|
|||||||
geoState = "idle",
|
geoState = "idle",
|
||||||
geoError,
|
geoError,
|
||||||
autosuggest = false,
|
autosuggest = false,
|
||||||
|
viewSwitch,
|
||||||
|
resultCount,
|
||||||
}: FilterBarProps) {
|
}: FilterBarProps) {
|
||||||
const router = useRouter();
|
const router = useRouter();
|
||||||
const pathname = usePathname();
|
const pathname = usePathname();
|
||||||
@@ -63,7 +144,7 @@ export function FilterBar({
|
|||||||
|
|
||||||
const currentSearch = searchParams.get("search") || "";
|
const currentSearch = searchParams.get("search") || "";
|
||||||
const currentPostcode = searchParams.get("postcode") || "";
|
const currentPostcode = searchParams.get("postcode") || "";
|
||||||
const currentRadius = searchParams.get("radius") || "1";
|
const currentRadius = searchParams.get("radius") || String(DEFAULT_RADIUS_MILES);
|
||||||
const initialOmniValue = currentPostcode || currentSearch;
|
const initialOmniValue = currentPostcode || currentSearch;
|
||||||
|
|
||||||
const [omniValue, setOmniValue] = useState(initialOmniValue);
|
const [omniValue, setOmniValue] = useState(initialOmniValue);
|
||||||
@@ -127,11 +208,14 @@ export function FilterBar({
|
|||||||
const currentGender = searchParams.get("gender") || "";
|
const currentGender = searchParams.get("gender") || "";
|
||||||
const currentAdmissionsPolicy = searchParams.get("admissions_policy") || "";
|
const currentAdmissionsPolicy = searchParams.get("admissions_policy") || "";
|
||||||
const currentHasSixthForm = searchParams.get("has_sixth_form") || "";
|
const currentHasSixthForm = searchParams.get("has_sixth_form") || "";
|
||||||
|
const currentFaith = searchParams.get("faith") || "";
|
||||||
|
|
||||||
// Count active dropdown filters (not search/postcode, not phase since it's always visible)
|
// Count the filters behind "More filters". Search, postcode, distance, phase
|
||||||
|
// and school type each have their own control in the toolbar, so they are
|
||||||
|
// visible without opening anything and are not counted here.
|
||||||
const activeDropdownFilters = [
|
const activeDropdownFilters = [
|
||||||
currentLA,
|
currentLA,
|
||||||
currentType,
|
currentFaith,
|
||||||
currentGender,
|
currentGender,
|
||||||
currentAdmissionsPolicy,
|
currentAdmissionsPolicy,
|
||||||
currentHasSixthForm,
|
currentHasSixthForm,
|
||||||
@@ -144,6 +228,50 @@ export function FilterBar({
|
|||||||
if (hasActiveDropdownFilters) setFiltersOpen(true);
|
if (hasActiveDropdownFilters) setFiltersOpen(true);
|
||||||
}, [hasActiveDropdownFilters]);
|
}, [hasActiveDropdownFilters]);
|
||||||
|
|
||||||
|
/*
|
||||||
|
* On phones the results toolbar is pinned, so it has to stay short. Once a
|
||||||
|
* search has been made the form folds into a one-line summary of it, and
|
||||||
|
* tapping the summary unfolds the form again. Desktop never folds: the
|
||||||
|
* summary is hidden there by CSS and the form is always shown.
|
||||||
|
*/
|
||||||
|
const currentQuery = currentPostcode || currentSearch;
|
||||||
|
const canFold = !isHero && !!currentQuery;
|
||||||
|
const [searchOpen, setSearchOpen] = useState(false);
|
||||||
|
|
||||||
|
// A search that arrives any other way (back/forward, "Use my location", a
|
||||||
|
// link) must fold the form and show its own text, or the summary and the
|
||||||
|
// unfolded input would describe two different searches.
|
||||||
|
const [shownQuery, setShownQuery] = useState(currentQuery);
|
||||||
|
if (shownQuery !== currentQuery) {
|
||||||
|
setShownQuery(currentQuery);
|
||||||
|
setSearchOpen(false);
|
||||||
|
setOmniValue(currentQuery);
|
||||||
|
}
|
||||||
|
|
||||||
|
// The phone chips line's right-edge fade says "more this way"; once there is
|
||||||
|
// no more, it only dims the last chip. Same rule as the school page's
|
||||||
|
// section nav (MOBILE.md, "Right-edge scroll-fade").
|
||||||
|
const controlsRowRef = useRef<HTMLDivElement>(null);
|
||||||
|
const [controlsAtEnd, setControlsAtEnd] = useState(false);
|
||||||
|
const updateControlsAtEnd = useCallback(() => {
|
||||||
|
const el = controlsRowRef.current;
|
||||||
|
if (!el) return;
|
||||||
|
const overflow = el.scrollWidth - el.clientWidth;
|
||||||
|
setControlsAtEnd(overflow <= 1 || el.scrollLeft >= overflow - 2);
|
||||||
|
}, []);
|
||||||
|
useEffect(() => {
|
||||||
|
window.addEventListener("resize", updateControlsAtEnd);
|
||||||
|
return () => window.removeEventListener("resize", updateControlsAtEnd);
|
||||||
|
}, [updateControlsAtEnd]);
|
||||||
|
// Chips come and go with the filters, so re-measure after every render
|
||||||
|
// rather than only on resize.
|
||||||
|
useEffect(updateControlsAtEnd);
|
||||||
|
const openSearch = () => {
|
||||||
|
setSearchOpen(true);
|
||||||
|
// After the form is displayed, or focus() lands on a hidden input.
|
||||||
|
requestAnimationFrame(() => inputRef.current?.focus());
|
||||||
|
};
|
||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
const handleKeyDown = (e: KeyboardEvent) => {
|
const handleKeyDown = (e: KeyboardEvent) => {
|
||||||
if (
|
if (
|
||||||
@@ -160,9 +288,21 @@ export function FilterBar({
|
|||||||
return () => document.removeEventListener("keydown", handleKeyDown);
|
return () => document.removeEventListener("keydown", handleKeyDown);
|
||||||
}, []);
|
}, []);
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Where the navigation in flight is headed. useSearchParams only catches up
|
||||||
|
* once a navigation lands, so a second change made before then (the phone
|
||||||
|
* sheet stays usable while one lands) would otherwise be built on the old
|
||||||
|
* URL and undo the first. Dropped once nothing is pending, when
|
||||||
|
* searchParams is current again.
|
||||||
|
*/
|
||||||
|
const pendingQueryRef = useRef<string | null>(null);
|
||||||
|
useEffect(() => {
|
||||||
|
if (!isPending) pendingQueryRef.current = null;
|
||||||
|
}, [isPending]);
|
||||||
|
|
||||||
const updateURL = useCallback(
|
const updateURL = useCallback(
|
||||||
(updates: Record<string, string>) => {
|
(updates: Record<string, string>) => {
|
||||||
const params = new URLSearchParams(searchParams);
|
const params = new URLSearchParams(pendingQueryRef.current ?? searchParams);
|
||||||
|
|
||||||
Object.entries(updates).forEach(([key, value]) => {
|
Object.entries(updates).forEach(([key, value]) => {
|
||||||
if (value && value !== "") {
|
if (value && value !== "") {
|
||||||
@@ -173,6 +313,7 @@ export function FilterBar({
|
|||||||
});
|
});
|
||||||
|
|
||||||
params.delete("page");
|
params.delete("page");
|
||||||
|
pendingQueryRef.current = params.toString();
|
||||||
|
|
||||||
startTransition(() => {
|
startTransition(() => {
|
||||||
router.push(`${pathname}?${params.toString()}`);
|
router.push(`${pathname}?${params.toString()}`);
|
||||||
@@ -186,6 +327,7 @@ export function FilterBar({
|
|||||||
// The search has been made; the suggestions that led to it are spent.
|
// The search has been made; the suggestions that led to it are spent.
|
||||||
setHasTyped(false);
|
setHasTyped(false);
|
||||||
close();
|
close();
|
||||||
|
setSearchOpen(false);
|
||||||
if (!omniValue.trim()) {
|
if (!omniValue.trim()) {
|
||||||
updateURL({ search: "", postcode: "", radius: "" });
|
updateURL({ search: "", postcode: "", radius: "" });
|
||||||
return;
|
return;
|
||||||
@@ -200,6 +342,7 @@ export function FilterBar({
|
|||||||
currentPhase && `phase=${currentPhase}`,
|
currentPhase && `phase=${currentPhase}`,
|
||||||
currentLA && `la=${currentLA}`,
|
currentLA && `la=${currentLA}`,
|
||||||
currentType && `type=${currentType}`,
|
currentType && `type=${currentType}`,
|
||||||
|
currentFaith && `faith=${currentFaith}`,
|
||||||
currentGender && `gender=${currentGender}`,
|
currentGender && `gender=${currentGender}`,
|
||||||
currentAdmissionsPolicy && `admissions=${currentAdmissionsPolicy}`,
|
currentAdmissionsPolicy && `admissions=${currentAdmissionsPolicy}`,
|
||||||
currentHasSixthForm && `sixth_form=${currentHasSixthForm}`,
|
currentHasSixthForm && `sixth_form=${currentHasSixthForm}`,
|
||||||
@@ -216,7 +359,7 @@ export function FilterBar({
|
|||||||
if (isPostcode) {
|
if (isPostcode) {
|
||||||
updateURL({
|
updateURL({
|
||||||
postcode: cleaned.toUpperCase(),
|
postcode: cleaned.toUpperCase(),
|
||||||
radius: currentRadius || "1",
|
radius: currentRadius,
|
||||||
search: "",
|
search: "",
|
||||||
});
|
});
|
||||||
} else {
|
} else {
|
||||||
@@ -225,47 +368,314 @@ export function FilterBar({
|
|||||||
};
|
};
|
||||||
|
|
||||||
const handleFilterChange = (key: string, value: string) => {
|
const handleFilterChange = (key: string, value: string) => {
|
||||||
updateURL({ [key]: value });
|
// A primary phase hides the secondary-only filters, so it clears them
|
||||||
|
// too: left applied, they would empty the list with no control showing.
|
||||||
|
const cleared =
|
||||||
|
key === "phase" && !hasSecondaryFilters(value)
|
||||||
|
? Object.fromEntries(SECONDARY_ONLY_KEYS.map((k) => [k, ""]))
|
||||||
|
: {};
|
||||||
|
updateURL({ ...cleared, [key]: value });
|
||||||
};
|
};
|
||||||
|
|
||||||
const handleClearFilters = () => {
|
// Every filter at once, keeping the search and its distance. The search is
|
||||||
setOmniValue("");
|
// what the results answer, not a filter on them: clearing it too used to
|
||||||
startTransition(() => {
|
// send desktop back to the home page.
|
||||||
router.push(pathname);
|
const handleClearFilterValues = () => {
|
||||||
});
|
updateURL(Object.fromEntries(FILTER_KEYS.map((k) => [k, ""])));
|
||||||
};
|
};
|
||||||
|
|
||||||
const hasActiveFilters =
|
/*
|
||||||
currentSearch ||
|
* A filter's options come from the full lists, not from the results: the
|
||||||
currentLA ||
|
* results have already been narrowed by that filter, so scoping to them
|
||||||
currentType ||
|
* would leave only the chosen value on offer, and switching (Girls to Boys,
|
||||||
currentPhase ||
|
* one school type to another) would need clearing first.
|
||||||
currentPostcode ||
|
*
|
||||||
currentGender ||
|
* Local authority is the exception, scoped to the results so a postcode
|
||||||
currentAdmissionsPolicy ||
|
* search offers the councils nearby rather than all of England's.
|
||||||
currentHasSixthForm;
|
*/
|
||||||
|
|
||||||
// Use result-scoped filter values when available, fall back to global
|
|
||||||
const laOptions =
|
const laOptions =
|
||||||
resultFilters?.local_authorities ?? filters.local_authorities;
|
resultFilters?.local_authorities ?? filters.local_authorities;
|
||||||
const typeOptions = resultFilters?.school_types ?? filters.school_types;
|
// Five groups a parent recognises, not GIAS's 34 establishment types.
|
||||||
const phaseOptions = resultFilters?.phases ?? filters.phases ?? [];
|
const typeOptions = filters.school_type_groups ?? [];
|
||||||
const genderOptions = resultFilters?.genders ?? filters.genders ?? [];
|
const faithOptions = filters.faiths ?? [];
|
||||||
const admissionsPolicyOptions =
|
const phaseOptions = filters.phases ?? [];
|
||||||
resultFilters?.admissions_policies ?? filters.admissions_policies ?? [];
|
const genderOptions = filters.genders ?? [];
|
||||||
|
const admissionsPolicyOptions = filters.admissions_policies ?? [];
|
||||||
|
|
||||||
const isSecondaryMode =
|
// Set by the phase chosen, never by what the results happen to contain.
|
||||||
currentPhase === "secondary" || genderOptions.length > 0;
|
const isSecondaryMode = hasSecondaryFilters(currentPhase);
|
||||||
|
|
||||||
// A select that is narrowing the results carries a sage tint; the class is
|
// A select that is narrowing the results carries a sage tint; the class is
|
||||||
// only ever additive, so the control's behaviour is untouched.
|
// only ever additive, so the control's behaviour is untouched.
|
||||||
const activeIf = (value: string) => (value ? ` ${styles.selectActive}` : "");
|
const activeIf = (value: string) => (value ? ` ${styles.selectActive}` : "");
|
||||||
|
|
||||||
|
const radiusLabel = milesLabel(currentRadius);
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Phones filter through one button and a sheet holding every filter. The
|
||||||
|
* desktop row's phone version scrolled sideways with "More filters" first,
|
||||||
|
* so phase showed only in part and school type not at all, and the panel
|
||||||
|
* "More filters" opened did not contain either of them.
|
||||||
|
*/
|
||||||
|
const [sheetOpen, setSheetOpen] = useState(false);
|
||||||
|
// The sheet is phone furniture: if the screen widens past phone width while
|
||||||
|
// it is open (rotation, a resized window), close it, or its selects and the
|
||||||
|
// desktop row's would both be showing.
|
||||||
|
useEffect(() => {
|
||||||
|
if (!sheetOpen || typeof window.matchMedia !== "function") return;
|
||||||
|
const phone = window.matchMedia("(max-width: 640px)");
|
||||||
|
const onChange = (e: { matches: boolean }) => {
|
||||||
|
if (!e.matches) setSheetOpen(false);
|
||||||
|
};
|
||||||
|
phone.addEventListener("change", onChange);
|
||||||
|
return () => phone.removeEventListener("change", onChange);
|
||||||
|
}, [sheetOpen]);
|
||||||
|
const values: Record<FilterKey, string> = {
|
||||||
|
phase: currentPhase,
|
||||||
|
school_type: currentType,
|
||||||
|
faith: currentFaith,
|
||||||
|
local_authority: currentLA,
|
||||||
|
gender: currentGender,
|
||||||
|
has_sixth_form: currentHasSixthForm,
|
||||||
|
admissions_policy: currentAdmissionsPolicy,
|
||||||
|
};
|
||||||
|
const labelFor = (key: FilterKey, value: string) => {
|
||||||
|
if (key === "has_sixth_form") {
|
||||||
|
return value === "yes" ? "With sixth form" : "Without sixth form";
|
||||||
|
}
|
||||||
|
// An old link may carry a raw GIAS type, which reads as itself.
|
||||||
|
const labelled = { school_type: typeOptions, faith: faithOptions }[
|
||||||
|
key as "school_type" | "faith"
|
||||||
|
];
|
||||||
|
if (labelled) return optionFor(labelled, value)?.label ?? value;
|
||||||
|
// Phase, gender and admissions values are lowercased option names; the
|
||||||
|
// rest are the names themselves.
|
||||||
|
const named: Partial<Record<FilterKey, string[]>> = {
|
||||||
|
phase: phaseOptions,
|
||||||
|
gender: genderOptions,
|
||||||
|
admissions_policy: admissionsPolicyOptions,
|
||||||
|
};
|
||||||
|
return (named[key] ?? []).find((o) => o.toLowerCase() === value.toLowerCase()) ?? value;
|
||||||
|
};
|
||||||
|
const applied = FILTER_KEYS.filter((k) => values[k]).map((key) => ({
|
||||||
|
key,
|
||||||
|
label: labelFor(key, values[key]),
|
||||||
|
}));
|
||||||
|
const appliedCount = applied.length;
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Each select is built here once and drawn twice: as a pill in the desktop
|
||||||
|
* row or panel, and as a full-width labelled field in the phone sheet. Only
|
||||||
|
* one copy is ever showing; the sheet's is mounted only while it is open.
|
||||||
|
* The sheet's stay enabled while a change lands: disabling the control
|
||||||
|
* under the user's focus would drop focus to <body>, out of the dialog.
|
||||||
|
*/
|
||||||
|
type Look = "pill" | "panel" | "sheet";
|
||||||
|
const selectClass = (look: Look, value: string) =>
|
||||||
|
`${look === "pill" ? styles.controlSelect : styles.filterSelect}${look === "sheet" ? ` ${styles.sheetSelect}` : ""}${activeIf(value)}`;
|
||||||
|
|
||||||
|
const phaseSelect = (look: Look) => (
|
||||||
|
<SelectShell wide={look !== "pill"}>
|
||||||
|
<select
|
||||||
|
value={currentPhase}
|
||||||
|
onChange={(e) => handleFilterChange("phase", e.target.value)}
|
||||||
|
className={selectClass(look, currentPhase)}
|
||||||
|
aria-label="Phase"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">Any phase</option>
|
||||||
|
{phaseOptions.map((p) => (
|
||||||
|
<option key={p} value={p.toLowerCase()}>
|
||||||
|
{p}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
|
||||||
|
const typeSelected = selectedOf(typeOptions, currentType);
|
||||||
|
const faithSelected = selectedOf(faithOptions, currentFaith);
|
||||||
|
|
||||||
|
const typeSelect = (look: Look) => (
|
||||||
|
<SelectShell wide={look !== "pill"}>
|
||||||
|
<select
|
||||||
|
value={typeSelected.value}
|
||||||
|
onChange={(e) => handleFilterChange("school_type", e.target.value)}
|
||||||
|
className={selectClass(look, currentType)}
|
||||||
|
aria-label="School type"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">Any school type</option>
|
||||||
|
{typeSelected.unlisted && (
|
||||||
|
<option value={typeSelected.unlisted}>{typeSelected.unlisted}</option>
|
||||||
|
)}
|
||||||
|
{typeOptions.map((o) => (
|
||||||
|
<option key={o.value} value={o.value}>
|
||||||
|
{o.label}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
|
||||||
|
const laSelect = (look: Look) => (
|
||||||
|
<SelectShell wide>
|
||||||
|
<select
|
||||||
|
value={currentLA}
|
||||||
|
onChange={(e) => handleFilterChange("local_authority", e.target.value)}
|
||||||
|
className={selectClass(look, currentLA)}
|
||||||
|
aria-label="Local authority"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">All Local Authorities</option>
|
||||||
|
{laOptions.map((la) => (
|
||||||
|
<option key={la} value={la}>
|
||||||
|
{la}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
|
||||||
|
const faithSelect = (look: Look) => (
|
||||||
|
<SelectShell wide>
|
||||||
|
<select
|
||||||
|
value={faithSelected.value}
|
||||||
|
onChange={(e) => handleFilterChange("faith", e.target.value)}
|
||||||
|
className={selectClass(look, currentFaith)}
|
||||||
|
aria-label="Faith"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">Any faith or none</option>
|
||||||
|
{faithSelected.unlisted && (
|
||||||
|
<option value={faithSelected.unlisted}>{faithSelected.unlisted}</option>
|
||||||
|
)}
|
||||||
|
{faithOptions.map((o) => (
|
||||||
|
<option key={o.value} value={o.value}>
|
||||||
|
{o.label}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
|
||||||
|
const genderSelect = (look: Look) => (
|
||||||
|
<SelectShell wide>
|
||||||
|
<select
|
||||||
|
value={currentGender}
|
||||||
|
onChange={(e) => handleFilterChange("gender", e.target.value)}
|
||||||
|
className={selectClass(look, currentGender)}
|
||||||
|
aria-label="Gender"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">Boys, Girls & Mixed</option>
|
||||||
|
{genderOptions.map((g) => (
|
||||||
|
<option key={g} value={g.toLowerCase()}>
|
||||||
|
{g}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
|
||||||
|
const sixthFormSelect = (look: Look) => (
|
||||||
|
<SelectShell wide>
|
||||||
|
<select
|
||||||
|
value={currentHasSixthForm}
|
||||||
|
onChange={(e) => handleFilterChange("has_sixth_form", e.target.value)}
|
||||||
|
className={selectClass(look, currentHasSixthForm)}
|
||||||
|
aria-label="Sixth form"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">With or without sixth form</option>
|
||||||
|
<option value="yes">With sixth form</option>
|
||||||
|
<option value="no">Without sixth form</option>
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
|
||||||
|
const admissionsSelect = (look: Look) => (
|
||||||
|
<SelectShell wide>
|
||||||
|
<select
|
||||||
|
value={currentAdmissionsPolicy}
|
||||||
|
onChange={(e) => handleFilterChange("admissions_policy", e.target.value)}
|
||||||
|
className={selectClass(look, currentAdmissionsPolicy)}
|
||||||
|
aria-label="Admissions"
|
||||||
|
disabled={isPending && look !== "sheet"}
|
||||||
|
>
|
||||||
|
<option value="">All admissions types</option>
|
||||||
|
{admissionsPolicyOptions.map((p) => (
|
||||||
|
<option key={p} value={p.toLowerCase()}>
|
||||||
|
{p}
|
||||||
|
</option>
|
||||||
|
))}
|
||||||
|
</select>
|
||||||
|
</SelectShell>
|
||||||
|
);
|
||||||
|
|
||||||
|
const sheetTrigger = (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`${styles.sheetTrigger}${appliedCount ? ` ${styles.sheetTriggerActive}` : ""}`}
|
||||||
|
onClick={() => setSheetOpen(true)}
|
||||||
|
aria-haspopup="dialog"
|
||||||
|
aria-label={appliedCount ? `Filters, ${appliedCount} applied` : "Filters"}
|
||||||
|
>
|
||||||
|
<SlidersIcon />
|
||||||
|
Filters
|
||||||
|
{appliedCount > 0 && (
|
||||||
|
<span className={styles.sheetTriggerCount} aria-hidden="true">
|
||||||
|
{appliedCount}
|
||||||
|
</span>
|
||||||
|
)}
|
||||||
|
</button>
|
||||||
|
);
|
||||||
|
// Beside the folded search summary; on the chips line when there is no
|
||||||
|
// summary to sit beside. While the search is being edited it steps aside,
|
||||||
|
// and comes back when the form folds.
|
||||||
|
const triggerBesideSummary = canFold && !searchOpen;
|
||||||
|
const triggerOnChipsLine = !canFold;
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
className={`${styles.filterBar} ${isPending ? styles.isLoading : ""} ${isHero ? styles.heroMode : ""}`}
|
className={`${styles.filterBar} ${isPending ? styles.isLoading : ""} ${isHero ? styles.heroMode : ""}`}
|
||||||
>
|
>
|
||||||
<form onSubmit={handleSearchSubmit} className={styles.searchSection}>
|
{triggerBesideSummary && (
|
||||||
|
<div className={styles.summaryRow}>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={styles.searchSummary}
|
||||||
|
onClick={openSearch}
|
||||||
|
aria-label={`Edit search: ${currentQuery}${currentPostcode ? `, within ${radiusLabel}` : ""}`}
|
||||||
|
>
|
||||||
|
<svg
|
||||||
|
width="18"
|
||||||
|
height="18"
|
||||||
|
viewBox="0 0 24 24"
|
||||||
|
fill="none"
|
||||||
|
stroke="currentColor"
|
||||||
|
strokeWidth="2"
|
||||||
|
strokeLinecap="round"
|
||||||
|
aria-hidden="true"
|
||||||
|
>
|
||||||
|
<circle cx="11" cy="11" r="7" />
|
||||||
|
<path d="m20 20-3.5-3.5" />
|
||||||
|
</svg>
|
||||||
|
<span className={styles.summaryText}>
|
||||||
|
<strong>{currentQuery}</strong>
|
||||||
|
{/* Short, so the distance survives beside the Filters button on a
|
||||||
|
360px screen; the button's name carries the long form. */}
|
||||||
|
{currentPostcode && <span> · {currentRadius} mi</span>}
|
||||||
|
</span>
|
||||||
|
<span className={styles.summaryEdit} aria-hidden="true">Edit</span>
|
||||||
|
</button>
|
||||||
|
{sheetTrigger}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
<form
|
||||||
|
onSubmit={handleSearchSubmit}
|
||||||
|
className={`${styles.searchSection}${canFold && !searchOpen ? ` ${styles.searchFolded}` : ""}`}
|
||||||
|
>
|
||||||
<div className={styles.omniBoxContainer}>
|
<div className={styles.omniBoxContainer}>
|
||||||
{isHero && (
|
{isHero && (
|
||||||
<span className={styles.omniIcon} aria-hidden="true">
|
<span className={styles.omniIcon} aria-hidden="true">
|
||||||
@@ -292,6 +702,7 @@ export function FilterBar({
|
|||||||
onKeyDown={handleOmniKeyDown}
|
onKeyDown={handleOmniKeyDown}
|
||||||
onBlur={close}
|
onBlur={close}
|
||||||
placeholder="School name or postcode"
|
placeholder="School name or postcode"
|
||||||
|
aria-label="School name or postcode"
|
||||||
className={styles.omniInput}
|
className={styles.omniInput}
|
||||||
{...(autosuggest ? {
|
{...(autosuggest ? {
|
||||||
role: "combobox",
|
role: "combobox",
|
||||||
@@ -323,7 +734,7 @@ export function FilterBar({
|
|||||||
{isHero && (
|
{isHero && (
|
||||||
<>
|
<>
|
||||||
<p className={styles.searchHint}>
|
<p className={styles.searchHint}>
|
||||||
Search by <strong>school name</strong> — or use your{" "}
|
Search by <strong>school name</strong>, or use your{" "}
|
||||||
<strong>postcode</strong> for the nearest schools.
|
<strong>postcode</strong> for the nearest schools.
|
||||||
</p>
|
</p>
|
||||||
{onNearMe && (
|
{onNearMe && (
|
||||||
@@ -370,51 +781,43 @@ export function FilterBar({
|
|||||||
|
|
||||||
{!isHero && (
|
{!isHero && (
|
||||||
<>
|
<>
|
||||||
<div className={styles.controlsRow}>
|
{viewSwitch && (
|
||||||
|
<div className={styles.viewSwitchSlot}>{viewSwitch}</div>
|
||||||
|
)}
|
||||||
|
{/* Desktop and tablet. Every control here is a real <select> or
|
||||||
|
<button>, drawn as a pill. Phones hide the row and use the
|
||||||
|
Filters button and sheet instead. */}
|
||||||
|
<div className={styles.controlsRow} role="group" aria-label="Filters">
|
||||||
{currentPostcode && (
|
{currentPostcode && (
|
||||||
<div className={styles.radiusControl}>
|
|
||||||
<label className={styles.radiusLabel}>Within:</label>
|
|
||||||
<SelectShell>
|
|
||||||
<select
|
|
||||||
value={currentRadius}
|
|
||||||
onChange={(e) => updateURL({ radius: e.target.value })}
|
|
||||||
className={styles.controlSelect}
|
|
||||||
disabled={isPending}
|
|
||||||
>
|
|
||||||
<option value="0.5">0.5 miles</option>
|
|
||||||
<option value="1">1 mile</option>
|
|
||||||
<option value="3">3 miles</option>
|
|
||||||
<option value="5">5 miles</option>
|
|
||||||
</select>
|
|
||||||
</SelectShell>
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
{phaseOptions.length > 0 && (
|
|
||||||
<SelectShell>
|
<SelectShell>
|
||||||
<select
|
<select
|
||||||
value={currentPhase}
|
value={currentRadius}
|
||||||
onChange={(e) => handleFilterChange("phase", e.target.value)}
|
onChange={(e) => updateURL({ radius: e.target.value })}
|
||||||
className={`${styles.controlSelect}${activeIf(currentPhase)}`}
|
className={`${styles.controlSelect} ${styles.selectActive}`}
|
||||||
|
aria-label="Distance"
|
||||||
disabled={isPending}
|
disabled={isPending}
|
||||||
>
|
>
|
||||||
<option value="">All Phases</option>
|
{RADIUS_OPTIONS.map((r) => (
|
||||||
{phaseOptions.map((p) => (
|
<option key={r} value={r}>
|
||||||
<option key={p} value={p.toLowerCase()}>
|
Within {milesLabel(r)}
|
||||||
{p}
|
|
||||||
</option>
|
</option>
|
||||||
))}
|
))}
|
||||||
</select>
|
</select>
|
||||||
</SelectShell>
|
</SelectShell>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
{phaseOptions.length > 0 && phaseSelect("pill")}
|
||||||
|
|
||||||
|
{typeOptions.length > 0 && typeSelect("pill")}
|
||||||
|
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
className={`${styles.advancedToggle}${hasActiveDropdownFilters ? ` ${styles.advancedToggleActive}` : ''}`}
|
className={`${styles.advancedToggle}${hasActiveDropdownFilters ? ` ${styles.advancedToggleActive}` : ''}`}
|
||||||
onClick={() => setFiltersOpen((v) => !v)}
|
onClick={() => setFiltersOpen((v) => !v)}
|
||||||
aria-expanded={filtersOpen}
|
aria-expanded={filtersOpen}
|
||||||
>
|
>
|
||||||
{hasActiveDropdownFilters ? 'Filters' : 'Advanced'}
|
<SlidersIcon />
|
||||||
|
More filters
|
||||||
{hasActiveDropdownFilters
|
{hasActiveDropdownFilters
|
||||||
? ` (${activeDropdownFilters.length})`
|
? ` (${activeDropdownFilters.length})`
|
||||||
: ""}
|
: ""}
|
||||||
@@ -423,116 +826,113 @@ export function FilterBar({
|
|||||||
/>
|
/>
|
||||||
</button>
|
</button>
|
||||||
|
|
||||||
{hasActiveFilters && (
|
{appliedCount > 0 && (
|
||||||
<button
|
<button
|
||||||
onClick={handleClearFilters}
|
onClick={handleClearFilterValues}
|
||||||
className={`btn btn-tertiary ${styles.clearButton}`}
|
className={`btn btn-tertiary ${styles.clearButton}`}
|
||||||
type="button"
|
type="button"
|
||||||
disabled={isPending}
|
disabled={isPending}
|
||||||
>
|
>
|
||||||
Clear
|
Clear all
|
||||||
</button>
|
</button>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{filtersOpen && (
|
{filtersOpen && (
|
||||||
<div className={styles.filters}>
|
<div className={styles.filters}>
|
||||||
<SelectShell wide>
|
{laSelect("panel")}
|
||||||
<select
|
{faithOptions.length > 0 && faithSelect("panel")}
|
||||||
value={currentLA}
|
|
||||||
onChange={(e) =>
|
|
||||||
handleFilterChange("local_authority", e.target.value)
|
|
||||||
}
|
|
||||||
className={`${styles.filterSelect}${activeIf(currentLA)}`}
|
|
||||||
disabled={isPending}
|
|
||||||
>
|
|
||||||
<option value="">All Local Authorities</option>
|
|
||||||
{laOptions.map((la) => (
|
|
||||||
<option key={la} value={la}>
|
|
||||||
{la}
|
|
||||||
</option>
|
|
||||||
))}
|
|
||||||
</select>
|
|
||||||
</SelectShell>
|
|
||||||
|
|
||||||
<SelectShell wide>
|
|
||||||
<select
|
|
||||||
value={currentType}
|
|
||||||
onChange={(e) =>
|
|
||||||
handleFilterChange("school_type", e.target.value)
|
|
||||||
}
|
|
||||||
className={`${styles.filterSelect}${activeIf(currentType)}`}
|
|
||||||
disabled={isPending}
|
|
||||||
>
|
|
||||||
<option value="">All School Types</option>
|
|
||||||
{typeOptions.map((type) => (
|
|
||||||
<option key={type} value={type}>
|
|
||||||
{type}
|
|
||||||
</option>
|
|
||||||
))}
|
|
||||||
</select>
|
|
||||||
</SelectShell>
|
|
||||||
|
|
||||||
{isSecondaryMode && (
|
{isSecondaryMode && (
|
||||||
<>
|
<>
|
||||||
{genderOptions.length > 0 && (
|
{genderOptions.length > 0 && genderSelect("panel")}
|
||||||
<SelectShell wide>
|
{sixthFormSelect("panel")}
|
||||||
<select
|
{admissionsPolicyOptions.length > 0 && admissionsSelect("panel")}
|
||||||
value={currentGender}
|
|
||||||
onChange={(e) =>
|
|
||||||
handleFilterChange("gender", e.target.value)
|
|
||||||
}
|
|
||||||
className={`${styles.filterSelect}${activeIf(currentGender)}`}
|
|
||||||
disabled={isPending}
|
|
||||||
>
|
|
||||||
<option value="">Boys, Girls & Mixed</option>
|
|
||||||
{genderOptions.map((g) => (
|
|
||||||
<option key={g} value={g.toLowerCase()}>
|
|
||||||
{g}
|
|
||||||
</option>
|
|
||||||
))}
|
|
||||||
</select>
|
|
||||||
</SelectShell>
|
|
||||||
)}
|
|
||||||
|
|
||||||
<SelectShell wide>
|
|
||||||
<select
|
|
||||||
value={currentHasSixthForm}
|
|
||||||
onChange={(e) =>
|
|
||||||
handleFilterChange("has_sixth_form", e.target.value)
|
|
||||||
}
|
|
||||||
className={`${styles.filterSelect}${activeIf(currentHasSixthForm)}`}
|
|
||||||
disabled={isPending}
|
|
||||||
>
|
|
||||||
<option value="">With or without sixth form</option>
|
|
||||||
<option value="yes">With sixth form</option>
|
|
||||||
<option value="no">Without sixth form</option>
|
|
||||||
</select>
|
|
||||||
</SelectShell>
|
|
||||||
|
|
||||||
{admissionsPolicyOptions.length > 0 && (
|
|
||||||
<SelectShell wide>
|
|
||||||
<select
|
|
||||||
value={currentAdmissionsPolicy}
|
|
||||||
onChange={(e) =>
|
|
||||||
handleFilterChange("admissions_policy", e.target.value)
|
|
||||||
}
|
|
||||||
className={`${styles.filterSelect}${activeIf(currentAdmissionsPolicy)}`}
|
|
||||||
disabled={isPending}
|
|
||||||
>
|
|
||||||
<option value="">All admissions types</option>
|
|
||||||
{admissionsPolicyOptions.map((p) => (
|
|
||||||
<option key={p} value={p.toLowerCase()}>
|
|
||||||
{p}
|
|
||||||
</option>
|
|
||||||
))}
|
|
||||||
</select>
|
|
||||||
</SelectShell>
|
|
||||||
)}
|
|
||||||
</>
|
</>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
{/* Phones: what is applied, each removable with a tap. The line
|
||||||
|
scrolls sideways if it overflows, under the same right-edge fade
|
||||||
|
as the school page's section nav. */}
|
||||||
|
{(appliedCount > 0 || triggerOnChipsLine) && (
|
||||||
|
<div
|
||||||
|
ref={controlsRowRef}
|
||||||
|
className={`${styles.chipsLine}${controlsAtEnd ? ` ${styles.controlsAtEnd}` : ""}`}
|
||||||
|
onScroll={updateControlsAtEnd}
|
||||||
|
>
|
||||||
|
{triggerOnChipsLine && sheetTrigger}
|
||||||
|
{appliedCount > 0 && (
|
||||||
|
<div className={styles.chips} role="group" aria-label="Applied filters">
|
||||||
|
{applied.map(({ key, label }) => (
|
||||||
|
<button
|
||||||
|
key={key}
|
||||||
|
type="button"
|
||||||
|
className={styles.chip}
|
||||||
|
onClick={() => handleFilterChange(key, "")}
|
||||||
|
aria-label={`Remove filter: ${label}`}
|
||||||
|
disabled={isPending}
|
||||||
|
>
|
||||||
|
<span className={styles.chipLabel}>{label}</span>
|
||||||
|
<svg
|
||||||
|
width="14"
|
||||||
|
height="14"
|
||||||
|
viewBox="0 0 24 24"
|
||||||
|
fill="none"
|
||||||
|
stroke="currentColor"
|
||||||
|
strokeWidth="2.5"
|
||||||
|
strokeLinecap="round"
|
||||||
|
aria-hidden="true"
|
||||||
|
>
|
||||||
|
<path d="M18 6 6 18M6 6l12 12" />
|
||||||
|
</svg>
|
||||||
|
</button>
|
||||||
|
))}
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`btn btn-tertiary ${styles.chipsClear}`}
|
||||||
|
onClick={handleClearFilterValues}
|
||||||
|
disabled={isPending}
|
||||||
|
>
|
||||||
|
Clear all
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
|
||||||
|
<FilterSheet
|
||||||
|
open={sheetOpen}
|
||||||
|
onClose={() => setSheetOpen(false)}
|
||||||
|
radius={currentPostcode ? currentRadius : null}
|
||||||
|
onRadiusChange={(r) => updateURL({ radius: r })}
|
||||||
|
onClearAll={appliedCount > 0 ? handleClearFilterValues : undefined}
|
||||||
|
resultCount={resultCount}
|
||||||
|
isPending={isPending}
|
||||||
|
>
|
||||||
|
{phaseOptions.length > 0 && (
|
||||||
|
<SheetField label="Phase">{phaseSelect("sheet")}</SheetField>
|
||||||
|
)}
|
||||||
|
{typeOptions.length > 0 && (
|
||||||
|
<SheetField label="School type">{typeSelect("sheet")}</SheetField>
|
||||||
|
)}
|
||||||
|
{faithOptions.length > 0 && (
|
||||||
|
<SheetField label="Faith">{faithSelect("sheet")}</SheetField>
|
||||||
|
)}
|
||||||
|
<SheetField label="Local authority">{laSelect("sheet")}</SheetField>
|
||||||
|
{isSecondaryMode && (
|
||||||
|
<>
|
||||||
|
{genderOptions.length > 0 && (
|
||||||
|
<SheetField label="Gender">{genderSelect("sheet")}</SheetField>
|
||||||
|
)}
|
||||||
|
<SheetField label="Sixth form">{sixthFormSelect("sheet")}</SheetField>
|
||||||
|
{admissionsPolicyOptions.length > 0 && (
|
||||||
|
<SheetField label="Admissions">{admissionsSelect("sheet")}</SheetField>
|
||||||
|
)}
|
||||||
|
</>
|
||||||
|
)}
|
||||||
|
</FilterSheet>
|
||||||
</>
|
</>
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
@@ -0,0 +1,92 @@
|
|||||||
|
/* ── Phone filter sheet ───────────────────────────────────────────── */
|
||||||
|
|
||||||
|
.body {
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
gap: 1rem;
|
||||||
|
padding: 1rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.field {
|
||||||
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
gap: 0.375rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.fieldLabel {
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 600;
|
||||||
|
color: var(--text-primary);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Distance: five joined segments, a full-width row. At 360px each is about
|
||||||
|
65px wide, clear of the 44px minimum. */
|
||||||
|
.segments {
|
||||||
|
display: flex;
|
||||||
|
border: 1px solid var(--border-strong);
|
||||||
|
border-radius: var(--radius-sm);
|
||||||
|
overflow: hidden;
|
||||||
|
}
|
||||||
|
|
||||||
|
.segment {
|
||||||
|
position: relative;
|
||||||
|
flex: 1 1 0;
|
||||||
|
display: flex;
|
||||||
|
}
|
||||||
|
|
||||||
|
.segment + .segment {
|
||||||
|
border-left: 1px solid var(--border);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* The real radio stays in the tree for keyboard and screen readers; the span
|
||||||
|
is what is drawn. */
|
||||||
|
.segment input {
|
||||||
|
position: absolute;
|
||||||
|
inset: 0;
|
||||||
|
margin: 0;
|
||||||
|
opacity: 0;
|
||||||
|
cursor: pointer;
|
||||||
|
}
|
||||||
|
|
||||||
|
.segment span {
|
||||||
|
flex: 1;
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
min-height: 2.75rem;
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 500;
|
||||||
|
color: var(--text-primary);
|
||||||
|
background: var(--bg-card);
|
||||||
|
white-space: nowrap;
|
||||||
|
transition: background-color var(--transition), color var(--transition);
|
||||||
|
}
|
||||||
|
|
||||||
|
.segment input:checked + span {
|
||||||
|
background: rgba(var(--sage-rgb), 0.38);
|
||||||
|
color: var(--brand-strong);
|
||||||
|
font-weight: 700;
|
||||||
|
}
|
||||||
|
|
||||||
|
.segment input:focus-visible + span {
|
||||||
|
box-shadow: inset 0 0 0 2px var(--brand);
|
||||||
|
}
|
||||||
|
|
||||||
|
.footer {
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.75rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.clearAll {
|
||||||
|
min-height: 2.75rem;
|
||||||
|
padding: 0 1rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.show {
|
||||||
|
flex: 1;
|
||||||
|
min-height: 2.75rem;
|
||||||
|
justify-content: center;
|
||||||
|
}
|
||||||
@@ -0,0 +1,121 @@
|
|||||||
|
"use client";
|
||||||
|
|
||||||
|
import { useId } from "react";
|
||||||
|
import type { ReactNode } from "react";
|
||||||
|
import { Modal } from "./Modal";
|
||||||
|
import styles from "./FilterSheet.module.css";
|
||||||
|
|
||||||
|
export const RADIUS_OPTIONS = ["0.25", "0.5", "1", "3", "5"] as const;
|
||||||
|
|
||||||
|
export const radiusLabel = (r: string) => `${r} mile${r === "1" ? "" : "s"}`;
|
||||||
|
|
||||||
|
interface FilterSheetProps {
|
||||||
|
open: boolean;
|
||||||
|
onClose: () => void;
|
||||||
|
/** The current distance, or null when the search is not by postcode. */
|
||||||
|
radius: string | null;
|
||||||
|
onRadiusChange: (radius: string) => void;
|
||||||
|
/** The filter selects, each already labelled; FilterBar owns their state. */
|
||||||
|
children: ReactNode;
|
||||||
|
/** Shown only when something is applied. */
|
||||||
|
onClearAll?: () => void;
|
||||||
|
resultCount?: number;
|
||||||
|
isPending: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Every filter in one place, for phones. A change applies at once, as it does
|
||||||
|
* in the desktop toolbar, so the results behind the sheet are already the
|
||||||
|
* filtered ones and the footer button only has to close it.
|
||||||
|
*/
|
||||||
|
export function FilterSheet({
|
||||||
|
open,
|
||||||
|
onClose,
|
||||||
|
radius,
|
||||||
|
onRadiusChange,
|
||||||
|
children,
|
||||||
|
onClearAll,
|
||||||
|
resultCount,
|
||||||
|
isPending,
|
||||||
|
}: FilterSheetProps) {
|
||||||
|
const distanceId = useId();
|
||||||
|
|
||||||
|
const showLabel = isPending
|
||||||
|
? "Updating…"
|
||||||
|
: resultCount === undefined
|
||||||
|
? "Show schools"
|
||||||
|
: resultCount === 0
|
||||||
|
? "No schools match"
|
||||||
|
: `Show ${resultCount.toLocaleString()} school${resultCount === 1 ? "" : "s"}`;
|
||||||
|
|
||||||
|
return (
|
||||||
|
<Modal
|
||||||
|
isOpen={open}
|
||||||
|
onClose={onClose}
|
||||||
|
title="Filters"
|
||||||
|
size="small"
|
||||||
|
footer={
|
||||||
|
<div className={styles.footer}>
|
||||||
|
{onClearAll && (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`btn btn-tertiary ${styles.clearAll}`}
|
||||||
|
onClick={onClearAll}
|
||||||
|
>
|
||||||
|
Clear all
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={`btn btn-action ${styles.show}`}
|
||||||
|
onClick={onClose}
|
||||||
|
>
|
||||||
|
{showLabel}
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
}
|
||||||
|
>
|
||||||
|
{/* Controls stay enabled while a change lands, so focus is never
|
||||||
|
dropped out of the dialog; aria-busy says the results are updating. */}
|
||||||
|
<div className={styles.body} aria-busy={isPending}>
|
||||||
|
{radius !== null && (
|
||||||
|
<div className={styles.field}>
|
||||||
|
<span id={distanceId} className={styles.fieldLabel}>
|
||||||
|
Distance
|
||||||
|
</span>
|
||||||
|
<div
|
||||||
|
className={styles.segments}
|
||||||
|
role="radiogroup"
|
||||||
|
aria-labelledby={distanceId}
|
||||||
|
>
|
||||||
|
{RADIUS_OPTIONS.map((r) => (
|
||||||
|
<label key={r} className={styles.segment}>
|
||||||
|
<input
|
||||||
|
type="radio"
|
||||||
|
name={`${distanceId}-radius`}
|
||||||
|
value={r}
|
||||||
|
checked={r === radius}
|
||||||
|
onChange={() => onRadiusChange(r)}
|
||||||
|
aria-label={`Within ${radiusLabel(r)}`}
|
||||||
|
/>
|
||||||
|
<span>{r} mi</span>
|
||||||
|
</label>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
{children}
|
||||||
|
</div>
|
||||||
|
</Modal>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
/** One labelled row of the sheet. */
|
||||||
|
export function SheetField({ label, children }: { label: string; children: ReactNode }) {
|
||||||
|
return (
|
||||||
|
<label className={styles.field}>
|
||||||
|
<span className={styles.fieldLabel}>{label}</span>
|
||||||
|
{children}
|
||||||
|
</label>
|
||||||
|
);
|
||||||
|
}
|
||||||
@@ -10,7 +10,17 @@
|
|||||||
import { LogoMark } from './Logo';
|
import { LogoMark } from './Logo';
|
||||||
import styles from './Footer.module.css';
|
import styles from './Footer.module.css';
|
||||||
|
|
||||||
export function Footer() {
|
/**
|
||||||
|
* Both default to false so a caller that forgets a prop hides the link rather
|
||||||
|
* than pointing it at a page that 404s. Same reasoning as backend/flags.py:
|
||||||
|
* "Every flag defaults to False."
|
||||||
|
*/
|
||||||
|
interface FooterProps {
|
||||||
|
aboutEnabled?: boolean;
|
||||||
|
blogEnabled?: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function Footer({ aboutEnabled = false, blogEnabled = false }: FooterProps = {}) {
|
||||||
const currentYear = new Date().getFullYear();
|
const currentYear = new Date().getFullYear();
|
||||||
|
|
||||||
return (
|
return (
|
||||||
@@ -94,17 +104,26 @@ export function Footer() {
|
|||||||
</ul>
|
</ul>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div className={styles.section}>
|
{/* Dropped entirely when both flags are dark, rather than left as an
|
||||||
<h4 className={styles.sectionTitle}>About</h4>
|
empty heading: shipping dark means the footer renders as it did
|
||||||
<ul className={styles.links}>
|
before the feature existed. */}
|
||||||
{/* The only route to a named human. Deliberately not in the nav:
|
{(aboutEnabled || blogEnabled) && (
|
||||||
the mobile bottom bar already carries four items, and both of
|
<div className={styles.section}>
|
||||||
these are lower intent than any of them. Post bylines link
|
<h4 className={styles.sectionTitle}>About</h4>
|
||||||
here too, which is where a reader actually asks the question. */}
|
<ul className={styles.links}>
|
||||||
<li><a href="/about" className={styles.link}>Who's behind this</a></li>
|
{/* The only route to a named human. Deliberately not in the nav:
|
||||||
<li><a href="/blog" className={styles.link}>Blog</a></li>
|
the mobile bottom bar already carries four items, and both of
|
||||||
</ul>
|
these are lower intent than any of them. Post bylines link
|
||||||
</div>
|
here too, which is where a reader actually asks the question. */}
|
||||||
|
{aboutEnabled && (
|
||||||
|
<li><a href="/about" className={styles.link}>Who's behind this</a></li>
|
||||||
|
)}
|
||||||
|
{blogEnabled && (
|
||||||
|
<li><a href="/blog" className={styles.link}>Blog</a></li>
|
||||||
|
)}
|
||||||
|
</ul>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
<div className={styles.bottom}>
|
<div className={styles.bottom}>
|
||||||
|
|||||||
@@ -484,42 +484,84 @@
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/* View Toggle */
|
/* ── Results toolbar ───────────────────────────────────────────────────────
|
||||||
.viewToggle {
|
Search, filters and the List/Map switch in one card, pinned under the
|
||||||
|
header. It sits above Leaflet's controls (z-index 1000), which scroll up
|
||||||
|
beneath it, and below the comparison toast and the map's own fullscreen
|
||||||
|
overlay. */
|
||||||
|
.resultsToolbar {
|
||||||
|
position: sticky;
|
||||||
|
top: calc(64px + 0.5rem);
|
||||||
|
z-index: 1001;
|
||||||
display: flex;
|
display: flex;
|
||||||
gap: 0.2rem;
|
align-items: flex-start;
|
||||||
background: var(--bg-secondary);
|
gap: 0.75rem;
|
||||||
padding: 0.2rem;
|
margin-bottom: 1.25rem;
|
||||||
border-radius: 6px;
|
padding: 0.875rem 1rem;
|
||||||
}
|
|
||||||
|
|
||||||
.viewToggleBtn {
|
|
||||||
display: flex;
|
|
||||||
align-items: center;
|
|
||||||
gap: 0.25rem;
|
|
||||||
padding: 0.375rem 0.625rem;
|
|
||||||
font-size: 0.8125rem;
|
|
||||||
font-weight: 500;
|
|
||||||
background: transparent;
|
|
||||||
border: none;
|
|
||||||
border-radius: 5px;
|
|
||||||
cursor: pointer;
|
|
||||||
color: var(--text-secondary);
|
|
||||||
transition: all 0.2s ease;
|
|
||||||
}
|
|
||||||
|
|
||||||
.viewToggleBtn:hover {
|
|
||||||
color: var(--text-primary);
|
|
||||||
}
|
|
||||||
|
|
||||||
.viewToggleBtn.active {
|
|
||||||
background: var(--bg-card);
|
background: var(--bg-card);
|
||||||
color: var(--brand-strong);
|
border: 1px solid var(--border);
|
||||||
box-shadow: 0 2px 4px rgba(var(--shadow-rgb), 0.08);
|
border-radius: var(--radius-lg);
|
||||||
|
box-shadow: var(--shadow-soft);
|
||||||
}
|
}
|
||||||
|
|
||||||
.viewToggleBtn svg {
|
.resultsToolbar > :first-child {
|
||||||
|
flex: 1;
|
||||||
|
min-width: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* The one filled control in the toolbar: which view you are in is the first
|
||||||
|
thing a results page should answer. */
|
||||||
|
.viewSwitch {
|
||||||
flex-shrink: 0;
|
flex-shrink: 0;
|
||||||
|
display: flex;
|
||||||
|
gap: 2px;
|
||||||
|
padding: 1px;
|
||||||
|
background: var(--bg-card);
|
||||||
|
border: 1.5px solid var(--brand);
|
||||||
|
border-radius: var(--radius-md);
|
||||||
|
}
|
||||||
|
|
||||||
|
.viewSwitchBtn {
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.5rem;
|
||||||
|
min-height: 2.5rem;
|
||||||
|
padding: 0 1.125rem;
|
||||||
|
background: transparent;
|
||||||
|
border: 0;
|
||||||
|
border-radius: calc(var(--radius-md) - 3px);
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 700;
|
||||||
|
color: var(--brand-strong);
|
||||||
|
cursor: pointer;
|
||||||
|
transition: background-color var(--transition), color var(--transition);
|
||||||
|
}
|
||||||
|
|
||||||
|
.viewSwitchBtn:hover {
|
||||||
|
background: var(--brand-bg);
|
||||||
|
}
|
||||||
|
|
||||||
|
.viewSwitchBtn[aria-pressed='true'] {
|
||||||
|
background: var(--brand);
|
||||||
|
color: var(--brand-on);
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Phones: a full-bleed band flush under the header, and the switch gives way
|
||||||
|
to the floating button in .mobileDock. */
|
||||||
|
@media (max-width: 640px) {
|
||||||
|
.resultsToolbar {
|
||||||
|
top: 56px;
|
||||||
|
margin: -1rem -1rem 1rem;
|
||||||
|
padding: 0.75rem 1rem;
|
||||||
|
border-width: 0 0 1px;
|
||||||
|
border-radius: 0;
|
||||||
|
box-shadow: 0 2px 8px rgba(var(--shadow-rgb), 0.06);
|
||||||
|
}
|
||||||
|
|
||||||
|
.viewSwitch {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
.results {
|
.results {
|
||||||
@@ -530,136 +572,132 @@
|
|||||||
margin-top: 0;
|
margin-top: 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Map View Layout */
|
/* ── Map view ──────────────────────────────────────────────────────────────
|
||||||
|
The list on the left, the map filling the rest, in one card that runs from
|
||||||
|
under the pinned toolbar to the bottom of the screen. --toolbar-h is the
|
||||||
|
toolbar's measured height, written by HomeView. */
|
||||||
|
/* Where the split starts before any scrolling: header, the page's top
|
||||||
|
padding (globals.css .main), the toolbar and its margin. */
|
||||||
|
.homeView {
|
||||||
|
--map-top: calc(64px + 1.25rem + var(--toolbar-h, 76px) + 1.25rem);
|
||||||
|
--map-bottom: 1rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
@media (max-width: 768px) {
|
||||||
|
.homeView {
|
||||||
|
--map-top: calc(64px + 1rem + var(--toolbar-h, 76px) + 1.25rem);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
.mapViewContainer {
|
.mapViewContainer {
|
||||||
display: grid;
|
display: grid;
|
||||||
grid-template-columns: 1fr 340px;
|
grid-template-columns: minmax(360px, 460px) minmax(0, 1fr);
|
||||||
gap: 1rem;
|
height: calc(100dvh - var(--map-top) - var(--map-bottom));
|
||||||
height: calc(100dvh - 280px);
|
min-height: 480px;
|
||||||
min-height: 520px;
|
|
||||||
max-height: 800px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.mapContainer {
|
|
||||||
border-radius: 10px;
|
|
||||||
overflow: hidden;
|
|
||||||
border: 1px solid var(--border);
|
|
||||||
height: 100%;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactList {
|
|
||||||
display: flex;
|
|
||||||
flex-direction: column;
|
|
||||||
gap: 0.5rem;
|
|
||||||
overflow-y: auto;
|
|
||||||
height: 100%;
|
|
||||||
padding-right: 0.375rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactList::-webkit-scrollbar {
|
|
||||||
width: 6px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactList::-webkit-scrollbar-track {
|
|
||||||
background: var(--bg-secondary);
|
|
||||||
border-radius: 3px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactList::-webkit-scrollbar-thumb {
|
|
||||||
background: var(--border);
|
|
||||||
border-radius: 3px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactList::-webkit-scrollbar-thumb:hover {
|
|
||||||
background: var(--text-muted);
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Compact School Item */
|
|
||||||
.compactItem {
|
|
||||||
display: flex;
|
|
||||||
justify-content: space-between;
|
|
||||||
align-items: center;
|
|
||||||
gap: 0.75rem;
|
|
||||||
padding: 0.625rem 0.75rem;
|
|
||||||
background: var(--bg-card);
|
background: var(--bg-card);
|
||||||
border: 1px solid var(--border);
|
border: 1px solid var(--border);
|
||||||
border-radius: 8px;
|
border-radius: var(--radius-lg);
|
||||||
transition: all 0.2s ease;
|
overflow: hidden;
|
||||||
}
|
}
|
||||||
|
|
||||||
.compactItem:hover {
|
.mapListPane {
|
||||||
border-color: var(--brand);
|
display: flex;
|
||||||
box-shadow: 0 2px 6px rgba(var(--shadow-rgb), 0.05);
|
flex-direction: column;
|
||||||
|
min-height: 0;
|
||||||
|
background: var(--bg-primary);
|
||||||
|
border-right: 1px solid var(--border);
|
||||||
}
|
}
|
||||||
|
|
||||||
.compactItemContent {
|
/* One line: the count takes what the sort leaves, and truncates rather than
|
||||||
|
wrap if a narrow pane cannot fit both. */
|
||||||
|
.mapListPane .resultsHeader {
|
||||||
|
flex-wrap: nowrap;
|
||||||
|
gap: 0.75rem;
|
||||||
|
padding: 0.875rem 1rem 0.75rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mapListPane .resultsHeader h2 {
|
||||||
flex: 1;
|
flex: 1;
|
||||||
min-width: 0;
|
min-width: 0;
|
||||||
}
|
font-size: var(--step-0);
|
||||||
|
|
||||||
.compactItemHeader {
|
|
||||||
display: flex;
|
|
||||||
align-items: center;
|
|
||||||
gap: 0.375rem;
|
|
||||||
margin-bottom: 0.125rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactItemName {
|
|
||||||
font-weight: 600;
|
|
||||||
font-size: 0.8125rem;
|
|
||||||
color: var(--text-primary);
|
|
||||||
text-decoration: none;
|
|
||||||
white-space: nowrap;
|
white-space: nowrap;
|
||||||
overflow: hidden;
|
overflow: hidden;
|
||||||
text-overflow: ellipsis;
|
text-overflow: ellipsis;
|
||||||
}
|
}
|
||||||
|
|
||||||
.compactItemName:hover {
|
.mapListPane .resultsHeaderActions {
|
||||||
color: var(--brand-strong);
|
|
||||||
}
|
|
||||||
|
|
||||||
.distanceBadge {
|
|
||||||
flex-shrink: 0;
|
flex-shrink: 0;
|
||||||
padding: 0.0625rem 0.375rem;
|
|
||||||
font-size: 0.6875rem;
|
|
||||||
font-weight: 600;
|
|
||||||
background: var(--brand);
|
|
||||||
color: var(--brand-on);
|
|
||||||
border-radius: 3px;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.compactItemMeta {
|
/* A select is as wide as its longest option ("Highest Reading, Writing &
|
||||||
display: flex;
|
Maths %", 281px), more than half the pane. Cap it; a long choice truncates. */
|
||||||
gap: 0.375rem;
|
.mapListPane .sortSelect {
|
||||||
font-size: 0.6875rem;
|
max-width: 11rem;
|
||||||
color: var(--text-secondary);
|
text-overflow: ellipsis;
|
||||||
margin-bottom: 0.25rem;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.compactItemMeta span:not(:last-child)::after {
|
.mapContainer {
|
||||||
content: '·';
|
height: 100%;
|
||||||
margin-left: 0.375rem;
|
min-height: 0;
|
||||||
color: var(--text-muted);
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.compactItemStats {
|
.compactList {
|
||||||
display: flex;
|
|
||||||
gap: 0.75rem;
|
|
||||||
font-size: 0.6875rem;
|
|
||||||
color: var(--text-secondary);
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactStat strong {
|
|
||||||
color: var(--text-primary);
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactItemActions {
|
|
||||||
display: flex;
|
display: flex;
|
||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
gap: 0.25rem;
|
gap: 0.625rem;
|
||||||
flex-shrink: 0;
|
flex: 1;
|
||||||
|
min-height: 0;
|
||||||
|
overflow-y: auto;
|
||||||
|
padding: 0.125rem 1rem 1rem;
|
||||||
|
scrollbar-width: thin;
|
||||||
|
/* The rows lay themselves out by this list's width (SchoolRow.module.css),
|
||||||
|
which here is always narrow, whatever the screen. */
|
||||||
|
container: results / inline-size;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* A row in the list beside the map: clicking it picks its pin. */
|
||||||
|
.mapRow {
|
||||||
|
position: relative;
|
||||||
|
cursor: pointer;
|
||||||
|
border-radius: 10px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mapRowSelected > :last-child {
|
||||||
|
outline: 2px solid var(--brand);
|
||||||
|
outline-offset: 1px;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Visually hidden until focused, then a pill over the row's top edge. */
|
||||||
|
.showOnMap {
|
||||||
|
position: absolute;
|
||||||
|
width: 1px;
|
||||||
|
height: 1px;
|
||||||
|
overflow: hidden;
|
||||||
|
clip-path: inset(50%);
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
.showOnMap:focus-visible {
|
||||||
|
top: -0.5rem;
|
||||||
|
right: 0.75rem;
|
||||||
|
z-index: 1;
|
||||||
|
width: auto;
|
||||||
|
height: auto;
|
||||||
|
padding: 0.375rem 0.75rem;
|
||||||
|
overflow: visible;
|
||||||
|
clip-path: none;
|
||||||
|
background: var(--brand);
|
||||||
|
color: var(--brand-on);
|
||||||
|
border: 0;
|
||||||
|
border-radius: 999px;
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 700;
|
||||||
|
outline: 2px solid var(--text-primary);
|
||||||
|
outline-offset: 2px;
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
|
||||||
.sectionHeader {
|
.sectionHeader {
|
||||||
margin-bottom: 1rem;
|
margin-bottom: 1rem;
|
||||||
@@ -696,6 +734,8 @@
|
|||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
gap: 0.5rem;
|
gap: 0.5rem;
|
||||||
margin-bottom: 1.25rem;
|
margin-bottom: 1.25rem;
|
||||||
|
/* The rows lay themselves out by this list's width (SchoolRow.module.css). */
|
||||||
|
container: results / inline-size;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Staggered fade-in for rows */
|
/* Staggered fade-in for rows */
|
||||||
@@ -744,11 +784,6 @@
|
|||||||
justify-content: space-between;
|
justify-content: space-between;
|
||||||
}
|
}
|
||||||
|
|
||||||
.viewToggle {
|
|
||||||
justify-content: center;
|
|
||||||
flex-shrink: 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* The sort <select> sizes to its widest option ("Highest Reading, Writing
|
/* The sort <select> sizes to its widest option ("Highest Reading, Writing
|
||||||
& Maths %"), which overflows a phone viewport — beside the view toggle it
|
& Maths %"), which overflows a phone viewport — beside the view toggle it
|
||||||
ran off the right edge. Let it flex into the remaining space and shrink;
|
ran off the right edge. Let it flex into the remaining space and shrink;
|
||||||
@@ -758,67 +793,43 @@
|
|||||||
min-width: 0;
|
min-width: 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
.mapViewContainer {
|
|
||||||
grid-template-columns: 1fr;
|
|
||||||
grid-template-rows: 260px auto;
|
|
||||||
height: auto;
|
|
||||||
gap: 0.75rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.mapContainer {
|
|
||||||
height: 260px;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactList {
|
|
||||||
height: auto;
|
|
||||||
max-height: 350px;
|
|
||||||
padding-right: 0;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactItem {
|
|
||||||
flex-direction: column;
|
|
||||||
align-items: stretch;
|
|
||||||
gap: 0.5rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactItemActions {
|
|
||||||
flex-direction: row;
|
|
||||||
}
|
|
||||||
|
|
||||||
.compactItemActions > * {
|
|
||||||
flex: 1;
|
|
||||||
}
|
|
||||||
|
|
||||||
.emptyState {
|
.emptyState {
|
||||||
padding: 2rem 1.25rem;
|
padding: 2rem 1.25rem;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Highlighted List Item */
|
/* ── Mobile dock ───────────────────────────────────────────────────────────
|
||||||
.highlightedItem .compactItem {
|
The floating List/Map button (phones only) above the selected pin's card.
|
||||||
border-color: var(--brand);
|
A column, so the button always clears the card instead of covering it. */
|
||||||
box-shadow: 0 0 0 1px var(--brand);
|
.mobileDock {
|
||||||
background: var(--bg-secondary);
|
display: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
/* Mobile Bottom Sheet */
|
.viewFab {
|
||||||
.bottomSheetWrapper {
|
|
||||||
display: none;
|
display: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
@media (max-width: 768px) {
|
@media (max-width: 768px) {
|
||||||
.bottomSheetWrapper {
|
.mobileDock {
|
||||||
display: block;
|
display: flex;
|
||||||
|
flex-direction: column;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.75rem;
|
||||||
position: fixed;
|
position: fixed;
|
||||||
bottom: 0;
|
bottom: 0;
|
||||||
left: 0;
|
left: 0;
|
||||||
width: 100%;
|
width: 100%;
|
||||||
z-index: 1000;
|
z-index: 1002;
|
||||||
padding: 1rem;
|
padding: 1rem;
|
||||||
pointer-events: none;
|
pointer-events: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.mobileDock > * {
|
||||||
|
pointer-events: auto;
|
||||||
|
}
|
||||||
|
|
||||||
.bottomSheet {
|
.bottomSheet {
|
||||||
|
align-self: stretch;
|
||||||
position: relative;
|
position: relative;
|
||||||
background: var(--bg-card);
|
background: var(--bg-card);
|
||||||
border-radius: 12px;
|
border-radius: 12px;
|
||||||
@@ -827,36 +838,37 @@
|
|||||||
animation: slideUpSheet 0.3s cubic-bezier(0.16, 1, 0.3, 1) forwards;
|
animation: slideUpSheet 0.3s cubic-bezier(0.16, 1, 0.3, 1) forwards;
|
||||||
}
|
}
|
||||||
|
|
||||||
.bottomSheet .compactItem {
|
|
||||||
border: none;
|
|
||||||
box-shadow: none;
|
|
||||||
background: transparent;
|
|
||||||
padding: 1rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.bottomSheet .compactItem:hover {
|
|
||||||
box-shadow: none;
|
|
||||||
}
|
|
||||||
|
|
||||||
|
/* A 30px circle, drawn by ::before, inside a 44px target (MOBILE.md). */
|
||||||
.closeSheetBtn {
|
.closeSheetBtn {
|
||||||
position: absolute;
|
position: absolute;
|
||||||
top: -12px;
|
top: -19px;
|
||||||
right: -12px;
|
right: -15px;
|
||||||
width: 30px;
|
width: 44px;
|
||||||
height: 30px;
|
height: 44px;
|
||||||
background: var(--bg-card);
|
padding: 0;
|
||||||
border: 1px solid var(--border);
|
background: none;
|
||||||
border-radius: 50%;
|
border: 0;
|
||||||
display: flex;
|
display: flex;
|
||||||
align-items: center;
|
align-items: center;
|
||||||
justify-content: center;
|
justify-content: center;
|
||||||
font-size: 1.25rem;
|
font-size: 1.25rem;
|
||||||
color: var(--text-secondary);
|
color: var(--text-secondary);
|
||||||
cursor: pointer;
|
cursor: pointer;
|
||||||
box-shadow: 0 2px 8px rgba(var(--shadow-rgb), 0.1);
|
|
||||||
z-index: 10;
|
z-index: 10;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.closeSheetBtn::before {
|
||||||
|
content: '';
|
||||||
|
position: absolute;
|
||||||
|
inset: 7px;
|
||||||
|
z-index: -1;
|
||||||
|
background: var(--bg-card);
|
||||||
|
border: 1px solid var(--border);
|
||||||
|
border-radius: 50%;
|
||||||
|
box-shadow: 0 2px 8px rgba(var(--shadow-rgb), 0.1);
|
||||||
|
}
|
||||||
|
|
||||||
@keyframes slideUpSheet {
|
@keyframes slideUpSheet {
|
||||||
from {
|
from {
|
||||||
transform: translateY(120%);
|
transform: translateY(120%);
|
||||||
@@ -866,21 +878,76 @@
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/* When map view on mobile, expand map and hide list */
|
/* Map only: the pane keeps its heading, the cards give way to the pins and
|
||||||
|
the bottom sheet. */
|
||||||
.mapViewContainer {
|
.mapViewContainer {
|
||||||
grid-template-columns: 1fr;
|
grid-template-columns: minmax(0, 1fr);
|
||||||
grid-template-rows: 1fr;
|
grid-template-rows: auto minmax(0, 1fr);
|
||||||
height: calc(100dvh - 280px);
|
border-radius: var(--radius-md);
|
||||||
min-height: 400px;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.mapContainer {
|
.mapListPane {
|
||||||
height: 100%;
|
border-right: 0;
|
||||||
|
border-bottom: 1px solid var(--border);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.mapListPane .sortSelect,
|
||||||
.compactList {
|
.compactList {
|
||||||
display: none;
|
display: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* The sheet holds one results row, which is the card itself. It is not
|
||||||
|
inside a `results` container, so give it one: a phone-width sheet takes
|
||||||
|
the row's narrow layout. */
|
||||||
|
.bottomSheet {
|
||||||
|
container: results / inline-size;
|
||||||
|
}
|
||||||
|
|
||||||
|
.mapListPane .resultsHeader {
|
||||||
|
padding: 0.625rem 0.875rem;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Above the tab bar, and riding with it when iOS Chrome's URL bar hides
|
||||||
|
(MOBILE.md, check 4). */
|
||||||
|
@media (max-width: 640px) {
|
||||||
|
.mobileDock {
|
||||||
|
bottom: calc(56px + env(safe-area-inset-bottom, 0px));
|
||||||
|
padding: 0.75rem;
|
||||||
|
transform: translate3d(0, var(--mobile-bar-offset, 0px), 0);
|
||||||
|
}
|
||||||
|
|
||||||
|
.viewFab {
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.5rem;
|
||||||
|
min-height: 3rem;
|
||||||
|
padding: 0 1.375rem;
|
||||||
|
background: var(--text-primary);
|
||||||
|
color: var(--bg-primary);
|
||||||
|
border: 0;
|
||||||
|
border-radius: 999px;
|
||||||
|
box-shadow: 0 8px 20px rgba(var(--shadow-rgb), 0.32);
|
||||||
|
font-family: var(--font-ui);
|
||||||
|
font-size: var(--step--1);
|
||||||
|
font-weight: 700;
|
||||||
|
cursor: pointer;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Room under the last card so the floating button never sits on it. */
|
||||||
|
.hasViewFab {
|
||||||
|
padding-bottom: 4.5rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* The map runs down to the tab bar; the button floats over the map. */
|
||||||
|
.mapViewResults.hasViewFab {
|
||||||
|
padding-bottom: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.homeView {
|
||||||
|
--map-top: calc(56px + var(--toolbar-h, 124px) + 1rem);
|
||||||
|
--map-bottom: calc(56px + env(safe-area-inset-bottom, 0px) + 1rem);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
.quickSearches {
|
.quickSearches {
|
||||||
@@ -1466,37 +1533,6 @@
|
|||||||
cursor: pointer;
|
cursor: pointer;
|
||||||
}
|
}
|
||||||
|
|
||||||
.activeFilters {
|
|
||||||
display: flex;
|
|
||||||
flex-wrap: wrap;
|
|
||||||
gap: 0.5rem;
|
|
||||||
margin-bottom: 1rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.filterChip {
|
|
||||||
display: inline-flex;
|
|
||||||
align-items: center;
|
|
||||||
gap: 0.375rem;
|
|
||||||
padding: 0.25rem 0.625rem;
|
|
||||||
background: var(--bg-secondary);
|
|
||||||
border: 1px solid var(--border);
|
|
||||||
border-radius: 999px;
|
|
||||||
font-size: 0.8rem;
|
|
||||||
color: var(--text-secondary);
|
|
||||||
}
|
|
||||||
|
|
||||||
.chipRemove {
|
|
||||||
color: var(--text-muted);
|
|
||||||
text-decoration: none;
|
|
||||||
font-size: 0.9rem;
|
|
||||||
line-height: 1;
|
|
||||||
transition: color var(--transition, 0.2s ease);
|
|
||||||
}
|
|
||||||
|
|
||||||
.chipRemove:hover {
|
|
||||||
color: var(--text-primary);
|
|
||||||
}
|
|
||||||
|
|
||||||
.loadMoreSection {
|
.loadMoreSection {
|
||||||
display: flex;
|
display: flex;
|
||||||
flex-direction: column;
|
flex-direction: column;
|
||||||
|
|||||||
+338
-255
@@ -5,7 +5,7 @@
|
|||||||
|
|
||||||
'use client';
|
'use client';
|
||||||
|
|
||||||
import React, { useState, useEffect, useRef, useCallback } from 'react';
|
import React, { useState, useEffect, useRef, useCallback, useMemo } from 'react';
|
||||||
import { useSearchParams, useRouter, usePathname } from 'next/navigation';
|
import { useSearchParams, useRouter, usePathname } from 'next/navigation';
|
||||||
import { FilterBar } from './FilterBar';
|
import { FilterBar } from './FilterBar';
|
||||||
import { SchoolRow } from './SchoolRow';
|
import { SchoolRow } from './SchoolRow';
|
||||||
@@ -16,8 +16,8 @@ import { HeroIllustration } from './Illustration';
|
|||||||
import { useComparisonContext } from '@/context/ComparisonContext';
|
import { useComparisonContext } from '@/context/ComparisonContext';
|
||||||
import { fetchSchools, fetchLAaverages, fetchNationalAverages } from '@/lib/api';
|
import { fetchSchools, fetchLAaverages, fetchNationalAverages } from '@/lib/api';
|
||||||
import type { SchoolsResponse, Filters, School } from '@/lib/types';
|
import type { SchoolsResponse, Filters, School } from '@/lib/types';
|
||||||
import { schoolUrl, buildOfstedListBadge } from '@/lib/utils';
|
|
||||||
import { track } from '@/lib/analytics';
|
import { track } from '@/lib/analytics';
|
||||||
|
import { DEFAULT_RADIUS_MILES } from '@/lib/utils';
|
||||||
import styles from './HomeView.module.css';
|
import styles from './HomeView.module.css';
|
||||||
|
|
||||||
interface HomeViewProps {
|
interface HomeViewProps {
|
||||||
@@ -33,6 +33,13 @@ interface HomeViewProps {
|
|||||||
autosuggest?: boolean;
|
autosuggest?: boolean;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/*
|
||||||
|
* The view a postcode search opens in, on every screen size. The map is on
|
||||||
|
* trial as the default (2026-09-30); results_view_changed shows how often
|
||||||
|
* readers switch away from it. Name searches have no map and always list.
|
||||||
|
*/
|
||||||
|
const DEFAULT_LOCATION_VIEW: 'list' | 'map' = 'map';
|
||||||
|
|
||||||
function daysUntil(month: number, day: number): number {
|
function daysUntil(month: number, day: number): number {
|
||||||
const today = new Date();
|
const today = new Date();
|
||||||
today.setHours(0, 0, 0, 0);
|
today.setHours(0, 0, 0, 0);
|
||||||
@@ -135,6 +142,27 @@ function CalendarIcon() {
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* List / Map glyphs for the results view switch and its floating twin. */
|
||||||
|
function ListIcon() {
|
||||||
|
return (
|
||||||
|
<svg {...ICON_PROPS} width={18} height={18}>
|
||||||
|
<path d="M9 6h11M9 12h11M9 18h11" />
|
||||||
|
<circle cx="4.5" cy="6" r="1" />
|
||||||
|
<circle cx="4.5" cy="12" r="1" />
|
||||||
|
<circle cx="4.5" cy="18" r="1" />
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
function MapIcon() {
|
||||||
|
return (
|
||||||
|
<svg {...ICON_PROPS} width={18} height={18}>
|
||||||
|
<path d="M9 4 3 6v14l6-2 6 2 6-2V4l-6 2-6-2Z" />
|
||||||
|
<path d="M9 4v14M15 6v14" />
|
||||||
|
</svg>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
interface ValueProp {
|
interface ValueProp {
|
||||||
icon: React.ReactNode;
|
icon: React.ReactNode;
|
||||||
tintClass: string;
|
tintClass: string;
|
||||||
@@ -149,11 +177,12 @@ interface ValueProp {
|
|||||||
* and is backed by the next-deadline bar further down this page.
|
* and is backed by the next-deadline bar further down this page.
|
||||||
*
|
*
|
||||||
* Every claim here must name something the product actually does. Two of the
|
* Every claim here must name something the product actually does. Two of the
|
||||||
* four previously did not: "up to three schools" contradicted MAX_SCHOOLS = 5
|
* four previously did not: "up to three schools" contradicted the basket limit
|
||||||
* in context/ComparisonProvider.tsx (and the card further down the page, which
|
* of five (and the card further down the page, which correctly said five), and
|
||||||
* correctly said five), and "class sizes" described data the codebase has never
|
* "class sizes" described data the codebase has never held — grep for it and
|
||||||
* held — grep for it and this line was the only hit. Both are corrected below
|
* this line was the only hit. Both are corrected below against the real
|
||||||
* against the real fields, which live in components/school/InclusionSection.tsx.
|
* fields, which live in components/school/InclusionSection.tsx.
|
||||||
|
* The limit is now five per phase: MAX_PER_GROUP in lib/compareLogic.ts.
|
||||||
*/
|
*/
|
||||||
const VALUE_PROPS: ValueProp[] = [
|
const VALUE_PROPS: ValueProp[] = [
|
||||||
{
|
{
|
||||||
@@ -179,13 +208,13 @@ const VALUE_PROPS: ValueProp[] = [
|
|||||||
icon: <BarsIcon />,
|
icon: <BarsIcon />,
|
||||||
tintClass: styles.propIconCompare,
|
tintClass: styles.propIconCompare,
|
||||||
title: 'Easy to compare',
|
title: 'Easy to compare',
|
||||||
body: 'Up to five schools side by side, on the measures that matter.',
|
body: 'Up to five primary and five secondary schools side by side, on the measures that matter.',
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
icon: <HeartIcon />,
|
icon: <HeartIcon />,
|
||||||
tintClass: styles.propIconContext,
|
tintClass: styles.propIconContext,
|
||||||
title: 'Beyond the numbers',
|
title: 'Beyond the numbers',
|
||||||
body: 'SEN support, pupil premium and attendance — not just results.',
|
body: 'Not just results: SEN support, pupil premium and attendance too.',
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
icon: <CalendarIcon />,
|
icon: <CalendarIcon />,
|
||||||
@@ -200,7 +229,13 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
const router = useRouter();
|
const router = useRouter();
|
||||||
const pathname = usePathname();
|
const pathname = usePathname();
|
||||||
const { addSchool, removeSchool, selectedSchools } = useComparisonContext();
|
const { addSchool, removeSchool, selectedSchools } = useComparisonContext();
|
||||||
const [resultsView, setResultsView] = useState<'list' | 'map'>('list');
|
/*
|
||||||
|
* The reader's choice, once they make one; until then the default for the
|
||||||
|
* kind of search. Derived rather than seeded into state, because a hero
|
||||||
|
* search reaches the results by client-side navigation: the same instance
|
||||||
|
* gets new props, and a state seeded on the landing page would stay "list".
|
||||||
|
*/
|
||||||
|
const [chosenView, setChosenView] = useState<'list' | 'map' | null>(null);
|
||||||
const [selectedMapSchool, setSelectedMapSchool] = useState<School | null>(null);
|
const [selectedMapSchool, setSelectedMapSchool] = useState<School | null>(null);
|
||||||
const sortOrder = searchParams.get('sort') || 'default';
|
const sortOrder = searchParams.get('sort') || 'default';
|
||||||
const [allSchools, setAllSchools] = useState<School[]>(initialSchools.schools);
|
const [allSchools, setAllSchools] = useState<School[]>(initialSchools.schools);
|
||||||
@@ -212,7 +247,21 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
const [mapSchools, setMapSchools] = useState<School[]>([]);
|
const [mapSchools, setMapSchools] = useState<School[]>([]);
|
||||||
const [isLoadingMap, setIsLoadingMap] = useState(false);
|
const [isLoadingMap, setIsLoadingMap] = useState(false);
|
||||||
const prevSearchParamsRef = useRef(searchParams.toString());
|
const prevSearchParamsRef = useRef(searchParams.toString());
|
||||||
|
const toolbarRef = useRef<HTMLDivElement>(null);
|
||||||
|
const resultsRef = useRef<HTMLElement>(null);
|
||||||
|
const mapListRef = useRef<HTMLDivElement>(null);
|
||||||
|
|
||||||
const mapParamsRef = useRef<string>('');
|
const mapParamsRef = useRef<string>('');
|
||||||
|
const loadMoreController = useRef<AbortController | null>(null);
|
||||||
|
// Identity changes even for A → B → A, so an old A response stays stale.
|
||||||
|
const searchScope = useRef({ key: searchParams.toString() });
|
||||||
|
if (searchScope.current.key !== searchParams.toString()) {
|
||||||
|
searchScope.current = { key: searchParams.toString() };
|
||||||
|
}
|
||||||
|
useEffect(() => {
|
||||||
|
setIsLoadingMore(false);
|
||||||
|
return () => { loadMoreController.current?.abort(); };
|
||||||
|
}, [searchParams]);
|
||||||
const [geoState, setGeoState] = useState<'idle' | 'requesting' | 'error'>('idle');
|
const [geoState, setGeoState] = useState<'idle' | 'requesting' | 'error'>('idle');
|
||||||
const [geoError, setGeoError] = useState<string | null>(null);
|
const [geoError, setGeoError] = useState<string | null>(null);
|
||||||
/*
|
/*
|
||||||
@@ -249,6 +298,18 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
const isSecondaryView = currentPhase.toLowerCase().includes('secondary')
|
const isSecondaryView = currentPhase.toLowerCase().includes('secondary')
|
||||||
|| (!currentPhase && secondaryCount > primaryCount);
|
|| (!currentPhase && secondaryCount > primaryCount);
|
||||||
const isMixedView = primaryCount > 0 && secondaryCount > 0 && !currentPhase;
|
const isMixedView = primaryCount > 0 && secondaryCount > 0 && !currentPhase;
|
||||||
|
const resultsView: 'list' | 'map' = chosenView ?? (isLocationSearch ? DEFAULT_LOCATION_VIEW : 'list');
|
||||||
|
|
||||||
|
// The map view fills the screen below the pinned toolbar, whose height
|
||||||
|
// depends on how its controls wrap. Measure it rather than guess.
|
||||||
|
const [toolbarHeight, setToolbarHeight] = useState<number | null>(null);
|
||||||
|
useEffect(() => {
|
||||||
|
const el = toolbarRef.current;
|
||||||
|
if (!el || typeof ResizeObserver === 'undefined') return;
|
||||||
|
const observer = new ResizeObserver(() => setToolbarHeight(Math.round(el.getBoundingClientRect().height)));
|
||||||
|
observer.observe(el);
|
||||||
|
return () => observer.disconnect();
|
||||||
|
}, [isSearchActive]);
|
||||||
|
|
||||||
// Reset pagination and map cache when search params change
|
// Reset pagination and map cache when search params change
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -274,17 +335,28 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
if (resultsView !== 'map' || !isLocationSearch) return;
|
if (resultsView !== 'map' || !isLocationSearch) return;
|
||||||
const paramsKey = searchParams.toString();
|
const paramsKey = searchParams.toString();
|
||||||
if (paramsKey === mapParamsRef.current) return;
|
if (paramsKey === mapParamsRef.current) return;
|
||||||
mapParamsRef.current = paramsKey;
|
const controller = new AbortController();
|
||||||
|
const scope = searchScope.current;
|
||||||
|
const current = () => !controller.signal.aborted && searchScope.current === scope;
|
||||||
setIsLoadingMap(true);
|
setIsLoadingMap(true);
|
||||||
const params: Record<string, any> = {};
|
const params: Record<string, any> = {};
|
||||||
searchParams.forEach((value, key) => { params[key] = value; });
|
searchParams.forEach((value, key) => { params[key] = value; });
|
||||||
|
params.radius ??= DEFAULT_RADIUS_MILES;
|
||||||
params.page = 1;
|
params.page = 1;
|
||||||
params.page_size = 500;
|
params.page_size = 500;
|
||||||
fetchSchools(params, { cache: 'no-store' })
|
fetchSchools(params, { cache: 'no-store', signal: controller.signal })
|
||||||
.then(r => setMapSchools(r.schools))
|
.then(r => {
|
||||||
.catch(() => setMapSchools(initialSchools.schools))
|
if (!current()) return;
|
||||||
.finally(() => setIsLoadingMap(false));
|
mapParamsRef.current = paramsKey;
|
||||||
}, [resultsView, searchParams]);
|
setMapSchools(r.schools);
|
||||||
|
})
|
||||||
|
.catch(() => {
|
||||||
|
if (current()) setMapSchools(initialSchools.schools);
|
||||||
|
// No cache marker on failure: opening the map again retries.
|
||||||
|
})
|
||||||
|
.finally(() => { if (current()) setIsLoadingMap(false); });
|
||||||
|
return () => controller.abort();
|
||||||
|
}, [resultsView, searchParams, initialSchools.schools]);
|
||||||
|
|
||||||
// Fetch LA averages when secondary or mixed schools are visible
|
// Fetch LA averages when secondary or mixed schools are visible
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -305,19 +377,25 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
if (isLoadingMore || !hasMore) return;
|
if (isLoadingMore || !hasMore) return;
|
||||||
track('results_load_more', { next_page: currentPage + 1 });
|
track('results_load_more', { next_page: currentPage + 1 });
|
||||||
setIsLoadingMore(true);
|
setIsLoadingMore(true);
|
||||||
|
const scope = searchScope.current;
|
||||||
|
const controller = new AbortController();
|
||||||
|
loadMoreController.current?.abort();
|
||||||
|
loadMoreController.current = controller;
|
||||||
|
const current = () => !controller.signal.aborted && searchScope.current === scope;
|
||||||
try {
|
try {
|
||||||
const params: Record<string, any> = {};
|
const params: Record<string, any> = {};
|
||||||
searchParams.forEach((value, key) => { params[key] = value; });
|
searchParams.forEach((value, key) => { params[key] = value; });
|
||||||
params.page = currentPage + 1;
|
params.page = currentPage + 1;
|
||||||
params.page_size = initialSchools.page_size;
|
params.page_size = initialSchools.page_size;
|
||||||
const response = await fetchSchools(params, { cache: 'no-store' });
|
const response = await fetchSchools(params, { cache: 'no-store', signal: controller.signal });
|
||||||
|
if (!current()) return;
|
||||||
setAllSchools(prev => [...prev, ...response.schools]);
|
setAllSchools(prev => [...prev, ...response.schools]);
|
||||||
setCurrentPage(response.page);
|
setCurrentPage(response.page);
|
||||||
setHasMore(response.page < response.total_pages);
|
setHasMore(response.page < response.total_pages);
|
||||||
} catch {
|
} catch {
|
||||||
// silently ignore
|
// silently ignore
|
||||||
} finally {
|
} finally {
|
||||||
setIsLoadingMore(false);
|
if (current()) setIsLoadingMore(false);
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -343,7 +421,7 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
setGeoState('idle');
|
setGeoState('idle');
|
||||||
track('near_me_used', { outcome: 'granted' });
|
track('near_me_used', { outcome: 'granted' });
|
||||||
track('search_submitted', { query: postcode, via: 'near_me', has_postcode: true, filters_active: '', filters_count: 0 });
|
track('search_submitted', { query: postcode, via: 'near_me', has_postcode: true, filters_active: '', filters_count: 0 });
|
||||||
router.push(`/?postcode=${encodeURIComponent(postcode)}&radius=1`);
|
router.push(`/?postcode=${encodeURIComponent(postcode)}&radius=${DEFAULT_RADIUS_MILES}`);
|
||||||
} else {
|
} else {
|
||||||
track('near_me_used', { outcome: 'no_postcode' });
|
track('near_me_used', { outcome: 'no_postcode' });
|
||||||
setGeoState('error');
|
setGeoState('error');
|
||||||
@@ -369,7 +447,7 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
);
|
);
|
||||||
}, [router]);
|
}, [router]);
|
||||||
|
|
||||||
const sortedSchools = [...allSchools].sort((a, b) => {
|
const sortSchools = (list: School[]) => [...list].sort((a, b) => {
|
||||||
if (sortOrder === 'rwm_desc') return (b.rwm_expected_pct ?? -Infinity) - (a.rwm_expected_pct ?? -Infinity);
|
if (sortOrder === 'rwm_desc') return (b.rwm_expected_pct ?? -Infinity) - (a.rwm_expected_pct ?? -Infinity);
|
||||||
if (sortOrder === 'rwm_asc') return (a.rwm_expected_pct ?? Infinity) - (b.rwm_expected_pct ?? Infinity);
|
if (sortOrder === 'rwm_asc') return (a.rwm_expected_pct ?? Infinity) - (b.rwm_expected_pct ?? Infinity);
|
||||||
if (sortOrder === 'att8_desc') return (b.attainment_8_score ?? -Infinity) - (a.attainment_8_score ?? -Infinity);
|
if (sortOrder === 'att8_desc') return (b.attainment_8_score ?? -Infinity) - (a.attainment_8_score ?? -Infinity);
|
||||||
@@ -378,6 +456,15 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
if (sortOrder === 'name_asc') return a.school_name.localeCompare(b.school_name);
|
if (sortOrder === 'name_asc') return a.school_name.localeCompare(b.school_name);
|
||||||
return 0;
|
return 0;
|
||||||
});
|
});
|
||||||
|
const sortedSchools = sortSchools(allSchools);
|
||||||
|
// The map gets a stable array (a new one rebuilds every pin and closes the
|
||||||
|
// open card); only the list beside it is sorted.
|
||||||
|
const mapResultSchools = mapSchools.length > 0 ? mapSchools : initialSchools.schools;
|
||||||
|
const mapListSchools = sortSchools(mapResultSchools);
|
||||||
|
// Two places, so a 0.25-mile search is not drawn or labelled as 0.3.
|
||||||
|
const radiusMiles = initialSchools.location_info
|
||||||
|
? Number((initialSchools.location_info.radius / 1.60934).toFixed(2))
|
||||||
|
: undefined;
|
||||||
|
|
||||||
// Empty-results sentinel: track when a search returns nothing.
|
// Empty-results sentinel: track when a search returns nothing.
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
@@ -422,11 +509,133 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
});
|
});
|
||||||
}, [addSchool, selectedSchools.length]);
|
}, [addSchool, selectedSchools.length]);
|
||||||
|
|
||||||
|
const hasViewSwitch = isLocationSearch && initialSchools.schools.length > 0;
|
||||||
|
const compareUrns = useMemo(() => selectedSchools.map(s => s.urn), [selectedSchools]);
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Below 769px the map view hides its list pane (HomeView.module.css), and
|
||||||
|
* with the map now the default on phones, every postcode search there
|
||||||
|
* would otherwise build up to 500 hidden cards. Decided after mount, so
|
||||||
|
* the server's HTML and the first client render still agree.
|
||||||
|
*/
|
||||||
|
const [listPaneShown, setListPaneShown] = useState(true);
|
||||||
|
useEffect(() => {
|
||||||
|
if (typeof window.matchMedia !== 'function') return;
|
||||||
|
const query = window.matchMedia('(min-width: 769px)');
|
||||||
|
const update = () => setListPaneShown(query.matches);
|
||||||
|
update();
|
||||||
|
query.addEventListener('change', update);
|
||||||
|
return () => query.removeEventListener('change', update);
|
||||||
|
}, []);
|
||||||
|
const clearMapSelection = useCallback(() => setSelectedMapSchool(null), []);
|
||||||
|
|
||||||
|
// A pin chosen on the map brings its card into view in the list beside it.
|
||||||
|
useEffect(() => {
|
||||||
|
if (!selectedMapSchool) return;
|
||||||
|
const card = mapListRef.current?.querySelector<HTMLElement>(`[data-urn="${selectedMapSchool.urn}"]`);
|
||||||
|
if (card?.offsetParent) card.scrollIntoView({ block: 'nearest', behavior: 'smooth' });
|
||||||
|
}, [selectedMapSchool]);
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Switching view from far down the list would otherwise leave the reader
|
||||||
|
* looking at whatever now sits at that scroll offset, usually the footer,
|
||||||
|
* because the map layout is much shorter than a long list. Bring the top of
|
||||||
|
* the results back to just under the pinned toolbar instead.
|
||||||
|
*/
|
||||||
|
const changeView = (view: 'list' | 'map', via: 'toolbar' | 'floating') => {
|
||||||
|
if (view === resultsView) return;
|
||||||
|
setChosenView(view);
|
||||||
|
track('results_view_changed', { view, via });
|
||||||
|
requestAnimationFrame(() => {
|
||||||
|
const results = resultsRef.current;
|
||||||
|
const toolbar = toolbarRef.current;
|
||||||
|
if (!results || !toolbar) return;
|
||||||
|
const toolbarBottom = toolbar.getBoundingClientRect().bottom;
|
||||||
|
const resultsTop = results.getBoundingClientRect().top;
|
||||||
|
if (resultsTop < toolbarBottom) {
|
||||||
|
window.scrollTo({ top: window.scrollY + resultsTop - toolbarBottom - 12 });
|
||||||
|
}
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
|
const isMapView = initialSchools.schools.length > 0 && resultsView === 'map' && isLocationSearch;
|
||||||
|
|
||||||
|
// One school as a results row: the list view, the list beside the map and
|
||||||
|
// the phone's bottom sheet all draw the same thing.
|
||||||
|
const renderRow = (school: School) => (
|
||||||
|
school.attainment_8_score != null ? (
|
||||||
|
<SecondarySchoolRow
|
||||||
|
key={school.urn}
|
||||||
|
school={school}
|
||||||
|
isLocationSearch={isLocationSearch}
|
||||||
|
onAddToCompare={addSchoolFromSearch}
|
||||||
|
onRemoveFromCompare={removeSchool}
|
||||||
|
isInCompare={compareUrns.includes(school.urn)}
|
||||||
|
laAvgAttainment8={school.local_authority ? laAverages[school.local_authority] ?? null : null}
|
||||||
|
/>
|
||||||
|
) : (
|
||||||
|
<SchoolRow
|
||||||
|
key={school.urn}
|
||||||
|
school={school}
|
||||||
|
isLocationSearch={isLocationSearch}
|
||||||
|
onAddToCompare={addSchoolFromSearch}
|
||||||
|
onRemoveFromCompare={removeSchool}
|
||||||
|
isInCompare={compareUrns.includes(school.urn)}
|
||||||
|
nationalAvgRwm={nationalAvgRwm}
|
||||||
|
/>
|
||||||
|
)
|
||||||
|
);
|
||||||
|
|
||||||
|
const schoolCount = `${initialSchools.total.toLocaleString()} school${initialSchools.total !== 1 ? 's' : ''}`;
|
||||||
|
|
||||||
|
// The count and the sort. Above the list in list view; at the top of the
|
||||||
|
// list pane, beside the map, in map view.
|
||||||
|
const resultsHeader = (
|
||||||
|
<div className={styles.resultsHeader}>
|
||||||
|
<h2 aria-live="polite" aria-atomic="true">
|
||||||
|
{/* Beside the map the heading shares one line with the sort, so it
|
||||||
|
drops the postcode, which the search box just above already shows. */}
|
||||||
|
{isMapView && radiusMiles != null
|
||||||
|
? `${schoolCount} within ${radiusMiles} mile${radiusMiles === 1 ? '' : 's'}`
|
||||||
|
: isLocationSearch && radiusMiles != null && initialSchools.location_info
|
||||||
|
? `${schoolCount} within ${radiusMiles} mile${radiusMiles === 1 ? '' : 's'} of ${initialSchools.location_info.postcode}`
|
||||||
|
: `${schoolCount} found`
|
||||||
|
}
|
||||||
|
</h2>
|
||||||
|
<div className={styles.resultsHeaderActions}>
|
||||||
|
<select
|
||||||
|
value={sortOrder}
|
||||||
|
onChange={e => {
|
||||||
|
const params = new URLSearchParams(searchParams);
|
||||||
|
if (e.target.value === 'default') {
|
||||||
|
params.delete('sort');
|
||||||
|
} else {
|
||||||
|
params.set('sort', e.target.value);
|
||||||
|
}
|
||||||
|
router.push(`${pathname}?${params.toString()}`);
|
||||||
|
}}
|
||||||
|
className={styles.sortSelect}
|
||||||
|
>
|
||||||
|
<option value="default">Sort: Relevance</option>
|
||||||
|
{(!isSecondaryView || isMixedView) && <option value="rwm_desc">Highest Reading, Writing & Maths %</option>}
|
||||||
|
{(!isSecondaryView || isMixedView) && <option value="rwm_asc">Lowest Reading, Writing & Maths %</option>}
|
||||||
|
{(isSecondaryView || isMixedView) && <option value="att8_desc">Highest Attainment 8</option>}
|
||||||
|
{(isSecondaryView || isMixedView) && <option value="att8_asc">Lowest Attainment 8</option>}
|
||||||
|
{isLocationSearch && <option value="distance">Nearest first</option>}
|
||||||
|
<option value="name_asc">Name A–Z</option>
|
||||||
|
</select>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
/* The landing arrangement owns its own vertical rhythm (one gap, set in
|
/* The landing arrangement owns its own vertical rhythm (one gap, set in
|
||||||
CSS); the search arrangement is a filter bar directly above its results
|
CSS); the search arrangement is a filter bar directly above its results
|
||||||
and wants none of it. */
|
and wants none of it. */
|
||||||
<div className={isSearchActive ? styles.homeView : `${styles.homeView} ${styles.landing}`}>
|
<div
|
||||||
|
className={isSearchActive ? styles.homeView : `${styles.homeView} ${styles.landing}`}
|
||||||
|
style={toolbarHeight ? { '--toolbar-h': `${toolbarHeight}px` } as React.CSSProperties : undefined}
|
||||||
|
>
|
||||||
{/* Hero: a Sand panel with the proposition and the search on the left and
|
{/* Hero: a Sand panel with the proposition and the search on the left and
|
||||||
the brand landscape bleeding to the panel edge on the right. The
|
the brand landscape bleeding to the panel edge on the right. The
|
||||||
search lives inside the panel here and above the results elsewhere,
|
search lives inside the panel here and above the results elsewhere,
|
||||||
@@ -452,8 +661,8 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
every line above the fold costs. */}
|
every line above the fold costs. */}
|
||||||
<span className={styles.heroDescriptionFull}>
|
<span className={styles.heroDescriptionFull}>
|
||||||
{' '}Key Stage 2 SATs, GCSE results, Ofsted grades, progress scores
|
{' '}Key Stage 2 SATs, GCSE results, Ofsted grades, progress scores
|
||||||
and admissions data{coverageLabel && <> for <strong>{coverageLabel} schools</strong></>} — side by
|
and admissions data{coverageLabel && <> for <strong>{coverageLabel} schools</strong></>}, side by
|
||||||
side, in one place.
|
side in one place.
|
||||||
</span>
|
</span>
|
||||||
</p>
|
</p>
|
||||||
|
|
||||||
@@ -496,15 +705,42 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
</ul>
|
</ul>
|
||||||
</div>
|
</div>
|
||||||
) : (
|
) : (
|
||||||
<FilterBar
|
/* Pinned under the header, so the search, the filters and the List/Map
|
||||||
filters={filters}
|
switch stay in reach however far down the results a reader is. */
|
||||||
isHero={false}
|
<div ref={toolbarRef} className={styles.resultsToolbar}>
|
||||||
resultFilters={initialSchools.result_filters}
|
<FilterBar
|
||||||
onNearMe={handleNearMe}
|
filters={filters}
|
||||||
geoState={geoState}
|
isHero={false}
|
||||||
geoError={geoError}
|
resultFilters={initialSchools.result_filters}
|
||||||
autosuggest={autosuggest}
|
resultCount={initialSchools.total}
|
||||||
/>
|
onNearMe={handleNearMe}
|
||||||
|
geoState={geoState}
|
||||||
|
geoError={geoError}
|
||||||
|
autosuggest={autosuggest}
|
||||||
|
viewSwitch={hasViewSwitch && (
|
||||||
|
<div className={styles.viewSwitch} role="group" aria-label="Results view">
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={styles.viewSwitchBtn}
|
||||||
|
aria-pressed={resultsView === 'list'}
|
||||||
|
onClick={() => changeView('list', 'toolbar')}
|
||||||
|
>
|
||||||
|
<ListIcon />
|
||||||
|
List
|
||||||
|
</button>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={styles.viewSwitchBtn}
|
||||||
|
aria-pressed={resultsView === 'map'}
|
||||||
|
onClick={() => changeView('map', 'toolbar')}
|
||||||
|
>
|
||||||
|
<MapIcon />
|
||||||
|
Map
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{/* Next admissions deadline — one bar, not four cards. */}
|
{/* Next admissions deadline — one bar, not four cards. */}
|
||||||
@@ -556,7 +792,10 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
nothing to list — an empty <section> is still a flex child, so it was
|
nothing to list — an empty <section> is still a flex child, so it was
|
||||||
contributing a full section gap of blank space above the footer. */}
|
contributing a full section gap of blank space above the footer. */}
|
||||||
{(isSearchActive || initialSchools.schools.length > 0) && (
|
{(isSearchActive || initialSchools.schools.length > 0) && (
|
||||||
<section className={`${styles.results} ${resultsView === 'map' && isLocationSearch ? styles.mapViewResults : ''}`}>
|
<section
|
||||||
|
ref={resultsRef}
|
||||||
|
className={`${styles.results} ${resultsView === 'map' && isLocationSearch ? styles.mapViewResults : ''} ${hasViewSwitch ? styles.hasViewFab : ''}`}
|
||||||
|
>
|
||||||
{!hasSearch && initialSchools.schools.length > 0 && (
|
{!hasSearch && initialSchools.schools.length > 0 && (
|
||||||
<div className={styles.sectionHeader}>
|
<div className={styles.sectionHeader}>
|
||||||
<h2>Featured Schools</h2>
|
<h2>Featured Schools</h2>
|
||||||
@@ -566,77 +805,7 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
{hasSearch && (
|
{hasSearch && !isMapView && resultsHeader}
|
||||||
<div className={styles.resultsHeader}>
|
|
||||||
<h2 aria-live="polite" aria-atomic="true">
|
|
||||||
{isLocationSearch && initialSchools.location_info
|
|
||||||
? `${initialSchools.total.toLocaleString()} school${initialSchools.total !== 1 ? 's' : ''} within ${(initialSchools.location_info.radius / 1.60934).toFixed(1)} miles of ${initialSchools.location_info.postcode}`
|
|
||||||
: `${initialSchools.total.toLocaleString()} school${initialSchools.total !== 1 ? 's' : ''} found`
|
|
||||||
}
|
|
||||||
</h2>
|
|
||||||
<div className={styles.resultsHeaderActions}>
|
|
||||||
{isLocationSearch && initialSchools.schools.length > 0 && (
|
|
||||||
<div className={styles.viewToggle}>
|
|
||||||
<button
|
|
||||||
className={`${styles.viewToggleBtn} ${resultsView === 'list' ? styles.active : ''}`}
|
|
||||||
onClick={() => setResultsView('list')}
|
|
||||||
>
|
|
||||||
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" width="16" height="16">
|
|
||||||
<line x1="8" y1="6" x2="21" y2="6"/>
|
|
||||||
<line x1="8" y1="12" x2="21" y2="12"/>
|
|
||||||
<line x1="8" y1="18" x2="21" y2="18"/>
|
|
||||||
<line x1="3" y1="6" x2="3.01" y2="6"/>
|
|
||||||
<line x1="3" y1="12" x2="3.01" y2="12"/>
|
|
||||||
<line x1="3" y1="18" x2="3.01" y2="18"/>
|
|
||||||
</svg>
|
|
||||||
List
|
|
||||||
</button>
|
|
||||||
<button
|
|
||||||
className={`${styles.viewToggleBtn} ${resultsView === 'map' ? styles.active : ''}`}
|
|
||||||
onClick={() => setResultsView('map')}
|
|
||||||
>
|
|
||||||
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" strokeWidth="2" width="16" height="16">
|
|
||||||
<path d="M21 10c0 7-9 13-9 13s-9-6-9-13a9 9 0 0 1 18 0z"/>
|
|
||||||
<circle cx="12" cy="10" r="3"/>
|
|
||||||
</svg>
|
|
||||||
Map
|
|
||||||
</button>
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
{resultsView === 'list' && (
|
|
||||||
<select
|
|
||||||
value={sortOrder}
|
|
||||||
onChange={e => {
|
|
||||||
const params = new URLSearchParams(searchParams);
|
|
||||||
if (e.target.value === 'default') {
|
|
||||||
params.delete('sort');
|
|
||||||
} else {
|
|
||||||
params.set('sort', e.target.value);
|
|
||||||
}
|
|
||||||
router.push(`${pathname}?${params.toString()}`);
|
|
||||||
}}
|
|
||||||
className={styles.sortSelect}
|
|
||||||
>
|
|
||||||
<option value="default">Sort: Relevance</option>
|
|
||||||
{(!isSecondaryView || isMixedView) && <option value="rwm_desc">Highest Reading, Writing & Maths %</option>}
|
|
||||||
{(!isSecondaryView || isMixedView) && <option value="rwm_asc">Lowest Reading, Writing & Maths %</option>}
|
|
||||||
{(isSecondaryView || isMixedView) && <option value="att8_desc">Highest Attainment 8</option>}
|
|
||||||
{(isSecondaryView || isMixedView) && <option value="att8_asc">Lowest Attainment 8</option>}
|
|
||||||
{isLocationSearch && <option value="distance">Nearest first</option>}
|
|
||||||
<option value="name_asc">Name A–Z</option>
|
|
||||||
</select>
|
|
||||||
)}
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
{isSearchActive && (
|
|
||||||
<div className={styles.activeFilters}>
|
|
||||||
{searchParams.get('search') && <span className={styles.filterChip}>Search: {searchParams.get('search')}<a href="/" className={styles.chipRemove} onClick={e => { e.preventDefault(); }}>×</a></span>}
|
|
||||||
{searchParams.get('local_authority') && <span className={styles.filterChip}>{searchParams.get('local_authority')}</span>}
|
|
||||||
{searchParams.get('school_type') && <span className={styles.filterChip}>{searchParams.get('school_type')}</span>}
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
|
|
||||||
{initialSchools.schools.length === 0 && isSearchActive ? (
|
{initialSchools.schools.length === 0 && isSearchActive ? (
|
||||||
<EmptyState
|
<EmptyState
|
||||||
@@ -649,77 +818,62 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
},
|
},
|
||||||
}}
|
}}
|
||||||
/>
|
/>
|
||||||
) : initialSchools.schools.length > 0 && resultsView === 'map' && isLocationSearch ? (
|
) : isMapView ? (
|
||||||
/* Map View Layout */
|
/* Map View Layout: the list beside the map, as one card. */
|
||||||
<div className={styles.mapViewContainer}>
|
<div className={styles.mapViewContainer}>
|
||||||
|
<div className={styles.mapListPane}>
|
||||||
|
{resultsHeader}
|
||||||
|
<div ref={mapListRef} className={styles.compactList}>
|
||||||
|
{/* The list view's own rows, so both views show the same thing.
|
||||||
|
Clicking a row (not its links or buttons) picks its pin. */}
|
||||||
|
{listPaneShown && mapListSchools.map((school) => (
|
||||||
|
<div
|
||||||
|
key={school.urn}
|
||||||
|
data-urn={school.urn}
|
||||||
|
className={`${styles.mapRow} ${selectedMapSchool?.urn === school.urn ? styles.mapRowSelected : ''}`}
|
||||||
|
onClick={(e) => {
|
||||||
|
if ((e.target as HTMLElement).closest('a, button')) return;
|
||||||
|
setSelectedMapSchool(school);
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
{/* The keyboard's way to pick the pin: hidden until it has
|
||||||
|
focus, since a pointer just clicks the row. The row
|
||||||
|
itself cannot be the button, as it holds links and
|
||||||
|
buttons of its own. */}
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
className={styles.showOnMap}
|
||||||
|
aria-pressed={selectedMapSchool?.urn === school.urn}
|
||||||
|
onClick={() => setSelectedMapSchool(school)}
|
||||||
|
>
|
||||||
|
Show {school.school_name} on the map
|
||||||
|
</button>
|
||||||
|
{renderRow(school)}
|
||||||
|
</div>
|
||||||
|
))}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
<div className={styles.mapContainer}>
|
<div className={styles.mapContainer}>
|
||||||
<SchoolMap
|
<SchoolMap
|
||||||
schools={isLoadingMap ? initialSchools.schools : mapSchools}
|
schools={mapResultSchools}
|
||||||
center={initialSchools.location_info?.coordinates}
|
center={initialSchools.location_info?.coordinates}
|
||||||
referencePoint={initialSchools.location_info?.coordinates}
|
referencePoint={initialSchools.location_info?.coordinates}
|
||||||
|
radiusMiles={radiusMiles}
|
||||||
|
selectedUrn={selectedMapSchool?.urn ?? null}
|
||||||
onMarkerClick={setSelectedMapSchool}
|
onMarkerClick={setSelectedMapSchool}
|
||||||
|
onDeselect={clearMapSelection}
|
||||||
|
onAddToCompare={addSchoolFromSearch}
|
||||||
|
compareUrns={compareUrns}
|
||||||
nationalAvgRwm={nationalAvgRwm}
|
nationalAvgRwm={nationalAvgRwm}
|
||||||
laAverages={laAverages}
|
laAverages={laAverages}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
<div className={styles.compactList}>
|
|
||||||
{(isLoadingMap ? initialSchools.schools : mapSchools).map((school) => (
|
|
||||||
<div
|
|
||||||
key={school.urn}
|
|
||||||
className={`${styles.listItemWrapper} ${selectedMapSchool?.urn === school.urn ? styles.highlightedItem : ''}`}
|
|
||||||
>
|
|
||||||
<CompactSchoolItem
|
|
||||||
school={school}
|
|
||||||
onAddToCompare={addSchoolFromSearch}
|
|
||||||
isInCompare={selectedSchools.some(s => s.urn === school.urn)}
|
|
||||||
nationalAvgRwm={nationalAvgRwm}
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
))}
|
|
||||||
</div>
|
|
||||||
|
|
||||||
{/* Mobile Bottom Sheet for Selected Map Pin */}
|
|
||||||
{selectedMapSchool && (
|
|
||||||
<div className={styles.bottomSheetWrapper}>
|
|
||||||
<div className={styles.bottomSheet}>
|
|
||||||
<button className={styles.closeSheetBtn} onClick={() => setSelectedMapSchool(null)}>×</button>
|
|
||||||
<CompactSchoolItem
|
|
||||||
school={selectedMapSchool}
|
|
||||||
onAddToCompare={addSchoolFromSearch}
|
|
||||||
isInCompare={selectedSchools.some(s => s.urn === selectedMapSchool.urn)}
|
|
||||||
nationalAvgRwm={nationalAvgRwm}
|
|
||||||
/>
|
|
||||||
</div>
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
</div>
|
</div>
|
||||||
) : (
|
) : (
|
||||||
/* List View Layout */
|
/* List View Layout */
|
||||||
<>
|
<>
|
||||||
<div className={styles.schoolList}>
|
<div className={styles.schoolList}>
|
||||||
{sortedSchools.map((school) => (
|
{sortedSchools.map(renderRow)}
|
||||||
school.attainment_8_score != null ? (
|
|
||||||
<SecondarySchoolRow
|
|
||||||
key={school.urn}
|
|
||||||
school={school}
|
|
||||||
isLocationSearch={isLocationSearch}
|
|
||||||
onAddToCompare={addSchoolFromSearch}
|
|
||||||
onRemoveFromCompare={removeSchool}
|
|
||||||
isInCompare={selectedSchools.some(s => s.urn === school.urn)}
|
|
||||||
laAvgAttainment8={school.local_authority ? laAverages[school.local_authority] ?? null : null}
|
|
||||||
/>
|
|
||||||
) : (
|
|
||||||
<SchoolRow
|
|
||||||
key={school.urn}
|
|
||||||
school={school}
|
|
||||||
isLocationSearch={isLocationSearch}
|
|
||||||
onAddToCompare={addSchoolFromSearch}
|
|
||||||
onRemoveFromCompare={removeSchool}
|
|
||||||
isInCompare={selectedSchools.some(s => s.urn === school.urn)}
|
|
||||||
nationalAvgRwm={nationalAvgRwm}
|
|
||||||
/>
|
|
||||||
)
|
|
||||||
))}
|
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{(hasMore || allSchools.length < initialSchools.total) && (
|
{(hasMore || allSchools.length < initialSchools.total) && (
|
||||||
@@ -742,105 +896,34 @@ export function HomeView({ initialSchools, filters, totalSchools, howItWorks, ed
|
|||||||
)}
|
)}
|
||||||
</section>
|
</section>
|
||||||
)}
|
)}
|
||||||
</div>
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Compact School Item for Map View */
|
{/* Phones and small tablets: the selected pin's card, and on phones the
|
||||||
interface CompactSchoolItemProps {
|
floating List/Map button, stacked above the bottom tab bar. The
|
||||||
school: School;
|
toolbar's switch is hidden at phone width, where this replaces it. */}
|
||||||
onAddToCompare: (school: School) => void;
|
{hasViewSwitch && (
|
||||||
isInCompare: boolean;
|
<div className={styles.mobileDock}>
|
||||||
nationalAvgRwm?: number | null;
|
<button
|
||||||
}
|
type="button"
|
||||||
|
className={styles.viewFab}
|
||||||
function CompactSchoolItem({ school, onAddToCompare, isInCompare, nationalAvgRwm }: CompactSchoolItemProps) {
|
aria-label={resultsView === 'list' ? 'Show map' : 'Show list'}
|
||||||
const ofstedBadge = buildOfstedListBadge(school);
|
onClick={() => changeView(resultsView === 'list' ? 'map' : 'list', 'floating')}
|
||||||
const isSecondary = school.attainment_8_score != null;
|
|
||||||
|
|
||||||
// vs-national delta for primary schools
|
|
||||||
const rwmDelta =
|
|
||||||
!isSecondary && school.rwm_expected_pct != null && nationalAvgRwm != null
|
|
||||||
? Math.round(school.rwm_expected_pct - nationalAvgRwm)
|
|
||||||
: null;
|
|
||||||
|
|
||||||
const deltaStyle: React.CSSProperties =
|
|
||||||
rwmDelta == null
|
|
||||||
? {}
|
|
||||||
: rwmDelta >= 2
|
|
||||||
? { fontSize: '0.7rem', color: 'var(--status-above)', fontWeight: 600 }
|
|
||||||
: rwmDelta <= -2
|
|
||||||
? { fontSize: '0.7rem', color: 'var(--brand)', fontWeight: 600 }
|
|
||||||
: { fontSize: '0.7rem', color: 'var(--text-muted)' };
|
|
||||||
|
|
||||||
return (
|
|
||||||
<div className={styles.compactItem}>
|
|
||||||
<div className={styles.compactItemContent}>
|
|
||||||
<div className={styles.compactItemHeader}>
|
|
||||||
<a href={schoolUrl(school.urn, school.school_name)} className={styles.compactItemName}>
|
|
||||||
{school.school_name}
|
|
||||||
</a>
|
|
||||||
{school.distance !== undefined && school.distance !== null && (
|
|
||||||
<span className={styles.distanceBadge}>
|
|
||||||
{school.distance.toFixed(1)} mi
|
|
||||||
</span>
|
|
||||||
)}
|
|
||||||
</div>
|
|
||||||
{/* Ofsted badge */}
|
|
||||||
<div style={{ marginBottom: '0.25rem' }}>
|
|
||||||
<span
|
|
||||||
style={{
|
|
||||||
display: 'inline-block',
|
|
||||||
padding: '0.0625rem 0.375rem',
|
|
||||||
fontSize: '0.625rem',
|
|
||||||
fontWeight: 600,
|
|
||||||
borderRadius: '3px',
|
|
||||||
whiteSpace: 'nowrap',
|
|
||||||
...(ofstedBadge.cssClass === 'ofsted1' ? { background: 'var(--status-above-bg)', color: 'var(--status-above)' } :
|
|
||||||
ofstedBadge.cssClass === 'ofsted2' ? { background: 'var(--status-above-bg)', color: 'var(--status-above)' } :
|
|
||||||
ofstedBadge.cssClass === 'ofsted3' ? { background: 'var(--status-below-bg)', color: 'var(--status-below)' } :
|
|
||||||
ofstedBadge.cssClass === 'ofsted4' ? { background: 'var(--status-below)', color: 'var(--text-inverse)' } :
|
|
||||||
ofstedBadge.cssClass === 'ofstedRc' ? { background: 'var(--phase-secondary-text)', color: 'var(--text-inverse)' } :
|
|
||||||
ofstedBadge.cssClass === 'ofstedPending' ? { background: 'var(--bg-secondary)', color: 'var(--text-muted)' } :
|
|
||||||
{ background: 'var(--bg-secondary)', color: 'var(--text-muted)' }),
|
|
||||||
}}
|
|
||||||
>
|
>
|
||||||
{ofstedBadge.label}
|
{resultsView === 'list' ? <><MapIcon />Map</> : <><ListIcon />List</>}
|
||||||
</span>
|
</button>
|
||||||
</div>
|
{resultsView === 'map' && selectedMapSchool && (
|
||||||
{/* Headline metric + delta */}
|
<div className={styles.bottomSheet}>
|
||||||
<div className={styles.compactItemStats}>
|
<button
|
||||||
<span className={styles.compactStat}>
|
className={styles.closeSheetBtn}
|
||||||
<strong>
|
onClick={() => setSelectedMapSchool(null)}
|
||||||
{isSecondary
|
aria-label="Close"
|
||||||
? (school.attainment_8_score != null ? school.attainment_8_score.toFixed(1) : '-')
|
>
|
||||||
: (school.rwm_expected_pct != null ? `${school.rwm_expected_pct}%` : '-')}
|
×
|
||||||
</strong>
|
</button>
|
||||||
{' '}
|
{renderRow(selectedMapSchool)}
|
||||||
{isSecondary ? 'Att 8' : 'RWM'}
|
</div>
|
||||||
</span>
|
|
||||||
{rwmDelta != null && (
|
|
||||||
<span style={deltaStyle}>
|
|
||||||
{rwmDelta >= 2
|
|
||||||
? `+${rwmDelta} pts vs national`
|
|
||||||
: rwmDelta <= -2
|
|
||||||
? `${rwmDelta} pts vs national`
|
|
||||||
: '≈ national avg'}
|
|
||||||
</span>
|
|
||||||
)}
|
)}
|
||||||
</div>
|
</div>
|
||||||
</div>
|
)}
|
||||||
<div className={styles.compactItemActions}>
|
|
||||||
<button
|
|
||||||
className={isInCompare ? 'btn btn-active btn-sm' : 'btn btn-secondary btn-sm'}
|
|
||||||
onClick={() => onAddToCompare(school)}
|
|
||||||
>
|
|
||||||
{isInCompare ? '✓ Comparing' : '+ Compare'}
|
|
||||||
</button>
|
|
||||||
<a href={schoolUrl(school.urn, school.school_name)} className="btn btn-tertiary btn-sm">
|
|
||||||
View
|
|
||||||
</a>
|
|
||||||
</div>
|
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@@ -47,7 +47,7 @@ export function HowItWorksSection() {
|
|||||||
<div className={styles.sectionHead}>
|
<div className={styles.sectionHead}>
|
||||||
<p className={styles.sectionKicker}>Every school page</p>
|
<p className={styles.sectionKicker}>Every school page</p>
|
||||||
<h2 className={styles.sectionHeading}>What you'll see on every school</h2>
|
<h2 className={styles.sectionHeading}>What you'll see on every school</h2>
|
||||||
<p className={styles.sectionAside}>Primary or secondary — the page adapts to the phase</p>
|
<p className={styles.sectionAside}>The page adapts to primary or secondary</p>
|
||||||
</div>
|
</div>
|
||||||
<div className={styles.hiwGrid}>
|
<div className={styles.hiwGrid}>
|
||||||
{/* Card 1 — Performance */}
|
{/* Card 1 — Performance */}
|
||||||
@@ -123,7 +123,7 @@ export function HowItWorksSection() {
|
|||||||
<div className={styles.hiwCardBody}>
|
<div className={styles.hiwCardBody}>
|
||||||
<div className={styles.hiwStep}>Judgement</div>
|
<div className={styles.hiwStep}>Judgement</div>
|
||||||
<div className={styles.hiwTitle}>Ofsted at a glance</div>
|
<div className={styles.hiwTitle}>Ofsted at a glance</div>
|
||||||
<p className={styles.hiwDesc}>Since November 2025, Ofsted rates each area of school life on a five-point scale rather than one overall word. We show every area and the inspection date — and, for schools not yet reinspected, the older overall grade they still carry.</p>
|
<p className={styles.hiwDesc}>Since November 2025, Ofsted rates each area of school life on a five-point scale rather than one overall word. We show every area, the inspection date and, for schools not yet reinspected, the older overall grade they still carry.</p>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
@@ -143,7 +143,7 @@ export function HowItWorksSection() {
|
|||||||
<span className={styles.compareRowVal}>{b}</span>
|
<span className={styles.compareRowVal}>{b}</span>
|
||||||
</div>
|
</div>
|
||||||
))}
|
))}
|
||||||
<div className={styles.compareFoot}>+ compare up to 5 schools</div>
|
<div className={styles.compareFoot}>+ up to 5 primary & 5 secondary</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
<div className={styles.hiwCardBody}>
|
<div className={styles.hiwCardBody}>
|
||||||
@@ -152,7 +152,7 @@ export function HowItWorksSection() {
|
|||||||
{/* One verb for one feature. The site previously called this
|
{/* One verb for one feature. The site previously called this
|
||||||
"compare" in the nav, "shortlist" in the footer and "pin" here,
|
"compare" in the nav, "shortlist" in the footer and "pin" here,
|
||||||
which reads as three separate things it does not have. */}
|
which reads as three separate things it does not have. */}
|
||||||
<p className={styles.hiwDesc}>Compare up to five schools and every metric aligns in the same columns — works for primary and secondary alike.</p>
|
<p className={styles.hiwDesc}>Compare primary and secondary school performance side by side: KS2 SATs results for primary schools, GCSE Attainment 8 for secondary schools, and Ofsted ratings for both, lined up in one table so you can see where each school is stronger.</p>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
|
|||||||
Loaded 100 of 161 files, more files were not shown because too many files have changed in this diff.
Show more
Reference in new issue
Block a user