Compare commits
merge into: tudor/school_compare:feat/compare-chart-mobile-readability
tudor/school_compare:main
tudor/school_compare:perf/server-client-split
tudor/school_compare:feat/detail-header-details-reveal
tudor/school_compare:feat/detail-gias-fields-remove-unwired
tudor/school_compare:feat/info-popover-tooltip
tudor/school_compare:fix/compare-null-year-blanks-chart
tudor/school_compare:feat/allow-analytics-iframe-embed
tudor/school_compare:fix/detail-trend-chart-taller
tudor/school_compare:feat/umami-heatmap-recorder
tudor/school_compare:fix/sats-per-level-national
tudor/school_compare:fix/rankings-admissions-accuracy
tudor/school_compare:fix/homepage-education-accuracy
tudor/school_compare:fix/special-note-full-width
tudor/school_compare:fix/special-schools-not-failing
tudor/school_compare:fix/report-card-chip-alignment
tudor/school_compare:fix/detail-allthrough-admissions-phase
tudor/school_compare:fix/detail-all-through
tudor/school_compare:fix/detail-chart-truthfulness
tudor/school_compare:fix/detail-inclusion-admissions
tudor/school_compare:fix/detail-provenance-anchoring
tudor/school_compare:fix/detail-ofsted-correctness
tudor/school_compare:fix/list-map-report-card-signal
tudor/school_compare:fix/detail-report-card-render-date
tudor/school_compare:fix/promote-status-token
tudor/school_compare:fix/ofsted-link-text
tudor/school_compare:fix/mobile-cell-name-size
tudor/school_compare:fix/secondary-anchors-button-affordance
tudor/school_compare:fix/modal-keyboard-viewport
tudor/school_compare:fix/mobile-compare-polish
tudor/school_compare:fix/expert-signoff-shouldfixes
tudor/school_compare:fix/annual-dag-ks4-national-selector
tudor/school_compare:fix/expert-signoff-mustfixes
tudor/school_compare:fix/compare-final-review-mustfix
tudor/school_compare:fix/gias-blank-name-codes
tudor/school_compare:feature/ingest-independent-schools
tudor/school_compare:fix/compare-expert-fixes
tudor/school_compare:fix/schoolbar-sticky-offset
tudor/school_compare:fix/compare-mockup-drift
tudor/school_compare:fix/trends-chart-height
tudor/school_compare:fix/e2e-compare-samephase
tudor/school_compare:ci/frontend-checks-speedup
tudor/school_compare:perf/batch-supplementary
tudor/school_compare:fix/compare-refresh-and-fetch
tudor/school_compare:perf/compare-loading
tudor/school_compare:feat/compare-frontend-rebuild
tudor/school_compare:feat/compare-api-enrichment
tudor/school_compare:feat/compare-data-foundation
tudor/school_compare:chore/staged-prod-promotion
tudor/school_compare:fix/daily-dag-cache-invalidation
tudor/school_compare:fix/gias-legacy-fallback
tudor/school_compare:feat/gias-code-dictionaries
tudor/school_compare:fix/proposed-to-close-copy
tudor/school_compare:feat/proposed-to-close-schools
tudor/school_compare:feat/gias-sixth-form-flag
tudor/school_compare:fix/school-detail-nan-500
tudor/school_compare:feat/near-me-by-search
tudor/school_compare:fix/results-map-ios-fullscreen
tudor/school_compare:fix/mobile-sort-select-overflow
tudor/school_compare:feat/compare-chips-two-per-row
tudor/school_compare:fix/e2e-compare-chips-phase
tudor/school_compare:fix/runtime-api-proxy
tudor/school_compare:chore/remove-parent-view
tudor/school_compare:fix/compare-chart-refetch-resilience
tudor/school_compare:feat/compare-chart-mobile-readability
tudor/school_compare:fix/hero-map-ios-fullscreen
tudor/school_compare:fix/e2e-rankings-year-pick
tudor/school_compare:fix/rankings-year-validation
tudor/school_compare:feat/pr-comment-agent
tudor/school_compare:feat/school-detail-visualisations
tudor/school_compare:add-contact-form-footer
..
pull from: tudor/school_compare:fix/compare-chart-refetch-resilience
tudor/school_compare:main
tudor/school_compare:perf/server-client-split
tudor/school_compare:feat/detail-header-details-reveal
tudor/school_compare:feat/detail-gias-fields-remove-unwired
tudor/school_compare:feat/info-popover-tooltip
tudor/school_compare:fix/compare-null-year-blanks-chart
tudor/school_compare:feat/allow-analytics-iframe-embed
tudor/school_compare:fix/detail-trend-chart-taller
tudor/school_compare:feat/umami-heatmap-recorder
tudor/school_compare:fix/sats-per-level-national
tudor/school_compare:fix/rankings-admissions-accuracy
tudor/school_compare:fix/homepage-education-accuracy
tudor/school_compare:fix/special-note-full-width
tudor/school_compare:fix/special-schools-not-failing
tudor/school_compare:fix/report-card-chip-alignment
tudor/school_compare:fix/detail-allthrough-admissions-phase
tudor/school_compare:fix/detail-all-through
tudor/school_compare:fix/detail-chart-truthfulness
tudor/school_compare:fix/detail-inclusion-admissions
tudor/school_compare:fix/detail-provenance-anchoring
tudor/school_compare:fix/detail-ofsted-correctness
tudor/school_compare:fix/list-map-report-card-signal
tudor/school_compare:fix/detail-report-card-render-date
tudor/school_compare:fix/promote-status-token
tudor/school_compare:fix/ofsted-link-text
tudor/school_compare:fix/mobile-cell-name-size
tudor/school_compare:fix/secondary-anchors-button-affordance
tudor/school_compare:fix/modal-keyboard-viewport
tudor/school_compare:fix/mobile-compare-polish
tudor/school_compare:fix/expert-signoff-shouldfixes
tudor/school_compare:fix/annual-dag-ks4-national-selector
tudor/school_compare:fix/expert-signoff-mustfixes
tudor/school_compare:fix/compare-final-review-mustfix
tudor/school_compare:fix/gias-blank-name-codes
tudor/school_compare:feature/ingest-independent-schools
tudor/school_compare:fix/compare-expert-fixes
tudor/school_compare:fix/schoolbar-sticky-offset
tudor/school_compare:fix/compare-mockup-drift
tudor/school_compare:fix/trends-chart-height
tudor/school_compare:fix/e2e-compare-samephase
tudor/school_compare:ci/frontend-checks-speedup
tudor/school_compare:perf/batch-supplementary
tudor/school_compare:fix/compare-refresh-and-fetch
tudor/school_compare:perf/compare-loading
tudor/school_compare:feat/compare-frontend-rebuild
tudor/school_compare:feat/compare-api-enrichment
tudor/school_compare:feat/compare-data-foundation
tudor/school_compare:chore/staged-prod-promotion
tudor/school_compare:fix/daily-dag-cache-invalidation
tudor/school_compare:fix/gias-legacy-fallback
tudor/school_compare:feat/gias-code-dictionaries
tudor/school_compare:fix/proposed-to-close-copy
tudor/school_compare:feat/proposed-to-close-schools
tudor/school_compare:feat/gias-sixth-form-flag
tudor/school_compare:fix/school-detail-nan-500
tudor/school_compare:feat/near-me-by-search
tudor/school_compare:fix/results-map-ios-fullscreen
tudor/school_compare:fix/mobile-sort-select-overflow
tudor/school_compare:feat/compare-chips-two-per-row
tudor/school_compare:fix/e2e-compare-chips-phase
tudor/school_compare:fix/runtime-api-proxy
tudor/school_compare:chore/remove-parent-view
tudor/school_compare:fix/compare-chart-refetch-resilience
tudor/school_compare:feat/compare-chart-mobile-readability
tudor/school_compare:fix/hero-map-ios-fullscreen
tudor/school_compare:fix/e2e-rankings-year-pick
tudor/school_compare:fix/rankings-year-validation
tudor/school_compare:feat/pr-comment-agent
tudor/school_compare:feat/school-detail-visualisations
tudor/school_compare:add-contact-form-footer
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
9f8dba227c |
fix(compare): keep chart data when a client refetch fails
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m38s
PR Checks / Backend Smoke (pull_request) Successful in 5s
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
PR Checks / Build Frontend (no push) (pull_request) Successful in 47s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 9s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m9s
The compare view refetches /api/compare on the client after SSR; on any failure the catch nulled comparisonData, destroying the working SSR-provided chart. A transient error (or staging's broken external /api proxy) should not blank a comparison the user is already viewing — keep the existing data instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> |
||
|
|
18cd805c6c |
Merge pull request 'feat(compare): readable comparison chart on mobile' (#11) from feat/compare-chart-mobile-readability into main
Deploy (staging -> E2E gate -> production) / Build Backend (FastAPI) (push) Successful in 13s
Deploy (staging -> E2E gate -> production) / Build Frontend (Next.js) (push) Successful in 49s
Deploy (staging -> E2E gate -> production) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 12s
Deploy (staging -> E2E gate -> production) / Deploy to Staging (push) Successful in 1s
Deploy (staging -> E2E gate -> production) / E2E Journeys against Staging (push) Failing after 1m6s
Deploy (staging -> E2E gate -> production) / Promote to Production (push) Has been skipped
Reviewed-on: #11 |