docs: H4 rollout order and where stg_gias_ukprn is built (review)
PR Checks / Frontend Typecheck + Tests (pull_request) Waiting to run
PR Checks / Backend Smoke (pull_request) Waiting to run
PR Checks / Build Backend (no push) (pull_request) Waiting to run
PR Checks / Build Frontend (no push) (pull_request) Waiting to run
PR Checks / Build Pipeline (no push) (pull_request) Waiting to run
PR Checks / AI Code Review (Claude) (pull_request) Waiting to run
PR Checks / Frontend Typecheck + Tests (pull_request) Waiting to run
PR Checks / Backend Smoke (pull_request) Waiting to run
PR Checks / Build Backend (no push) (pull_request) Waiting to run
PR Checks / Build Frontend (no push) (pull_request) Waiting to run
PR Checks / Build Pipeline (no push) (pull_request) Waiting to run
PR Checks / AI Code Review (Claude) (pull_request) Waiting to run
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
32715af568
commit
4f342c50fd
1 file changed
+10
-3
+10
-3
@@ -234,9 +234,16 @@ E2E.
|
||||
not from a `ukprn` column on `stg_gias_establishments`. A `ref` to
|
||||
`stg_gias_establishments` from the Ofsted models would put them in the daily
|
||||
build's `stg_gias_establishments+` selection, where their Ofsted parents are
|
||||
not built (`pipeline/tests/test_dag_selectors.py`). The daily build selects
|
||||
`stg_gias_ukprn` by name; `stg_gias_establishments` gains only
|
||||
`inspectorate_name`.
|
||||
not built (`pipeline/tests/test_dag_selectors.py`). The monthly Ofsted build
|
||||
selects `stg_gias_ukprn+`; the daily build must not rebuild it, because
|
||||
rebuilding a view drops the views on it (CASCADE) and `dim_school` reads
|
||||
them. `stg_gias_establishments` gains only `inspectorate_name`.
|
||||
- **First rollout order (each environment, once).** The new models need
|
||||
`raw.gias_establishments."UKPRN"`, which only a daily run with PR 1 creates,
|
||||
and `dim_school`'s unit tests need `int_ofsted_listed`, which only a monthly
|
||||
run creates. So: run the daily DAG (its `dbt_build` fails once on
|
||||
`dim_school`'s unit tests — expected), then `school_data_monthly_ofsted`,
|
||||
then the daily DAG again. From then on both schedules run normally.
|
||||
- **A report card is recognised by `rc_inspection_date` as well as by its area
|
||||
labels** (`hasReportCard`), on the school page and in compare. An FE report
|
||||
card carries a safeguarding result and no school areas, so the label test
|
||||
|
||||
Reference in new issue
Block a user