TudorandClaude Opus 5
6fc7fce948
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m15s
PR Checks / Backend Smoke (pull_request) Successful in 9s
PR Checks / Build Backend (no push) (pull_request) Successful in 20s
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m21s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 12s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m39s
Both features ship dark. Neither is reachable in an environment where its flag is off, and every flag in this system starts off, so a deploy of this commit makes both disappear until someone turns them on deliberately. Two independent flags rather than one, which makes blog-on-about-off a reachable state. That state is the whole reason the change is larger than four notFound() calls: the blog leans on the About page for its author identity. The Person entity is anchored at /about#tudor, and that URL 404s while about_page is dark, so a post published in that state would claim an author resolving to nothing. Worse than having no named author. Both bylines fall back to unlinked text and the BlogPosting attributes to the publisher instead, so every combination of the two flags renders something correct. Gated: /about, /blog, /blog/[slug], the RSS feed, both footer links, and the matching content-sitemap entries. A sitemap must never advertise a URL that 404s. With both dark it emits a valid empty urlset rather than a 404, because robots.txt names it unconditionally. Not gated: /admin. Posts have to be writable before the blog is worth switching on, so flagging the panel would make the flag unflippable. getFlags takes a revalidate rather than always using the 300s constant. Reading a flag pins the calling route to the lowest revalidate among its fetches, and the footer links live in the root layout, so a naive gate there would have dropped every school and place page from a weekly cache to a 5-minute one. The layout passes 604800, the floor those routes already declare, and the build confirms all four SSG route families still prerender. The cost is one-way latency: pages follow a flip in minutes, footer links within a week. The e2e journeys follow the existing paired shape from the admission_distance flag: a lit journey and a dark one for each flag, reading state from whether /about and /blog respond rather than from /api/flags, which another journey asserts is not publicly reachable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXnXQKnPpZBBP61fBQiFkq
59 lines
2.3 KiB
TypeScript
59 lines
2.3 KiB
TypeScript
import { getFlags, FLAGS_REVALIDATE } from '@/lib/flags';
|
|
|
|
// jsdom provides no global fetch, so there is nothing for jest.spyOn to attach
|
|
// to — assign it and restore the original afterwards. This is the first test
|
|
// here to mock fetch; later ones should follow this shape.
|
|
const realFetch = global.fetch;
|
|
|
|
function mockFetch(impl: () => Promise<unknown>) {
|
|
global.fetch = jest.fn(impl) as unknown as typeof fetch;
|
|
}
|
|
|
|
describe('getFlags', () => {
|
|
afterEach(() => { global.fetch = realFetch; });
|
|
|
|
it('returns the flags the API reports', async () => {
|
|
mockFetch(async () => ({
|
|
ok: true,
|
|
json: async () => ({ admission_distance: true }),
|
|
}));
|
|
await expect(getFlags()).resolves.toEqual({ admission_distance: true });
|
|
});
|
|
|
|
it('returns no flags rather than throwing when the API is down', async () => {
|
|
// A page that cannot read flags must render everything dark, not 500.
|
|
// Fail-closed is the same direction as the backend's default.
|
|
mockFetch(async () => { throw new Error('ECONNREFUSED'); });
|
|
await expect(getFlags()).resolves.toEqual({});
|
|
});
|
|
|
|
it('returns no flags rather than throwing on a non-200', async () => {
|
|
mockFetch(async () => ({ ok: false, status: 503 }));
|
|
await expect(getFlags()).resolves.toEqual({});
|
|
});
|
|
|
|
/*
|
|
* Reading a flag pins the calling route's ISR floor: Next uses the LOWEST
|
|
* revalidate among a route's fetches for the whole route. That is why the
|
|
* revalidate is an argument rather than the constant.
|
|
*
|
|
* Every SEO route here declares `revalidate = 604800`. A gate that read
|
|
* flags at the 300s default would drop the whole school and place corpus
|
|
* from a weekly cache to a 5-minute one, which is a large origin-load
|
|
* regression to pay for a feature flag.
|
|
*/
|
|
it('reads at the 300s floor by default', async () => {
|
|
mockFetch(async () => ({ ok: true, json: async () => ({}) }));
|
|
await getFlags();
|
|
expect((global.fetch as jest.Mock).mock.calls[0][1])
|
|
.toEqual({ next: { revalidate: FLAGS_REVALIDATE } });
|
|
});
|
|
|
|
it('lets a caller pass its own route floor instead', async () => {
|
|
mockFetch(async () => ({ ok: true, json: async () => ({}) }));
|
|
await getFlags(604800);
|
|
expect((global.fetch as jest.Mock).mock.calls[0][1])
|
|
.toEqual({ next: { revalidate: 604800 } });
|
|
});
|
|
});
|