PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m5s
PR Checks / Backend Smoke (pull_request) Successful in 8s
PR Checks / Build Backend (no push) (pull_request) Successful in 13s
PR Checks / Build Frontend (no push) (pull_request) Successful in 45s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 11s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m59s
The admissions card measured 1503px on a live school page — half the height of every section put together, and nearly three times the next largest — with its default view rendering as four tiles adrift in about 1080px of blank card. The cause was a layout trick meeting content it was never sized for. The admissions views are stacked in one grid cell so switching them never shifts layout, and the hidden ones keep their box: only visibility is dropped. That works while the views are comparable. The distance view added in #102 carries a chart, a table and a map, came to 1402px against the tile grid's 316px, and pinned every other view to its height — including the one that renders by default, which nobody had clicked. Rather than only unpinning it, the detail moves out. Every other topic on the page is a section with a nav entry, and "how close did we need to live, and would we have got in?" is a topic, not a variant reading of the intake figures. The headline number stays on the Admissions tile where the intake story is; the record behind it now lives in a Distance section directly below. admissions 1503px -> 554px distance new -> 743px (median section on the page is ~528px) Three further changes, each of which also makes the content better rather than only shorter: * The map renders on request. Before a postcode is entered it is a circle drawn round a school, and it costs a Leaflet bundle and 240px to say so; a successful check opens it automatically, which is the point at which it starts answering something. Map height 320px -> 240px. * The chart appears only at the four published years that let the summary state a direction. Below that we already refuse to call the series a trend, and a line through three points asserts one regardless of what the sentence beneath it admits. The table carries those years anyway, with the reasons a line cannot show. * Three caveat paragraphs become one. They said walking-route twice and made the same point about priorities in two voices. It now sits in CutoffDistanceDetail rather than inside the check, so it still renders for a school with coordinates missing, where there is a table but no map and no check. The new e2e guard asserts no section exceeds 2.5x the median section height. Measuring the card's internals cannot catch this: the tile grid is flex: 1, so it absorbs the stretch and every box still looks full. The first version of this test targeted an arbitrary primary, passed against the live bug, and proved nothing; pointed at a school that actually holds cut-off history it fails on staging with "#admissions is 1459px against a 526px median". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WDvkyqqHABm4bmth2kjAxE
134 lines
4.6 KiB
TypeScript
134 lines
4.6 KiB
TypeScript
/**
|
|
* SecondarySchoolSections — the section sequence for secondary detail pages.
|
|
* Server component.
|
|
*
|
|
* Wrapped in `.secondaryScope`, which activates the secondary-only style
|
|
* overrides in schoolSections.module.css. Those rules target class names the
|
|
* primary page also uses (.card, .sectionTitle, .metricCard …), so scoping is
|
|
* what keeps them from restyling primary pages.
|
|
*
|
|
* The render conditions here MUST match buildSecondaryNavItems in
|
|
* lib/schoolSections, or the sticky nav will link to sections that do not exist.
|
|
*/
|
|
|
|
import type {
|
|
School, SchoolResult, AbsenceData, OfstedInspection, SchoolCensus,
|
|
SchoolAdmissions, SchoolAdmissionDistance, SchoolDeprivation, SchoolFinance, NationalAverages,
|
|
} from '@/lib/types';
|
|
import { ofstedLegacyAreas } from '@/lib/utils';
|
|
import type { SecondaryFlags } from '@/lib/schoolSections';
|
|
import { OfstedSection } from './OfstedSection';
|
|
import { GcseSection } from './GcseSection';
|
|
import { SecondaryAdmissionsSection } from './SecondaryAdmissionsSection';
|
|
import { DistanceSection } from './DistanceSection';
|
|
import { SecondaryHistorySection } from './SecondaryHistorySection';
|
|
import { WellbeingSection } from './WellbeingSection';
|
|
import { FinancesSection } from './FinancesSection';
|
|
import styles from './schoolSections.module.css';
|
|
|
|
export interface SecondarySchoolSectionsProps {
|
|
schoolInfo: School;
|
|
yearlyData: SchoolResult[];
|
|
absenceData: AbsenceData | null;
|
|
ofsted: OfstedInspection | null;
|
|
census: SchoolCensus | null;
|
|
admissions: SchoolAdmissions | null;
|
|
/** Needed to tell a year with no published cut-off apart from a year the
|
|
* school simply was not oversubscribed. */
|
|
admissionsHistory: SchoolAdmissions[];
|
|
admissionDistance: SchoolAdmissionDistance | null;
|
|
admissionDistanceHistory: SchoolAdmissionDistance[];
|
|
deprivation: SchoolDeprivation | null;
|
|
finance: SchoolFinance | null;
|
|
nationalAvg: NationalAverages | null;
|
|
flags: SecondaryFlags;
|
|
}
|
|
|
|
export function SecondarySchoolSections({
|
|
schoolInfo, yearlyData, ofsted, census,
|
|
admissions, admissionsHistory, admissionDistance, admissionDistanceHistory,
|
|
deprivation, finance, nationalAvg, flags,
|
|
}: SecondarySchoolSectionsProps) {
|
|
const secondaryAvg = nationalAvg?.secondary ?? {};
|
|
|
|
const isReportCard = !!(ofsted?.report_card && Object.keys(ofsted.report_card).length > 0);
|
|
const ofstedInspectedDate = isReportCard
|
|
? ofsted?.rc_inspection_date ?? null
|
|
: ofsted?.inspection_date ?? null;
|
|
const oeifAreas = ofsted ? ofstedLegacyAreas(ofsted) : [];
|
|
const oeifAllSameGrade =
|
|
!!ofsted &&
|
|
!isReportCard &&
|
|
oeifAreas.length >= 3 &&
|
|
oeifAreas.every((a) => a.value === ofsted.overall_effectiveness);
|
|
|
|
return (
|
|
<div className={styles.secondaryScope}>
|
|
{ofsted && (
|
|
<OfstedSection
|
|
ofsted={ofsted}
|
|
urn={schoolInfo.urn}
|
|
isReportCard={isReportCard}
|
|
ofstedInspectedDate={ofstedInspectedDate}
|
|
oeifAllSameGrade={oeifAllSameGrade}
|
|
oeifAreas={oeifAreas}
|
|
variant="secondary"
|
|
/>
|
|
)}
|
|
|
|
{flags.hasResults && flags.latestResults && (
|
|
<GcseSection
|
|
latestResults={flags.latestResults}
|
|
schoolInfo={schoolInfo}
|
|
secondaryAvg={secondaryAvg}
|
|
p8Suspended={flags.p8Suspended}
|
|
suppressComparison={flags.suppressComparison}
|
|
/>
|
|
)}
|
|
|
|
{/* See PrimarySchoolSections: distance and EES admissions are independent
|
|
sources, so either one warrants the section. */}
|
|
{(admissions || admissionDistance) && (
|
|
<SecondaryAdmissionsSection
|
|
admissions={admissions}
|
|
admissionDistance={admissionDistance}
|
|
admissionsHistory={admissionsHistory}
|
|
schoolInfo={schoolInfo}
|
|
hasSixthForm={flags.hasSixthForm}
|
|
/>
|
|
)}
|
|
|
|
{/* See PrimarySchoolSections — same placement, same reason. */}
|
|
<DistanceSection
|
|
admissionDistanceHistory={admissionDistanceHistory}
|
|
admissionsHistory={admissionsHistory}
|
|
schoolInfo={schoolInfo}
|
|
/>
|
|
|
|
{yearlyData.length > 1 && (
|
|
<SecondaryHistorySection
|
|
yearlyData={yearlyData}
|
|
schoolInfo={schoolInfo}
|
|
nationalAvg={nationalAvg}
|
|
secondaryAvg={secondaryAvg}
|
|
suppressComparison={flags.suppressComparison}
|
|
/>
|
|
)}
|
|
|
|
{flags.hasWellbeing && (
|
|
<WellbeingSection
|
|
latestResults={flags.latestResults}
|
|
census={census}
|
|
schoolInfo={schoolInfo}
|
|
deprivation={deprivation}
|
|
hasDeprivation={flags.hasDeprivation}
|
|
/>
|
|
)}
|
|
|
|
{flags.hasFinance && finance && (
|
|
<FinancesSection finance={finance} showPremises />
|
|
)}
|
|
</div>
|
|
);
|
|
}
|