TudorandClaude Opus 5
c981d89137
Every generateStaticParams is gated behind PRERENDER_PLACES and wrapped in the same try/catch the school route uses. The plan claimed authority pages were 'few enough to always prebuild' — but few enough still means the API must be reachable at build time, and in CI it is not: the build failed with ECONNREFUSED rather than degrading to ISR. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mWQnpye9F299NVRCCSRvj
92 lines
3.5 KiB
TypeScript
92 lines
3.5 KiB
TypeScript
/**
|
|
* Town and locality pages.
|
|
*
|
|
* A place below the five-school threshold is not in the registry, so
|
|
* fetchPlace returns null and the request 404s rather than rendering a page
|
|
* with nothing to say.
|
|
*/
|
|
import { notFound, redirect } from 'next/navigation';
|
|
import type { Metadata } from 'next';
|
|
import { fetchPlace, fetchPlaces, authoritySlug } from '@/lib/places';
|
|
import { fetchNationalAverages } from '@/lib/api';
|
|
import { PlaceView } from '@/components/places/PlaceView';
|
|
import { absoluteUrl } from '@/lib/site';
|
|
|
|
interface Props { params: Promise<{ place: string }> }
|
|
|
|
// ISR: place aggregates change only when the pipeline runs.
|
|
export const revalidate = 604800;
|
|
export const dynamicParams = true;
|
|
|
|
export async function generateStaticParams(): Promise<Array<{ place: string }>> {
|
|
// Off by default: ~2,000 place routes cannot be built in CI on every deploy.
|
|
// Matches the PRERENDER_SCHOOLS gate on the school route.
|
|
if (process.env.PRERENDER_PLACES !== '1') return [];
|
|
try {
|
|
return (await fetchPlaces())
|
|
.filter((p) => p.kind === 'town' || p.kind === 'locality')
|
|
.map((p) => ({ place: p.slug }));
|
|
} catch (error) {
|
|
console.warn('generateStaticParams: API unreachable, falling back to on-demand ISR.', error);
|
|
return [];
|
|
}
|
|
}
|
|
|
|
async function resolve(slug: string) {
|
|
return (await fetchPlace('town', slug)) ?? (await fetchPlace('locality', slug));
|
|
}
|
|
|
|
/** Other towns in the same authority — the cheapest honest definition of
|
|
* "nearby", and enough to stop each place page being a dead end. */
|
|
async function neighboursOf(detail: { place: { slug: string; parent_authority: string | null } }) {
|
|
if (!detail.place.parent_authority) return [];
|
|
const all = await fetchPlaces();
|
|
return all
|
|
.filter((p) => p.kind === 'town' && p.slug !== detail.place.slug)
|
|
.slice(0, 12);
|
|
}
|
|
|
|
export async function generateMetadata({ params }: Props): Promise<Metadata> {
|
|
const { place: slug } = await params;
|
|
const detail = await resolve(slug);
|
|
if (!detail) return { title: 'Place Not Found' };
|
|
|
|
const { name, count } = detail.place;
|
|
return {
|
|
title: `Schools in ${name} — Compare ${count} Schools | schoolcompare`,
|
|
description:
|
|
`Every school in ${name} ranked by SATs and GCSE results, with Ofsted grades, `
|
|
+ `the local average against England, and how close you had to live to get a place.`,
|
|
alternates: { canonical: absoluteUrl(`/schools/${slug}`) },
|
|
};
|
|
}
|
|
|
|
export default async function PlacePage({ params }: Props) {
|
|
const { place: slug } = await params;
|
|
const detail = await resolve(slug);
|
|
if (!detail) notFound();
|
|
|
|
// Global constraint: no page without a local average. A place with too few
|
|
// schools carrying results has nothing to say that a list does not, so it
|
|
// defers to its authority rather than publishing a thin page.
|
|
if (detail.averages.rwm_expected_pct == null
|
|
&& detail.averages.attainment_8_score == null) {
|
|
if (detail.place.parent_authority) {
|
|
redirect(`/schools/authority/${authoritySlug(detail.place.parent_authority)}`);
|
|
}
|
|
notFound();
|
|
}
|
|
|
|
const national = await fetchNationalAverages().catch(() => null);
|
|
// NationalAverages is nested by phase — { primary: {...}, secondary: {...} }
|
|
// — not flat. Reading it flat silently yields undefined and the page renders
|
|
// with no comparison, which is the one thing that makes it not a list.
|
|
return (
|
|
<PlaceView
|
|
detail={detail}
|
|
englandAverage={national?.primary?.rwm_expected_pct ?? null}
|
|
neighbours={await neighboursOf(detail)}
|
|
/>
|
|
);
|
|
}
|