TudorandClaude Opus 5
6fc7fce948
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m15s
PR Checks / Backend Smoke (pull_request) Successful in 9s
PR Checks / Build Backend (no push) (pull_request) Successful in 20s
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m21s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 12s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m39s
Both features ship dark. Neither is reachable in an environment where its flag is off, and every flag in this system starts off, so a deploy of this commit makes both disappear until someone turns them on deliberately. Two independent flags rather than one, which makes blog-on-about-off a reachable state. That state is the whole reason the change is larger than four notFound() calls: the blog leans on the About page for its author identity. The Person entity is anchored at /about#tudor, and that URL 404s while about_page is dark, so a post published in that state would claim an author resolving to nothing. Worse than having no named author. Both bylines fall back to unlinked text and the BlogPosting attributes to the publisher instead, so every combination of the two flags renders something correct. Gated: /about, /blog, /blog/[slug], the RSS feed, both footer links, and the matching content-sitemap entries. A sitemap must never advertise a URL that 404s. With both dark it emits a valid empty urlset rather than a 404, because robots.txt names it unconditionally. Not gated: /admin. Posts have to be writable before the blog is worth switching on, so flagging the panel would make the flag unflippable. getFlags takes a revalidate rather than always using the 300s constant. Reading a flag pins the calling route to the lowest revalidate among its fetches, and the footer links live in the root layout, so a naive gate there would have dropped every school and place page from a weekly cache to a 5-minute one. The layout passes 604800, the floor those routes already declare, and the build confirms all four SSG route families still prerender. The cost is one-way latency: pages follow a flip in minutes, footer links within a week. The e2e journeys follow the existing paired shape from the admission_distance flag: a lit journey and a dark one for each flag, reading state from whether /about and /blog respond rather than from /api/flags, which another journey asserts is not publicly reachable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXnXQKnPpZBBP61fBQiFkq
48 lines
2.0 KiB
TypeScript
48 lines
2.0 KiB
TypeScript
/**
|
|
* The footer is the only navigational route to /about and /blog, so it is
|
|
* where a dark flag would otherwise leave a link into a 404.
|
|
*
|
|
* Both props default to false. A caller that forgets to pass them hides the
|
|
* links, which is the direction that cannot break a page — the same reasoning
|
|
* as backend/flags.py's "every flag defaults to False".
|
|
*/
|
|
import { render, screen } from '@testing-library/react';
|
|
import { Footer } from '@/components/Footer';
|
|
|
|
describe('footer feature links', () => {
|
|
it('links to both when both flags are on', () => {
|
|
render(<Footer aboutEnabled blogEnabled />);
|
|
expect(screen.getByRole('link', { name: /who's behind this/i }))
|
|
.toHaveAttribute('href', '/about');
|
|
expect(screen.getByRole('link', { name: /^blog$/i }))
|
|
.toHaveAttribute('href', '/blog');
|
|
});
|
|
|
|
it('omits the about link when that flag is dark', () => {
|
|
render(<Footer blogEnabled />);
|
|
expect(screen.queryByRole('link', { name: /who's behind this/i })).toBeNull();
|
|
expect(screen.getByRole('link', { name: /^blog$/i })).toBeInTheDocument();
|
|
});
|
|
|
|
it('omits the blog link when that flag is dark', () => {
|
|
render(<Footer aboutEnabled />);
|
|
expect(screen.queryByRole('link', { name: /^blog$/i })).toBeNull();
|
|
expect(screen.getByRole('link', { name: /who's behind this/i }))
|
|
.toBeInTheDocument();
|
|
});
|
|
|
|
it('drops the whole section when both are dark, not an empty heading', () => {
|
|
// Shipping dark means the footer renders as it did before the feature
|
|
// existed, not as a section with its contents removed.
|
|
render(<Footer />);
|
|
expect(screen.queryByRole('heading', { name: /^about$/i })).toBeNull();
|
|
expect(screen.queryByRole('link', { name: /who's behind this/i })).toBeNull();
|
|
expect(screen.queryByRole('link', { name: /^blog$/i })).toBeNull();
|
|
});
|
|
|
|
it('defaults to dark when a caller passes nothing', () => {
|
|
render(<Footer />);
|
|
expect(screen.queryByRole('link', { name: /who's behind this/i })).toBeNull();
|
|
});
|
|
});
|