PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 10m0s
PR Checks / Backend Smoke (pull_request) Successful in 48s
PR Checks / Build Backend (no push) (pull_request) Successful in 17s
PR Checks / Build Frontend (no push) (pull_request) Successful in 41s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 24s
- pr-checks.yml: PR gate — frontend typecheck+jest, backend import smoke, image builds (no push), Claude AI review posted as PR comment (severe findings block merge) - deploy.yml (replaces build-and-push.yml): merge to main builds+pushes images tagged sha-<sha>/staging, deploys the staging Portainer stack via webhook, runs Playwright E2E journeys against staging, then retags the verified images :prod (previous kept as :prod-previous) and deploys prod - docker-compose.portainer.staging.yml: second Portainer stack — :staging images, sc_staging_* names, own macvlan IPs, Airflow on 8081; data bootstrapped from source via the staging Airflow DAGs - prod compose now pins :prod instead of :latest (only the promotion step moves it; :latest is no longer published) - e2e/: 6 Playwright journeys (search, postcode, detail, compare, rankings) driven by BASE_URL — the promotion gate - scripts/ci/ai_review.py: Claude review with structured JSON findings - docs/DEPLOY.md: full SDLC doc incl. one-time setup checklist and rollback - replaced removed 'next lint' with tsc typecheck; fixed stale jest tests (slug URLs, N/A formatting, stable trend, fake-timer setup) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL
162 lines
5.2 KiB
TypeScript
162 lines
5.2 KiB
TypeScript
/**
|
|
* Utility Functions Tests
|
|
*/
|
|
|
|
import {
|
|
formatPercentage,
|
|
formatProgress,
|
|
calculateTrend,
|
|
isValidPostcode,
|
|
debounce,
|
|
buildOfstedListBadge,
|
|
} from '@/lib/utils';
|
|
|
|
describe('formatPercentage', () => {
|
|
it('formats percentages correctly', () => {
|
|
expect(formatPercentage(75.5)).toBe('75.5%');
|
|
expect(formatPercentage(100)).toBe('100.0%');
|
|
expect(formatPercentage(0)).toBe('0.0%');
|
|
});
|
|
|
|
it('handles null values', () => {
|
|
expect(formatPercentage(null)).toBe('N/A');
|
|
});
|
|
});
|
|
|
|
describe('formatProgress', () => {
|
|
it('formats progress scores correctly', () => {
|
|
expect(formatProgress(2.5)).toBe('+2.5');
|
|
expect(formatProgress(-1.3)).toBe('-1.3');
|
|
expect(formatProgress(0)).toBe('0.0');
|
|
});
|
|
|
|
it('handles null values', () => {
|
|
expect(formatProgress(null)).toBe('N/A');
|
|
});
|
|
});
|
|
|
|
describe('calculateTrend', () => {
|
|
it('calculates upward trend', () => {
|
|
expect(calculateTrend(75, 70)).toBe('up');
|
|
});
|
|
|
|
it('calculates downward trend', () => {
|
|
expect(calculateTrend(70, 75)).toBe('down');
|
|
});
|
|
|
|
it('calculates stable trend', () => {
|
|
expect(calculateTrend(75, 75)).toBe('stable');
|
|
});
|
|
|
|
it('handles null previous value', () => {
|
|
expect(calculateTrend(75, null)).toBe('stable');
|
|
});
|
|
|
|
it('handles null current value', () => {
|
|
expect(calculateTrend(null, 75)).toBe('stable');
|
|
});
|
|
});
|
|
|
|
describe('isValidPostcode', () => {
|
|
it('validates correct UK postcodes', () => {
|
|
expect(isValidPostcode('SW1A 1AA')).toBe(true);
|
|
expect(isValidPostcode('M1 1AE')).toBe(true);
|
|
expect(isValidPostcode('B33 8TH')).toBe(true);
|
|
});
|
|
|
|
it('rejects invalid postcodes', () => {
|
|
expect(isValidPostcode('INVALID')).toBe(false);
|
|
expect(isValidPostcode('12345')).toBe(false);
|
|
expect(isValidPostcode('')).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('debounce', () => {
|
|
beforeEach(() => {
|
|
jest.useFakeTimers();
|
|
});
|
|
|
|
afterEach(() => {
|
|
jest.useRealTimers();
|
|
});
|
|
|
|
it('delays function execution', () => {
|
|
const mockFn = jest.fn();
|
|
const debouncedFn = debounce(mockFn, 300);
|
|
|
|
debouncedFn('test');
|
|
expect(mockFn).not.toHaveBeenCalled();
|
|
|
|
jest.advanceTimersByTime(300);
|
|
expect(mockFn).toHaveBeenCalledWith('test');
|
|
expect(mockFn).toHaveBeenCalledTimes(1);
|
|
});
|
|
|
|
it('cancels previous calls', () => {
|
|
const mockFn = jest.fn();
|
|
const debouncedFn = debounce(mockFn, 300);
|
|
|
|
debouncedFn('first');
|
|
jest.advanceTimersByTime(150);
|
|
debouncedFn('second');
|
|
jest.advanceTimersByTime(150);
|
|
debouncedFn('third');
|
|
jest.advanceTimersByTime(300);
|
|
|
|
expect(mockFn).toHaveBeenCalledWith('third');
|
|
expect(mockFn).toHaveBeenCalledTimes(1);
|
|
});
|
|
});
|
|
|
|
describe('buildOfstedListBadge', () => {
|
|
it('returns grade word + year for OEIF Outstanding', () => {
|
|
const badge = buildOfstedListBadge({ ofsted_grade: 1, ofsted_date: '2023-11-15', ofsted_framework: 'OEIF' });
|
|
expect(badge.label).toBe('Outstanding · 2023');
|
|
expect(badge.cssClass).toBe('ofsted1');
|
|
});
|
|
|
|
it('returns grade word for each OEIF grade', () => {
|
|
expect(buildOfstedListBadge({ ofsted_grade: 2, ofsted_date: '2022-05-01' }).label).toBe('Good · 2022');
|
|
expect(buildOfstedListBadge({ ofsted_grade: 3, ofsted_date: '2021-01-01' }).label).toBe('Req. Improvement · 2021');
|
|
expect(buildOfstedListBadge({ ofsted_grade: 4, ofsted_date: '2020-03-01' }).label).toBe('Inadequate · 2020');
|
|
});
|
|
|
|
it('returns grade word without year when date is missing', () => {
|
|
const badge = buildOfstedListBadge({ ofsted_grade: 2, ofsted_date: null });
|
|
expect(badge.label).toBe('Good');
|
|
expect(badge.cssClass).toBe('ofsted2');
|
|
});
|
|
|
|
it('returns Report Card badge when framework is ReportCard', () => {
|
|
const badge = buildOfstedListBadge({ ofsted_grade: null, ofsted_date: '2025-11-01', ofsted_framework: 'ReportCard' });
|
|
expect(badge.label).toBe('Report Card · 2025');
|
|
expect(badge.cssClass).toBe('ofstedRc');
|
|
});
|
|
|
|
it('returns an "Inspected" badge for an OEIF inspection with no overall grade (post-Sept-2024)', () => {
|
|
// Inspected after Sept 2024: inspection on record (date + framework) but
|
|
// Ofsted no longer issues an overall grade. Must NOT read as "Not yet inspected".
|
|
const badge = buildOfstedListBadge({ ofsted_grade: null, ofsted_date: '2024-11-01', ofsted_framework: 'OEIF' });
|
|
expect(badge.label).toBe('Inspected · 2024');
|
|
expect(badge.cssClass).toBe('ofstedInspected');
|
|
});
|
|
|
|
it('returns an "Inspected" badge without a year when the grade is missing and date is absent but a record exists', () => {
|
|
const badge = buildOfstedListBadge({ ofsted_grade: null, ofsted_date: null, ofsted_framework: 'OEIF' });
|
|
expect(badge.label).toBe('Inspected');
|
|
expect(badge.cssClass).toBe('ofstedInspected');
|
|
});
|
|
|
|
it('returns pending badge when no grade and no inspection on record', () => {
|
|
const badge = buildOfstedListBadge({ ofsted_grade: null, ofsted_date: null, ofsted_framework: null });
|
|
expect(badge.label).toBe('Not yet inspected');
|
|
expect(badge.cssClass).toBe('ofstedPending');
|
|
});
|
|
|
|
it('returns pending badge when all fields are undefined', () => {
|
|
const badge = buildOfstedListBadge({});
|
|
expect(badge.label).toBe('Not yet inspected');
|
|
expect(badge.cssClass).toBe('ofstedPending');
|
|
});
|
|
});
|