PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m46s
PR Checks / Backend Smoke (pull_request) Successful in 7s
PR Checks / Build Backend (no push) (pull_request) Successful in 18s
PR Checks / Build Frontend (no push) (pull_request) Successful in 47s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 36s
PR Checks / AI Code Review (Claude) (pull_request) Failing after 5m4s
- Metric changes no longer refire /api/compare (the data is already client-side; the picker is presentational) — the fetch effect depends only on the URN set, with URL sync split into its own effect. - The initial client fetch is skipped when the SSR payload already covers the selected schools; national averages + benchmarks now arrive via SSR props so nothing is lost by skipping. - page.tsx fetches comparison and metrics in parallel. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
72 lines
2.2 KiB
TypeScript
72 lines
2.2 KiB
TypeScript
/**
|
|
* Compare Page (SSR)
|
|
* Side-by-side comparison of schools with metrics
|
|
*/
|
|
|
|
import { fetchComparison, fetchMetrics } from '@/lib/api';
|
|
import { ComparisonView } from '@/components/ComparisonView';
|
|
import type { Metadata } from 'next';
|
|
|
|
interface ComparePageProps {
|
|
searchParams: Promise<{
|
|
urns?: string;
|
|
metric?: string;
|
|
}>;
|
|
}
|
|
|
|
export const metadata: Metadata = {
|
|
title: 'Compare Schools',
|
|
description:
|
|
'Compare schools in England side by side — Ofsted inspections, KS2 and GCSE results against the England average, admissions odds and school community.',
|
|
keywords:
|
|
'school comparison, compare schools, Ofsted comparison, school admissions, KS2 comparison, primary school performance',
|
|
};
|
|
|
|
// Dynamic via searchParams; remove force-dynamic so internal data fetches
|
|
// can still use Next.js's per-call revalidate cache.
|
|
|
|
export default async function ComparePage({ searchParams }: ComparePageProps) {
|
|
const { urns: urnsParam, metric: metricParam } = await searchParams;
|
|
|
|
const urns = urnsParam?.split(',').map(Number).filter(Boolean) || [];
|
|
const selectedMetric = metricParam || 'rwm_expected_pct';
|
|
|
|
try {
|
|
// Fetch comparison + metrics in parallel — they are independent.
|
|
const [comparisonResponse, metricsResponse] = await Promise.all([
|
|
urns.length > 0
|
|
? fetchComparison(urnsParam!).catch((error) => {
|
|
console.error('Failed to fetch comparison:', error);
|
|
return null;
|
|
})
|
|
: Promise.resolve(null),
|
|
fetchMetrics(),
|
|
]);
|
|
|
|
const metricsArray = metricsResponse?.metrics || [];
|
|
|
|
return (
|
|
<ComparisonView
|
|
initialData={comparisonResponse?.comparison ?? null}
|
|
initialNationalAverages={comparisonResponse?.national_averages}
|
|
initialBenchmarks={comparisonResponse?.benchmarks}
|
|
initialUrns={urns}
|
|
metrics={metricsArray}
|
|
selectedMetric={selectedMetric}
|
|
/>
|
|
);
|
|
} catch (error) {
|
|
console.error('Error fetching data for compare page:', error);
|
|
|
|
// Return error state with empty metrics
|
|
return (
|
|
<ComparisonView
|
|
initialData={null}
|
|
initialUrns={urns}
|
|
metrics={[]}
|
|
selectedMetric={selectedMetric}
|
|
/>
|
|
);
|
|
}
|
|
}
|