TudorandClaude Opus 4.8
0b36eace9d
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m2s
PR Checks / Backend Smoke (pull_request) Successful in 7s
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
PR Checks / Build Frontend (no push) (pull_request) Successful in 46s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 12s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m38s
Three review points on the special-schools change: 1. Copy accuracy — the context note said "Its pupils have special educational needs" for every isSpecialSchool() match, but the helper also matches pupil referral units and alternative provision, whose pupils are educated outside a mainstream setting (e.g. after exclusion) and are not necessarily SEND. Extracted a shared <SpecialSchoolNote> with type-aware copy: SEND wording only for genuine special schools; PRUs/AP get their own accurate wording. 2. Same-school trend was conflated with the England comparison — SchoolRow's year-over-year trend arrow (and the school's own figure) were gated on the same flag that drops the vs-England delta, hiding a still-meaningful trend for special schools with real data. Split the two: the school's OWN RWM figure + trend show whenever there's a real value (special schools included; only a placeholder all-zero row is hidden); only the vs-England delta is additionally dropped for special/PRU/AP. Mirrored in SecondarySchoolRow (own Attainment 8 shown; only the vs-LA delta dropped). 3. De-duplicated the .specialNote CSS (was copy-pasted between the two detail view module files) into SpecialSchoolNote.module.css, owned by the shared component so it can't drift. New SpecialSchoolNote unit tests assert SEND wording for special schools and NOT for PRUs/AP. tsc clean; 112/112 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
34 lines
1.6 KiB
TypeScript
34 lines
1.6 KiB
TypeScript
/**
|
|
* SpecialSchoolNote Component Tests
|
|
*/
|
|
|
|
import '@testing-library/jest-dom';
|
|
import { render, screen } from '@testing-library/react';
|
|
import { SpecialSchoolNote } from '@/components/SpecialSchoolNote';
|
|
|
|
describe('SpecialSchoolNote', () => {
|
|
it('renders nothing for a mainstream school', () => {
|
|
const { container } = render(<SpecialSchoolNote school={{ school_type: 'Academy converter' }} />);
|
|
expect(container).toBeEmptyDOMElement();
|
|
});
|
|
|
|
it('describes a special school as teaching pupils with SEND', () => {
|
|
render(<SpecialSchoolNote school={{ school_type: 'Community special school' }} />);
|
|
expect(screen.getByText(/This is a special school/i)).toBeInTheDocument();
|
|
expect(screen.getByText(/special educational needs/i)).toBeInTheDocument();
|
|
});
|
|
|
|
it('does NOT call PRU pupils SEND — they are educated outside a mainstream school', () => {
|
|
render(<SpecialSchoolNote school={{ school_type: 'Pupil referral unit' }} />);
|
|
expect(screen.getByText(/This is a pupil referral unit/i)).toBeInTheDocument();
|
|
expect(screen.getByText(/educated outside a mainstream school/i)).toBeInTheDocument();
|
|
expect(screen.queryByText(/special educational needs/i)).not.toBeInTheDocument();
|
|
});
|
|
|
|
it('does NOT call alternative-provision pupils SEND', () => {
|
|
render(<SpecialSchoolNote school={{ school_type: 'Academy alternative provision converter' }} />);
|
|
expect(screen.getByText(/This is an alternative provision setting/i)).toBeInTheDocument();
|
|
expect(screen.queryByText(/special educational needs/i)).not.toBeInTheDocument();
|
|
});
|
|
});
|