TudorandClaude Opus 5
6fc7fce948
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m15s
PR Checks / Backend Smoke (pull_request) Successful in 9s
PR Checks / Build Backend (no push) (pull_request) Successful in 20s
PR Checks / Build Frontend (no push) (pull_request) Successful in 1m21s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 12s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 1m39s
Both features ship dark. Neither is reachable in an environment where its flag is off, and every flag in this system starts off, so a deploy of this commit makes both disappear until someone turns them on deliberately. Two independent flags rather than one, which makes blog-on-about-off a reachable state. That state is the whole reason the change is larger than four notFound() calls: the blog leans on the About page for its author identity. The Person entity is anchored at /about#tudor, and that URL 404s while about_page is dark, so a post published in that state would claim an author resolving to nothing. Worse than having no named author. Both bylines fall back to unlinked text and the BlogPosting attributes to the publisher instead, so every combination of the two flags renders something correct. Gated: /about, /blog, /blog/[slug], the RSS feed, both footer links, and the matching content-sitemap entries. A sitemap must never advertise a URL that 404s. With both dark it emits a valid empty urlset rather than a 404, because robots.txt names it unconditionally. Not gated: /admin. Posts have to be writable before the blog is worth switching on, so flagging the panel would make the flag unflippable. getFlags takes a revalidate rather than always using the 300s constant. Reading a flag pins the calling route to the lowest revalidate among its fetches, and the footer links live in the root layout, so a naive gate there would have dropped every school and place page from a weekly cache to a 5-minute one. The layout passes 604800, the floor those routes already declare, and the build confirms all four SSG route families still prerender. The cost is one-way latency: pages follow a flip in minutes, footer links within a week. The e2e journeys follow the existing paired shape from the admission_distance flag: a lit journey and a dark one for each flag, reading state from whether /about and /blog respond rather than from /api/flags, which another journey asserts is not publicly reachable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXnXQKnPpZBBP61fBQiFkq
67 lines
2.7 KiB
TypeScript
67 lines
2.7 KiB
TypeScript
/**
|
|
* The blog index imports getCachedPayload, which pulls in Payload — ESM-only,
|
|
* and next/jest will not transform node_modules. Mocking that one module keeps
|
|
* the page's metadata testable without loading the CMS; the mock is never
|
|
* called, because `metadata` is a static export evaluated at import time.
|
|
*/
|
|
jest.mock('@/lib/payload', () => ({ getCachedPayload: jest.fn() }));
|
|
|
|
import { metadata } from '@/app/(frontend)/blog/page';
|
|
import { blogPostingJsonLd, breadcrumbJsonLd } from '@/lib/jsonld';
|
|
|
|
const post = {
|
|
title: 'What the data cannot tell you',
|
|
slug: 'what-the-data-cannot-tell-you',
|
|
excerpt: 'Results describe one year group on a handful of days.',
|
|
publishedAt: '2026-09-15T00:00:00.000Z',
|
|
};
|
|
|
|
describe('/blog metadata', () => {
|
|
it('canonicalises to the bare path', () => {
|
|
expect(metadata.alternates?.canonical)
|
|
.toBe('https://www.schoolcompare.co.uk/blog');
|
|
});
|
|
});
|
|
|
|
describe('BlogPosting structured data', () => {
|
|
it('names the same Person entity the about page declares', () => {
|
|
// By @id, not by repeating the person: search engines must resolve every
|
|
// post and the about page to one author entity, or the site has several.
|
|
const ld = blogPostingJsonLd(post, { namedAuthor: true });
|
|
expect(ld['@type']).toBe('BlogPosting');
|
|
expect(ld.author['@id']).toBe('https://www.schoolcompare.co.uk/about#tudor');
|
|
expect(ld.publisher['@id']).toBe('https://www.schoolcompare.co.uk#organization');
|
|
});
|
|
|
|
it('attributes to the organization when the about page is dark', () => {
|
|
/*
|
|
* The two flags are independent, so blog-on-about-off is a reachable
|
|
* state. The Person entity lives at /about#tudor and that URL 404s while
|
|
* the flag is dark, so claiming it would declare an author that resolves
|
|
* to nothing — worse for the blog's credibility than having no named
|
|
* author at all. Attribute to the publisher instead.
|
|
*/
|
|
const ld = blogPostingJsonLd(post, { namedAuthor: false });
|
|
expect(ld.author['@id']).toBe('https://www.schoolcompare.co.uk#organization');
|
|
expect(JSON.stringify(ld)).not.toContain('/about');
|
|
});
|
|
|
|
it('carries a self-referencing canonical url and the publish date', () => {
|
|
const ld = blogPostingJsonLd(post, { namedAuthor: true });
|
|
expect(ld.url).toBe(
|
|
'https://www.schoolcompare.co.uk/blog/what-the-data-cannot-tell-you',
|
|
);
|
|
expect(ld.datePublished).toBe('2026-09-15T00:00:00.000Z');
|
|
});
|
|
});
|
|
|
|
describe('breadcrumbs', () => {
|
|
it('places the post under the blog index', () => {
|
|
const ld = breadcrumbJsonLd(post);
|
|
expect(ld.itemListElement[0].item).toBe('https://www.schoolcompare.co.uk/blog');
|
|
expect(ld.itemListElement[1].item).toBe(
|
|
'https://www.schoolcompare.co.uk/blog/what-the-data-cannot-tell-you',
|
|
);
|
|
});
|
|
});
|