TudorandClaude Opus 5
3aad5101a8
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m2s
PR Checks / Backend Smoke (pull_request) Successful in 7s
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
PR Checks / Build Frontend (no push) (pull_request) Successful in 45s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 38s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 54s
Beechwood College (URN 142458, Sully, CF64 5SE) survived the England-only filter. GIAS types it a Special post 16 institution (32), not a Welsh establishment (30), so filtering on establishment type alone left it behind — the last Welsh school on the site, and the reason Vale of Glamorgan was still in the authority list. The earlier verification claimed the type codes mapped onto the Welsh authorities in both directions. That was checked exhaustively for Cardiff and by count for three others; Vale of Glamorgan was never checked, and it was the one that did not hold. LA code is the reliable discriminator: GIAS gives the 22 Welsh unitary authorities the contiguous block 660-681, which English authorities never use. Filtering on postcode would have been wrong — Redbrook, Tutshill, Wyedean and two other Gloucestershire schools carry NP16/NP25 postcodes because Royal Mail areas straddle the border, and they are English schools with English data. An e2e test now pins those five so the fix cannot be simplified into a postcode filter later. The 660-681 range is documented GIAS structure this project cannot verify from its own data, so the range filters and the authority NAME checks: if the range is ever wrong, a Welsh authority reappears in assert_england_only_schools and the pipeline fails loudly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015mWQnpye9F299NVRCCSRvj
60 lines
2.0 KiB
YAML
60 lines
2.0 KiB
YAML
name: school_compare
|
|
version: "1.0.0"
|
|
config-version: 2
|
|
|
|
profile: school_compare
|
|
|
|
model-paths: ["models"]
|
|
macro-paths: ["macros"]
|
|
test-paths: ["tests"]
|
|
seed-paths: ["seeds"]
|
|
target-path: "target"
|
|
clean-targets: ["target", "dbt_packages"]
|
|
|
|
# schoolcompare publishes England only. GIAS ships the whole UK plus overseas
|
|
# and offshore establishments, none of which have comparable DfE performance
|
|
# data — Wales does not publish on the English measures at all. Excluding them
|
|
# at the mart boundary keeps them out of the site, the filter lists and the
|
|
# sitemap together. Codes are TypeOfEstablishment, see seeds/gias_code_names.csv.
|
|
# 25 = Offshore schools (Jersey, Guernsey, Isle of Man, Gibraltar)
|
|
# 26 = Service children's education (BFPO, Fieldwork Overseas)
|
|
# 30 = Welsh establishment
|
|
# 37 = British schools overseas
|
|
# dim_school, dim_location and assert_england_only_schools all read this list.
|
|
vars:
|
|
non_england_school_type_codes: [25, 26, 30, 37]
|
|
|
|
# Type alone is not enough. Beechwood College (URN 142458, Sully, CF64 5SE)
|
|
# is a Welsh school that GIAS types as a Special post 16 institution (32)
|
|
# rather than a Welsh establishment (30), so the type filter let it through.
|
|
# LA code is the reliable discriminator: GIAS gives the 22 Welsh unitary
|
|
# authorities the contiguous block 660-681, which English authorities never
|
|
# use (they occupy 201-384 and 800-938).
|
|
#
|
|
# Filtering on postcode would be wrong: Redbrook, Tutshill, Wyedean and two
|
|
# other Gloucestershire schools carry NP16/NP25 postcodes because Royal Mail
|
|
# areas straddle the border, and they are English schools with English data.
|
|
welsh_la_code_min: 660
|
|
welsh_la_code_max: 681
|
|
|
|
models:
|
|
school_compare:
|
|
staging:
|
|
+materialized: view
|
|
+schema: staging
|
|
intermediate:
|
|
+materialized: view
|
|
+schema: intermediate
|
|
marts:
|
|
+materialized: table
|
|
+schema: marts
|
|
|
|
tests:
|
|
school_compare:
|
|
assert_no_orphaned_facts:
|
|
+severity: warn
|
|
|
|
seeds:
|
|
school_compare:
|
|
+schema: seeds
|