fix(compare): repair mobile add-school modal + re-apply stranded chart-height fix #56

Merged
tudor merged 2 commits from fix/mobile-compare-polish into main 2026-07-17 22:11:46 +00:00
5 changed files with 37 additions and 40 deletions
@@ -1,16 +1,23 @@
/* Chart wrapper: chips (mobile) above, canvas filling the rest of the /* Chart wrapper: chips (mobile) above, then the canvas, then the gap note.
parent .chartContainer, whose fixed height drives Chart.js sizing via The canvas has its OWN definite height (Chart.js needs one for
maintainAspectRatio: false. */ maintainAspectRatio: false); the chips and the note flow at their natural
size around it rather than competing with it for a fixed outer height —
so a longer note (e.g. the KS4 gap caption) or a two-row chip legend can
never squash the chart. */
.wrapper { .wrapper {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%;
} }
.canvasBox { .canvasBox {
position: relative; position: relative;
flex: 1 1 auto; height: 380px;
min-height: 0; }
@media (max-width: 640px) {
.canvasBox {
height: 280px;
}
} }
/* School chips: mobile-only legend + tap-to-focus control. Desktop keeps /* School chips: mobile-only legend + tap-to-focus control. Desktop keeps
+4
View File
@@ -123,6 +123,10 @@
.modal { .modal {
width: 100%; width: 100%;
max-width: 100%; max-width: 100%;
/* Bottom sheet: open at a stable, comfortable height so the empty
"start typing" state isn't a tiny stub and the sheet doesn't jump as
results load (the results list scrolls within). */
min-height: 55vh;
max-height: 95vh; max-height: 95vh;
border-bottom-left-radius: 0; border-bottom-left-radius: 0;
border-bottom-right-radius: 0; border-bottom-right-radius: 0;
@@ -2,14 +2,6 @@
padding: 1.5rem; padding: 1.5rem;
} }
.title {
font-size: 1.5rem;
font-weight: 700;
color: var(--text-primary, #1a1612);
margin-bottom: 1.5rem;
font-family: var(--font-playfair), 'Playfair Display', serif;
}
.warning { .warning {
background: var(--accent-gold-bg); background: var(--accent-gold-bg);
border: 1px solid var(--accent-gold, #c9a227); border: 1px solid var(--accent-gold, #c9a227);
@@ -119,12 +111,16 @@
font-size: 1rem; font-size: 1rem;
font-weight: 600; font-weight: 600;
color: var(--text-primary, #1a1612); color: var(--text-primary, #1a1612);
margin-bottom: 0.5rem; margin-bottom: 0.25rem;
white-space: nowrap; white-space: nowrap;
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
} }
.resultButton {
flex: 0 0 auto;
}
.schoolMeta { .schoolMeta {
display: flex; display: flex;
gap: 1rem; gap: 1rem;
@@ -159,21 +155,21 @@
padding: 1rem; padding: 1rem;
} }
.title { /* Compact stacked card: name + meta, then a full-width action so the tap
font-size: 1.25rem; target is obvious and the card doesn't waste vertical space. */
}
.resultItem { .resultItem {
flex-direction: column; flex-direction: column;
align-items: stretch; align-items: stretch;
gap: 0.625rem;
padding: 0.875rem;
} }
.addButton { .resultButton {
width: 100%; width: 100%;
} }
.schoolMeta { .schoolMeta {
flex-direction: column; flex-wrap: wrap;
gap: 0.25rem; gap: 0.25rem 1rem;
} }
} }
+3 -5
View File
@@ -81,10 +81,8 @@ export function SchoolSearchModal({ isOpen, onClose }: SchoolSearchModalProps) {
}; };
return ( return (
<Modal isOpen={isOpen} onClose={handleClose}> <Modal isOpen={isOpen} onClose={handleClose} title="Add School to Comparison">
<div className={styles.modalContent}> <div className={styles.modalContent}>
<h2 className={styles.title}>Add School to Comparison</h2>
{!canAddMore && ( {!canAddMore && (
<div className={styles.warning}> <div className={styles.warning}>
Maximum 5 schools can be compared. Remove a school to add another. Maximum 5 schools can be compared. Remove a school to add another.
@@ -129,9 +127,9 @@ export function SchoolSearchModal({ isOpen, onClose }: SchoolSearchModalProps) {
<button <button
onClick={() => handleAddSchool(school)} onClick={() => handleAddSchool(school)}
disabled={alreadySelected || !canAddMore} disabled={alreadySelected || !canAddMore}
className={ className={`${styles.resultButton} ${
alreadySelected ? "btn btn-active" : "btn btn-secondary" alreadySelected ? "btn btn-active" : "btn btn-secondary"
} }`}
> >
{alreadySelected ? "✓ Comparing" : "+ Compare"} {alreadySelected ? "✓ Comparing" : "+ Compare"}
</button> </button>
@@ -60,18 +60,10 @@
margin: 0 0 1rem; margin: 0 0 1rem;
} }
/* ComparisonChart runs Chart.js with maintainAspectRatio:false, so it fills /* ComparisonChart owns its own canvas height now (a definite px value per
its container's height — which must be *definite*. A min-height alone does breakpoint), with the mobile chip legend above and the gap note below it
not resolve the chart wrapper's height:100%, leaving Chart.js to fall back flowing at natural size. This box therefore only needs to not constrain
to its ~150px default (a squashed sliver). Give it a real height. */ that height — no fixed height, or the note would again eat the plot. */
.chartBox { .chartBox {
height: 420px; min-height: 0;
}
@media (max-width: 640px) {
/* Taller on mobile: the mobile-only school chips sit above the canvas and
wrap to two rows for 3+ schools, so the plot keeps a usable height. */
.chartBox {
height: 360px;
}
} }