The Results Over Time trend chart was capped at 280px tall on desktop, squishing the lines together and making them hard to read. This raises the base .chartContainer height to 380px in both the primary (KS2) and secondary (KS4) detail views.
Why mobile is unaffected
In both CSS modules the 380px lives in the base .chartContainer rule, which the existing @media (max-width: 768px) query already overrides with height: auto. On mobile, PerformanceChart's own .chartWrapper carries the canvas height (220px at ≤640px) with the chip strip and mini-legend flowing around it — so the desktop bump doesn't touch the mobile layout.
Notes
Verified .chartContainer only ever wraps PerformanceChart in both views (not the hero map).
Pure CSS value change; no behaviour change, so no e2e/ journey updates needed.
## What
The **Results Over Time** trend chart was capped at `280px` tall on desktop, squishing the lines together and making them hard to read. This raises the base `.chartContainer` height to `380px` in both the primary (KS2) and secondary (KS4) detail views.
## Why mobile is unaffected
In both CSS modules the `380px` lives in the base `.chartContainer` rule, which the existing `@media (max-width: 768px)` query already overrides with `height: auto`. On mobile, `PerformanceChart`'s own `.chartWrapper` carries the canvas height (220px at ≤640px) with the chip strip and mini-legend flowing around it — so the desktop bump doesn't touch the mobile layout.
## Notes
- Verified `.chartContainer` only ever wraps `PerformanceChart` in both views (not the hero map).
- Pure CSS value change; no behaviour change, so no `e2e/` journey updates needed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
The trend chart was capped at 280px tall on desktop, squishing the
lines together and making them hard to read. Raise the base
.chartContainer height to 380px in both the primary and secondary
detail views.
Mobile is unaffected: the base value is already overridden to
height:auto by the existing max-width:768px query, where
PerformanceChart's own .chartWrapper carries the canvas height.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
This PR only changes the height of .chartContainer from 280px to 380px in two CSS module files, adding an explanatory comment for the desktop-only change. Purely a cosmetic CSS tweak with no functional, security, or deploy risk.
✅ No issues found.
## 🤖 AI Code Review (Claude Code)
This PR only changes the height of `.chartContainer` from 280px to 380px in two CSS module files, adding an explanatory comment for the desktop-only change. Purely a cosmetic CSS tweak with no functional, security, or deploy risk.
✅ No issues found.
tudor
merged commit d02a323cdc into main2026-07-21 21:08:34 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
What
The Results Over Time trend chart was capped at
280pxtall on desktop, squishing the lines together and making them hard to read. This raises the base.chartContainerheight to380pxin both the primary (KS2) and secondary (KS4) detail views.Why mobile is unaffected
In both CSS modules the
380pxlives in the base.chartContainerrule, which the existing@media (max-width: 768px)query already overrides withheight: auto. On mobile,PerformanceChart's own.chartWrappercarries the canvas height (220px at ≤640px) with the chip strip and mini-legend flowing around it — so the desktop bump doesn't touch the mobile layout.Notes
.chartContaineronly ever wrapsPerformanceChartin both views (not the hero map).e2e/journey updates needed.🤖 Generated with Claude Code
https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
🤖 AI Code Review (Claude Code)
This PR only changes the height of
.chartContainerfrom 280px to 380px in two CSS module files, adding an explanatory comment for the desktop-only change. Purely a cosmetic CSS tweak with no functional, security, or deploy risk.✅ No issues found.