fix(modal): give the close button a 44px touch target

The close button was 40px square: a 24px icon in 8px of padding. MOBILE.md sets 44px as the minimum, and the phone filter sheet journey, which checks every target in the sheet, has failed on it in the staging E2E gate since the sheet shipped. Measured on staging with the rule injected: the button is 44x44, nothing in the sheet is under 44, and the page does not overflow. Every Modal gets the same button, the compare page's school search included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merge pull request 'feat(search): one state school group, not academy and council-run' (#171 ) from feat/single-state-school-group into main
2026-10-02 16:40:45 +01:00 · 2026-10-02 15:33:13 +00:00
1 changed files with 4 additions and 0 deletions
@@ -79,7 +79,11 @@
  font-family: var(--font-display);
 }
 /* 44px, the MOBILE.md touch-target minimum: the 24px icon and its padding
   came to 40, and the phone filter sheet journey caught it. */
 .closeButton {
  min-width: 2.75rem;
  min-height: 2.75rem;
  padding: 0.5rem;
  background: transparent;
  border: none;
Author	SHA1	Message	Date
TudorandClaude Opus 5.5	27d83f9bd0	fix(modal): give the close button a 44px touch target PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m13s Details PR Checks / Backend Smoke (pull_request) Successful in 10s Details PR Checks / Build Backend (no push) (pull_request) Successful in 18s Details PR Checks / Build Frontend (no push) (pull_request) Successful in 1m19s Details PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s Details PR Checks / AI Code Review (Claude) (pull_request) Successful in 12s Details The close button was 40px square: a 24px icon in 8px of padding. MOBILE.md sets 44px as the minimum, and the phone filter sheet journey, which checks every target in the sheet, has failed on it in the staging E2E gate since the sheet shipped. Measured on staging with the rule injected: the button is 44x44, nothing in the sheet is under 44, and the page does not overflow. Every Modal gets the same button, the compare page's school search included. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-02 16:40:45 +01:00
tudor	19c574edb0	Merge pull request 'feat(search): one state school group, not academy and council-run' (#171 ) from feat/single-state-school-group into main Stage (build -> staging -> E2E gate) / prepare (push) Successful in 1s Details Stage (build -> staging -> E2E gate) / Build Backend (FastAPI) (push) Successful in 19s Details Stage (build -> staging -> E2E gate) / Build Frontend (Next.js) (push) Successful in 1m24s Details Stage (build -> staging -> E2E gate) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 14s Details Stage (build -> staging -> E2E gate) / Deploy to Staging (push) Successful in 25s Details Stage (build -> staging -> E2E gate) / E2E Journeys against Staging (push) Failing after 3m2s Details Reviewed-on: #171	2026-10-02 15:33:13 +00:00