Compare commits
10
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f579630fab | ||
|
|
66bc5523f6 | ||
|
|
3cb72d0a0f | ||
|
|
b89fa47ec5 | ||
|
|
0c7ad0f309 | ||
|
|
e4565e9f15 | ||
|
|
06e4898c30 | ||
|
|
a9611e21c3 | ||
|
|
0696518995 | ||
|
|
315f1feede |
+4
-1
@@ -30,6 +30,7 @@ from .data_loader import (
|
|||||||
load_latest_school_data,
|
load_latest_school_data,
|
||||||
geocode_single_postcode,
|
geocode_single_postcode,
|
||||||
get_supplementary_data,
|
get_supplementary_data,
|
||||||
|
get_supplementary_data_batch,
|
||||||
search_schools_typesense,
|
search_schools_typesense,
|
||||||
)
|
)
|
||||||
from .data_loader import get_data_info as get_db_info
|
from .data_loader import get_data_info as get_db_info
|
||||||
@@ -679,8 +680,10 @@ async def compare_schools(
|
|||||||
db = None
|
db = None
|
||||||
try:
|
try:
|
||||||
db = database.SessionLocal()
|
db = database.SessionLocal()
|
||||||
|
# One query per table for all schools, not ~5 queries per school.
|
||||||
|
batch = get_supplementary_data_batch(db, urn_list)
|
||||||
for urn in urn_list:
|
for urn in urn_list:
|
||||||
supp = get_supplementary_data(db, urn)
|
supp = batch.get(urn, {})
|
||||||
supplementary_by_urn[urn] = {
|
supplementary_by_urn[urn] = {
|
||||||
key: supp.get(key, default)
|
key: supp.get(key, default)
|
||||||
for key, default in _EMPTY_SUPPLEMENTARY.items()
|
for key, default in _EMPTY_SUPPLEMENTARY.items()
|
||||||
|
|||||||
+123
-65
@@ -662,30 +662,8 @@ def _admissions_row_dict(a) -> dict:
|
|||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
def get_supplementary_data(db: Session, urn: int) -> dict:
|
def _census_dict(pc) -> dict:
|
||||||
"""Fetch all supplementary data for a single school URN."""
|
return {
|
||||||
result = {}
|
|
||||||
|
|
||||||
def safe_query(model, pk_field, latest_field=None):
|
|
||||||
try:
|
|
||||||
q = db.query(model).filter(getattr(model, pk_field) == urn)
|
|
||||||
if latest_field:
|
|
||||||
q = q.order_by(getattr(model, latest_field).desc())
|
|
||||||
return q.first()
|
|
||||||
except Exception as e:
|
|
||||||
import logging
|
|
||||||
logging.getLogger(__name__).error("safe_query failed for %s: %s", model.__name__, e)
|
|
||||||
db.rollback()
|
|
||||||
return None
|
|
||||||
|
|
||||||
# Latest Ofsted inspection
|
|
||||||
o = safe_query(FactOfstedInspection, "urn", "inspection_date")
|
|
||||||
result["ofsted"] = _ofsted_block(o, urn) if o else None
|
|
||||||
|
|
||||||
# Census (latest year of fact_pupil_characteristics)
|
|
||||||
pc = safe_query(FactPupilCharacteristics, "urn", "year")
|
|
||||||
result["census"] = (
|
|
||||||
{
|
|
||||||
"year": pc.year,
|
"year": pc.year,
|
||||||
"total_pupils": pc.total_pupils,
|
"total_pupils": pc.total_pupils,
|
||||||
"female_pupils": pc.female_pupils,
|
"female_pupils": pc.female_pupils,
|
||||||
@@ -693,52 +671,18 @@ def get_supplementary_data(db: Session, urn: int) -> dict:
|
|||||||
"fsm_pct": pc.fsm_pct,
|
"fsm_pct": pc.fsm_pct,
|
||||||
"eal_pct": pc.eal_pct,
|
"eal_pct": pc.eal_pct,
|
||||||
}
|
}
|
||||||
if pc
|
|
||||||
else None
|
|
||||||
)
|
|
||||||
|
|
||||||
# Admissions — all years, oldest first (for the multi-year trend view).
|
|
||||||
try:
|
|
||||||
admissions_rows = (
|
|
||||||
db.query(FactAdmissions)
|
|
||||||
.filter(FactAdmissions.urn == urn)
|
|
||||||
.order_by(FactAdmissions.year.asc())
|
|
||||||
.all()
|
|
||||||
)
|
|
||||||
except Exception as e:
|
|
||||||
import logging
|
|
||||||
logging.getLogger(__name__).error("admissions history query failed: %s", e)
|
|
||||||
db.rollback()
|
|
||||||
admissions_rows = []
|
|
||||||
|
|
||||||
history = [_admissions_row_dict(a) for a in admissions_rows]
|
def _deprivation_dict(d) -> dict:
|
||||||
result["admissions_history"] = history
|
return {
|
||||||
# Keep the single latest-year object for backwards-compatible consumers
|
|
||||||
# (hero chips, etc.).
|
|
||||||
result["admissions"] = history[-1] if history else None
|
|
||||||
|
|
||||||
# SEN detail — not available in current marts
|
|
||||||
result["sen_detail"] = None
|
|
||||||
|
|
||||||
# Phonics — no school-level data on EES
|
|
||||||
result["phonics"] = None
|
|
||||||
|
|
||||||
# Deprivation
|
|
||||||
d = safe_query(FactDeprivation, "urn")
|
|
||||||
result["deprivation"] = (
|
|
||||||
{
|
|
||||||
"lsoa_code": d.lsoa_code,
|
"lsoa_code": d.lsoa_code,
|
||||||
"idaci_score": d.idaci_score,
|
"idaci_score": d.idaci_score,
|
||||||
"idaci_decile": d.idaci_decile,
|
"idaci_decile": d.idaci_decile,
|
||||||
}
|
}
|
||||||
if d
|
|
||||||
else None
|
|
||||||
)
|
|
||||||
|
|
||||||
# Finance (latest year)
|
|
||||||
f = safe_query(FactFinance, "urn", "year")
|
def _finance_dict(f) -> dict:
|
||||||
result["finance"] = (
|
return {
|
||||||
{
|
|
||||||
"year": f.year,
|
"year": f.year,
|
||||||
"per_pupil_spend": f.per_pupil_spend,
|
"per_pupil_spend": f.per_pupil_spend,
|
||||||
"staff_cost_pct": f.staff_cost_pct,
|
"staff_cost_pct": f.staff_cost_pct,
|
||||||
@@ -746,8 +690,122 @@ def get_supplementary_data(db: Session, urn: int) -> dict:
|
|||||||
"support_staff_cost_pct": f.support_staff_cost_pct,
|
"support_staff_cost_pct": f.support_staff_cost_pct,
|
||||||
"premises_cost_pct": f.premises_cost_pct,
|
"premises_cost_pct": f.premises_cost_pct,
|
||||||
}
|
}
|
||||||
if f
|
|
||||||
else None
|
|
||||||
|
def _empty_supplementary() -> dict:
|
||||||
|
return {
|
||||||
|
"ofsted": None,
|
||||||
|
"census": None,
|
||||||
|
"admissions": None,
|
||||||
|
"admissions_history": [],
|
||||||
|
"sen_detail": None,
|
||||||
|
"phonics": None,
|
||||||
|
"deprivation": None,
|
||||||
|
"finance": None,
|
||||||
|
}
|
||||||
|
|
||||||
|
|
||||||
|
def get_supplementary_data_batch(db: Session, urns: list[int]) -> dict:
|
||||||
|
"""Fetch supplementary data for many URNs with one query per table
|
||||||
|
(WHERE urn IN (...)) instead of ~5 queries per school, collapsing the
|
||||||
|
per-request round-trips from 5*N to a constant 5. Returns {urn: block}
|
||||||
|
with the same shape get_supplementary_data produces per URN.
|
||||||
|
|
||||||
|
Each table is queried independently and failures degrade that table to
|
||||||
|
empty for every URN — a missing mart never blanks the others.
|
||||||
|
"""
|
||||||
|
urns = [int(u) for u in urns]
|
||||||
|
result = {urn: _empty_supplementary() for urn in urns}
|
||||||
|
if not urns:
|
||||||
|
return result
|
||||||
|
|
||||||
|
def _safe(fn):
|
||||||
|
try:
|
||||||
|
fn()
|
||||||
|
except Exception as e:
|
||||||
|
import logging
|
||||||
|
logging.getLogger(__name__).error("batch supplementary query failed: %s", e)
|
||||||
|
db.rollback()
|
||||||
|
|
||||||
|
# Ofsted — latest inspection per URN. Ordered so the first row seen per
|
||||||
|
# URN is the most recent.
|
||||||
|
def _ofsted():
|
||||||
|
rows = (
|
||||||
|
db.query(FactOfstedInspection)
|
||||||
|
.filter(FactOfstedInspection.urn.in_(urns))
|
||||||
|
.order_by(FactOfstedInspection.urn, FactOfstedInspection.inspection_date.desc())
|
||||||
|
.all()
|
||||||
)
|
)
|
||||||
|
seen = set()
|
||||||
|
for o in rows:
|
||||||
|
if o.urn in seen:
|
||||||
|
continue
|
||||||
|
seen.add(o.urn)
|
||||||
|
result[o.urn]["ofsted"] = _ofsted_block(o, o.urn)
|
||||||
|
_safe(_ofsted)
|
||||||
|
|
||||||
|
# Census — latest year per URN.
|
||||||
|
def _census():
|
||||||
|
rows = (
|
||||||
|
db.query(FactPupilCharacteristics)
|
||||||
|
.filter(FactPupilCharacteristics.urn.in_(urns))
|
||||||
|
.order_by(FactPupilCharacteristics.urn, FactPupilCharacteristics.year.desc())
|
||||||
|
.all()
|
||||||
|
)
|
||||||
|
seen = set()
|
||||||
|
for pc in rows:
|
||||||
|
if pc.urn in seen:
|
||||||
|
continue
|
||||||
|
seen.add(pc.urn)
|
||||||
|
result[pc.urn]["census"] = _census_dict(pc)
|
||||||
|
_safe(_census)
|
||||||
|
|
||||||
|
# Admissions — all years per URN, oldest first (multi-year trend view).
|
||||||
|
def _admissions():
|
||||||
|
rows = (
|
||||||
|
db.query(FactAdmissions)
|
||||||
|
.filter(FactAdmissions.urn.in_(urns))
|
||||||
|
.order_by(FactAdmissions.urn, FactAdmissions.year.asc())
|
||||||
|
.all()
|
||||||
|
)
|
||||||
|
history: dict = {urn: [] for urn in urns}
|
||||||
|
for a in rows:
|
||||||
|
history[a.urn].append(_admissions_row_dict(a))
|
||||||
|
for urn, rows_for_urn in history.items():
|
||||||
|
result[urn]["admissions_history"] = rows_for_urn
|
||||||
|
result[urn]["admissions"] = rows_for_urn[-1] if rows_for_urn else None
|
||||||
|
_safe(_admissions)
|
||||||
|
|
||||||
|
# Deprivation — one row per URN.
|
||||||
|
def _deprivation():
|
||||||
|
rows = (
|
||||||
|
db.query(FactDeprivation)
|
||||||
|
.filter(FactDeprivation.urn.in_(urns))
|
||||||
|
.all()
|
||||||
|
)
|
||||||
|
for d in rows:
|
||||||
|
result[d.urn]["deprivation"] = _deprivation_dict(d)
|
||||||
|
_safe(_deprivation)
|
||||||
|
|
||||||
|
# Finance — latest year per URN.
|
||||||
|
def _finance():
|
||||||
|
rows = (
|
||||||
|
db.query(FactFinance)
|
||||||
|
.filter(FactFinance.urn.in_(urns))
|
||||||
|
.order_by(FactFinance.urn, FactFinance.year.desc())
|
||||||
|
.all()
|
||||||
|
)
|
||||||
|
seen = set()
|
||||||
|
for f in rows:
|
||||||
|
if f.urn in seen:
|
||||||
|
continue
|
||||||
|
seen.add(f.urn)
|
||||||
|
result[f.urn]["finance"] = _finance_dict(f)
|
||||||
|
_safe(_finance)
|
||||||
|
|
||||||
return result
|
return result
|
||||||
|
|
||||||
|
|
||||||
|
def get_supplementary_data(db: Session, urn: int) -> dict:
|
||||||
|
"""Supplementary data for a single URN (thin wrapper over the batch)."""
|
||||||
|
return get_supplementary_data_batch(db, [urn])[int(urn)]
|
||||||
|
|||||||
@@ -67,7 +67,9 @@ def client(monkeypatch):
|
|||||||
|
|
||||||
monkeypatch.setattr(app_module, "load_school_data", _two_primary_schools_df)
|
monkeypatch.setattr(app_module, "load_school_data", _two_primary_schools_df)
|
||||||
monkeypatch.setattr(
|
monkeypatch.setattr(
|
||||||
app_module, "get_supplementary_data", lambda db, urn: dict(CANNED_SUPPLEMENTARY)
|
app_module,
|
||||||
|
"get_supplementary_data_batch",
|
||||||
|
lambda db, urns: {int(u): dict(CANNED_SUPPLEMENTARY) for u in urns},
|
||||||
)
|
)
|
||||||
monkeypatch.setattr(database_module, "SessionLocal", _StubSession)
|
monkeypatch.setattr(database_module, "SessionLocal", _StubSession)
|
||||||
return TestClient(app_module.app, raise_server_exceptions=False)
|
return TestClient(app_module.app, raise_server_exceptions=False)
|
||||||
@@ -102,10 +104,10 @@ def test_top_level_national_averages_and_benchmarks(client):
|
|||||||
def test_supplementary_failure_degrades_not_500(client, monkeypatch):
|
def test_supplementary_failure_degrades_not_500(client, monkeypatch):
|
||||||
from backend import app as app_module
|
from backend import app as app_module
|
||||||
|
|
||||||
def _boom(db, urn):
|
def _boom(db, urns):
|
||||||
raise RuntimeError("marts unavailable")
|
raise RuntimeError("marts unavailable")
|
||||||
|
|
||||||
monkeypatch.setattr(app_module, "get_supplementary_data", _boom)
|
monkeypatch.setattr(app_module, "get_supplementary_data_batch", _boom)
|
||||||
resp = client.get("/api/compare?urns=100140")
|
resp = client.get("/api/compare?urns=100140")
|
||||||
assert resp.status_code == 200
|
assert resp.status_code == 200
|
||||||
school = resp.json()["comparison"]["100140"]
|
school = resp.json()["comparison"]["100140"]
|
||||||
|
|||||||
@@ -0,0 +1,111 @@
|
|||||||
|
"""get_supplementary_data_batch fetches one query per table for all URNs
|
||||||
|
(not ~5 per school) and returns the same per-URN block shape as the
|
||||||
|
single-URN function, picking the latest row per URN where relevant."""
|
||||||
|
|
||||||
|
import types
|
||||||
|
|
||||||
|
from backend import data_loader
|
||||||
|
from backend.data_loader import get_supplementary_data_batch
|
||||||
|
|
||||||
|
|
||||||
|
class _FakeQuery:
|
||||||
|
"""Records that a query ran and serves canned rows filtered by an in-list."""
|
||||||
|
|
||||||
|
def __init__(self, recorder, model_name, rows):
|
||||||
|
self._rec = recorder
|
||||||
|
self._model = model_name
|
||||||
|
self._rows = rows
|
||||||
|
|
||||||
|
def filter(self, *args, **kwargs):
|
||||||
|
return self
|
||||||
|
|
||||||
|
def order_by(self, *args, **kwargs):
|
||||||
|
return self
|
||||||
|
|
||||||
|
def all(self):
|
||||||
|
self._rec.append(self._model)
|
||||||
|
return self._rows
|
||||||
|
|
||||||
|
def first(self):
|
||||||
|
self._rec.append(self._model)
|
||||||
|
return self._rows[0] if self._rows else None
|
||||||
|
|
||||||
|
|
||||||
|
class _FakeSession:
|
||||||
|
def __init__(self, rows_by_model):
|
||||||
|
self.rows_by_model = rows_by_model
|
||||||
|
self.queries: list[str] = []
|
||||||
|
|
||||||
|
def query(self, model):
|
||||||
|
name = model.__name__
|
||||||
|
return _FakeQuery(self.queries, name, self.rows_by_model.get(name, []))
|
||||||
|
|
||||||
|
def rollback(self):
|
||||||
|
pass
|
||||||
|
|
||||||
|
|
||||||
|
def _ofsted_row(urn, date, oe):
|
||||||
|
base = {f: None for f in (
|
||||||
|
"framework", "inspection_type", "quality_of_education", "behaviour_attitudes",
|
||||||
|
"personal_development", "leadership_management", "early_years_provision",
|
||||||
|
"sixth_form_provision", "ungraded_outcome", "ungraded_grade",
|
||||||
|
"rc_safeguarding_met", "rc_inclusion", "rc_curriculum_teaching", "rc_achievement",
|
||||||
|
"rc_attendance_behaviour", "rc_personal_development", "rc_leadership_governance",
|
||||||
|
"rc_early_years", "rc_sixth_form", "report_url",
|
||||||
|
)}
|
||||||
|
base.update(urn=urn, inspection_date=types.SimpleNamespace(isoformat=lambda: date),
|
||||||
|
overall_effectiveness=oe, grade_source=None)
|
||||||
|
return types.SimpleNamespace(**base)
|
||||||
|
|
||||||
|
|
||||||
|
def _adm_row(urn, year):
|
||||||
|
return types.SimpleNamespace(
|
||||||
|
urn=urn, year=year, school_phase="Primary", places_offered=100,
|
||||||
|
total_applications=200, first_preference_applications=150,
|
||||||
|
first_preference_offers=140, first_preference_offer_pct=93.3,
|
||||||
|
oversubscription_ratio=1.5, oversubscribed=True,
|
||||||
|
total_offers=100, second_preference_offers=5, third_preference_offers=2,
|
||||||
|
cross_la_applications=10, cross_la_offers=3,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def test_one_query_per_table_and_latest_row_per_urn():
|
||||||
|
rows = {
|
||||||
|
# URN 1 has two Ofsted rows; the batch must keep the most recent (2023).
|
||||||
|
"FactOfstedInspection": [
|
||||||
|
_ofsted_row(1, "2023-01-01", 2),
|
||||||
|
_ofsted_row(1, "2019-01-01", 3),
|
||||||
|
_ofsted_row(2, "2021-06-01", 1),
|
||||||
|
],
|
||||||
|
"FactAdmissions": [_adm_row(1, 202526), _adm_row(1, 202627), _adm_row(2, 202627)],
|
||||||
|
"FactPupilCharacteristics": [],
|
||||||
|
"FactDeprivation": [],
|
||||||
|
"FactFinance": [],
|
||||||
|
}
|
||||||
|
session = _FakeSession(rows)
|
||||||
|
out = get_supplementary_data_batch(session, [1, 2])
|
||||||
|
|
||||||
|
# Exactly one query per table — five total, regardless of two URNs.
|
||||||
|
assert sorted(session.queries) == [
|
||||||
|
"FactAdmissions", "FactDeprivation", "FactFinance",
|
||||||
|
"FactOfstedInspection", "FactPupilCharacteristics",
|
||||||
|
]
|
||||||
|
|
||||||
|
# Latest Ofsted kept per URN
|
||||||
|
assert out[1]["ofsted"]["overall_effectiveness"] == 2
|
||||||
|
assert out[2]["ofsted"]["overall_effectiveness"] == 1
|
||||||
|
|
||||||
|
# Admissions history grouped per URN, latest exposed as `admissions`
|
||||||
|
assert [r["year"] for r in out[1]["admissions_history"]] == [202526, 202627]
|
||||||
|
assert out[1]["admissions"]["year"] == 202627
|
||||||
|
assert out[2]["admissions_history"] == [{**out[2]["admissions_history"][0]}]
|
||||||
|
|
||||||
|
# Empty tables degrade to the null block, not a crash
|
||||||
|
assert out[1]["census"] is None and out[1]["deprivation"] is None
|
||||||
|
|
||||||
|
|
||||||
|
def test_single_wrapper_matches_batch(monkeypatch):
|
||||||
|
session = _FakeSession({"FactOfstedInspection": [_ofsted_row(5, "2022-01-01", 2)]})
|
||||||
|
single = data_loader.get_supplementary_data(session, 5)
|
||||||
|
assert single["ofsted"]["overall_effectiveness"] == 2
|
||||||
|
assert single["admissions_history"] == []
|
||||||
+32
-12
@@ -19,6 +19,27 @@ function schoolLinks(page: Page) {
|
|||||||
return page.locator('a[href^="/school/"]');
|
return page.locator('a[href^="/school/"]');
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Two URNs guaranteed to be pure-primary (same phase). The compare page's
|
||||||
|
* phase tabs split all-through schools (which carry KS4 data) onto the
|
||||||
|
* secondary tab, so picking two arbitrary "primary" search hits can land
|
||||||
|
* them on different tabs where only the active one renders. Selecting via
|
||||||
|
* the API by exact phase keeps both on the same tab. Data-invariant: uses
|
||||||
|
* whatever primaries the environment holds.
|
||||||
|
*/
|
||||||
|
async function twoPrimaryUrns(page: Page): Promise<[string, string]> {
|
||||||
|
const res = await page.request.get('/api/schools?search=primary&per_page=50');
|
||||||
|
expect(res.ok()).toBeTruthy();
|
||||||
|
const body = await res.json();
|
||||||
|
const urns: string[] = (body.schools ?? [])
|
||||||
|
.filter((s: { phase?: string; rwm_expected_pct?: number | null }) =>
|
||||||
|
s.phase === 'Primary' && s.rwm_expected_pct != null,
|
||||||
|
)
|
||||||
|
.map((s: { urn: number }) => String(s.urn));
|
||||||
|
expect(urns.length).toBeGreaterThanOrEqual(2);
|
||||||
|
return [urns[0], urns[1]];
|
||||||
|
}
|
||||||
|
|
||||||
test('home page loads with hero search', async ({ page }) => {
|
test('home page loads with hero search', async ({ page }) => {
|
||||||
await page.goto('/');
|
await page.goto('/');
|
||||||
await expect(page.locator('h1').first()).toBeVisible();
|
await expect(page.locator('h1').first()).toBeVisible();
|
||||||
@@ -139,19 +160,13 @@ test('results map fullscreen falls back to an overlay on iOS', async ({ page })
|
|||||||
});
|
});
|
||||||
|
|
||||||
test('comparing two schools shows the parent-first sections side by side', async ({ page }) => {
|
test('comparing two schools shows the parent-first sections side by side', async ({ page }) => {
|
||||||
// Collect two school URNs from search results, then load the share URL
|
// Two same-phase (pure primary) schools so both stay on one tab.
|
||||||
await searchByName(page, 'primary');
|
const [urn0, urn1] = await twoPrimaryUrns(page);
|
||||||
await expect(schoolLinks(page).first()).toBeVisible({ timeout: 15_000 });
|
|
||||||
const hrefs = await schoolLinks(page).evaluateAll((links) =>
|
|
||||||
links.map((l) => (l as HTMLAnchorElement).getAttribute('href') || '')
|
|
||||||
);
|
|
||||||
const urns = [...new Set(hrefs.map((h) => h.match(/\/school\/(\d+)/)?.[1]).filter(Boolean))];
|
|
||||||
expect(urns.length).toBeGreaterThanOrEqual(2);
|
|
||||||
|
|
||||||
await page.goto(`/compare?urns=${urns[0]},${urns[1]}`);
|
await page.goto(`/compare?urns=${urn0},${urn1}`);
|
||||||
// Both schools' detail links should render in the comparison view
|
// Both schools' detail links should render in the comparison view
|
||||||
await expect(page.locator(`a[href*="${urns[0]}"]`).first()).toBeVisible({ timeout: 15_000 });
|
await expect(page.locator(`a[href*="${urn0}"]`).first()).toBeVisible({ timeout: 15_000 });
|
||||||
await expect(page.locator(`a[href*="${urns[1]}"]`).first()).toBeVisible();
|
await expect(page.locator(`a[href*="${urn1}"]`).first()).toBeVisible();
|
||||||
|
|
||||||
// The parent-first sections render in order (data-invariant: headings only)
|
// The parent-first sections render in order (data-invariant: headings only)
|
||||||
for (const heading of [
|
for (const heading of [
|
||||||
@@ -213,7 +228,12 @@ test('compare chart on mobile shows school chips with tap-to-focus', async ({ pa
|
|||||||
expect(bodyOverflowsX).toBe(false);
|
expect(bodyOverflowsX).toBe(false);
|
||||||
|
|
||||||
// The trends chart still renders (inside the Explore trends section)…
|
// The trends chart still renders (inside the Explore trends section)…
|
||||||
await expect(page.locator('canvas:visible').first()).toBeVisible({ timeout: 15_000 });
|
const chartCanvas = page.locator('canvas:visible').first();
|
||||||
|
await expect(chartCanvas).toBeVisible({ timeout: 15_000 });
|
||||||
|
// …at a real height, not the squashed ~150px Chart.js fallback that
|
||||||
|
// appears when the container lacks a definite height.
|
||||||
|
const chartBox = await chartCanvas.boundingBox();
|
||||||
|
expect(chartBox && chartBox.height).toBeGreaterThan(220);
|
||||||
|
|
||||||
// …with the mobile chart legend chips and tap-to-focus behaviour intact.
|
// …with the mobile chart legend chips and tap-to-focus behaviour intact.
|
||||||
const chipGroup = page.getByRole('group', { name: /highlight a school/i });
|
const chipGroup = page.getByRole('group', { name: /highlight a school/i });
|
||||||
|
|||||||
@@ -95,4 +95,12 @@ describe('CompareOfsted', () => {
|
|||||||
expect(links).toHaveLength(3);
|
expect(links).toHaveLength(3);
|
||||||
expect(links[0]).toHaveAttribute('href', 'https://reports.ofsted.gov.uk/provider/21/1');
|
expect(links[0]).toHaveAttribute('href', 'https://reports.ofsted.gov.uk/provider/21/1');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('renders a per-measure mobile tag with the short school name', () => {
|
||||||
|
render(<CompareOfsted schools={schools} data={data} />);
|
||||||
|
// Each measure repeats the schools, so the short name ("Graded" from
|
||||||
|
// "Graded School") appears once per measure (4) via the cell tag.
|
||||||
|
expect(screen.getAllByText('Graded').length).toBe(4);
|
||||||
|
expect(screen.getAllByText('Card').length).toBe(4);
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -10,6 +10,7 @@ import {
|
|||||||
debounce,
|
debounce,
|
||||||
buildOfstedListBadge,
|
buildOfstedListBadge,
|
||||||
metricKind,
|
metricKind,
|
||||||
|
shortName,
|
||||||
computeYBounds,
|
computeYBounds,
|
||||||
} from '@/lib/utils';
|
} from '@/lib/utils';
|
||||||
|
|
||||||
@@ -223,3 +224,17 @@ describe('isProposedToClose', () => {
|
|||||||
expect(isProposedToClose({})).toBe(false);
|
expect(isProposedToClose({})).toBe(false);
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
describe('shortName', () => {
|
||||||
|
it('drops the trailing establishment-type words', () => {
|
||||||
|
expect(shortName('Barclay Primary School')).toBe('Barclay');
|
||||||
|
expect(shortName('Elmhurst Primary School')).toBe('Elmhurst');
|
||||||
|
expect(shortName("St Mary's Catholic Primary School")).toBe("St Mary's");
|
||||||
|
expect(shortName('Riverside Community Junior School')).toBe('Riverside');
|
||||||
|
});
|
||||||
|
|
||||||
|
it('keeps a name that carries no type suffix, capping very long ones', () => {
|
||||||
|
expect(shortName('Beaver Road')).toBe('Beaver Road');
|
||||||
|
expect(shortName('A'.repeat(30), 10)).toBe('AAAAAAAAA…');
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|||||||
@@ -132,6 +132,11 @@
|
|||||||
color: var(--accent-coral-dark, #b04a2e);
|
color: var(--accent-coral-dark, #b04a2e);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Full name on desktop, short name on the compact mobile pills. */
|
||||||
|
.chipNameShort {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
.chipMeta {
|
.chipMeta {
|
||||||
display: block;
|
display: block;
|
||||||
font-size: 0.78rem;
|
font-size: 0.78rem;
|
||||||
@@ -163,3 +168,40 @@
|
|||||||
padding-top: 1rem;
|
padding-top: 1rem;
|
||||||
max-width: 75ch;
|
max-width: 75ch;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Mobile: the sticky school bar becomes compact, horizontally-scrollable
|
||||||
|
pills with short names (matching the mobile mockup) instead of full-width
|
||||||
|
cards whose names wrap to several lines. */
|
||||||
|
@media (max-width: 640px) {
|
||||||
|
.schoolChip {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
min-width: 0;
|
||||||
|
border-top-width: 2px;
|
||||||
|
border-radius: 999px;
|
||||||
|
padding: 0.35rem 0.7rem;
|
||||||
|
box-shadow: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipName {
|
||||||
|
font-size: 0.85rem;
|
||||||
|
white-space: nowrap;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipNameFull {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipNameShort {
|
||||||
|
display: inline;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipMeta {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
|
.chipRemove {
|
||||||
|
width: 18px;
|
||||||
|
height: 18px;
|
||||||
|
font-size: 0.75rem;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -28,7 +28,7 @@ import type {
|
|||||||
NationalAverages,
|
NationalAverages,
|
||||||
School,
|
School,
|
||||||
} from '@/lib/types';
|
} from '@/lib/types';
|
||||||
import { CHART_COLORS, schoolUrl } from '@/lib/utils';
|
import { CHART_COLORS, schoolUrl, shortName } from '@/lib/utils';
|
||||||
import { fetchComparison } from '@/lib/api';
|
import { fetchComparison } from '@/lib/api';
|
||||||
import { track } from '@/lib/analytics';
|
import { track } from '@/lib/analytics';
|
||||||
import styles from './ComparisonView.module.css';
|
import styles from './ComparisonView.module.css';
|
||||||
@@ -349,7 +349,8 @@ export function ComparisonView({
|
|||||||
/>
|
/>
|
||||||
<span className={styles.chipText}>
|
<span className={styles.chipText}>
|
||||||
<a className={styles.chipName} href={schoolUrl(school.urn, school.school_name)}>
|
<a className={styles.chipName} href={schoolUrl(school.urn, school.school_name)}>
|
||||||
{school.school_name}
|
<span className={styles.chipNameFull}>{school.school_name}</span>
|
||||||
|
<span className={styles.chipNameShort}>{shortName(school.school_name)}</span>
|
||||||
</a>
|
</a>
|
||||||
<span className={styles.chipMeta}>
|
<span className={styles.chipMeta}>
|
||||||
{[school.local_authority, school.school_type].filter(Boolean).join(' · ')}
|
{[school.local_authority, school.school_type].filter(Boolean).join(' · ')}
|
||||||
|
|||||||
@@ -10,7 +10,7 @@
|
|||||||
import { summariseAdmissions } from '@/lib/compareLogic';
|
import { summariseAdmissions } from '@/lib/compareLogic';
|
||||||
import type { ComparisonData, School } from '@/lib/types';
|
import type { ComparisonData, School } from '@/lib/types';
|
||||||
import { CHART_COLORS } from '@/lib/utils';
|
import { CHART_COLORS } from '@/lib/utils';
|
||||||
import { Cell, Chip, RowLabel, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
import { Cell, Chip, Measure, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
||||||
|
|
||||||
export function CompareAdmissions({
|
export function CompareAdmissions({
|
||||||
schools,
|
schools,
|
||||||
@@ -49,9 +49,10 @@ export function CompareAdmissions({
|
|||||||
}
|
}
|
||||||
>
|
>
|
||||||
<SectionGrid schools={schools}>
|
<SectionGrid schools={schools}>
|
||||||
<RowLabel tip="How many application forms named the school at any preference rank — not the number of families competing head-to-head for a place.">
|
<Measure
|
||||||
Interest in the school
|
tip="How many application forms named the school at any preference rank — not the number of families competing head-to-head for a place."
|
||||||
</RowLabel>
|
label="Interest in the school"
|
||||||
|
>
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const a = rows[i];
|
const a = rows[i];
|
||||||
return (
|
return (
|
||||||
@@ -68,7 +69,9 @@ export function CompareAdmissions({
|
|||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
|
||||||
<RowLabel>First-choice families offered a place</RowLabel>
|
</Measure>
|
||||||
|
|
||||||
|
<Measure label="First-choice families offered a place">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const summary = summariseAdmissions(rows[i]);
|
const summary = summariseAdmissions(rows[i]);
|
||||||
return (
|
return (
|
||||||
@@ -95,7 +98,9 @@ export function CompareAdmissions({
|
|||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
|
||||||
<RowLabel>What this means</RowLabel>
|
</Measure>
|
||||||
|
|
||||||
|
<Measure label="What this means">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const a = rows[i];
|
const a = rows[i];
|
||||||
const summary = summariseAdmissions(a);
|
const summary = summariseAdmissions(a);
|
||||||
@@ -118,6 +123,7 @@ export function CompareAdmissions({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
</SectionGrid>
|
</SectionGrid>
|
||||||
</Section>
|
</Section>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -15,7 +15,7 @@ import {
|
|||||||
type ReportCardSummary,
|
type ReportCardSummary,
|
||||||
} from '@/lib/compareLogic';
|
} from '@/lib/compareLogic';
|
||||||
import type { Benchmarks, ComparisonData, NationalAverages, School } from '@/lib/types';
|
import type { Benchmarks, ComparisonData, NationalAverages, School } from '@/lib/types';
|
||||||
import { Cell, Chip, RowLabel, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
import { Cell, Chip, Measure, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
||||||
|
|
||||||
function ReportCardChips({ summary }: { summary: ReportCardSummary }) {
|
function ReportCardChips({ summary }: { summary: ReportCardSummary }) {
|
||||||
return (
|
return (
|
||||||
@@ -69,7 +69,7 @@ export function CompareAtAGlance({
|
|||||||
return (
|
return (
|
||||||
<Section title="At a glance" how="The short version — each row below is explained in its own section further down.">
|
<Section title="At a glance" how="The short version — each row below is explained in its own section further down.">
|
||||||
<SectionGrid schools={schools}>
|
<SectionGrid schools={schools}>
|
||||||
<RowLabel>Latest Ofsted inspection</RowLabel>
|
<Measure label="Latest Ofsted inspection">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const display = ofstedDisplay(data[String(school.urn)]?.ofsted);
|
const display = ofstedDisplay(data[String(school.urn)]?.ofsted);
|
||||||
return (
|
return (
|
||||||
@@ -87,16 +87,16 @@ export function CompareAtAGlance({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel
|
<Measure
|
||||||
tip={
|
tip={
|
||||||
isSecondary
|
isSecondary
|
||||||
? 'Average Attainment 8 score across GCSE subjects (latest year).'
|
? 'Average Attainment 8 score across GCSE subjects (latest year).'
|
||||||
: '% of Year 6 pupils reaching the expected standard in reading, writing and maths (latest year).'
|
: '% of Year 6 pupils reaching the expected standard in reading, writing and maths (latest year).'
|
||||||
}
|
}
|
||||||
|
label={isSecondary ? 'Attainment 8 score' : 'Children reaching the expected standard'}
|
||||||
>
|
>
|
||||||
{isSecondary ? 'Attainment 8 score' : 'Children reaching the expected standard'}
|
|
||||||
</RowLabel>
|
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const value = headlineValues[i];
|
const value = headlineValues[i];
|
||||||
return (
|
return (
|
||||||
@@ -131,8 +131,9 @@ export function CompareAtAGlance({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel>Getting a place</RowLabel>
|
<Measure label="Getting a place">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const summary = summariseAdmissions(data[String(school.urn)]?.admissions);
|
const summary = summariseAdmissions(data[String(school.urn)]?.admissions);
|
||||||
return (
|
return (
|
||||||
@@ -148,8 +149,9 @@ export function CompareAtAGlance({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel>Size</RowLabel>
|
<Measure label="Size">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const census = data[String(school.urn)]?.census;
|
const census = data[String(school.urn)]?.census;
|
||||||
const pupils = census?.total_pupils ?? school.total_pupils ?? null;
|
const pupils = census?.total_pupils ?? school.total_pupils ?? null;
|
||||||
@@ -174,6 +176,7 @@ export function CompareAtAGlance({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
</SectionGrid>
|
</SectionGrid>
|
||||||
</Section>
|
</Section>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -9,7 +9,7 @@
|
|||||||
|
|
||||||
import { verdict } from '@/lib/compareLogic';
|
import { verdict } from '@/lib/compareLogic';
|
||||||
import type { Benchmarks, ComparisonData, School } from '@/lib/types';
|
import type { Benchmarks, ComparisonData, School } from '@/lib/types';
|
||||||
import { Cell, Chip, RowLabel, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
import { Cell, Chip, Measure, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
||||||
|
|
||||||
function pctSplit(part: number | null | undefined, total: number | null | undefined): string | null {
|
function pctSplit(part: number | null | undefined, total: number | null | undefined): string | null {
|
||||||
if (part == null || total == null || total === 0) return null;
|
if (part == null || total == null || total === 0) return null;
|
||||||
@@ -48,7 +48,7 @@ export function CompareCommunity({
|
|||||||
how="The school's community, from the latest school census. State-school averages are computed from our dataset and shown for context — there's no “right” number here."
|
how="The school's community, from the latest school census. State-school averages are computed from our dataset and shown for context — there's no “right” number here."
|
||||||
>
|
>
|
||||||
<SectionGrid schools={schools}>
|
<SectionGrid schools={schools}>
|
||||||
<RowLabel>Pupils on roll</RowLabel>
|
<Measure label="Pupils on roll">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const info = data[String(school.urn)]?.school_info as (School & { gias_total_pupils?: number | null; capacity?: number | null }) | undefined;
|
const info = data[String(school.urn)]?.school_info as (School & { gias_total_pupils?: number | null; capacity?: number | null }) | undefined;
|
||||||
const census = data[String(school.urn)]?.census;
|
const census = data[String(school.urn)]?.census;
|
||||||
@@ -74,8 +74,9 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel>Girls / boys</RowLabel>
|
<Measure label="Girls / boys">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const census = data[String(school.urn)]?.census;
|
const census = data[String(school.urn)]?.census;
|
||||||
const girls = pctSplit(census?.female_pupils, census?.total_pupils);
|
const girls = pctSplit(census?.female_pupils, census?.total_pupils);
|
||||||
@@ -86,10 +87,12 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel tip="% of pupils eligible for free school meals — a common measure of how many pupils come from lower-income families. Benchmark computed across state schools in our dataset.">
|
<Measure
|
||||||
Free school meals
|
tip="% of pupils eligible for free school meals — a common measure of how many pupils come from lower-income families. Benchmark computed across state schools in our dataset."
|
||||||
</RowLabel>
|
label="Free school meals"
|
||||||
|
>
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const fsm = data[String(school.urn)]?.census?.fsm_pct ?? null;
|
const fsm = data[String(school.urn)]?.census?.fsm_pct ?? null;
|
||||||
return (
|
return (
|
||||||
@@ -104,10 +107,12 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel tip="% of pupils whose first language is known or believed to be other than English. State-school average computed from our dataset.">
|
<Measure
|
||||||
English as an additional language
|
tip="% of pupils whose first language is known or believed to be other than English. State-school average computed from our dataset."
|
||||||
</RowLabel>
|
label="English as an additional language"
|
||||||
|
>
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const eal = data[String(school.urn)]?.census?.eal_pct ?? null;
|
const eal = data[String(school.urn)]?.census?.eal_pct ?? null;
|
||||||
return (
|
return (
|
||||||
@@ -116,10 +121,12 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel tip="% of pupils receiving SEN support (not including EHC plans). A high figure can mean the school hosts specialist provision — often a strength, not a warning sign. State-school average computed from our dataset.">
|
<Measure
|
||||||
Extra learning support (SEN)
|
tip="% of pupils receiving SEN support (not including EHC plans). A high figure can mean the school hosts specialist provision — often a strength, not a warning sign. State-school average computed from our dataset."
|
||||||
</RowLabel>
|
label="Extra learning support (SEN)"
|
||||||
|
>
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const rows = data[String(school.urn)]?.yearly_data ?? [];
|
const rows = data[String(school.urn)]?.yearly_data ?? [];
|
||||||
let sen: number | null = null;
|
let sen: number | null = null;
|
||||||
@@ -143,8 +150,9 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel>Faith character</RowLabel>
|
<Measure label="Faith character">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const info = data[String(school.urn)]?.school_info;
|
const info = data[String(school.urn)]?.school_info;
|
||||||
const faith = info?.religious_denomination;
|
const faith = info?.religious_denomination;
|
||||||
@@ -155,8 +163,9 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel>Ages</RowLabel>
|
<Measure label="Ages">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const info = data[String(school.urn)]?.school_info;
|
const info = data[String(school.urn)]?.school_info;
|
||||||
return (
|
return (
|
||||||
@@ -165,8 +174,9 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel>Run by</RowLabel>
|
<Measure label="Run by">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const info = data[String(school.urn)]?.school_info;
|
const info = data[String(school.urn)]?.school_info;
|
||||||
const trust = info?.trust_name;
|
const trust = info?.trust_name;
|
||||||
@@ -177,6 +187,7 @@ export function CompareCommunity({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
</SectionGrid>
|
</SectionGrid>
|
||||||
</Section>
|
</Section>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -13,7 +13,7 @@ import {
|
|||||||
type OfstedDisplay,
|
type OfstedDisplay,
|
||||||
} from '@/lib/compareLogic';
|
} from '@/lib/compareLogic';
|
||||||
import type { ComparisonData, OfstedInspection, School } from '@/lib/types';
|
import type { ComparisonData, OfstedInspection, School } from '@/lib/types';
|
||||||
import { Cell, Chip, RowLabel, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
import { Cell, Chip, Measure, Section, SectionGrid, sectionStyles as s } from './sectionShared';
|
||||||
|
|
||||||
const GRADE_TONE: Record<number, 'good' | 'warn' | 'bad'> = {
|
const GRADE_TONE: Record<number, 'good' | 'warn' | 'bad'> = {
|
||||||
1: 'good',
|
1: 'good',
|
||||||
@@ -157,14 +157,15 @@ export function CompareOfsted({
|
|||||||
}
|
}
|
||||||
>
|
>
|
||||||
<SectionGrid schools={schools}>
|
<SectionGrid schools={schools}>
|
||||||
<RowLabel>Result</RowLabel>
|
<Measure label="Result">
|
||||||
{schools.map((school, i) => (
|
{schools.map((school, i) => (
|
||||||
<Cell key={school.urn} school={school} index={i}>
|
<Cell key={school.urn} school={school} index={i}>
|
||||||
<ResultCell display={displays[i]} />
|
<ResultCell display={displays[i]} />
|
||||||
</Cell>
|
</Cell>
|
||||||
))}
|
))}
|
||||||
|
</Measure>
|
||||||
|
|
||||||
<RowLabel>Inspected</RowLabel>
|
<Measure label="Inspected">
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const ofsted = data[String(school.urn)]?.ofsted;
|
const ofsted = data[String(school.urn)]?.ofsted;
|
||||||
const age = yearsSince(ofsted?.inspection_date ?? null);
|
const age = yearsSince(ofsted?.inspection_date ?? null);
|
||||||
@@ -176,9 +177,12 @@ export function CompareOfsted({
|
|||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
|
||||||
<RowLabel tip="Older-style inspections: one rating per judgement area, where published. New-style inspections: the full report card, one rating per area of school life.">
|
</Measure>
|
||||||
Judgement detail
|
|
||||||
</RowLabel>
|
<Measure
|
||||||
|
tip="Older-style inspections: one rating per judgement area, where published. New-style inspections: the full report card, one rating per area of school life."
|
||||||
|
label="Judgement detail"
|
||||||
|
>
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const ofsted = data[String(school.urn)]?.ofsted;
|
const ofsted = data[String(school.urn)]?.ofsted;
|
||||||
return (
|
return (
|
||||||
@@ -196,9 +200,12 @@ export function CompareOfsted({
|
|||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
|
||||||
<RowLabel tip="Links to the school's page on ofsted.gov.uk, where all its inspection reports are listed.">
|
</Measure>
|
||||||
Ofsted page
|
|
||||||
</RowLabel>
|
<Measure
|
||||||
|
tip="Links to the school's page on ofsted.gov.uk, where all its inspection reports are listed."
|
||||||
|
label="Ofsted page"
|
||||||
|
>
|
||||||
{schools.map((school, i) => {
|
{schools.map((school, i) => {
|
||||||
const url =
|
const url =
|
||||||
data[String(school.urn)]?.ofsted?.ofsted_page_url ??
|
data[String(school.urn)]?.ofsted?.ofsted_page_url ??
|
||||||
@@ -211,6 +218,7 @@ export function CompareOfsted({
|
|||||||
</Cell>
|
</Cell>
|
||||||
);
|
);
|
||||||
})}
|
})}
|
||||||
|
</Measure>
|
||||||
</SectionGrid>
|
</SectionGrid>
|
||||||
</Section>
|
</Section>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -60,37 +60,18 @@
|
|||||||
margin: 0 0 1rem;
|
margin: 0 0 1rem;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* ComparisonChart runs Chart.js with maintainAspectRatio:false, so it fills
|
||||||
|
its container's height — which must be *definite*. A min-height alone does
|
||||||
|
not resolve the chart wrapper's height:100%, leaving Chart.js to fall back
|
||||||
|
to its ~150px default (a squashed sliver). Give it a real height. */
|
||||||
.chartBox {
|
.chartBox {
|
||||||
min-height: 320px;
|
height: 420px;
|
||||||
}
|
}
|
||||||
|
|
||||||
.tableWrapper {
|
@media (max-width: 640px) {
|
||||||
overflow-x: auto;
|
/* Taller on mobile: the mobile-only school chips sit above the canvas and
|
||||||
margin-top: 1.5rem;
|
wrap to two rows for 3+ schools, so the plot keeps a usable height. */
|
||||||
|
.chartBox {
|
||||||
|
height: 360px;
|
||||||
}
|
}
|
||||||
|
|
||||||
.table {
|
|
||||||
width: 100%;
|
|
||||||
border-collapse: collapse;
|
|
||||||
font-size: 0.9rem;
|
|
||||||
}
|
|
||||||
|
|
||||||
.table th,
|
|
||||||
.table td {
|
|
||||||
text-align: left;
|
|
||||||
padding: 0.6rem 0.75rem;
|
|
||||||
border-bottom: 1px solid var(--border-light);
|
|
||||||
}
|
|
||||||
|
|
||||||
.table th {
|
|
||||||
background: var(--bg-secondary);
|
|
||||||
font-size: 0.8rem;
|
|
||||||
text-transform: uppercase;
|
|
||||||
letter-spacing: 0.03em;
|
|
||||||
color: var(--text-secondary);
|
|
||||||
}
|
|
||||||
|
|
||||||
.yearCell {
|
|
||||||
font-weight: 600;
|
|
||||||
white-space: nowrap;
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,19 +1,17 @@
|
|||||||
/**
|
/**
|
||||||
* Explore trends — the full grouped metric catalogue (nothing from the old
|
* Explore trends — the full grouped metric catalogue (nothing from the old
|
||||||
* compare page is lost; spec §4's tier 3) driving the year-by-year chart
|
* compare page is lost; spec §4's tier 3) driving the year-by-year chart with
|
||||||
* with its England reference line, plus the year-by-year table. Progress
|
* its England reference line. Matches the mockup: a measure picker and the
|
||||||
* metrics carry CI-based bands for the years DfE published them.
|
* chart only (no data table).
|
||||||
*/
|
*/
|
||||||
|
|
||||||
'use client';
|
'use client';
|
||||||
|
|
||||||
import dynamic from 'next/dynamic';
|
import dynamic from 'next/dynamic';
|
||||||
|
|
||||||
import { progressBand } from '@/lib/compareLogic';
|
|
||||||
import type { ComparisonData, MetricDefinition, NationalAverages, School } from '@/lib/types';
|
import type { ComparisonData, MetricDefinition, NationalAverages, School } from '@/lib/types';
|
||||||
import { formatAcademicYear, formatMetricValue, metricKind } from '@/lib/utils';
|
|
||||||
import { track } from '@/lib/analytics';
|
import { track } from '@/lib/analytics';
|
||||||
import { Chip, Section, sectionStyles as s } from './sectionShared';
|
import { Section } from './sectionShared';
|
||||||
import styles from './TrendsExplorer.module.css';
|
import styles from './TrendsExplorer.module.css';
|
||||||
|
|
||||||
const ComparisonChart = dynamic(
|
const ComparisonChart = dynamic(
|
||||||
@@ -40,14 +38,6 @@ const SECONDARY_OPTGROUPS: { label: string; category: string }[] = [
|
|||||||
export const PRIMARY_CATEGORIES = PRIMARY_OPTGROUPS.map((g) => g.category);
|
export const PRIMARY_CATEGORIES = PRIMARY_OPTGROUPS.map((g) => g.category);
|
||||||
export const SECONDARY_CATEGORIES = SECONDARY_OPTGROUPS.map((g) => g.category);
|
export const SECONDARY_CATEGORIES = SECONDARY_OPTGROUPS.map((g) => g.category);
|
||||||
|
|
||||||
const PROGRESS_CI: Record<string, [string, string]> = {
|
|
||||||
reading_progress: ['reading_progress_lower_ci', 'reading_progress_upper_ci'],
|
|
||||||
writing_progress: ['writing_progress_lower_ci', 'writing_progress_upper_ci'],
|
|
||||||
maths_progress: ['maths_progress_lower_ci', 'maths_progress_upper_ci'],
|
|
||||||
};
|
|
||||||
|
|
||||||
const BAND_LABEL = { above: 'Above average', average: 'Average', below: 'Below average' } as const;
|
|
||||||
|
|
||||||
export function TrendsExplorer({
|
export function TrendsExplorer({
|
||||||
schools,
|
schools,
|
||||||
data,
|
data,
|
||||||
@@ -78,21 +68,11 @@ export function TrendsExplorer({
|
|||||||
nationalByYear[entry.year] = block?.[metric] ?? null;
|
nationalByYear[entry.year] = block?.[metric] ?? null;
|
||||||
}
|
}
|
||||||
|
|
||||||
const years = [
|
|
||||||
...new Set(
|
|
||||||
schools.flatMap(
|
|
||||||
(school) => data[String(school.urn)]?.yearly_data.map((d) => Math.trunc(d.year)) ?? [],
|
|
||||||
),
|
|
||||||
),
|
|
||||||
].sort((a, b) => a - b);
|
|
||||||
|
|
||||||
const handleMetricChange = (next: string) => {
|
const handleMetricChange = (next: string) => {
|
||||||
track('compare_metric_changed', { metric: next, phase: isPrimaryPhase ? 'primary' : 'secondary' });
|
track('compare_metric_changed', { metric: next, phase: isPrimaryPhase ? 'primary' : 'secondary' });
|
||||||
onMetricChange(next);
|
onMetricChange(next);
|
||||||
};
|
};
|
||||||
|
|
||||||
const ciKeys = PROGRESS_CI[metric];
|
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<Section
|
<Section
|
||||||
title="Explore trends"
|
title="Explore trends"
|
||||||
@@ -128,8 +108,7 @@ export function TrendsExplorer({
|
|||||||
{metric.includes('progress') && (
|
{metric.includes('progress') && (
|
||||||
<p className={styles.progressNote}>
|
<p className={styles.progressNote}>
|
||||||
Progress scores measure pupils' progress from KS1 to KS2. A score of 0 equals the
|
Progress scores measure pupils' progress from KS1 to KS2. A score of 0 equals the
|
||||||
national average. DfE stopped publishing KS2 progress after 2022/23 (no KS1 baseline);
|
national average. DfE stopped publishing KS2 progress after 2022/23 (no KS1 baseline).
|
||||||
bands use DfE's confidence intervals, not the raw score alone.
|
|
||||||
</p>
|
</p>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
@@ -142,52 +121,6 @@ export function TrendsExplorer({
|
|||||||
nationalByYear={nationalByYear}
|
nationalByYear={nationalByYear}
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
|
|
||||||
{years.length > 0 && (
|
|
||||||
<div className={styles.tableWrapper}>
|
|
||||||
<table className={styles.table}>
|
|
||||||
<thead>
|
|
||||||
<tr>
|
|
||||||
<th>Year</th>
|
|
||||||
{schools.map((school) => (
|
|
||||||
<th key={school.urn}>{school.school_name}</th>
|
|
||||||
))}
|
|
||||||
</tr>
|
|
||||||
</thead>
|
|
||||||
<tbody>
|
|
||||||
{years.map((year) => (
|
|
||||||
<tr key={year}>
|
|
||||||
<td className={styles.yearCell}>{formatAcademicYear(year)}</td>
|
|
||||||
{schools.map((school) => {
|
|
||||||
const row = data[String(school.urn)]?.yearly_data.find(
|
|
||||||
(d) => Math.trunc(d.year) === year,
|
|
||||||
) as (Record<string, unknown> & { year: number }) | undefined;
|
|
||||||
const value = row?.[metric];
|
|
||||||
if (typeof value !== 'number') return <td key={school.urn}>–</td>;
|
|
||||||
const band = ciKeys
|
|
||||||
? progressBand(
|
|
||||||
value,
|
|
||||||
(row?.[ciKeys[0]] as number | null) ?? null,
|
|
||||||
(row?.[ciKeys[1]] as number | null) ?? null,
|
|
||||||
)
|
|
||||||
: null;
|
|
||||||
return (
|
|
||||||
<td key={school.urn}>
|
|
||||||
{formatMetricValue(value, metricKind(metric))}{' '}
|
|
||||||
{band && (
|
|
||||||
<Chip tone={band === 'above' ? 'good' : band === 'below' ? 'warn' : 'neutral'}>
|
|
||||||
{BAND_LABEL[band]}
|
|
||||||
</Chip>
|
|
||||||
)}
|
|
||||||
</td>
|
|
||||||
);
|
|
||||||
})}
|
|
||||||
</tr>
|
|
||||||
))}
|
|
||||||
</tbody>
|
|
||||||
</table>
|
|
||||||
</div>
|
|
||||||
)}
|
|
||||||
</div>
|
</div>
|
||||||
</details>
|
</details>
|
||||||
</Section>
|
</Section>
|
||||||
|
|||||||
@@ -31,43 +31,73 @@
|
|||||||
margin-top: 1.25rem;
|
margin-top: 1.25rem;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Mobile base: each measure is a card; each cell is a school row led by a
|
||||||
|
colour dot + short name. `display: contents` at ≥761px dissolves the card
|
||||||
|
back into the shared grid. */
|
||||||
|
.measure {
|
||||||
|
background: var(--bg-card);
|
||||||
|
border: 1px solid var(--border-light);
|
||||||
|
border-radius: 12px;
|
||||||
|
box-shadow: var(--shadow-soft);
|
||||||
|
padding: 0.75rem 0.85rem;
|
||||||
|
margin-bottom: 0.6rem;
|
||||||
|
}
|
||||||
|
|
||||||
.rowLabel {
|
.rowLabel {
|
||||||
font-size: 0.85rem;
|
font-size: 0.85rem;
|
||||||
font-weight: 600;
|
font-weight: 600;
|
||||||
color: var(--text-secondary);
|
color: var(--text-primary);
|
||||||
display: flex;
|
display: flex;
|
||||||
align-items: center;
|
align-items: center;
|
||||||
gap: 0.35rem;
|
gap: 0.35rem;
|
||||||
background: var(--bg-secondary);
|
padding: 0 0 0.1rem;
|
||||||
border-radius: 6px;
|
|
||||||
padding: 0.4rem 0.6rem;
|
|
||||||
margin-top: 0.8rem;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
.cell {
|
.cell {
|
||||||
padding: 0.4rem 0.6rem;
|
display: flex;
|
||||||
|
align-items: baseline;
|
||||||
|
gap: 0.35rem 0.5rem;
|
||||||
|
flex-wrap: wrap;
|
||||||
|
padding: 0.5rem 0;
|
||||||
|
border-top: 1px solid var(--border-light);
|
||||||
|
margin-top: 0.5rem;
|
||||||
font-size: 0.95rem;
|
font-size: 0.95rem;
|
||||||
}
|
}
|
||||||
|
|
||||||
.cell::before {
|
/* The school name gets its own full-width line above the value — real
|
||||||
content: attr(data-school);
|
school names are long and varied, so a fixed-width name column truncated
|
||||||
display: block;
|
them ("Our Lady Queen of H…") or crowded the value. */
|
||||||
font-size: 0.72rem;
|
.cellTag {
|
||||||
|
display: inline-flex;
|
||||||
|
align-items: center;
|
||||||
|
gap: 0.4rem;
|
||||||
|
flex-basis: 100%;
|
||||||
|
font-size: 0.8rem;
|
||||||
font-weight: 600;
|
font-weight: 600;
|
||||||
color: var(--sc, var(--text-muted));
|
color: var(--sc, var(--text-secondary));
|
||||||
|
margin-bottom: 0.15rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.cellDot {
|
||||||
|
width: 9px;
|
||||||
|
height: 9px;
|
||||||
|
border-radius: 50%;
|
||||||
|
background: var(--dot, var(--text-muted));
|
||||||
|
flex: none;
|
||||||
}
|
}
|
||||||
|
|
||||||
.big {
|
.big {
|
||||||
font-size: 1.35rem;
|
font-size: 1.05rem;
|
||||||
font-weight: 700;
|
font-weight: 700;
|
||||||
font-variant-numeric: tabular-nums;
|
font-variant-numeric: tabular-nums;
|
||||||
}
|
}
|
||||||
|
|
||||||
.small {
|
.small {
|
||||||
display: block;
|
display: block;
|
||||||
|
flex-basis: 100%;
|
||||||
font-size: 0.8rem;
|
font-size: 0.8rem;
|
||||||
color: var(--text-muted);
|
color: var(--text-muted);
|
||||||
margin-top: 0.1rem;
|
margin-top: 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
.chip {
|
.chip {
|
||||||
@@ -159,6 +189,7 @@
|
|||||||
display: flex;
|
display: flex;
|
||||||
gap: 0.3rem;
|
gap: 0.3rem;
|
||||||
flex-wrap: wrap;
|
flex-wrap: wrap;
|
||||||
|
flex-basis: 100%;
|
||||||
margin-top: 0.3rem;
|
margin-top: 0.3rem;
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -197,20 +228,37 @@
|
|||||||
gap: 0 0.75rem;
|
gap: 0 0.75rem;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* Dissolve the per-measure card so its label + cells become grid items of
|
||||||
|
.grid, keeping columns aligned across every measure. */
|
||||||
|
.measure {
|
||||||
|
display: contents;
|
||||||
|
}
|
||||||
|
|
||||||
|
.cellTag {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
.rowLabel {
|
.rowLabel {
|
||||||
background: none;
|
color: var(--text-secondary);
|
||||||
border-radius: 0;
|
|
||||||
margin-top: 0;
|
|
||||||
padding: 0.85rem 0.5rem 0.85rem 0;
|
padding: 0.85rem 0.5rem 0.85rem 0;
|
||||||
border-bottom: 1px solid var(--border-light);
|
border-bottom: 1px solid var(--border-light);
|
||||||
}
|
}
|
||||||
|
|
||||||
.cell {
|
.cell {
|
||||||
|
display: block;
|
||||||
padding: 0.85rem 0.25rem;
|
padding: 0.85rem 0.25rem;
|
||||||
|
border-top: none;
|
||||||
border-bottom: 1px solid var(--border-light);
|
border-bottom: 1px solid var(--border-light);
|
||||||
|
margin-top: 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
.cell::before {
|
.big {
|
||||||
content: none;
|
font-size: 1.35rem;
|
||||||
|
}
|
||||||
|
|
||||||
|
.small {
|
||||||
|
flex-basis: auto;
|
||||||
|
padding-left: 0;
|
||||||
|
margin-top: 0.1rem;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -10,7 +10,7 @@
|
|||||||
import type { CSSProperties, ReactNode } from 'react';
|
import type { CSSProperties, ReactNode } from 'react';
|
||||||
|
|
||||||
import type { School } from '@/lib/types';
|
import type { School } from '@/lib/types';
|
||||||
import { CHART_TEXT_COLORS } from '@/lib/utils';
|
import { CHART_COLORS, CHART_TEXT_COLORS, shortName } from '@/lib/utils';
|
||||||
import styles from './compareSections.module.css';
|
import styles from './compareSections.module.css';
|
||||||
|
|
||||||
export function Section({
|
export function Section({
|
||||||
@@ -61,6 +61,29 @@ export function RowLabel({ children, tip }: { children: ReactNode; tip?: string
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* One measure = its row label plus a cell per school. `display: contents` on
|
||||||
|
* desktop (see CSS) makes these flow into the section grid as if this wrapper
|
||||||
|
* weren't here, keeping columns aligned across measures; on mobile the wrapper
|
||||||
|
* becomes a card so each measure reads as its own block.
|
||||||
|
*/
|
||||||
|
export function Measure({
|
||||||
|
label,
|
||||||
|
tip,
|
||||||
|
children,
|
||||||
|
}: {
|
||||||
|
label: ReactNode;
|
||||||
|
tip?: string;
|
||||||
|
children: ReactNode;
|
||||||
|
}) {
|
||||||
|
return (
|
||||||
|
<div className={styles.measure}>
|
||||||
|
<RowLabel tip={tip}>{label}</RowLabel>
|
||||||
|
{children}
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
export function Cell({
|
export function Cell({
|
||||||
school,
|
school,
|
||||||
index,
|
index,
|
||||||
@@ -73,9 +96,19 @@ export function Cell({
|
|||||||
return (
|
return (
|
||||||
<div
|
<div
|
||||||
className={styles.cell}
|
className={styles.cell}
|
||||||
data-school={school.school_name}
|
style={
|
||||||
style={{ '--sc': CHART_TEXT_COLORS[index % CHART_TEXT_COLORS.length] } as CSSProperties}
|
{
|
||||||
|
'--sc': CHART_TEXT_COLORS[index % CHART_TEXT_COLORS.length],
|
||||||
|
'--dot': CHART_COLORS[index % CHART_COLORS.length],
|
||||||
|
} as CSSProperties
|
||||||
|
}
|
||||||
>
|
>
|
||||||
|
{/* Mobile-only per-school tag (dot + short name); hidden on desktop,
|
||||||
|
where the column header identifies the school. */}
|
||||||
|
<span className={styles.cellTag}>
|
||||||
|
<span className={styles.cellDot} aria-hidden="true" />
|
||||||
|
{shortName(school.school_name)}
|
||||||
|
</span>
|
||||||
{children}
|
{children}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -59,6 +59,24 @@ export function truncate(text: string, maxLength: number): string {
|
|||||||
return text.slice(0, maxLength).trim() + '...';
|
return text.slice(0, maxLength).trim() + '...';
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* A compact school label for tight spaces (mobile compare rows, chip bars):
|
||||||
|
* drop the trailing establishment-type words so "Barclay Primary School" →
|
||||||
|
* "Barclay", "St Mary's Catholic Primary School" → "St Mary's". Falls back to
|
||||||
|
* a length-capped truncation for names that don't carry a type suffix.
|
||||||
|
*/
|
||||||
|
export function shortName(name: string, maxLength = 32): string {
|
||||||
|
let s = name
|
||||||
|
.replace(
|
||||||
|
/\s+(primary|junior|infant|nursery|community|foundation|catholic|academy|school|college)\b.*$/i,
|
||||||
|
'',
|
||||||
|
)
|
||||||
|
.trim();
|
||||||
|
if (!s) s = name;
|
||||||
|
if (s.length > maxLength) s = s.slice(0, maxLength - 1).trim() + '…';
|
||||||
|
return s;
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Format a school's age range for display, e.g. "3-11" → "Ages 3–11".
|
* Format a school's age range for display, e.g. "3-11" → "Ages 3–11".
|
||||||
* Display-only — leaves the raw `age_range` field (used for sixth-form
|
* Display-only — leaves the raw `age_range` field (used for sixth-form
|
||||||
|
|||||||
Reference in New Issue
Block a user