Compare commits

..
1 Commits
Author SHA1 Message Date
TudorandClaude Fable 5 d52d384cf2 fix(school): make hero map fullscreen work on iOS Safari
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m39s
PR Checks / Backend Smoke (pull_request) Successful in 5s
PR Checks / Build Backend (no push) (pull_request) Successful in 10s
PR Checks / Build Frontend (no push) (pull_request) Successful in 47s
PR Checks / Build Pipeline (no push) (pull_request) Successful in 9s
PR Checks / AI Code Review (Claude) (pull_request) Successful in 4m15s
iOS Safari has no Element.requestFullscreen (fullscreen is video-only),
so tapping the map band or 'View on map' silently did nothing on
iPhones. Fall back to a fixed-position CSS overlay driven by state when
the Fullscreen API is missing or its promise rejects, locking body
scroll while open. The Leaflet map already re-measures via the shared
isFullscreen flag. New e2e journey simulates the iOS condition by
deleting the API and asserts the overlay opens and closes; it fails
against the current production build.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
2026-07-05 21:34:22 +01:00
2 changed files with 1 additions and 47 deletions
-28
View File
@@ -1,28 +0,0 @@
# TEMPORARY diagnostic workflow — delete after the rankings year= bug is closed.
name: Staging Rankings Diagnostic
on:
push:
branches:
- diag/staging-rankings-year
jobs:
staging-api-diagnostic:
name: Staging rankings year diagnostic
runs-on: ubuntu-latest
steps:
- name: Probe staging rankings year handling
env:
BASE: ${{ secrets.STAGING_BASE_URL }}
run: |
probe() {
echo "== $1 =="
curl -s --max-time 15 -D /tmp/h.txt -o /tmp/b.txt "$BASE$1"
echo "--- headers:"; cat /tmp/h.txt
echo "--- body (first 400 bytes):"; head -c 400 /tmp/b.txt; echo
}
probe "/api/data-info"
probe "/api/filters"
probe "/api/rankings?metric=rwm_expected_pct&limit=3"
probe "/api/rankings?metric=rwm_expected_pct&limit=3&year=202425"
probe "/"
+1 -19
View File
@@ -12,25 +12,7 @@ env:
PIPELINE_IMAGE_NAME: ${{ gitea.repository }}-pipeline
jobs:
# TEMPORARY: evidence gathering for the rankings year= empty-list bug on
# staging. Remove before merging. Prints status codes and row counts only.
staging-api-diagnostic:
name: Staging rankings year diagnostic
runs-on: ubuntu-latest
steps:
- name: Probe staging rankings year handling
env:
BASE: ${{ secrets.STAGING_BASE_URL }}
run: |
echo "== /api/filters years =="
curl -s --max-time 15 "$BASE/api/filters" -o /tmp/f.json -w "status %{http_code}\n"
python3 -c "import json; print(json.load(open('/tmp/f.json')).get('years'))" || head -c 300 /tmp/f.json
echo "== /api/rankings probes (metric=rwm_expected_pct, limit=3) =="
for Q in "" "&year=202425" "&year=201819" "&year=2024"; do
CODE=$(curl -s --max-time 15 -o /tmp/r.json -w "%{http_code}" "$BASE/api/rankings?metric=rwm_expected_pct&limit=3$Q")
echo "query [$Q] -> status $CODE"
python3 -c "import json; d=json.load(open('/tmp/r.json')); print(' year:', d.get('year'), 'total:', d.get('total'), 'rows:', len(d.get('rankings', [])))" || head -c 300 /tmp/r.json
done
frontend-checks:
name: Frontend Typecheck + Tests
runs-on: ubuntu-latest
steps: