18 Commits

Include renames

Author	SHA1	Message	Date
TudorandClaude Opus 5	6fc7fce948	feat(flags): put /about and /blog behind flags, dark by default ... Both features ship dark. Neither is reachable in an environment where its flag is off, and every flag in this system starts off, so a deploy of this commit makes both disappear until someone turns them on deliberately. Two independent flags rather than one, which makes blog-on-about-off a reachable state. That state is the whole reason the change is larger than four notFound() calls: the blog leans on the About page for its author identity. The Person entity is anchored at /about#tudor, and that URL 404s while about_page is dark, so a post published in that state would claim an author resolving to nothing. Worse than having no named author. Both bylines fall back to unlinked text and the BlogPosting attributes to the publisher instead, so every combination of the two flags renders something correct. Gated: /about, /blog, /blog/[slug], the RSS feed, both footer links, and the matching content-sitemap entries. A sitemap must never advertise a URL that 404s. With both dark it emits a valid empty urlset rather than a 404, because robots.txt names it unconditionally. Not gated: /admin. Posts have to be writable before the blog is worth switching on, so flagging the panel would make the flag unflippable. getFlags takes a revalidate rather than always using the 300s constant. Reading a flag pins the calling route to the lowest revalidate among its fetches, and the footer links live in the root layout, so a naive gate there would have dropped every school and place page from a weekly cache to a 5-minute one. The layout passes 604800, the floor those routes already declare, and the build confirms all four SSG route families still prerender. The cost is one-way latency: pages follow a flip in minutes, footer links within a week. The e2e journeys follow the existing paired shape from the admission_distance flag: a lit journey and a dark one for each flag, reading state from whether /about and /blog respond rather than from /api/flags, which another journey asserts is not publicly reachable. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DXnXQKnPpZBBP61fBQiFkq	2026-09-08 17:12:25 +01:00
TudorandClaude Opus 5	f614414070	feat(about): give the site a named author ... The site had no author, no statement of why it exists and nobody accountable for its numbers, which is most of why it reads as machine generated. The page states plainly that its author is not an education expert. The credibility claim is lived experience — a parent going through primary admissions — plus stated provenance for every figure, which is true and cannot be undermined by someone noticing there is no teaching qualification behind it. First name only: the Person JSON-LD carries no familyName, worksFor or affiliation, and a test asserts it stays that way. The footer gains a fourth column, with a tablet breakpoint so four columns pair up rather than crushing before the 768px collapse. The nav is deliberately untouched — its mobile tab bar already carries four items. public/brand/tudor.jpg is NOT in this commit. The page references it and will show a broken image until the photograph is supplied; a stock portrait would defeat the entire point of the work. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017YmbBhr8s7GusjDE12hrZM	2026-09-02 16:22:52 +01:00
TudorandClaude Opus 5	4043270a77	fix(home): stop implying we are official, and fix the mobile hero and search ... Three things, all reported from the live mobile view. WE ARE NOT AN OFFICIAL SERVICE The value prop read "Official & trusted", whose grammatical subject is this site — it reads as a claim that schoolcompare is an official service. It is not; it is an independent site that republishes official figures. Now "Built on official data", which describes the data instead. Checked every other use of the word: all nine describe the data ("official DfE figures", "the official figure isn't in") and are correct as they stand. That one title was the only place the site described itself. The footer now says it outright — "An independent site. Not affiliated with the Department for Education or Ofsted." — so it appears on every page rather than being left to inference. An e2e test asserts both halves: that the statement is present, and that no text presents the site itself as official. The disclaimer first measured 4.71:1 against a 4.5 floor. That is a fine margin for decoration and the wrong one for a line whose job is to be legible to someone checking whether this is a government site; it is now 5.59:1, quieter than the copy around it by size rather than by contrast. THE ARTWORK SAT UNDER THE SEARCH ON PHONES The DOM keeps .heroContent first so the desktop overlay does not depend on source order, which left the band stranded at the bottom of the panel, reading as a strip stuck on the end rather than a hero image. `order` moves it above the copy on phones; it is decorative and aria-hidden, so no reading order changes. Measured on a 667px viewport — the shortest phone still in use — the search button lands at 418px, comfortably inside the fold. THE SEARCH INPUT WAS UNUSABLE ON PHONES "Search schools" is a fixed 134px with white-space: nowrap, so it took 48% of the row. Measured on staging: 390px input text space 102px placeholder needs 194px 360px 72px 320px 32px At 320px you could not see what you were typing. The button now wraps to its own full-width row below 480px, which fixes 360px and up — 390px goes from 102px to 226px of text space. The pill stays a single element, so it keeps its border, shadow and :focus-within ring, and the button gains a full-width tap target. 320px is still ~30px short. Closing it needs a shorter placeholder, which three other tests match on by exact string; left alone deliberately rather than churn them for a width that is effectively gone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-14 22:59:12 +01:00
TudorandClaude Opus 5	dc22fd2853	fix(home): correct what the landing page claims, and give it one rhythm ... The homepage made four statements that were not true, carried elements that asked nothing of anyone, and had a hero illustration that broke in both the places it had to work. Claims, all verified against the code or the API: * "24,000+ schools" (three places) against a real 27,230. The fact box meant to show the live figure rendered its own fallback on every request, because DataInfoResponse declared a `total_schools` field the API has never sent — it sends `unique_schools`. The fetch succeeded; only that field was undefined, so nothing threw and nothing failed. The interface, not the code, was the thing that was wrong. * "Up to three schools side by side" against MAX_SCHOOLS = 5, contradicting a card 400px below it that correctly said five. * "Class sizes" — data the codebase has never held. That copy line was the only hit in a full-repo grep. * Invented results and Ofsted grades attributed to two real, named schools in the compare preview. Also one feature, three words: Compare (nav), shortlist (footer), pin (cards). Settled on Compare everywhere. And <title> was the bare string "Home". Cut: the trust line (repeated the coverage figure one paragraph after the hero gave it, behind three decorative dots), the "Start exploring" row (three links to two destinations already in the nav), the six-row coverage table, and three of the four countdown cards — which gave the page's largest numeral to dates up to 245 days away, two of them offer days, which cannot be missed. All four dates remain, at proportionate weight. Value-prop titles drop from <h2> to <p>; they were outranking the page's real headings in the document outline. Rhythm: the gaps between the seven landing bands were 24/32/24/16/48/32/16px, each band setting its own margin, with four different section-header treatments between them. The page container now owns one gap, and there is one header pattern. An e2e test asserts the gaps are identical. Illustration: it kept a fixed light palette in both themes, which left a pale sky slab as the brightest object on a near-black page, out-shouting the H1 and the search box. It now reads from --ill-* tokens with a dark re-grade. And the hero slot ranges from 1.34:1 to 4.9:1 across breakpoints, which no single composition survives under `slice` — at 860x176 a 540x520 scene shows only its bottom 110 units, so the schoolhouse was cropped away entirely on phones, leaving hills and a pin pointing at nothing. There are now two compositions, each drawn against the crop window its own breakpoint produces, with CSS showing one. Both are static server-rendered SVG. The deadline bar renders on the server rather than on hydrate. The effect-based version needed a reserved height, and one guessed number cannot cover a block whose supporting line wraps differently at every width — measured, it was short at all four, shifting the page up to 108px on a phone. Verified on the built output through an offline render harness (no local server): real compiled CSS, real rendered markup, four widths, both themes. tsc clean, 159/159 unit tests, build green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-14 17:29:47 +01:00
Tudor	b11ee3c8de	feat(brand): use the supplied logo artwork instead of a reconstruction ... The mark shipped so far was my SVG approximation, and it was wrong: the real mark is a teardrop pin with a white window and a path flowing out of its base, carrying three leaves — not a circle with a separate tail. Both colourways are extracted from the supplied sheet, which has a genuinely transparent background, so these are the artwork rather than a trace: public/brand/mark.png teal pin, white window and path, green leaves public/brand/mark-on-dark.png white pin with the counter knocked through Two colourways are needed, not one. Rendered against every real ground, the teal pin holds up on Warm White, white cards, Sand and both dark-theme grounds — but it vanishes on the teal footer band, where only the white window survives. The header therefore serves the teal artwork and swaps to the on-dark artwork for dark-theme viewers through a <picture> source, needing no JavaScript; the footer forces on-dark, because its band is teal in both themes. Everything downstream now derives from those two files: the favicon (app/icon.png, replacing icon.svg), the touch icon (app/apple-icon.png, replacing the generated apple-icon.tsx), the three PWA rasters, and the share card, which reads public/brand/mark.png off disk so it can never drift from the header. The logo sizing CSS keyed off a square box, which would have squashed a 153:189 artwork — height now drives and width follows. The wordmark stays live text in Manrope. The sheet's wordmark is a raster with visible edge fringing, and the written style guide specifies Manrope; live text also stays selectable, scales cleanly and recolours with the theme. KNOWN LIMITATION: the largest instance on the sheet is 153×189. That is ample for the header at 38px, the favicon and the share card, but short of the 512px PWA icon, which is upscaled and slightly soft. A vector would fix it and is a single swap — every consumer goes through components/Logo.tsx or public/brand. Verified: tsc clean, 159/159 tests, build green, /icon.png and /apple-icon.png emit as static routes, and the header, footer, share card and all five icons were rendered and inspected in both themes.	2026-08-08 22:22:58 +01:00
Tudor	39e5c11274	fix(brand): match the below-average tint to its own hue, and finish the casing ... Three review findings. --status-below-bg carried the raw --coral tuple (249,115,96) instead of the hue it belongs to (#A9481F → 169,72,31), so "below average" chips rendered a coral-pink wash behind terracotta text — the one solid/tint pair in the file whose hues disagreed. Alpha drops 0.15 → 0.12 to match --status-above-bg, so the two chips read as equal weight; left at 0.15 the darker terracotta tint takes the label to 4.45:1 on Warm White, under the 4.5 floor. At 0.12 it is 4.86:1 on cards and 4.67:1 on Warm White. Auditing the whole file for the same class of error turned up one more: --action-bg was also a --coral tint while --action is the darkened #BE3C27. It is unused today and the dark-theme value was already correct, but it is aligned so a future coral ghost button gets a matching label and ground. The five phase pairs also "mismatch" by the same test and are deliberately left alone: those pair a pastel ground (sage, sky, mustard, lavender) with a deeper text hue, which is exactly what the guideline's Chips/Tags show. The lowercase wordmark had only reached the visual chrome. Every user-visible occurrence now matches: page title and template, appleWebApp title, authors, OpenGraph and Twitter titles and siteName, the school page's siteName, the PWA manifest name and short_name, the footer copyright line, the nav's aria-label, the Web Share API strings, and the editorial paragraph. Comments in lib/*.ts and AdmissionsView still say "SchoolCompare"; they describe the codebase rather than the mark, so they are left to keep this diff to the reported problem. The comment explaining why the font classes belong on <html> still described --font-schibsted, which no longer exists. It now names --font-manrope and --font-inter, and records that the e2e typeface assertion is the only guard — this failure mode throws nothing and fails no unit test. Verified: tsc clean, 159/159 tests, build green, and the rendered title is now "School Admissions Guide | schoolcompare". Status and phase labels re-checked on their own composited tints over both light grounds — all clear AA.	2026-08-07 18:33:30 +01:00
Tudor	accc562b90	feat(brand): adopt the schoolcompare identity across the site ... Implements the supplied brand guideline: the pin-and-leaf mark, the lowercase schoolcompare wordmark, Manrope for headings and Inter for everything a person reads a number from, the deep-teal/coral/mustard/sage palette, and the rounder geometry the guideline asks for. The landing hero is rebuilt to the concept: a Sand panel carrying the proposition, the search and a trust line, with the brand landscape bleeding to the panel's right edge, followed by the four value props. Concept vs reality — where the guideline describes something this product does not have, the real feature takes its place and the decision is recorded in a code comment next to it: - The Thriving Score is not implemented. Four of its five sub-scores (pastoral, enrichment, community, facilities) have no source in DfE or Ofsted data, and its band names are Ofsted's own, which would sit beside the real Ofsted grade and be indistinguishable from it. - Guides, About, Favourites and Sign in are not added to the nav — there are no such pages and no accounts system. Rankings and Admissions, which the guideline omits, keep their places because they exist. - The fourth value prop is "Never miss a deadline" rather than "Save & revisit", which would need shortlisting. Two deviations from the supplied swatches, both forced by contrast and both confined to text and fills. Coral #F97360 under a white label measures 2.75:1 against a 4.5 floor, so --action is a darkened #BE3C27 and the original coral survives as --coral for tints, borders and illustration. Mustard #F2C94C is 1.5:1 as text, so --mustard-ink carries labels while --mustard stays exact for fills and rings. Every token clears AA on all three light grounds; Sand is the binding one, so several values sit a step darker than white alone would need. The guideline is light-only, but the site already ships a dark theme, so it is rebuilt from the same tokens rather than dropped. Verified: tsc clean, 159/159 unit tests, production build green, and the generated share card and app icon render from the new mark. The hero and the site chrome were rendered from the compiled CSS and the prerendered markup to confirm Manrope and Inter actually resolve — a font token that silently falls back has shipped here before.	2026-08-07 18:05:49 +01:00
TudorandClaude Opus 4.8	794c27f6b6	feat(footer): add contact email link ... No contact route existed anywhere on the site. Add a contact@schoolcompare.co.uk mailto link in the footer brand column. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-01 22:30:04 +01:00
Tudor SitaruandClaude Opus 4.7	7e182e88b2	feat(analytics): typed Umami event taxonomy across the funnel ... Add lib/analytics.ts with a single typed track() wrapper. SSR-safe, never throws, no-ops when Umami isn't loaded. Event names form a fixed union so refactors stay safe. 14 events wired: Discovery (3) search_submitted FilterBar submit + near_me path near_me_used all geolocation outcomes empty_results search returns 0 schools Engagement (5) school_viewed SchoolDetail + Secondary on mount, with urn / phase / local_authority / from section_nav_used section-nav links on both detail views chart_metric_changed mobile chart chip switch metric_compared_in_rankings rankings metric dropdown external_link_clicked Ofsted / school website / DfE (declarative data-umami-event attributes) Conversion (5) compare_school_added search/rankings/detail/compare sources compare_school_removed detail toggle and compare page compare_viewed once per session when there's a selection (school_count, phase_mix) compare_metric_changed compare page metric dropdown compare_shared native sheet vs clipboard distinguished Operational (1) api_error caught in handleResponse, includes endpoint / status / route Suggested Goals to configure in the Umami dashboard for the funnel report: search_submitted → school_viewed → compare_school_added → compare_viewed → compare_shared. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-19 22:04:22 +01:00
Tudor SitaruandClaude Sonnet 4.6	f6b9d650f8	feat(admissions): add admissions guide page and homepage countdown strip ... - New /admissions route with AdmissionsView client component - Live countdowns (days until) to Primary/Secondary deadlines and Offer Days - Step-by-step timelines for both tracks with highlighted milestone rows - Tips section covering equal preference rule, late applications, waiting lists - Homepage countdown strip (4 cards) between discovery chips and how-it-works - Admissions nav link and footer link added Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-15 17:00:21 +01:00
Tudor SitaruandClaude Opus 4.6	ac2d64caaf	feat(home): implement redesigned homepage ... - Hero: Playfair heading with coral italic accent, teal eyebrow pill, richer sub-copy describing both primary and secondary coverage - Discovery: geolocation "Schools near me" button (reverse-geocodes via postcodes.io → /?postcode=…&radius=1), plus Start exploring chips linking to /rankings and /compare - How it works: 3-card grid showing miniature real-UI previews for Performance (primary SATs cascade + secondary Att8 bar), Ofsted inspection card, and side-by-side Compare table - Editorial: text column + factbox (totalSchools, LA count, coverage dates) rendered inside a white card below the how-it-works section - Footer: expanded to 3 columns (brand blurb, Product, Resources); links updated to / /rankings /compare and real gov.uk/ofsted URLs - All new sections visible only on landing (no search active) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-14 21:02:18 +01:00
tudorandClaude Sonnet 4.6	5eff9af69c	feat: add secondary school support with KS4 data and metric tooltips ... - Backend: replace INNER JOIN ks2 with UNION ALL (ks2 + ks4) so primary and secondary schools both appear in the main DataFrame - Backend: add /api/national-averages endpoint computing means from live data, replacing the hardcoded NATIONAL_AVG constant on the frontend - Backend: add phase filter param to /api/schools; return phases from /api/filters; fix hardcoded "phase": "Primary" in school detail endpoint - Backend: add KS4 metric definitions (Attainment 8, Progress 8, EBacc, English & Maths pass rates) to METRIC_DEFINITIONS and RANKING_COLUMNS - Frontend: SchoolDetailView is now phase-aware — secondary schools show a GCSE Results section (Att8, P8, E&M, EBacc) instead of SATs; phonics tab hidden for secondary; admissions says Year 7 instead of Year 3; history table shows KS4 columns; chart datasets switch for secondary - Frontend: new MetricTooltip component (CSS-only ⓘ icon) backed by METRIC_EXPLANATIONS — added to RWM, GPS, SEN, EAL, IDACI, progress scores and all KS4 metrics throughout SchoolDetailView and SchoolCard - Frontend: METRIC_EXPLANATIONS extended with KS4 terms (Attainment 8, Progress 8, EBacc) and previously missing terms (SEN, EHCP, EAL, IDACI) - Frontend: SchoolCard expands "RWM" to "Reading, Writing & Maths" and shows Attainment 8 / English & Maths Grade 4+ for secondary schools - Frontend: FilterBar adds Phase dropdown (Primary / Secondary / All-through) - Frontend: HomeView hero copy updated; compact list shows phase-aware metric - Global metadata updated to remove "primary only" framing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-28 14:59:40 +00:00
tudorandClaude Opus 4.6	8aca0a7a53	feat(ui): site-wide UX/UI audit — unified buttons, tokens, accessibility ... - Add shared button system (.btn-primary/secondary/tertiary/active) in globals.css - Replace 40+ hardcoded rgba() values with design tokens across all CSS modules - Add skip link, :focus-visible indicators, and ARIA landmarks - Standardise button labels ("+ Compare" / "✓ Comparing") across all components - Add collapse/minimize toggle to ComparisonToast - Fix heading hierarchy (h3→h2 in ComparisonView) - Add aria-live on search results, aria-label on trend SVGs - Add "Search" nav link, fix footer empty section, unify max-widths - Darken --text-muted for WCAG AA compliance (4.6:1 contrast ratio) - Net reduction of ~180 lines through button style deduplication Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-03-25 20:28:03 +00:00
tudorandClaude Sonnet 4.6	1c49a135c4	feat(ofsted): add Report Card system support alongside legacy OEIF grades ... Ofsted replaced single overall grades with Report Cards from Nov 2025. Both systems are retained during the transition period. - DB: new framework + 9 RC columns on ofsted_inspections (schema v4) - Integrator: auto-detect OEIF vs Report Card from CSV column headers; parse 5-level RC grades and safeguarding met/not-met - API: expose all new fields in the ofsted response dict - Frontend: branch on framework='ReportCard' to show safeguarding badge + 8-category grid; fall back to legacy OEIF layout otherwise; always show inspection date in both layouts - CSS: rcGrade1–5 and safeguardingMet/NotMet classes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-25 13:03:04 +00:00
tudorandClaude Sonnet 4.6	3d24050d11	feat(ux): implement comprehensive UX audit fixes across all pages ... Addresses 28 issues identified in UX audit (P0–P3 severity): P0 — Critical: - Fix compare URL sharing: seed ComparisonContext from SSR initialData when localStorage is empty, making /compare?urns=... links shareable - Remove permanently broken "Avg. Scaled Score" column from school detail historical data table P1 — High priority: - Add radius selector (0.5–10 mi) to postcode search in FilterBar - Make Add to Compare a toggle (remove) on SchoolCards - Hide hero title/description once a search is active - Show school count + quick-search prompts on empty landing page - Compare empty state opens in-page school search modal directly - Remove URN from school detail header (irrelevant to end users) - Move map above performance chart in school detail page - Add ← Back navigation to school detail page - Add sort controls to search results (RWM%, distance, A–Z) - Show metric descriptions below metric selector - Expand ComparisonToast to list school names with per-school remove - Add progress score explainer (0 = national average) throughout P2 — Medium: - Remove console.log statements from ComparisonView - Colour-code comparison school cards to match chart line colours - Replace plain loading text with LoadingSkeleton in ComparisonView - Rankings empty state uses shared EmptyState component - Rankings year filter shows actual year e.g. "2023 (Latest)" - Rankings subtitle shows top-N count - Add View link alongside Add button in rankings table - Remove placeholder Privacy Policy / Terms links from footer - Replace untappable 10px info icons with visible metric hint text - Show active filter chips in search results header P3 — Polish: - Remove redundant "Home" nav link (logo already links home) - Add / and Ctrl+K keyboard shortcut to focus search input - Add Share button to compare page (copies URL to clipboard) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-23 21:31:28 +00:00
Tudor	3cab49a2b3	Removing duplicate footer entries	2026-02-04 12:11:42 +00:00
TudorandClaude Opus 4.5	c2ec067495	Apply warm editorial design system across all components ... Replace generic blue/gray colors with warm editorial palette: - Navigation: coral active states, branded logo colors - Footer: navy background, gold section titles - FilterBar: coral search button and focus states - SchoolCard: coral left accent on hover, teal/coral buttons - HomeView: gradient hero section, Playfair Display headings - RankingsView: gold top-3 highlights, warm table styling - ComparisonView: teal card borders, coral buttons Consistent use of CSS variables and Playfair Display serif font for headings throughout. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2026-02-03 10:11:23 +00:00
TudorandClaude Sonnet 4.5	ff7f5487e6	Complete Next.js migration with SSR and Docker deployment ... - Migrate from vanilla JavaScript SPA to Next.js 16 with App Router - Add server-side rendering for all pages (Home, Compare, Rankings) - Create individual school pages with dynamic routing (/school/[urn]) - Implement Chart.js and Leaflet map integrations - Add comprehensive SEO with sitemap, robots.txt, and JSON-LD - Set up Docker multi-service architecture (PostgreSQL, FastAPI, Next.js) - Update CI/CD pipeline to build both backend and frontend images - Fix Dockerfile to include devDependencies for TypeScript compilation - Add Jest testing configuration - Implement performance optimizations (code splitting, caching) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>	2026-02-02 20:34:35 +00:00