tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity
657 Commits 70 Branches 0 Tags
97dd69a5127658a1f446798bef59d0fc2c0065a1
Commit Graph
30 Commits
Author SHA1 Message Date
TudorandClaude Opus 5 97dd69a512 docs(perf): resolve CSS strategy for shared section components 
Planning surfaced a gap: the two detail views' CSS modules share 79 class
names, 22 with differing rules, 16 of those used in section markup by both
views. Shared sections cannot use one stylesheet without visual change.

Resolution: union the 14 incidental-drift differences (defensive overflow
properties never back-ported between the views), and keep the 2 genuine
visual differences (.genderBar, .heroStatValue) as distinct classes behind a
variant prop. Adds an isolated CSS-merge commit so a visual regression
bisects to the merge rather than a JSX move.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
 2026-08-01 20:47:21 +01:00
TudorandClaude Opus 5 d1c92ea7d5 docs(perf): spec for detail-page server/client split 
Design for splitting SchoolDetailView (65KB) and SecondarySchoolDetailView
(46KB) into server section components behind a small client shell, following
the existing components/compare/ decomposition pattern.

Key constraint: a server component imported by a client component becomes
client, so sections are composed in page.tsx and passed through the shell as
children. Moving /api/national-averages server-side is a prerequisite, since
the England-comparison deltas feed most sections.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
 2026-07-30 15:35:54 +01:00
TudorandClaude Opus 4.8 702408d6a4 docs(compare): implementation plan for InfoPopover metric help 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-07-22 15:34:38 +01:00
TudorandClaude Opus 4.8 09d94e513e docs(compare): design for unified InfoPopover metric-help affordance 
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
 2026-07-22 15:30:40 +01:00
TudorandClaude Fable 5 77d7052662 docs(spec): re-verify the 2021/22 KS2 gap — expert finding refuted, footnote copy stands
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m5s
Details
PR Checks / Backend Smoke (pull_request) Successful in 7s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 17s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 47s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 47s
Details
PR Checks / AI Code Review (Claude) (pull_request) Successful in 4m1s
Details 
The final review claimed DfE published school-level 2021/22 KS2 in Dec
2022. Re-verified: the GOV.UK announcement 'Primary school performance
tables: 2022' is CANCELLED ('will not be published in key stage 2
performance tables in academic year 2021/22'), and the EES 2021/22
release carries the same statement. No code change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-16 19:12:07 +01:00
TudorandClaude Fable 5 a86a2be96c docs: plan for the five must-fix findings from the final expert review 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-16 14:39:11 +01:00
TudorandClaude Fable 5 6138e2b2ee Merge main (PR #34) into compare frontend branch 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-14 00:04:03 +01:00
TudorandClaude Fable 5 9447b80bc6 docs: compare mockups as frontend design source + rebuild plan 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-13 19:13:18 +01:00
TudorandClaude Fable 5 17b4498c80 docs: plan for compare API enrichment 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-13 15:46:04 +01:00
tudor 3754947fd6 Merge pull request 'feat(pipeline): compare-screen data foundation — raw→marts promotions, national averages, Ofsted report cards' (#32) from feat/compare-data-foundation into main
Stage (build -> staging -> E2E gate) / Build Backend (FastAPI) (push) Successful in 12s
Details
Stage (build -> staging -> E2E gate) / Build Frontend (Next.js) (push) Successful in 48s
Details
Stage (build -> staging -> E2E gate) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 1m16s
Details
Stage (build -> staging -> E2E gate) / Deploy to Staging (push) Successful in 1s
Details
Stage (build -> staging -> E2E gate) / E2E Journeys against Staging (push) Successful in 41s
Details 
Reviewed-on: #32
 2026-07-13 12:52:11 +00:00
TudorandClaude Fable 5 dd0ff7d0c2 docs: plan for staged production promotion 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-13 08:34:32 +01:00
TudorandClaude Fable 5 bee63a7836 docs(spec): 2021/22 school-level KS2 is a permanent DfE source gap, not a pipeline task 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-12 22:10:05 +01:00
TudorandClaude Fable 5 297bdbd12e docs: compare-screen redesign spec, expert review, and data-foundation plan 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB
 2026-07-12 21:19:53 +01:00
TudorandClaude Fable 5 c26755750d docs: mark GIAS code dictionaries spec implemented
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 9m38s
Details
PR Checks / Backend Smoke (pull_request) Successful in 8s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 22s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 47s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 54s
Details
PR Checks / AI Code Review (Claude) (pull_request) Failing after 3m58s
Details 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-09 14:12:52 +01:00
TudorandClaude Fable 5 08bd86db05 docs: implementation plan for GIAS code dictionaries 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-09 10:10:26 +01:00
TudorandClaude Fable 5 1ae5762a0a docs: design spec for GIAS code dictionaries (codes in marts, names in code) 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-09 09:55:53 +01:00
TudorandClaude Fable 5 3fcb1340d4 docs: mark sixth-form flag pipeline change implemented 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 10:43:08 +01:00
TudorandClaude Fable 5 87f4c6dd40 docs: implementation plan for GIAS sixth-form flag 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 10:21:02 +01:00
TudorandClaude Fable 5 0309b27c84 docs: exam results phase taxonomy and sixth-form separation spec 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-07 10:02:21 +01:00
TudorandClaude Fable 5 f2b71b67d4 docs(audit): correct postcode finding — full postcodes do trigger proximity search 
Recheck with 'B91 3DL' via the search box shows the geocoded radius
search works (distances, nearest-first, radius selector, map toggle).
Original P0.3 tested only a partial postcode, which silently falls back
to text search — refiled as P2.0 (silent mode switch on partial input).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 15:01:02 +01:00
TudorandClaude Fable 5 a059fa213e docs(audit): prioritized UX/UI audit report 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 14:41:44 +01:00
TudorandClaude Fable 5 1bd69e693a docs(audit): cross-cutting cohesion pass notes 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 14:28:09 +01:00
TudorandClaude Fable 5 c52169d5d8 docs(audit): journey 5 notes — admissions 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 14:17:20 +01:00
TudorandClaude Fable 5 860f79e725 docs(audit): journey 4 notes — rankings 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 14:11:37 +01:00
TudorandClaude Fable 5 3c02a0a478 docs(audit): journey 3 notes — building a comparison 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 11:49:39 +01:00
TudorandClaude Fable 5 fe0a7713df docs(audit): journey 2 notes — cold landing on school detail 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 11:27:44 +01:00
TudorandClaude Fable 5 2dd1ff76ed docs(audit): journey 1 notes — home to school search 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 11:11:49 +01:00
TudorandClaude Fable 5 ee5b94099a chore(audit): axe harness and notes template for UX audit 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 10:53:50 +01:00
TudorandClaude Fable 5 eeb3f2491a docs: execution plan for site-wide UX/UI audit 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 10:14:34 +01:00
TudorandClaude Fable 5 683daa032e docs: design spec for site-wide UX/UI audit 
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-02 10:01:03 +01:00