31 Commits

Include renames

Author	SHA1	Message	Date
tudor	8cf2ac47c1	Merge pull request 'feat(detail): surface GIAS identity/contact details, drop unwired sections' (#82) from feat/detail-gias-fields-remove-unwired into main ... Reviewed-on: #82	2026-07-24 10:56:34 +00:00
TudorandClaude Opus 4.8	0186227ced	feat(detail): surface GIAS identity/contact details, drop unwired sections ... Add seven school-identity fields to the detail header (both primary and secondary views): age range, religious character, nursery and sixth-form indicators as chips; telephone (tel: link), county and parliamentary constituency as header details. religious_denomination, age_range and has_sixth_form were already served; telephone, nursery_provision, county and parliamentary_constituency are newly wired through the marts query (with a NULL fallback for un-rebuilt marts, mirroring has_sixth_form) and the school_info API response. Remove three UI sections the backend never populated (always null): Year 1 Phonics, the SEN "types of additional needs" breakdown, and the average class-size card — along with their now-dead props, route plumbing, and the SenDetail/Phonics types + class_size_avg field. Extend the e2e detail journey to assert the Phonics section is gone and the new header fields render when the record carries them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-24 09:23:08 +01:00
TudorandClaude Opus 4.8	8e763e39d1	test(e2e): compare help popover stays within the mobile viewport ... Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-22 15:38:56 +01:00
TudorandClaude Opus 4.8	a5b2296240	fix(rankings,admissions): correct accuracy issues from education audit ... Follow-up audit of the rankings and admissions pages. Admissions (AdmissionsView.tsx): - National Offer Day no longer claims offers publish "from 12:01 am"; release times are set per-council (often late afternoon, some overnight), so it now tells parents to check their council's page. - Secondary preference count no longer states a flat "up to six" (that's London/Pan-London); most LAs allow three to six. Mirrors the hedge the primary step already used. - Added the two deadlines that most often catch parents out: selective schools' separate entrance-test registration (months earlier), and faith schools' supplementary information form sent direct to the school. Covered in both the primary and secondary criteria steps. - Reworded the equal-preference tip so it's precise: order is the tie-break among schools you qualify for (you get the highest-ranked one), not irrelevant. Rankings (RankingsView.tsx): - Subtitle "Top-performing schools by X" -> "Schools ranked by X", so it isn't nonsensical for context/equity/absence metrics. - KS2 progress isn't published for 2023/24 or 2024/25 (no KS1 baseline). Selecting a primary progress metric on a recent year used to dead-end on a generic "No rankings found". Added a scoped caveat to the progress hint and an explanatory empty-state (primary only — secondary Progress 8 is published). Added an admissions smoke journey (static content, stable milestones). Verified with tsc --noEmit and next build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 12:08:50 +01:00
TudorandClaude Opus 4.8	ae6ef6860b	fix: don't portray special schools as failing the mainstream benchmark ... Special schools, PRUs and alternative provision teach pupils with SEND who sit the same KS2/KS4 assessments but very few reach the mainstream "expected standard". Their headline attainment is therefore ~0% (or a very low Attainment 8), and the site was comparing that to the England average and painting it red — e.g. Greenmead School (a community special school) rendered as "0.0% — −62 pts below England average" with three 0% red SATs bars. That portrays a special school as catastrophically failing against a benchmark that doesn't fit it. Add a shared `isSpecialSchool()` helper (detects every DfE special-school establishment type — all contain "special" — plus PRUs / alternative provision) and drop the mainstream England comparison + "below" framing for these schools across every surface: - Detail (primary + secondary): a plain-English context note explaining the school is special and why the comparison isn't shown; England-average delta chips, "England avg" hints, the SATs national markers, the Attainment-8 "vs national" bar and the trend chart's England overlay are all suppressed. An all-zero placeholder SATs row hides the (empty) subject bar chart and the "why is combined lower" bridge. - Rankings / search rows (primary + secondary): the mainstream RWM / Attainment 8 stat shows "—" with no "vs national" delta, instead of "0% · −62 vs national". - Compare: special schools' attainment values are dropped (no misleading dot at 0% / no "Below England average" chip); progress banding, which IS a fair measure for special schools, is kept. Belt-and-braces zero-guard: a whole-row zero attainment (special or a suppressed cohort) is also treated as not-comparable, while a legitimate single 0 (e.g. 0% exceeding at a mainstream school) stays comparable. Tests: new isSpecialSchool unit tests (every DfE special type matched, no mainstream false positives); an e2e journey asserts Greenmead shows the special-school note and no England-average comparison. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 20:39:16 +01:00
TudorandClaude Opus 4.8	f6bb037c47	fix(detail): render both phases for all-through schools (Batch E) ... Batch E of applying the compare-screen learnings to the school detail page — all-through handling (point 11). An all-through school carries both KS2 and KS4 figures in the same yearly rows, but SchoolDetailView flipped it to isSecondary and rendered GCSE-only, hiding the entire primary phase (SATs, phonics, KS2 trend). The Results snapshot already gated its KS2/KS4 blocks purely on data availability, so both already appeared there — but the section title, the trend chart, phonics, the nav label and the history table all still assumed a single phase. - Add an explicit `isAllThrough` flag (+ `showPrimaryContent = isPrimary || isAllThrough`); pure-secondary behaviour is unchanged. - Hero: an "All-through (primary & secondary)" meta chip for all-ages framing. - Results section: title "SATs & GCSE Results", a combined subtitle, and "Primary — KS2 SATs (Year 6)" / "Secondary — GCSEs (Year 11)" sub-headings separating the two blocks. - Results Over Time: render two stacked PerformanceCharts (KS2 SATs + GCSEs) rather than crowding both stages' series — on different scales with different gap stories — onto one axis. Each gets its correct England overlay. - Phonics section + nav item now show for all-through (primary-stage metric). - History table: an all-through column set covering both phases (RWM, Exceeding, Attainment 8, Progress 8, Eng & Maths 4+). - Nav "Results" label for all-through instead of "GCSEs". e2e: a new journey asserts an all-through school (Hessle, 137306) shows both the KS2 and KS4 results and the All-through label, with a data-driven precondition skip if staging data drifts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:53:07 +01:00
TudorandClaude Fable 5	b2b2cad5ac	test/docs: harden report-card list e2e + correct badge docstring ... Review fixes on the list/map report-card PR: - e2e precondition now hard-asserts ofsted_rc_date instead of test.skip, so the backend dropping the field fails loudly (that's the regression under test), not silently skips. - Use page_size=5 (the real backend param); per_page was ignored and fell back to the default page size. - Update buildOfstedListBadge docstring to describe the ofsted_rc_date-based, report-card-wins-first detection instead of the removed framework check. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 21:24:09 +01:00
TudorandClaude Fable 5	5ec4f3f7cd	fix(list/map): badge report-card schools as Report Card, not their carried-forward grade ... The search-result cards and map pins keyed report-card detection off ofsted_framework === 'ReportCard', but the API sets ofsted_framework to the raw event grouping ('Schools - S5'); worse, ofsted_grade (the carried-forward legacy grade) was checked first and won. So report-card schools were badged by their old grade — Barclay's pin/card read 'Outstanding · 2021' instead of 'Report Card · 2026'. Same root cause as the detail-page fix, different surface. Expose ofsted_rc_date on the list serialization (the report-card inspection date, non-null only for report cards) and make both badge builders treat a present rc-date as winning over any grade, using its year. Removes the dead framework === 'ReportCard' branches. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 21:14:57 +01:00
TudorandClaude Fable 5	b31e71ac88	fix(detail): render report cards and date them by the report-card inspection ... The detail views detected report cards via ofsted.framework === 'ReportCard', but the API sets framework to the raw event grouping ('Schools - S5') even for report-card schools — so the check never matched: report-card schools rendered as legacy 'Ofsted Rating' badges dated to a pre-Nov-2025 inspection (e.g. Barclay shown as 'Outstanding, Inspected 7 October 2021' instead of its Feb 2026 report card). Detect report cards by the presence of the report_card object (matching the compare screen), and date them with rc_inspection_date, never the legacy inspection_date. Applies to both primary and secondary detail views. New e2e assertion against a real report-card school gates it. Note: the list/map surface has the same latent issue via ofsted_framework (LeafletMapInner) — flagged as a separate follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 19:09:16 +01:00
TudorandClaude Fable 5	5944d88f0b	fix(compare): expert sign-off must-fixes — phase-matched admissions, Ofsted sentinel codes, selective-school copy ... M1: admissions rounds are now selected by the active phase tab (admissionsForPhase) — an all-through school's Year 7 round no longer masquerades as Reception odds beside pure primaries; honest per-cell and section fallbacks name the round (Reception / Year 7). M2: Ofsted sentinel codes (9 = not applicable) never render as judgement chips, and the sixth-form judgement — previously dropped — now renders for schools that have one. M3: 'What this means' is phase- and type-aware: selective schools get entrance-test framing, secondary faith schools a faith-criteria note, and the primaries' distance template never appears on the secondary tab (admissions_policy now exposed in compare school_info). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 12:40:42 +01:00
TudorandClaude Fable 5	84baf95f68	fix(compare): stale basket fetch no longer blanks a freshly opened comparison ... Opening a compare link while localStorage held a different basket raced a fetch for the OLD school set against the URL's SSR data; the stale response replaced comparisonData, so no active school had data and every section (including the trends chart) vanished until a hard refresh. Responses from superseded effect runs are now dropped, successful ones merge instead of replace, and the URL-seed effect re-runs when a client-side navigation changes ?urns=. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 07:16:04 +01:00
TudorandClaude Fable 5	99b769ca9e	feat(compare): fill the sticky bar's label rail with a comparison caption ... 'COMPARING / 3 primary schools' — 0.72rem uppercase eyebrow over a 0.95rem semibold count, sized to sit alongside the 0.92rem chip names without dominating. Desktop only; mobile pills unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 21:27:25 +01:00
TudorandClaude Fable 5	8e0b730629	fix(compare): align sticky school chips with their data columns on desktop ... The bar was a plain flex row while sections use a 200px-label + per-school grid, so chips drifted off the columns they label. The bar now shares the sections' grid template (via --school-count) at the same 761px breakpoint; verified pixel-exact against live section columns (236/615/994). Mobile pills unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 21:05:16 +01:00
TudorandClaude Fable 5	026a7ab6aa	fix(compare): render all-secondary comparisons — re-run phase detection after basket hydration ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 14:42:09 +01:00
TudorandClaude Fable 5	fef83b3bf2	fix(compare): sticky school bar hidden behind the site header ... The Navigation header is position:sticky top:0 (z-index 1000). The school bar was also sticky top:0 (z-index 10), so when scrolled it pinned at the same top:0 *behind* the header — on mobile 57 of its 72px were covered, leaving only a sliver, so you couldn't see which schools were selected. Offset the bar's sticky top to the header height (65px desktop, 57px mobile — the Navigation breakpoint is also 640px) so it pins just below. e2e guard asserts the bar's sticky offset is at least the header height (verified it fails against the pre-fix build). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-15 12:32:36 +01:00
tudor	b89fa47ec5	Merge pull request 'fix(compare): trends chart was squashed to ~150px — give it a real height' (#41) from fix/trends-chart-height into main ... Reviewed-on: #41	2026-07-14 22:51:04 +00:00
TudorandClaude Fable 5	e4565e9f15	fix(compare): give the trends chart a real height (was squashed to ~150px) ... ComparisonChart runs Chart.js with maintainAspectRatio:false, so it sizes to its container's height — which must be definite. TrendsExplorer gave .chartBox a min-height, which doesn't resolve the chart wrapper's height:100%, so Chart.js fell back to its ~150px default: a squashed 8.6:1 sliver that didn't match the mockups. Set a definite height (420px desktop, 360px mobile where the chips row sits above the canvas). Verified on staging by patching the live height: canvas went from 1287x150 to 1287x392 (desktop) / 284 (mobile) — proper ~3:1 proportions matching the mockup, with the England dashed line, COVID/2021-22 gap and table all reading correctly. An e2e guard asserts the trends canvas is taller than 220px so the squash can't regress. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-14 23:24:39 +01:00
TudorandClaude Fable 5	06e4898c30	test(e2e): pick two same-phase schools for the compare journey ... The compare page's phase tabs put all-through schools (which carry KS4 data) on the secondary tab, so comparing an all-through school with a pure primary splits them across tabs and only the active tab renders its link. The test picked the first two 'primary' search hits without guaranteeing same phase, so it flaked whenever a search returned an all-through school first (e.g. URN 137306). Now selects two pure-Primary URNs via the API — deterministic and data-invariant. Verified against staging: was a 15.6s timeout, now passes in ~1.8s. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-14 23:12:23 +01:00
TudorandClaude Fable 5	2f85b9c647	test(e2e): compare journeys for the parent-first redesign ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-13 23:59:22 +01:00
TudorandClaude Opus 4.8	87642b7b06	fix(api): serialize schools that have no performance rows ... Schools without KS2/KS4 results (special post-16 institutions, sixth-form centres, PRUs, new schools) come back from the marts LEFT JOIN with NaN in every numeric column. school_info passed those raw pandas values straight into JSONResponse, which renders with allow_nan=False, so the detail endpoint 500d and the frontend turned that into a 404 on every such SEO landing page. Run school_info values through convert_to_native (the same treatment yearly_data already gets), add backend unit tests plus a pytest step in PR checks, and an e2e journey that finds a results-less school via the search API and asserts its page renders. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-07 09:22:54 +01:00
TudorandClaude Opus 4.8	4e8df006d7	feat(home): move "use my location" beside the hero search box ... The geolocation shortcut lived in the discovery strip below the results, away from the search. Move it directly under the hero search input, paired with the postcode hint, so the two ways to find nearby schools ("type a postcode" / "use my location") read as one idea and are visible at first glance. - FilterBar gains optional onNearMe/geoState/geoError props and renders the teal "Use my location" pill (with spinner + error) in hero mode; the geolocation flow itself still lives in HomeView. - Remove the now-duplicate near-me button and its dead CSS from the discovery section. - Refresh the search hint copy to pair with the button. - e2e: assert the "use my location" shortcut renders in the hero. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-06 17:01:45 +01:00
tudor	1f8284adfc	Merge pull request 'fix(map): results map fullscreen falls back to an overlay on iOS' (#18) from fix/results-map-ios-fullscreen into main ... Reviewed-on: #18	2026-07-06 13:33:16 +00:00
TudorandClaude Fable 5	b2dc4d0779	fix(map): results map fullscreen falls back to an overlay on iOS ... The results-view map's fullscreen button called requestFullscreen(), which iOS Safari doesn't implement (fullscreen is video-only there), so tapping it did nothing on iPhones — the same gap already fixed for the school hero map. When the Fullscreen API is missing or its promise rejects, fall back to a fixed-position overlay (.fsFallback, z-index 5000) driven by state, locking body scroll while open. Leaflet re-measures on window resize, so dispatch a resize when fullscreen toggles (the CSS overlay fires none) or the map would fill only part of the screen. Native fullscreen is unchanged. New e2e journey deletes Element.requestFullscreen on a mobile viewport, opens the results map fullscreen, and asserts the exit control appears then releases; it fails against current production, reproducing the bug. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 14:09:37 +01:00
TudorandClaude Fable 5	3adea73ee0	fix(e2e): compare-chips test must use schools in one phase ... The test picked the first two /school/ links from a 'primary' search and asserted exactly two mobile chips. But a 'primary' search can return all-through schools (e.g. 'Hessle High School and Penshurst Primary') that classify as secondary, so the two picks can split across phases — the active phase then holds one school and the chips are correctly gated out (they need ≥2 in the active phase), while the canvas still shows one line. That's a test artefact, not a bug. Pick three schools instead: across two phases the auto-selected majority phase always holds ≥2, so the chip legend is guaranteed. Assert ≥2 chips (the majority may be 2 or 3). Verified against staging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 11:42:11 +01:00
TudorandClaude Fable 5	22769b6295	feat(compare): readable comparison chart on mobile ... The compare chart squashed clustered schools into a thin band (y pinned 0-100) under an in-chart title + per-school legend that ate ~40% of a 300px card, leaving converging lines indistinguishable on phones. - Auto-fit the y-axis to the data on all viewports (computeYBounds in lib/utils: padded + min-span for percentages, symmetric around 0 for progress, fitted for scores; negative pct-named trend metrics are not zero-clamped). - Distinct point style per school (circle/triangle/rect/rectRot/star) as secondary encoding for convergence and colour-blindness. - Mobile: drop in-chart title/legend/axis titles; add a chip row (colour dot + name) that doubles as tap-to-focus — highlights one school's line and dims the rest. Chart card 300px -> 340px, nearly all plot. - Fix a latent colour mismatch: datasets were built from Object.entries whose integer-like URN keys enumerate in ascending numeric order, desyncing line colours from card colours; the chart now receives the ordered school list. - Union years across schools instead of taking the first school's. - Extract PerformanceChart's matchMedia pattern into hooks/useIsMobile. Unit tests for metricKind/computeYBounds; e2e journey covers the mobile chips and focus toggle. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-05 22:02:26 +01:00
TudorandClaude Fable 5	d52d384cf2	fix(school): make hero map fullscreen work on iOS Safari ... iOS Safari has no Element.requestFullscreen (fullscreen is video-only), so tapping the map band or 'View on map' silently did nothing on iPhones. Fall back to a fixed-position CSS overlay driven by state when the Fullscreen API is missing or its promise rejects, locking body scroll while open. The Leaflet map already re-measures via the shared isFullscreen flag. New e2e journey simulates the iOS condition by deleting the API and asserts the overlay opens and closes; it fails against the current production build. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-05 21:34:22 +01:00
TudorandClaude Fable 5	acec8135e1	fix(e2e): pick the latest explicit year in the rankings year test ... Staging doesn't always carry the full data history, so selecting the oldest year legitimately returns no rows and fails the promotion gate. Select the most recent explicit year instead: the default view already proved it has rows, so an empty table after selecting it can only mean the year query param was rejected — the regression this test guards. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-05 14:29:43 +01:00
TudorandClaude Fable 5	6c872ce726	fix(api): accept academic-year codes in rankings year filter ... The rankings endpoint validated year with le=2100, but the database stores academic-year codes like 201819, so any explicit year selection returned a 422 and the rankings page rendered its empty state. Widen the bound to cover the codes and extend the e2e journey to pick a specific year and assert the table stays populated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-04 22:13:56 +01:00
TudorandClaude Fable 5	deeef23131	fix(e2e): assert on a visible canvas — the first canvas is hidden by design ... The admissions card stacks year/trend views in one grid cell and keeps the inactive view visibility:hidden; its canvas is first in the DOM. Use canvas:visible instead of scrolling. Verified: full suite passes against prod. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL	2026-07-03 14:40:13 +01:00
TudorandClaude Fable 5	4ece55b031	fix(e2e): scroll the detail-page chart into view before asserting visibility ... The canvas renders below the fold and stays 'hidden' to Playwright until scrolled to; wait for attachment, scroll, then assert. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL	2026-07-03 14:34:17 +01:00
TudorandClaude Fable 5	4a52735356	feat(sdlc): staging environment + automated staging→prod pipeline ... - pr-checks.yml: PR gate — frontend typecheck+jest, backend import smoke, image builds (no push), Claude AI review posted as PR comment (severe findings block merge) - deploy.yml (replaces build-and-push.yml): merge to main builds+pushes images tagged sha-<sha>/staging, deploys the staging Portainer stack via webhook, runs Playwright E2E journeys against staging, then retags the verified images :prod (previous kept as :prod-previous) and deploys prod - docker-compose.portainer.staging.yml: second Portainer stack — :staging images, sc_staging_* names, own macvlan IPs, Airflow on 8081; data bootstrapped from source via the staging Airflow DAGs - prod compose now pins :prod instead of :latest (only the promotion step moves it; :latest is no longer published) - e2e/: 6 Playwright journeys (search, postcode, detail, compare, rankings) driven by BASE_URL — the promotion gate - scripts/ci/ai_review.py: Claude review with structured JSON findings - docs/DEPLOY.md: full SDLC doc incl. one-time setup checklist and rollback - replaced removed 'next lint' with tsc typecheck; fixed stale jest tests (slug URLs, N/A formatting, stable trend, fake-timer setup) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PqGhF93UrpDNvXBLMjJENL	2026-07-03 06:50:40 +01:00