70 Commits

Include renames

Author	SHA1	Message	Date
TudorandClaude Opus 4.8	684da611ff	feat(detail): always show religious character, "None" for no religious character ... Previously the chip was hidden for "Does not apply"/"None". Show it in all cases, rendering "None" for those two sentinel values. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-24 09:24:27 +01:00
TudorandClaude Opus 4.8	0186227ced	feat(detail): surface GIAS identity/contact details, drop unwired sections ... Add seven school-identity fields to the detail header (both primary and secondary views): age range, religious character, nursery and sixth-form indicators as chips; telephone (tel: link), county and parliamentary constituency as header details. religious_denomination, age_range and has_sixth_form were already served; telephone, nursery_provision, county and parliamentary_constituency are newly wired through the marts query (with a NULL fallback for un-rebuilt marts, mirroring has_sixth_form) and the school_info API response. Remove three UI sections the backend never populated (always null): Year 1 Phonics, the SEN "types of additional needs" breakdown, and the average class-size card — along with their now-dead props, route plumbing, and the SenDetail/Phonics types + class_size_avg field. Extend the e2e detail journey to assert the Phonics section is gone and the new header fields render when the record carries them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-24 09:23:08 +01:00
TudorandClaude Opus 4.8	8a9ba30cc2	fix(detail): compare each SATs bar to its own national benchmark ... The KS2 SATs chart drew a single national-average line spanning the full height of each subject's chart area, positioned at the national *expected* value. But the area stacks two bars — Expected and Exceeding — and the higher-standard/greater-depth national is a very different, much lower figure (e.g. reading higher standard ~29% vs expected ~75%). So the line crossed the Exceeding bar at the wrong place, making every school's exceeding result look far below national when it wasn't. The per-subject higher-standard nationals were already computed in the fact_ks2_national_averages mart; they just weren't serialized. Fix: - backend: add reading_high_pct, writing_gd_pct (writing = greater depth) and maths_high_pct to the national-averages payload. - SchoolDetailView: pass a nationalExceedingPct per subject, mapping writing to the greater-depth figure. - SatsChart: replace the single full-height line with a national marker on each bar's own track (coral tick + "nat X%" in the bar header), so Expected and Exceeding each sit against the correct benchmark. KS2 only; the secondary Attainment 8 chart already uses one line for one measure and is untouched. Verified: tsc --noEmit, next build, and backend pytest (national averages marts, incl. a new test guarding the per-subject nationals). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 14:55:43 +01:00
tudor	e4c8b86fe7	Merge pull request 'fix(detail): align Ofsted Report Card grade chips' (#71) from fix/report-card-chip-alignment into main ... Reviewed-on: #71	2026-07-20 21:32:45 +00:00
TudorandClaude Opus 4.8	1c1df77961	fix(detail): align Ofsted Report Card grade chips ... The grade boxes rendered inconsistently: Safeguarding "Met" was a small 0.8125rem inline pill while grade values ("Strong") were 1.25rem full-width chips, and because category labels wrap to one or two lines each value sat at a different vertical position. Two-line values like "Expected standard" also produced a taller box. Add a scoped `.gradeGrid` modifier (Report Card + OEIF grids in both the primary and secondary detail views) that reserves two label lines so every chip shares a baseline, and gives all value chips one font size, padding and min-height — long text wraps inside an equal-height chip via max-width:100%. Scoped rather than touching the shared `.metricCard`/`.metricValue` used by the finance, phonics and admissions sections. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 22:31:58 +01:00
tudor	993822d769	Merge pull request 'fix: don’t portray special schools as failing the mainstream benchmark' (#70) from fix/special-schools-not-failing into main ... Reviewed-on: #70	2026-07-20 21:14:57 +00:00
TudorandClaude Opus 4.8	0b36eace9d	fix(review): accurate PRU/AP copy, unbundle same-school trend, de-dupe note CSS ... Three review points on the special-schools change: 1. Copy accuracy — the context note said "Its pupils have special educational needs" for every isSpecialSchool() match, but the helper also matches pupil referral units and alternative provision, whose pupils are educated outside a mainstream setting (e.g. after exclusion) and are not necessarily SEND. Extracted a shared <SpecialSchoolNote> with type-aware copy: SEND wording only for genuine special schools; PRUs/AP get their own accurate wording. 2. Same-school trend was conflated with the England comparison — SchoolRow's year-over-year trend arrow (and the school's own figure) were gated on the same flag that drops the vs-England delta, hiding a still-meaningful trend for special schools with real data. Split the two: the school's OWN RWM figure + trend show whenever there's a real value (special schools included; only a placeholder all-zero row is hidden); only the vs-England delta is additionally dropped for special/PRU/AP. Mirrored in SecondarySchoolRow (own Attainment 8 shown; only the vs-LA delta dropped). 3. De-duplicated the .specialNote CSS (was copy-pasted between the two detail view module files) into SpecialSchoolNote.module.css, owned by the shared component so it can't drift. New SpecialSchoolNote unit tests assert SEND wording for special schools and NOT for PRUs/AP. tsc clean; 112/112 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 22:09:32 +01:00
TudorandClaude Opus 4.8	de943ded19	fix(review): don't suppress a genuine mainstream 0 in the rows ... Review feedback: the rankings/search rows treated any exactly-0 attainment as not comparable regardless of school type, so a genuine 0 at a mainstream school rendered as "—" (looks like missing data) and dropped its delta — stricter and inconsistent with SchoolDetailView's placeholder check. - SchoolRow: match SchoolDetailView's ks2Placeholder signature — suppress only when ALL of RWM + reading + writing + maths are 0 (special/suppressed signature), not on a bare rwm === 0. A genuine 0% combined (some pupils met individual subjects but not all three) is not all-zero, so it stays comparable and shows its real figure + trend. - SecondarySchoolRow: Attainment 8 is a single 0–80 score with no subject breakdown to form an all-zero signature, so key off establishment type only (drop the bare att8 === 0 guard). A genuine (if extreme) 0.0 shows its value + LA delta. - For consistency, apply the same to the detail views: drop the bare attainment_8_score === 0 guard (KS4 keys off isSpecial only); KS2 keeps the all-four-subjects-zero placeholder signature. Special schools / PRUs / AP are still handled via isSpecialSchool everywhere. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 21:58:13 +01:00
TudorandClaude Opus 4.8	ae6ef6860b	fix: don't portray special schools as failing the mainstream benchmark ... Special schools, PRUs and alternative provision teach pupils with SEND who sit the same KS2/KS4 assessments but very few reach the mainstream "expected standard". Their headline attainment is therefore ~0% (or a very low Attainment 8), and the site was comparing that to the England average and painting it red — e.g. Greenmead School (a community special school) rendered as "0.0% — −62 pts below England average" with three 0% red SATs bars. That portrays a special school as catastrophically failing against a benchmark that doesn't fit it. Add a shared `isSpecialSchool()` helper (detects every DfE special-school establishment type — all contain "special" — plus PRUs / alternative provision) and drop the mainstream England comparison + "below" framing for these schools across every surface: - Detail (primary + secondary): a plain-English context note explaining the school is special and why the comparison isn't shown; England-average delta chips, "England avg" hints, the SATs national markers, the Attainment-8 "vs national" bar and the trend chart's England overlay are all suppressed. An all-zero placeholder SATs row hides the (empty) subject bar chart and the "why is combined lower" bridge. - Rankings / search rows (primary + secondary): the mainstream RWM / Attainment 8 stat shows "—" with no "vs national" delta, instead of "0% · −62 vs national". - Compare: special schools' attainment values are dropped (no misleading dot at 0% / no "Below England average" chip); progress banding, which IS a fair measure for special schools, is kept. Belt-and-braces zero-guard: a whole-row zero attainment (special or a suppressed cohort) is also treated as not-comparable, while a legitimate single 0 (e.g. 0% exceeding at a mainstream school) stays comparable. Tests: new isSpecialSchool unit tests (every DfE special type matched, no mainstream false positives); an e2e journey asserts Greenmead shows the special-school note and no England-average comparison. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 20:39:16 +01:00
TudorandClaude Opus 4.8	733faefb98	fix(detail): label which phase all-through admissions figures cover (Batch F) ... Final Ofsted/education-expert review of the detail page (Batch F) found one clarity gap: on an all-through school the Admissions block shows a single entry point's figures (Hessle's are the Year 7 secondary intake — admissions.school_phase = "Secondary") but is titled just "Admissions", so a parent interested in the reception/primary intake could read the Year 7 numbers as the whole school. Add a phase subtitle for all-through schools ("These figures are for secondary entry (Year 7)." / "...primary entry (Reception)."). Pure-primary and pure-secondary pages are unambiguous and unchanged. Rest of the review verified correct against source payloads: all three Ofsted regimes (report card / ungraded post-Sept-2024 / carried-forward), England- average anchoring, gap-honest trend charts (KS2 + KS4), all-through dual-phase rendering, and the mobile layout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 17:13:37 +01:00
TudorandClaude Opus 4.8	f6bb037c47	fix(detail): render both phases for all-through schools (Batch E) ... Batch E of applying the compare-screen learnings to the school detail page — all-through handling (point 11). An all-through school carries both KS2 and KS4 figures in the same yearly rows, but SchoolDetailView flipped it to isSecondary and rendered GCSE-only, hiding the entire primary phase (SATs, phonics, KS2 trend). The Results snapshot already gated its KS2/KS4 blocks purely on data availability, so both already appeared there — but the section title, the trend chart, phonics, the nav label and the history table all still assumed a single phase. - Add an explicit `isAllThrough` flag (+ `showPrimaryContent = isPrimary || isAllThrough`); pure-secondary behaviour is unchanged. - Hero: an "All-through (primary & secondary)" meta chip for all-ages framing. - Results section: title "SATs & GCSE Results", a combined subtitle, and "Primary — KS2 SATs (Year 6)" / "Secondary — GCSEs (Year 11)" sub-headings separating the two blocks. - Results Over Time: render two stacked PerformanceCharts (KS2 SATs + GCSEs) rather than crowding both stages' series — on different scales with different gap stories — onto one axis. Each gets its correct England overlay. - Phonics section + nav item now show for all-through (primary-stage metric). - History table: an all-through column set covering both phases (RWM, Exceeding, Attainment 8, Progress 8, Eng & Maths 4+). - Nav "Results" label for all-through instead of "GCSEs". e2e: a new journey asserts an all-through school (Hessle, 137306) shows both the KS2 and KS4 results and the All-through label, with a data-driven precondition skip if staging data drifts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:53:07 +01:00
TudorandClaude Fable 5	4e6be0ce65	fix(detail): banded first-choice interpretation + plain-English P8 absence copy ... Batch C (points 7-10): - Point 7: the admissions section shows the first-choice offer rate but no sense of how severe a low rate is. Reuse the compare screen's banded summariseAdmissions ('More than half of first choices missed out' etc.) as an interpretive line under the tiles. (Selective/faith framing was already present via admissionsTag.) - Point 8: replace the jargon P8-suspended banner ('not used for accountability purposes ... treat with caution') with the compare screen's plain-English 'no KS2 baseline (COVID)' explanation. - Points 9 (disadvantaged cohort sizes) and 10 (FSM benchmark) don't apply to the detail page: it shows disadvantaged composition, not disadvantaged attainment, and no FSM-vs-benchmark comparison — so there's no small-cohort caveat or cross-definition fallback to fix here. - Also fixed a stray lowercase 'national avg' provenance string Batch B missed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:03:23 +01:00
tudor	452ec77449	Merge pull request 'fix(detail): 'England average' provenance labelling (Batch B)' (#65) from fix/detail-provenance-anchoring into main ... Reviewed-on: #65	2026-07-20 07:52:55 +00:00
TudorandClaude Fable 5	e36125b24a	fix(detail): label official DfE figures as 'England average' (provenance) ... Batch B (points 5-6): the detail page called every national figure a 'National avg'. All of them come from the official-DfE national-averages marts (KS2/KS4 headlines), so they are England averages — relabel to match the compare screen's provenance convention ('England average' for official figures; the detail page has no computed benchmarks, so no 'state-school average (computed)' label is needed). Point 6 (anchoring every number) is already satisfied on the detail page via DeltaChip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 07:19:22 +01:00
TudorandClaude Fable 5	fdda52ff0a	fix(detail): filter Ofsted sentinel codes, show sixth-form judgement, label carried-forward grades ... Batch A of applying compare-screen learnings to the detail page (points 2-3): - Point 2: the legacy OEIF sub-judgement grid rendered any non-null value via OFSTED_LABELS[value], so Ofsted's sentinel code 9 ('not applicable') leaked as an undefined label, and the sixth-form judgement was dropped entirely. New shared ofstedLegacyAreas() helper returns only real grades (1-4) and includes Sixth Form provision. Both detail views + the all-same-grade check use it. - Point 3: the OEIF disclaimer always claimed 'Ofsted no longer makes an overall judgement' even when showing a carried-forward grade. It's now grade_source-aware and labels carried-forward grades as such, matching the compare screen. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 07:15:33 +01:00
TudorandClaude Fable 5	b31e71ac88	fix(detail): render report cards and date them by the report-card inspection ... The detail views detected report cards via ofsted.framework === 'ReportCard', but the API sets framework to the raw event grouping ('Schools - S5') even for report-card schools — so the check never matched: report-card schools rendered as legacy 'Ofsted Rating' badges dated to a pre-Nov-2025 inspection (e.g. Barclay shown as 'Outstanding, Inspected 7 October 2021' instead of its Feb 2026 report card). Detect report cards by the presence of the report_card object (matching the compare screen), and date them with rc_inspection_date, never the legacy inspection_date. Applies to both primary and secondary detail views. New e2e assertion against a real report-card school gates it. Note: the list/map surface has the same latent issue via ofsted_framework (LeafletMapInner) — flagged as a separate follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 19:09:16 +01:00
TudorandClaude Fable 5	4522cbf645	fix(ui): shorten proposed-to-close notice copy ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-08 22:51:32 +01:00
TudorandClaude Fable 5	45ab479062	feat(ui): mark proposed-to-close schools in listings and detail pages ... Amber tag in listing rows (option A) and a slim notice strip under the detail-page header (option E): proposed for closure, formal process not necessarily started, check with the local authority before applying. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-08 22:05:55 +01:00
TudorandClaude Fable 5	95081d38bd	chore: remove the Ofsted Parent View feature end to end ... Removes the 'What Parents Say' section and all supporting elements: Frontend: - Drop the OfstedParentView type, the parent_view field, the survey section and the 'X% would recommend' callouts in the primary and secondary detail views, the Parents nav item, and the parent-view CSS. Backend: - Remove the FactParentView model, its loading in data_loader, and parent_view from the school-details API response. - Bump SCHEMA_VERSION to 6 and add an idempotent drop step (DROP TABLE IF EXISTS marts.fact_parent_view) to the CLI migration; add scripts/sql/drop_fact_parent_view.sql to apply directly to the dbt-owned marts DBs on staging and prod. Pipeline: - Delete the stg_parent_view + fact_parent_view dbt models and their source/schema entries, the tap-uk-parent-view Meltano extractor, and the monthly Parent View DAG; drop it from the Dockerfile and the staging bootstrap docs. The rest of dbt (which builds every mart the app reads) is untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 09:01:26 +01:00
TudorandClaude Fable 5	192173e515	feat(school-detail): icon-only Compare on phone heroes; unclutter map bottom edge ... On ≤640px the floating Compare button becomes a 40px round glyph (+ / ✓, aria-labelled) like the section-nav compare icon, instead of a full-width text pill over the map. The OSM attribution moves to the map band's top-left in preview so it no longer collides with the school name sliding up under the fade; fullscreen keeps Leaflet's default bottom-right since the zoom control occupies the top-left there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-02 16:17:12 +01:00
TudorandClaude Opus 4.8	cdb2e4cf41	fix(ofsted): link to the school's Ofsted page, not a hardcoded provider type ... The report link hardcoded provider type 21, which 404s for every school whose Ofsted provider type isn't 21 (nurseries -> 20, academies -> 23, etc.). Use Ofsted's URN-based find-inspection-report URL, which redirects to the correct provider page for any school, and rename the link to "Ofsted reports" since it points to the school's Ofsted page (all reports), not one report. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-01 22:26:48 +01:00
TudorandClaude Opus 4.8	d4d9ae5252	feat(school-detail): map-blended hero, remove at-a-glance stats ... Replace the header's at-a-glance stats row with a location map that sits atop the hero and blends into the school title. The map is a static, non-interactive preview (never traps page scroll) with a coral pin; the whole band — or the inline "View on map ↗" link by the address — opens a fullscreen, interactive map. Compare floats glassy over the band. The separate "Location" section (and its nav item) is removed; the map now lives only in the hero. Schools without lat/long render the header with no map band, as before. New: SchoolHeroMap (fullscreen wrapper, forwardRef open handle) + LeafletHeroMapInner (minimal single-school map with interaction toggle). Applied to both primary and secondary detail views; dead heroStats/tone/ mapContainer CSS removed (shared .heroStat* card classes kept). Also drops the orphaned "Latest data" note and does not reintroduce an Ofsted strip in the hero (it would duplicate the Ofsted section directly below). Mockup kept at mockups/header-map-hero.html. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-01 18:12:12 +01:00
TudorandClaude Opus 4.8	14474eccf1	feat(school-detail): move Back to a standalone link, dock "Back to top" in the nav ... Replicate the Autotrader pattern: pull the page-back control out of the sticky section-nav bar and place a standalone "← Back" text link above the header card, on the page background, where it scrolls away with the page. It keeps the context-aware behaviour (router.back → /search fallback); the secondary view gains the same fallback for parity (it previously used a bare router.back() that dead-ends on deep links). The pinned slot the Back button vacated now holds a "↑ Top" control that smooth-scrolls to the top, so the sticky bar keeps a useful affordance. Applies to both primary and secondary detail views. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-01 14:48:17 +01:00
TudorandClaude Opus 4.8	b0639db79e	feat(school-detail): dedupe hero header, drop redundant chip strip ... The hero header rendered the Ofsted signal twice — once as a chip in the strip and again as a tile in the at-a-glance scorecard — and an Oversubscribed chip already covered by the First-choice tile's footnote. Remove the chip strip on both primary and secondary detail views, leaving the scorecard trio (Results · Ofsted · First-choice) as the single home for the headline numbers. Widen the scorecard's render gate to hasHeroStats so a school with an Ofsted rating but no results still shows its Ofsted signal (previously carried by the chip strip). Drop the now-dead .heroChip CSS, keeping the shared .tone-* tokens the scorecard's serif number uses. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-01 12:45:49 +01:00
TudorandClaude Opus 4.8	207e3c631c	fix(school-detail): rename admissions heading to "Admissions" ... "How Hard to Get Into This School" presupposes difficulty, which misleads for the many undersubscribed primaries (e.g. schools offering places to 100% of first-choice applicants). Rename to the neutral "Admissions", matching the secondary page and the section nav label; the demand figures and the "Oversubscribed" chip convey the difficulty where it applies. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lh7Js5xSetKNzLVr9ArXLF	2026-07-01 11:15:54 +01:00
TudorandClaude Opus 4.8	23d7390286	feat(school-detail): reorder sections by parent demand (analytics-led) ... Reorders the detail-page sections so the most-sought content leads, based on 30-day section_nav_used analytics (nav clicks over-count buried sections, so a low, high-demand section is a strong "surface me" signal): Primary: Ofsted → SATs Results → Admissions → Pupils & Inclusion → History → Phonics → What Parents Say → School Life → Location → Local Area → Finances Secondary: Ofsted → GCSEs → Admissions → History → Parents → Wellbeing → Location → Finances Key moves: Admissions (23%, most-clicked) lifted from #6→#3; Pupils & Inclusion (18%) from #7→#4; History (13%) off the bottom. Ofsted stays first (its low click rate is positional — everyone reaches it first). Low-demand context sections (Local Area, Finances) stay last. Brings the primary page in line with secondary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lh7Js5xSetKNzLVr9ArXLF	2026-07-01 09:51:46 +01:00
TudorandClaude Opus 4.8	2fb7faf659	feat(school-detail): mobile section nav becomes a menu; Compare shrinks to an icon ... Fixes the cramped mobile bar where Back, the carried Compare pill and All ▾ all competed with the scrolling section links: - On mobile the horizontal swipe strip collapses into a single "Section: <current> ▾" button that opens the existing jump-to-section sheet — no fragile horizontal swipe, and it doubles as a "you are here" indicator. - The carried Compare CTA becomes a compact 38px icon on mobile (compare-arrows + "add" badge; flips to a teal check when in the comparison), so it no longer crowds the section control. Desktop keeps the labelled pill. - Back is icon-only on mobile (label hidden), text on desktop. - Desktop is unchanged: horizontal links + All ▾, full CTA in the hero. Both the mobile section menu and the desktop All ▾ open the same sheet. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lh7Js5xSetKNzLVr9ArXLF	2026-06-30 23:27:03 +01:00
TudorandClaude Opus 4.8	758f902b66	feat(school-detail): dock section nav, pin Back, carry Compare CTA, add All ▾ menu ... Reworks the sticky section bar on the school detail page so mobile users can perceive the page's breadth and get back to their results without hunting: - Dock the bar directly under the global header (top: 56px mobile / 64px desktop) so it's reachable immediately instead of buried below the tall hero. - Pin "← Back" so it never scrolls off; only the section links scroll, keeping the existing right-edge fade. Back uses router.back() with a /search fallback so deep-links never dead-end. - Carry the hero's "Add to Compare" CTA into the bar as a compact pill once the hero button scrolls out of view, so the conversion action survives. - Add an "All ▾" menu (dropdown on desktop, bottom sheet on mobile) listing every section with the active one ticked — full breadth without horizontal scrolling. Reuses the site's existing pill / coral / edge-fade / sheet vocabulary rather than introducing a new navigation paradigm. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lh7Js5xSetKNzLVr9ArXLF	2026-06-30 22:39:48 +01:00
TudorandClaude Opus 4.8	c40a6a949c	feat(admissions): replace sparse Q&A list with 2×2 stat tiles ... The "How Hard to Get Into This School" this-year view rendered four question/answer rows stretched to fill the trend chart's height, leaving tall gaps and a long horizontal jump from a small muted question to its number. Replace with a 2×2 grid of stat tiles — each number paired with its label directly beneath — so the panel reads quickly and fills the reserved height without artificial spacing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-30 16:07:54 +01:00
TudorandClaude Opus 4.8	368b9f2b59	fix(admissions): render trend with Chart.js instead of scaled SVG ... The hand-rolled SVG sparkline used px font sizes inside a 520-wide viewBox that stretched to the full card width, so labels ballooned ~4x and collided — and with 10+ years of real data the per-point labels and year ticks overlapped badly, while the oversized chart stretched the "this year" view. Replace it with a Chart.js line chart (AdmissionsTrendChart) in a fixed 200px wrapper, matching PerformanceChart: responsive px fonts, auto-skipping x ticks, auto-scaled y-axis clamped to 0-100, emphasised latest point. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-19 18:59:57 +01:00
TudorandClaude Opus 4.8	4de7e559e9	feat(admissions): surface multi-year admissions trend on school detail ... The school detail page only showed the latest admissions year. We store every year, which is more decision-relevant for parents (the trend and its consistency matter more than a single noisy year). Backend now returns the full admissions_history (oldest first) alongside the existing latest-year object. The primary SchoolDetailView gains a header toggle ("This year | N-year trend") that swaps the Q&A for an SVG sparkline of the first-choice offer rate. The toggle only appears when >=2 years carry an offer rate; otherwise it falls back to the single-year card. Both views share one CSS-grid cell so switching causes no layout shift. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-06-19 18:41:03 +01:00
Tudor SitaruandClaude Opus 4.7	62eeee5f7c	perf: cache aggressively and trim client bundle ... Frontend - Dynamic-import Chart.js components on detail/compare views so Chart.js no longer ships in initial JS. - Drop force-dynamic on home, compare, rankings so internal data fetches reuse Next.js's per-call revalidate cache. - Switch /school/[slug] to ISR with a 7-day revalidate window (school data updates annually). - Preconnect to analytics + postcodes.io; remove redundant defer on the Umami Script tag (afterInteractive already covers it). - Bump images.minimumCacheTTL to 1 year. - Extract HowItWorks and Editorial sections as server components passed to HomeView via slot props so their JSX stays out of the client bundle. Backend - Add GZipMiddleware (min 512 bytes). - Add CacheAndETagMiddleware: per-path Cache-Control with long s-maxage + stale-while-revalidate, ETag generation, and 304 on If-None-Match. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-06-02 13:46:45 +01:00
Tudor SitaruandClaude Opus 4.7	7e182e88b2	feat(analytics): typed Umami event taxonomy across the funnel ... Add lib/analytics.ts with a single typed track() wrapper. SSR-safe, never throws, no-ops when Umami isn't loaded. Event names form a fixed union so refactors stay safe. 14 events wired: Discovery (3) search_submitted FilterBar submit + near_me path near_me_used all geolocation outcomes empty_results search returns 0 schools Engagement (5) school_viewed SchoolDetail + Secondary on mount, with urn / phase / local_authority / from section_nav_used section-nav links on both detail views chart_metric_changed mobile chart chip switch metric_compared_in_rankings rankings metric dropdown external_link_clicked Ofsted / school website / DfE (declarative data-umami-event attributes) Conversion (5) compare_school_added search/rankings/detail/compare sources compare_school_removed detail toggle and compare page compare_viewed once per session when there's a selection (school_count, phase_mix) compare_metric_changed compare page metric dropdown compare_shared native sheet vs clipboard distinguished Operational (1) api_error caught in handleResponse, includes endpoint / status / route Suggested Goals to configure in the Umami dashboard for the funnel report: search_submitted → school_viewed → compare_school_added → compare_viewed → compare_shared. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-19 22:04:22 +01:00
Tudor SitaruandClaude Opus 4.7	59f13a74f9	feat(mobile): mobile cleanups for deadlines, result cards, tooltips, ofsted, rankings ... MOB-07: Admissions deadlines strip becomes a horizontal snap-scroller on ≤640px instead of a cramped 2×2 grid (which forced "Secondary · Deadline" track labels down to 9.6px). Cards stay readable, the right edge fades to signal more content past the viewport, .chipTrack font bumped to 0.7rem. MOB-09: Result-card line3 (headline metric + secondary stats) was crowding everything onto one row. Force the first .stat (Attainment 8 / RWM headline) to flex-basis 100% on mobile so delta-vs-LA and pupil count wrap below it with a visible row-gap. Applied to both SchoolRow (primary) and SecondarySchoolRow. MOB-12: MetricTooltip ⓘ icons rendered at ~9px and relied on :hover (which doesn't fire on touch). Hide the whole .wrapper at ≤640px — metric labels themselves carry the meaning. Saves building a tap-to-show layer for now. MOB-13: The "Ofsted pending / No inspection on record" empty state took a full hero card to communicate non-information. Add a data-ofsted-state attribute on the hero chip; on ≤640px, the "none" state collapses to a single muted line. MOB-17: Already had Type+Action columns hidden on rankings mobile — no change needed beyond marking complete. MOB-18: Long metric headers ("Reading, Writing & Maths Combined %") forced the value column wide. Drop .valueHeader to 0.625rem with white-space: normal at ≤640px so labels wrap onto 2 short lines. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-19 09:38:48 +01:00
Tudor SitaruandClaude Opus 4.7	4acfd21883	feat(mobile): section-nav scroll affordance and drop illegible home previews ... MOB-03: The school-detail section nav (SATs / Admissions / Pupils / Location / History) overflows on phones (scrollWidth 462 vs clientWidth 356) with no signal that more tabs exist past the right edge. Add a right-edge mask-image fade at ≤640px, scroll-snap on each link, and bigger tap targets (min-height 36px, padding bumped). A scroll/resize listener toggles an .atEnd class that removes the fade once the user has scrolled to the last tab. MOB-04: The "What you'll see on every school" cards rendered preview visuals (mini cascade chart, Ofsted badge, compare table) with text scaled down to 6–10px — unreadable on a phone. Hide .hiwVisual at ≤640px and let the explanatory text carry each card; tiny visible text count on the home dropped from 51 to 8. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-05-18 15:35:17 +01:00
Tudor SitaruandClaude Opus 4.7	1fb4b3ec5e	refactor(primary): move gender split out of header into Pupils & Inclusion ... Header "Pupils" line reverts to plain inline text matching Headteacher and website weight. Gender split lives in Pupils & Inclusion as a card alongside pupil premium / EAL / SEN support — peers of similar weight. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-17 22:52:59 +01:00
Tudor SitaruandClaude Opus 4.7	675601869b	feat(detail): show pupil gender split on school detail pages ... Upgrades the existing "Pupils" stat to include a compact split bar and percentage hint for mixed schools (single-sex schools already carry a "Boys's/Girls's school" badge, so the split would be redundant). Wires fact_pupil_characteristics into the API: new SQLAlchemy model and a real census block in /api/schools/{urn} replacing the prior null stub. On the primary detail page the inline "Pupils: 241" text is replaced by a richer block (display number + bar + "52% girls · 48% boys"). On the secondary detail page the existing "Total pupils" hero stat card grows the bar and hint beneath the number. Both fall back to the previous text-only rendering when census gender data is missing. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-17 22:36:33 +01:00
Tudor SitaruandClaude Opus 4.6	bfff24fa5f	style(detail): apply hero card style to Pupils & Inclusion ... Renames the RWM-specific .rwmHero* classes to generic .heroStat* and reuses them on the three Pupils & Inclusion headline cards (disadvantaged, EAL, SEN support). Grid switches to auto-fit to accommodate both 2- and 3-card layouts. SEN primary-need breakdown stays on the dense .metricCard style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-14 14:31:31 +01:00
Tudor SitaruandClaude Opus 4.6	34cd8ad26e	style(sats): restyle RWM hero cards to match approved mockup ... Top two combined cards now use a teal-tinted background with a 2.1rem Playfair serif teal value and a compact uppercase label — consistent with the hero treatment shown in the design mockup. Scoped via new .rwmHero* classes so other metric cards on the page keep their existing style. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-14 14:01:45 +01:00
Tudor SitaruandClaude Opus 4.6	045dbc65b7	feat(sats): add "why is combined lower?" bridge between hero and cascade ... Explains the intersection semantics of RWM combined — a pupil is only counted if they met the bar in all three subjects — with a math line showing the per-subject percentages collapsing to the combined figure. Only renders when all four values are present; national-average pill markers on the cascade are untouched. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-14 13:30:11 +01:00
Tudor SitaruandClaude Opus 4.6	35deedcc16	feat(admissions): promote verdict to headline, move above Q&A ... The Oversubscribed badge + "Demand exceeds capacity" text lived at the bottom of the tile as an afterthought. It's the headline finding — a parent should read it first, then let the Q&A supply the detail. Replace the footer badge with a Playfair Display sentence directly under the section title: "This school is oversubscribed." (state word coloured coral for oversubscribed, teal for undersubscribed). The "Demand exceeds capacity" / "Supply meets demand" line sits below as quiet muted text — present for context but not competing with the headline. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-14 11:03:57 +01:00
Tudor SitaruandClaude Opus 4.6	5abab067a1	feat(admissions): replace bar + metric cards with Q&A tile ... The "How Hard to Get Into This School" tile mixed a progress bar (places vs first-choice) with three text metric cards, making the data feel fragmented and hiding the real narrative. The progress bar also broke visually when undersubscribed and didn't scale to different school sizes. Replace with a typographic Q&A list that answers the questions parents actually ask — "How many places were offered?", "How many families wanted this school first?", "How many got their first choice?", "How many applied in total?" — with a verdict footer (Oversubscribed / Not oversubscribed + one-sentence explanation). The third row now uses first_preference_offers (already in the API response) to show "27 of 42 (64.3%)" instead of just the percentage, giving the raw count parents actually want. Each row is independently null-gated; rows stack vertically under 480px so the Playfair numeral stays legible. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-14 10:01:19 +01:00
Tudor SitaruandClaude Opus 4.6	6d685b7e8a	refactor(admissions): rename published_admission_number to places_offered ... The staging model aliased EES's total_number_places_offered column as published_admission_number, but PAN is the school's published capacity (not exposed by EES at school level) — what we actually have is the count of places offered in a given admissions round. The misnomer propagated to the mart, SQLAlchemy model, API response, TS types, and UI copy ("places per year", "(PAN)"). Rename end-to-end and fix the UI labels: - "29 places for 42 first-choice applications" → "29 places offered for 42 first-choice applications" - "Reception/Year 7 places per year" → "Reception/Year 7 places offered" - drop the misleading "(PAN)" suffix in the secondary view Also add a comment in stg_ees_admissions clarifying this is the number of places offered, not PAN. Requires dbt to rebuild fact_admissions (marts are materialized as tables) before the backend can start. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-14 09:45:43 +01:00
Tudor SitaruandClaude Opus 4.6	3bf2e8f262	feat(detail): replace SATs text tables with cascade bar charts, add admissions bar and history accordion ... Redesign the School Details page for better parent comprehension: - New SatsChart component: horizontal cascade bars with ruler scale and national average marker (teal/coral palette matching site theme) - Admissions section: visual progress bar showing 1st-preference demand vs available places, colour-coded by oversubscription status - Historical data: collapse raw year-by-year table behind a disclosure element while keeping the performance line chart always visible - EAL metric: add national average comparison via DeltaChip (backend now includes eal_pct in national averages endpoint) - New formatWithSuppression utility for null/suppressed data handling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-13 21:22:24 +01:00
Tudor SitaruandClaude Sonnet 4.6	a3cfffa4d0	feat: national average reference line now tracks per year on history chart ... Previously the dashed reference line was a flat horizontal at the latest year's national average across all historical data, implying the national figure was constant. Now the backend returns per-year averages in `by_year` and the chart maps each data year to its own national average, so the reference line correctly reflects how the national picture changed over time (including COVID recovery dip/recovery). - backend: /api/national-averages now includes `by_year` list alongside existing `year`/`primary`/`secondary` latest-year snapshot - types: NationalAverages extended with `by_year: NationalAveragesYear[]` - PerformanceChart: accepts `nationalByYear` prop; builds per-year series aligned to school data years, falling back to scalar prop if absent - SchoolDetailView + SecondarySchoolDetailView: pass `nationalAvg.by_year` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-09 13:55:14 +01:00
Tudor SitaruandClaude Sonnet 4.6	e625addc3b	fix(school-detail): move active-section useEffect after navItems declaration ... TypeScript compile error: 'navItems' used before its declaration. The IntersectionObserver useEffect referenced navItems in its dep array but was placed above the navItems const declaration. Move it to just after navItems is built. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-08 15:59:01 +01:00
Tudor SitaruandClaude Sonnet 4.6	536a166b35	feat(school-detail): highlight active section in sticky nav on scroll ... Uses IntersectionObserver on each section element. Multiple thresholds (0, 0.1, 0.25, 0.5, 0.75, 1.0) track the intersection ratio of every section simultaneously; whichever has the highest visible ratio at any moment becomes the active item. rootMargin offsets for the sticky nav height so a section is only considered active once it's genuinely in view beneath the bar. Active link gets .sectionNavLinkActive — coral background + white text, matching the phase tab active style used elsewhere in the product. Observer is cleaned up on unmount. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-08 15:42:20 +01:00
Tudor SitaruandClaude Sonnet 4.6	e72345bad5	refactor(school-detail): remove hero summary, red oversubscribed chip ... - Drop the auto-generated italic summary sentence from the hero — adds little beyond what the chips and stats already convey. - Oversubscribed hero chip: tone-gold → tone-coral so it reads as a warning rather than a neutral highlight. - Remove unused buildSchoolSummary import and .heroSummary CSS. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-08 15:27:03 +01:00
Tudor SitaruandClaude Opus 4.6	dfa8058efc	feat(school-detail): page-wide improvements across 5 sections ... History chart - Strip the redundant school-name title (already the page heading) - Default to 2 visible lines: Reading, Writing & Maths expected % (teal, bold) + Exceeding (gold, lighter); progress score lines hidden by default, togglable via legend - Add dashed national average reference line for RWM (primary) or Attainment 8 (secondary) so the school's trajectory is always in context - Add trend summary chip above the chart computed from the data ("↓ Peaked at 90% (2016/17), currently 70%") - Add COVID footnote when 2019/20 and 2020/21 data is absent Ofsted section - Collapse the four identical "Outstanding / Outstanding / Outstanding / Outstanding" boxes into a single prose line when all sub-grades match the overall verdict; show individual cards only when grades differ SATs sub-metrics - DeltaChip vs national average on Expected level row for Reading, Writing and Maths (national averages already in the API response) Admissions - Fix label: "Year 3 places per year" → "Reception places per year" for primary schools Pupils & Inclusion - DeltaChip + national avg hint on Eligible for pupil premium and Pupils receiving SEN support (both keys present in /api/national-averages) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-08 15:13:13 +01:00
Tudor SitaruandClaude Opus 4.6	1e5c66d6ab	fix(admissions): correct first_preference_offer_pct in dbt staging ... The staging model was mapping EES column ``proportion_1stprefs_v_totaloffers`` straight onto ``first_preference_offer_pct``. That raw column is not a percentage — it is a ratio of first-preference applications to total offers (an oversubscription indicator, >1 means oversubscribed), so OLQH rendered as "1%" when the true first-choice success rate is 27/42 = 64%. The frontend display code is not at fault and is not patched here — data-quality issues must be fixed at the source. - stg_ees_admissions: compute ``first_preference_offer_pct`` as ``100 * number_1st_preference_offers / times_put_as_1st_preference`` — of families who listed this school first, the % that received an offer (0–100). Guard against divide-by-zero. - stg_ees_admissions: expose the legitimate EES ratio as the new column ``oversubscription_ratio`` (1st-preference applications per place) for future use, clearly named. - fact_admissions, FactAdmissions model, data_loader: propagate the new ``oversubscription_ratio`` column. - SchoolAdmissions type: document both columns inline. - buildSchoolSummary: reword the oversubscription clause so it reads sensibly across the whole 0–100 range (no more "just 64%"). - Hero chip subtitle: clearer phrasing "X% of first-choice applicants offered a place". Requires a dbt run of stg_ees_admissions and fact_admissions on deploy so the new column materialises. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-04-08 11:29:40 +01:00