638 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
TudorandClaude Fable 5	3710529e49	fix(api): map blank-name GIAS sentinel codes to empty string, not Unknown ... ReligiousCharacter 99 (~4k schools) and AdmissionsPolicy 9 (~5.6k) carry a code with a blank name in the GIAS CSV; the generator skipped them so they hit the Unknown(<code>) path — wrongly triggering the Faith-priority tag and polluting filters. Blank-only codes now map to "" (byte-identical to the old name pipeline); accepted_values lists extended to match the seed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 22:04:53 +01:00
tudor	159207c6f5	Merge pull request 'fix(pipeline): add the missing backend cache-invalidation step to the data DAGs' (#26) from fix/daily-dag-cache-invalidation into main ... Reviewed-on: #26	2026-07-09 20:41:42 +00:00
TudorandClaude Fable 5	d677b54533	fix(pipeline): cache invalidation for IDACI DAG too; curl timeouts ... Addresses AI-review findings: the annual IDACI DAG also rebuilds a mart (fact_deprivation) and needs the reload; curl gets connect/max timeouts so an unreachable backend fails fast instead of hanging the task. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 21:26:45 +01:00
TudorandClaude Fable 5	c353e36072	fix(pipeline): actually invalidate the backend cache after data rebuilds ... The daily/monthly/annual DAG docstring promised an Invalidate Cache step that never existed — after a marts rebuild the backend kept serving its startup-cached (possibly empty) DataFrame until a container restart. Add a POST /api/admin/reload task at the end of each pipeline DAG, mirroring the sitemap DAG's admin-call pattern. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 21:12:01 +01:00
tudor	d9223a6d6e	Merge pull request 'fix(api): legacy name-column fallback when marts predate the GIAS code migration' (#25) from fix/gias-legacy-fallback into main ... Reviewed-on: #25	2026-07-09 19:13:55 +00:00
TudorandClaude Fable 5	74ca76d150	fix(api): match missing-column fallbacks on the DBAPI error, not the statement ... str(ProgrammingError) embeds the full SQL, which contains every column name — the substring check matched any error and could take the wrong retry branch. Parse the missing column from exc.orig instead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 19:29:58 +01:00
TudorandClaude Fable 5	4b75152ee0	fix(api): fall back to legacy name-column query when marts predate code migration ... Closes the deploy window flagged by CI review — the backend now works against both the old (name) and new (code) mart schemas. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 14:48:06 +01:00
tudor	84dfc6c1bb	Merge pull request 'feat: GIAS classification fields stored as codes, translated in code' (#24) from feat/gias-code-dictionaries into main ... Reviewed-on: #24	2026-07-09 13:32:43 +00:00
TudorandClaude Fable 5	c26755750d	docs: mark GIAS code dictionaries spec implemented ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 14:12:52 +01:00
TudorandClaude Fable 5	254a19eb42	fix(pipeline): run gias_code_names seed + drift test in the daily DAG ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 14:11:31 +01:00
TudorandClaude Fable 5	4f6b2b0edc	feat(pipeline): typesense sync translates GIAS codes before indexing ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 10:51:40 +01:00
TudorandClaude Fable 5	f1a013ec01	feat(api): translate GIAS codes to names at the query boundary ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 10:48:53 +01:00
TudorandClaude Fable 5	fa6c929a3a	feat(pipeline): dim_school/dim_location store GIAS codes; seed drift test ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 10:45:15 +01:00
TudorandClaude Fable 5	d898e6279b	feat(pipeline): ingest GIAS code columns; staging exposes codes not names ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 10:41:52 +01:00
TudorandClaude Fable 5	e188c2ff4b	feat: GIAS code->name dictionaries generated from live bulk CSV ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 10:38:19 +01:00
TudorandClaude Fable 5	08bd86db05	docs: implementation plan for GIAS code dictionaries ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 10:10:26 +01:00
TudorandClaude Fable 5	1ae5762a0a	docs: design spec for GIAS code dictionaries (codes in marts, names in code) ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-09 09:55:53 +01:00
tudor	bc87e56545	Merge pull request 'fix(ui): shorten proposed-to-close notice copy' (#23) from fix/proposed-to-close-copy into main ... Reviewed-on: #23	2026-07-08 21:52:56 +00:00
TudorandClaude Fable 5	4522cbf645	fix(ui): shorten proposed-to-close notice copy ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-08 22:51:32 +01:00
tudor	7370712888	Merge pull request 'feat: include and mark 'Open, but proposed to close' schools' (#22) from feat/proposed-to-close-schools into main ... Reviewed-on: #22	2026-07-08 21:23:23 +00:00
TudorandClaude Fable 5	45ab479062	feat(ui): mark proposed-to-close schools in listings and detail pages ... Amber tag in listing rows (option A) and a slim notice strip under the detail-page header (option E): proposed for closure, formal process not necessarily started, check with the local authority before applying. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-08 22:05:55 +01:00
TudorandClaude Fable 5	6f602f4a9e	feat(api): expose GIAS establishment status on school payloads ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-08 22:05:55 +01:00
TudorandClaude Fable 5	de81e9cdbd	feat(pipeline): include 'Open, but proposed to close' schools in dims ... These schools are still operating and publish results; they drop out automatically when GIAS flips them to Closed since marts fully rebuild each run. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-08 21:54:08 +01:00
tudor	45c68b60b4	Merge pull request 'feat: drive sixth-form separation from GIAS OfficialSixthForm flag' (#21) from feat/gias-sixth-form-flag into main ... Reviewed-on: #21	2026-07-07 13:48:12 +00:00
TudorandClaude Fable 5	f1388ff5bd	fix(pipeline): normalize GIAS OfficialSixthForm comparison with lower(trim()) ... Matches the phase derivation's guard against casing/whitespace variants in raw GIAS data; an unmatched variant previously fell through silently to the statutory-age fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 14:05:10 +01:00
TudorandClaude Fable 5	4d226fd616	test: drop unused fake exception helper ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 13:36:01 +01:00
TudorandClaude Fable 5	a524cdc591	fix(api): survive missing has_sixth_form column and numpy bool serialization ... - data_loader.load_school_data_as_dataframe now catches a ProgrammingError whose message mentions has_sixth_form (psycopg2 UndefinedColumn) and retries with a NULL-AS-has_sixth_form query variant, so the API keeps serving data (and the app.py column-fallback branch stays reachable) even before the nightly pipeline has rebuilt marts.dim_school. - utils.convert_to_native now handles numpy.bool_ so GET /api/schools/{urn} doesn't 500 once has_sixth_form is a populated bool-dtype column. - Update the now-stale comment on the app.py age-range fallback branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 13:33:25 +01:00
TudorandClaude Fable 5	3fcb1340d4	docs: mark sixth-form flag pipeline change implemented ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 10:43:08 +01:00
TudorandClaude Fable 5	0934c8f38c	feat(ui): sixth-form badge, note and filter labels use GIAS flag ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 10:40:42 +01:00
TudorandClaude Fable 5	1d149ffc48	feat(api): drive has_sixth_form filter and payloads from GIAS flag ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 10:36:39 +01:00
TudorandClaude Fable 5	d11faefebd	feat(pipeline): derive dim_school.has_sixth_form from GIAS flag ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 10:30:39 +01:00
TudorandClaude Fable 5	3b35849bb3	feat(pipeline): ingest GIAS OfficialSixthForm into staging ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 10:28:08 +01:00
TudorandClaude Fable 5	87f4c6dd40	docs: implementation plan for GIAS sixth-form flag ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 10:21:02 +01:00
TudorandClaude Fable 5	0309b27c84	docs: exam results phase taxonomy and sixth-form separation spec ... Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-07 10:02:21 +01:00
tudor	85484a80c4	Merge pull request 'fix(api): school detail 500s for schools with no performance rows' (#20) from fix/school-detail-nan-500 into main ... Reviewed-on: #20	2026-07-07 08:56:23 +00:00
TudorandClaude Opus 4.8	536832a524	chore: drop committed .pyc files, ignore __pycache__ everywhere ... Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-07 09:37:17 +01:00
TudorandClaude Opus 4.8	87642b7b06	fix(api): serialize schools that have no performance rows ... Schools without KS2/KS4 results (special post-16 institutions, sixth-form centres, PRUs, new schools) come back from the marts LEFT JOIN with NaN in every numeric column. school_info passed those raw pandas values straight into JSONResponse, which renders with allow_nan=False, so the detail endpoint 500d and the frontend turned that into a 404 on every such SEO landing page. Run school_info values through convert_to_native (the same treatment yearly_data already gets), add backend unit tests plus a pytest step in PR checks, and an e2e journey that finds a results-less school via the search API and asserts its page renders. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-07 09:22:54 +01:00
tudor	929748d014	Merge pull request 'feat(home): move "use my location" beside the hero search box' (#19) from feat/near-me-by-search into main ... Reviewed-on: #19	2026-07-06 17:56:58 +00:00
TudorandClaude Opus 4.8	4e8df006d7	feat(home): move "use my location" beside the hero search box ... The geolocation shortcut lived in the discovery strip below the results, away from the search. Move it directly under the hero search input, paired with the postcode hint, so the two ways to find nearby schools ("type a postcode" / "use my location") read as one idea and are visible at first glance. - FilterBar gains optional onNearMe/geoState/geoError props and renders the teal "Use my location" pill (with spinner + error) in hero mode; the geolocation flow itself still lives in HomeView. - Remove the now-duplicate near-me button and its dead CSS from the discovery section. - Refresh the search hint copy to pair with the button. - e2e: assert the "use my location" shortcut renders in the hero. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-06 17:01:45 +01:00
tudor	1f8284adfc	Merge pull request 'fix(map): results map fullscreen falls back to an overlay on iOS' (#18) from fix/results-map-ios-fullscreen into main ... Reviewed-on: #18	2026-07-06 13:33:16 +00:00
TudorandClaude Fable 5	b2dc4d0779	fix(map): results map fullscreen falls back to an overlay on iOS ... The results-view map's fullscreen button called requestFullscreen(), which iOS Safari doesn't implement (fullscreen is video-only there), so tapping it did nothing on iPhones — the same gap already fixed for the school hero map. When the Fullscreen API is missing or its promise rejects, fall back to a fixed-position overlay (.fsFallback, z-index 5000) driven by state, locking body scroll while open. Leaflet re-measures on window resize, so dispatch a resize when fullscreen toggles (the CSS overlay fires none) or the map would fill only part of the screen. Native fullscreen is unchanged. New e2e journey deletes Element.requestFullscreen on a mobile viewport, opens the results map fullscreen, and asserts the exit control appears then releases; it fails against current production, reproducing the bug. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 14:09:37 +01:00
tudor	1cdcd85e41	Merge pull request 'fix(search): stop the mobile sort dropdown overflowing the viewport' (#17) from fix/mobile-sort-select-overflow into main ... Reviewed-on: #17	2026-07-06 12:46:48 +00:00
TudorandClaude Fable 5	a00cbe9161	fix(search): stop the mobile sort dropdown overflowing the viewport ... On a location search the results header shows the view toggle and the sort <select> side by side. The select sizes to its widest option ('Highest Reading, Writing & Maths %', ~273px), so on a phone its right edge ran ~46px past the viewport and was clipped off-screen. On mobile let the select flex into the remaining space with min-width:0 so its label truncates instead of overflowing, and keep the view toggle from shrinking. Verified live at 390px: the select now sits fully within the viewport. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 13:23:29 +01:00
tudor	64121592fd	Merge pull request 'feat(compare): lay mobile chart chips two per row' (#16) from feat/compare-chips-two-per-row into main ... Reviewed-on: #16	2026-07-06 12:16:26 +00:00
TudorandClaude Fable 5	6828f6cd44	feat(compare): lay mobile chart chips two per row ... The mobile chart legend stacked one school chip per line, so up to five schools pushed the chart down and left the plot cramped. Switch the chip row to a two-column grid; each chip fills its column and truncates its name with an ellipsis (full names remain on the school cards and in the tooltip). Five schools now take three rows instead of five, giving the chart noticeably more height. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 12:17:41 +01:00
tudor	331ae8d89f	Merge pull request 'fix(e2e): compare-chips test must compare schools in one phase' (#15) from fix/e2e-compare-chips-phase into main ... Reviewed-on: #15	2026-07-06 11:01:22 +00:00
TudorandClaude Fable 5	3adea73ee0	fix(e2e): compare-chips test must use schools in one phase ... The test picked the first two /school/ links from a 'primary' search and asserted exactly two mobile chips. But a 'primary' search can return all-through schools (e.g. 'Hessle High School and Penshurst Primary') that classify as secondary, so the two picks can split across phases — the active phase then holds one school and the chips are correctly gated out (they need ≥2 in the active phase), while the canvas still shows one line. That's a test artefact, not a bug. Pick three schools instead: across two phases the auto-selected majority phase always holds ≥2, so the chip legend is guaranteed. Assert ≥2 chips (the majority may be 2 or 3). Verified against staging. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 11:42:11 +01:00
tudor	47335fcda0	Merge pull request 'fix(frontend): proxy /api and /sitemap.xml at runtime, not via baked rewrites' (#14) from fix/runtime-api-proxy into main ... Reviewed-on: #14	2026-07-06 10:11:39 +00:00
TudorandClaude Fable 5	95a5783da1	fix(frontend): proxy /api and /sitemap.xml at runtime, not via baked rewrites ... next.config.js rewrites() bakes its destination into the build (routes-manifest.json), capturing FASTAPI_URL at build time. Because one frontend image is promoted staging->prod, the baked backend host forced every environment to name the backend service identically; staging names it 'backend_stg', so the browser's /api/* calls proxied to the baked 'http://backend' and failed with getaddrinfo ENOTFOUND backend. (SSR was unaffected because lib/api.ts reads FASTAPI_URL at runtime.) Replace the rewrites with route handlers that read FASTAPI_URL per request: - app/api/[...path]/route.ts — transparent proxy for all methods, streams the response, strips hop-by-hop headers, and returns 502 on upstream failure instead of crashing. - app/sitemap.xml/route.ts — proxies the backend sitemap (robots.ts points crawlers here). The same promoted image now adapts to whatever the backend is called in each environment. Verified: production build succeeds with /api/[...path] and /sitemap.xml as dynamic routes and an empty rewrites manifest. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>	2026-07-06 10:00:42 +01:00
tudor	5c39131b50	Merge pull request 'chore: remove the Ofsted Parent View feature end to end' (#13) from chore/remove-parent-view into main ... Reviewed-on: #13	2026-07-06 08:31:00 +00:00