240 Commits

Include renames

Author	SHA1	Message	Date
TudorandClaude Opus 5	803e68970c	refactor(detail): drop dead derived state from the shell ... Leftover from the mechanical extraction: the shell still called computeSchoolFlags() and derived isReportCard / ofstedInspectedDate / oeifAreas / oeifAllSameGrade / deprivationDesc / primaryAvg / secondaryAvg on every render, duplicating work page.tsx already does. None of those values were referenced in its JSX anymore -- that logic moved to the section composers. The chrome needs only four locally-derived values (latestResults, phase, isAllThrough, hasLocation), all one-liners over props it already owns. Removing them made seven props dead, which TypeScript caught at both call sites: absenceData, ofsted, admissions, admissionsHistory, deprivation, finance and nationalAvg now go straight to the section composers and never reach the client component. The shell's surface is down to schoolInfo, yearlyData, census, navItems and children. No behaviour change: 155 tests pass and the characterization tests remain byte-identical to the commit that introduced them. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-02 21:54:59 +01:00
TudorandClaude Opus 5	752eb07310	refactor(detail): render sections on the server behind a client shell ... page.tsx now composes the sections and passes them through SchoolDetailShell as children, so ~1,300 lines of static markup stop shipping as client JavaScript. The shell keeps what is genuinely interactive: back link, header reveal, hero map, compare CTA, sticky nav and scroll-spy. The scroll-spy already located sections via document.getElementById, so it works unchanged against server-rendered children. Charts needed a client wrapper: next/dynamic with ssr:false is illegal in a Server Component, so components/school/charts.tsx is the boundary that keeps Chart.js (64 KB gz) lazy and browser-only. Measured on this build: - school route client chunk: 8 KB gz (33 KB raw) - total static JS across all chunks: 380.6 -> 350.7 KB gz - section markup is absent from every client chunk ("Got their first choice", "Ofsted reports", "Most deprived" etc. all return 0 hits); shell strings still present, as expected - shared baseline unchanged at 172 KB gz -- out of scope, as designed The 14 characterization tests pass byte-identical to the commit that introduced them. Only the render helper changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-02 21:39:21 +01:00
TudorandClaude Opus 5	a7f6ff4035	refactor(detail): extract sections as server components ... Moves ~1,300 lines of section markup out of the two client views into components/school/, mirroring the components/compare/ layout. Twelve section components plus shared primitives, all server components. The only client file is AdmissionsViewToggle, which owns the hidden/aria-pressed state and receives both views as server-rendered children. JSX was extracted mechanically rather than retyped, so the markup the CSS modules depend on is verbatim. Sharing follows measured similarity, not assumption: - Finances (91%) shared. The secondary premises-cost card is gated behind a prop so primary pages are unchanged; enabling it is a one-line follow-up. - Ofsted (80%) shared, but behind a variant prop. The headline similarity hid a real fork: on a school with no overall grade the primary page shows a "Not rated" badge while the secondary shows a four-area OEIF panel, and the disclaimer copy differs. Both preserved exactly; reconciling them is a human decision, not a side effect of a move. - Admissions (14%) and History (40%) kept separate. Not yet wired up -- the old views still render. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-02 21:33:28 +01:00
TudorandClaude Opus 5	2f786787b9	style(detail): merge the two detail stylesheets ... Builds components/school/schoolSections.module.css from the primary module, plus 35 secondary-only rules, so shared section components have one stylesheet. Three categories of difference, handled separately so nothing changes visually: - 7 incidental-drift properties unioned in (overflow-wrap, word-break, min-width, user-select) -- fixes that landed on one page and were never back-ported. Also fixes latent long-school-name overflow on the page that lacked them. - 4 genuinely visual class differences kept as explicit variants: genderBar, heroStatValue, genderSplitBoys, genderSplitGirls. font-weight on the genderSplit pair was reclassified from drift to visual -- unioning it would have bolded the primary page. - 17 rules that exist only in the secondary stylesheet but target shared class names (.card, .sectionTitle, .metricCard). Applied flat these would restyle the primary page, so they are scoped under .secondaryScope, which only SecondarySchoolSections will carry. Audited: every rule in both original stylesheets is a subset of the merged one (0 MISSING, 0 LOST), excluding the documented variants. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-01 21:18:15 +01:00
TudorandClaude Opus 5	5044c24895	refactor(detail): extract derived flags and nav items to lib ... Pure data-shape logic moves out of the client components so page.tsx can compute the section list on the server without importing them. The secondary page is not a variant of the primary one -- different section ids (gcse, wellbeing), different flags, and History gated on more than one year rather than at least one -- so it gets its own computeSecondaryFlags and buildSecondaryNavItems rather than bending a shared function. Adds 16 unit tests covering the all-through and special-school branches, previously reachable only through a full component render. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-01 21:14:35 +01:00
TudorandClaude Opus 5	d74cc95034	refactor(detail): fetch national averages on the server ... Both detail views fetched /api/national-averages in a useEffect, so the England-comparison deltas popped in after hydration and every section that uses them was pinned to the client. The page now fetches it in parallel with the school details (backend-cached 1h, degrades to null) and passes it down. Removes one client round-trip per detail page and unblocks the section extraction. Characterization tests pass unmodified; only the render helper changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>	2026-08-01 21:11:08 +01:00
TudorandClaude Opus 4.8	96d5fcf5b0	feat(detail): move religious character into header details + mobile reveal ... Religious character now sits with the other labelled header details (near County / Constituency) as "Religious character: <denomination>" ("None" for Does not apply / None), instead of as an identity chip. On mobile/tablet (≤768px) the header details block was hidden outright; it's now collapsed behind a "Show all details" toggle that reveals the full block (headteacher, website, pupils, trust, phone, religious character, county, constituency). Applied to both the primary and secondary detail views for parity. Extends the e2e journey with the mobile toggle behaviour. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-24 12:24:16 +01:00
tudor	8cf2ac47c1	Merge pull request 'feat(detail): surface GIAS identity/contact details, drop unwired sections' (#82) from feat/detail-gias-fields-remove-unwired into main ... Reviewed-on: #82	2026-07-24 10:56:34 +00:00
TudorandClaude Opus 4.8	684da611ff	feat(detail): always show religious character, "None" for no religious character ... Previously the chip was hidden for "Does not apply"/"None". Show it in all cases, rendering "None" for those two sentinel values. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-24 09:24:27 +01:00
TudorandClaude Opus 4.8	0186227ced	feat(detail): surface GIAS identity/contact details, drop unwired sections ... Add seven school-identity fields to the detail header (both primary and secondary views): age range, religious character, nursery and sixth-form indicators as chips; telephone (tel: link), county and parliamentary constituency as header details. religious_denomination, age_range and has_sixth_form were already served; telephone, nursery_provision, county and parliamentary_constituency are newly wired through the marts query (with a NULL fallback for un-rebuilt marts, mirroring has_sixth_form) and the school_info API response. Remove three UI sections the backend never populated (always null): Year 1 Phonics, the SEN "types of additional needs" breakdown, and the average class-size card — along with their now-dead props, route plumbing, and the SenDetail/Phonics types + class_size_avg field. Extend the e2e detail journey to assert the Phonics section is gone and the new header fields render when the record carries them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-24 09:23:08 +01:00
TudorandClaude Opus 4.8	84bca53c7e	refactor(compare): row-label help uses InfoPopover, not native title ... Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-22 15:38:25 +01:00
TudorandClaude Opus 4.8	15b7493b85	refactor(ui): MetricTooltip delegates to InfoPopover (circled ? glyph) ... Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-22 15:37:33 +01:00
TudorandClaude Opus 4.8	1d9d2eb5ae	feat(ui): add InfoPopover — viewport-aware metric help via Floating UI ... Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-22 15:36:23 +01:00
TudorandClaude Opus 4.8	32f8a02862	fix(detail): give Results Over Time chart more height on desktop ... The trend chart was capped at 280px tall on desktop, squishing the lines together and making them hard to read. Raise the base .chartContainer height to 380px in both the primary and secondary detail views. Mobile is unaffected: the base value is already overridden to height:auto by the existing max-width:768px query, where PerformanceChart's own .chartWrapper carries the canvas height. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 22:05:10 +01:00
TudorandClaude Opus 4.8	8a9ba30cc2	fix(detail): compare each SATs bar to its own national benchmark ... The KS2 SATs chart drew a single national-average line spanning the full height of each subject's chart area, positioned at the national *expected* value. But the area stacks two bars — Expected and Exceeding — and the higher-standard/greater-depth national is a very different, much lower figure (e.g. reading higher standard ~29% vs expected ~75%). So the line crossed the Exceeding bar at the wrong place, making every school's exceeding result look far below national when it wasn't. The per-subject higher-standard nationals were already computed in the fact_ks2_national_averages mart; they just weren't serialized. Fix: - backend: add reading_high_pct, writing_gd_pct (writing = greater depth) and maths_high_pct to the national-averages payload. - SchoolDetailView: pass a nationalExceedingPct per subject, mapping writing to the greater-depth figure. - SatsChart: replace the single full-height line with a national marker on each bar's own track (coral tick + "nat X%" in the bar header), so Expected and Exceeding each sit against the correct benchmark. KS2 only; the secondary Attainment 8 chart already uses one line for one measure and is untouched. Verified: tsc --noEmit, next build, and backend pytest (national averages marts, incl. a new test guarding the per-subject nationals). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 14:55:43 +01:00
TudorandClaude Opus 4.8	15da060e4a	feat(admissions): surface easy-to-miss deadlines as callout boxes ... The selective-school registration and faith-school SIF warnings were added as prose in the criteria steps, where they read as ordinary sentences and were easy to skim past. Pulled them into structured callout boxes with an amber "note" treatment (using the page's own gold accent tokens), a warning glyph, and a bold lead-in — so the two deadlines parents most often miss actually stand out. - Added a `callouts` field to Step; render as a callout group between the body and the tool link (both primary and secondary timelines). - Reverted the warning text back out of the step bodies so it isn't duplicated. Verified with tsc --noEmit and next build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 12:22:49 +01:00
TudorandClaude Opus 4.8	a5b2296240	fix(rankings,admissions): correct accuracy issues from education audit ... Follow-up audit of the rankings and admissions pages. Admissions (AdmissionsView.tsx): - National Offer Day no longer claims offers publish "from 12:01 am"; release times are set per-council (often late afternoon, some overnight), so it now tells parents to check their council's page. - Secondary preference count no longer states a flat "up to six" (that's London/Pan-London); most LAs allow three to six. Mirrors the hedge the primary step already used. - Added the two deadlines that most often catch parents out: selective schools' separate entrance-test registration (months earlier), and faith schools' supplementary information form sent direct to the school. Covered in both the primary and secondary criteria steps. - Reworded the equal-preference tip so it's precise: order is the tie-break among schools you qualify for (you get the highest-ranked one), not irrelevant. Rankings (RankingsView.tsx): - Subtitle "Top-performing schools by X" -> "Schools ranked by X", so it isn't nonsensical for context/equity/absence metrics. - KS2 progress isn't published for 2023/24 or 2024/25 (no KS1 baseline). Selecting a primary progress metric on a recent year used to dead-end on a generic "No rankings found". Added a scoped caveat to the progress hint and an explanatory empty-state (primary only — secondary Progress 8 is published). Added an admissions smoke journey (static content, stable milestones). Verified with tsc --noEmit and next build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 12:08:50 +01:00
TudorandClaude Opus 4.8	22e9eb2d48	fix(home): make Att8 bar match its numbers and separate safeguarding ... Two internal-consistency fixes on the "What you'll see" mock: - The Attainment 8 bar had drifted from the numbers beside it (fill 68% / line 57% vs a 54.8 score and 45.9 national avg). Restored the mock's original 1:1 value-to-percent mapping: fill 54.8%, national line 45.9%. - The report card grouped "Safeguarding: Met" in the same five-point list as the graded areas, but safeguarding is a separate binary met/not-met judgement under the real framework. Moved it below the list behind a divider, with an outlined chip and a "separate check" label so it no longer reads as a graded area. Verified with tsc --noEmit and next build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 10:01:10 +01:00
TudorandClaude Opus 4.8	13253116c2	fix(home): correct remaining KS2/Ofsted terminology on the landing page ... Follow-up to the accuracy pass — the medium-severity wording issues from the same expert review: - KS2 "Exceeding" isn't a DfE term. The above-expected level is the "higher standard" for the reading and maths tests and "greater depth" for teacher-assessed writing. Labelled per subject, and brought the illustrative reading value down from an implausible 73% (national higher standard is ~29%) to a realistic strong-school figure. - Attributed inspection outcomes to Ofsted, not only the DfE (Ofsted is a separate non-ministerial department). - Hero: "2026/2027 admissions results" -> "the 2026/27 admissions round" (admissions produce offers, not results, and we don't hold per-school offer outcomes). Tightened .miniRowHead so the longer "Greater depth" label stays on one line and the three subject columns keep their bars aligned (the visual is desktop-only; hidden on mobile). Verified with tsc --noEmit and next build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 09:07:23 +01:00
TudorandClaude Opus 4.8	1b8adb91ee	fix(home): correct education/Ofsted claims on the landing page ... Homepage marketing content had drifted from both the current education regime and the app's own school pages. An expert accuracy review surfaced five issues (3 critical, 2 high): - Ofsted card showed a single "OUTSTANDING" word-grade. Overall grades were abolished (Sept 2024) and inspections now produce a report card on a five-point scale (from Nov 2025). Rebuilt the card as a report card with per-area ratings + stand-alone safeguarding, matching what CompareOfsted actually renders on a school page. - Attainment 8 "National avg 50.2" was wrong; the real 2024/25 figure is 45.9. Corrected the benchmark and the illustrative school value. - Compare mock featured a KS2 "Reading progress" score, but KS2 progress isn't published for 2023/24 or 2024/25 (no post-COVID KS1 baseline). Swapped for Higher standard (RWM), which is published. - Editorial called it "UK school performance data"; the data is England-only. Now matches the hero and page metadata. - Softened the "40-page inspection report" exaggeration. Landing-page copy isn't covered by e2e journeys, so no test changes. Verified with tsc --noEmit and next build. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-21 09:00:02 +01:00
TudorandClaude Opus 4.8	261403bcd2	fix(detail): let the special-school note span the full container width ... Drop the note's `max-width: 72ch`, which left it stopping well short of the section's right edge. It now fills the results-section container like the subtitle paragraph above it. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 22:49:11 +01:00
tudor	e4c8b86fe7	Merge pull request 'fix(detail): align Ofsted Report Card grade chips' (#71) from fix/report-card-chip-alignment into main ... Reviewed-on: #71	2026-07-20 21:32:45 +00:00
TudorandClaude Opus 4.8	1c1df77961	fix(detail): align Ofsted Report Card grade chips ... The grade boxes rendered inconsistently: Safeguarding "Met" was a small 0.8125rem inline pill while grade values ("Strong") were 1.25rem full-width chips, and because category labels wrap to one or two lines each value sat at a different vertical position. Two-line values like "Expected standard" also produced a taller box. Add a scoped `.gradeGrid` modifier (Report Card + OEIF grids in both the primary and secondary detail views) that reserves two label lines so every chip shares a baseline, and gives all value chips one font size, padding and min-height — long text wraps inside an equal-height chip via max-width:100%. Scoped rather than touching the shared `.metricCard`/`.metricValue` used by the finance, phonics and admissions sections. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 22:31:58 +01:00
tudor	993822d769	Merge pull request 'fix: don’t portray special schools as failing the mainstream benchmark' (#70) from fix/special-schools-not-failing into main ... Reviewed-on: #70	2026-07-20 21:14:57 +00:00
TudorandClaude Opus 4.8	0b36eace9d	fix(review): accurate PRU/AP copy, unbundle same-school trend, de-dupe note CSS ... Three review points on the special-schools change: 1. Copy accuracy — the context note said "Its pupils have special educational needs" for every isSpecialSchool() match, but the helper also matches pupil referral units and alternative provision, whose pupils are educated outside a mainstream setting (e.g. after exclusion) and are not necessarily SEND. Extracted a shared <SpecialSchoolNote> with type-aware copy: SEND wording only for genuine special schools; PRUs/AP get their own accurate wording. 2. Same-school trend was conflated with the England comparison — SchoolRow's year-over-year trend arrow (and the school's own figure) were gated on the same flag that drops the vs-England delta, hiding a still-meaningful trend for special schools with real data. Split the two: the school's OWN RWM figure + trend show whenever there's a real value (special schools included; only a placeholder all-zero row is hidden); only the vs-England delta is additionally dropped for special/PRU/AP. Mirrored in SecondarySchoolRow (own Attainment 8 shown; only the vs-LA delta dropped). 3. De-duplicated the .specialNote CSS (was copy-pasted between the two detail view module files) into SpecialSchoolNote.module.css, owned by the shared component so it can't drift. New SpecialSchoolNote unit tests assert SEND wording for special schools and NOT for PRUs/AP. tsc clean; 112/112 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 22:09:32 +01:00
TudorandClaude Opus 4.8	de943ded19	fix(review): don't suppress a genuine mainstream 0 in the rows ... Review feedback: the rankings/search rows treated any exactly-0 attainment as not comparable regardless of school type, so a genuine 0 at a mainstream school rendered as "—" (looks like missing data) and dropped its delta — stricter and inconsistent with SchoolDetailView's placeholder check. - SchoolRow: match SchoolDetailView's ks2Placeholder signature — suppress only when ALL of RWM + reading + writing + maths are 0 (special/suppressed signature), not on a bare rwm === 0. A genuine 0% combined (some pupils met individual subjects but not all three) is not all-zero, so it stays comparable and shows its real figure + trend. - SecondarySchoolRow: Attainment 8 is a single 0–80 score with no subject breakdown to form an all-zero signature, so key off establishment type only (drop the bare att8 === 0 guard). A genuine (if extreme) 0.0 shows its value + LA delta. - For consistency, apply the same to the detail views: drop the bare attainment_8_score === 0 guard (KS4 keys off isSpecial only); KS2 keeps the all-four-subjects-zero placeholder signature. Special schools / PRUs / AP are still handled via isSpecialSchool everywhere. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 21:58:13 +01:00
TudorandClaude Opus 4.8	ae6ef6860b	fix: don't portray special schools as failing the mainstream benchmark ... Special schools, PRUs and alternative provision teach pupils with SEND who sit the same KS2/KS4 assessments but very few reach the mainstream "expected standard". Their headline attainment is therefore ~0% (or a very low Attainment 8), and the site was comparing that to the England average and painting it red — e.g. Greenmead School (a community special school) rendered as "0.0% — −62 pts below England average" with three 0% red SATs bars. That portrays a special school as catastrophically failing against a benchmark that doesn't fit it. Add a shared `isSpecialSchool()` helper (detects every DfE special-school establishment type — all contain "special" — plus PRUs / alternative provision) and drop the mainstream England comparison + "below" framing for these schools across every surface: - Detail (primary + secondary): a plain-English context note explaining the school is special and why the comparison isn't shown; England-average delta chips, "England avg" hints, the SATs national markers, the Attainment-8 "vs national" bar and the trend chart's England overlay are all suppressed. An all-zero placeholder SATs row hides the (empty) subject bar chart and the "why is combined lower" bridge. - Rankings / search rows (primary + secondary): the mainstream RWM / Attainment 8 stat shows "—" with no "vs national" delta, instead of "0% · −62 vs national". - Compare: special schools' attainment values are dropped (no misleading dot at 0% / no "Below England average" chip); progress banding, which IS a fair measure for special schools, is kept. Belt-and-braces zero-guard: a whole-row zero attainment (special or a suppressed cohort) is also treated as not-comparable, while a legitimate single 0 (e.g. 0% exceeding at a mainstream school) stays comparable. Tests: new isSpecialSchool unit tests (every DfE special type matched, no mainstream false positives); an e2e journey asserts Greenmead shows the special-school note and no England-average comparison. tsc clean; 108/108 unit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 20:39:16 +01:00
TudorandClaude Opus 4.8	733faefb98	fix(detail): label which phase all-through admissions figures cover (Batch F) ... Final Ofsted/education-expert review of the detail page (Batch F) found one clarity gap: on an all-through school the Admissions block shows a single entry point's figures (Hessle's are the Year 7 secondary intake — admissions.school_phase = "Secondary") but is titled just "Admissions", so a parent interested in the reception/primary intake could read the Year 7 numbers as the whole school. Add a phase subtitle for all-through schools ("These figures are for secondary entry (Year 7)." / "...primary entry (Reception)."). Pure-primary and pure-secondary pages are unambiguous and unchanged. Rest of the review verified correct against source payloads: all three Ofsted regimes (report card / ungraded post-Sept-2024 / carried-forward), England- average anchoring, gap-honest trend charts (KS2 + KS4), all-through dual-phase rendering, and the mobile layout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 17:13:37 +01:00
TudorandClaude Opus 4.8	f6bb037c47	fix(detail): render both phases for all-through schools (Batch E) ... Batch E of applying the compare-screen learnings to the school detail page — all-through handling (point 11). An all-through school carries both KS2 and KS4 figures in the same yearly rows, but SchoolDetailView flipped it to isSecondary and rendered GCSE-only, hiding the entire primary phase (SATs, phonics, KS2 trend). The Results snapshot already gated its KS2/KS4 blocks purely on data availability, so both already appeared there — but the section title, the trend chart, phonics, the nav label and the history table all still assumed a single phase. - Add an explicit `isAllThrough` flag (+ `showPrimaryContent = isPrimary || isAllThrough`); pure-secondary behaviour is unchanged. - Hero: an "All-through (primary & secondary)" meta chip for all-ages framing. - Results section: title "SATs & GCSE Results", a combined subtitle, and "Primary — KS2 SATs (Year 6)" / "Secondary — GCSEs (Year 11)" sub-headings separating the two blocks. - Results Over Time: render two stacked PerformanceCharts (KS2 SATs + GCSEs) rather than crowding both stages' series — on different scales with different gap stories — onto one axis. Each gets its correct England overlay. - Phonics section + nav item now show for all-through (primary-stage metric). - History table: an all-through column set covering both phases (RWM, Exceeding, Attainment 8, Progress 8, Eng & Maths 4+). - Nav "Results" label for all-through instead of "GCSEs". e2e: a new journey asserts an all-through school (Hessle, 137306) shows both the KS2 and KS4 results and the All-through label, with a data-driven precondition skip if staging data drifts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:53:07 +01:00
tudor	9c93c3d9c2	Merge pull request 'fix(detail): gap-honest year axis on the detail-page trend charts (Batch D)' (#67) from fix/detail-chart-truthfulness into main ... Reviewed-on: #67	2026-07-20 11:42:48 +00:00
TudorandClaude Opus 4.8	17bd4d5a5e	fix(detail): gap-honest year axis on the detail-page trend charts (Batch D) ... Applies the compare screen's chart-truthfulness rules (spec §8.1) to the school detail page's time-series charts. PerformanceChart (Results Over Time, both phases): - Fill every academic year between the first and last data point via the shared fillAcademicYears helper, so cancelled/unpublished years (2019/20, 2020/21, and — for KS2 — 2021/22) render as real gaps instead of compressed time. Each series and the England overlay map onto this filled axis with null for missing years; spanGaps:false so school lines never bridge a gap. - Replace the primary-only COVID note with a distinct, honest gap caption: KS2 names the cancelled tests plus the unpublished 2021/22 school-level year; KS4 names the unpublished 2019/20–2020/21 GCSE grading years. - Mobile x-axis switches to autoSkip so the longer (gap-honest) axis stays readable; the broken line still marks a missing year even when its tick label is skipped. AdmissionsTrendChart: - Same gap-honest axis + spanGaps:false so a missing admissions year is a real gap, not compressed time. Point 12 (definite canvas heights): desktop is already a definite 280px; fix the secondary detail's mobile .chartContainer, which fixed the outer box at 220px and double-constrained PerformanceChart's own 220px canvas + chip strip (clipping the chips onto the plot) — now height:auto to match the primary view. SatsChart is out of scope (single-year per-subject CSS bars — no year axis, no canvas height to constrain). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:19:37 +01:00
TudorandClaude Fable 5	4e6be0ce65	fix(detail): banded first-choice interpretation + plain-English P8 absence copy ... Batch C (points 7-10): - Point 7: the admissions section shows the first-choice offer rate but no sense of how severe a low rate is. Reuse the compare screen's banded summariseAdmissions ('More than half of first choices missed out' etc.) as an interpretive line under the tiles. (Selective/faith framing was already present via admissionsTag.) - Point 8: replace the jargon P8-suspended banner ('not used for accountability purposes ... treat with caution') with the compare screen's plain-English 'no KS2 baseline (COVID)' explanation. - Points 9 (disadvantaged cohort sizes) and 10 (FSM benchmark) don't apply to the detail page: it shows disadvantaged composition, not disadvantaged attainment, and no FSM-vs-benchmark comparison — so there's no small-cohort caveat or cross-definition fallback to fix here. - Also fixed a stray lowercase 'national avg' provenance string Batch B missed. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 12:03:23 +01:00
tudor	452ec77449	Merge pull request 'fix(detail): 'England average' provenance labelling (Batch B)' (#65) from fix/detail-provenance-anchoring into main ... Reviewed-on: #65	2026-07-20 07:52:55 +00:00
TudorandClaude Fable 5	e36125b24a	fix(detail): label official DfE figures as 'England average' (provenance) ... Batch B (points 5-6): the detail page called every national figure a 'National avg'. All of them come from the official-DfE national-averages marts (KS2/KS4 headlines), so they are England averages — relabel to match the compare screen's provenance convention ('England average' for official figures; the detail page has no computed benchmarks, so no 'state-school average (computed)' label is needed). Point 6 (anchoring every number) is already satisfied on the detail page via DeltaChip. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 07:19:22 +01:00
TudorandClaude Fable 5	fdda52ff0a	fix(detail): filter Ofsted sentinel codes, show sixth-form judgement, label carried-forward grades ... Batch A of applying compare-screen learnings to the detail page (points 2-3): - Point 2: the legacy OEIF sub-judgement grid rendered any non-null value via OFSTED_LABELS[value], so Ofsted's sentinel code 9 ('not applicable') leaked as an undefined label, and the sixth-form judgement was dropped entirely. New shared ofstedLegacyAreas() helper returns only real grades (1-4) and includes Sixth Form provision. Both detail views + the all-same-grade check use it. - Point 3: the OEIF disclaimer always claimed 'Ofsted no longer makes an overall judgement' even when showing a carried-forward grade. It's now grade_source-aware and labels carried-forward grades as such, matching the compare screen. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-20 07:15:33 +01:00
TudorandClaude Fable 5	5ec4f3f7cd	fix(list/map): badge report-card schools as Report Card, not their carried-forward grade ... The search-result cards and map pins keyed report-card detection off ofsted_framework === 'ReportCard', but the API sets ofsted_framework to the raw event grouping ('Schools - S5'); worse, ofsted_grade (the carried-forward legacy grade) was checked first and won. So report-card schools were badged by their old grade — Barclay's pin/card read 'Outstanding · 2021' instead of 'Report Card · 2026'. Same root cause as the detail-page fix, different surface. Expose ofsted_rc_date on the list serialization (the report-card inspection date, non-null only for report cards) and make both badge builders treat a present rc-date as winning over any grade, using its year. Removes the dead framework === 'ReportCard' branches. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 21:14:57 +01:00
TudorandClaude Fable 5	b31e71ac88	fix(detail): render report cards and date them by the report-card inspection ... The detail views detected report cards via ofsted.framework === 'ReportCard', but the API sets framework to the raw event grouping ('Schools - S5') even for report-card schools — so the check never matched: report-card schools rendered as legacy 'Ofsted Rating' badges dated to a pre-Nov-2025 inspection (e.g. Barclay shown as 'Outstanding, Inspected 7 October 2021' instead of its Feb 2026 report card). Detect report cards by the presence of the report_card object (matching the compare screen), and date them with rc_inspection_date, never the legacy inspection_date. Applies to both primary and secondary detail views. New e2e assertion against a real report-card school gates it. Note: the list/map surface has the same latent issue via ofsted_framework (LeafletMapInner) — flagged as a separate follow-up. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 19:09:16 +01:00
TudorandClaude Fable 5	3e77057567	style(compare): shorten Ofsted link text to 'Ofsted page' ... The link repeated the full school name ('Watford Grammar School for Boys's Ofsted page') — long on mobile, and the colour-coded school name already leads the row. Show just 'Ofsted page →'; keep the full name in aria-label so screen readers can still tell the per-school links apart. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 15:19:41 +01:00
TudorandClaude Fable 5	dc21e80a5e	style(compare): enlarge the per-school name label in mobile section cards ... The colour-coded school name that leads each row in a mobile measure card was 0.8rem — a touch small to scan which school a value belongs to. Bump to 0.9rem (with a matching 10px dot) so it's easier to read. Mobile only; desktop uses the column header and hides this label. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 15:06:18 +01:00
TudorandClaude Fable 5	b0c5b6bb57	fix(compare): anchor grade-5 & EBacc rows; restore secondary-button outline ... SF1 (expert sign-off): the secondary academics 'Grade 5+ in English & maths' and 'EBacc entry' rows rendered as bare numbers — the one place the 'every number anchored against the England average' promise broke. Both now show the official England anchor (already in the payload) + an Above/Close/Below verdict chip, matching Attainment 8 (which also gains a chip for consistency). Button affordance: globals.css has a duplicate .btn block whose 'border: none' overrode the base '1px solid transparent', so .btn-secondary/.btn-active's 'border-color' had no width — every outline button (the modal's '+ Compare', search-result '+ Compare', 'Comparing') rendered as borderless teal text. Give the outline variants the full 'border' shorthand so the outline renders regardless of the clobbered base. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 08:26:59 +01:00
TudorandClaude Fable 5	2fd997bfe6	fix(compare): keep the add-school sheet above the on-screen keyboard ... The bottom-sheet overlay was position:fixed inset:0, sized to the LAYOUT viewport, so when the mobile keyboard opened it kept full height: the sheet (anchored to the overlay's bottom) and the lower half of the dim backdrop sat behind the keyboard, hiding the search input and results. Track window.visualViewport (height + offsetTop) while the modal is open and pin the overlay to the visible region, so backdrop and sheet stay above the keyboard. Size the sheet against the overlay (max-height:100%, min-height:min(55vh,100%)) instead of vh, and drop the results list's own inner scroll on mobile so the sheet is a single scroll area. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-18 08:00:31 +01:00
TudorandClaude Fable 5	e5f7f4c959	fix(compare): repair the mobile add-school modal ... The 'add school' modal passed no title to Modal, so its header held only the close button — shoved to the far left by justify-content:space-between in an otherwise-empty bar — while the real title was rendered separately inside the content. Pass the title to Modal so the header reads title (left) + close (right), and drop the duplicate in-content heading. Also: the mobile full-width result button targeted a dead .addButton selector (the button never had that class), so it rendered inconsistently — give the button a real module class and full width on mobile, tighten the stacked cards, and give the bottom sheet a stable min-height so its empty state isn't a tiny stub. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 23:02:12 +01:00
TudorandClaude Fable 5	60918da483	fix(compare): give the trend chart its own definite canvas height so the gap note can't squash it ... The chart note (and the 2-row mobile chip legend) lived inside the fixed 360px/420px chartBox and competed with the canvas for it, so a longer caption — e.g. the new KS4 gap note — shrank the mobile canvas to ~178px and tripped the e2e >220px guard. The canvas now owns a definite height (280px mobile / 380px desktop) with chips above and the note flowing below at natural size, so neither can eat the plot. Verified on staging: patched canvas renders 280px vs the squashed 178px. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 22:58:35 +01:00
TudorandClaude Fable 5	200a97d0b9	fix(compare): per-school P8 explanation; disadvantaged cohort from the same yearly row ... Review findings: (1) the 'no KS2 baseline (COVID)' explanation was derived from the basket-wide max year, so a school with an unrelated data gap borrowed it from a neighbour with 2024/25 data — now judged per school on its own latest year. (2) The '~N disadvantaged pupils' cohort multiplied eligible_pupils and disadvantaged_pct resolved independently across years — now both come from the same yearly row that supplies the displayed percentage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 17:53:10 +01:00
TudorandClaude Fable 5	f3fa12806b	fix(compare): expert should-fixes S1-S4, S6 — banded chips, P8 reason, KS4 gap caption, all-through framing, cohort sizes ... S1: first-choice chip banded (More than half / About 1 in 3 / Over 1 in 4 missed out) so a 44%-offered grammar isn't understated by half. S2: Progress 8 explains its absence for 2024/25+ cohorts (no KS2 baseline, COVID) instead of a bare 'No data'. S3: KS4 trend charts get their own honest gap caption (2019/20-2020/21 unpublished; later years not in our dataset yet); y-axis 'Value'→'Score'; buildCompareChart exposes englandOnlyYears. S4: all-through schools labelled in chips, rail caption says 'N schools · <phase> view' for mixed baskets, whole-school roll no longer judged against the single-phase median, community section carries an all-ages caveat. S6 (spec §8.5): disadvantaged attainment shows the cohort behind it ('of ~50 disadvantaged pupils'). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 17:41:12 +01:00
TudorandClaude Fable 5	5944d88f0b	fix(compare): expert sign-off must-fixes — phase-matched admissions, Ofsted sentinel codes, selective-school copy ... M1: admissions rounds are now selected by the active phase tab (admissionsForPhase) — an all-through school's Year 7 round no longer masquerades as Reception odds beside pure primaries; honest per-cell and section fallbacks name the round (Reception / Year 7). M2: Ofsted sentinel codes (9 = not applicable) never render as judgement chips, and the sixth-form judgement — previously dropped — now renders for schools that have one. M3: 'What this means' is phase- and type-aware: selective schools get entrance-test framing, secondary faith schools a faith-criteria note, and the primaries' distance template never appears on the secondary tab (admissions_policy now exposed in compare school_info). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 12:40:42 +01:00
TudorandClaude Fable 5	80176cac4d	fix(compare): drop the merge-on-fetch — cancellation alone fixes the race ... Review finding: merging left a re-added school's old entry in the map forever, so the covered check served stale data and the map grew unboundedly. The cancelled flag already discards superseded responses, which is the actual race fix; replacing keeps the map bounded to the current selection and guarantees fresh refetches. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 07:27:10 +01:00
TudorandClaude Fable 5	84baf95f68	fix(compare): stale basket fetch no longer blanks a freshly opened comparison ... Opening a compare link while localStorage held a different basket raced a fetch for the OLD school set against the URL's SSR data; the stale response replaced comparisonData, so no active school had data and every section (including the trends chart) vanished until a hard refresh. Responses from superseded effect runs are now dropped, successful ones merge instead of replace, and the URL-seed effect re-runs when a client-side navigation changes ?urns=. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-17 07:16:04 +01:00
TudorandClaude Fable 5	99b769ca9e	feat(compare): fill the sticky bar's label rail with a comparison caption ... 'COMPARING / 3 primary schools' — 0.72rem uppercase eyebrow over a 0.95rem semibold count, sized to sit alongside the 0.92rem chip names without dominating. Desktop only; mobile pills unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 21:27:25 +01:00
TudorandClaude Fable 5	8e0b730629	fix(compare): align sticky school chips with their data columns on desktop ... The bar was a plain flex row while sections use a 200px-label + per-school grid, so chips drifted off the columns they label. The bar now shares the sections' grid template (via --school-count) at the same 761px breakpoint; verified pixel-exact against live section columns (236/615/994). Mobile pills unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0146VHeLAWjDVE2B5uU67jCB	2026-07-16 21:05:16 +01:00