refactor(school-detail): remove hero summary, red oversubscribed chip
Build and Push Docker Images / Build Backend (FastAPI) (push) Successful in 12s
Build and Push Docker Images / Build Frontend (Next.js) (push) Successful in 47s
Build and Push Docker Images / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 12s
Build and Push Docker Images / Trigger Portainer Update (push) Successful in 1s

- Drop the auto-generated italic summary sentence from the hero — adds
  little beyond what the chips and stats already convey.
- Oversubscribed hero chip: tone-gold → tone-coral so it reads as a
  warning rather than a neutral highlight.
- Remove unused buildSchoolSummary import and .heroSummary CSS.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Tudor Sitaru
2026-04-08 15:27:03 +01:00
parent dfa8058efc
commit e72345bad5
2 changed files with 2 additions and 16 deletions
@@ -858,16 +858,6 @@
color: var(--text-muted, #8a847a);
}
/* ── Hero summary sentence (B1) ──────────────────────────────────────── */
.heroSummary {
margin: 1.5rem 0 0;
font-family: var(--font-playfair), 'Playfair Display', serif;
font-size: clamp(1.0625rem, 1.6vw, 1.25rem);
font-style: italic;
line-height: 1.5;
color: var(--text-primary, #1a1612);
}
.heroDataNote {
margin: 0.5rem 0 0;
font-size: 0.75rem;
+2 -6
View File
@@ -19,7 +19,7 @@ import type {
} from '@/lib/types';
import {
formatPercentage, formatProgress, formatAcademicYear,
buildOfstedHeroChip, buildSchoolSummary,
buildOfstedHeroChip,
} from '@/lib/utils';
import { DeltaChip } from './DeltaChip';
import styles from './SchoolDetailView.module.css';
@@ -153,7 +153,6 @@ export function SchoolDetailView({
// ── Hero: framework-aware signal chip + narrative summary ─────────────
const ofstedHeroChip = buildOfstedHeroChip(ofsted);
const heroSummary = buildSchoolSummary(schoolInfo, ofsted, admissions, latestResults);
// KS2 headline numbers for the at-a-glance row
const heroRwm = isPrimary ? latestResults?.rwm_expected_pct ?? null : null;
@@ -235,7 +234,7 @@ export function SchoolDetailView({
</div>
{admissions?.oversubscribed && (
<div className={`${styles.heroChip} ${styles['tone-gold']}`}>
<div className={`${styles.heroChip} ${styles['tone-coral']}`}>
<div className={styles.heroChipTitle}>Oversubscribed</div>
<div className={styles.heroChipSub}>
{admissions.first_preference_offer_pct != null
@@ -302,9 +301,6 @@ export function SchoolDetailView({
</div>
)}
{heroSummary && (
<p className={styles.heroSummary}>{heroSummary}</p>
)}
{heroAcademicYear && (
<p className={styles.heroDataNote}>
Latest data: {heroAcademicYear}