fix(ui): round admission percentages, fix mobile overflow on detail pages
All checks were successful
Build and Push Docker Images / Build Backend (FastAPI) (push) Successful in 32s
Build and Push Docker Images / Build Frontend (Next.js) (push) Successful in 1m6s
Build and Push Docker Images / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 32s
Build and Push Docker Images / Trigger Portainer Update (push) Successful in 1s

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-29 11:22:13 +01:00
parent 77a0f5b674
commit e2c700fcfc
3 changed files with 106 additions and 3 deletions

View File

@@ -673,7 +673,7 @@ export function SchoolDetailView({
{admissions.first_preference_offer_pct != null && ( {admissions.first_preference_offer_pct != null && (
<div className={styles.metricCard}> <div className={styles.metricCard}>
<div className={styles.metricLabel}>Families who got their first-choice</div> <div className={styles.metricLabel}>Families who got their first-choice</div>
<div className={styles.metricValue}>{admissions.first_preference_offer_pct}%</div> <div className={styles.metricValue}>{formatPercentage(admissions.first_preference_offer_pct)}</div>
</div> </div>
)} )}
</div> </div>

View File

@@ -2,6 +2,7 @@
.container { .container {
width: 100%; width: 100%;
overflow-x: hidden;
} }
/* ── Header ──────────────────────────────────────────── */ /* ── Header ──────────────────────────────────────────── */
@@ -32,6 +33,7 @@
margin-bottom: 0.5rem; margin-bottom: 0.5rem;
line-height: 1.2; line-height: 1.2;
font-family: var(--font-playfair), 'Playfair Display', serif; font-family: var(--font-playfair), 'Playfair Display', serif;
overflow-wrap: break-word;
} }
.badges { .badges {
@@ -63,6 +65,7 @@
font-size: 0.875rem; font-size: 0.875rem;
color: var(--text-muted, #8a847a); color: var(--text-muted, #8a847a);
margin: 0 0 0.75rem; margin: 0 0 0.75rem;
overflow-wrap: break-word;
} }
.headerDetails { .headerDetails {
@@ -245,6 +248,8 @@
align-items: center; align-items: center;
gap: 0.375rem; gap: 0.375rem;
flex-wrap: wrap; flex-wrap: wrap;
overflow-wrap: break-word;
min-width: 0;
} }
.sectionTitle::before { .sectionTitle::before {
@@ -325,6 +330,8 @@
align-items: center; align-items: center;
justify-content: center; justify-content: center;
gap: 0.25rem; gap: 0.25rem;
overflow-wrap: break-word;
word-break: break-word;
} }
.metricHint { .metricHint {
@@ -672,6 +679,10 @@
/* ── Responsive ──────────────────────────────────────── */ /* ── Responsive ──────────────────────────────────────── */
@media (max-width: 768px) { @media (max-width: 768px) {
.header {
padding: 1rem;
}
.headerContent { .headerContent {
flex-direction: column; flex-direction: column;
gap: 1rem; gap: 1rem;
@@ -688,9 +699,101 @@
.schoolName { .schoolName {
font-size: 1.25rem; font-size: 1.25rem;
word-break: break-word;
}
.badges {
gap: 0.25rem;
}
.badge {
font-size: 0.75rem;
padding: 0.1rem 0.375rem;
}
.headerDetails {
flex-direction: column;
gap: 0.375rem;
}
.metricsGrid {
grid-template-columns: repeat(2, 1fr);
}
.metricValue {
font-size: 1rem;
}
.chartContainer {
height: 220px;
}
.dataTable {
font-size: 0.75rem;
}
.dataTable th,
.dataTable td {
padding: 0.5rem 0.375rem;
}
.card {
padding: 1rem;
}
.sectionTitle {
font-size: 1rem;
} }
.parentViewLabel { .parentViewLabel {
flex-basis: 10rem; flex-basis: 10rem;
} }
.ofstedReportLink {
margin-left: 0;
display: block;
margin-top: 0.25rem;
}
.admissionsTypeBadge {
font-size: 0.75rem;
}
}
@media (max-width: 480px) {
.parentViewRow {
flex-direction: column;
align-items: flex-start;
gap: 0.25rem;
}
.parentViewLabel {
flex: none;
max-width: 100%;
}
.parentViewBar {
width: 100%;
}
.parentViewPct {
flex: none;
}
.metricsGrid {
grid-template-columns: 1fr 1fr;
gap: 0.5rem;
}
.metricCard {
padding: 0.5rem;
}
.metricLabel {
font-size: 0.625rem;
}
.card {
padding: 0.75rem;
}
} }

View File

@@ -329,7 +329,7 @@ export function SecondarySchoolDetailView({
{admissions.first_preference_offer_pct != null && ( {admissions.first_preference_offer_pct != null && (
<div className={styles.metricCard}> <div className={styles.metricCard}>
<div className={styles.metricLabel}>1st choice offer rate</div> <div className={styles.metricLabel}>1st choice offer rate</div>
<div className={styles.metricValue}>{admissions.first_preference_offer_pct}%</div> <div className={styles.metricValue}>{formatPercentage(admissions.first_preference_offer_pct)}</div>
</div> </div>
)} )}
</div> </div>
@@ -611,7 +611,7 @@ export function SecondarySchoolDetailView({
{admissions.first_preference_offer_pct != null && ( {admissions.first_preference_offer_pct != null && (
<div className={styles.metricCard}> <div className={styles.metricCard}>
<div className={styles.metricLabel}>Families who got their first choice</div> <div className={styles.metricLabel}>Families who got their first choice</div>
<div className={styles.metricValue}>{admissions.first_preference_offer_pct}%</div> <div className={styles.metricValue}>{formatPercentage(admissions.first_preference_offer_pct)}</div>
</div> </div>
)} )}
</div> </div>