fix(startup): stop re-migrating on every container restart
All checks were successful
Build and Push Docker Images / Build Backend (FastAPI) (push) Successful in 48s
Build and Push Docker Images / Build Frontend (Next.js) (push) Successful in 1m13s
Build and Push Docker Images / Build Integrator (push) Successful in 58s
Build and Push Docker Images / Build Kestra Init (push) Successful in 35s
Build and Push Docker Images / Trigger Portainer Update (push) Successful in 1s

Two issues caused the backend to drop and reimport school data on restart:

1. schema_version table was in the drop list inside run_full_migration(),
   so after any migration the breadcrumb was destroyed and the next
   restart would see no version → re-trigger migration
2. Schema version was set after migration, so a crash mid-migration
   left no version → infinite re-migration loop

Fix: remove schema_version from the drop list, and set the version
before running migration so crashes don't cause loops.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-25 10:57:01 +00:00
parent ce470ca342
commit d1d994c1a2
2 changed files with 8 additions and 7 deletions

View File

@@ -128,17 +128,17 @@ def check_and_migrate_if_needed():
print("Running full migration...") print("Running full migration...")
try: try:
# Set schema version BEFORE migration so a crash mid-migration
# doesn't cause an infinite re-migration loop on every restart.
init_db()
set_db_schema_version(SCHEMA_VERSION)
success = run_full_migration(geocode=False) success = run_full_migration(geocode=False)
if success: if success:
# Ensure schema_version table exists before writing print(f"Migration complete. Schema version {SCHEMA_VERSION}.")
init_db()
set_db_schema_version(SCHEMA_VERSION)
print(f"Migration complete. Schema version set to {SCHEMA_VERSION}")
else: else:
print("Warning: Migration completed but no data was imported.") print("Warning: Migration completed but no data was imported.")
init_db()
set_db_schema_version(SCHEMA_VERSION)
except Exception as e: except Exception as e:
print(f"FATAL: Migration failed: {e}") print(f"FATAL: Migration failed: {e}")

View File

@@ -431,7 +431,8 @@ def run_full_migration(geocode: bool = False) -> bool:
# Only drop the core KS2 tables — leave supplementary tables (ofsted, census, # Only drop the core KS2 tables — leave supplementary tables (ofsted, census,
# finance, etc.) intact so a reimport doesn't wipe integrator-populated data. # finance, etc.) intact so a reimport doesn't wipe integrator-populated data.
ks2_tables = ["school_results", "schools", "schema_version"] # schema_version is NOT dropped: it persists so restarts don't re-trigger migration.
ks2_tables = ["school_results", "schools"]
print(f"Dropping core tables: {ks2_tables} ...") print(f"Dropping core tables: {ks2_tables} ...")
inspector = __import__("sqlalchemy").inspect(engine) inspector = __import__("sqlalchemy").inspect(engine)
existing = set(inspector.get_table_names()) existing = set(inspector.get_table_names())