tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'School name cutoff fix' (#43) from fix/compare-mockup-drift into main
Stage (build -> staging -> E2E gate) / Build Backend (FastAPI) (push) Successful in 13s
Details
Stage (build -> staging -> E2E gate) / Build Frontend (Next.js) (push) Successful in 50s
Details
Stage (build -> staging -> E2E gate) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 13s
Details
Stage (build -> staging -> E2E gate) / Deploy to Staging (push) Successful in 1s
Details
Stage (build -> staging -> E2E gate) / E2E Journeys against Staging (push) Successful in 44s
Details

Browse Source 
Reviewed-on: #43
This commit was merged in pull request #43.
This commit is contained in:
tudor
2026-07-15 08:01:47 +00:00
parent 19b41b6999 f579630fab
commit cf458fe05c
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nextjs-app/components/compare/compareSections.module.css
+11 -8
View File
@@ -55,24 +55,27 @@
.cell { .cell {
display: flex; display: flex;
align-items: center; align-items: baseline;
gap: 0.5rem; gap: 0.35rem 0.5rem;
flex-wrap: wrap; flex-wrap: wrap;
padding: 0.45rem 0; padding: 0.5rem 0;
border-top: 1px solid var(--border-light); border-top: 1px solid var(--border-light);
margin-top: 0.45rem; margin-top: 0.5rem;
font-size: 0.95rem; font-size: 0.95rem;
} }
/* The school name gets its own full-width line above the value — real
school names are long and varied, so a fixed-width name column truncated
them ("Our Lady Queen of H…") or crowded the value. */
.cellTag { .cellTag {
display: inline-flex; display: inline-flex;
align-items: center; align-items: center;
gap: 0.4rem; gap: 0.4rem;
width: 5rem; flex-basis: 100%;
flex: none;
font-size: 0.8rem; font-size: 0.8rem;
font-weight: 600; font-weight: 600;
color: var(--sc, var(--text-secondary)); color: var(--sc, var(--text-secondary));
margin-bottom: 0.15rem;
} }
.cellDot { .cellDot {
@@ -92,10 +95,9 @@
.small { .small {
display: block; display: block;
flex-basis: 100%; flex-basis: 100%;
padding-left: 5.5rem;
font-size: 0.8rem; font-size: 0.8rem;
color: var(--text-muted); color: var(--text-muted);
margin-top: -0.05rem; margin-top: 0;
} }
.chip { .chip {
@@ -187,6 +189,7 @@
display: flex; display: flex;
gap: 0.3rem; gap: 0.3rem;
flex-wrap: wrap; flex-wrap: wrap;
flex-basis: 100%;
margin-top: 0.3rem; margin-top: 0.3rem;
} }
nextjs-app/lib/utils.ts
+1 -1
View File
@@ -65,7 +65,7 @@ export function truncate(text: string, maxLength: number): string {
* "Barclay", "St Mary's Catholic Primary School" → "St Mary's". Falls back to * "Barclay", "St Mary's Catholic Primary School" → "St Mary's". Falls back to
* a length-capped truncation for names that don't carry a type suffix. * a length-capped truncation for names that don't carry a type suffix.
*/ */
export function shortName(name: string, maxLength = 20): string { export function shortName(name: string, maxLength = 32): string {
let s = name let s = name
.replace( .replace(
/\s+(primary|junior|infant|nursery|community|foundation|catholic|academy|school|college)\b.*$/i, /\s+(primary|junior|infant|nursery|community|foundation|catholic|academy|school|college)\b.*$/i,