tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request 'fix(compare): trends chart was squashed to ~150px — give it a real height' (#41) from fix/trends-chart-height into main
Stage (build -> staging -> E2E gate) / Build Backend (FastAPI) (push) Successful in 13s
Details
Stage (build -> staging -> E2E gate) / Build Frontend (Next.js) (push) Successful in 52s
Details
Stage (build -> staging -> E2E gate) / Build Pipeline (Meltano + dbt + Airflow) (push) Successful in 13s
Details
Stage (build -> staging -> E2E gate) / Deploy to Staging (push) Successful in 1s
Details
Stage (build -> staging -> E2E gate) / E2E Journeys against Staging (push) Successful in 38s
Details

Browse Source 
Reviewed-on: #41
This commit was merged in pull request #41.
This commit is contained in:
tudor
2026-07-14 22:51:04 +00:00
parent 0c7ad0f309 e4565e9f15
commit b89fa47ec5
2 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e/tests/journeys.spec.ts
+6 -1
View File
@@ -228,7 +228,12 @@ test('compare chart on mobile shows school chips with tap-to-focus', async ({ pa
expect(bodyOverflowsX).toBe(false);
// The trends chart still renders (inside the Explore trends section)…
await expect(page.locator('canvas:visible').first()).toBeVisible({ timeout: 15_000 });
const chartCanvas = page.locator('canvas:visible').first();
await expect(chartCanvas).toBeVisible({ timeout: 15_000 });
// …at a real height, not the squashed ~150px Chart.js fallback that
// appears when the container lacks a definite height.
const chartBox = await chartCanvas.boundingBox();
expect(chartBox && chartBox.height).toBeGreaterThan(220);
// …with the mobile chart legend chips and tap-to-focus behaviour intact.
const chipGroup = page.getByRole('group', { name: /highlight a school/i });