tudor/school_compare
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(design): keep below/attention off the brand hue, harden the share-card fonts
PR Checks / Frontend Typecheck + Tests (pull_request) Successful in 1m2s
Details
PR Checks / Backend Smoke (pull_request) Successful in 7s
Details
PR Checks / Build Backend (no push) (pull_request) Successful in 11s
Details
PR Checks / Build Frontend (no push) (pull_request) Successful in 49s
Details
PR Checks / Build Pipeline (no push) (pull_request) Successful in 10s
Details
PR Checks / AI Code Review (Claude) (pull_request) Failing after 1m8s
Details

Browse Source 
Review follow-up on #86.

The blind coral -> brand rename recreated the exact collision this PR set out
to remove: coral had been both the primary CTA and the "below average" signal,
so every negative indicator followed --primary onto iris. Sixteen rules moved
back onto the status ramp — delta chips, trend-down arrows, progress-negative
values, statusBad, chipBad/badgeBad, and the urgent deadline chips.

The Ofsted scale had also lost its worst step, with grade 4 landing on brand
while 1-2 were teal and 3 was amber. It now escalates by weight rather than by
reaching for another hue: a tinted amber chip for "requires improvement", a
solid amber one for "inadequate" (5.1:1 light, 7.7:1 dark). Report-card grade 5
follows the same rule.

globals.css now describes status as valence — teal above/good, amber
below/needs-attention — which is what it has to mean for an urgent deadline,
rather than the narrower "comparison point only" the first draft claimed.

On the share-card fonts: /opengraph-image is prerendered, so the font read
happens in the builder stage where assets/ exists, and the baked PNG ships
inside .next/standalone/.next/server/app/. File tracing independently places
the fonts at .next/standalone/assets, which the existing standalone COPY
carries to /app/assets. So the reported ENOENT doesn't occur — but it depends
on the tracer resolving a runtime join(), and a miss would be a silent 500
rather than a build failure. Declared outputFileTracingIncludes for the route
and made the Dockerfile COPY explicit so neither is left to inference.

Also repointed the immutable Cache-Control rule from the deleted favicon.svg
to app/icon.svg, where it was caching a 404.

Verified: tsc clean, 159/159 tests, clean rebuild prerenders all three image
routes with the fonts present in standalone.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
Tudor
2026-08-06 12:29:53 +01:00
co-authored by Claude Opus 5
parent 8ab0ac0a04
commit 8c3a5cc4e9
13 changed files with 51 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
nextjs-app/components/school/schoolSections.module.css
+7 -7
View File
@@ -860,7 +860,7 @@
}
.progressNegative {
color: var(--brand-strong);
color: var(--status-below);
font-weight: 700;
}
@@ -876,8 +876,8 @@
}
.statusBad {
background: var(--brand-bg);
color: var(--brand-strong);
background: var(--status-below-bg);
color: var(--status-below);
}
/* Charts Section */
@@ -1025,8 +1025,8 @@
color: var(--status-below);
}
.ofstedGrade4 {
background: var(--brand-bg);
color: var(--brand-strong);
background: var(--status-below);
color: var(--text-inverse);
}
/* Report Card grade colours (5-level scale, lower = better) */
@@ -1047,8 +1047,8 @@
color: var(--status-below);
} /* Needs attention */
.rcGrade5 {
background: var(--brand-bg);
color: var(--brand-strong);
background: var(--status-below);
color: var(--text-inverse);
} /* Urgent improvement */
/* Safeguarding value (used inside a standard metricCard) */