refactor(admissions): rename published_admission_number to places_offered · 6d685b7e8a - school_compare

refactor(admissions): rename published_admission_number to places_offered

Build and Push Docker Images / Build Backend (FastAPI) (push) Successful in 18s

Details

Build and Push Docker Images / Build Frontend (Next.js) (push) Successful in 46s

Details

Build and Push Docker Images / Build Pipeline (Meltano + dbt + Airflow) (push) Failing after 13s

Details

Build and Push Docker Images / Trigger Portainer Update (push) Has been skipped

Details

The staging model aliased EES's total_number_places_offered column as
published_admission_number, but PAN is the school's published capacity
(not exposed by EES at school level) — what we actually have is the
count of places offered in a given admissions round. The misnomer
propagated to the mart, SQLAlchemy model, API response, TS types, and
UI copy ("places per year", "(PAN)").

Rename end-to-end and fix the UI labels:
  - "29 places for 42 first-choice applications"
      → "29 places offered for 42 first-choice applications"
  - "Reception/Year 7 places per year"
      → "Reception/Year 7 places offered"
  - drop the misleading "(PAN)" suffix in the secondary view

Also add a comment in stg_ees_admissions clarifying this is the number
of places offered, not PAN. Requires dbt to rebuild fact_admissions
(marts are materialized as tables) before the backend can start.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

This commit is contained in:

Tudor Sitaru

2026-04-14 09:45:43 +01:00

parent 24ba65c829

commit 6d685b7e8a

7 changed files with 19 additions and 14 deletions

									
										pipeline/transform/models/marts/fact_admissions.sql
									
		+1
		-1
	
												View File
												
				@@ -4,7 +4,7 @@ select

				    urn,

				    year,

				    school_phase,

				    published_admission_number,

				    places_offered,

				    total_applications,

				    first_preference_applications,

				    first_preference_offers,